RFR: Store checks should run most of the time

Roman Kennke rkennke at redhat.com
Mon Sep 18 11:33:30 UTC 2017


Looks good. Except
- Use the bitfield evac check? The field in SH is likely to go away soon .

I can check+fix aarch64

Am 18. September 2017 13:06:51 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>http://cr.openjdk.java.net/~shade/shenandoah/store-check-cm-ur/webrev.02/
>
>Current store check code is wrong at least for x86: it checks
>ShenandoahUpdateRefsEarly which is
>ccstr coerced to the bool. Also, it has to actually check for both CM
>and UR flags, not choosing one
>statically. After Roman's change that makes storeval barriers
>unconditional, we can actually only
>check for EVAC in progress, and thus cover most of the stores most of
>the time.
>
>Did AArch64 change blindly.
>
>Testing: hotspot_gc_shenandoah, simple jcstress with
>-XX:+ShenandoahStoreCheck
>
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


More information about the shenandoah-dev mailing list