RFR: Refactoring GC phase and heap allocation tracking out of policy
Aleksey Shipilev
shade at redhat.com
Mon Sep 25 16:32:05 UTC 2017
On 09/25/2017 05:15 PM, Zhengyu Gu wrote:
> On 09/23/2017 06:50 AM, Aleksey Shipilev wrote:
>> On 09/23/2017 02:59 AM, Zhengyu Gu wrote:
>>> Refactoring GC phase timing tracking and heap allocation tracking out of ShenandoahCollectorPolicy.
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/prof_refactor/webrev.00/index.html
>>
>> I like it!
>>
>> Would be interesting to try and conditionalize timing gathering on gc+stats. It seems wasteful to
>> poll timers when we don't consume the data. Does not have to be in this patch though, but maybe the
>> change should have that work in mind.
>
> Our heuristics need timing feed also.
Yes, but we can split it out.
> http://cr.openjdk.java.net/~zgu/shenandoah/prof_refactor/webrev.01/
Looks good to me. You will collide with my committed change in
ShenandoahConcurrentThread::do_partial_cycle, sorry.
Under our new rules, this has to wait for anyone else to chime in.
-Aleksey
More information about the shenandoah-dev
mailing list