RFR: Adapt upstream object pinning API

Zhengyu Gu zgu at redhat.com
Wed Apr 4 17:52:22 UTC 2018



On 04/04/2018 01:49 PM, Roman Kennke wrote:
> Am 04.04.2018 um 19:39 schrieb Zhengyu Gu:
>> On 04/04/2018 01:33 PM, Roman Kennke wrote:
>>> Am 04.04.2018 um 19:02 schrieb Zhengyu Gu:
>>>> Adapted upstream object pinning API, also made adjustment to critical
>>>> native support to use new API.
>>>>
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/pin_interface/webrev.00/
>>>>
>>>> Test:
>>>>
>>>>     hotspot_gc_shenandoah on Linux x64 and Windows x64 (release +
>>>> fastdebug)
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
>>> I was about to merge from upstream jdk/jdk in the next few days. Maybe
>>> that would get it in anyway?
>>
>> Yes, it will work. I did this for testing, to make sure that it actually
>> works.
>>
>> I withdraw this patch.
> 
> We should consider this. Critical pinning with upstream API depends on
> JDK-8200429 which is in jdk/hs but not yet jdk/jdk. I usually only merge
> from jdk/jdk. It may take a little while until we get it through regular
> means. You can also cherry pick this if you like.

Just be aware that we already has critical native pinning code in 
Shenandoah with different API, merge from upstream won't be clean merge.

Thanks,

-Zhengyu

> 
> Roman
> 
> 


More information about the shenandoah-dev mailing list