RFR: Missing oopDesc::equals after the merge
Aleksey Shipilev
shade at redhat.com
Tue Apr 10 19:34:58 UTC 2018
On 04/10/2018 08:53 PM, Roman Kennke wrote:
> Am 10.04.2018 um 20:31 schrieb Aleksey Shipilev:
>> diff -r eea1ad783a6a src/hotspot/share/classfile/classLoaderData.cpp
>> --- a/src/hotspot/share/classfile/classLoaderData.cpp Tue Apr 10 17:38:36 2018 +0200
>> +++ b/src/hotspot/share/classfile/classLoaderData.cpp Tue Apr 10 20:24:39 2018 +0200
>> @@ -201,7 +201,7 @@
>> VerifyContainsOopClosure(oop target) : _target(target), _found(false) {}
>>
>> void do_oop(oop* p) {
>> - if (p != NULL && *p == _target) {
>> + if (p != NULL && oopDesc::equals(*p, _target)) {
>> _found = true;
>> }
>> }
>>
>> Testing: specjvm with oop verification (in progress)
>>
>> -Aleksey
>>
>
> Nice spot. Good to go.
>
> I'm curious how you found that?
Compiler.compiler with -XX:+VerifyStrictOopOperations
-Aleksey
More information about the shenandoah-dev
mailing list