RFR: Fix (non-PCH) build after "Bitmap based ShHeapRegionSet"

Roman Kennke rkennke at redhat.com
Mon Apr 16 15:25:53 UTC 2018


Yes.
Thanks for fixing!

Am 16. April 2018 17:09:55 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>Current sh/jdk build fails after recent commit.
>
>Fix:
>
>diff -r a4691713454d
>src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.hpp
>--- a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.hpp	Mon
>Apr 16 13:58:14 2018 +0200
>+++ b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.hpp	Mon
>Apr 16 17:07:49 2018 +0200
>@@ -28,6 +28,7 @@
>
> class ShenandoahHeap;
> class ShenandoahHeapRegion;
>+class ShenandoahHeapRegionSet;
>
> class ShenandoahHeapRegionSetIterator : public StackObj {
> private:
>@@ -36,8 +37,7 @@
>   ShenandoahHeap* const _heap;
>
> public:
>-  ShenandoahHeapRegionSetIterator(const ShenandoahHeapRegionSet* const
>set) :
>-    _set(set), _current_index(0), _heap(ShenandoahHeap::heap()) {}
>+  ShenandoahHeapRegionSetIterator(const ShenandoahHeapRegionSet* const
>set);
>
>   // MT version
>   ShenandoahHeapRegion* claim_next();
>diff -r a4691713454d
>src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.inline.hpp
>---
>a/src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.inline.hpp	Mon
>Apr 16 13:58:14 2018 +0200
>+++
>b/src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.inline.hpp	Mon
>Apr 16 17:07:49 2018 +0200
>@@ -30,6 +30,9 @@
> #include "gc/shenandoah/shenandoahHeap.inline.hpp"
> #include "gc/shenandoah/shenandoahHeapRegion.hpp"
>
>+ShenandoahHeapRegionSetIterator::ShenandoahHeapRegionSetIterator(const
>ShenandoahHeapRegionSet*
>const set) :
>+        _set(set), _current_index(0), _heap(ShenandoahHeap::heap()) {}
>+
> bool ShenandoahHeapRegionSet::is_in(size_t region_number) const {
>   assert(region_number < _heap->num_regions(), "Sanity");
>   return _set_map[region_number] == 1;
>
>
>Testing: hotspot_fast_gc_shenandoah {fastdebug|release}
>
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


More information about the shenandoah-dev mailing list