Happy path

Roman Kennke rkennke at redhat.com
Wed Apr 25 15:05:12 UTC 2018


Am 25.04.2018 um 17:02 schrieb Aleksey Shipilev:
> On 04/25/2018 04:45 PM, Roland Westrelin wrote:
>> Here is a new webrev:
>>
>> http://cr.openjdk.java.net/~roland/shenandoah/happypath-nocoalescing/webrev.00/
> 
> *) I think you meant to use "mask" in ShenandoahWriteBarrierNode::is_heap_state_test(Node*, int) here:
> 
>  584   if (in2->find_int_con(-1) != (ShenandoahHeap::EVACUATION | ShenandoahHeap::PARTIAL |
> ShenandoahHeap::TRAVERSAL)) {
> 
> Let me run a few performance tests to look for problems.
> 
> -Aleksey
> 
> 

Looks like the intention is to check if a constant matches the mask, not
doing the actual mask operation? Seems ok.?

Roman



More information about the shenandoah-dev mailing list