RFR: Fix broken asserts in ShenandoahSharedEnumFlag
Aleksey Shipilev
shade at redhat.com
Thu Apr 26 07:45:03 UTC 2018
On 04/25/2018 10:51 PM, Roman Kennke wrote:
> We assert this in ShenandoahSharedEnumFlag:
>
> assert (v < (1 << sizeof(ShenandoahSharedValue)), "sanity")
>
> However, this only works for values 0 and 1. I propose we change it to
> match the same asserts elsewhere in the same file:
>
> assert (v < (sizeof(ShenandoahSharedValue) * CHAR_MAX), "sanity")
>
> http://cr.openjdk.java.net/~rkennke/sharedvalue-fix-assert/webrev.00/
That makes sense, looks good!
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list