RFR: Integrate upstream OWST task terminator to Shenandoah

Roman Kennke roman at kennke.org
Fri Dec 7 17:17:33 UTC 2018


>> The patch looks ok. But it's lacking the JDK part. Please push the
>> whole
>> thing to Shenandoah's repo, otherwise it'll be temporarily broken.
>> Merge
>> from upstream will sort it out again.
> 
> Okay, here is the complete patch:
> http://cr.openjdk.java.net/~zgu/shenandoah/upstream_owst/webrev.02/
> 
> You really want to push JDK part, instead of pulling from upstream?

My preferred way of handling this is:
1. Push upstream part to jdk/jdk
2. Push Shenandoah part, including the upstream part to sh/jdk
3. Next upstream merge will be trivial

If we are certain that upstream part (1) doesn't change again, then
swapping 1 and 2 doesn't hurt.

Roman

> Thanks,
> 
> -Zhengyu
> 
>>
>> Thanks,
>> Roman
>>
>>
>>> Upstream "JDK-8214458: Port ShenandoahTaskTerminator to mainline
>>> and
>>> make it default" has been reviewed and is ready for pushing once
>>> CSR is
>>> approved.
>>>
>>> Let's get a head start and review Shenandoah side of change based
>>> on
>>> latest JDK-8214458 patch.
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/upstream_owst/we
>>> brev
>>> .01/
>>>
>>> Test:
>>>   tier1, tier2 and tier3 gc_shenandoah
>>>   fastdebug and release
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>
>>
> 



More information about the shenandoah-dev mailing list