RFR: Missing enter/leave around keep_alive_barrier in AArch64

[Andrew Haley]

On 07/12/17 13:18, Roman Kennke wrote:
> I've been missing enter/leave calls around the SATB pre barrier call in 
> MacroAssembler::keep_alive_barrier() for Shenandoah. This has been 
> sending EvilSyncBug (and possible some other tests) into endless loops.
> 
> The cleanest place to have them is in the (only) user of it in 
> generate_Reference_get():
> 
> http://cr.openjdk.java.net/~rkennke/aarch64-enter-leave/webrev.00/
> 
> Test: EvilSyncBug terminates now (aarch64). Running other tests right now
> 
> Ok?

All this saving and restoring of registers looks fantastically inefficient.
Is it the this does not matter because it is very rare?

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671