RFR: [9 Backport] Shenandoah string deduplication support
Roman Kennke
rkennke at redhat.com
Thu Jan 11 20:59:29 UTC 2018
Looks good to me.
Thank you for doing this!
Roman
> Hi Roman,
>
> Could you review this backport?
>
> Thanks,
>
> -Zhengyu
>
> On 01/10/2018 05:23 PM, Aleksey Shipilev wrote:
>> On 01/10/2018 10:31 PM, Zhengyu Gu wrote:
>>>
>>> On 01/10/2018 04:24 PM, Aleksey Shipilev wrote:
>>>> On 01/10/2018 10:18 PM, Zhengyu Gu wrote:
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~zgu/shenandoah/sh_strdedup/backport_jdk9/webrev.00/
>>>>>
>>>>
>>>> Thank you, this looks good.
>>>>
>>>> How much was changed compared to sh/jdk10, and are there places we
>>>> should take a special look at?
>>>> I assume G1 changes are the retraction to the upstream jdk9 state?
>>>>
>>>
>>> jdk10 patch applied pretty clean. The only file got mismerged was
>>> shenandoahRootProcessor.cpp.
>>>
>>> Yes, G1 changes reverted early changes back to upstream state.
>>
>> Good for me then!
>>
>> -Aleksey
>>
>>
More information about the shenandoah-dev
mailing list