RFR: Shenandoah String Dedup refactoring

Aleksey Shipilev shade at redhat.com
Tue Jul 3 17:52:52 UTC 2018


On 07/03/2018 07:38 PM, Zhengyu Gu wrote:
> Thanks for the review.
> 
> On 07/03/2018 11:53 AM, Aleksey Shipilev wrote:
>> On 07/02/2018 07:51 PM, Zhengyu Gu wrote:
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/shared_stringdedup/webrev.02/
>>
>> Nice to see another upstream diff ripout!
>>
>> *) Should we split out ShenandoahWorkerSession into a separate changeset for backporting?
> 
> Split into two changesets:
> 
> Worker session: http://cr.openjdk.java.net/~zgu/shenandoah/worker_id/webrev.00/
> 
> String dedup: http://cr.openjdk.java.net/~zgu/shenandoah/shared_stringdedup/webrev.03/

I think the per-task usages of ShenandoahWorkerSession like:
    92     ShenandoahWorkerSession worker_session(worker_id);

...should go into the first patch, because they are not string-dedup-specific. Otherwise looks good
for me, no need for other review.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list