RFR: Verify global and local gc-state status
Roman Kennke
rkennke at redhat.com
Thu Jul 5 18:10:44 UTC 2018
Am 05.07.2018 um 20:10 schrieb Aleksey Shipilev:
> On 07/05/2018 08:08 PM, Roman Kennke wrote:
>> Am 05.07.2018 um 20:04 schrieb Aleksey Shipilev:
>>> http://cr.openjdk.java.net/~shade/shenandoah/verify-gc-state/webrev.01/
>>>
>>> I wanted to do this for a long time, and now the work in mark-compact requires the verification step
>>> like this. It checks that gc-states in both thread-local caches and global in ShenandoahHeap are the
>>> ones we expect.
>>>
>>> Testing: tier3_gc_shenandoah
>>>
>>
>> Makes sense.
>>
>> What have those changes to do with that?
>>
>> http://cr.openjdk.java.net/~shade/shenandoah/verify-gc-state/webrev.01/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp.udiff.html
>
> Verifier checks that no "in-progress" bits are set. The code movements make that happen.
>
> -Aleksey
>
Ah. Ok then. Please push!
Thanks, Roman
More information about the shenandoah-dev
mailing list