RFR: Refactor to group marking bitmap and TAMS structure in one class ShenandoahMarkingContext

Aleksey Shipilev shade at redhat.com
Thu Jul 19 08:43:15 UTC 2018


On 07/18/2018 11:09 PM, Roman Kennke wrote:
> Am 18.07.2018 um 19:27 schrieb Aleksey Shipilev:
>> On 07/18/2018 07:16 PM, Roman Kennke wrote:
>>> Incremental:
>>> http://cr.openjdk.java.net/~rkennke/refactor-marking-context/webrev.01.diff/
>>>
>>> Full:
>>> http://cr.openjdk.java.net/~rkennke/refactor-marking-context/webrev.01/
>>
>> Looks good.
>>
>> -Aleksey
> 
> Found some copy+paste bugs (by jtreg tests):
> 
> Incremental:
> cr.openjdk.java.net/~rkennke/refactor-marking-context/webrev.02.diff/
> Full:
> cr.openjdk.java.net/~rkennke/refactor-marking-context/webrev.02/

*) Missed the opportunity for "next_ctx" here:

 509           compl_ctx->mark_bit_map()->copy_from(heap->next_marking_context()->mark_bit_map(),
MemRegion(bottom, top));

Otherwise looks okay.

-Aleksey



More information about the shenandoah-dev mailing list