RFR: Still need to call make_tlabs_parsable() even UseTLAB is disabled

Aleksey Shipilev shade at redhat.com
Wed Jun 13 15:04:01 UTC 2018


On 06/13/2018 04:57 PM, Zhengyu Gu wrote:
> We missed make_tlabs_parsable() call when preparing for full gc when UseTLAB is disabled, we still
> need it to retire PLAB.
> 
> http://cr.openjdk.java.net/~zgu/shenandoah/fullgc_retire_plab/webrev.00/

Oh! Looks good.

> We should consider to breakup it into two? cause it is confusing to call it when UseTLAB is off.

I think the method is misnomer: should be just "make_parsable", and let it figure out what to do if
-UseTLAB or +UseTLAB?

-Aleksey



More information about the shenandoah-dev mailing list