Move all Shenandoah runtime entry points to ShenandoahRuntime

Aleksey Shipilev shade at redhat.com
Thu Jun 14 08:20:00 UTC 2018


On 06/13/2018 07:50 PM, Roman Kennke wrote:
> As $SUBJECT says. In particular, it moves the shenandoah_clone_barrier
> out of SharedRuntime, thus reducing our upstream mess.
> 
> http://cr.openjdk.java.net/~rkennke/shenandoahrt/webrev.00/

Looks good!

Please break this line, if you can:

1099   call = make_leaf_call(c, m, ShenandoahBarrierSetC2::shenandoah_clone_barrier_Type(),
CAST_FROM_FN_PTR(address, ShenandoahRuntime::shenandoah_clone_barrier), "shenandoah_clone_barrier",
raw_adr_type, dest->in(AddPNode::Base));


We should probably stop calling it "g1_wb_pre" pretty soon:

 465         __ make_leaf_call(tf, CAST_FROM_FN_PTR(address,
ShenandoahRuntime::write_ref_field_pre_entry), "g1_wb_pre", pre_val, tls);


-Aleksey



More information about the shenandoah-dev mailing list