RFR: typo causes write barrier to be used where a read barrier is sufficient

Aleksey Shipilev shade at redhat.com
Thu Jun 14 12:21:22 UTC 2018


I read through that merge changeset:
  http://hg.openjdk.java.net/shenandoah/jdk/rev/6c71bb00fed8

... and what Roland found is the only typo like that.

-Aleksey

On 06/14/2018 02:00 PM, Roman Kennke wrote:
> Yes, this must have happened during c2merge. Please push! Thanks!
> 
> Am 14. Juni 2018 13:57:18 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>> On 06/14/2018 01:49 PM, Roland Westrelin wrote:
>>>
>>> diff --git a/src/hotspot/share/opto/parse2.cpp
>> b/src/hotspot/share/opto/parse2.cpp
>>> --- a/src/hotspot/share/opto/parse2.cpp
>>> +++ b/src/hotspot/share/opto/parse2.cpp
>>> @@ -211,7 +211,7 @@
>>>    if (is_store) {
>>>      ary = access_resolve_for_write(ary);
>>>    } else {
>>> -    ary = access_resolve_for_write(ary);
>>> +    ary = access_resolve_for_read(ary);
>>>    }
>>
>> Oh wow. Looks good! Maybe Roman would confirm this is bad typo indeed.
>>
>> -Aleksey
> 




More information about the shenandoah-dev mailing list