RFR: Implement arraycopy post-processing in GC threads for Traversal GC

Aleksey Shipilev shade at redhat.com
Tue Jun 19 08:39:45 UTC 2018


On 06/19/2018 10:32 AM, Roman Kennke wrote:
> Incremental:
> http://cr.openjdk.java.net/~rkennke/traversal-arraycopy/webrev.02.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/traversal-arraycopy/webrev.02/

*) Stray white-space:

 219


*) The check shapes are different, let's stick with fall-through? It would help my SBS lag tracing
patch too.

 121     if (count > ShenandoahEnqueueArrayCopyThreshold) {
 122       _heap->traversal_gc()->push_arraycopy(start, count);
 123       return; <--- early return
 124     }


 230     if ((size_t) obj->size() > ShenandoahEnqueueArrayCopyThreshold) {
 231       _heap->traversal_gc()->push_arraycopy(mr.start(), 0);
 232     } else {  <--- fall-through

Otherwise looks good, no need for another webrev.

-Aleksey



More information about the shenandoah-dev mailing list