RFR: enqueue barrier + some other things

Aleksey Shipilev shade at redhat.com
Wed Jun 20 11:39:55 UTC 2018


On 06/20/2018 01:35 PM, Roland Westrelin wrote:
> 
>> Could we _not_ move the code around when changing it? The 3.5 KLOC change in shenandoahSupport is
>> extremely hard to review, and I think it could be better.
> 
> Do you want me to split the patch. The big refactoring stuff in one, the
> rest in another?

Yes. I think we'd better have first patch that does not move the code, makes the actual code
changes, maybe renaming methods, but keeping their bodies at the same code positions. Then the
second patch that moves the code blocks around. It would be much easier to backport this way, as
actual changes would be visible in first patch, and second patch could be reimplemented by
reshuffling the existing code.

-Aleksey



More information about the shenandoah-dev mailing list