RFR: Fix shenandoah jdk non-PCH build
Aleksey Shipilev
shade at redhat.com
Tue Mar 13 15:55:19 UTC 2018
On 03/13/2018 04:52 PM, Roman Kennke wrote:
> Am 13.03.2018 um 16:43 schrieb Zhengyu Gu:
>> The patch to fix shenandoah jdk build with precompiled header disabled.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/sh-jdk-non-PCH/webrev.00/
>>
>>
>> Test:
>>
>> hotspot_gc_shenandoah (fastdebug and release)
>>
>> Thanks,
>>
>> -Zhengyu
>
> There are a few changes outside Shenandoah files. Why are they needed?
> Why are they not needed upstream? Would it make sense to upstream them?
I wondered the same, and these apparently cover our own additions to those files:
https://builds.shipilev.net/patch-openjdk-shenandoah-jdk/2018-03-13-v35-vs-02404e27d356/src/hotspot/share/code/debugInfo.cpp.sdiff.html
https://builds.shipilev.net/patch-openjdk-shenandoah-jdk/2018-03-13-v35-vs-02404e27d356/src/hotspot/share/utilities/growableArray.hpp.sdiff.html
-Aleksey
More information about the shenandoah-dev
mailing list