RFR: [10] Backports for fixing Shenandoah JDK10 non-PCH build

Aleksey Shipilev shade at redhat.com
Wed Mar 14 10:02:08 UTC 2018


On 03/14/2018 11:00 AM, Aleksey Shipilev wrote:
> On 03/13/2018 09:24 PM, Zhengyu Gu wrote:
>> A couple of backports to fix Shenandoah JDk10 build without precompiled headers.
>>
>> Both patches were applied cleanly.
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh-jdk10-non-PCH/webrev.00/
> 
> *) I would prefer not to pickup partial backports that fix PCH for us. Is there a way to just add
> appropriate headers to make it compile?
> 
> *) The code move for SBS::clone_in_heap should be done in sh/jdk, and then backported to sh/jdk10.
> Maybe you would like to RFR that first, then we backport, and then we finish fixing PCH in sh/jdk10.

*) Also, the changes in access.hpp seems the functional changes, not the PCH fix.

-Aleksey



More information about the shenandoah-dev mailing list