RFR: FinalEvac pause to turn off evacuation
Roman Kennke
rkennke at redhat.com
Thu Mar 15 18:08:19 UTC 2018
Am 15.03.2018 um 16:26 schrieb Aleksey Shipilev:
> On 03/15/2018 04:19 PM, Roman Kennke wrote:
>> Diff:
>> http://cr.openjdk.java.net/~rkennke/final-evac/webrev.02.diff/
>> Full:
>> http://cr.openjdk.java.net/~rkennke/final-evac/webrev.02/
>
> *) Regression: Verifier always runs at final-evac. Protect it with ShenandoahVerify. (I think it
> should have asserted, to be honest... have you ran tests?)
>
> *) VM_ShenandoahVerifyHeapAfterEvacuation used to override these:
>
> 166 // We don't care about that here.
> 167 bool deflates_idle_monitors() { return false; }
> 168 bool marks_nmethods() { return false; }
>
> Otherwise good.
>
Good catches. Yeah, I did kick off the testing after I posted the patch.
It just takes so long.
Hopefully last round:
Differential:
http://cr.openjdk.java.net/~rkennke/final-evac/webrev.03.diff/
Full:
http://cr.openjdk.java.net/~rkennke/final-evac/webrev.03/
Ok?
More information about the shenandoah-dev
mailing list