Remove runtime storeval barrier
Aleksey Shipilev
shade at redhat.com
Mon Mar 19 11:02:36 UTC 2018
On 03/19/2018 12:00 PM, Roman Kennke wrote:
> Am 19.03.2018 um 11:59 schrieb Aleksey Shipilev:
>> On 03/19/2018 11:55 AM, Roman Kennke wrote:
>>> The storeval_barrier() in BarrierSet is no longer used. It's all covered
>>> by the Access API now. Let's remove the API. I'll keep the
>>> ShenandoahBarrierSet part for internal use.
>>>
>>> diff --git a/src/hotspot/share/gc/shared/barrierSet.hpp
>>> b/src/hotspot/share/gc/shared/barrierSet.hpp
>>> --- a/src/hotspot/share/gc/shared/barrierSet.hpp
>>> +++ b/src/hotspot/share/gc/shared/barrierSet.hpp
>>> @@ -137,9 +137,6 @@
>>> virtual oop write_barrier(oop src) {
>>> return src;
>>> }
>>> - virtual oop storeval_barrier(oop src) {
>>> - return src;
>>> - }
>>>
>>> virtual void keep_alive_barrier(oop obj) {
>>> // Default impl does nothing.
>>>
>>>
>>> Ok?
>>
>> OK!
>>
>> What about this?
>>
>> virtual void interpreter_storeval_barrier(MacroAssembler* masm, Register dst, Register tmp) {
>> // Default implementation does nothing.
>> }
>>
>
> This needs to wait for CodeGen part of the BarrierSet API.
Ok then.
-Aleksey
More information about the shenandoah-dev
mailing list