RFR: [10] Backports for fixing Shenandoah JDK10 non-PCH build

Zhengyu Gu zgu at redhat.com
Tue Mar 20 15:34:13 UTC 2018



On 03/14/2018 06:02 AM, Aleksey Shipilev wrote:
> On 03/14/2018 11:00 AM, Aleksey Shipilev wrote:
>> On 03/13/2018 09:24 PM, Zhengyu Gu wrote:
>>> A couple of backports to fix Shenandoah JDk10 build without precompiled headers.
>>>
>>> Both patches were applied cleanly.
>>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh-jdk10-non-PCH/webrev.00/
>>
>> *) I would prefer not to pickup partial backports that fix PCH for us. Is there a way to just add
>> appropriate headers to make it compile?

Okay, JDK-8193063 seems never arrived to upstream jdk10. Redid fix 
without it. Unfortunately, it does need to touch G1 code to breakup 
circular dependency.

Webrev: 
http://cr.openjdk.java.net/~zgu/shenandoah/sh-jdk10-non-PCH/webrev.01/

Test:

   hotspot_gc_shenandoah (release + fastdebug)

Thanks,

-Zhengyu

>>
>> *) The code move for SBS::clone_in_heap should be done in sh/jdk, and then backported to sh/jdk10.
>> Maybe you would like to RFR that first, then we backport, and then we finish fixing PCH in sh/jdk10.
> 
> *) Also, the changes in access.hpp seems the functional changes, not the PCH fix.
> 
> -Aleksey
> 


More information about the shenandoah-dev mailing list