RFR: Shenandoah critical native support

Aleksey Shipilev shade at redhat.com
Wed Mar 28 23:02:49 UTC 2018


On 03/28/2018 07:54 PM, Zhengyu Gu wrote:
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh-critical-natives/webrev.00/index.html

This change has a few problems:

 *) Breaks our nightlies with:

* For target support_test_hotspot_jtreg_native_support_libCriticalNative_libCriticalNative.o:
/home/jenkins/workspace/nightly/shenandoah-jdk/test/hotspot/jtreg/gc/shenandoah/libCriticalNative.c:
In function ‘JavaCritical_CriticalNativeStress_sum1’:
/home/jenkins/workspace/nightly/shenandoah-jdk/test/hotspot/jtreg/gc/shenandoah/libCriticalNative.c:29:3:
error: ‘for’ loop initial declarations are only allowed in C99 mode
   for (jint index = 0; index < length; index ++) {
   ^

 *) Typos: "ciritical",

+JRT_LEAF(oopDesc*, SharedRuntime::pin_ciritcal_native_array(oopDesc* obj))

...

+JRT_LEAF(void, SharedRuntime::unpin_ciritcal_native_array(oopDesc* obj))

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list