RFR: Several small aarch64 fixes

Aleksey Shipilev shade at redhat.com
Fri May 4 13:32:23 UTC 2018


On 05/04/2018 03:29 PM, Roman Kennke wrote:
> While poking around aarch64 interpreter code for the primitives stuff, I
> discovered some things that should be fixed separately:
> 
> http://cr.openjdk.java.net/~rkennke/aarch64-fixes/webrev.00/

This does not look correct for a SATB barrier. Did you mean "MARKING | TRAVERSAL"?

1141           __ mov(rscratch2, ShenandoahHeap::EVACUATION | ShenandoahHeap::TRAVERSAL);
1142           __ tst(rscratch1, rscratch2);
1143           __ br(Assembler::EQ, done);

Otherwise good.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list