RFR: Fixing Windows and ARM32 build

Roman Kennke rkennke at redhat.com
Mon May 7 20:34:51 UTC 2018


Am 07.05.2018 um 22:22 schrieb Zhengyu Gu:
> Apparently, you cannot avoids precompiled headers for selected files on
> Windows, or you have to turn it off all together.
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/win-build/webrev.00/
> 
> Test:
> 
>   Windows X64 PCH and Non-PCH builds
>   Linux x64 PCH and Non-PCH builds
>   ARM32 PCH and Non-PCH builds
> 
> 
> Thanks,
> 
> -Zhengyu
> 
> 

IIRC, Aleksey did not want this:
-  Atomic::add(-bytes, &_used);
+  Atomic::sub(bytes, &_used);

because backports.


Why is this needed:
-  write_ref_array_pre_work(T* dst, int count);
+  write_ref_array_pre_work(T* dst, size_t count);

?

Is the change in src/hotspot/os/windows/attachListener_windows.cpp
needed? If yes, then upstream it?

Thanks,
Roman



More information about the shenandoah-dev mailing list