RFR: Fixing Windows and ARM32 build

[Aleksey Shipilev]

On 05/08/2018 08:04 AM, Roman Kennke wrote:
>> VSC++ does not like it:
>>
>> /shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp(595)
>> : warning C4146: unary minus operator applied to unsigned type, result
>> still unsigned
>>
>> so, we have to suppress warning at call site to avoid warnings-as-errors
>> build failure, sounds like not making backports any easier.
> 
> Ok. It's good for me, probably let Aleksey confirm, he should at least
> have it on his radar ;-)

Ok, fine, do it with sub. We will sort that out during backports.


>>> Why is this needed:
>>> -  write_ref_array_pre_work(T* dst, int count);
>>> +  write_ref_array_pre_work(T* dst, size_t count);
>>>
>> VSC++ wants explicit casting. G1BassierSet uses size_t here, probably we
>> should do so to avoid casting, also for consistency.
>>
>> Do you see any issues here?
> 
> No, it's ok, I just wanted to understand.

We should keep our code synced up between JDK versions. So, if this issue is present in either
jdk10, jdk9, or jdk8u, it should be done separately.


Thanks,
-Aleksey