RFR: Use PLAB for evacuations instead of TLAB

Zhengyu Gu zgu at redhat.com
Thu May 10 12:15:58 UTC 2018


Yes, it looks ok to me.

Thanks,

-Zhengyu

On 05/10/2018 07:42 AM, Roman Kennke wrote:
> Am 10.05.2018 um 01:24 schrieb Zhengyu Gu:
>>>
>>>> ShenandoahHeap.cpp L1499
>>>>     Need scope block for
>>>> 1499   ShenandoahGCPhase phase(ShenandoahPhaseTimings::make_parsable);
>>>> 1500   make_tlabs_parsable(true);
>>>>
>>>> or should just keep UseTLAB test here to avoid misleading timing info,
>>>> in case of phase time > 0.
>>>
>>> We also need to always retire the GCLABs, regardless of UseTLABs, the
>>> test is moved into the retire_all_tlabs() code.
>>>
>> Ah, I missed changes in make_tlabs_parsable() :-(
> 
> Can I take that as approval from you? ;-)
> 
> I would like to get Aleksey's ok too.
> 
> Roman
> 


More information about the shenandoah-dev mailing list