RFR: Move heuristics from ShCollectorPolicy to ShHeap
Aleksey Shipilev
shade at redhat.com
Wed May 16 16:26:23 UTC 2018
On 05/16/2018 05:19 PM, Roman Kennke wrote:
> I simply spliced all the calls to policy that also called to heuristics
> into two calls: policy+heuristics or changed to heuristics call for
> cases where policy did not do anything.
>
> Remaining record* stuff in policy should probably be moved into a
> separate ShenandoahStats class or such.
>
> Differential:
> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.01.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.01/
Looks OK. Have somebody else eyeball this, because I cannot trust my eyes anymore today. Or wait for
tomorrow.
> I can hold it back and fold into the bigger multi-context picture, or
> push it separately. Whatever you prefer.
On the second thought, it does not make my life significantly more complicated to have this splicing
committed and backported. We wanted to do this for some time anyway
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list