RFR: Rework GC degradation on allocation failure

Zhengyu Gu zgu at redhat.com
Fri May 18 13:48:12 UTC 2018


Good!

-Zhengyu

On 05/18/2018 09:16 AM, Aleksey Shipilev wrote:
> On 05/17/2018 09:46 PM, Zhengyu Gu wrote:
>> Hi,
>>
>> ShenandoahMetricsSnapshot
>>
>> - member variables need "_" prefix
>>
>> ShenandoahMetrics::external_fragmentation()
>>
>>   - algorithm does not seem to match comment
>>
>> Otherwise, looks good.
> 
> Right. Does this look better?
>    http://cr.openjdk.java.net/~shade/shenandoah/alloc-failure-rework/webrev.02/
> 
> I also reconsidered ShenandoahHeap::allocate_memory, and that fixes the issues that made nightly
> tests fail.
> 
> Testing: hotspot_gc_shenandoah
> 
> -Aleksey
> 
> 


More information about the shenandoah-dev mailing list