RFR: Make all Shenandoah tests @requires vm.gc.Shenandoah

Aleksey Shipilev shade at redhat.com
Wed Nov 28 14:11:43 UTC 2018


On 11/28/18 12:34 PM, Roman Kennke wrote:
> This puts @requires vm.gc.Shenandoah tag in all Shenandoah tests under
> gc/shenandoah such that they don't accidentally get selected in
> non-Shenandoah builds.
> 
> Testing: build with --with-jvm-features=-shenandoah,
> run-tests=gc/shenandoah, get:
> 
> 
> Test selection 'gc/shenandoah', will run:
> * jtreg:test/hotspot/jtreg/gc/shenandoah
> 
> Running test 'jtreg:test/hotspot/jtreg/gc/shenandoah'
> Test results: no tests selected
> 
> 
> http://cr.openjdk.java.net/~rkennke/tests-req-shenandoah/webrev.00/

Hold on, let me add "@key gc" and make sure "@test" is correct, and format test blocks consistently
then. Apply on top of your patch:
  http://cr.openjdk.java.net/~shade/shenandoah/shade-tests-updates.patch

New synopsis: "Shenandoah should @require Shenandoah, @key gc, and have good @test"

tier3_gc_shenandoah seems unaffected.

-Aleksey



More information about the shenandoah-dev mailing list