RFR: Fix shared tests to run without Shenandoah

Roman Kennke rkennke at redhat.com
Wed Nov 28 17:51:40 UTC 2018


>> Several shared tests wouldn't run or fail when Shenandoah is not
>> available. This fixes them. Some needed an extra test section, some
>> needed a runtime test, and one I did not know what to do:
>>
>> test/hotspot/jtreg/gc/TestFullGCCount.java
>>
>> http://cr.openjdk.java.net/~rkennke/fix-shared-tests/webrev.00/
> 
> *) TestSystemGC.java: @test should be TestSystemGCShenandoah
> 
> *) TestDynamicNumberOfGCThreads.java, TestInitialGCThreadLogging.java, TestGCId.java: bad indent
> around L34, "sun" should be aligned?
> 
>   33  * @run driver ClassFileInstaller sun.hotspot.WhiteBox
>   34  *                              sun.hotspot.WhiteBox$WhiteBoxPermission
> 
> *) TestDynamicNumberOfGCThreads.java, do you really need to change private->protected?

Nope. Leftover. Removed.

> *) CriticalNativeStress.java: addition of "compact" + "-degen" does not make sense. Did you mean
> "passive" + "+degen"? It probably makes sense to split out for a separate backport.

No, we already have passive+degen, I meand compact-degen. Also fixed a
number of other places like the above (added @test names, etc):

http://cr.openjdk.java.net/~rkennke/fix-shared-tests/webrev.01/


Ok?




More information about the shenandoah-dev mailing list