RFR: Fix shared tests to run without Shenandoah

Zhengyu Gu zgu at redhat.com
Wed Nov 28 18:42:06 UTC 2018



> 
> Ugh. I thought it's 2x the same line. Zhengyu suggested it might have
> intended to be compact. Let's simply revert this part.

Ah, I thought there are dup too ... :-(

-Zhengyu

> 
>>> http://cr.openjdk.java.net/~rkennke/fix-shared-tests/webrev.01/
>>
>> Okay, what's up with TestFullGCCount test? Does it not run without Shenandoah built? It should. The
>> @requires line there only protects from running the test with Shenandoah in explicit-concurrent
>> mode, right? (While you are at it, you can probably change "vm.gc == "Shenandoah"" to
>> "vm.gc.Shenandoah")
> 
> The way it was written was very confusing and it was wrong too. All the
> @requires together would not select any test at all, except default GC.
> The way I've split it up now should be good:
> 
> http://cr.openjdk.java.net/~rkennke/fix-shared-tests/webrev.02/
> 
> WDYT?
> 
> Roman
> 


More information about the shenandoah-dev mailing list