RFR: Missed VerifyObjectEquals in VerifyJCStressTest

Aleksey Shipilev shade at redhat.com
Mon Oct 1 17:15:10 UTC 2018


Option was renamed, but test was not updated. And it never failed, because it has
-XX:+IgnoreUnrecognizedVMOptions to be runnable in release mode.

Fix:

diff -r 7756fbadc938 test/hotspot/jtreg/gc/shenandoah/acceptance/VerifyJCStressTest.java
--- a/test/hotspot/jtreg/gc/shenandoah/acceptance/VerifyJCStressTest.java       Fri Sep 28 09:54:10
2018 -0400
+++ b/test/hotspot/jtreg/gc/shenandoah/acceptance/VerifyJCStressTest.java       Mon Oct 01 19:11:38
2018 +0200
@@ -31,3 +31,3 @@
  *  -XX:+UseShenandoahGC -Xmx1g -Xms1g
- *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyStrictOopOperations
+ *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyObjectEquals
  *  -XX:ShenandoahGCHeuristics=passive -XX:+ShenandoahDegeneratedGC
@@ -37,3 +37,3 @@
  *  -XX:+UseShenandoahGC -Xmx1g -Xms1g
- *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyStrictOopOperations
+ *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyObjectEquals
  *  -XX:ShenandoahGCHeuristics=passive -XX:-ShenandoahDegeneratedGC
@@ -43,3 +43,3 @@
  *  -XX:+UseShenandoahGC -Xmx1g -Xms1g
- *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyStrictOopOperations
-XX:+ShenandoahVerifyOptoBarriers
+ *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyObjectEquals
-XX:+ShenandoahVerifyOptoBarriers
  *  -XX:ShenandoahGCHeuristics=adaptive
@@ -49,3 +49,3 @@
  *  -XX:+UseShenandoahGC -Xmx1g -Xms1g
- *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyStrictOopOperations
-XX:+ShenandoahVerifyOptoBarriers
+ *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyObjectEquals
-XX:+ShenandoahVerifyOptoBarriers
  *  -XX:ShenandoahGCHeuristics=static
@@ -55,3 +55,3 @@
  *  -XX:+UseShenandoahGC -Xmx1g -Xms1g
- *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyStrictOopOperations
-XX:+ShenandoahVerifyOptoBarriers
+ *  -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerify -XX:+VerifyObjectEquals
-XX:+ShenandoahVerifyOptoBarriers
  *  -XX:ShenandoahGCHeuristics=traversal

Testing: VerifyJCStressTest

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list