RFR: Skip pre-evac verification and pacing on shortcut cycle path

Zhengyu Gu zgu at redhat.com
Mon Oct 22 13:32:43 UTC 2018



On 10/22/2018 09:23 AM, Aleksey Shipilev wrote:
> On 10/22/2018 03:19 PM, Zhengyu Gu wrote:
>> On 10/21/2018 02:58 PM, Aleksey Shipilev wrote:
>>> http://cr.openjdk.java.net/~shade/shenandoah/verifier-shortcut/webrev.01/
>>>
>>> This cleans up a corner case in our verification and pacing bindings: we don't need to call pacer on
>>> shortcut path, and there is no need to do double verification on non-shortcut path. This also
>>> naturally handles VerifyAfterGC on shortcut path.
>>
>> For piggyback ref-update cycle, should op_final_mark()'s trash_cset_regions() also signal the end of
>> GC cycle?
> 
> I don't understand the question.

I think we also need "if (VerifyAfterGC) Universe::verify()" after 
trash_cset_regions() in op_final_mark(), if update_ref is piggybacked to 
marking cycle, where is equivalent to op_final_updateref with separate 
ref-update cycle, no?

And I am still puzzled why op_final_evac() is the last op for a GC 
cycle, cause refs are not updated.

-Zhengyu

> 
> -Aleksey
> 


More information about the shenandoah-dev mailing list