Potential ShTraversalGC::weak_refs_work_doit bug

Roman Kennke rkennke at redhat.com
Mon Sep 10 09:38:49 UTC 2018


> This block has some weirdness:
> 
> http://hg.openjdk.java.net/shenandoah/jdk/file/e60d7f4b3ba9/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp#l1164
> 
> *) is_alive is redefined -- to the same value?


Where do you see is_alive redefined? It is defined once here:
http://hg.openjdk.java.net/shenandoah/jdk/file/e60d7f4b3ba9/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp#l1172


> *) complete_gc is not used? Shouldn't we call it to pick up new stuff from weak_oops_do?

It is used in WeakProcessor::weak_oops_do() calls, isn't it?

Or maybe I misunderstand your questions?

Roman



More information about the shenandoah-dev mailing list