RFR: Disable ShHeapUncommit on too-large large-pages

Aleksey Shipilev shade at redhat.com
Tue Sep 11 07:08:16 UTC 2018


On 09/10/2018 11:45 PM, Roman Kennke wrote:
> OMG, the webrev was totally garbled. Look at this one:
> cr.openjdk.java.net/~rkennke/disable-uncommit/webrev.01/

*) I'd say the condition in ShenandoahHeapRegion::setup_sizes should be "if (ShenandoahUncommit)"?
This way it captures the intent clearly. And the comment before it should mention uncommit, not
mem-protection.

Otherwise looks okay.

Thanks,
-Aleksey




More information about the shenandoah-dev mailing list