RFR: Missing includes after "Cleanup buffered queue handling"

Zhengyu Gu zgu at redhat.com
Tue Sep 18 16:23:41 UTC 2018


Yes.

-Zhengyu

On 09/18/2018 12:01 PM, Aleksey Shipilev wrote:
> Missed this during testing. Current build produces warnings:
> 
> In file included from
> /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp:27:0,
>                   from
> /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp:30,
>                   from
> /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp:31,
>                   from
> /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp:27:
> /home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp:43:15:
> warning: inline function ‘bool BufferedOverflowTaskQueue<E, F, N>::push(E) [with E =
> ObjArrayChunkedTask; MemoryType F = (MemoryType)5; unsigned int N = 131072]’ used but never defined
>     inline bool push(E t);
>                 ^~~~
> 
> This is because recent commit missed some includes:
> 
> diff -r 2f6a8e31fce0 src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp       Tue Sep 18 17:06:28
> 2018 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp       Tue Sep 18 17:51:58
> 2018 +0200
> @@ -32,4 +32,5 @@
>   #include "gc/shenandoah/shenandoahMarkingContext.inline.hpp"
>   #include "gc/shenandoah/shenandoahStringDedup.hpp"
> +#include "gc/shenandoah/shenandoahTaskqueue.inline.hpp"
>   #include "memory/iterator.inline.hpp"
>   #include "oops/oop.inline.hpp"
> diff -r 2f6a8e31fce0 src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp  Tue Sep 18 17:06:28 2018 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp  Tue Sep 18 17:51:58 2018 +0200
> @@ -34,4 +34,5 @@
>   #include "gc/shenandoah/shenandoahTraversalGC.hpp"
>   #include "gc/shenandoah/shenandoahTaskqueue.hpp"
> +#include "gc/shenandoah/shenandoahTaskqueue.inline.hpp"
>   #include "memory/iterator.inline.hpp"
>   #include "oops/oop.inline.hpp"
> 
> 
> Testing: x86_64 build {fastdebug|release}
> 
> Thanks,
> -Aleksey
> 


More information about the shenandoah-dev mailing list