[aarch64-port-dev ] [RFR] [8u] 8u232-b01 Upstream Sync

Aleksey Shipilev shade at redhat.com
Thu Aug 1 17:19:24 UTC 2019


The links to changesets below are broken, they are not "b09.changeset", but rather "$project.patch".
Anyway:

On 8/1/19 6:47 PM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/corba/b09.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/jaxp/b09.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/jaxws/b09.changeset

Look trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/jdk/b09.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/hotspot/b09.changeset

I don't understand where change to chaitin.hpp is coming from, really:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/hotspot/src/share/vm/opto/chaitin.hpp.sdiff.html

It seems both sides of the merge have the "if" branch removed:
  http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/bfff0a0ccb0e/src/share/vm/opto/chaitin.hpp#l323

http://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/file/7570e7d49957/src/share/vm/opto/chaitin.hpp#l323

Maybe I don't understand how webrev was generated.

Otherwise looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/langtools/b09.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/nashorn/b09.changeset

Look trivially good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u232-b01/root/b09.changeset
Looks good.

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list