RFR 8227103: Shenandoah: Refactor ShenandoahNMethod in preparation of concurrent nmethod iteration

Aleksey Shipilev shade at redhat.com
Fri Aug 2 10:42:02 UTC 2019


On 7/23/19 5:40 PM, Zhengyu Gu wrote:
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8227103/webrev.01/
Getting back to this! The refactoring generally looks good. Some minor things:

*) I wonder if we actually need to store _nmethod_table_state in ShenandoahCodeRootsIterator? It
looks as if that state is actually table-internal, and should be moved there? Actually, I don't see
the need for ShenandoahNMethodTableState, we can just as ShenandoahNMethodTable to iterate itself?

*) It looks like ShenandoahNMethodTable::log_(un)register_nmethod can be replaced with just
one-liners like: log_debug(gc, nmethod)(...), and inlined into their only uses?


-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list