RFR 8227103: Shenandoah: Refactor ShenandoahNMethod in preparation of concurrent nmethod iteration

[Aleksey Shipilev]

On 8/2/19 4:59 PM, Zhengyu Gu wrote:
> On 8/2/19 6:42 AM, Aleksey Shipilev wrote:
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8227103/webrev.02/

Looks good!

Minor nit: don't use "debug_only" macros, that is historical one, use DEBUG_ONLY instead. No need
for another webrev.

>> *) It looks like ShenandoahNMethodTable::log_(un)register_nmethod can be replaced with just
>> one-liners like: log_debug(gc, nmethod)(...), and inlined into their only uses?
>>
> 
> IIRC, the one-line version constructs parameters before checking if logging is enabled, so have to
> pay the penalty even logging is disabled, and parameter constructions here are not trivial.

Right. Okay.


-- 
Thanks,
-Aleksey