sh/jdk build failure on Windows

[Zhengyu Gu]

Sorry, I am on it.

-Zhengyu

On 8/7/19 4:26 AM, Aleksey Shipilev wrote:
> On 8/7/19 9:37 AM, Aleksey Shipilev wrote:
>> I believe recent pushes to sh/jdk broken Windows builds:
>>
>> c:\cygwin64\home\windows\worker\shenandoah-jdkX-windows\build\src\hotspot\share\gc/shenandoah/shenandoahLock.hpp(72)
>> : error C2653: 'SafepointSynchronize' : is not a class or namespace name
>> c:\cygwin64\home\windows\worker\shenandoah-jdkX-windows\build\src\hotspot\share\gc/shenandoah/shenandoahLock.hpp(72)
>> : error C3861: 'is_at_safepoint': identifier not found
>>
>> That probably only manifests without precompiled headers. Zhengyu, can you take a look?
> 
> Actually, not only on Windows?
> 
> In file included from
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/utilities/globalDefinitions.hpp:29:0,
>                   from
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/runtime/extendedPC.hpp:28,
>                   from
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/runtime/os.hpp:32,
>                   from
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.cpp:26:
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp: In
> member function ‘void ShenandoahLock::assert_owned_by_current_thread_or_safepoint()’:
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp:73:13:
> error: ‘SafepointSynchronize’ has not been declared
>              (SafepointSynchronize::is_at_safepoint() && thr->is_VM_thread()),
>               ^
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/utilities/debug.hpp:56:9: note:
> in definition of macro ‘vmassert’
>     if (!(p)) {                                                                  \
>           ^
> /home/buildbot/worker/shenandoah-jdkX-linux/build/src/hotspot/share/gc/shenandoah/shenandoahLock.hpp:72:5:
> note: in expansion of macro ‘assert’
>       assert((_state == locked && _owner == thr) ||
>       ^~~~~~
> At global scope:
> cc1plus: error: unrecognized command line option ‘-Wno-implicit-fallthrough’ [-Werror]
> cc1plus: error: unrecognized command line option ‘-Wno-int-in-bool-context’ [-Werror]
> cc1plus: all warnings being treated as errors
> 
>