RFR: Bulk integration from shenandoah/jdk8

Andrew John Hughes gnu.andrew at redhat.com
Thu Dec 12 03:16:37 UTC 2019



On 09/12/2019 14:33, Roman Kennke wrote:
> Hello all,
> 
> I'd like to propose integration of outstanding changes and backports
> from shenandoah/jdk8.
> 
> This time it is rather big. Most significantly, it includes LRB,
> elimination of forwarding pointer, the new x86_32 port, the Traversal
> GC, plus a whole lot of related bugfixes.
> 
> The list of changes:
> http://cr.openjdk.java.net/~rkennke/aarch64-shenandoah-integration-2019-12-09/changesets.txt
> 
> Shared-only webrev:
> http://cr.openjdk.java.net/~rkennke/aarch64-shenandoah-integration-2019-12-09/webrev-shared-only.00/
> 
> Full webrev:
> http://cr.openjdk.java.net/~rkennke/aarch64-shenandoah-integration-2019-12-09/webrev-all.00/
> 
> There are quite many shared-code changes involved in this. However, most
> of them actually revert/remove existing shared-code changes vs upstream
> jdk8u, so the net effect is a drastic improvement. We added a few new
> hooks (for the LRB), but we kept it inside the following pattern
> wherever possible:
> 
> #ifdef INCLUDE_ALL_GCS
> if (UseShenandoahGC) {...
> }
> #endif
> 
> Also, this change includes some renaming and moving-around of
> (Shenandoah) files to keep Shenandoah code in Shenandoah subdirectories,
> and follow the naming scheme of >=11 as much as possible.
> 
> Can I please get a review of this?
> 
> Thanks,
> Roman
> 

I looked over the shared webrev and it looks ok to me. I got the same
impression of it mainly being a cleanup exercise before I saw your
comment in the same vein, and it should make merges with 8u easier.

We should get this in ASAP as it's already get late in the cycle for the
January release.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the shenandoah-dev mailing list