RFR: 8236179: C1 register allocation error with T_ADDRESS

[Aditya Mandaleeka]

Thanks for updating the other platforms Martin. Those changes look right to me.

-Aditya

-----Original Message-----
From: Doerr, Martin <martin.doerr at sap.com> 
Sent: Thursday, December 19, 2019 8:31 AM
To: Roland Westrelin <rwestrel at redhat.com>; Aditya Mandaleeka <adityam at microsoft.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Cc: shenandoah-dev <shenandoah-dev at openjdk.java.net>
Subject: RE: RFR: 8236179: C1 register allocation error with T_ADDRESS

Hi everybody,

thanks for fixing this issue.

I guess it's currently used on some platforms, but I think we should fix it for all platforms. Otherwise it will break when using the parts which were only fixed for x86.

Here's my proposal:
https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~mdoerr%2F8236179_C1_T_ADDRESS%2Fwebrev.01%2F&data=02%7C01%7Cadityam%40microsoft.com%7C3d2013a8ff1d4ffbafaa08d784a0dcc1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637123698748787948&sdata=r11YVMnHSLm1Ms1Ipbq4vPDOhIwlrM8fz1QlAl%2BUWGY%3D&reserved=0

I'll run tests on more platforms.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev- 
> bounces at openjdk.java.net> On Behalf Of Roland Westrelin
> Sent: Donnerstag, 19. Dezember 2019 15:15
> To: Aditya Mandaleeka <adityam at microsoft.com>; hotspot compiler 
> <hotspot-compiler-dev at openjdk.java.net>
> Cc: shenandoah-dev <shenandoah-dev at openjdk.java.net>
> Subject: Re: RFR: 8236179: C1 register allocation error with T_ADDRESS
> 
> 
> Hi Aditya,
> 
> AFAIK, it's a requirement that the patch be posted on the openjdk 
> infrastructure. So here it is:
> 
> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.open
> jdk.java.net%2F~roland%2F8236179%2Fwebrev.00%2F&data=02%7C01%7Cadi
> tyam%40microsoft.com%7C3d2013a8ff1d4ffbafaa08d784a0dcc1%7C72f988bf86f1
> 41af91ab2d7cd011db47%7C1%7C0%7C637123698748787948&sdata=vQ1xR87EjA
> bf%2Bnwscs1c%2BpTqWLfeVODLz%2FleIsdmthU%3D&reserved=0
> 
> The change looks good to me but it would be good to check whether 
> architectures other than x86 need a similar change.
> 
> Roland.