RFR: Don't check store value in Shenandoah C2 verifier

Aleksey Shipilev shade at redhat.com
Mon Feb 18 12:15:23 UTC 2019


On 2/18/19 1:10 PM, Roman Kennke wrote:
> Since LRB, we don't need any store-value barriers anymore (except for
> the enqueue-barriers in traversal, but I don't think we even check
> that). The C2 verifier pass shouldn't check and complain about missing
> barriers.
> 
> http://cr.openjdk.java.net/~rkennke/fixoptoverifier/webrev.00/

Looks okay to me.

There is a block right below the removed one, does it matter still as well?

if (!verify_helper(n->in(MemNode::Address), phis, visited, ShenandoahStore, trace, barriers_used)) {
  report_verify_failure("Shenandoah verification: Store (address) should have barriers", n);
}

-Aleksey



More information about the shenandoah-dev mailing list