From zgu at redhat.com Fri Mar 1 16:25:07 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Fri, 01 Mar 2019 11:25:07 -0500 Subject: Question on Shenandoah GarbageCollectorMXBeans In-Reply-To: <30AA2877-69D7-45ED-AD71-C8DB09FCAF7E@nitschinger.at> References: <30AA2877-69D7-45ED-AD71-C8DB09FCAF7E@nitschinger.at> Message-ID: <1551457507.18805.141.camel@redhat.com> Hi Michael, I have no idea how this message went under our radar for so long, I just found out this morning, sorry! I filed https://bugs.openjdk.java.net/browse/JDK-8219976, and am working on the fix. Thanks, -Zhengyu On Thu, 2018-11-08 at 10:54 +0100, Michael Nitschinger wrote: > Hi, > > I?ve been trying to get GC information through the > GarbageCollectorMXBean instances and it is working great so far, > although I have a couple of questions. I couldn?t find any > documentation on this topic, so sorry if it is written up somewhere. > > I?m adding my NotificationListener to the MXBeans returned by the > ManagementFactory with shenandoah enabled and: > > when I?m looking at the ?cause? of the > GarbageCollectionNotificationInfo it always says ?No GC? which seems > weird to me (both for the Pauses and the Cycles bean) - even that the > action contains messages like ?end of major GC? or ?end of minor GC". > In terms of ?action?, Shenandoah Pauses always seems to return ?end > of major GC? while Shenandoah Cycles returns ?end of minor GC?, but > is that really accurate? There seems to be only one ?shenandoah? > memory pool and while the Cycles info has memory usage attached to > it, the Pauses one has no memory information whatsoever (all values > are zeroed out). > > I?m running on 1.8.0_181-b15 that ships with fedora and the only JVM > flag that I set was -XX:+UseShenandoahGC. > > Happy to provide more information if required, > Thanks, > Michael > From michael at nitschinger.at Fri Mar 1 16:26:52 2019 From: michael at nitschinger.at (Michael Nitschinger) Date: Fri, 1 Mar 2019 17:26:52 +0100 Subject: Question on Shenandoah GarbageCollectorMXBeans In-Reply-To: <1551457507.18805.141.camel@redhat.com> References: <30AA2877-69D7-45ED-AD71-C8DB09FCAF7E@nitschinger.at> <1551457507.18805.141.camel@redhat.com> Message-ID: <502DAA0F-3944-41AD-A31B-12379256F152@nitschinger.at> No problem at all, thanks for fixing! > On 01.03.2019, at 17:25, zgu at redhat.com wrote: > > Hi Michael, > > I have no idea how this message went under our radar for so long, I > just found out this morning, sorry! > > I filed https://bugs.openjdk.java.net/browse/JDK-8219976, and am > working on the fix. > > Thanks, > > -Zhengyu > > On Thu, 2018-11-08 at 10:54 +0100, Michael Nitschinger wrote: >> Hi, >> >> I?ve been trying to get GC information through the >> GarbageCollectorMXBean instances and it is working great so far, >> although I have a couple of questions. I couldn?t find any >> documentation on this topic, so sorry if it is written up somewhere. >> >> I?m adding my NotificationListener to the MXBeans returned by the >> ManagementFactory with shenandoah enabled and: >> >> when I?m looking at the ?cause? of the >> GarbageCollectionNotificationInfo it always says ?No GC? which seems >> weird to me (both for the Pauses and the Cycles bean) - even that the >> action contains messages like ?end of major GC? or ?end of minor GC". >> In terms of ?action?, Shenandoah Pauses always seems to return ?end >> of major GC? while Shenandoah Cycles returns ?end of minor GC?, but >> is that really accurate? There seems to be only one ?shenandoah? >> memory pool and while the Cycles info has memory usage attached to >> it, the Pauses one has no memory information whatsoever (all values >> are zeroed out). >> >> I?m running on 1.8.0_181-b15 that ships with fedora and the only JVM >> flag that I set was -XX:+UseShenandoahGC. >> >> Happy to provide more information if required, >> Thanks, >> Michael >> From zgu at redhat.com Fri Mar 1 16:44:20 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Fri, 01 Mar 2019 11:44:20 -0500 Subject: RFR(T) 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah Message-ID: <1551458660.18805.145.camel@redhat.com> Please review this trivial fix, that sets heap's GC cause during GC session, so the value can be picked up, instead of default one. Bug: https://bugs.openjdk.java.net/browse/JDK-8219976 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8219976/webrev.00/ Test: tier1, 2, 3_gc_shenandoah on Linux 64 (fastdebug and release) Thanks, -Zhengyu From zgu at redhat.com Fri Mar 1 19:57:50 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Fri, 01 Mar 2019 14:57:50 -0500 Subject: Shenandoah Events In-Reply-To: References: <1547056066.3477.71.camel@redhat.com> <1547213900.13989.11.camel@redhat.com> <1547497635.13989.39.camel@redhat.com> <1547503411.13989.42.camel@redhat.com> <1547576674.13989.57.camel@redhat.com> <47c53e84-3c0a-0e6c-361a-620c9c2b905c@redhat.com> <8efb1eef-cb06-b547-e6eb-804ac5d7db5c@redhat.com> Message-ID: <1551470270.18805.147.camel@redhat.com> Hi Ken, On Fri, 2019-01-18 at 16:02 -0500, Ken Dobson wrote: > Actually I've just gotten my authorship so here is a link to the > webrev. > > http://cr.openjdk.java.net/~kdobson/serializer/webrev/ > What's the status about this patch? Is it ready to go in? Do you need help to create RFE and sponsor? Thanks, -Zhengyu > > On Fri, Jan 18, 2019 at 12:43 PM Aleksey Shipilev > wrote: > > On 1/18/19 5:02 PM, Ken Dobson wrote: > > > On Wed, Jan 16, 2019 at 3:40 PM Aleksey Shipilev > m > wrote: > > > *) Not sure why some paths have JFR_ONLY, and some do not. > > Try to configure build with > > > --with-jvm-features=-jfr and build? Pretty sure you would > > need to put something like NO_JFR_RETURN > > > to send_jfr_region_transition_event declaration. > > > > > > I think JFR_ONLY is for when you call just a single jfr related > > function in a section of the code > > > that will still be run with JFR removed. It removes the code in > > that case. Is this what you mean by > > > NO_JFR_RETURN? > > > > There are two ways to conditionalize on JFR flag: > > > > a) Declare the function with NO_JFR_RETURN: > > > > blah.hpp: > > void my_jfr_event_handler() NO_JFR_RETURN; > > > > blah.cpp: > > #if INCLUDE_JFR > > void my_jfr_event_handler() { > > ... > > } > > #endif > > > > use.cpp: > > m() { > > my_jfr_event_handler(); > > } > > > > b) Declare the function completely, and protect all calls to it: > > > > blah.hpp: > > void my_jfr_event_handler(); > > > > blah.cpp: > > void my_jfr_event_handler() { > > #if INCLUDE_JFR > > ... > > #endif > > } > > > > use.cpp: > > m() { > > JFR_ONLY(my_jfr_event_handler();) > > } > > > > I prefer (a), because it looks more straight-forward and cleanly > > optimizeable. With new set_state > > function, both options are no longer viable: there is a code that > > should execute regardless of JFR. > > > > > Please give this a review when you have the chance, I'll check to > > make sure it causes no issues > > > configuring without JFR. > > > > I would, but the patch probably got stripped from the mailing list? > > > > -Aleksey > > From rkennke at redhat.com Fri Mar 1 20:42:09 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 1 Mar 2019 21:42:09 +0100 Subject: RFR(T) 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah In-Reply-To: <1551458660.18805.145.camel@redhat.com> References: <1551458660.18805.145.camel@redhat.com> Message-ID: <8eb5bfa3-aa78-f5f9-fe40-dd2f162ff1e9@redhat.com> Looks good to me. Thanks! Roman > Please review this trivial fix, that sets heap's GC cause during GC > session, so the value can be picked up, instead of default one. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8219976 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8219976/webrev.00/ > > Test: > tier1, 2, 3_gc_shenandoah on Linux 64 (fastdebug and release) > > > Thanks, > > -Zhengyu > From manc at google.com Fri Mar 1 21:42:56 2019 From: manc at google.com (Man Cao) Date: Fri, 1 Mar 2019 13:42:56 -0800 Subject: RFR (M): 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead In-Reply-To: References: <6b1e59ec7f4746e8e071fd44ec91ca966fac8d78.camel@oracle.com> <7e0c775d-86c1-b80c-b1a6-373ca21206ba@oracle.com> Message-ID: Hi, I rebased the patch to latest tip: https://cr.openjdk.java.net/~manc/8212206/webrev.03/ Could someone give a second "looks good"? -Man On Sat, Jan 26, 2019 at 4:35 PM Man Cao wrote: > Friendly ping. Could anyone give a second "looks good"? > > As for the develop flag > AdaptiveSizePolicyGCTimeLimitThreshold/GCOverheadLimitThreshold, I added a > note about it in https://bugs.openjdk.java.net/browse/JDK-8212084. > > -Man > > > On Tue, Jan 15, 2019 at 6:41 PM Man Cao wrote: > >> Hi, >> >> I rebased the patch to tip and updated year in some headers to 2019, >> without making any real change: >> http://cr.openjdk.java.net/~manc/8212206/webrev.02/ >> >> >> I don't foresee that this will be implemented, or even makes sense, for >>> ZGC. As I see it, this is only a thing STW collectors. For that reason, >>> I don't think it belongs in CollectedHeap. Keeping it as a separate >>> utility class for collectors that want to use it sounds better. >>> >> Sounds good to keep this patch in the current state, without further >> changing the CollectedHeap class. >> >> I haven't looked very closely at the patch, but couldn't help to notice >>> that the option is called "GCOverheapLimitThreshold" (and >>> "AdaptiveSizePolicyGCTimeLimitThreshold" before that), which is a >>> tautology and a not very good description of what it is. >>> How about we take the opportunity to clean this up and completely ditch >>> the "gc_overhead_limit_count" thing and get rid of this option? It's a >>> "develop" option, so it's not available to normal users anyway. Has >>> anyone of you ever used this option and actually find it valuable? >> >> I didn't find any users inside Google that require changing this option. >> That said, some users did complain that UseGCOverheadLimit for ParallelGC >> or CMS is too difficult to get >> triggered, because of the requirement for 5 consecutive full GCs, which >> is set by this option. >> I think if it were a normal "product" option, there will definitely be >> users setting it. >> I never understand why it is a "develop" option. I think we could either >> remove it, >> or make it an "experimental" option. >> I'm leaning towards not removing it for now, as I'm not sure if 5 is >> still a reasonable >> default value for UseGCOverheadLimit for G1. >> How about we decide whether to keep or remove this option after >> JDK-8212084 (UseGCOverheadLimit for G1) is fixed? >> >> Also for the hsperfdata counter change, I created >> https://bugs.openjdk.java.net/browse/JDK-8217221. I will draft a CSR for >> it later. >> >> -Man >> > From zgu at redhat.com Sat Mar 2 13:18:10 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Sat, 02 Mar 2019 08:18:10 -0500 Subject: RFR(T) 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah In-Reply-To: <8eb5bfa3-aa78-f5f9-fe40-dd2f162ff1e9@redhat.com> References: <1551458660.18805.145.camel@redhat.com> <8eb5bfa3-aa78-f5f9-fe40-dd2f162ff1e9@redhat.com> Message-ID: <1551532690.18805.154.camel@redhat.com> On Fri, 2019-03-01 at 21:42 +0100, Roman Kennke wrote: > Looks good to me. > Thanks, Roman. -Zhengyu > Thanks! > Roman > > > Please review this trivial fix, that sets heap's GC cause during GC > > session, so the value can be picked up, instead of default one. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8219976 > > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8219976/webrev.00/ > > > > Test: > > tier1, 2, 3_gc_shenandoah on Linux 64 (fastdebug and release) > > > > > > Thanks, > > > > -Zhengyu > > > > From shade at redhat.com Mon Mar 4 09:40:41 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 4 Mar 2019 10:40:41 +0100 Subject: Shenandoah Events In-Reply-To: <1551470270.18805.147.camel@redhat.com> References: <1547056066.3477.71.camel@redhat.com> <1547213900.13989.11.camel@redhat.com> <1547497635.13989.39.camel@redhat.com> <1547503411.13989.42.camel@redhat.com> <1547576674.13989.57.camel@redhat.com> <47c53e84-3c0a-0e6c-361a-620c9c2b905c@redhat.com> <8efb1eef-cb06-b547-e6eb-804ac5d7db5c@redhat.com> <1551470270.18805.147.camel@redhat.com> Message-ID: <3b124bd2-55c4-ac72-227f-65a791876d68@redhat.com> On 3/1/19 8:57 PM, zgu at redhat.com wrote: > On Fri, 2019-01-18 at 16:02 -0500, Ken Dobson wrote: >> Actually I've just gotten my authorship so here is a link to the >> webrev. >> >> http://cr.openjdk.java.net/~kdobson/serializer/webrev/ >> > What's the status about this patch? Is it ready to go in? Do you need > help to create RFE and sponsor? I see my edits never made it to the webrev: http://cr.openjdk.java.net/~shade/shenandoah/jfr-review-1.patch At least jfr_type_serializers should be initialized once, and not per region. -Aleksey From shade at redhat.com Mon Mar 4 11:51:06 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 4 Mar 2019 12:51:06 +0100 Subject: LRB midpath code quality Message-ID: Hi there, I have been looking into generated code quality for LRB. Run the gc-bench test that writes a single int: https://icedtea.classpath.org/hg/gc-bench/ $ ~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions -Xmx20g -XX:+UseShenandoahGC" writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee lrb.perfasm There are things to improve in default mode, but it is also visible with -XX:-UseCompressedOops: [Verified Entry Point] 7.34% 0x00007f60e3a167b0: mov %eax,-0x14000(%rsp) 5.73% 0x00007f60e3a167b7: push %rbp 6.09% 0x00007f60e3a167b8: sub $0x10,%rsp 5.31% 0x00007f60e3a167bc: mov 0x10(%rsi),%r10 .......................... LRB fastpath check .......................... 0.85% 0x00007f60e3a167c0: testb $0x1,0x20(%r15) 7.14% ? 0x00007f60e3a167c5: jne 0x00007f60e3a167db .........?......... LRB fastpath ends, store to %r10 follows ........... 0.38% ? ? 0x00007f60e3a167c7: movl $0x2a,0x20(%r10) 12.63% ? ? 0x00007f60e3a167cf: add $0x10,%rsp 0.40% ? ? 0x00007f60e3a167d3: pop %rbp 5.56% ? ? 0x00007f60e3a167d4: test %eax,0x177b9826(%rip) 0.29% ? ? 0x00007f60e3a167da: retq ---------?---?----------- LRB midpath starts -------------------------- .........?...?............ checking in-cset ........................... ? ? 0x00007f60e3a167db: mov %r10,%r11 ? 0x00007f60e3a167de: shr $0x17,%r11 ? 0x00007f60e3a167e2: movabs $0x7f60f309c048,%r8 ? 0x00007f60e3a167ec: cmpb $0x0,(%r8,%r11,1) ? ? 0x00007f60e3a167f1: je 0x00007f60e3a16806 ..........?..?............ checking null .............................. ? ? 0x00007f60e3a167f3: test %r10,%r10 ?? ? 0x00007f60e3a167f6: je 0x00007f60e3a16820 ..........??.?............ checking is-forwarded ...................... ?? ? 0x00007f60e3a167f8: mov -0x8(%r10),%r11 ?? ? 0x00007f60e3a167fc: cmp %r10,%r11 ???? 0x00007f60e3a167ff: je 0x00007f60e3a1680b ..........????............ return mess ................................ ?????? 0x00007f60e3a16801: mov %r11,%r10 ?????? 0x00007f60e3a16804: jmp 0x00007f60e3a167c7 ??? ?? 0x00007f60e3a16806: mov %r10,%r11 ?? ?? 0x00007f60e3a16809: jmp 0x00007f60e3a16801 ...........??..?.......... slowpath call .............................. ?? ? 0x00007f60e3a1680b: mov %r11,%rdi ? ? 0x00007f60e3a1680e: movabs $0x7f60f9afad70,%r10 ? ? 0x00007f60e3a16818: callq *%r10 ? ? 0x00007f60e3a1681b: mov %rax,%r11 ? ? 0x00007f60e3a1681e: jmp 0x00007f60e3a16801 I would have expected the branches return straight to 0x00007f60e3a167c7, instead of jumping through the "return mess", since %r10 is kept untouched. -XX:+UseCompressedOops is messier: [Verified Entry Point] 3.26% 0x00007f39ac476150: mov %eax,-0x14000(%rsp) 6.60% 0x00007f39ac476157: push %rbp 1.94% 0x00007f39ac476158: sub $0x10,%rsp 1.70% 0x00007f39ac47615c: mov 0xc(%rsi),%r11d .......................... LRB fastpath check .......................... 5.84% 0x00007f39ac476160: testb $0x1,0x20(%r15) 2.07% ? 0x00007f39ac476165: jne 0x00007f39ac47617c .........?......... LRB fastpath ends, store to %r11 follows ........... 1.36% ? ? 0x00007f39ac476167: movl $0x2a,0xc(%r12,%r11,8) 13.28% ? ? 0x00007f39ac476170: add $0x10,%rsp 3.36% ? ? 0x00007f39ac476174: pop %rbp 1.90% ? ? 0x00007f39ac476175: test %eax,0x19e85e85(%rip) 0.98% ? ? 0x00007f39ac47617b: retq ---------?---?----------- LRB midpath starts -------------------------- .........?...?............ checking in-cset ........................... ? ? 0x00007f39ac47617c: mov %r11,%r9 ? 0x00007f39ac47617f: shl $0x3,%r9 ? 0x00007f39ac476183: mov %r9,%r10 ? 0x00007f39ac476186: shr $0x17,%r10 ? 0x00007f39ac47618a: movabs $0x7f39bc0871e0,%r8 ? 0x00007f39ac476194: cmpb $0x0,(%r8,%r10,1) ? ? 0x00007f39ac476199: je 0x00007f39ac4761ae ..........?..?............ checking null .............................. ? ? 0x00007f39ac47619b: test %r11d,%r11d ?? ? 0x00007f39ac47619e: je 0x00007f39ac4761cc ..........??.?............ checking is-forwarded ...................... ?? ? 0x00007f39ac4761a0: mov -0x8(%r12,%r11,8),%r9 ?? ? 0x00007f39ac4761a5: lea (%r12,%r11,8),%r10 ?? ? 0x00007f39ac4761a9: cmp %r10,%r9 ???? 0x00007f39ac4761ac: je 0x00007f39ac4761b7 ..........????............ return mess ................................ ????? 0x00007f39ac4761ae: mov %r9,%r11 ???? 0x00007f39ac4761b1: shr $0x3,%r11 ???? 0x00007f39ac4761b5: jmp 0x00007f39ac476167 ...........??.?.......... slowpath call ............................... ?? ? 0x00007f39ac4761b7: mov %r9,%rdi ? ? 0x00007f39ac4761ba: movabs $0x7f39c4c26d70,%r10 ? ? 0x00007f39ac4761c4: callq *%r10 ? ? 0x00007f39ac4761c7: mov %rax,%r9 ? ? 0x00007f39ac4761ca: jmp 0x00007f39ac4761ae Same thing here, and "return mess" packs the reference back for returning. It seems useless as %r11 still carries the unpacked reference on non-in-cset path. Also, %r9 is available with unpacked reference during "checking is-forwarded" execution, being unpacked earlier during "checking in-cset". Maybe LRB expansion in C2 needs touchups to handle these, to optimize code size and performance when GC is active. -Aleksey From rkennke at redhat.com Mon Mar 4 12:49:02 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 04 Mar 2019 13:49:02 +0100 Subject: LRB midpath code quality In-Reply-To: References: Message-ID: <3A277B16-37D3-4F1B-822F-7A7EDF89DB20@redhat.com> Any ideas why C2 is doing this? Roland: do you think this can be improved? Thanks, Roman Am 4. M?rz 2019 12:51:06 MEZ schrieb Aleksey Shipilev : >Hi there, > >I have been looking into generated code quality for LRB. > >Run the gc-bench test that writes a single int: > https://icedtea.classpath.org/hg/gc-bench/ > >$ >~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java >-jar >target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions >-Xmx20g -XX:+UseShenandoahGC" >writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee >lrb.perfasm > >There are things to improve in default mode, but it is also visible >with -XX:-UseCompressedOops: > > [Verified Entry Point] > 7.34% 0x00007f60e3a167b0: mov %eax,-0x14000(%rsp) > 5.73% 0x00007f60e3a167b7: push %rbp > 6.09% 0x00007f60e3a167b8: sub $0x10,%rsp > 5.31% 0x00007f60e3a167bc: mov 0x10(%rsi),%r10 >.......................... LRB fastpath check >.......................... > 0.85% 0x00007f60e3a167c0: testb $0x1,0x20(%r15) > 7.14% ? 0x00007f60e3a167c5: jne 0x00007f60e3a167db >.........?......... LRB fastpath ends, store to %r10 follows >........... > 0.38% ? ? 0x00007f60e3a167c7: movl $0x2a,0x20(%r10) > 12.63% ? ? 0x00007f60e3a167cf: add $0x10,%rsp > 0.40% ? ? 0x00007f60e3a167d3: pop %rbp > 5.56% ? ? 0x00007f60e3a167d4: test %eax,0x177b9826(%rip) > 0.29% ? ? 0x00007f60e3a167da: retq >---------?---?----------- LRB midpath starts -------------------------- >.........?...?............ checking in-cset ........................... > ? ? 0x00007f60e3a167db: mov %r10,%r11 > ? 0x00007f60e3a167de: shr $0x17,%r11 > ? 0x00007f60e3a167e2: movabs $0x7f60f309c048,%r8 > ? 0x00007f60e3a167ec: cmpb $0x0,(%r8,%r11,1) > ? ? 0x00007f60e3a167f1: je 0x00007f60e3a16806 >..........?..?............ checking null .............................. > ? ? 0x00007f60e3a167f3: test %r10,%r10 > ?? ? 0x00007f60e3a167f6: je 0x00007f60e3a16820 >..........??.?............ checking is-forwarded ...................... > ?? ? 0x00007f60e3a167f8: mov -0x8(%r10),%r11 > ?? ? 0x00007f60e3a167fc: cmp %r10,%r11 > ???? 0x00007f60e3a167ff: je 0x00007f60e3a1680b >..........????............ return mess ................................ > ?????? 0x00007f60e3a16801: mov %r11,%r10 > ?????? 0x00007f60e3a16804: jmp 0x00007f60e3a167c7 > ??? ?? 0x00007f60e3a16806: mov %r10,%r11 > ?? ?? 0x00007f60e3a16809: jmp 0x00007f60e3a16801 >...........??..?.......... slowpath call .............................. > ?? ? 0x00007f60e3a1680b: mov %r11,%rdi > ? ? 0x00007f60e3a1680e: movabs $0x7f60f9afad70,%r10 > ? ? 0x00007f60e3a16818: callq *%r10 > ? ? 0x00007f60e3a1681b: mov %rax,%r11 > ? ? 0x00007f60e3a1681e: jmp 0x00007f60e3a16801 > > >I would have expected the branches return straight to >0x00007f60e3a167c7, instead of jumping through >the "return mess", since %r10 is kept untouched. > >-XX:+UseCompressedOops is messier: > > [Verified Entry Point] > 3.26% 0x00007f39ac476150: mov %eax,-0x14000(%rsp) > 6.60% 0x00007f39ac476157: push %rbp > 1.94% 0x00007f39ac476158: sub $0x10,%rsp > 1.70% 0x00007f39ac47615c: mov 0xc(%rsi),%r11d >.......................... LRB fastpath check >.......................... > 5.84% 0x00007f39ac476160: testb $0x1,0x20(%r15) > 2.07% ? 0x00007f39ac476165: jne 0x00007f39ac47617c >.........?......... LRB fastpath ends, store to %r11 follows >........... > 1.36% ? ? 0x00007f39ac476167: movl $0x2a,0xc(%r12,%r11,8) > 13.28% ? ? 0x00007f39ac476170: add $0x10,%rsp > 3.36% ? ? 0x00007f39ac476174: pop %rbp > 1.90% ? ? 0x00007f39ac476175: test %eax,0x19e85e85(%rip) > 0.98% ? ? 0x00007f39ac47617b: retq >---------?---?----------- LRB midpath starts -------------------------- >.........?...?............ checking in-cset ........................... > ? ? 0x00007f39ac47617c: mov %r11,%r9 > ? 0x00007f39ac47617f: shl $0x3,%r9 > ? 0x00007f39ac476183: mov %r9,%r10 > ? 0x00007f39ac476186: shr $0x17,%r10 > ? 0x00007f39ac47618a: movabs $0x7f39bc0871e0,%r8 > ? 0x00007f39ac476194: cmpb $0x0,(%r8,%r10,1) > ? ? 0x00007f39ac476199: je 0x00007f39ac4761ae >..........?..?............ checking null .............................. > ? ? 0x00007f39ac47619b: test %r11d,%r11d > ?? ? 0x00007f39ac47619e: je 0x00007f39ac4761cc >..........??.?............ checking is-forwarded ...................... > ?? ? 0x00007f39ac4761a0: mov -0x8(%r12,%r11,8),%r9 > ?? ? 0x00007f39ac4761a5: lea (%r12,%r11,8),%r10 > ?? ? 0x00007f39ac4761a9: cmp %r10,%r9 > ???? 0x00007f39ac4761ac: je 0x00007f39ac4761b7 >..........????............ return mess ................................ > ????? 0x00007f39ac4761ae: mov %r9,%r11 > ???? 0x00007f39ac4761b1: shr $0x3,%r11 > ???? 0x00007f39ac4761b5: jmp 0x00007f39ac476167 >...........??.?.......... slowpath call ............................... > ?? ? 0x00007f39ac4761b7: mov %r9,%rdi > ? ? 0x00007f39ac4761ba: movabs $0x7f39c4c26d70,%r10 > ? ? 0x00007f39ac4761c4: callq *%r10 > ? ? 0x00007f39ac4761c7: mov %rax,%r9 > ? ? 0x00007f39ac4761ca: jmp 0x00007f39ac4761ae > >Same thing here, and "return mess" packs the reference back for >returning. It seems useless as %r11 >still carries the unpacked reference on non-in-cset path. Also, %r9 is >available with unpacked >reference during "checking is-forwarded" execution, being unpacked >earlier during "checking in-cset". > >Maybe LRB expansion in C2 needs touchups to handle these, to optimize >code size and performance when >GC is active. > >-Aleksey -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From kdobson at redhat.com Mon Mar 4 15:11:54 2019 From: kdobson at redhat.com (Ken Dobson) Date: Mon, 4 Mar 2019 10:11:54 -0500 Subject: Shenandoah Events In-Reply-To: <3b124bd2-55c4-ac72-227f-65a791876d68@redhat.com> References: <1547056066.3477.71.camel@redhat.com> <1547213900.13989.11.camel@redhat.com> <1547497635.13989.39.camel@redhat.com> <1547503411.13989.42.camel@redhat.com> <1547576674.13989.57.camel@redhat.com> <47c53e84-3c0a-0e6c-361a-620c9c2b905c@redhat.com> <8efb1eef-cb06-b547-e6eb-804ac5d7db5c@redhat.com> <1551470270.18805.147.camel@redhat.com> <3b124bd2-55c4-ac72-227f-65a791876d68@redhat.com> Message-ID: Hi Aleksey, I've been using your edits to run the benchmarks I just haven't published a new webrev yet. Ken Dobson On Mon, Mar 4, 2019 at 4:40 AM Aleksey Shipilev wrote: > On 3/1/19 8:57 PM, zgu at redhat.com wrote: > > On Fri, 2019-01-18 at 16:02 -0500, Ken Dobson wrote: > >> Actually I've just gotten my authorship so here is a link to the > >> webrev. > >> > >> http://cr.openjdk.java.net/~kdobson/serializer/webrev/ > >> > > What's the status about this patch? Is it ready to go in? Do you need > > help to create RFE and sponsor? > > I see my edits never made it to the webrev: > http://cr.openjdk.java.net/~shade/shenandoah/jfr-review-1.patch > > At least jfr_type_serializers should be initialized once, and not per > region. > > -Aleksey > > From jborgers at jpinpoint.com Mon Mar 4 15:31:39 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Mon, 4 Mar 2019 16:31:39 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps Message-ID: Hi, First, thanks for the great work on ShenandoahGC! We want to use it for our big heaps. We have an application running with 420 GB heaps on a 24 core CPU (48 hardware threads) using ShenandoahGC. We have better results than G1, still not as good as expected. We have many degenerate GC pauses and some full GC pauses, last ones typically of around 30 s. Requirements are pauses < 16 ms, so we are not there yet. Load on the application is varying, with high load we get full GC's. We followed recommendations from the wiki. We enlarged heap size compared to G1 (340 to 420 GB), ConcGCThreads (16 seems ok), ParallelGCThreads (44 seems ok), played with pacing delay (50 seems ok), spike factor (5 seems ok) and we tried compact heuristics besides default adaptive. However, we still get those degenerate and full gc pauses with durations far above our requirements. Would it make sense to post the complete configuration, statistics logged and full gc log file? To get some tips, recommendations? The gc log file is rather large. Thanks in advance, Kind regards, Jeroen Borgers From shade at redhat.com Mon Mar 4 15:41:00 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 4 Mar 2019 16:41:00 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: Message-ID: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> On 3/4/19 4:31 PM, Jeroen Borgers wrote: > Would it make sense to post the complete configuration, statistics logged > and full gc log file? To get some tips, recommendations? The gc log file is > rather large. Yes, please post the full gc logs somewhere, and maybe post the excerpts around the failures somewhere too? -Aleksey From jborgers at jpinpoint.com Mon Mar 4 16:48:26 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Mon, 4 Mar 2019 17:48:26 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> Message-ID: Great. Please find 3 gc log files at: www.jpinpoint.com/resources/gc_Shenandoah_Thu.log.0.current.zip gc_Shenandoah_Thu.log.1.zip gc_shenandoah_Weekend_25.zip Kind regards, Jeroen Op ma 4 mrt. 2019 om 16:43 schreef Aleksey Shipilev : > On 3/4/19 4:31 PM, Jeroen Borgers wrote: > > Would it make sense to post the complete configuration, statistics logged > > and full gc log file? To get some tips, recommendations? The gc log file > is > > rather large. > > Yes, please post the full gc logs somewhere, and maybe post the excerpts > around the failures > somewhere too? > > -Aleksey > > From shade at redhat.com Mon Mar 4 17:28:55 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 4 Mar 2019 18:28:55 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> Message-ID: <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> On 3/4/19 5:48 PM, Jeroen Borgers wrote: > Please find 3 gc log files at: > www.jpinpoint.com/resources/gc_Shenandoah_Thu.log.0.current.zip > > gc_Shenandoah_Thu.log.1.zip > gc_shenandoah_Weekend_25.zip Briefly looking at one of the logs, Weekend_25.zip. *) First things first, command line options: CommandLine flags: -XX:-AlwaysPreTouch -XX:+ClassUnloadingWithConcurrentMark -XX:ConcGCThreads=16 -XX:GCLogFileSize=10485760 -XX:InitialHeapSize=450971566080 -XX:InitialTenuringThreshold=2 -XX:+LogVMOutput -XX:+ManagementServer -XX:MaxHeapSize=450971566080 -XX:MaxTenuringThreshold=2 -XX:NumberOfGCLogFiles=10 -XX:ParallelGCThreads=44 -XX:+PrintGC -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -XX:ShenandoahAllocSpikeFactor=5 -XX:+ShenandoahAllocationTrace -XX:ShenandoahPacingMaxDelay=50 -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions -XX:+UseGCLogFileRotation -XX:+UseNUMA -XX:+UseNUMAInterleaving -XX:+UseShenandoahGC -XX:+UseTransparentHugePages - Consider enabling -XX:+AlwaysPreTouch, especially as you are running with NUMA turned on and THP turned on. If memory allocator and/or defragger kicks in at unfortunate times, it might stall the collector enough to trip off the the concurrent mode; - These options are useless for Shenandoah: "-XX:InitialTenuringThreshold=2 -XX:MaxTenuringThreshold=2" - "-XX:InitialHeapSize=450971566080 -XX:MaxHeapSize=450971566080", but machine has "physical 528157524k(460445396k free)". There is some native memory spent on top of heap size, are you sure the machine never swaps? *) 8u191 Shenandoah is a bit old, which might not have all the performance touchups. Sorry about that. Can you try our 8u nightlies? https://builds.shipilev.net/openjdk-shenandoah-jdk8/ *) From very far out, it seems that the normal GC cycle takes around 16 seconds in that config. And the live data set is around 260G (the heap size after Full GC) of 420G max. Which means, any allocation spike at 10+ GB/sec would tank the whole thing. I'd say if you cannot crank up the heap, then you'd have to choose whether you want much larger allocation pacing delay (i.e. seconds) or accept more Degen/Full GCs. *) Looking at progression of some counters: $ grep "Actual Free" gc_shenandoah_Weekend_25.logfull | less ...it seems it slowly goes down, until Full GC recovers from it. We have seen those as heuristics issues before, and it should be fixed in recent 8u's, but probably not in 8u191. -Aleksey From rkennke at redhat.com Mon Mar 4 21:29:12 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 4 Mar 2019 22:29:12 +0100 Subject: LRB midpath code quality In-Reply-To: References: Message-ID: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> Also, it seems weird that the null-check is after the in-cset-check, but not before. It's probably a left-over from null-check-cloning that should actually disappear too? Roman > Hi there, > > I have been looking into generated code quality for LRB. > > Run the gc-bench test that writes a single int: > https://icedtea.classpath.org/hg/gc-bench/ > > $ ~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar > target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions -Xmx20g -XX:+UseShenandoahGC" > writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee lrb.perfasm > > There are things to improve in default mode, but it is also visible with -XX:-UseCompressedOops: > > [Verified Entry Point] > 7.34% 0x00007f60e3a167b0: mov %eax,-0x14000(%rsp) > 5.73% 0x00007f60e3a167b7: push %rbp > 6.09% 0x00007f60e3a167b8: sub $0x10,%rsp > 5.31% 0x00007f60e3a167bc: mov 0x10(%rsi),%r10 > .......................... LRB fastpath check .......................... > 0.85% 0x00007f60e3a167c0: testb $0x1,0x20(%r15) > 7.14% ? 0x00007f60e3a167c5: jne 0x00007f60e3a167db > .........?......... LRB fastpath ends, store to %r10 follows ........... > 0.38% ? ? 0x00007f60e3a167c7: movl $0x2a,0x20(%r10) > 12.63% ? ? 0x00007f60e3a167cf: add $0x10,%rsp > 0.40% ? ? 0x00007f60e3a167d3: pop %rbp > 5.56% ? ? 0x00007f60e3a167d4: test %eax,0x177b9826(%rip) > 0.29% ? ? 0x00007f60e3a167da: retq > ---------?---?----------- LRB midpath starts -------------------------- > .........?...?............ checking in-cset ........................... > ? ? 0x00007f60e3a167db: mov %r10,%r11 > ? 0x00007f60e3a167de: shr $0x17,%r11 > ? 0x00007f60e3a167e2: movabs $0x7f60f309c048,%r8 > ? 0x00007f60e3a167ec: cmpb $0x0,(%r8,%r11,1) > ? ? 0x00007f60e3a167f1: je 0x00007f60e3a16806 > ..........?..?............ checking null .............................. > ? ? 0x00007f60e3a167f3: test %r10,%r10 > ?? ? 0x00007f60e3a167f6: je 0x00007f60e3a16820 > ..........??.?............ checking is-forwarded ...................... > ?? ? 0x00007f60e3a167f8: mov -0x8(%r10),%r11 > ?? ? 0x00007f60e3a167fc: cmp %r10,%r11 > ???? 0x00007f60e3a167ff: je 0x00007f60e3a1680b > ..........????............ return mess ................................ > ?????? 0x00007f60e3a16801: mov %r11,%r10 > ?????? 0x00007f60e3a16804: jmp 0x00007f60e3a167c7 > ??? ?? 0x00007f60e3a16806: mov %r10,%r11 > ?? ?? 0x00007f60e3a16809: jmp 0x00007f60e3a16801 > ...........??..?.......... slowpath call .............................. > ?? ? 0x00007f60e3a1680b: mov %r11,%rdi > ? ? 0x00007f60e3a1680e: movabs $0x7f60f9afad70,%r10 > ? ? 0x00007f60e3a16818: callq *%r10 > ? ? 0x00007f60e3a1681b: mov %rax,%r11 > ? ? 0x00007f60e3a1681e: jmp 0x00007f60e3a16801 > > > I would have expected the branches return straight to 0x00007f60e3a167c7, instead of jumping through > the "return mess", since %r10 is kept untouched. > > -XX:+UseCompressedOops is messier: > > [Verified Entry Point] > 3.26% 0x00007f39ac476150: mov %eax,-0x14000(%rsp) > 6.60% 0x00007f39ac476157: push %rbp > 1.94% 0x00007f39ac476158: sub $0x10,%rsp > 1.70% 0x00007f39ac47615c: mov 0xc(%rsi),%r11d > .......................... LRB fastpath check .......................... > 5.84% 0x00007f39ac476160: testb $0x1,0x20(%r15) > 2.07% ? 0x00007f39ac476165: jne 0x00007f39ac47617c > .........?......... LRB fastpath ends, store to %r11 follows ........... > 1.36% ? ? 0x00007f39ac476167: movl $0x2a,0xc(%r12,%r11,8) > 13.28% ? ? 0x00007f39ac476170: add $0x10,%rsp > 3.36% ? ? 0x00007f39ac476174: pop %rbp > 1.90% ? ? 0x00007f39ac476175: test %eax,0x19e85e85(%rip) > 0.98% ? ? 0x00007f39ac47617b: retq > ---------?---?----------- LRB midpath starts -------------------------- > .........?...?............ checking in-cset ........................... > ? ? 0x00007f39ac47617c: mov %r11,%r9 > ? 0x00007f39ac47617f: shl $0x3,%r9 > ? 0x00007f39ac476183: mov %r9,%r10 > ? 0x00007f39ac476186: shr $0x17,%r10 > ? 0x00007f39ac47618a: movabs $0x7f39bc0871e0,%r8 > ? 0x00007f39ac476194: cmpb $0x0,(%r8,%r10,1) > ? ? 0x00007f39ac476199: je 0x00007f39ac4761ae > ..........?..?............ checking null .............................. > ? ? 0x00007f39ac47619b: test %r11d,%r11d > ?? ? 0x00007f39ac47619e: je 0x00007f39ac4761cc > ..........??.?............ checking is-forwarded ...................... > ?? ? 0x00007f39ac4761a0: mov -0x8(%r12,%r11,8),%r9 > ?? ? 0x00007f39ac4761a5: lea (%r12,%r11,8),%r10 > ?? ? 0x00007f39ac4761a9: cmp %r10,%r9 > ???? 0x00007f39ac4761ac: je 0x00007f39ac4761b7 > ..........????............ return mess ................................ > ????? 0x00007f39ac4761ae: mov %r9,%r11 > ???? 0x00007f39ac4761b1: shr $0x3,%r11 > ???? 0x00007f39ac4761b5: jmp 0x00007f39ac476167 > ...........??.?.......... slowpath call ............................... > ?? ? 0x00007f39ac4761b7: mov %r9,%rdi > ? ? 0x00007f39ac4761ba: movabs $0x7f39c4c26d70,%r10 > ? ? 0x00007f39ac4761c4: callq *%r10 > ? ? 0x00007f39ac4761c7: mov %rax,%r9 > ? ? 0x00007f39ac4761ca: jmp 0x00007f39ac4761ae > > Same thing here, and "return mess" packs the reference back for returning. It seems useless as %r11 > still carries the unpacked reference on non-in-cset path. Also, %r9 is available with unpacked > reference during "checking is-forwarded" execution, being unpacked earlier during "checking in-cset". > > Maybe LRB expansion in C2 needs touchups to handle these, to optimize code size and performance when > GC is active. > > -Aleksey > From manc at google.com Mon Mar 4 22:41:43 2019 From: manc at google.com (Man Cao) Date: Mon, 4 Mar 2019 14:41:43 -0800 Subject: RFR (M): 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead In-Reply-To: References: <6b1e59ec7f4746e8e071fd44ec91ca966fac8d78.camel@oracle.com> <7e0c775d-86c1-b80c-b1a6-373ca21206ba@oracle.com> Message-ID: Thanks for taking a look, Jiangli. I renamed "permanent gen" to "metaspace". I double checked that currently full GCs due to metaspace expansion will not affect the calculation of GC overhead . New webrev: https://cr.openjdk.java.net/~manc/8212206/webrev.04/ -Man On Sun, Mar 3, 2019 at 11:48 AM Jiangli Zhou wrote: > Hi Man, > > As both Thomas and Per seemed to be okay with the refactoring, you > probably had sufficient approval already. > > The following comment in adaptiveSizePolicy.cpp seems to be outdated. The > comment predates the PermGen removal. It's probably a good idea to also > cleanup the comment as part of your refactoring change. > > 281 // Note that the gc time limit test only works for the collections 282 // of the young gen + tenured gen and not for collections of the 283 // permanent gen. That is because the calculation of the space 284 // freed by the collection is the free space in the young gen + 285 // tenured gen. > > Thanks and regards, > > Jiangli > > > On Fri, Mar 1, 2019 at 1:43 PM Man Cao wrote: > >> Hi, >> >> I rebased the patch to latest tip: >> https://cr.openjdk.java.net/~manc/8212206/webrev.03/ >> >> Could someone give a second "looks good"? >> >> -Man >> >> >> On Sat, Jan 26, 2019 at 4:35 PM Man Cao wrote: >> >>> Friendly ping. Could anyone give a second "looks good"? >>> >>> As for the develop flag >>> AdaptiveSizePolicyGCTimeLimitThreshold/GCOverheadLimitThreshold, I added a >>> note about it in https://bugs.openjdk.java.net/browse/JDK-8212084. >>> >>> -Man >>> >>> >>> On Tue, Jan 15, 2019 at 6:41 PM Man Cao wrote: >>> >>>> Hi, >>>> >>>> I rebased the patch to tip and updated year in some headers to 2019, >>>> without making any real change: >>>> http://cr.openjdk.java.net/~manc/8212206/webrev.02/ >>>> >>>> >>>> I don't foresee that this will be implemented, or even makes sense, for >>>>> ZGC. As I see it, this is only a thing STW collectors. For that >>>>> reason, >>>>> I don't think it belongs in CollectedHeap. Keeping it as a separate >>>>> utility class for collectors that want to use it sounds better. >>>>> >>>> Sounds good to keep this patch in the current state, without further >>>> changing the CollectedHeap class. >>>> >>>> I haven't looked very closely at the patch, but couldn't help to notice >>>>> that the option is called "GCOverheapLimitThreshold" (and >>>>> "AdaptiveSizePolicyGCTimeLimitThreshold" before that), which is a >>>>> tautology and a not very good description of what it is. >>>>> How about we take the opportunity to clean this up and completely >>>>> ditch >>>>> the "gc_overhead_limit_count" thing and get rid of this option? It's a >>>>> "develop" option, so it's not available to normal users anyway. Has >>>>> anyone of you ever used this option and actually find it valuable? >>>> >>>> I didn't find any users inside Google that require changing this option. >>>> That said, some users did complain that UseGCOverheadLimit for >>>> ParallelGC or CMS is too difficult to get >>>> triggered, because of the requirement for 5 consecutive full GCs, which >>>> is set by this option. >>>> I think if it were a normal "product" option, there will definitely be >>>> users setting it. >>>> I never understand why it is a "develop" option. I think we could >>>> either remove it, >>>> or make it an "experimental" option. >>>> I'm leaning towards not removing it for now, as I'm not sure if 5 is >>>> still a reasonable >>>> default value for UseGCOverheadLimit for G1. >>>> How about we decide whether to keep or remove this option after >>>> JDK-8212084 (UseGCOverheadLimit for G1) is fixed? >>>> >>>> Also for the hsperfdata counter change, I created >>>> https://bugs.openjdk.java.net/browse/JDK-8217221. I will draft a CSR >>>> for it later. >>>> >>>> -Man >>>> >>> From manc at google.com Tue Mar 5 02:20:03 2019 From: manc at google.com (Man Cao) Date: Mon, 4 Mar 2019 18:20:03 -0800 Subject: RFR (M): 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead In-Reply-To: References: <6b1e59ec7f4746e8e071fd44ec91ca966fac8d78.camel@oracle.com> <7e0c775d-86c1-b80c-b1a6-373ca21206ba@oracle.com> Message-ID: After offline discussion with Jiangli, we think it is better to just remove this comment block. The reason is that full GCs due to metaspace expansion will not take the code path to execute AdaptiveSizePolicy::check_gc_overhead_limit(), because of the check for AdaptiveSizePolicy::should_update_promo_stats(). New webrev: https://cr.openjdk.java.net/~manc/8212206/webrev.05/ -Man On Mon, Mar 4, 2019 at 2:41 PM Man Cao wrote: > Thanks for taking a look, Jiangli. I renamed "permanent gen" to > "metaspace". > I double checked that currently full GCs due to metaspace expansion will > not affect the calculation of GC overhead . > > New webrev: https://cr.openjdk.java.net/~manc/8212206/webrev.04/ > > -Man > > > On Sun, Mar 3, 2019 at 11:48 AM Jiangli Zhou > wrote: > >> Hi Man, >> >> As both Thomas and Per seemed to be okay with the refactoring, you >> probably had sufficient approval already. >> >> The following comment in adaptiveSizePolicy.cpp seems to be outdated. The >> comment predates the PermGen removal. It's probably a good idea to also >> cleanup the comment as part of your refactoring change. >> >> 281 // Note that the gc time limit test only works for the collections 282 // of the young gen + tenured gen and not for collections of the 283 // permanent gen. That is because the calculation of the space 284 // freed by the collection is the free space in the young gen + 285 // tenured gen. >> >> Thanks and regards, >> >> Jiangli >> >> From rwestrel at redhat.com Tue Mar 5 08:10:37 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Tue, 05 Mar 2019 09:10:37 +0100 Subject: LRB midpath code quality In-Reply-To: <3A277B16-37D3-4F1B-822F-7A7EDF89DB20@redhat.com> References: <3A277B16-37D3-4F1B-822F-7A7EDF89DB20@redhat.com> Message-ID: <87r2blyc5e.fsf@redhat.com> > Any ideas why C2 is doing this? > > Roland: do you think this can be improved? That looks like some register allocation anomaly. I'm not sure there's much we can do. Roland. From rwestrel at redhat.com Tue Mar 5 08:12:38 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Tue, 05 Mar 2019 09:12:38 +0100 Subject: LRB midpath code quality In-Reply-To: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> Message-ID: <87mum9yc21.fsf@redhat.com> > Also, it seems weird that the null-check is after the in-cset-check, but > not before. It's probably a left-over from null-check-cloning that > should actually disappear too? It looks like it's not converted to an implicit null check for some reason. Roland. From rkennke at redhat.com Tue Mar 5 09:07:37 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 05 Mar 2019 10:07:37 +0100 Subject: LRB midpath code quality In-Reply-To: <87mum9yc21.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> Message-ID: Am 5. M?rz 2019 09:12:38 MEZ schrieb Roland Westrelin : > >> Also, it seems weird that the null-check is after the in-cset-check, >but >> not before. It's probably a left-over from null-check-cloning that >> should actually disappear too? > >It looks like it's not converted to an implicit null check for some >reason. Do we even need a null check there, implicit or not? There should be a null-check before in-cset-check which apparently got eliminated, in any case we would blow up there, no? No way we would even get to the later null-check with an actual null. Maybe this causes the register hiccup in return paths? Or are we wiring up the wrong nodes into the phi? Uncasted_val vs. val? Thanks, Roman -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From rwestrel at redhat.com Tue Mar 5 09:11:33 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Tue, 05 Mar 2019 10:11:33 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> Message-ID: <87imwxy9bu.fsf@redhat.com> > Do we even need a null check there, implicit or not? There should be a > null-check before in-cset-check which apparently got eliminated, in > any case we would blow up there, no? No way we would even get to the > later null-check with an actual null. Unless I'm missing something, there's a a barrier right after the null check so we need the null check: ..........?..?............ checking null .............................. ? ? 0x00007f60e3a167f3: test %r10,%r10 ?? ? 0x00007f60e3a167f6: je 0x00007f60e3a16820 ..........??.?............ checking is-forwarded ...................... ?? ? 0x00007f60e3a167f8: mov -0x8(%r10),%r11 It should be an implicit null check as I understand. Roland. From rkennke at redhat.com Tue Mar 5 09:18:29 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 05 Mar 2019 10:18:29 +0100 Subject: LRB midpath code quality In-Reply-To: <87imwxy9bu.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> Message-ID: Am 5. M?rz 2019 10:11:33 MEZ schrieb Roland Westrelin : > >> Do we even need a null check there, implicit or not? There should be >a >> null-check before in-cset-check which apparently got eliminated, in >> any case we would blow up there, no? No way we would even get to the >> later null-check with an actual null. > >Unless I'm missing something, there's a a barrier right after the null >check so we need the null check: > >..........?..?............ checking null .............................. > ? ? 0x00007f60e3a167f3: test %r10,%r10 > ?? ? 0x00007f60e3a167f6: je 0x00007f60e3a16820 >..........??.?............ checking is-forwarded ...................... > ?? ? 0x00007f60e3a167f8: mov -0x8(%r10),%r11 > > >It should be an implicit null check as I understand. Well yes, an implicit null-check would be good. It would never fire, because if the value is null, it would blow up earlier in the cset check. Or am I missing something? Roman -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From jborgers at jpinpoint.com Tue Mar 5 09:51:43 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 10:51:43 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> Message-ID: Hi Aleksey, Thanks for your remarks. In addition to Edwins findings: 1.1 AlwaysPreTouch seems to be on while reported as off, as shown in 'ps' and in logfile it says (line 12:) Parallel pretouch 13440 regions with 2097152 byte pages 1.2 Right, left overs from previous GC, jvm options to remove 1.3 Right, swapping must be avoided at any time 2. Good to know! We'll use new 8u nightlies 3. Right, sudden high allocation rates are a problem. Getting more memory will take time. We might be able to throttle the load somewhat. Like my colleague found, (transparent) huge pages do not seem to be utilized fully. I see in the log file: Memory: 4k page, physical 528157524k(460445396k free), swap 2097148k(1463356k free) and on line 12: Parallel pretouch 13440 regions with 2097152 byte pages So it seems to use both 4kB and 2MB pages. The latter area is only 26 GB. We don't understand this nor how to solve it. Suggestions very welcome. -Jeroen Op di 5 mrt. 2019 om 09:19 schreef Edwin Graven : > Aleksey > > Thanks for looking into this I'm a colleague of Jeroen and can answer most of the questions > > We start the application with the option -XX:+AlwaysPreTouch > > if i look at the ps outpot it's also stating > > acv 35165 1 99 Mar04 ? 9-09:00:00 java -server > -Drss.configuration.propertiesFile=/appl/acv/server/conf/server.properties > -Djava.library.path=bin:/opt/mqm/java/lib64:/appl/acv/kafka/libs > -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=8005 > -Dcom.sun.management.jmxremote.authenticate=true > -Dcom.sun.management.jmxremote.password.file=/appl/acv/server/conf/jmxauth/jmxremote.password > > -Dcom.sun.management.jmxremote.access.file=/appl/acv/server/conf/jmxauth/jmxremote.access > -Dcom.sun.management.jmxremote.ssl=false > -Djsse.enableSNIExtension=false -XX:+UseShenandoahGC -XX:+UseNUMA > -XX:+UseTransparentHugePages -XX:+UnlockDiagnosticVMOptions > -XX:+ShenandoahAllocationTrace -XX:+LogVMOutput -XX:ParallelGCThreads=44 > -XX:ShenandoahGCHeuristics=adaptive -XX:ConcGCThreads=16 > -XX:+UnlockExperimentalVMOptions -XX:+ClassUnloadingWithConcurrentMark > -XX:ShenandoahAllocSpikeFactor=7 -XX:ShenandoahPacingMaxDelay=75 > -XX:+AlwaysPreTouch -verbosegc -Xms420g -Xmx420g > -XX:+UseGCLogFileRotation -XX:+PrintGCDetails -XX:NumberOfGCLogFiles=10 > -XX:GCLogFileSize=10M -XX:MaxTenuringThreshold=2 > -Xloggc:/appl/acv/log/server/gc_Shenandoah_Mon.log -classpath > lib/.:lib/*:/opt/mqm/java/lib/*:/appl/acv/kafka/libs/*:/appl/acv/server/custom/* > com.riskshield.server.Starter -i/appl/acv/server/conf/server.ini > > Not sure why it's reporting in the gc log with -XX:-AlwaysPreTouch. we are currently testing with 2 machines and we are > seeing this behavior on both machines. > > Both machine have 512GB installed. swap space is set to 2GB on both machines. when running for a while (3days) both machines > have still 60G available (1G free mem and 59G filecache) > > I'm going to try to install 8u nightlies today. > > an other strange thing we encounter is that we used the option UseTransparentHugePages But hardly any pages are in hugepages > when we start is we see around 12G address as hugepages and it stays on that level. > > If we start the G1 collector with TransparentHugepages we see it running up to 290G. > currently we are using G1 on our production system with largepages (vm.nr_hugepages) also tried this option in combination with > Shenandoah but then java reports that there is nog enough memory, it does not look at the reserved block (vm.nr_hugepages) > > Edwin Graven > > > On 3/4/19 6:28 PM, Aleksey Shipilev wrote: > > On 3/4/19 5:48 PM, Jeroen Borgers wrote: > > Please find 3 gc log files at:www.jpinpoint.com/resources/gc_Shenandoah_Thu.log.0.current.zip > gc_Shenandoah_Thu.log.1.zip > gc_shenandoah_Weekend_25.zip > > > Briefly looking at one of the logs, Weekend_25.zip. > > *) First things first, command line options: > > CommandLine flags: -XX:-AlwaysPreTouch -XX:+ClassUnloadingWithConcurrentMark -XX:ConcGCThreads=16 > -XX:GCLogFileSize=10485760 -XX:InitialHeapSize=450971566080 -XX:InitialTenuringThreshold=2 > -XX:+LogVMOutput -XX:+ManagementServer -XX:MaxHeapSize=450971566080 -XX:MaxTenuringThreshold=2 > -XX:NumberOfGCLogFiles=10 -XX:ParallelGCThreads=44 -XX:+PrintGC -XX:+PrintGCDetails > -XX:+PrintGCTimeStamps -XX:ShenandoahAllocSpikeFactor=5 -XX:+ShenandoahAllocationTrace > -XX:ShenandoahPacingMaxDelay=50 -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions > -XX:+UseGCLogFileRotation -XX:+UseNUMA -XX:+UseNUMAInterleaving -XX:+UseShenandoahGC > -XX:+UseTransparentHugePages > > - Consider enabling -XX:+AlwaysPreTouch, especially as you are running with NUMA turned on and THP > turned on. If memory allocator and/or defragger kicks in at unfortunate times, it might stall the > collector enough to trip off the the concurrent mode; > > - These options are useless for Shenandoah: "-XX:InitialTenuringThreshold=2 -XX:MaxTenuringThreshold=2" > > - "-XX:InitialHeapSize=450971566080 -XX:MaxHeapSize=450971566080", but machine has "physical > 528157524k(460445396k free)". There is some native memory spent on top of heap size, are you sure > the machine never swaps? > > > *) 8u191 Shenandoah is a bit old, which might not have all the performance touchups. Sorry about > that. Can you try our 8u nightlies? https://builds.shipilev.net/openjdk-shenandoah-jdk8/ > > *) From very far out, it seems that the normal GC cycle takes around 16 seconds in that config. And > the live data set is around 260G (the heap size after Full GC) of 420G max. Which means, any > allocation spike at 10+ GB/sec would tank the whole thing. I'd say if you cannot crank up the heap, > then you'd have to choose whether you want much larger allocation pacing delay (i.e. seconds) or > accept more Degen/Full GCs. > > *) Looking at progression of some counters: > > $ grep "Actual Free" gc_shenandoah_Weekend_25.logfull | less > > ...it seems it slowly goes down, until Full GC recovers from it. We have seen those as heuristics > issues before, and it should be fixed in recent 8u's, but probably not in 8u191. > > > -Aleksey > > From shade at redhat.com Tue Mar 5 11:19:32 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 12:19:32 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> Message-ID: <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> On 3/5/19 10:51 AM, Jeroen Borgers wrote: > Thanks for your remarks. In addition to Edwins findings: > 1.1 AlwaysPreTouch seems to be on while reported as off, as shown in 'ps' and in logfile it says > (line 12:) Right. Sorry, my bad, that's Shenandoah reverting dropping AlwaysPreTouch and enabling ShenandoahAlwaysPretouch specifically. It needs to be that way to avoid hitting serial pretouch code that would wreck up NUMA interleaving. > 3. Right, sudden high allocation rates are a problem. Getting more memory will take time. We might > be able to throttle the load somewhat. Yes, either throttle the load (for example, beef up pacing threshold), or maybe beef up the ConcGCThreads? > Like my colleague found, (transparent) huge pages do not seem to be utilized fully. I see in the log > file: > Memory: 4k page, physical 528157524k(460445396k free), swap 2097148k(1463356k free)?? > and on line 12: > Parallel pretouch 13440 regions with 2097152 byte pages > So it seems to use both 4kB and 2MB pages. The latter area is only 26 GB. > We don't understand this nor how to solve it. Suggestions very welcome. This is Shenandoah bug! Argh. Tracked here: https://bugs.openjdk.java.net/browse/JDK-8220153 -Aleksey From jborgers at jpinpoint.com Tue Mar 5 12:24:05 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 13:24:05 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: Op di 5 mrt. 2019 om 12:20 schreef Aleksey Shipilev : > On 3/5/19 10:51 AM, Jeroen Borgers wrote: > > Thanks for your remarks. In addition to Edwins findings: > > 1.1 AlwaysPreTouch seems to be on while reported as off, as shown in > 'ps' and in logfile it says > > (line 12:) > > Right. Sorry, my bad, that's Shenandoah reverting dropping AlwaysPreTouch > and enabling > ShenandoahAlwaysPretouch specifically. It needs to be that way to avoid > hitting serial pretouch code > that would wreck up NUMA interleaving. > Ok, good to know. > > > 3. Right, sudden high allocation rates are a problem. Getting more > memory will take time. We might > > be able to throttle the load somewhat. > > Yes, either throttle the load (for example, beef up pacing threshold), or > maybe beef up the > ConcGCThreads? > > We hope we can throttle the system that puts sudden load on our application. Beefing up the ConcGCThreads might also be an option, although we are almost at 100% CPU with high load. Application can progress slower and lose max 16 ms on 30 ms by getting less CPU time, so we might try e.g. 24 or 32. > > Like my colleague found, (transparent) huge pages do not seem to be > utilized fully. I see in the log > > file: > > Memory: 4k page, physical 528157524k(460445396k free), swap > 2097148k(1463356k free) > > and on line 12: > > Parallel pretouch 13440 regions with 2097152 byte pages > > So it seems to use both 4kB and 2MB pages. The latter area is only 26 GB. > > We don't understand this nor how to solve it. Suggestions very welcome. > > This is Shenandoah bug! Argh. Tracked here: > https://bugs.openjdk.java.net/browse/JDK-8220153 > > Ah, good finding! And I see your patch solves it, right? When will this be available? > -Aleksey > > -Jeroen From jborgers at jpinpoint.com Tue Mar 5 13:17:51 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 14:17:51 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: Hi, Another question. We set max pacing delay to 50 ms. However, the histogram shows differently (weekend log file): Actual pacing delays histogram: From - To Count Sum 1 ms - 2 ms: 1391036 695518 ms 2 ms - 4 ms: 1005742 1005742 ms 4 ms - 8 ms: 821336 1642672 ms 8 ms - 16 ms: 702322 2809288 ms 16 ms - 32 ms: 617988 4943904 ms 32 ms - 64 ms: 11181201 178899216 ms 64 ms - 128 ms: 3687 117984 ms 128 ms - 256 ms: 12 768 ms 256 ms - 512 ms: 0 0 ms 512 ms - 1024 ms: 0 0 ms 1024 ms - 2048 ms: 24 12288 ms 2048 ms - 4096 ms: 18 18432 ms 4096 ms - 8192 ms: 195 399360 ms 8192 ms - 16384 ms: 478 1957888 ms Total: 15724039 192503060 ms There are many > 64 ms., while we specify 50 ms as max? I don't understand. And the total time individual threads are stopped is huge: 192_503 s. Much more than the STW time: Total Pauses (G) = 4133.93 s (a = 95487 us) (n = 43293) (lvls, us = 525, 2969, 10938, 18750, 34999971) If I multiply the latter by 48 (assuming every hardware thread is utilized by 1 app thread; all are affected during STW) I get: 198_384 s. Similar to the total pacing time. Does this mean that our app is stopped by pacing in the same order as by STW pauses? -Jeroen Op di 5 mrt. 2019 om 13:24 schreef Jeroen Borgers : > > Op di 5 mrt. 2019 om 12:20 schreef Aleksey Shipilev : > >> On 3/5/19 10:51 AM, Jeroen Borgers wrote: >> > Thanks for your remarks. In addition to Edwins findings: >> > 1.1 AlwaysPreTouch seems to be on while reported as off, as shown in >> 'ps' and in logfile it says >> > (line 12:) >> >> Right. Sorry, my bad, that's Shenandoah reverting dropping AlwaysPreTouch >> and enabling >> ShenandoahAlwaysPretouch specifically. It needs to be that way to avoid >> hitting serial pretouch code >> that would wreck up NUMA interleaving. >> > > Ok, good to know. > > >> >> > 3. Right, sudden high allocation rates are a problem. Getting more >> memory will take time. We might >> > be able to throttle the load somewhat. >> >> Yes, either throttle the load (for example, beef up pacing threshold), or >> maybe beef up the >> ConcGCThreads? >> >> We hope we can throttle the system that puts sudden load on our > application. Beefing up the ConcGCThreads might also be an option, although > we are almost at 100% CPU with high load. Application can progress slower > and lose max 16 ms on 30 ms by getting less CPU time, so we might try e.g. > 24 or 32. > > >> > Like my colleague found, (transparent) huge pages do not seem to be >> utilized fully. I see in the log >> > file: >> > Memory: 4k page, physical 528157524k(460445396k free), swap >> 2097148k(1463356k free) >> > and on line 12: >> > Parallel pretouch 13440 regions with 2097152 byte pages >> > So it seems to use both 4kB and 2MB pages. The latter area is only 26 >> GB. >> > We don't understand this nor how to solve it. Suggestions very welcome. >> >> This is Shenandoah bug! Argh. Tracked here: >> https://bugs.openjdk.java.net/browse/JDK-8220153 >> >> Ah, good finding! And I see your patch solves it, right? When will this > be available? > > >> -Aleksey >> >> > -Jeroen > From shade at redhat.com Tue Mar 5 13:23:42 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 14:23:42 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: On 3/5/19 2:17 PM, Jeroen Borgers wrote: > Actual pacing delays histogram: > > ? ? ? From -? ? ? ? ?To? ? ? ? ?Count? ? ? ? ?Sum > ? ? ? 1 ms -? ? ? ?2 ms:? ? ? 1391036? ? ? 695518 ms > ? ? ? 2 ms -? ? ? ?4 ms:? ? ? 1005742? ? ?1005742 ms > ? ? ? 4 ms -? ? ? ?8 ms:? ? ? ?821336? ? ?1642672 ms > ? ? ? 8 ms -? ? ? 16 ms:? ? ? ?702322? ? ?2809288 ms > ? ? ?16 ms -? ? ? 32 ms:? ? ? ?617988? ? ?4943904 ms > ? ? ?32 ms -? ? ? 64 ms:? ? ?11181201? ?178899216 ms > ? ? ?64 ms -? ? ?128 ms:? ? ? ? ?3687? ? ? 117984 ms > ? ? 128 ms -? ? ?256 ms:? ? ? ? ? ?12? ? ? ? ?768 ms > ? ? 256 ms -? ? ?512 ms:? ? ? ? ? ? 0? ? ? ? ? ?0 ms > ? ? 512 ms -? ? 1024 ms:? ? ? ? ? ? 0? ? ? ? ? ?0 ms > ? ?1024 ms -? ? 2048 ms:? ? ? ? ? ?24? ? ? ?12288 ms > ? ?2048 ms -? ? 4096 ms:? ? ? ? ? ?18? ? ? ?18432 ms > ? ?4096 ms -? ? 8192 ms:? ? ? ? ? 195? ? ? 399360 ms > ? ?8192 ms -? ?16384 ms:? ? ? ? ? 478? ? ?1957888 ms > ? ? ? ? ? ? ? ? ? Total:? ? ?15724039? ?192503060 ms > > There are many > 64 ms., while we specify 50 ms as max? I don't understand. And the total time > individual threads are stopped is huge: 192_503 s. Much more than the STW time: > > Total Pauses (G)? ? ? ? ? ? =? 4133.93 s (a =? ? 95487 us) (n = 43293) (lvls, us =? ? ? 525,? ? > ?2969,? ? 10938,? ? 18750, 34999971) > > If I multiply the latter by 48 (assuming?every hardware thread is utilized by 1 app thread; all are > affected during STW) I get: 198_384 s. Similar to the total pacing time.? > > Does this mean that our app is stopped by pacing in the same order as by STW pauses? Actual pacing delay is calculated as the difference between thread entering pacing path and exiting from it. So, if Java thread got to be paced, and then STW pause hits while Java thread is there, the length of that STW pause would be counted into pacing delay. Which is corroborated by your data? I'd say the first mode 1..128 ms is the pacing mostly without STW stops, and the other mode 1024..16384 ms is Degen/Full STWs that you experience. -Aleksey From jborgers at jpinpoint.com Tue Mar 5 13:49:27 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 14:49:27 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: Right, that makes sense! Would maybe be helpful to add some explanation on this to the text, maybe something like 'Pacing delay includes STW time of pauses that hit while threads are being paced. For this reason you may see delays longer than max pacing delay.' -Jeroen Op di 5 mrt. 2019 om 14:24 schreef Aleksey Shipilev : > On 3/5/19 2:17 PM, Jeroen Borgers wrote: > > Actual pacing delays histogram: > > > > From - To Count Sum > > 1 ms - 2 ms: 1391036 695518 ms > > 2 ms - 4 ms: 1005742 1005742 ms > > 4 ms - 8 ms: 821336 1642672 ms > > 8 ms - 16 ms: 702322 2809288 ms > > 16 ms - 32 ms: 617988 4943904 ms > > 32 ms - 64 ms: 11181201 178899216 ms > > 64 ms - 128 ms: 3687 117984 ms > > 128 ms - 256 ms: 12 768 ms > > 256 ms - 512 ms: 0 0 ms > > 512 ms - 1024 ms: 0 0 ms > > 1024 ms - 2048 ms: 24 12288 ms > > 2048 ms - 4096 ms: 18 18432 ms > > 4096 ms - 8192 ms: 195 399360 ms > > 8192 ms - 16384 ms: 478 1957888 ms > > Total: 15724039 192503060 ms > > > > There are many > 64 ms., while we specify 50 ms as max? I don't > understand. And the total time > > individual threads are stopped is huge: 192_503 s. Much more than the > STW time: > > > > Total Pauses (G) = 4133.93 s (a = 95487 us) (n = 43293) > (lvls, us = 525, > > 2969, 10938, 18750, 34999971) > > > > If I multiply the latter by 48 (assuming every hardware thread is > utilized by 1 app thread; all are > > affected during STW) I get: 198_384 s. Similar to the total pacing time. > > > > Does this mean that our app is stopped by pacing in the same order as by > STW pauses? > > Actual pacing delay is calculated as the difference between thread > entering pacing path and exiting > from it. So, if Java thread got to be paced, and then STW pause hits while > Java thread is there, the > length of that STW pause would be counted into pacing delay. Which is > corroborated by your data? > > I'd say the first mode 1..128 ms is the pacing mostly without STW stops, > and the other mode > 1024..16384 ms is Degen/Full STWs that you experience. > > -Aleksey > > From shade at redhat.com Tue Mar 5 14:00:33 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 15:00:33 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Message-ID: On 3/5/19 2:07 PM, Edwin Graven wrote: > Okay so THP is a bug, is there any change it will be possible to use LargePages instead of THP > like we do with G1?? If you can use LargePages there won?t be any risk of using swap. Yes, except the teeny-tiny detail that hugetlbfs support is also broken (argh): https://bugs.openjdk.java.net/browse/JDK-8220162 If everything goes right, patches would hit jdk/jdk (development head) this week, and Roman would backport them to 11u and 8u next week. -Aleksey From shade at redhat.com Tue Mar 5 14:37:37 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 15:37:37 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: <2b544811-30f9-7246-0d12-46fb48500388@redhat.com> On 3/5/19 2:49 PM, Jeroen Borgers wrote: > Right, that makes sense!? > > Would maybe be helpful to add some explanation on this to the text, maybe something like 'Pacing > delay includes STW time of pauses that hit while threads are being paced. For this reason you may > see delays longer than max pacing delay.'? This would be enough? Pacing delays are measured from entering the pacing code till exiting it. Therefore, observed pacing delays may be higher than the threshold when paced thread spent more time in the pacing code. It usually happens when thread is de-scheduled while paced, OS takes longer to unblock the thread, or JVM experiences the STW pause. -Aleksey From jborgers at jpinpoint.com Tue Mar 5 16:02:46 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 17:02:46 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <2b544811-30f9-7246-0d12-46fb48500388@redhat.com> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <2b544811-30f9-7246-0d12-46fb48500388@redhat.com> Message-ID: Haha, nice :-) Op di 5 mrt. 2019 15:38 schreef Aleksey Shipilev : > On 3/5/19 2:49 PM, Jeroen Borgers wrote: > > Right, that makes sense! > > > > Would maybe be helpful to add some explanation on this to the text, > maybe something like 'Pacing > > delay includes STW time of pauses that hit while threads are being > paced. For this reason you may > > see delays longer than max pacing delay.' > > This would be enough? > > Pacing delays are measured from entering the pacing code till exiting > it. Therefore, > observed pacing delays may be higher than the threshold when paced > thread spent more > time in the pacing code. It usually happens when thread is de-scheduled > while paced, > OS takes longer to unblock the thread, or JVM experiences the STW pause. > > -Aleksey > > From zgu at redhat.com Tue Mar 5 16:18:33 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Tue, 05 Mar 2019 11:18:33 -0500 Subject: RFR(XXS) 8220161: Shenandoah does not need to initialize PLABs for safepoint workers Message-ID: <1551802713.18805.177.camel@redhat.com> Please review this small patch that not creating PLAB for safepoint workers, it does not seem they evacuate anything. It also fixes the crashes we have seen recently, because we never enable PLAB creation for late safepoint workers, that results trying to retire NULL PLAB during GC. Bug: https://bugs.openjdk.java.net/browse/JDK-8220161 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220161/webrev.00/ Test: tier1, 2, 3_gc_shenandoah on Linux 64 (fastdebug and release) Thanks, -Zhengyu From edwin at graven-ict.nl Tue Mar 5 08:17:42 2019 From: edwin at graven-ict.nl (Edwin Graven) Date: Tue, 5 Mar 2019 09:17:42 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> Message-ID: <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> Aleksey Thanks for looking into this I'm a colleague of Jeroen and can answer most of the questions We start the application with the option -XX:+AlwaysPreTouch if i look at the ps outpot it's also stating acv????? 35165???? 1 99 Mar04 ???????? 9-09:00:00 java -server -Drss.configuration.propertiesFile=/appl/acv/server/conf/server.properties -Djava.library.path=bin:/opt/mqm/java/lib64:/appl/acv/kafka/libs -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=8005 -Dcom.sun.management.jmxremote.authenticate=true -Dcom.sun.management.jmxremote.password.file=/appl/acv/server/conf/jmxauth/jmxremote.password -Dcom.sun.management.jmxremote.access.file=/appl/acv/server/conf/jmxauth/jmxremote.access -Dcom.sun.management.jmxremote.ssl=false -Djsse.enableSNIExtension=false -XX:+UseShenandoahGC -XX:+UseNUMA -XX:+UseTransparentHugePages -XX:+UnlockDiagnosticVMOptions -XX:+ShenandoahAllocationTrace -XX:+LogVMOutput -XX:ParallelGCThreads=44 -XX:ShenandoahGCHeuristics=adaptive -XX:ConcGCThreads=16 -XX:+UnlockExperimentalVMOptions -XX:+ClassUnloadingWithConcurrentMark -XX:ShenandoahAllocSpikeFactor=7 -XX:ShenandoahPacingMaxDelay=75 -XX:+AlwaysPreTouch -verbosegc -Xms420g -Xmx420g -XX:+UseGCLogFileRotation -XX:+PrintGCDetails -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=10M -XX:MaxTenuringThreshold=2 -Xloggc:/appl/acv/log/server/gc_Shenandoah_Mon.log -classpath lib/.:lib/*:/opt/mqm/java/lib/*:/appl/acv/kafka/libs/*:/appl/acv/server/custom/* com.riskshield.server.Starter -i/appl/acv/server/conf/server.ini Not sure why it's reporting in the gc log with -XX:-AlwaysPreTouch. we are currently testing with 2 machines and we are seeing this behavior on both machines. Both machine have 512GB installed. swap space is set to 2GB on both machines. when running for a while (3days) both machines have still 60G available (1G free mem and 59G filecache) I'm going to try to install 8u nightlies today. an other strange thing we encounter is that we used the option UseTransparentHugePages But hardly any pages are in hugepages when we start is we see around 12G address as hugepages and it stays on that level. If we start the G1 collector with TransparentHugepages we see it running up to 290G. currently we are using G1 on our production system with largepages (vm.nr_hugepages) also tried this option in combination with Shenandoah but then java reports that there is nog enough memory, it does not look at the reserved block (vm.nr_hugepages) Edwin Graven On 3/4/19 6:28 PM, Aleksey Shipilev wrote: > On 3/4/19 5:48 PM, Jeroen Borgers wrote: >> Please find 3 gc log files at: >> www.jpinpoint.com/resources/gc_Shenandoah_Thu.log.0.current.zip >> >> gc_Shenandoah_Thu.log.1.zip gc_shenandoah_Weekend_25.zip > Briefly looking at one of the logs, Weekend_25.zip. *) First things > first, command line options: CommandLine flags: -XX:-AlwaysPreTouch > -XX:+ClassUnloadingWithConcurrentMark -XX:ConcGCThreads=16 > -XX:GCLogFileSize=10485760 -XX:InitialHeapSize=450971566080 > -XX:InitialTenuringThreshold=2 -XX:+LogVMOutput -XX:+ManagementServer > -XX:MaxHeapSize=450971566080 -XX:MaxTenuringThreshold=2 > -XX:NumberOfGCLogFiles=10 -XX:ParallelGCThreads=44 -XX:+PrintGC > -XX:+PrintGCDetails -XX:+PrintGCTimeStamps > -XX:ShenandoahAllocSpikeFactor=5 -XX:+ShenandoahAllocationTrace > -XX:ShenandoahPacingMaxDelay=50 -XX:+UnlockDiagnosticVMOptions > -XX:+UnlockExperimentalVMOptions -XX:+UseGCLogFileRotation > -XX:+UseNUMA -XX:+UseNUMAInterleaving -XX:+UseShenandoahGC > -XX:+UseTransparentHugePages - Consider enabling -XX:+AlwaysPreTouch, > especially as you are running with NUMA turned on and THP turned on. > If memory allocator and/or defragger kicks in at unfortunate times, it > might stall the collector enough to trip off the the concurrent mode; > - These options are useless for Shenandoah: > "-XX:InitialTenuringThreshold=2 -XX:MaxTenuringThreshold=2" - > "-XX:InitialHeapSize=450971566080 -XX:MaxHeapSize=450971566080", but > machine has "physical 528157524k(460445396k free)". There is some > native memory spent on top of heap size, are you sure the machine > never swaps? *) 8u191 Shenandoah is a bit old, which might not have > all the performance touchups. Sorry about that. Can you try our 8u > nightlies? https://builds.shipilev.net/openjdk-shenandoah-jdk8/ *) > From very far out, it seems that the normal GC cycle takes around 16 > seconds in that config. And the live data set is around 260G (the heap > size after Full GC) of 420G max. Which means, any allocation spike at > 10+ GB/sec would tank the whole thing. I'd say if you cannot crank up > the heap, then you'd have to choose whether you want much larger > allocation pacing delay (i.e. seconds) or accept more Degen/Full GCs. > *) Looking at progression of some counters: $ grep "Actual Free" > gc_shenandoah_Weekend_25.logfull | less ...it seems it slowly goes > down, until Full GC recovers from it. We have seen those as heuristics > issues before, and it should be fixed in recent 8u's, but probably not > in 8u191. -Aleksey > From edwin at graven-ict.nl Tue Mar 5 13:07:33 2019 From: edwin at graven-ict.nl (Edwin Graven) Date: Tue, 5 Mar 2019 14:07:33 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> Message-ID: <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Aleksey Okay so THP is a bug, is there any change it will be possible to use LargePages instead of THP like we do with G1?? If you can use LargePages there won?t be any risk of using swap. Edwin Verstuurd vanaf mijn iPhone > Op 5 mrt. 2019 om 13:24 heeft Jeroen Borgers het volgende geschreven: > > > Op di 5 mrt. 2019 om 12:20 schreef Aleksey Shipilev : >> On 3/5/19 10:51 AM, Jeroen Borgers wrote: >> > Thanks for your remarks. In addition to Edwins findings: >> > 1.1 AlwaysPreTouch seems to be on while reported as off, as shown in 'ps' and in logfile it says >> > (line 12:) >> >> Right. Sorry, my bad, that's Shenandoah reverting dropping AlwaysPreTouch and enabling >> ShenandoahAlwaysPretouch specifically. It needs to be that way to avoid hitting serial pretouch code >> that would wreck up NUMA interleaving. > > Ok, good to know. > >> >> > 3. Right, sudden high allocation rates are a problem. Getting more memory will take time. We might >> > be able to throttle the load somewhat. >> >> Yes, either throttle the load (for example, beef up pacing threshold), or maybe beef up the >> ConcGCThreads? >> > We hope we can throttle the system that puts sudden load on our application. Beefing up the ConcGCThreads might also be an option, although we are almost at 100% CPU with high load. Application can progress slower and lose max 16 ms on 30 ms by getting less CPU time, so we might try e.g. 24 or 32. > >> > Like my colleague found, (transparent) huge pages do not seem to be utilized fully. I see in the log >> > file: >> > Memory: 4k page, physical 528157524k(460445396k free), swap 2097148k(1463356k free) >> > and on line 12: >> > Parallel pretouch 13440 regions with 2097152 byte pages >> > So it seems to use both 4kB and 2MB pages. The latter area is only 26 GB. >> > We don't understand this nor how to solve it. Suggestions very welcome. >> >> This is Shenandoah bug! Argh. Tracked here: >> https://bugs.openjdk.java.net/browse/JDK-8220153 >> > Ah, good finding! And I see your patch solves it, right? When will this be available? > >> -Aleksey >> > > -Jeroen From jianglizhou at google.com Sun Mar 3 19:48:40 2019 From: jianglizhou at google.com (Jiangli Zhou) Date: Sun, 3 Mar 2019 11:48:40 -0800 Subject: RFR (M): 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead In-Reply-To: References: <6b1e59ec7f4746e8e071fd44ec91ca966fac8d78.camel@oracle.com> <7e0c775d-86c1-b80c-b1a6-373ca21206ba@oracle.com> Message-ID: Hi Man, As both Thomas and Per seemed to be okay with the refactoring, you probably had sufficient approval already. The following comment in adaptiveSizePolicy.cpp seems to be outdated. The comment predates the PermGen removal. It's probably a good idea to also cleanup the comment as part of your refactoring change. 281 // Note that the gc time limit test only works for the collections 282 // of the young gen + tenured gen and not for collections of the 283 // permanent gen. That is because the calculation of the space 284 // freed by the collection is the free space in the young gen + 285 // tenured gen. Thanks and regards, Jiangli On Fri, Mar 1, 2019 at 1:43 PM Man Cao wrote: > Hi, > > I rebased the patch to latest tip: > https://cr.openjdk.java.net/~manc/8212206/webrev.03/ > > Could someone give a second "looks good"? > > -Man > > > On Sat, Jan 26, 2019 at 4:35 PM Man Cao wrote: > >> Friendly ping. Could anyone give a second "looks good"? >> >> As for the develop flag >> AdaptiveSizePolicyGCTimeLimitThreshold/GCOverheadLimitThreshold, I added a >> note about it in https://bugs.openjdk.java.net/browse/JDK-8212084. >> >> -Man >> >> >> On Tue, Jan 15, 2019 at 6:41 PM Man Cao wrote: >> >>> Hi, >>> >>> I rebased the patch to tip and updated year in some headers to 2019, >>> without making any real change: >>> http://cr.openjdk.java.net/~manc/8212206/webrev.02/ >>> >>> >>> I don't foresee that this will be implemented, or even makes sense, for >>>> ZGC. As I see it, this is only a thing STW collectors. For that reason, >>>> I don't think it belongs in CollectedHeap. Keeping it as a separate >>>> utility class for collectors that want to use it sounds better. >>>> >>> Sounds good to keep this patch in the current state, without further >>> changing the CollectedHeap class. >>> >>> I haven't looked very closely at the patch, but couldn't help to notice >>>> that the option is called "GCOverheapLimitThreshold" (and >>>> "AdaptiveSizePolicyGCTimeLimitThreshold" before that), which is a >>>> tautology and a not very good description of what it is. >>>> How about we take the opportunity to clean this up and completely ditch >>>> the "gc_overhead_limit_count" thing and get rid of this option? It's a >>>> "develop" option, so it's not available to normal users anyway. Has >>>> anyone of you ever used this option and actually find it valuable? >>> >>> I didn't find any users inside Google that require changing this option. >>> That said, some users did complain that UseGCOverheadLimit for >>> ParallelGC or CMS is too difficult to get >>> triggered, because of the requirement for 5 consecutive full GCs, which >>> is set by this option. >>> I think if it were a normal "product" option, there will definitely be >>> users setting it. >>> I never understand why it is a "develop" option. I think we could either >>> remove it, >>> or make it an "experimental" option. >>> I'm leaning towards not removing it for now, as I'm not sure if 5 is >>> still a reasonable >>> default value for UseGCOverheadLimit for G1. >>> How about we decide whether to keep or remove this option after >>> JDK-8212084 (UseGCOverheadLimit for G1) is fixed? >>> >>> Also for the hsperfdata counter change, I created >>> https://bugs.openjdk.java.net/browse/JDK-8217221. I will draft a CSR >>> for it later. >>> >>> -Man >>> >> From jianglizhou at google.com Tue Mar 5 15:53:05 2019 From: jianglizhou at google.com (Jiangli Zhou) Date: Tue, 5 Mar 2019 07:53:05 -0800 Subject: RFR (M): 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead In-Reply-To: References: <6b1e59ec7f4746e8e071fd44ec91ca966fac8d78.camel@oracle.com> <7e0c775d-86c1-b80c-b1a6-373ca21206ba@oracle.com> Message-ID: Hi Man, The comment change looks ok to me. Thanks and regards, Jiangli On Mon, Mar 4, 2019 at 6:20 PM Man Cao wrote: > After offline discussion with Jiangli, we think it is better to just > remove this comment block. > The reason is that full GCs due to metaspace expansion will not take the > code path to execute AdaptiveSizePolicy::check_gc_overhead_limit(), because > of the check for AdaptiveSizePolicy::should_update_promo_stats(). > > New webrev: https://cr.openjdk.java.net/~manc/8212206/webrev.05/ > > -Man > > > On Mon, Mar 4, 2019 at 2:41 PM Man Cao wrote: > >> Thanks for taking a look, Jiangli. I renamed "permanent gen" to >> "metaspace". >> I double checked that currently full GCs due to metaspace expansion will >> not affect the calculation of GC overhead . >> >> New webrev: https://cr.openjdk.java.net/~manc/8212206/webrev.04/ >> >> -Man >> >> >> On Sun, Mar 3, 2019 at 11:48 AM Jiangli Zhou >> wrote: >> >>> Hi Man, >>> >>> As both Thomas and Per seemed to be okay with the refactoring, you >>> probably had sufficient approval already. >>> >>> The following comment in adaptiveSizePolicy.cpp seems to be outdated. >>> The comment predates the PermGen removal. It's probably a good idea to also >>> cleanup the comment as part of your refactoring change. >>> >>> 281 // Note that the gc time limit test only works for the collections 282 // of the young gen + tenured gen and not for collections of the 283 // permanent gen. That is because the calculation of the space 284 // freed by the collection is the free space in the young gen + 285 // tenured gen. >>> >>> Thanks and regards, >>> >>> Jiangli >>> >>> From shade at redhat.com Tue Mar 5 17:16:23 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 18:16:23 +0100 Subject: RFR(XXS) 8220161: Shenandoah does not need to initialize PLABs for safepoint workers In-Reply-To: <1551802713.18805.177.camel@redhat.com> References: <1551802713.18805.177.camel@redhat.com> Message-ID: <2a900a73-f8f1-bff8-9869-b801307d79ea@redhat.com> On 3/5/19 5:18 PM, zgu at redhat.com wrote: > Please review this small patch that not creating PLAB for safepoint > workers, it does not seem they evacuate anything. > > It also fixes the crashes we have seen recently, because we never > enable PLAB creation for late safepoint workers, that results trying to > retire NULL PLAB during GC. > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220161 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220161/webrev.00/ Looks good. -Aleksey From jborgers at jpinpoint.com Tue Mar 5 18:54:40 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Tue, 5 Mar 2019 19:54:40 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Message-ID: Good to know. Great it would be available next week. -Jeroen Op di 5 mrt. 2019 15:02 schreef Aleksey Shipilev : > On 3/5/19 2:07 PM, Edwin Graven wrote: > > Okay so THP is a bug, is there any change it will be possible to use > LargePages instead of THP > > like we do with G1?? If you can use LargePages there won?t be any risk > of using swap. > Yes, except the teeny-tiny detail that hugetlbfs support is also broken > (argh): > https://bugs.openjdk.java.net/browse/JDK-8220162 > > If everything goes right, patches would hit jdk/jdk (development head) > this week, and Roman would > backport them to 11u and 8u next week. > > -Aleksey > > From shade at redhat.com Tue Mar 5 19:58:16 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 5 Mar 2019 20:58:16 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+1 to sh/jdk11 Message-ID: <2b530117-46f9-0083-62b0-c83602d8a773@redhat.com> Upstream^W We have pushed the jdk-11.0.3+1 tag upstream to jdk-updates/jdk11u. Let's pick it up to sh/jdk11 to stabilize before the CPU. We would probably have other minor merges with +2, +3, etc. Summary of changes: http://cr.openjdk.java.net/~shade/shenandoah/merge-jdk11.0.3-1/changesets.txt Webrev: http://cr.openjdk.java.net/~shade/shenandoah/merge-jdk11.0.3-1/webrev.01/ The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+1. Testing: hotspot_gc_shenandoah {fastdebug,release} Thanks, -Aleksey From rkennke at redhat.com Wed Mar 6 00:10:14 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 01:10:14 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+1 to sh/jdk11 In-Reply-To: <2b530117-46f9-0083-62b0-c83602d8a773@redhat.com> References: <2b530117-46f9-0083-62b0-c83602d8a773@redhat.com> Message-ID: <419aa668-3c9b-2bee-12d8-a4a1092ceb92@redhat.com> Good! Thanks! Roman > Upstream^W We have pushed the jdk-11.0.3+1 tag upstream to jdk-updates/jdk11u. Let's pick it up to > sh/jdk11 to stabilize before the CPU. We would probably have other minor merges with +2, +3, etc. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merge-jdk11.0.3-1/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merge-jdk11.0.3-1/webrev.01/ > > The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+1. > > Testing: hotspot_gc_shenandoah {fastdebug,release} > > Thanks, > -Aleksey > > From shade at redhat.com Wed Mar 6 07:55:26 2019 From: shade at redhat.com (shade at redhat.com) Date: Wed, 06 Mar 2019 07:55:26 +0000 Subject: hg: shenandoah/jdk11: 153 new changesets Message-ID: <201903060755.x267tcx9000338@aojmv0008.oracle.com> Changeset: da724382dab4 Author: mullan Date: 2018-10-25 13:55 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/da724382dab4 8211883: Disable anon and NULL cipher suites Reviewed-by: jnimeh ! src/java.base/share/conf/security/java.security ! test/jdk/javax/net/ssl/SSLSession/JSSERenegotiate.java ! test/jdk/javax/net/ssl/ciphersuites/DisabledAlgorithms.java ! test/jdk/sun/security/ssl/SSLContextImpl/CustomizedCipherSuites.java Changeset: 0dafecad54d5 Author: rpatil Date: 2018-11-01 12:43 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/0dafecad54d5 8213085: (tz) Upgrade time-zone data to tzdata2018g Reviewed-by: martin, naoto ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/antarctica ! make/data/tzdata/asia ! make/data/tzdata/australasia ! make/data/tzdata/backward ! make/data/tzdata/etcetera ! make/data/tzdata/europe ! make/data/tzdata/factory ! make/data/tzdata/leapseconds ! make/data/tzdata/northamerica ! make/data/tzdata/pacificnew ! make/data/tzdata/southamerica ! make/data/tzdata/systemv ! make/data/tzdata/zone.tab ! src/java.base/share/classes/sun/util/resources/TimeZoneNames.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_de.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_es.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_fr.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_it.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_ja.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_ko.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_pt_BR.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_sv.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_zh_CN.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_zh_TW.java ! test/jdk/sun/util/calendar/zi/tzdata/VERSION ! test/jdk/sun/util/calendar/zi/tzdata/africa ! test/jdk/sun/util/calendar/zi/tzdata/antarctica ! test/jdk/sun/util/calendar/zi/tzdata/asia ! test/jdk/sun/util/calendar/zi/tzdata/australasia ! test/jdk/sun/util/calendar/zi/tzdata/backward ! test/jdk/sun/util/calendar/zi/tzdata/etcetera ! test/jdk/sun/util/calendar/zi/tzdata/europe ! test/jdk/sun/util/calendar/zi/tzdata/factory ! test/jdk/sun/util/calendar/zi/tzdata/leapseconds ! test/jdk/sun/util/calendar/zi/tzdata/northamerica ! test/jdk/sun/util/calendar/zi/tzdata/pacificnew ! test/jdk/sun/util/calendar/zi/tzdata/southamerica ! test/jdk/sun/util/calendar/zi/tzdata/systemv ! test/jdk/sun/util/calendar/zi/tzdata/zone.tab Changeset: 2c53a52abfee Author: weijun Date: 2018-11-06 14:15 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/2c53a52abfee 8205507: jdk/javax/xml/crypto/dsig/GenerationTests.java timed out Reviewed-by: mullan ! test/jdk/javax/xml/crypto/dsig/GenerationTests.java Changeset: 8c131dfdf646 Author: dlong Date: 2018-10-25 18:41 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8c131dfdf646 8021335: Missing synchronization when reading counters for live threads and peak thread count Reviewed-by: dholmes, mchung ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/services/threadService.cpp ! src/hotspot/share/services/threadService.hpp ! test/jdk/java/lang/management/ThreadMXBean/ResetPeakThreadCount.java Changeset: 50d915ac1651 Author: simonis Date: 2018-10-31 16:02 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/50d915ac1651 8213151: [AIX] Some class library files are missing the Classpath exception Reviewed-by: stuefe, rriggs, mbaesken ! src/java.base/aix/native/libjli/java_md_aix.c ! src/java.base/aix/native/libjli/java_md_aix.h ! src/java.desktop/aix/native/libawt/porting_aix.c ! src/java.desktop/aix/native/libawt/porting_aix.h Changeset: 17c3ea95e18d Author: goetz Date: 2018-10-12 08:33 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/17c3ea95e18d 8211931: [ppc][testbug] runtime/jni/terminatedThread/TestTerminatedThread.java fails as threads don't terminate immediately Reviewed-by: dholmes, mdoerr ! test/hotspot/jtreg/runtime/jni/terminatedThread/TestTerminatedThread.java Changeset: 9c19d1cd9e8a Author: iklam Date: 2018-08-28 16:01 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9c19d1cd9e8a 8210043: Invalid assert(HeapBaseMinAddress > 0) in ReservedHeapSpace::initialize_compressed_heap Summary: Removed the assert Reviewed-by: ccheung, jiangli ! src/hotspot/share/memory/virtualspace.cpp Changeset: 7d56097e8435 Author: tschatzl Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d56097e8435 8205633: TestOptionsWithRanges.java of '-XX:TLABSize=2147483648' fails intermittently Summary: Exclude maximum range value from testing. Reviewed-by: sangheki, kbarrett ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java Changeset: 71dd02edf2df Author: iklam Date: 2018-08-28 16:01 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/71dd02edf2df 8210040: TestOptionsWithRanges.java is very slow Summary: Added -Xmx1024m -XX:-ZapUnusedHeapArea; split into 10 smaller tests Reviewed-by: kvn, coleenp ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java + test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges_generate.sh ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOption.java Changeset: 407fc2d5752f Author: mdoerr Date: 2018-10-31 14:48 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/407fc2d5752f 8213086: Compiler thread creation should be bounded by available space in memory and Code Cache Reviewed-by: kvn, thartmann ! src/hotspot/share/compiler/compileBroker.cpp Changeset: 1dac3602717f Author: rhalade Date: 2018-10-31 13:58 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1dac3602717f 8207059: Update test certificates in QuoVadisCA.java test Reviewed-by: mullan, mbaesken ! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java Changeset: 3d9682b1d45d Author: goetz Date: 2018-11-12 16:40 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/3d9682b1d45d 8213527: [testbug] Fix PrintMetaspaceDcmd test using UseCompressedOops for 32-bit. Reviewed-by: dholmes, mdoerr ! test/hotspot/jtreg/runtime/Metaspace/PrintMetaspaceDcmd.java Changeset: 0f638ecc8f51 Author: mbaesken Date: 2018-07-19 11:04 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/0f638ecc8f51 8207395: jar has issues with UNC-path arguments for the jar -C parameter [windows] Reviewed-by: goetz, sherman ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java Changeset: 46d165a11842 Author: ghaug Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/46d165a11842 8209357: [PPC64] Fix build which was broken by 8208672 (Enable -Wreorder) Reviewed-by: mbaesken, tschatzl ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp ! src/hotspot/cpu/ppc/frame_ppc.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp Changeset: 16d5ec7dbbb4 Author: lucy Date: 2018-08-14 14:28 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/16d5ec7dbbb4 8209433: [s390] Fix build, broken by 8208672 (Enable -Wreorder) Reviewed-by: tschatzl, shade ! src/hotspot/cpu/s390/c1_CodeStubs_s390.cpp ! src/hotspot/cpu/s390/frame_s390.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp Changeset: bbb4cdeecd46 Author: bulasevich Date: 2018-11-16 19:29 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/bbb4cdeecd46 8213410: UseCompressedOops requirement check fails fails on 32-bit system Reviewed-by: dholmes ! test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java ! test/hotspot/jtreg/gc/metaspace/TestMetaspaceMemoryPool.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassSpaceSize.java ! test/hotspot/jtreg/runtime/Metaspace/MaxMetaspaceSizeTest.java ! test/hotspot/jtreg/runtime/logging/CompressedOopsTest.java Changeset: 8687668b33da Author: sgehwolf Date: 2018-11-07 13:54 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8687668b33da 8212937: Parent class loader may not have a referred ClassLoaderData instance when obtained in Klass::class_in_module_of_loader Summary: Fix to obtain the class loader's name from the java.lang.ClassLoader object instead of its ClassLoaderData. Reviewed-by: coleenp, lfoltan ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/oops/klass.cpp + test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/ParentClassLoader.java + test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/PreemptingChildClassLoader.java + test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/Test.java Changeset: 01712e8a67c0 Author: shade Date: 2018-11-20 22:59 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/01712e8a67c0 8213992: Rename and make DieOnSafepointTimeout the diagnostic option Reviewed-by: dholmes, dcubed, coleenp, kvn ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/safepoint.cpp Changeset: 789a020d4afe Author: stuefe Date: 2018-11-27 07:54 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/789a020d4afe 8213834: JVMTI ResourceExhausted should not be posted in CompilerThread Reviewed-by: dholmes, dcubed, jcbeyler, sspitsyn ! src/hotspot/share/prims/jvmtiExport.cpp Changeset: 104e1f3c0dca Author: shade Date: 2018-09-28 18:28 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/104e1f3c0dca 8211268: Disable unsupported GCs for Zero Reviewed-by: sgehwolf, erikj ! make/autoconf/hotspot.m4 Changeset: 6c90d1d1a03b Author: shade Date: 2018-11-10 20:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6c90d1d1a03b 8211926: Catastrophic size_t underflow in BitMap::*_large methods Reviewed-by: kbarrett, stuefe ! src/hotspot/share/utilities/bitMap.cpp ! src/hotspot/share/utilities/bitMap.hpp ! src/hotspot/share/utilities/bitMap.inline.hpp + test/hotspot/gtest/utilities/test_bitMap_large.cpp Changeset: f7090fdf3222 Author: shade Date: 2018-11-19 11:51 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f7090fdf3222 8212070: Introduce diagnostic flag to abort VM on failed JIT compilation Reviewed-by: mikael, thartmann ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileBroker.hpp ! src/hotspot/share/runtime/globals.hpp Changeset: 9357712b48d7 Author: pliden Date: 2018-12-03 14:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9357712b48d7 8214476: ZGC: Build ZGC by default Reviewed-by: shade, rkennke, ihse ! make/autoconf/hotspot.m4 ! make/conf/jib-profiles.js Changeset: a23d4b4ea281 Author: phh Date: 2018-12-07 08:14 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a23d4b4ea281 8208647: switch jtreg to 4.2b13 Summary: Increment build number to b13 and replace '?' with String in GatherDiagnosticInfoObserver:startingTestRun Reviewed-by: robm ! make/conf/jib-profiles.js ! test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java Changeset: a26c99d42a25 Author: jdv Date: 2018-11-14 01:29 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a26c99d42a25 8212116: IIOException "tEXt chunk length is not proper" on opening png file Reviewed-by: serb ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java + test/jdk/javax/imageio/plugins/png/ReadPNGWithNoTextInTEXTChunk.java Changeset: 9e179e01882d Author: sgehwolf Date: 2018-11-26 09:36 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9e179e01882d 8214059: Undefined behaviour in ADLC Reviewed-by: shade, kbarrett Contributed-by: Simon Tooke ! src/hotspot/share/adlc/adlparse.cpp ! src/hotspot/share/adlc/dfa.cpp ! src/hotspot/share/adlc/formssel.cpp Changeset: a97a7c94942d Author: mbaesken Date: 2018-10-02 13:48 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a97a7c94942d 8211106: [windows] Update OS detection code to recognize Windows Server 2019 Reviewed-by: alanb, clanger, bobv ! src/hotspot/os/windows/os_windows.cpp ! src/java.base/windows/native/libjava/java_props_md.c Changeset: cc69d2297dac Author: phh Date: 2018-12-12 06:17 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/cc69d2297dac 8206075: On x86, assert on unbound assembler Labels used as branch targets 8208480: Test failure: assert(is_bound() || is_unused()) after JDK-8206075 in C1 8209511: C2 asserts with UseSSE < 4 and AVX enabled: "Label was never bound to a location, but it was used as a jmp target' Summary: Combine unbound Label assertion checking backports Reviewed-by: robm ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/asm/assembler.hpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp Changeset: 1918c90271d3 Author: sgroeger Date: 2018-12-07 14:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1918c90271d3 8211844: [aix] ProcessBuilder: Piping between created processes does not work. Reviewed-by: cjplummer, simonis, goetz ! src/java.base/unix/classes/java/lang/ProcessImpl.java ! test/jdk/ProblemList.txt Changeset: b39daedbb906 Author: iignatyev Date: 2018-12-13 14:07 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b39daedbb906 8215128: Test library OSInfo.getSolarisVersion cannot determine Solaris version Reviewed-by: chegar ! test/jdk/lib/testlibrary/jdk/testlibrary/OSInfo.java Changeset: 55ba541d7763 Author: coleenp Date: 2018-08-11 12:49 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/55ba541d7763 8207924: serviceability/sa/TestUniverse.java#id0 intermittently fails with assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded Summary: InstanceKlass::implementors() needs the Compile_lock Reviewed-by: thartmann, eosterlund ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp Changeset: f5bfe0e02b98 Author: mbalao Date: 2018-09-12 13:09 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f5bfe0e02b98 8029661: Support TLS v1.2 algorithm in SunPKCS11 provider Summary: TLS v1.2 algorithms for key and MAC derivation added to SunPKCS11 crypto provider. Reviewed-by: valeriep ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsRsaPremasterSecretGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java + src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_KEY_MAT_PARAMS.java + src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_MASTER_KEY_DERIVE_PARAMS.java + src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS_MAC_PARAMS.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/Functions.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java ! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c ! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c ! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h ! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h + test/jdk/sun/security/pkcs11/fips/TestTLS12.java ! test/jdk/sun/security/pkcs11/fips/cert8.db ! test/jdk/sun/security/pkcs11/fips/key3.db ! test/jdk/sun/security/pkcs11/fips/keystore Changeset: ac31174dd0c9 Author: mikael Date: 2018-09-19 09:24 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ac31174dd0c9 8210912: Build error in src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c after JDK-8029661 Reviewed-by: mullan ! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_convert.c Changeset: 4d390169521e Author: mbalao Date: 2018-11-08 18:10 -0300 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/4d390169521e 8213154: Update copyright headers of files in src tree that are missing Classpath exception Reviewed-by: andrew ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_KEY_MAT_PARAMS.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS12_MASTER_KEY_DERIVE_PARAMS.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_TLS_MAC_PARAMS.java ! test/jdk/sun/security/pkcs11/fips/TestTLS12.java Changeset: 5196137de551 Author: roland Date: 2018-09-06 16:27 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5196137de551 8209544: AES encrypt performance regression in jdk11b11 Reviewed-by: kvn, vlivanov ! src/hotspot/share/opto/subnode.cpp Changeset: 40c6726514f3 Author: roland Date: 2018-11-08 10:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/40c6726514f3 8211451: ~2.5% regression on compression benchmark starting with 12-b11 Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp Changeset: bda6414e933c Author: bulasevich Date: 2018-12-25 18:20 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/bda6414e933c 8215637: client VM variant build error: zgc (enabled) depends on opto (disabled) Reviewed-by: robm, pliden ! src/hotspot/share/gc/z/zBarrierSet.cpp Changeset: b891bde6dc13 Author: clanger Date: 2018-12-12 11:34 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b891bde6dc13 8214892: Delayed starting of debugging via jcmd Reviewed-by: cjplummer, clanger Contributed-by: ralf.schmelter at sap.com ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp ! src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c + test/jdk/com/sun/jdi/OnJcmdTest.java Changeset: 1afd15fd158c Author: bulasevich Date: 2018-12-25 18:35 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1afd15fd158c 8206107: [x86_32] jck tests for ldc2_w bytecode fail Reviewed-by: dsamersoff ! src/hotspot/cpu/x86/templateTable_x86.cpp Changeset: 0ef67386a57d Author: goetz Date: 2018-12-31 14:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/0ef67386a57d 8215975: [testbug] Adapt nsk tests to the PPC, S390 and AIX platforms. Summary: Use LIBPATH on AIX, no shared memory connector on any Unix. Reviewed-by: gadams, simonis, sspitsyn ! test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attach/attach002.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Allocate/alloc001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.bash ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses/retransform003/TestDriver.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetNativeMethodPrefix/SetNativeMethodPrefix002/TestDriver.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/ArgumentHandler.java Changeset: 93acc1c67eca Author: gromero Date: 2018-10-16 16:26 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/93acc1c67eca 8212481: PPC64: Enable POWER9 CPU detection Reviewed-by: mdoerr, simonis ! src/hotspot/cpu/ppc/assembler_ppc.hpp ! src/hotspot/cpu/ppc/assembler_ppc.inline.hpp ! src/hotspot/cpu/ppc/vm_version_ppc.cpp ! src/hotspot/cpu/ppc/vm_version_ppc.hpp Changeset: 68ed039202bf Author: sviswanathan Date: 2019-01-11 12:00 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/68ed039202bf 8216290: Register to register spill may use AVX 512 move instruction on unsupported platform. Reviewed-by: vlivanov, thartmann ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/x86.ad Changeset: b9577e95e758 Author: sgehwolf Date: 2019-01-14 17:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b9577e95e758 8214108: [TESTBUG] Incorrect Function parameter lists in vmTestbase/nsk/jvmti/scenarios/extension/EX03/ex03t001 Reviewed-by: gadams, sspitsyn Contributed-by: Simon Tooke ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/extension/EX03/ex03t001/ex03t001.c ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extmech/extmech.c Changeset: f632687e9147 Author: sgehwolf Date: 2018-11-22 10:11 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f632687e9147 8214105: [TESTBUG] Bit test is always false in serviceability/jvmti/StartPhase/AllowedFunctions Reviewed-by: dcubed, dholmes, jcbeyler, gadams, sspitsyn Contributed-by: Simon Tooke ! test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c Changeset: 4f3e66062582 Author: sgehwolf Date: 2018-12-04 17:54 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/4f3e66062582 8214061: Buffer written into itself Summary: Actually write the msg text into the buffer. Reviewed-by: dcubed, sgehwolf, sspitsyn Contributed-by: Simon Tooke ! src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c Changeset: c07c37d1af16 Author: robm Date: 2019-01-15 05:21 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c07c37d1af16 Merge ! make/conf/jib-profiles.js ! src/java.base/share/conf/security/java.security Changeset: ea9d70720bbb Author: stuefe Date: 2019-01-15 08:03 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ea9d70720bbb 8216982: Assertion poison page established too early Reviewed-by: mdoerr, dholmes ! src/hotspot/share/runtime/thread.cpp Changeset: 355ecc3f08f3 Author: robm Date: 2019-01-15 11:20 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/355ecc3f08f3 Merge Changeset: 1fc623d5b8d7 Author: robm Date: 2019-01-15 11:22 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1fc623d5b8d7 Merge Changeset: 3e1ce991ee48 Author: stuefe Date: 2018-11-08 16:23 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/3e1ce991ee48 8211845: A new switch to control verbosity of hs-err files Reviewed-by: goetz, mdoerr ! src/hotspot/share/runtime/globals.hpp Changeset: e0b6b76f1f42 Author: mbaesken Date: 2018-11-15 17:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e0b6b76f1f42 8211326: add OS user related information to hs_err file Reviewed-by: dholmes, stuefe ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp ! src/hotspot/share/utilities/vmError.cpp Changeset: e3045eabf5cd Author: mhorie Date: 2018-11-22 21:43 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e3045eabf5cd 8214205: PPC64: Add instructions for counting trailing zeros Reviewed-by: mdoerr, gromero ! src/hotspot/cpu/ppc/assembler_ppc.hpp ! src/hotspot/cpu/ppc/assembler_ppc.inline.hpp ! src/hotspot/cpu/ppc/globals_ppc.hpp ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/ppc/vm_version_ppc.cpp Changeset: ffa198ebfb4f Author: shade Date: 2019-01-09 15:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ffa198ebfb4f 8215724: Epsilon: ArrayStoreExceptionTest.java fails; missing arraycopy check Reviewed-by: eosterlund, lkorinth ! src/hotspot/share/gc/shared/barrierSet.hpp + src/hotspot/share/gc/shared/barrierSet.inline.hpp ! src/hotspot/share/oops/access.inline.hpp + test/hotspot/jtreg/gc/epsilon/TestArraycopyCheckcast.java Changeset: 468035a5947a Author: mdoerr Date: 2019-01-11 11:02 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/468035a5947a 8216376: [PPC64] Possibly unreliable stack frame resizing in template interpreter Reviewed-by: goetz, gromero ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp Changeset: 6674c579dc75 Author: ysuenaga Date: 2019-01-11 23:32 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6674c579dc75 8216486: Possibility of integer overflow in JfrThreadSampler::run() Reviewed-by: rehn, sgehwolf ! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp Changeset: 5fc74655f16d Author: sgehwolf Date: 2019-01-11 13:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5fc74655f16d 8216559: [JFR] Native libraries not correctly parsed from /proc/self/maps Summary: Use %7s for the dev scan format as major:minor may be up to that length Reviewed-by: mgronlun, jwilhelm ! src/hotspot/os/linux/os_linux.cpp ! test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java Changeset: 970ef4a71e59 Author: clanger Date: 2018-09-28 06:39 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/970ef4a71e59 8211218: remove double semicolon in src/java.desktop/macosx/classes/sun/font/CFont.java Reviewed-by: serb ! src/java.desktop/macosx/classes/sun/font/CFont.java Changeset: a7f53869e42b Author: robm Date: 2019-01-21 08:36 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a7f53869e42b Merge Changeset: 70320624c7b3 Author: mbaesken Date: 2019-01-04 17:46 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/70320624c7b3 8215962: Support ThreadPriorityPolicy mode 1 for non-root users on linux/bsd Reviewed-by: dcubed, dholmes ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 9606d9e8443e Author: mdoerr Date: 2018-12-14 09:59 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9606d9e8443e 8214352: C1: Unnecessary "compilation bailout: block join failed" with JVMTI Summary: Invalidate Phi functions for conflicting types and avoid bailout. Reviewed-by: kvn, iveresov ! src/hotspot/share/c1/c1_Instruction.cpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/c1/c1_ValueStack.hpp Changeset: 312a4a1b2d99 Author: gromero Date: 2018-11-28 13:16 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/312a4a1b2d99 8214451: PPC64/s390: Clean up unused CRC32 prototype and function Reviewed-by: mdoerr, lucy ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/stubRoutines_ppc.hpp ! src/hotspot/cpu/s390/macroAssembler_s390.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.hpp Changeset: e513ab26f5d4 Author: mdoerr Date: 2019-01-21 09:44 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e513ab26f5d4 8216060: [PPC64] Vector CRC implementation should be used by interpreter and be faster for short arrays Reviewed-by: gromero, goetz ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! src/hotspot/cpu/ppc/stubRoutines_ppc.hpp ! src/hotspot/cpu/ppc/stubRoutines_ppc_64.cpp ! src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp Changeset: d8c737fcf612 Author: mhorie Date: 2019-01-18 08:31 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d8c737fcf612 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace Reviewed-by: kvn, rriggs, mdoerr, gromero ! make/data/characterdata/CharacterData00.java.template ! make/data/characterdata/CharacterData01.java.template ! make/data/characterdata/CharacterData02.java.template ! make/data/characterdata/CharacterData0E.java.template ! make/data/characterdata/CharacterDataLatin1.java.template ! make/data/characterdata/CharacterDataPrivateUse.java.template ! make/data/characterdata/CharacterDataUndefined.java.template ! src/hotspot/cpu/ppc/assembler_ppc.hpp ! src/hotspot/cpu/ppc/assembler_ppc.inline.hpp ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/ppc/vm_version_ppc.cpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/opto/c2_globals.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/intrinsicnode.hpp ! src/hotspot/share/opto/library_call.cpp ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/lang/CharacterData.java + test/micro/org/openjdk/bench/java/lang/Characters.java Changeset: f18299da5814 Author: kvn Date: 2019-01-18 11:55 -0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f18299da5814 8215317: [GRAAL] unit test CheckGraalIntrinsics failed after 8213754 Summary: Fix CheckGraalIntrinsics test for new intrinsics. Reviewed-by: iveresov, never ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java Changeset: cf06455aff0e Author: xuelei Date: 2018-09-20 14:19 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/cf06455aff0e 8210974: No extensions debug log for ClientHello Reviewed-by: jnimeh, wetmore ! src/java.base/share/classes/sun/security/ssl/SSLExtensions.java Changeset: e746d3e28aae Author: afarley Date: 2018-12-04 09:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e746d3e28aae 8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler Reviewed-by: simonis, erikj, ihse, stuefe, mbaesken ! make/launcher/Launcher-jdk.pack.gmk ! make/launcher/LauncherCommon.gmk ! make/lib/LibCommon.gmk Changeset: c32cfebf95f9 Author: phh Date: 2019-01-28 07:58 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c32cfebf95f9 8217520: Remove vm.opt.MaxGCPauseMillis == "null" from TestOldGenCollectionUsage.java Summary: Remove the corresponding @requires line Reviewed-by: tschatzl ! test/hotspot/jtreg/gc/g1/mixedgc/TestOldGenCollectionUsage.java Changeset: 9f85aec34a63 Author: tonyp Date: 2018-07-23 11:38 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9f85aec34a63 8207849: Allow the addition of more number to the Java version string Reviewed-by: erikj ! make/autoconf/jdk-version.m4 ! make/autoconf/spec.gmk.in ! make/autoconf/version-numbers Changeset: cf8e84225ce9 Author: clanger Date: 2019-01-25 10:59 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/cf8e84225ce9 8217657: Move the test for default value of jdk.includeInExceptions into own test Reviewed-by: mullan, goetz ! test/jdk/java/net/Socket/ExceptionText.java + test/jdk/jdk/security/JavaDotSecurity/TestJDKIncludeInExceptions.java Changeset: 2c35c998a216 Author: ngasson Date: 2019-01-22 10:25 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/2c35c998a216 8217427: (dc) nio/channels/DatagramChannel/UseDGWithIPv6.java fails without IPv6 Reviewed-by: alanb, clanger ! test/jdk/java/nio/channels/DatagramChannel/UseDGWithIPv6.java Changeset: 4814af49ecbb Author: sherman Date: 2018-09-18 10:43 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/4814af49ecbb 8034802: (zipfs) newFileSystem throws UOE when the zip file is located in a custom file system Reviewed-by: xiaofeya, clanger + src/jdk.zipfs/share/classes/jdk/nio/zipfs/ByteArrayChannel.java ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java ! test/jdk/jdk/nio/zipfs/ZipFSTester.java Changeset: 75672ce3d004 Author: coffeys Date: 2019-01-29 11:58 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/75672ce3d004 8212941: Support new Japanese era in java.time.chrono.JapaneseEra Reviewed-by: chegar, naoto, coffeys Contributed-by: deepak.kejriwal at oracle.com ! src/java.base/share/classes/java/time/chrono/JapaneseEra.java Changeset: c1e1669edace Author: coffeys Date: 2019-01-29 12:00 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c1e1669edace 8216546: Support new Japanese era in java.lang.Character for Java SE 11 Reviewed-by: chegar, naoto, rriggs, coffeys Contributed-by: deepak.kejriwal at oracle.com ! src/java.base/share/classes/java/lang/Character.java Changeset: 37877e665dbb Author: stuefe Date: 2019-01-30 14:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/37877e665dbb 8212173: Thread._stack_base/_stack_size initialized too late for new threads Reviewed-by: dholmes, simonis ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/solaris/os_solaris.hpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os_cpu/aix_ppc/os_aix_ppc.cpp ! src/hotspot/os_cpu/bsd_x86/os_bsd_x86.cpp ! src/hotspot/os_cpu/bsd_zero/os_bsd_zero.cpp ! src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp ! src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp ! src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp ! src/hotspot/os_cpu/linux_sparc/os_linux_sparc.cpp ! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp ! src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp ! src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp ! src/hotspot/share/gc/parallel/gcTaskThread.cpp ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmThread.cpp Changeset: 7d1ee08bc241 Author: jnimeh Date: 2018-11-13 18:22 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d1ee08bc241 8212885: TLS 1.3 resumed session does not retain peer certificate chain Reviewed-by: xuelei, wetmore ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/PostHandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksClient.java Changeset: 5fef030dd8e5 Author: apetcher Date: 2018-11-21 15:06 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5fef030dd8e5 8213202: Possible race condition in TLS 1.3 session resumption Reviewed-by: jnimeh ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java Changeset: 6cd57917d46d Author: apetcher Date: 2018-12-11 11:01 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6cd57917d46d 8214688: TLS 1.3 session resumption with hello retry request failed with "illegal_parameter" Reviewed-by: jnimeh ! src/java.base/share/classes/sun/security/ssl/ClientHandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java Changeset: dd764f251274 Author: mullan Date: 2019-01-29 10:24 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/dd764f251274 8217579: TLS_EMPTY_RENEGOTIATION_INFO_SCSV is disabled after 8211883 Reviewed-by: jnimeh, clanger ! src/java.base/share/classes/sun/security/ssl/SSLAlgorithmDecomposer.java ! test/jdk/javax/net/ssl/sanity/ciphersuites/CheckCipherSuites.java Changeset: 78b38786a8e2 Author: mdoerr Date: 2019-01-25 09:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/78b38786a8e2 8217459: [PPC64] Cleanup non-vector version of CRC32 Reviewed-by: gromero, goetz ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! src/hotspot/cpu/ppc/stubRoutines_ppc.hpp ! src/hotspot/cpu/ppc/stubRoutines_ppc_64.cpp ! src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp Changeset: 606182671211 Author: ysuenaga Date: 2019-02-01 21:43 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/606182671211 8217432: MetaspaceGC::_capacity_until_GC exceeds MaxMetaspaceSize Reviewed-by: tschatzl, stuefe ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace.hpp ! test/hotspot/jtreg/vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java Changeset: b65e14ddff51 Author: goetz Date: 2019-01-29 08:43 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b65e14ddff51 8217628: Verbose ArrayIndexOutOfBoundsException message also in JNI calls. Reviewed-by: mdoerr, dholmes, lfoltan ! src/hotspot/share/prims/jni.cpp ! test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java + test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/libArrayIndexOutOfBoundsExceptionTest.c Changeset: 8506d9c7fc4a Author: roland Date: 2018-11-14 13:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8506d9c7fc4a 8213419: C2 may hang in MulLNode::Ideal()/MulINode::Ideal() with gcc 8.2.1 Reviewed-by: kvn, dlong, aph ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp + test/hotspot/jtreg/compiler/integerArithmetic/MultiplyByIntegerMinHang.java Changeset: 960d89a5b12a Author: roland Date: 2019-02-01 11:36 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/960d89a5b12a 8214206: Fix for JDK-8213419 is broken on 32-bit Reviewed-by: mdoerr, shade ! src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp ! src/hotspot/cpu/s390/c1_LIRGenerator_s390.cpp ! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp ! src/hotspot/cpu/sparc/c1_LIRGenerator_sparc.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp ! src/hotspot/share/opto/divnode.cpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/runtime/compilationPolicy.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/simpleThresholdPolicy.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/hotspot/share/utilities/hashtable.cpp Changeset: d0f5c7702207 Author: stuefe Date: 2019-02-01 10:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d0f5c7702207 8218156: "jcmd VM.metaspace basic" misreports free chunk space Reviewed-by: zgu ! src/hotspot/share/memory/metaspace.cpp Changeset: 2a723a9e9ef3 Author: shade Date: 2019-01-17 17:28 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/2a723a9e9ef3 8217321: [TESTBUG] utilities/test_globalDefinitions.cpp should use _LP64, not LP64 Reviewed-by: tschatzl, coleenp ! test/hotspot/gtest/utilities/test_globalDefinitions.cpp Changeset: f05fb1cc6882 Author: mbalao Date: 2018-11-09 10:34 -0300 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f05fb1cc6882 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts Summary: Improvements on the synchronization of SequencedEvent events from different AppContexts Reviewed-by: serb ! src/java.desktop/share/classes/java/awt/SequencedEvent.java + test/jdk/java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java + test/jdk/java/awt/event/SequencedEvent/MultipleContextsUnitTest.java - test/jdk/java/awt/event/SequencedEvent/SequencedEventTest.java Changeset: 9bdf3d861018 Author: shade Date: 2019-01-19 11:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9bdf3d861018 8217378: UseCriticalCMSThreadPriority is broken Reviewed-by: rkennke, dcubed ! src/hotspot/share/runtime/os.cpp + test/hotspot/jtreg/gc/cms/TestCriticalPriority.java Changeset: dbe0a36a3d58 Author: shade Date: 2019-01-09 20:28 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/dbe0a36a3d58 8216302: StackTraceElement::fill_in can use cached Class.name Reviewed-by: coleenp, dholmes, mchung ! make/hotspot/symbols/symbols-unix ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/native/libjava/Class.c + test/hotspot/jtreg/runtime/StackTrace/StackTraceClassCache.java Changeset: ff2da8d7afc7 Author: shade Date: 2019-01-14 17:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ff2da8d7afc7 8216308: StackTraceElement::fill_in can use injected Class source-file Reviewed-by: coleenp, dholmes ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmSymbols.hpp Changeset: 050c888ebf3d Author: shade Date: 2019-01-18 16:40 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/050c888ebf3d 8217014: Epsilon should not ignore Metadata GC causes Reviewed-by: stuefe, zgu ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp + test/hotspot/jtreg/gc/epsilon/TestClasses.java Changeset: d5e4cb94efc1 Author: shade Date: 2019-01-25 16:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d5e4cb94efc1 8217471: [TESTBUG] gc/epsilon/TestClasses.java fails on some platforms - OOME Metaspace Reviewed-by: dholmes, tschatzl ! test/hotspot/jtreg/gc/epsilon/TestClasses.java Changeset: 6495ee123bce Author: zgu Date: 2019-02-14 10:11 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6495ee123bce 8200109: NMT: diff_malloc_site assert(early->flags() == current->flags(), "Must be the same memory type") Reviewed-by: shade, coleenp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/services/memReporter.cpp + test/hotspot/jtreg/runtime/NMT/MallocSiteTypeChange.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: 738b99400d75 Author: manc Date: 2018-11-13 22:08 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/738b99400d75 8213829: Remove circular dependency between g1CollectedHeap and g1ConcurrentMark Summary: Improve include statements related to g1CollectedHeap.inline.hpp Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/dirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1FullGCReferenceProcessorExecutor.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp Changeset: 8efc32a04106 Author: jnimeh Date: 2018-12-06 22:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8efc32a04106 8214129: SSL session resumption/SNI with TLS1.2 causes StackOverflowError Reviewed-by: xuelei, jjiang ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java Changeset: 5589d5407ed8 Author: zgu Date: 2019-01-20 12:20 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5589d5407ed8 8217342: Build failed with excluding JFR Reviewed-by: shade, pliden ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/zTracer.cpp Changeset: 1a52113cac2a Author: thartmann Date: 2018-08-17 08:21 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1a52113cac2a 8208275: C2 crash in Node::add_req(Node*) Summary: Split-if optimization should not process (dead) counted loops. Reviewed-by: roland ! src/hotspot/share/opto/ifnode.cpp + test/hotspot/jtreg/compiler/loopopts/TestOneIterationStripMined.java Changeset: 00f90cb49b14 Author: lmesnik Date: 2018-08-21 13:17 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/00f90cb49b14 8209758: 2 classes with same name G1PrintCollectionSetClosure cause crash when logging is enabled Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/g1/g1CollectionSet.cpp Changeset: 5542f6e946c9 Author: joehw Date: 2018-08-22 14:28 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5542f6e946c9 8209615: ParseError in XMLEventReader on a valid input Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java Changeset: 8cf38073b9a2 Author: joehw Date: 2018-09-18 13:31 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8cf38073b9a2 8210874: Test for JDK-8209615 Reviewed-by: lancea + test/jaxp/javax/xml/jaxp/unittest/stream/XMLEventReaderTest/JDK8209615.java Changeset: 808748a49c25 Author: hseigel Date: 2018-10-11 11:31 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/808748a49c25 8211821: PrintStringTableStatistics crashes JVM Summary: During JVM exit, print the Symbol and String tables before current thread gets deleted. Reviewed-by: iklam, dholmes ! src/hotspot/share/runtime/java.cpp ! src/hotspot/share/runtime/thread.cpp + test/hotspot/jtreg/runtime/PrintStringTableStats/PrintStringTableStatsTest.java Changeset: 8e6ddf414a98 Author: egahlin Date: 2018-12-07 18:00 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8e6ddf414a98 8213421: Line number information for execution samples always 0 Reviewed-by: mgronlun ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.hpp Changeset: e973f836be3a Author: mchinnathamb Date: 2018-12-18 12:59 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e973f836be3a 8215397: jsig.c missing classpath exception Reviewed-by: dholmes ! src/java.base/unix/native/libjsig/jsig.c Changeset: a363f160b05a Author: prr Date: 2019-01-22 17:31 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a363f160b05a 8216965: crash in freetypeScaler.c CopyBW2Grey8 Reviewed-by: serb, mbaesken ! src/java.desktop/share/native/libfontmanager/freetypeScaler.c + test/jdk/java/awt/FontClass/FontSize1Test.java Changeset: a4de04b0d564 Author: ccheung Date: 2019-01-03 14:33 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a4de04b0d564 8215947: JVM crash with -XX:+DumpSharedSpaces Summary: disable JIT compilation if -XX:+DumpSharedSpaces is specified by the user Reviewed-by: lfoltan, jiangli ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/runtime/SharedArchiveFile/SharedArchiveFile.java Changeset: d12bbd4b453c Author: joehw Date: 2019-01-04 10:42 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d12bbd4b453c 8215330: javax.xml.catalog.CatalogResolverImpl: GroupEntry.matchURI fails to match Reviewed-by: lancea ! src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java + test/jaxp/javax/xml/jaxp/unittest/catalog/GroupTest.java + test/jaxp/javax/xml/jaxp/unittest/catalog/GroupTest.xml Changeset: 1b33c1444fd5 Author: valeriep Date: 2018-11-07 01:04 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1b33c1444fd5 8211049: Second parameter of "initialize" method is not used Summary: Use the specified random object instead of system default Reviewed-by: weijun ! src/java.base/share/classes/sun/security/rsa/RSAKeyPairGenerator.java + test/jdk/sun/security/rsa/TestKeyPairGeneratorInit.java Changeset: ecd45206087d Author: egahlin Date: 2018-12-07 14:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ecd45206087d 8207829: FlightRecorderMXBeanImpl is leaking the first classloader which calls it Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/RequestEngine.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java + test/jdk/jdk/jfr/jmx/TestFlightRecorderMXBeanLeak.java Changeset: ea39ba358ab3 Author: egahlin Date: 2018-11-05 14:40 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ea39ba358ab3 8209960: -Xlog:jfr* doesn't work with the JFR Reviewed-by: mgronlun ! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVMSupport.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/LogTag.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Logger.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/MetadataReader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/SettingsManager.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Type.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/TypeLibrary.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdCheck.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdConfigure.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdDump.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStop.java Changeset: d2ac1cb44233 Author: lancea Date: 2018-10-07 14:35 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d2ac1cb44233 8211765: JarFile constructor throws undocumented exception Reviewed-by: lancea, sherman, alanb, chegar Contributed-by: Jaikiran Pai ! src/java.base/share/classes/java/util/zip/ZipFile.java ! test/jdk/java/util/jar/JarFile/Constructor.java Changeset: 56d673a2ff47 Author: coffeys Date: 2018-12-05 17:33 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/56d673a2ff47 8213952: Relax DNSName restriction as per RFC 1123 Reviewed-by: weijun, mullan, chegar ! src/java.base/share/classes/sun/security/x509/DNSName.java ! src/java.base/share/classes/sun/security/x509/GeneralName.java ! src/java.base/share/classes/sun/security/x509/RFC822Name.java ! src/java.base/share/classes/sun/security/x509/URIName.java ! src/java.base/share/classes/sun/security/x509/X500Name.java ! test/jdk/sun/security/tools/keytool/KeyToolTest.java + test/jdk/sun/security/x509/GeneralName/DNSNameTest.java Changeset: a844fbcd2618 Author: egahlin Date: 2018-12-07 17:11 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a844fbcd2618 8212232: Wrong metadata for the configuration of the cutoff for old object sample events Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/settings/CutoffSetting.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/settings/PeriodSetting.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/settings/ThresholdSetting.java Changeset: ec202962d1c1 Author: shade Date: 2019-01-30 19:45 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ec202962d1c1 8217994: os::print_hex_dump should be more resilient against unreadable memory Reviewed-by: zgu, stuefe, lucy ! src/hotspot/share/runtime/os.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: f7bc4cb8efb4 Author: shade Date: 2019-01-18 17:05 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/f7bc4cb8efb4 8217315: Proper units should print more significant digits Reviewed-by: stuefe, tschatzl ! src/hotspot/share/utilities/globalDefinitions.hpp ! test/hotspot/gtest/utilities/test_globalDefinitions.cpp Changeset: ceb89d69305a Author: mgronlun Date: 2018-12-21 16:56 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ceb89d69305a 8215727: Restore JFR thread sampler loop to old / previous behavior Reviewed-by: egahlin, mgronlun Contributed-by: milan.mimica at gmail.com ! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp Changeset: 62fae67d3695 Author: lancea Date: 2018-10-01 13:05 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/62fae67d3695 8211295: DriverManager.getConnection fails when called from com.sun.rowset.JdbcRowSetImpl Reviewed-by: mchung, alanb ! src/java.sql/share/classes/java/sql/DriverManager.java ! test/jdk/java/sql/testng/util/StubConnection.java + test/jdk/javax/sql/testng/test/rowset/jdbcrowset/JdbcRowSetDriverManagerTest.java Changeset: b44928c9ec71 Author: aph Date: 2018-10-03 17:29 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b44928c9ec71 8211163: UNIX version of Java_java_io_Console_echo does not return a clean boolean Reviewed-by: shade, alanb ! src/java.base/unix/native/libjava/Console_md.c Changeset: b8e1bb78e6e9 Author: itakiguchi Date: 2018-11-01 17:48 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b8e1bb78e6e9 8211382: ISO2022JP and GB18030 NIO converter issues Reviewed-by: sherman, rriggs ! src/jdk.charsets/share/classes/sun/nio/cs/ext/GB18030.java.template ! src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_JP.java + test/jdk/sun/nio/cs/TestGB18030.java ! test/jdk/sun/nio/cs/TestISO2022JP.java Changeset: ad065da28c45 Author: aoqi Date: 2019-01-31 23:56 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ad065da28c45 8217597: [TESTBUG] old version docker does not support --cpus Summary: "--cpus" is only available in Docker 1.13 and higher, and is the equivalent of setting both --cpu-period and --cpu-quota. Reviewed-by: bobv, dholmes Contributed-by: aoqi at loongson.cn ! test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java Changeset: 74aaaf4cc105 Author: shade Date: 2019-02-19 13:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/74aaaf4cc105 8219251: Langtools tests default memory size needs to be 768m Reviewed-by: aph, clanger ! make/RunTests.gmk Changeset: 9612496fdb2f Author: ssahoo Date: 2018-11-14 23:12 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9612496fdb2f 8211787: javax/net/ssl/TLSCommon/TLSTest.java throws java.net.SocketTimeoutException: Read timed out Summary: java.net.SocketTimeoutException: Read timed out Reviewed-by: xuelei ! test/jdk/javax/net/ssl/TLSCommon/TLSTest.java Changeset: 93f4a52e6c8e Author: dmarkov Date: 2018-11-29 15:17 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/93f4a52e6c8e 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files Reviewed-by: kaddepalli, aivanov, serb ! src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp Changeset: b2c1b2cf0131 Author: xuelei Date: 2018-12-14 17:51 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b2c1b2cf0131 8213782: NullPointerException in sun.security.ssl.OutputRecord.changeWriteCiphers Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/ssl/ChangeCipherSpec.java ! src/java.base/share/classes/sun/security/ssl/Finished.java ! src/java.base/share/classes/sun/security/ssl/KeyUpdate.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java Changeset: c462d75dd8e3 Author: stooke Date: 2019-01-16 13:38 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c462d75dd8e3 8216578: Remove unused/obsolete method in JFR code Reviewed-by: mgronlun, mikael ! src/hotspot/share/jfr/periodic/jfrOSInterface.cpp Changeset: 88c4f803dd3c Author: jiangli Date: 2019-01-10 13:03 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/88c4f803dd3c 8214827: Incorrect call ClassLoaders.toFileURL("jrt:/java.compiler") Summary: Use URL constructor for jrt URL in SystemDictionaryShared::get_shared_protection_domain(). Reviewed-by: ccheung, iklam, dholmes, coleenp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! test/hotspot/jtreg/runtime/appcds/ProtectionDomain.java ! test/hotspot/jtreg/runtime/appcds/test-classes/JimageClassProtDomain.java ! test/hotspot/jtreg/runtime/appcds/test-classes/ProtDomain.java ! test/hotspot/jtreg/runtime/appcds/test-classes/ProtDomainB.java Changeset: 18b4acfaaa97 Author: xuelei Date: 2018-12-14 19:39 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/18b4acfaaa97 8214339: SSLSocketImpl erroneously wraps SocketException Reviewed-by: ascarpino, jnimeh ! src/java.base/share/classes/sun/security/ssl/Alert.java ! src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/TransportContext.java + test/jdk/javax/net/ssl/templates/SSLContextTemplate.java + test/jdk/sun/security/ssl/SSLSocketImpl/SSLExceptionForIOIssue.java Changeset: cda64d0af641 Author: sherman Date: 2018-09-04 17:04 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/cda64d0af641 8197398: (zipfs) Files.walkFileTree walk indefinitelly while processing JAR file with "/" as a directory inside. Reviewed-by: alanb ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java ! test/jdk/jdk/nio/zipfs/ZFSTests.java Changeset: 65b2452a181c Author: weijun Date: 2018-11-27 08:51 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/65b2452a181c 8214100: use of keystore probing results in unnecessary exception thrown Reviewed-by: mullan ! src/java.base/share/classes/java/security/KeyStore.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java + test/jdk/sun/security/tools/keytool/ProbingFailure.java ! test/lib/jdk/test/lib/process/ProcessTools.java Changeset: 79e42fda296c Author: weijun Date: 2018-12-05 08:48 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/79e42fda296c 8214513: A PKCS12 keystore from Java 8 using custom PBE parameters cannot be read in Java 11 Reviewed-by: mullan ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java + test/jdk/sun/security/pkcs12/WrongPBES2.java Changeset: c9bc1abfdf28 Author: shade Date: 2019-02-20 16:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c9bc1abfdf28 8219260: Default number of test jobs needs to be consistently calculated Reviewed-by: aph, clanger, erikj ! make/RunTests.gmk Changeset: 741bd6b212cc Author: mullan Date: 2018-12-11 13:22 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/741bd6b212cc 8207258: Distrust TLS server certificates anchored by Symantec Root CAs Reviewed-by: weijun + src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java ! src/java.base/share/classes/sun/security/validator/EndEntityChecker.java + src/java.base/share/classes/sun/security/validator/SymantecTLSPolicy.java ! src/java.base/share/classes/sun/security/validator/Validator.java ! src/java.base/share/conf/security/java.security + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/geotrustglobalca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/geotrustprimarycag2-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/geotrustprimarycag3-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/geotrustuniversalca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/thawteprimaryrootca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/thawteprimaryrootcag2-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/thawteprimaryrootcag3-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/verisignclass3g3ca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/verisignclass3g4ca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/verisignclass3g5ca-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/verisignclass3g5ca-codesigning-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/verisignuniversalrootca-chain.pem + test/lib/jdk/test/lib/security/SecurityUtils.java Changeset: fb58996c6d6f Author: mullan Date: 2019-01-22 09:27 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/fb58996c6d6f 8216280: Allow later Symantec Policy distrust date for two Apple SubCAs Reviewed-by: coffeys ! src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java ! src/java.base/share/classes/sun/security/validator/EndEntityChecker.java ! src/java.base/share/classes/sun/security/validator/SymantecTLSPolicy.java ! src/java.base/share/classes/sun/security/validator/Validator.java ! src/java.base/share/conf/security/java.security ! test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/appleistca2g1-chain.pem + test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/appleistca8g1-chain.pem Changeset: 7564c2cc5dbb Author: alitvinov Date: 2018-11-12 22:28 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/7564c2cc5dbb 8187364: Unable to enter zero width non-joiner (ZWNJ) symbol in Swing text component Reviewed-by: serb, dmarkov ! src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java Changeset: 09456a6d05fb Author: serb Date: 2018-11-02 15:38 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/09456a6d05fb 8207070: Webstart app popup on wrong screen in a one-screen setup changing to multi-monitor Reviewed-by: prr ! src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java ! src/java.desktop/windows/classes/sun/awt/windows/WWindowPeer.java + test/jdk/java/awt/Toolkit/DisplayChangesException/DisplayChangesException.java Changeset: 5a20f10008ba Author: sherman Date: 2018-09-05 09:12 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5a20f10008ba 8210394: (zipfs) jdk/nio/zipfs/ZFSTests.java rootdir.zip: The process cannot access the file because it is being used by another process Reviewed-by: alanb, jlaskey ! test/jdk/jdk/nio/zipfs/ZFSTests.java Changeset: dbc6ec189ad6 Author: dmarkov Date: 2018-12-06 13:32 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/dbc6ec189ad6 8213983: [macosx] Keyboard shortcut ?cmd +`? stops working properly if popup window is displayed Reviewed-by: kaddepalli, serb ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 03b3109b8fdd Author: alitvinov Date: 2018-08-27 18:29 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/03b3109b8fdd 8201818: [macosx] Printing attributes break page size set via "java.awt.print.Book" object Reviewed-by: prr, psadhukhan ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java + test/jdk/java/awt/print/PageFormat/WrongPaperForBookPrintingTest.java Changeset: fdce193fca1c Author: jjg Date: 2019-01-15 11:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/fdce193fca1c 8212233: javadoc fails on jdk12 with "The code being documented uses modules but the packages defined in $URL are in the unnamed module." Reviewed-by: hannesw, pmuthuswamy ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Extern.java + test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOptionWithAutomaticModule.java Changeset: 92631e5c6ac1 Author: tnakamura Date: 2018-12-13 00:46 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/92631e5c6ac1 8213183: InputMethod cannot be used after its restarting Summary: Retains masks at XSelectInput and deletes all IM data at DestroyXIMCallback Reviewed-by: naoto ! src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java ! src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c + test/jdk/java/awt/im/InputContext/ReconnectTest.java Changeset: 99aff95cfd08 Author: itakiguchi Date: 2019-01-06 19:28 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/99aff95cfd08 8211267: StackOverflowError happened by TextField.setFont(...) Reviewed-by: serb, prr ! src/java.desktop/unix/classes/sun/awt/X11/XTextFieldPeer.java + test/jdk/java/awt/TextField/FontChangeTest/FontChangeTest.java Changeset: 69ca38220233 Author: shade Date: 2019-02-16 21:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/69ca38220233 8216049: stringTable::intern creates redundant String when looking up existing one Reviewed-by: redestad, gziemski, rehn, zgu, jiangli ! src/hotspot/share/classfile/stringTable.cpp Changeset: 7a8527a0115e Author: aph Date: 2018-12-21 17:14 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/7a8527a0115e 8215202: AArch64: jtreg test test/jdk/sun/nio/cs/FindEncoderBugs.java fails Reviewed-by: aph Contributed-by: nick.gasson at arm.com ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! test/jdk/sun/nio/cs/FindEncoderBugs.java Changeset: eb645fac9846 Author: aph Date: 2018-12-20 17:07 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/eb645fac9846 8215100: AArch64: fix compareTo intrinsic with four-character Latin/Unicode Reviewed-by: aph, dpochepk Contributed-by: nick.gasson at arm.com ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! test/hotspot/jtreg/compiler/intrinsics/string/TestStringIntrinsics2.java Changeset: fb7dee4bc45f Author: egahlin Date: 2018-12-12 18:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/fb7dee4bc45f 8165675: Trace event for thread park has incorrect unit for timeout Reviewed-by: mgronlun ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/prims/unsafe.cpp ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java ! test/jdk/jdk/jfr/event/runtime/TestThreadParkEvent.java ! test/jdk/jdk/jfr/jmx/security/TestEnoughPermission.java ! test/lib/jdk/test/lib/jfr/Events.java Changeset: 728178955615 Author: egahlin Date: 2018-12-08 14:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/728178955615 8213966: The ZGC JFR events should be marked as experimental Reviewed-by: pliden ! src/hotspot/share/jfr/metadata/metadata.xml Changeset: 2cf5bec8d8ba Author: egahlin Date: 2018-12-13 14:21 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/2cf5bec8d8ba 8215175: Inconsistencies in JFR event metadata Reviewed-by: mgronlun ! src/hotspot/share/jfr/leakprofiler/emitEventOperation.cpp ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/jfr/metadata/metadata.xsd ! src/hotspot/share/jfr/periodic/jfrNetworkUtilization.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/MetadataHandler.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/AbstractDCmd.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdCheck.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdConfigure.java + test/jdk/jdk/jfr/api/metadata/annotations/TestFormatMissingValue.java Changeset: a69dd232b3e7 Author: egahlin Date: 2018-12-13 23:25 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a69dd232b3e7 8215362: JFR GTest JfrTestNetworkUtilization fails Reviewed-by: mgronlun ! test/hotspot/gtest/jfr/test_networkUtilization.cpp ! test/jdk/jdk/jfr/event/runtime/TestNetworkUtilizationEvent.java Changeset: b3483fbaf236 Author: manc Date: 2019-02-05 08:20 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b3483fbaf236 8218192: Remove copy constructor for MemRegion Summary: Remove copy constructor in memRegion.hpp Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/memory/memRegion.hpp Changeset: 19a2f95cd8f4 Author: goetz Date: 2019-02-20 17:55 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/19a2f95cd8f4 8219461: Bump update version for OpenJDK jdk11.0.3 Reviewed-by: clanger ! make/autoconf/version-numbers Changeset: 2a7edc39dded Author: roland Date: 2018-11-26 17:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/2a7edc39dded 8214189: test/hotspot/jtreg/compiler/intrinsics/mathexact/MulExactLConstantTest.java fails on Windows x64 when run with -XX:-TieredCompilation Reviewed-by: kvn ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp + test/hotspot/jtreg/compiler/integerArithmetic/MultiplyByConstantLongMax.java Changeset: 32dface8136c Author: sjohanss Date: 2018-11-23 10:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/32dface8136c 8214118: HeapRegions marked as archive even if CDS mapping fails Reviewed-by: tschatzl, jiangli ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Allocator.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/filemap.hpp Changeset: cd1c042181e9 Author: jnimeh Date: 2018-10-16 12:05 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/cd1c042181e9 8210989: RSASSA-PSS certificate cannot be selected for client auth on TLSv1.2 Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/CertificateRequest.java ! src/java.base/share/classes/sun/security/ssl/HandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/X509Authentication.java Changeset: 80d25f7feef9 Author: clanger Date: 2019-02-27 12:43 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/80d25f7feef9 Added tag jdk-11.0.3+1 for changeset cd1c042181e9 ! .hgtags Changeset: 3f6d0b57c622 Author: shade Date: 2019-03-05 20:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/3f6d0b57c622 Merge ! .hgtags ! make/autoconf/hotspot.m4 ! make/autoconf/version-numbers ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/memory/metaspace.hpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/ifnode.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/opto/subnode.cpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/utilities/bitMap.cpp ! src/hotspot/share/utilities/bitMap.hpp ! src/hotspot/share/utilities/bitMap.inline.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java - test/jdk/java/awt/event/SequencedEvent/SequencedEventTest.java From rwestrel at redhat.com Wed Mar 6 08:44:17 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 09:44:17 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> Message-ID: <87va0wwfxa.fsf@redhat.com> Maybe having 2 regions instead of a single wider one: enum { _heap_stable = 1, _heap_unstable, PATH_LIMIT }; Node* region = new RegionNode(PATH_LIMIT); Node* val_phi = new PhiNode(region, uncasted_val->bottom_type()->is_oopptr()); Node* raw_mem_phi = PhiNode::make(region, raw_mem, Type::MEMORY, TypeRawPtr::BOTTOM); enum { _not_cset = 1, _not_equal, _evac_path, _null_path, PATH_LIMIT2 }; Node* region2 = new RegionNode(PATH_LIMIT2); Node* val_phi2 = new PhiNode(region2, uncasted_val->bottom_type()->is_oopptr()); Node* raw_mem_phi2 = PhiNode::make(region2, raw_mem, Type::MEMORY, TypeRawPtr::BOTTOM); confuses the register allocator. That could be something to try. Roland. From rkennke at redhat.com Wed Mar 6 08:51:54 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 06 Mar 2019 09:51:54 +0100 Subject: LRB midpath code quality In-Reply-To: <87va0wwfxa.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87va0wwfxa.fsf@redhat.com> Message-ID: <17BDAFCF-1E3E-47D9-878D-2C6EC2A2380D@redhat.com> Will try with one region... Am 6. M?rz 2019 09:44:17 MEZ schrieb Roland Westrelin : > >Maybe having 2 regions instead of a single wider one: > > enum { _heap_stable = 1, _heap_unstable, PATH_LIMIT }; > Node* region = new RegionNode(PATH_LIMIT); >Node* val_phi = new PhiNode(region, >uncasted_val->bottom_type()->is_oopptr()); >Node* raw_mem_phi = PhiNode::make(region, raw_mem, Type::MEMORY, >TypeRawPtr::BOTTOM); > >enum { _not_cset = 1, _not_equal, _evac_path, _null_path, PATH_LIMIT2 >}; > Node* region2 = new RegionNode(PATH_LIMIT2); >Node* val_phi2 = new PhiNode(region2, >uncasted_val->bottom_type()->is_oopptr()); >Node* raw_mem_phi2 = PhiNode::make(region2, raw_mem, Type::MEMORY, >TypeRawPtr::BOTTOM); > >confuses the register allocator. That could be something to try. > >Roland. -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From rwestrel at redhat.com Wed Mar 6 08:54:38 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 09:54:38 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> Message-ID: <87sgw0wfg1.fsf@redhat.com> > Well yes, an implicit null-check would be good. It would never fire, > because if the value is null, it would blow up earlier in the cset > check. Or am I missing something? I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier load as a candidate for implicit null checks for some reason. Roland. From jborgers at jpinpoint.com Wed Mar 6 09:14:25 2019 From: jborgers at jpinpoint.com (Jeroen Borgers) Date: Wed, 6 Mar 2019 10:14:25 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Message-ID: Could I vote or watch the issues? Don't know how to be able to log in. -Jeroen Op di 5 mrt. 2019 om 19:54 schreef Jeroen Borgers : > Good to know. > Great it would be available next week. > > -Jeroen > > > Op di 5 mrt. 2019 15:02 schreef Aleksey Shipilev : > >> On 3/5/19 2:07 PM, Edwin Graven wrote: >> > Okay so THP is a bug, is there any change it will be possible to use >> LargePages instead of THP >> > like we do with G1?? If you can use LargePages there won?t be any risk >> of using swap. >> Yes, except the teeny-tiny detail that hugetlbfs support is also broken >> (argh): >> https://bugs.openjdk.java.net/browse/JDK-8220162 >> >> If everything goes right, patches would hit jdk/jdk (development head) >> this week, and Roman would >> backport them to 11u and 8u next week. >> >> -Aleksey >> >> From rkennke at redhat.com Wed Mar 6 09:20:33 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:20:33 +0100 Subject: LRB midpath code quality In-Reply-To: <87sgw0wfg1.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> Message-ID: <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> >> Well yes, an implicit null-check would be good. It would never fire, >> because if the value is null, it would blow up earlier in the cset >> check. Or am I missing something? > > I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier > load as a candidate for implicit null checks for some reason. Yes, maybe. But can you explain to me why it should be needed at all? If a dominating (implicit?) null-check before the in-cset-check should catch all nulls on that path already? Why does it matter? Roman From rkennke at redhat.com Wed Mar 6 09:29:40 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:29:40 +0100 Subject: LRB midpath code quality In-Reply-To: <87sgw0wfg1.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> Message-ID: I believe it does look better now: https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA Does it? Roman > >> Well yes, an implicit null-check would be good. It would never fire, >> because if the value is null, it would blow up earlier in the cset >> check. Or am I missing something? > > I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier > load as a candidate for implicit null checks for some reason. > > Roland. > From rkennke at redhat.com Wed Mar 6 09:34:03 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:34:03 +0100 Subject: LRB midpath code quality In-Reply-To: <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> Message-ID: <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> >>> Well yes, an implicit null-check would be good. It would never fire, >>> because if the value is null, it would blow up earlier in the cset >>> check. Or am I missing something? >> >> I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier >> load as a candidate for implicit null checks for some reason. > > Yes, maybe. > > But can you explain to me why it should be needed at all? If a > dominating (implicit?) null-check before the in-cset-check should catch > all nulls on that path already? Why does it matter? Also, I don't think we want to generate an NPE/SEGV on that path. We want to skip a bunch of stuff if the value is NULL. Roman From shade at redhat.com Wed Mar 6 09:34:07 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 10:34:07 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> Message-ID: On 3/6/19 10:29 AM, Roman Kennke wrote: > I believe it does look better now: > > https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA Yes, those back branches to 0x00007f46f04b9247 is what I wanted to see. The leftover wrinkle is explicit NPE here, which should be implicit: ?? 0x00007f46f04b9272: test %rax,%rax ?? 0x00007f46f04b9275: je 0x00007f46f04b9294 -Aleksey From shade at redhat.com Wed Mar 6 09:35:59 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 10:35:59 +0100 Subject: LRB midpath code quality In-Reply-To: <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> Message-ID: <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> On 3/6/19 10:34 AM, Roman Kennke wrote: >>>> Well yes, an implicit null-check would be good. It would never fire, >>>> because if the value is null, it would blow up earlier in the cset >>>> check. Or am I missing something? >>> >>> I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier >>> load as a candidate for implicit null checks for some reason. >> >> Yes, maybe. >> >> But can you explain to me why it should be needed at all? If a >> dominating (implicit?) null-check before the in-cset-check should catch >> all nulls on that path already? Why does it matter? > > Also, I don't think we want to generate an NPE/SEGV on that path. We > want to skip a bunch of stuff if the value is NULL. We might just back-branch to the access, no? And let NPE be handled there? In here: https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA This branch: 0x00007f46f04b9272: test %rax,%rax 0x00007f46f04b9275: je 0x00007f46f04b9294 ...can just go to where every other branch is going: 0x00007f46f04b9247: movl $0x2a,0x20(%rax) ; implicit exception: dispatches to 0x00007f46f04b9294 -Aleksey From rkennke at redhat.com Wed Mar 6 09:39:18 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:39:18 +0100 Subject: LRB midpath code quality In-Reply-To: <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> Message-ID: <2b028ca9-6281-9e3c-002e-8bba7a5a02f1@redhat.com> >>>>> Well yes, an implicit null-check would be good. It would never fire, >>>>> because if the value is null, it would blow up earlier in the cset >>>>> check. Or am I missing something? >>>> >>>> I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier >>>> load as a candidate for implicit null checks for some reason. >>> >>> Yes, maybe. >>> >>> But can you explain to me why it should be needed at all? If a >>> dominating (implicit?) null-check before the in-cset-check should catch >>> all nulls on that path already? Why does it matter? >> >> Also, I don't think we want to generate an NPE/SEGV on that path. We >> want to skip a bunch of stuff if the value is NULL. > > We might just back-branch to the access, no? And let NPE be handled there? > > In here: > https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA > > This branch: > > 0x00007f46f04b9272: test %rax,%rax > 0x00007f46f04b9275: je 0x00007f46f04b9294 > > ...can just go to where every other branch is going: > > 0x00007f46f04b9247: movl $0x2a,0x20(%rax) > ; implicit exception: dispatches to 0x00007f46f04b9294 The interesting question is this: we generate ideal code for null-check+branch before in-cset-check. What happened to this? Is it gone because C2 proved the value to be non-null? Why is the cloned branch not gone? Because it cannot be proven non-null? I believe this whole implicit NPE is nonsensical there: we don't want NPE or SEGV there, we want to branch back in case of null. I am trying a fix. It'd look like this then: https://paste.fedoraproject.org/paste/NHnR-sJFj8sJkESY5KS2XQ Roman From rkennke at redhat.com Wed Mar 6 09:44:29 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:44:29 +0100 Subject: LRB midpath code quality In-Reply-To: <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> Message-ID: <762bd24b-d6f1-a384-b311-8484fdd86f13@redhat.com> In case you want to see or experiment with it: http://cr.openjdk.java.net/~rkennke/streamline-lrb-midpath/streamline-lrb-midpath.patch hotspot_gc_shenandoah seems fine without the cloned null-check. Will also run all of specjvm before RFRing. Roland, WDYT? Roman > On 3/6/19 10:34 AM, Roman Kennke wrote: >>>>> Well yes, an implicit null-check would be good. It would never fire, >>>>> because if the value is null, it would blow up earlier in the cset >>>>> check. Or am I missing something? >>>> >>>> I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier >>>> load as a candidate for implicit null checks for some reason. >>> >>> Yes, maybe. >>> >>> But can you explain to me why it should be needed at all? If a >>> dominating (implicit?) null-check before the in-cset-check should catch >>> all nulls on that path already? Why does it matter? >> >> Also, I don't think we want to generate an NPE/SEGV on that path. We >> want to skip a bunch of stuff if the value is NULL. > > We might just back-branch to the access, no? And let NPE be handled there? > > In here: > https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA > > This branch: > > 0x00007f46f04b9272: test %rax,%rax > 0x00007f46f04b9275: je 0x00007f46f04b9294 > > ...can just go to where every other branch is going: > > 0x00007f46f04b9247: movl $0x2a,0x20(%rax) > ; implicit exception: dispatches to 0x00007f46f04b9294 > > -Aleksey > From rwestrel at redhat.com Wed Mar 6 09:43:54 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 10:43:54 +0100 Subject: LRB midpath code quality In-Reply-To: <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> Message-ID: <87mum8wd5x.fsf@redhat.com> > But can you explain to me why it should be needed at all? If a > dominating (implicit?) null-check before the in-cset-check should catch > all nulls on that path already? Why does it matter? That dominating check was removed so we can have an implicit null check so we don't execute any null check instruction. That doesn't quite work as the conversion to an implicit null check fails. But assuming that works, isn't it better to not execute a test for null? Roland. From shade at redhat.com Wed Mar 6 09:44:34 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 10:44:34 +0100 Subject: LRB midpath code quality In-Reply-To: <2b028ca9-6281-9e3c-002e-8bba7a5a02f1@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <7d106db1-ac80-1d6c-9573-9553975a6fa6@redhat.com> <2b028ca9-6281-9e3c-002e-8bba7a5a02f1@redhat.com> Message-ID: <3651ffc7-ab2f-0999-d19b-6852fc3140e0@redhat.com> On 3/6/19 10:39 AM, Roman Kennke wrote: >> We might just back-branch to the access, no? And let NPE be handled there? >> >> In here: >> https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA >> >> This branch: >> >> 0x00007f46f04b9272: test %rax,%rax >> 0x00007f46f04b9275: je 0x00007f46f04b9294 >> >> ...can just go to where every other branch is going: >> >> 0x00007f46f04b9247: movl $0x2a,0x20(%rax) >> ; implicit exception: dispatches to 0x00007f46f04b9294 > > The interesting question is this: we generate ideal code for > null-check+branch before in-cset-check. What happened to this? Is it > gone because C2 proved the value to be non-null? Why is the cloned > branch not gone? Because it cannot be proven non-null? I believe this > whole implicit NPE is nonsensical there: we don't want NPE or SEGV > there, we want to branch back in case of null. I am trying a fix. > > It'd look like this then: > https://paste.fedoraproject.org/paste/NHnR-sJFj8sJkESY5KS2XQ Explicit NP check appeared :( 0x00007ff3484bb0c0: test %rax,%rax 0x00007ff3484bb0c3: je 0x00007ff3484bb105 I think we better check for NP as we do now in mid-path, but just branch to access which would handle NPE. -Aleksey From rkennke at redhat.com Wed Mar 6 09:50:49 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 10:50:49 +0100 Subject: LRB midpath code quality In-Reply-To: <87mum8wd5x.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <87mum8wd5x.fsf@redhat.com> Message-ID: <72125065-0597-8d47-ffec-3a01e362a65c@redhat.com> >> But can you explain to me why it should be needed at all? If a >> dominating (implicit?) null-check before the in-cset-check should catch >> all nulls on that path already? Why does it matter? > > That dominating check was removed so we can have an implicit null check > so we don't execute any null check instruction. Ok, but why has it been removed? 1. In case C2 has proven the value to be not-NULL, I suppose we can just as well not null-check in the fwd ptr load? 2. In case it has been turned into an implicit NULL-check I argue that this is wrong: we don't want an NPE or SEGV there, we want to skip the whole path. Also, wouldn't the annotated assembly say so like 'implicit exception: dispatches to ...' ? > That doesn't quite work > as the conversion to an implicit null check fails. But assuming that > works, isn't it better to not execute a test for null? Sure. But that would only ever throw an NPE? Or can it be made to branch back too? And if so, it would have to be done *before* the cset check, not after, otherwise it would go BOOM there. Roman From rwestrel at redhat.com Wed Mar 6 09:51:40 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 10:51:40 +0100 Subject: LRB midpath code quality In-Reply-To: <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> Message-ID: <87k1hcwcsz.fsf@redhat.com> > Also, I don't think we want to generate an NPE/SEGV on that path. We > want to skip a bunch of stuff if the value is NULL. We don't generate an NullPointerException and we almost never have a sigsev as it's a path where no null have been seen. Roland. From rkennke at redhat.com Wed Mar 6 10:01:24 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 11:01:24 +0100 Subject: LRB midpath code quality In-Reply-To: <87k1hcwcsz.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <87k1hcwcsz.fsf@redhat.com> Message-ID: >> Also, I don't think we want to generate an NPE/SEGV on that path. We >> want to skip a bunch of stuff if the value is NULL. > > We don't generate an NullPointerException and we almost never have a > sigsev as it's a path where no null have been seen. Ah. So it speculates on non-NULL, and then deopts and recompiles if that assumption turns out be be wrong? In this case I agree: let's do it in midpath, using implicit null-check. But the issue remains: if we *do* get a NULL then we need to catch it before the cset-check? Or am I still missing something? Also, any idea how we could turn that explicit null-check into an implicit one? Roman From rwestrel at redhat.com Wed Mar 6 10:01:54 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 11:01:54 +0100 Subject: LRB midpath code quality In-Reply-To: <72125065-0597-8d47-ffec-3a01e362a65c@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <87mum8wd5x.fsf@redhat.com> <72125065-0597-8d47-ffec-3a01e362a65c@redhat.com> Message-ID: <87h8cgwcbx.fsf@redhat.com> > Ok, but why has it been removed? > 1. In case C2 has proven the value to be not-NULL, I suppose we can just > as well not null-check in the fwd ptr load? The null check is after the barrier. We load an oop field, emit the barrier, null check the oop and then do something with the oop. So at the point where the barrier is c2 hasn't proven the oop to be not null and there needs to be a null check. What the current code does is find that there's a null check after the barrier, find the null check never fails, move it in the barrier so we have no need for an explicit test for null. > 2. In case it has been turned into an implicit NULL-check I argue that > this is wrong: we don't want an NPE or SEGV there, we want to skip the > whole path. Also, wouldn't the annotated assembly say so like 'implicit > exception: dispatches to ...' ? The null check is there because it was observed to never trigger. So in practice there will be no SEGV. And if it ever triggers then the code will deoptimize and be recompiled. On the recompilation, the null check won't be seen as unlikely by c2 and it won't be moved around anymore. > Sure. But that would only ever throw an NPE? Or can it be made to branch > back too? And if so, it would have to be done *before* the cset check, > not after, otherwise it would go BOOM there. It's not going to branch back, it's going to deoptimize, very rarely. So this is saving the need for a check for null and a branch and we don't give up anything in exchange. Why would you not want that? Roland. From rwestrel at redhat.com Wed Mar 6 10:03:48 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 11:03:48 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <87k1hcwcsz.fsf@redhat.com> Message-ID: <87ef7kwc8r.fsf@redhat.com> > Also, any idea how we could turn that explicit null-check into an > implicit one? That should happen in PhaseCFG::implicit_null_check(). So something's not going the way it should there. Roland. From rkennke at redhat.com Wed Mar 6 10:04:50 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 11:04:50 +0100 Subject: LRB midpath code quality In-Reply-To: <87h8cgwcbx.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <87mum8wd5x.fsf@redhat.com> <72125065-0597-8d47-ffec-3a01e362a65c@redhat.com> <87h8cgwcbx.fsf@redhat.com> Message-ID: >> Ok, but why has it been removed? >> 1. In case C2 has proven the value to be not-NULL, I suppose we can just >> as well not null-check in the fwd ptr load? > > The null check is after the barrier. We load an oop field, emit the > barrier, null check the oop and then do something with the oop. So at > the point where the barrier is c2 hasn't proven the oop to be not null > and there needs to be a null check. What the current code does is find > that there's a null check after the barrier, find the null check never > fails, move it in the barrier so we have no need for an explicit test > for null. > >> 2. In case it has been turned into an implicit NULL-check I argue that >> this is wrong: we don't want an NPE or SEGV there, we want to skip the >> whole path. Also, wouldn't the annotated assembly say so like 'implicit >> exception: dispatches to ...' ? > > The null check is there because it was observed to never trigger. So in > practice there will be no SEGV. And if it ever triggers then the code > will deoptimize and be recompiled. On the recompilation, the null check > won't be seen as unlikely by c2 and it won't be moved around anymore. > >> Sure. But that would only ever throw an NPE? Or can it be made to branch >> back too? And if so, it would have to be done *before* the cset check, >> not after, otherwise it would go BOOM there. > > It's not going to branch back, it's going to deoptimize, very rarely. So > this is saving the need for a check for null and a branch and we don't > give up anything in exchange. Why would you not want that? ok, I understand now. Here's the patch with the null-check-cloning intact: http://cr.openjdk.java.net/~rkennke/streamline-lrb-midpath/streamline-lrb-midpath2.patch It still generates the explicit null-check inside the barrier midpath. Can you check how to eliminate that? Thanks, Roman From rkennke at redhat.com Wed Mar 6 10:10:35 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 11:10:35 +0100 Subject: LRB midpath code quality In-Reply-To: <87sgw0wfg1.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> Message-ID: <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> >> Well yes, an implicit null-check would be good. It would never fire, >> because if the value is null, it would blow up earlier in the cset >> check. Or am I missing something? > > I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier > load as a candidate for implicit null checks for some reason. Uhhh. I think I may have removed the -8 handling from MacroAssembler::needs_explicit_null_check() path in original LRB patch :-) Let me try to put that back... Roman From rkennke at redhat.com Wed Mar 6 10:15:24 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 11:15:24 +0100 Subject: LRB midpath code quality In-Reply-To: <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> Message-ID: <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> >>> Well yes, an implicit null-check would be good. It would never fire, >>> because if the value is null, it would blow up earlier in the cset >>> check. Or am I missing something? >> >> I suppose PhaseCFG::implicit_null_check() doesn't recognize the barrier >> load as a candidate for implicit null checks for some reason. > > Uhhh. I think I may have removed the -8 handling from > MacroAssembler::needs_explicit_null_check() path in original LRB patch :-) > > Let me try to put that back... Hmm, no. That path looks ok. I changed the fwdptr load to be raw access. Might that cause problems? Roman From shade at redhat.com Wed Mar 6 10:18:46 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 11:18:46 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Message-ID: On 3/6/19 10:14 AM, Jeroen Borgers wrote: > Could I vote or watch the issues? Don't know how to be able to log in. OpenJDK login is required for bugs.openjdk.java.net. The login comes with Author role: https://openjdk.java.net/projects/#project-author -Aleksey From rkennke at redhat.com Wed Mar 6 11:15:04 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 12:15:04 +0100 Subject: LRB midpath code quality In-Reply-To: <87ef7kwc8r.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <87k1hcwcsz.fsf@redhat.com> <87ef7kwc8r.fsf@redhat.com> Message-ID: <3b40d2a5-239b-03e3-0c95-345105d8c743@redhat.com> Roland: in this path: Node* new_val = uncasted_val; if (unc_ctrl != NULL) { // Clone the null check in this branch to allow implicit null check new_val = clone_null_check(ctrl, val, unc_ctrl, phase); fix_null_check(unc, unc_ctrl, ctrl->in(0)->as_If()->proj_out(0), uses, phase); IfNode* iff = unc_ctrl->in(0)->as_If(); phase->igvn().replace_input_of(iff, 1, phase->igvn().intcon(1)); } what is this replacement with constant 1 doing there? Roman >> Also, any idea how we could turn that explicit null-check into an >> implicit one? > > That should happen in PhaseCFG::implicit_null_check(). So something's > not going the way it should there. > > Roland. > From shade at redhat.com Wed Mar 6 11:27:25 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 12:27:25 +0100 Subject: RFR (XS) 8220228: Improve Shenandoah pacing histogram message Message-ID: <758bafed-fbae-2d98-b8a2-d74c3574d882@redhat.com> RFE: https://bugs.openjdk.java.net/browse/JDK-8220228 Patch: diff -r f88fbb5fc085 src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp > --- a/src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Wed Mar 06 12:01:55 2019 +0100 > +++ b/src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Wed Mar 06 12:26:06 2019 +0100 > @@ -297,6 +297,12 @@ > > out->print_cr("%7d ms - %7d ms: " SIZE_FORMAT_W(12) SIZE_FORMAT_W(12) " ms", l, r, count, sum); > } > out->print_cr("%23s: " SIZE_FORMAT_W(12) SIZE_FORMAT_W(12) " ms", "Total", total_count, total_sum); > out->cr(); > + out->print_cr("Pacing delays are measured from entering the pacing code till exiting it. Therefore,"); > + out->print_cr("observed pacing delays may be higher than the threshold when paced thread spent more"); > + out->print_cr("time in the pacing code. It usually happens when thread is de-scheduled while paced,"); > + out->print_cr("OS takes longer to unblock the thread, or JVM experiences the STW pause."); > + out->cr(); > + > } Testing: Linux x86_64 build, eyeballing -Xlog:gc+stats Thanks, -Aleksey From rwestrel at redhat.com Wed Mar 6 11:33:38 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 12:33:38 +0100 Subject: LRB midpath code quality In-Reply-To: <3b40d2a5-239b-03e3-0c95-345105d8c743@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <2a73faab-032c-110e-adf9-c1c8e2c7e3c8@redhat.com> <2b02eaf2-4c23-91cf-12cb-3c92fd407ee2@redhat.com> <87k1hcwcsz.fsf@redhat.com> <87ef7kwc8r.fsf@redhat.com> <3b40d2a5-239b-03e3-0c95-345105d8c743@redhat.com> Message-ID: <878sxsw831.fsf@redhat.com> > what is this replacement with constant 1 doing there? Killing the if. Roland. From rwestrel at redhat.com Wed Mar 6 11:33:55 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 12:33:55 +0100 Subject: LRB midpath code quality In-Reply-To: <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> Message-ID: <875zsww82k.fsf@redhat.com> > I changed the fwdptr load to be raw access. Might that cause problems? Not sure. I will take a look. Roland. From rkennke at redhat.com Wed Mar 6 11:36:54 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 12:36:54 +0100 Subject: LRB midpath code quality In-Reply-To: <875zsww82k.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> <875zsww82k.fsf@redhat.com> Message-ID: <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> >> I changed the fwdptr load to be raw access. Might that cause problems? > > Not sure. I will take a look. Thanks! I changed it back to proper -8 offset type, but it did not help. I am out of ideas. Roman From rkennke at redhat.com Wed Mar 6 11:51:16 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 12:51:16 +0100 Subject: RFR (XS) 8220228: Improve Shenandoah pacing histogram message In-Reply-To: <758bafed-fbae-2d98-b8a2-d74c3574d882@redhat.com> References: <758bafed-fbae-2d98-b8a2-d74c3574d882@redhat.com> Message-ID: <04e2b835-9d68-729e-6609-1fcfcd87dc94@redhat.com> I would say 'an STW pause' rather than 'the STW pause', other than that looks good. Thanks! Roman > RFE: > https://bugs.openjdk.java.net/browse/JDK-8220228 > > Patch: > > diff -r f88fbb5fc085 src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp >> --- a/src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Wed Mar 06 12:01:55 2019 +0100 >> +++ b/src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Wed Mar 06 12:26:06 2019 +0100 >> @@ -297,6 +297,12 @@ >> >> out->print_cr("%7d ms - %7d ms: " SIZE_FORMAT_W(12) SIZE_FORMAT_W(12) " ms", l, r, count, sum); >> } >> out->print_cr("%23s: " SIZE_FORMAT_W(12) SIZE_FORMAT_W(12) " ms", "Total", total_count, total_sum); >> out->cr(); >> + out->print_cr("Pacing delays are measured from entering the pacing code till exiting it. Therefore,"); >> + out->print_cr("observed pacing delays may be higher than the threshold when paced thread spent more"); >> + out->print_cr("time in the pacing code. It usually happens when thread is de-scheduled while paced,"); >> + out->print_cr("OS takes longer to unblock the thread, or JVM experiences the STW pause."); >> + out->cr(); >> + >> } > > Testing: Linux x86_64 build, eyeballing -Xlog:gc+stats > > Thanks, > -Aleksey > From rwestrel at redhat.com Wed Mar 6 12:37:05 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 13:37:05 +0100 Subject: LRB midpath code quality In-Reply-To: <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> <875zsww82k.fsf@redhat.com> <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> Message-ID: <87zhq8uqku.fsf@redhat.com> See patch below. Something got dropped accidentally it seems. Roland. diff -r 6075f6799044 src/hotspot/share/opto/lcm.cpp --- a/src/hotspot/share/opto/lcm.cpp Fri Feb 22 12:21:36 2019 +0100 +++ b/src/hotspot/share/opto/lcm.cpp Wed Mar 06 13:34:24 2019 +0100 @@ -178,6 +178,8 @@ case Op_LoadRange: case Op_LoadD_unaligned: case Op_LoadL_unaligned: + assert(mach->in(2) == val, "should be address"); + break; case Op_StoreB: case Op_StoreC: case Op_StoreCM: From rkennke at redhat.com Wed Mar 6 13:00:53 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 14:00:53 +0100 Subject: LRB midpath code quality In-Reply-To: <87zhq8uqku.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> <875zsww82k.fsf@redhat.com> <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> <87zhq8uqku.fsf@redhat.com> Message-ID: Wow wtf. Is this only in sh/jdk ? When did that happen?! Does it mean it foobar'ed *all* such implicit null-checks? I'm getting this code now: https://paste.fedoraproject.org/paste/oTr4OvMt~V2xrz70wNM4IQ looks good to me. This is the patch now: http://cr.openjdk.java.net/~rkennke/streamline-lrb-midpath/streamline-lrb-midpath3.patch Thanks for helping!! Roman > See patch below. Something got dropped accidentally it seems. > > Roland. > > diff -r 6075f6799044 src/hotspot/share/opto/lcm.cpp > --- a/src/hotspot/share/opto/lcm.cpp Fri Feb 22 12:21:36 2019 +0100 > +++ b/src/hotspot/share/opto/lcm.cpp Wed Mar 06 13:34:24 2019 +0100 > @@ -178,6 +178,8 @@ > case Op_LoadRange: > case Op_LoadD_unaligned: > case Op_LoadL_unaligned: > + assert(mach->in(2) == val, "should be address"); > + break; > case Op_StoreB: > case Op_StoreC: > case Op_StoreCM: > From rwestrel at redhat.com Wed Mar 6 13:07:45 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 06 Mar 2019 14:07:45 +0100 Subject: LRB midpath code quality In-Reply-To: References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> <875zsww82k.fsf@redhat.com> <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> <87zhq8uqku.fsf@redhat.com> Message-ID: <87tvggup5q.fsf@redhat.com> > Wow wtf. Is this only in sh/jdk ? When did that happen?! Does it mean it > foobar'ed *all* such implicit null-checks? changeset: 54694:a97e6642b12d user: rkennke date: Fri Feb 15 18:58:37 2019 +0100 summary: Load reference barriers diff -r db2675d861c0 -r a97e6642b12d src/hotspot/share/opto/lcm.cpp --- a/src/hotspot/share/opto/lcm.cpp Thu Feb 14 20:52:50 2019 +0100 +++ b/src/hotspot/share/opto/lcm.cpp Fri Feb 15 18:58:37 2019 +0100 @@ -182,9 +178,6 @@ case Op_LoadRange: case Op_LoadD_unaligned: case Op_LoadL_unaligned: - case Op_ShenandoahReadBarrier: - assert(mach->in(2) == val, "should be address"); - break; case Op_StoreB: case Op_StoreC: case Op_StoreCM: Yes, quite possible it broke more implicit null checks. Roland. From rkennke at redhat.com Wed Mar 6 13:12:58 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 14:12:58 +0100 Subject: LRB midpath code quality In-Reply-To: <87tvggup5q.fsf@redhat.com> References: <04654396-447e-1809-670f-b735cfcc0017@redhat.com> <87mum9yc21.fsf@redhat.com> <87imwxy9bu.fsf@redhat.com> <87sgw0wfg1.fsf@redhat.com> <06e7b851-0533-733b-7fea-d77058bd35a4@redhat.com> <76b4fba0-8e48-7134-cccb-32f6692d1eb5@redhat.com> <875zsww82k.fsf@redhat.com> <6569970b-0468-1d14-4473-20a1bf3eefc2@redhat.com> <87zhq8uqku.fsf@redhat.com> <87tvggup5q.fsf@redhat.com> Message-ID: <55419c85-b146-97c5-9ba6-e369c9e48ddb@redhat.com> Ok. Bad me :-) I'll run specjvm before/after let's see if we get improved performance from this patch. Thanks!! Roman > >> Wow wtf. Is this only in sh/jdk ? When did that happen?! Does it mean it >> foobar'ed *all* such implicit null-checks? > > changeset: 54694:a97e6642b12d > user: rkennke > date: Fri Feb 15 18:58:37 2019 +0100 > summary: Load reference barriers > > diff -r db2675d861c0 -r a97e6642b12d src/hotspot/share/opto/lcm.cpp > --- a/src/hotspot/share/opto/lcm.cpp Thu Feb 14 20:52:50 2019 +0100 > +++ b/src/hotspot/share/opto/lcm.cpp Fri Feb 15 18:58:37 2019 +0100 > @@ -182,9 +178,6 @@ > case Op_LoadRange: > case Op_LoadD_unaligned: > case Op_LoadL_unaligned: > - case Op_ShenandoahReadBarrier: > - assert(mach->in(2) == val, "should be address"); > - break; > case Op_StoreB: > case Op_StoreC: > case Op_StoreCM: > > Yes, quite possible it broke more implicit null checks. > > Roland. > From zgu at redhat.com Wed Mar 6 13:24:03 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Wed, 06 Mar 2019 08:24:03 -0500 Subject: Question on Shenandoah GarbageCollectorMXBeans In-Reply-To: <502DAA0F-3944-41AD-A31B-12379256F152@nitschinger.at> References: <30AA2877-69D7-45ED-AD71-C8DB09FCAF7E@nitschinger.at> <1551457507.18805.141.camel@redhat.com> <502DAA0F-3944-41AD-A31B-12379256F152@nitschinger.at> Message-ID: <1551878643.18805.189.camel@redhat.com> On Fri, 2019-03-01 at 17:26 +0100, Michael Nitschinger wrote: > No problem at all, thanks for fixing! I fixed in JDK13, should trickle down to JDK8 through backports. Thanks, -Zhengyu > > > On 01.03.2019, at 17:25, zgu at redhat.com wrote: > > > > Hi Michael, > > > > I have no idea how this message went under our radar for so long, I > > just found out this morning, sorry! > > > > I filed https://bugs.openjdk.java.net/browse/JDK-8219976, and am > > working on the fix. > > > > Thanks, > > > > -Zhengyu > > > > On Thu, 2018-11-08 at 10:54 +0100, Michael Nitschinger wrote: > > > Hi, > > > > > > I?ve been trying to get GC information through the > > > GarbageCollectorMXBean instances and it is working great so far, > > > although I have a couple of questions. I couldn?t find any > > > documentation on this topic, so sorry if it is written up > > > somewhere. > > > > > > I?m adding my NotificationListener to the MXBeans returned by the > > > ManagementFactory with shenandoah enabled and: > > > > > > when I?m looking at the ?cause? of the > > > GarbageCollectionNotificationInfo it always says ?No GC? which > > > seems > > > weird to me (both for the Pauses and the Cycles bean) - even that > > > the > > > action contains messages like ?end of major GC? or ?end of minor > > > GC". > > > In terms of ?action?, Shenandoah Pauses always seems to return > > > ?end > > > of major GC? while Shenandoah Cycles returns ?end of minor GC?, > > > but > > > is that really accurate? There seems to be only one ?shenandoah? > > > memory pool and while the Cycles info has memory usage attached > > > to > > > it, the Pauses one has no memory information whatsoever (all > > > values > > > are zeroed out). > > > > > > I?m running on 1.8.0_181-b15 that ships with fedora and the only > > > JVM > > > flag that I set was -XX:+UseShenandoahGC. > > > > > > Happy to provide more information if required, > > > Thanks, > > > Michael > > > > > From shade at redhat.com Wed Mar 6 14:04:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 15:04:53 +0100 Subject: RFR (XS) 8220228: Improve Shenandoah pacing histogram message In-Reply-To: <04e2b835-9d68-729e-6609-1fcfcd87dc94@redhat.com> References: <758bafed-fbae-2d98-b8a2-d74c3574d882@redhat.com> <04e2b835-9d68-729e-6609-1fcfcd87dc94@redhat.com> Message-ID: <19f3b55f-a53b-339a-6c75-660aec4af6a1@redhat.com> On 3/6/19 12:51 PM, Roman Kennke wrote: > I would say 'an STW pause' rather than 'the STW pause', other than that looks good. Thanks! Right. Replaced with "an STW pause". -Aleksey From rkennke at redhat.com Wed Mar 6 15:51:30 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 6 Mar 2019 16:51:30 +0100 Subject: RFR: Streamline LRB midpath Message-ID: <92cea71a-53d8-819d-7edd-b0ba8ee586f2@redhat.com> We have some issues with generated code quality in the LRB barrier midpath. Specifically, we made a mess on the return path, and we generated an explicit null-check where an implicit null-check would do. See Aleksey's findings and related discussions here: https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-March/008924.html Regarding the null-check, it turned out that I mistakenly removed some code from lcm.cpp (see webrev). This potentially affects other null-checks too. With this patch, the return path is clean and returns straight back to where it came from, and the null-check is implicit now. http://cr.openjdk.java.net/~rkennke/streamline-lrb-midpath/webrev.00/ I ran it against SPECjvm. I couldn't see a significant difference/negative impacts. It also passes all of hotspot_gc_shenandoah tests in fastdebug. Ok to push? Roman From shade at redhat.com Wed Mar 6 17:12:47 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 18:12:47 +0100 Subject: RFR [11]: Fix post-merge build problem: Shenandoah should be disabled with Zero Message-ID: <2f447464-145f-c41b-3781-7ad3e50b141e@redhat.com> Build-test shows I did a little merge mistake in sh/jdk11: I forgot to add shenandoahgc to the new block that disables Zero for all unsupported GCs. Here is the rectification: diff -r 3f6d0b57c622 make/autoconf/hotspot.m4 --- a/make/autoconf/hotspot.m4 Tue Mar 05 20:27:45 2019 +0100 +++ b/make/autoconf/hotspot.m4 Wed Mar 06 18:00:55 2019 +0100 @@ -356,11 +356,11 @@ AC_MSG_RESULT([no, platform not supported]) fi # Disable unsupported GCs for Zero if HOTSPOT_CHECK_JVM_VARIANT(zero); then - DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc zgc" + DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc shenandoahgc zgc" fi # Turn on additional features based on other parts of configure if test "x$INCLUDE_DTRACE" = "xtrue"; then JVM_FEATURES="$JVM_FEATURES dtrace" Testing: local x86_64-zero build -Aleksey From zgu at redhat.com Wed Mar 6 17:19:12 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Wed, 06 Mar 2019 12:19:12 -0500 Subject: RFR [11]: Fix post-merge build problem: Shenandoah should be disabled with Zero In-Reply-To: <2f447464-145f-c41b-3781-7ad3e50b141e@redhat.com> References: <2f447464-145f-c41b-3781-7ad3e50b141e@redhat.com> Message-ID: <1551892752.18805.196.camel@redhat.com> Looks good. -Zhengyu On Wed, 2019-03-06 at 18:12 +0100, Aleksey Shipilev wrote: > Build-test shows I did a little merge mistake in sh/jdk11: I forgot > to add shenandoahgc to the new > block that disables Zero for all unsupported GCs. > > Here is the rectification: > > diff -r 3f6d0b57c622 make/autoconf/hotspot.m4 > --- a/make/autoconf/hotspot.m4 Tue Mar 05 20:27:45 2019 +0100 > +++ b/make/autoconf/hotspot.m4 Wed Mar 06 18:00:55 2019 +0100 > @@ -356,11 +356,11 @@ > AC_MSG_RESULT([no, platform not supported]) > fi > > # Disable unsupported GCs for Zero > if HOTSPOT_CHECK_JVM_VARIANT(zero); then > - DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc > zgc" > + DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc > shenandoahgc zgc" > fi > > # Turn on additional features based on other parts of configure > if test "x$INCLUDE_DTRACE" = "xtrue"; then > JVM_FEATURES="$JVM_FEATURES dtrace" > > Testing: local x86_64-zero build > > -Aleksey > From shade at redhat.com Wed Mar 6 17:21:34 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 18:21:34 +0100 Subject: RFR: Streamline LRB midpath In-Reply-To: <92cea71a-53d8-819d-7edd-b0ba8ee586f2@redhat.com> References: <92cea71a-53d8-819d-7edd-b0ba8ee586f2@redhat.com> Message-ID: On 3/6/19 4:51 PM, Roman Kennke wrote: > We have some issues with generated code quality in the LRB barrier > midpath. Specifically, we made a mess on the return path, and we > generated an explicit null-check where an implicit null-check would do. > See Aleksey's findings and related discussions here: > > https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-March/008924.html > > Regarding the null-check, it turned out that I mistakenly removed some > code from lcm.cpp (see webrev). This potentially affects other > null-checks too. > > With this patch, the return path is clean and returns straight back to > where it came from, and the null-check is implicit now. > > http://cr.openjdk.java.net/~rkennke/streamline-lrb-midpath/webrev.00/ Yes, midpath looks much better now. Compare with: https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-March/008924.html -XX:-UseCompressedOops [Verified Entry Point] 6.53% 0x00007fda43a14530: mov %eax,-0x14000(%rsp) 5.04% 0x00007fda43a14537: push %rbp 6.81% 0x00007fda43a14538: sub $0x10,%rsp 4.55% 0x00007fda43a1453c: mov 0x10(%rsi),%rax .......................... LRB fastpath check .......................... 1.22% 0x00007fda43a14540: testb $0x1,0x20(%r15) 6.18% ? 0x00007fda43a14545: jne 0x00007fda43a1455a .........?......... LRB fastpath ends, store to %rax follows ........... 0.41% ?? ?? 0x00007fda43a14547: movl $0x2a,0x20(%rax) 11.89% ?? ?? 0x00007fda43a1454e: add $0x10,%rsp 0.50% ?? ?? 0x00007fda43a14552: pop %rbp 4.96% ?? ?? 0x00007fda43a14553: test %eax,0x17646aa7(%rip) 0.28% ?? ?? 0x00007fda43a14559: retq ---------??--??----------- LRB midpath starts -------------------------- .........??..??............ checking in-cset ........................... ?? ?? 0x00007fda43a1455a: mov %rax,%r10 ? ?? 0x00007fda43a1455d: shr $0x17,%r10 ? ?? 0x00007fda43a14561: movabs $0x7fda5308cd88,%r11 ? ?? 0x00007fda43a1456b: cmpb $0x0,(%r11,%r10,1) ? ?? 0x00007fda43a14570: je 0x00007fda43a14547 .............??.......... checking is-forwarded ........................ ? ?? 0x00007fda43a14572: mov -0x8(%rax),%rdi ? ?? 0x00007fda43a14576: cmp %rax,%rdi ???? 0x00007fda43a14579: je 0x00007fda43a14580 ???? 0x00007fda43a1457b: mov %rdi,%rax ???? 0x00007fda43a1457e: jmp 0x00007fda43a14547 ...........??.?............ slowpath call .............................. ?? ? 0x00007fda43a14580: movabs $0x7fda59985d90,%r10 ? ? 0x00007fda43a1458a: callq *%r10 ? ? 0x00007fda43a1458d: jmp 0x00007fda43a14547 ? 0x00007fda43a1458f: mov $0xfffffff6,%esi -XX:+UseCompressedOops: [Verified Entry Point] 4.07% 0x00007fbb9c470950: mov %eax,-0x14000(%rsp) 8.91% 0x00007fbb9c470957: push %rbp 2.08% 0x00007fbb9c470958: sub $0x10,%rsp 4.90% 0x00007fbb9c47095c: mov 0xc(%rsi),%r11d 4.90% 0x00007fbb9c470960: mov %r11,%r9 1.95% 0x00007fbb9c470963: shl $0x3,%r9 .......................... LRB fastpath check .......................... 2.47% 0x00007fbb9c470967: testb $0x1,0x20(%r15) 3.14% ? 0x00007fbb9c47096c: jne 0x00007fbb9c470982 .........?......... LRB fastpath ends, store to %r9 follows ........... 4.68% ?? ?? 0x00007fbb9c47096e: movl $0x2a,0xc(%r9) 7.37% ?? ?? 0x00007fbb9c470976: add $0x10,%rsp 2.06% ?? ?? 0x00007fbb9c47097a: pop %rbp 2.69% ?? ?? 0x00007fbb9c47097b: test %eax,0x198e467f(%rip) 3.73% ?? ?? 0x00007fbb9c470981: retq ---------??-??----------- LRB midpath starts -------------------------- .........??.??............ checking in-cset ........................... ?? ?? 0x00007fbb9c470982: mov %r9,%r10 ? ?? 0x00007fbb9c470985: shr $0x17,%r10 ? ?? 0x00007fbb9c470989: movabs $0x7fbbac0871c0,%r8 ? ?? 0x00007fbb9c470993: cmpb $0x0,(%r8,%r10,1) ? ?? 0x00007fbb9c470998: je 0x00007fbb9c47096e ............??.......... checking is-forwarded ........................ ??? 0x00007fbb9c47099a: mov -0x8(%r12,%r11,8),%r9 ??? 0x00007fbb9c47099f: lea (%r12,%r11,8),%r10 ??? 0x00007fbb9c4709a3: cmp %r10,%r9 ??? 0x00007fbb9c4709a6: jne 0x00007fbb9c47096e ...........?.?............ slowpath call .............................. ? ? 0x00007fbb9c4709a8: mov %r9,%rdi ? ? 0x00007fbb9c4709ab: movabs $0x7fbbb467fd90,%r10 ? ? 0x00007fbb9c4709b5: callq *%r10 ? ? 0x00007fbb9c4709b8: mov %rax,%r9 ? ? 0x00007fbb9c4709bb: jmp 0x00007fbb9c47096e Thanks, -Aleksey From shade at redhat.com Wed Mar 6 17:34:01 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 6 Mar 2019 18:34:01 +0100 Subject: RFR [11]: Fix post-merge build problem: Shenandoah should be disabled with Zero In-Reply-To: <1551892752.18805.196.camel@redhat.com> References: <2f447464-145f-c41b-3781-7ad3e50b141e@redhat.com> <1551892752.18805.196.camel@redhat.com> Message-ID: <671f862d-f068-0af5-ea5e-efc96225b48d@redhat.com> Thanks, pushed. Respinning tests... -Aleksey On 3/6/19 6:19 PM, zgu at redhat.com wrote: > Looks good. > > -Zhengyu > > On Wed, 2019-03-06 at 18:12 +0100, Aleksey Shipilev wrote: >> Build-test shows I did a little merge mistake in sh/jdk11: I forgot >> to add shenandoahgc to the new >> block that disables Zero for all unsupported GCs. >> >> Here is the rectification: >> >> diff -r 3f6d0b57c622 make/autoconf/hotspot.m4 >> --- a/make/autoconf/hotspot.m4 Tue Mar 05 20:27:45 2019 +0100 >> +++ b/make/autoconf/hotspot.m4 Wed Mar 06 18:00:55 2019 +0100 >> @@ -356,11 +356,11 @@ >> AC_MSG_RESULT([no, platform not supported]) >> fi >> >> # Disable unsupported GCs for Zero >> if HOTSPOT_CHECK_JVM_VARIANT(zero); then >> - DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc >> zgc" >> + DISABLED_JVM_FEATURES="$DISABLED_JVM_FEATURES epsilongc g1gc >> shenandoahgc zgc" >> fi >> >> # Turn on additional features based on other parts of configure >> if test "x$INCLUDE_DTRACE" = "xtrue"; then >> JVM_FEATURES="$JVM_FEATURES dtrace" >> >> Testing: local x86_64-zero build >> >> -Aleksey >> From shade at redhat.com Wed Mar 6 17:33:50 2019 From: shade at redhat.com (shade at redhat.com) Date: Wed, 06 Mar 2019 17:33:50 +0000 Subject: hg: shenandoah/jdk11: Fix post-merge build problem: Shenandoah should be disabled with Zero Message-ID: <201903061733.x26HXooc015931@aojmv0008.oracle.com> Changeset: 3e6a9b28a2fb Author: shade Date: 2019-03-06 18:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/3e6a9b28a2fb Fix post-merge build problem: Shenandoah should be disabled with Zero ! make/autoconf/hotspot.m4 From roman at kennke.org Wed Mar 6 21:00:10 2019 From: roman at kennke.org (roman at kennke.org) Date: Wed, 06 Mar 2019 21:00:10 +0000 Subject: hg: shenandoah/jdk: Streamline LRB midpath Message-ID: <201903062100.x26L0BNX024556@aojmv0008.oracle.com> Changeset: 82b898d4e103 Author: rkennke Date: 2019-03-06 21:59 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/82b898d4e103 Streamline LRB midpath ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/opto/lcm.cpp From shade at redhat.com Thu Mar 7 10:37:22 2019 From: shade at redhat.com (shade at redhat.com) Date: Thu, 07 Mar 2019 10:37:22 +0000 Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.3+1 for changeset 3e6a9b28a2fb Message-ID: <201903071037.x27AbMwf004679@aojmv0008.oracle.com> Changeset: 1a25fae48aa2 Author: shade Date: 2019-03-07 11:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1a25fae48aa2 Added tag shenandoah-jdk-11.0.3+1 for changeset 3e6a9b28a2fb ! .hgtags From shade at redhat.com Thu Mar 7 11:05:29 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 12:05:29 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+2 to sh/jdk11 Message-ID: <6c2d5138-f439-fdd9-3e64-b2a233cb4eaa@redhat.com> Another minor tag update from jdk-updates/jdk11u, now it is jdk-11.0.3+2. Merge is trivial. Summary of changes: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b2/changesets.txt Webrev: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b2/webrev/ The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+2. Testing: hotspot_gc_shenandoah {fastdebug,release} Thanks, -Aleksey From rkennke at redhat.com Thu Mar 7 13:06:30 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 7 Mar 2019 14:06:30 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+2 to sh/jdk11 In-Reply-To: <6c2d5138-f439-fdd9-3e64-b2a233cb4eaa@redhat.com> References: <6c2d5138-f439-fdd9-3e64-b2a233cb4eaa@redhat.com> Message-ID: <27ca4af1-74be-c52f-9340-ba7377511987@redhat.com> Ok. Changes look good! Thanks, Roman > Another minor tag update from jdk-updates/jdk11u, now it is jdk-11.0.3+2. Merge is trivial. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b2/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b2/webrev/ > > The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+2. > > Testing: hotspot_gc_shenandoah {fastdebug,release} > > Thanks, > -Aleksey > > > > From shade at redhat.com Thu Mar 7 13:11:37 2019 From: shade at redhat.com (shade at redhat.com) Date: Thu, 07 Mar 2019 13:11:37 +0000 Subject: hg: shenandoah/jdk11: 6 new changesets Message-ID: <201903071311.x27DBdu4022171@aojmv0008.oracle.com> Changeset: b36f77788f49 Author: rpatil Date: 2019-02-22 16:15 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b36f77788f49 8206120: Add test cases for lenient Japanese era parsing 8211398: Square character support for the Japanese new era 8218915: Change isJavaIdentifierStart and isJavaIdentifierPart to handle new code points Reviewed-by: coffeys, naoto Contributed-by: deepak.kejriwal at oracle.com ! make/data/characterdata/CharacterData00.java.template ! make/data/unicodedata/UnicodeData.txt ! src/java.base/share/classes/java/lang/Character.java ! test/jdk/java/lang/Character/Scripts.txt + test/jdk/java/lang/Character/TestIsJavaIdentifierMethods.java ! test/jdk/java/lang/Character/UnicodeData.txt ! test/jdk/java/lang/Character/charprop00.bin ! test/jdk/java/time/test/java/time/format/TestNonIsoFormatter.java + test/jdk/java/util/Calendar/JapaneseLenientEraTest.java Changeset: 44c4b7ba480d Author: aivanov Date: 2018-12-20 12:44 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/44c4b7ba480d 8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry Reviewed-by: ihse, dcubed ! src/jdk.jdwp.agent/share/native/libjdwp/transport.c Changeset: 906d0c094d0e Author: jcbeyler Date: 2018-09-04 14:17 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/906d0c094d0e 8210192: Hsperf counter ParNew::CMS should be ParNew:CMS Summary: Rename the counter back to ParNew:CMS and added a test Reviewed-by: sjohanss, tschatzl Contributed-by: manc at google.com ! src/hotspot/share/gc/cms/cmsHeap.cpp + test/hotspot/jtreg/gc/TestPolicyNamePerfCounter.java ! test/hotspot/jtreg/gc/testlibrary/PerfCounter.java Changeset: 9de3f198995c Author: goetz Date: 2019-02-28 13:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9de3f198995c 8219714: [testbug] com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java must pass classpath to subprocess Reviewed-by: dholmes, dcubed ! test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java Changeset: b81a40ed669b Author: goetz Date: 2019-03-06 08:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b81a40ed669b Added tag jdk-11.0.3+2 for changeset 9de3f198995c ! .hgtags Changeset: 44b1264b66df Author: shade Date: 2019-03-07 11:59 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/44b1264b66df Merge ! .hgtags From shade at redhat.com Thu Mar 7 19:40:50 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 20:40:50 +0100 Subject: Heads-up: CTW failure with LRB Message-ID: <710b6ea5-7e07-f212-6bc0-ed910c3c7901@redhat.com> Seems like reproduce more or less reliably: $ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/java_base_2.java TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:+UnlockDiagnosticVMOptions -XX:+ShenandoahVerifyOptoBarriers" java.lang.AssertionError: There were 1 errors:[{modules_java_base_3117: failed during compilation of class #4583 : sun/nio/cs/ISO_8859_15}] Look around for hs_err, it would mention: # Internal Error (/home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:3251), pid=26762, tid=7608 # Error: ShouldNotReachHere() Current CompileTask: C2: 258504 49993 !b 4 sun.nio.cs.ISO_8859_1$Encoder::encodeArrayLoop (369 bytes) Stack: [0x00007f5fdc76a000,0x00007f5fdc86b000], sp=0x00007f5fdc864480, free space=1001k Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x15e49cb] ShenandoahLoadReferenceBarrierNode::get_barrier_strength()+0x67b V [libjvm.so+0x15e51b3] ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)+0x213 V [libjvm.so+0x1547f47] ShenandoahBarrierSetC2::optimize_loops(PhaseIdealLoop*, LoopOptsMode, VectorSet&, Node_Stack&, Node_List&) const+0xc7 V [libjvm.so+0x1159882] PhaseIdealLoop::build_and_optimize(LoopOptsMode)+0xc02 V [libjvm.so+0x15daf23] ShenandoahBarrierC2Support::expand(Compile*, PhaseIterGVN&)+0x2b3 V [libjvm.so+0x1547e0f] ShenandoahBarrierSetC2::expand_barriers(Compile*, PhaseIterGVN&) const+0xf V [libjvm.so+0x9891bd] Compile::Optimize()+0xced V [libjvm.so+0x98a360] Compile::Compile(ciEnv*, C2Compiler*, ciMethod*, int, bool, bool, bool, DirectiveSet*)+0xe90 V [libjvm.so+0x7c04ad] C2Compiler::compile_method(ciEnv*, ciMethod*, int, DirectiveSet*)+0x10d V [libjvm.so+0x9968d5] CompileBroker::invoke_compiler_on_method(CompileTask*)+0x3f5 V [libjvm.so+0x9979f8] CompileBroker::compiler_thread_loop()+0x498 V [libjvm.so+0x17646da] JavaThread::thread_main_inner()+0x26a V [libjvm.so+0x176c3ee] JavaThread::run()+0x1ae -Aleksey From shade at redhat.com Thu Mar 7 19:59:54 2019 From: shade at redhat.com (shade at redhat.com) Date: Thu, 07 Mar 2019 19:59:54 +0000 Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.3+2 for changeset 44b1264b66df Message-ID: <201903071959.x27JxsJD019598@aojmv0008.oracle.com> Changeset: 54ed564be8cb Author: shade Date: 2019-03-07 20:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/54ed564be8cb Added tag shenandoah-jdk-11.0.3+2 for changeset 44b1264b66df ! .hgtags From rkennke at redhat.com Thu Mar 7 20:23:12 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 7 Mar 2019 21:23:12 +0100 Subject: Heads-up: CTW failure with LRB In-Reply-To: <710b6ea5-7e07-f212-6bc0-ed910c3c7901@redhat.com> References: <710b6ea5-7e07-f212-6bc0-ed910c3c7901@redhat.com> Message-ID: <6bd3e327-70bf-3579-f26f-aabed79a2cfd@redhat.com> Thanks for reporting! Last time I tried CTW it worked. *sigh* I think it should be easy to fix, and not affect correctness in release build. I'll take care of it. Roman > Seems like reproduce more or less reliably: > > $ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/java_base_2.java > TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:+UnlockDiagnosticVMOptions > -XX:+ShenandoahVerifyOptoBarriers" > > java.lang.AssertionError: There were 1 errors:[{modules_java_base_3117: failed during compilation of > class #4583 : sun/nio/cs/ISO_8859_15}] > > Look around for hs_err, it would mention: > > # Internal Error > (/home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:3251), > pid=26762, tid=7608 > # Error: ShouldNotReachHere() > > Current CompileTask: > C2: 258504 49993 !b 4 sun.nio.cs.ISO_8859_1$Encoder::encodeArrayLoop (369 bytes) > > Stack: [0x00007f5fdc76a000,0x00007f5fdc86b000], sp=0x00007f5fdc864480, free space=1001k > Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native > code) > V [libjvm.so+0x15e49cb] ShenandoahLoadReferenceBarrierNode::get_barrier_strength()+0x67b > V [libjvm.so+0x15e51b3] ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)+0x213 > V [libjvm.so+0x1547f47] ShenandoahBarrierSetC2::optimize_loops(PhaseIdealLoop*, LoopOptsMode, > VectorSet&, Node_Stack&, Node_List&) const+0xc7 > V [libjvm.so+0x1159882] PhaseIdealLoop::build_and_optimize(LoopOptsMode)+0xc02 > V [libjvm.so+0x15daf23] ShenandoahBarrierC2Support::expand(Compile*, PhaseIterGVN&)+0x2b3 > V [libjvm.so+0x1547e0f] ShenandoahBarrierSetC2::expand_barriers(Compile*, PhaseIterGVN&) const+0xf > V [libjvm.so+0x9891bd] Compile::Optimize()+0xced > V [libjvm.so+0x98a360] Compile::Compile(ciEnv*, C2Compiler*, ciMethod*, int, bool, bool, bool, > DirectiveSet*)+0xe90 > V [libjvm.so+0x7c04ad] C2Compiler::compile_method(ciEnv*, ciMethod*, int, DirectiveSet*)+0x10d > V [libjvm.so+0x9968d5] CompileBroker::invoke_compiler_on_method(CompileTask*)+0x3f5 > V [libjvm.so+0x9979f8] CompileBroker::compiler_thread_loop()+0x498 > V [libjvm.so+0x17646da] JavaThread::thread_main_inner()+0x26a > V [libjvm.so+0x176c3ee] JavaThread::run()+0x1ae > > -Aleksey > From shade at redhat.com Thu Mar 7 21:59:16 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 22:59:16 +0100 Subject: Heads-up: CTW failure with LRB In-Reply-To: <6bd3e327-70bf-3579-f26f-aabed79a2cfd@redhat.com> References: <710b6ea5-7e07-f212-6bc0-ed910c3c7901@redhat.com> <6bd3e327-70bf-3579-f26f-aabed79a2cfd@redhat.com> Message-ID: <070e061a-f04d-8fa3-6fab-3f47ea5794ea@redhat.com> On 3/7/19 9:23 PM, Roman Kennke wrote: > Thanks for reporting! Last time I tried CTW it worked. *sigh* I think it should be easy to fix, and > not affect correctness in release build. I'll take care of it. Probably this node is missing in switch: 404 EncodeISOArray === 391 364 397 402 341 [[ 405 349 840 852 ]] !jvms: ISO_8859_1$Encoder::encodeISOArray @ bci:22 ISO_8859_1$Encoder::encodeArrayLoop @ bci:172 -Aleksey From rkennke at redhat.com Thu Mar 7 22:05:02 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 7 Mar 2019 23:05:02 +0100 Subject: RFR: Use STRONG barrier for EncodeISOArray Message-ID: Missing EncodeISOArray in get_barrier_strength() leads to asserts failing in CTW test. diff -r 82b898d4e103 -r dd0d3e62843a src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Wed Mar 06 21:59:59 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Thu Mar 07 23:03:49 2019 +0100 @@ -3181,6 +3181,7 @@ case Op_EncodeP: case Op_CastP2X: case Op_SafePoint: + case Op_EncodeISOArray: strength = STRONG; break; case Op_LoadB: Makes the test pass. Ok? Roman From rkennke at redhat.com Thu Mar 7 22:05:31 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 7 Mar 2019 23:05:31 +0100 Subject: Heads-up: CTW failure with LRB In-Reply-To: <070e061a-f04d-8fa3-6fab-3f47ea5794ea@redhat.com> References: <710b6ea5-7e07-f212-6bc0-ed910c3c7901@redhat.com> <6bd3e327-70bf-3579-f26f-aabed79a2cfd@redhat.com> <070e061a-f04d-8fa3-6fab-3f47ea5794ea@redhat.com> Message-ID: <198a991a-c9d8-8010-01a6-96ec898f69b1@redhat.com> Yes. Found at the same time. Just sent an RFR. :-) Roman > On 3/7/19 9:23 PM, Roman Kennke wrote: >> Thanks for reporting! Last time I tried CTW it worked. *sigh* I think it should be easy to fix, and >> not affect correctness in release build. I'll take care of it. > > Probably this node is missing in switch: > > 404 EncodeISOArray === 391 364 397 402 341 [[ 405 349 840 852 ]] !jvms: > ISO_8859_1$Encoder::encodeISOArray @ bci:22 ISO_8859_1$Encoder::encodeArrayLoop @ bci:172 > > -Aleksey > From shade at redhat.com Thu Mar 7 22:09:07 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 23:09:07 +0100 Subject: RFR: Use STRONG barrier for EncodeISOArray In-Reply-To: References: Message-ID: <05595efa-b8f4-6a03-a8b9-c36220982850@redhat.com> On 3/7/19 11:05 PM, Roman Kennke wrote: > Missing EncodeISOArray in get_barrier_strength() leads to asserts > failing in CTW test. > > diff -r 82b898d4e103 -r dd0d3e62843a > src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp > --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Wed Mar > 06 21:59:59 2019 +0100 > +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Thu Mar > 07 23:03:49 2019 +0100 > @@ -3181,6 +3181,7 @@ > case Op_EncodeP: > case Op_CastP2X: > case Op_SafePoint: > + case Op_EncodeISOArray: > strength = STRONG; > break; > case Op_LoadB: > > Makes the test pass. Ok? Looks good. -Aleksey From roman at kennke.org Thu Mar 7 22:18:46 2019 From: roman at kennke.org (roman at kennke.org) Date: Thu, 07 Mar 2019 22:18:46 +0000 Subject: hg: shenandoah/jdk: Use STRONG barrier for EncodeISOArray Message-ID: <201903072218.x27MIkhm027023@aojmv0008.oracle.com> Changeset: dd0d3e62843a Author: rkennke Date: 2019-03-07 23:03 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dd0d3e62843a Use STRONG barrier for EncodeISOArray ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp From shade at redhat.com Fri Mar 8 17:14:43 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 8 Mar 2019 18:14:43 +0100 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize Message-ID: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> RFE: https://bugs.openjdk.java.net/browse/JDK-8220350 Fix: http://cr.openjdk.java.net/~shade/8220350/webrev.01/ This prepares Shenandoah code for accepting bugfixes in this method. Some asserts are added to verify important fields are indeed initialized. Pacer cache moved out of ShHeapRegion to resolve initialization circularity -- it does not matter anyway, because increase_live_data_gc_words is called rarely itself, being protected by the cache during mark. Testing: hotspot_gc_shenandoah Thanks, -Aleksey From shade at redhat.com Fri Mar 8 17:30:37 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 8 Mar 2019 18:30:37 +0100 Subject: RFR (S) 8220162: Shenandoah should not commit HugeTLBFS memory Message-ID: <34d621a8-c3d2-7c37-a4e9-4942c460109f@redhat.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8220162 Fix: http://cr.openjdk.java.net/~shade/8220162/webrev.02/ This is a funny bug: technically, +UseLargePages works and allocates heap in hugetlbfs, but it _also_ commits stuff in usual memory after that. Which was found by allocating large enough hugetlbfs so that double-allocation fails with OOME right away. The apparent way out is to check if we have reserved a "special" space, and skip commits then. Unfortunately, again, constructing a reliable regression test proved hard, so I had to resort to manual testing. Testing: adhoc runs with HugeTLBFS enabled, hotspot_gc_shenandoah {with and without -XX:+UseLargePages} Thanks, -Aleksey From shade at redhat.com Fri Mar 8 17:30:08 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 8 Mar 2019 18:30:08 +0100 Subject: RFR (S) 8220153: Shenandoah does not work with TransparentHugePages properly Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8220153 Fix: http://cr.openjdk.java.net/~shade/8220153/webrev.02/ There are several troubles in current code. First, we need to make sure heap is aligned to make it madvise'able by shared code during commits. Second, we have to pretouch with smaller pages when THP is enabled, because we need to tell kernel all these smaller pages can be for coalesced into a huge one. Third, when pretouching, it is apparently important to pretouch contiguous spaces separately (I haven't verified why, but it is empirically better). Unfortunately, constructing a reliable regression test proved hard, so I had to resort to manual testing. Testing: adhoc runs with THP enabled, hotspot_gc_shenandoah {with and without -XX:+UseTHP} Thanks, -Aleksey From zgu at redhat.com Fri Mar 8 18:45:12 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 8 Mar 2019 13:45:12 -0500 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> Message-ID: <47395054-8fcb-67d3-3f94-a2ead9b04af6@redhat.com> On 3/8/19 12:14 PM, Aleksey Shipilev wrote: > RFE: > https://bugs.openjdk.java.net/browse/JDK-8220350 > > Fix: > http://cr.openjdk.java.net/~shade/8220350/webrev.01/ > With large pages, there is a possibility that a single page can host multiple regions. Our region based commit/uncommit might not work in this scenario. Have you tested it? SH::initialize() still a 200 lines function, might be good to break it up, e.g. a method for each section? Otherwise, looks good. Thanks, -Zhengyu > This prepares Shenandoah code for accepting bugfixes in this method. Some asserts are added to > verify important fields are indeed initialized. Pacer cache moved out of ShHeapRegion to resolve > initialization circularity -- it does not matter anyway, because increase_live_data_gc_words is > called rarely itself, being protected by the cache during mark. > > Testing: hotspot_gc_shenandoah > > Thanks, > -Aleksey > From rkennke at redhat.com Fri Mar 8 18:57:12 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 8 Mar 2019 19:57:12 +0100 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> Message-ID: <8ad16573-b7f4-3e26-e0c4-925d666bcc1d@redhat.com> Hi Aleksey, Instead of re-formatting the constructor call here, I'd probably rather extract the arguments into local variables: - ShenandoahHeapRegion* r = new ShenandoahHeapRegion(this, - (HeapWord*) pgc_rs.base() + reg_size_words * i, - reg_size_words, + ShenandoahHeapRegion* r = new ShenandoahHeapRegion( + this, + (HeapWord*) sh_rs.base() + ShenandoahHeapRegion::region_size_words() * i, + ShenandoahHeapRegion::region_size_words(), i, - i < num_committed_regions); + i < num_committed_regions + ); Also, your webrev seems inconsistent: e.g.: http://cr.openjdk.java.net/~shade/8220350/webrev.01/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp.udiff.html vs.: http://cr.openjdk.java.net/~shade/8220350/webrev.01/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp.patch and: http://cr.openjdk.java.net/~shade/8220350/webrev.01/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp.udiff.html vs http://cr.openjdk.java.net/~shade/8220350/webrev.01/src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp.patch I am not sure I am looking at the correct stuff! :-) Roman > RFE: > https://bugs.openjdk.java.net/browse/JDK-8220350 > > Fix: > http://cr.openjdk.java.net/~shade/8220350/webrev.01/ > > This prepares Shenandoah code for accepting bugfixes in this method. Some asserts are added to > verify important fields are indeed initialized. Pacer cache moved out of ShHeapRegion to resolve > initialization circularity -- it does not matter anyway, because increase_live_data_gc_words is > called rarely itself, being protected by the cache during mark. > > Testing: hotspot_gc_shenandoah > > Thanks, > -Aleksey > From shade at redhat.com Fri Mar 8 19:05:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 8 Mar 2019 20:05:53 +0100 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: <47395054-8fcb-67d3-3f94-a2ead9b04af6@redhat.com> References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> <47395054-8fcb-67d3-3f94-a2ead9b04af6@redhat.com> Message-ID: <694cdc71-f7bd-3f8a-9833-ae23193d232c@redhat.com> On 3/8/19 7:45 PM, Zhengyu Gu wrote: > On 3/8/19 12:14 PM, Aleksey Shipilev wrote: >> Fix: >> ?? http://cr.openjdk.java.net/~shade/8220350/webrev.01/ > > With large pages, there is a possibility that a single page can host multiple regions. Our region > based commit/uncommit might not work in this scenario. Have you tested it? This is handled already by rounding up region size to page size in ShenandoahHeapRegion::setup_sizes (yes, it is awkward, but well...): // Make sure region size is at least one large page, if enabled. // Otherwise, uncommitting one region may falsely uncommit the adjacent // regions too. // Also see shenandoahArguments.cpp, where it handles UseLargePages. if (UseLargePages && ShenandoahUncommit) { region_size = MAX2(region_size, os::large_page_size()); } I think it is tested by one of our regression tests. > SH::initialize() still a 200 lines function, might be good to break it up, e.g. a method for each > section? Otherwise, looks good. Not here. I really need to push the other two bugfixes. -Aleksey From zgu at redhat.com Fri Mar 8 19:12:14 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 8 Mar 2019 14:12:14 -0500 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: <694cdc71-f7bd-3f8a-9833-ae23193d232c@redhat.com> References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> <47395054-8fcb-67d3-3f94-a2ead9b04af6@redhat.com> <694cdc71-f7bd-3f8a-9833-ae23193d232c@redhat.com> Message-ID: <7a797acc-0ab4-8de4-8a37-7663f6269244@redhat.com> On 3/8/19 2:05 PM, Aleksey Shipilev wrote: > On 3/8/19 7:45 PM, Zhengyu Gu wrote: >> On 3/8/19 12:14 PM, Aleksey Shipilev wrote: >>> Fix: >>> ?? http://cr.openjdk.java.net/~shade/8220350/webrev.01/ >> >> With large pages, there is a possibility that a single page can host multiple regions. Our region >> based commit/uncommit might not work in this scenario. Have you tested it? > > This is handled already by rounding up region size to page size in ShenandoahHeapRegion::setup_sizes > (yes, it is awkward, but well...): > > // Make sure region size is at least one large page, if enabled. > // Otherwise, uncommitting one region may falsely uncommit the adjacent > // regions too. > // Also see shenandoahArguments.cpp, where it handles UseLargePages. > if (UseLargePages && ShenandoahUncommit) { > region_size = MAX2(region_size, os::large_page_size()); > } Ah, missed this. > > I think it is tested by one of our regression tests. > >> SH::initialize() still a 200 lines function, might be good to break it up, e.g. a method for each >> section? Otherwise, looks good. Okay. Reviewed. -Zhengyu > > Not here. I really need to push the other two bugfixes. > > -Aleksey > From shade at redhat.com Fri Mar 8 19:14:03 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 8 Mar 2019 20:14:03 +0100 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: <8ad16573-b7f4-3e26-e0c4-925d666bcc1d@redhat.com> References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> <8ad16573-b7f4-3e26-e0c4-925d666bcc1d@redhat.com> Message-ID: On 3/8/19 7:57 PM, Roman Kennke wrote: > Instead of re-formatting the constructor call here, I'd probably rather extract the arguments into > local variables: > > -????? ShenandoahHeapRegion* r = new ShenandoahHeapRegion(this, > -???????????????????????????????????????????????????????? (HeapWord*) pgc_rs.base() + reg_size_words > * i, > -???????????????????????????????????????????????????????? reg_size_words, > +????? ShenandoahHeapRegion* r = new ShenandoahHeapRegion( > +????????????? this, > +????????????? (HeapWord*) sh_rs.base() + ShenandoahHeapRegion::region_size_words() * i, > +????????????? ShenandoahHeapRegion::region_size_words(), > ????????????????????????????????????????????????????????? i, > -???????????????????????????????????????????????????????? i < num_committed_regions); > +????????????? i < num_committed_regions > +????? ); Would this be better? for (size_t i = 0; i < _num_regions; i++) { HeapWord* start = (HeapWord*)sh_rs.base() + size_words * i; bool is_committed = i < num_committed_regions; ShenandoahHeapRegion* r = new ShenandoahHeapRegion(this, start, size_words, i, is_committed); > Also, your webrev seems inconsistent: Not sure what happened there. Trying again: http://cr.openjdk.java.net/~shade/8220350/webrev.02/ -Aleksey From rkennke at redhat.com Fri Mar 8 19:34:24 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 8 Mar 2019 20:34:24 +0100 Subject: RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: References: <21631ccd-1e04-41d5-826b-b7d4190ad11e@redhat.com> <8ad16573-b7f4-3e26-e0c4-925d666bcc1d@redhat.com> Message-ID: <70b450ec-8ee6-8290-981b-652c62e15940@redhat.com> >> Instead of re-formatting the constructor call here, I'd probably rather extract the arguments into >> local variables: >> >> -????? ShenandoahHeapRegion* r = new ShenandoahHeapRegion(this, >> -???????????????????????????????????????????????????????? (HeapWord*) pgc_rs.base() + reg_size_words >> * i, >> -???????????????????????????????????????????????????????? reg_size_words, >> +????? ShenandoahHeapRegion* r = new ShenandoahHeapRegion( >> +????????????? this, >> +????????????? (HeapWord*) sh_rs.base() + ShenandoahHeapRegion::region_size_words() * i, >> +????????????? ShenandoahHeapRegion::region_size_words(), >> ????????????????????????????????????????????????????????? i, >> -???????????????????????????????????????????????????????? i < num_committed_regions); >> +????????????? i < num_committed_regions >> +????? ); > > Would this be better? > > for (size_t i = 0; i < _num_regions; i++) { > HeapWord* start = (HeapWord*)sh_rs.base() + size_words * i; > bool is_committed = i < num_committed_regions; > ShenandoahHeapRegion* r = new ShenandoahHeapRegion(this, start, size_words, i, is_committed); Yes, much better. >> Also, your webrev seems inconsistent: > > Not sure what happened there. Trying again: > http://cr.openjdk.java.net/~shade/8220350/webrev.02/ Looks good! Thanks! Roman From rkennke at redhat.com Fri Mar 8 20:23:41 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 8 Mar 2019 21:23:41 +0100 Subject: RFR (S) 8220153: Shenandoah does not work with TransparentHugePages properly In-Reply-To: References: Message-ID: Ok good. Thanks! Roman > Bug: > https://bugs.openjdk.java.net/browse/JDK-8220153 > > Fix: > http://cr.openjdk.java.net/~shade/8220153/webrev.02/ > > There are several troubles in current code. First, we need to make sure heap is aligned to make it > madvise'able by shared code during commits. Second, we have to pretouch with smaller pages when THP > is enabled, because we need to tell kernel all these smaller pages can be for coalesced into a huge > one. Third, when pretouching, it is apparently important to pretouch contiguous spaces separately (I > haven't verified why, but it is empirically better). > > Unfortunately, constructing a reliable regression test proved hard, so I had to resort to manual > testing. > > Testing: adhoc runs with THP enabled, hotspot_gc_shenandoah {with and without -XX:+UseTHP} > > Thanks, > -Aleksey > From zgu at redhat.com Fri Mar 8 21:10:45 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 8 Mar 2019 16:10:45 -0500 Subject: RFR (S) 8220162: Shenandoah should not commit HugeTLBFS memory In-Reply-To: <34d621a8-c3d2-7c37-a4e9-4942c460109f@redhat.com> References: <34d621a8-c3d2-7c37-a4e9-4942c460109f@redhat.com> Message-ID: <1771d6d7-f45c-c803-f984-a28af19acbfd@redhat.com> Looks good. -Zhengyu On 3/8/19 12:30 PM, Aleksey Shipilev wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8220162 > > Fix: > http://cr.openjdk.java.net/~shade/8220162/webrev.02/ > > This is a funny bug: technically, +UseLargePages works and allocates heap in hugetlbfs, but it > _also_ commits stuff in usual memory after that. Which was found by allocating large enough > hugetlbfs so that double-allocation fails with OOME right away. The apparent way out is to check if > we have reserved a "special" space, and skip commits then. > > Unfortunately, again, constructing a reliable regression test proved hard, so I had to resort to > manual testing. > > Testing: adhoc runs with HugeTLBFS enabled, hotspot_gc_shenandoah {with and without -XX:+UseLargePages} > > Thanks, > -Aleksey > From rkennke at redhat.com Fri Mar 8 22:11:54 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 8 Mar 2019 23:11:54 +0100 Subject: RFR (S) 8220162: Shenandoah should not commit HugeTLBFS memory In-Reply-To: <34d621a8-c3d2-7c37-a4e9-4942c460109f@redhat.com> References: <34d621a8-c3d2-7c37-a4e9-4942c460109f@redhat.com> Message-ID: <9dda8df0-c979-9107-25d9-173a65419089@redhat.com> Hmm... I find the designation 'special' not very useful, but fail to come up with anything better. I guess it's ok. Reviewed. (Unless you find a better name for it.. ;-) ) Roman > Bug: > https://bugs.openjdk.java.net/browse/JDK-8220162 > > Fix: > http://cr.openjdk.java.net/~shade/8220162/webrev.02/ > > This is a funny bug: technically, +UseLargePages works and allocates heap in hugetlbfs, but it > _also_ commits stuff in usual memory after that. Which was found by allocating large enough > hugetlbfs so that double-allocation fails with OOME right away. The apparent way out is to check if > we have reserved a "special" space, and skip commits then. > > Unfortunately, again, constructing a reliable regression test proved hard, so I had to resort to > manual testing. > > Testing: adhoc runs with HugeTLBFS enabled, hotspot_gc_shenandoah {with and without -XX:+UseLargePages} > > Thanks, > -Aleksey > From rkennke at redhat.com Sun Mar 10 21:59:10 2019 From: rkennke at redhat.com (Roman Kennke) Date: Sun, 10 Mar 2019 22:59:10 +0100 Subject: RFR: Enable TLHS by default (again) In-Reply-To: References: Message-ID: >> Do we want to finally enable TLHS for good? Or do we considere too risky >> compared to (almost zero immediate) usefulness? It'd allow some more >> concurrent processing going forward. > > I think it is too risky without apparent benefit, at this point. Adding the simple regression test > with TLHS specifically enabled would be nice, though. How about now? Upstream is deprecating the flag, and working towards removal already: https://bugs.openjdk.java.net/browse/JDK-8220049 The single program that I remember having problems with is the Serial benchmark with +TLHS and +traversal, and I've just run it 30 times in a row without issues. I've also run our regression tests, all of specjvm and specjbb with no issues. I see indications that this might actually help throughput and latency, but this probably needs more testing. It doesn't look like it would regress throughput or latency though. I propose to push it to sh/jdk now, let it test+bake for a bit, then upstream it to jdk/jdk. We should probably not backport to jdk11. Not sure. WDYT? Roman From shade at redhat.com Sun Mar 10 22:02:44 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Sun, 10 Mar 2019 23:02:44 +0100 Subject: RFR: Enable TLHS by default (again) In-Reply-To: References: Message-ID: <9711df5c-2943-a0bc-e328-a08c3cab39f3@redhat.com> On 3/10/19 10:59 PM, Roman Kennke wrote: > I propose to push it to sh/jdk now, let it test+bake for a bit, then > upstream it to jdk/jdk. We should probably not backport to jdk11. Not sure. Yes, let's push it to sh/jdk, and see if it breaks anything. -Aleksey From roman at kennke.org Sun Mar 10 22:08:11 2019 From: roman at kennke.org (roman at kennke.org) Date: Sun, 10 Mar 2019 22:08:11 +0000 Subject: hg: shenandoah/jdk: Enable TLHS by default Message-ID: <201903102208.x2AM8Brq005794@aojmv0008.oracle.com> Changeset: eb54f70a13d9 Author: rkennke Date: 2019-03-10 23:07 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/eb54f70a13d9 Enable TLHS by default ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp From rkennke at redhat.com Mon Mar 11 12:09:18 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 11 Mar 2019 13:09:18 +0100 Subject: RFR: Cease support for shenandoah/jdk12 Message-ID: <39909118-1dea-befe-3ffd-7a1c25385fa0@redhat.com> We maintain Shenandoah in upstream jdk-updates/jdk12u now. Let's cease support for sh/jdk12 and make the repository read-only. http://cr.openjdk.java.net/~rkennke/cease-sh-jdk12/webrev.00/ Builds and runs just fine. Ok? Roman From shade at redhat.com Mon Mar 11 12:10:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 11 Mar 2019 13:10:53 +0100 Subject: RFR: Cease support for shenandoah/jdk12 In-Reply-To: <39909118-1dea-befe-3ffd-7a1c25385fa0@redhat.com> References: <39909118-1dea-befe-3ffd-7a1c25385fa0@redhat.com> Message-ID: On 3/11/19 1:09 PM, Roman Kennke wrote: > http://cr.openjdk.java.net/~rkennke/cease-sh-jdk12/webrev.00/ I would drop this line: log_warning(gc)("* Shenandoah GC support for this JDK release had ceased.*"); Support is there, it is just not in sh/jdk12. Otherwise looks good! -Aleksey From roman at kennke.org Mon Mar 11 12:17:41 2019 From: roman at kennke.org (roman at kennke.org) Date: Mon, 11 Mar 2019 12:17:41 +0000 Subject: hg: shenandoah/jdk12: Cease support for shenandoah/jdk12 Message-ID: <201903111217.x2BCHfPq020546@aojmv0008.oracle.com> Changeset: 4436df5d798c Author: rkennke Date: 2019-03-11 13:17 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk12/rev/4436df5d798c Cease support for shenandoah/jdk12 ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp From zgu at redhat.com Mon Mar 11 17:38:45 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Mon, 11 Mar 2019 13:38:45 -0400 Subject: RFR(S) 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots Message-ID: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> Shenandoah still uses serial version, should switch to parallel version. Bug: https://bugs.openjdk.java.net/browse/JDK-8220444 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220444/webrev.00/ Test: hotspot_gc_shenandoah (fastdebug and release) Benchmark: Compiler.compiler Baseline: http://cr.openjdk.java.net/~zgu/JDK-8220444/serial.log After Patch: http://cr.openjdk.java.net/~zgu/JDK-8220444/par.log Thanks, -Zhengyu From rkennke at redhat.com Mon Mar 11 17:44:02 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 11 Mar 2019 18:44:02 +0100 Subject: RFR(S) 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots In-Reply-To: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> References: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> Message-ID: <94db7cec-c8e1-e758-5b02-169563b74e02@redhat.com> Very nice! Does the weakprocessor only handle the jni weak oops? I seem to remember it covers more 'weak roots' too? Roman > Shenandoah still uses serial version, should switch to parallel version. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220444 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220444/webrev.00/ > > Test: > ? hotspot_gc_shenandoah (fastdebug and release) > > ? Benchmark: > ? Compiler.compiler > ? Baseline: http://cr.openjdk.java.net/~zgu/JDK-8220444/serial.log > ? After Patch: http://cr.openjdk.java.net/~zgu/JDK-8220444/par.log > > > Thanks, > > -Zhengyu From zgu at redhat.com Mon Mar 11 17:50:30 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Mon, 11 Mar 2019 13:50:30 -0400 Subject: RFR(S) 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots In-Reply-To: <94db7cec-c8e1-e758-5b02-169563b74e02@redhat.com> References: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> <94db7cec-c8e1-e758-5b02-169563b74e02@redhat.com> Message-ID: On 3/11/19 1:44 PM, Roman Kennke wrote: > Very nice! > > Does the weakprocessor only handle the jni weak oops? I seem to remember > it covers more 'weak roots' too? It covers more than jni weak oops. I intend to breakup "JNI Weak Roots" in followup RFE, if Aleksey has not objection. Thanks, -Zhengyu > > Roman > >> Shenandoah still uses serial version, should switch to parallel version. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8220444 >> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220444/webrev.00/ >> >> Test: >> ?? hotspot_gc_shenandoah (fastdebug and release) >> >> ?? Benchmark: >> ?? Compiler.compiler >> ?? Baseline: http://cr.openjdk.java.net/~zgu/JDK-8220444/serial.log >> ?? After Patch: http://cr.openjdk.java.net/~zgu/JDK-8220444/par.log >> >> >> Thanks, >> >> -Zhengyu From shade at redhat.com Mon Mar 11 17:52:19 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 11 Mar 2019 18:52:19 +0100 Subject: RFR(S) 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots In-Reply-To: References: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> <94db7cec-c8e1-e758-5b02-169563b74e02@redhat.com> Message-ID: On 3/11/19 6:50 PM, Zhengyu Gu wrote: > On 3/11/19 1:44 PM, Roman Kennke wrote: >> Does the weakprocessor only handle the jni weak oops? I seem to remember it covers more 'weak >> roots' too? > > It covers more than jni weak oops. I intend to breakup "JNI Weak Roots" in followup RFE, if Aleksey > has not objection. I have no objection! >>> Shenandoah still uses serial version, should switch to parallel version. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8220444 >>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220444/webrev.00/ Looks good. -Aleksey From rkennke at redhat.com Mon Mar 11 17:59:38 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 11 Mar 2019 18:59:38 +0100 Subject: RFR(S) 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots In-Reply-To: References: <5f1dd8b0-5ff1-0c95-7bde-2183e3ee9270@redhat.com> <94db7cec-c8e1-e758-5b02-169563b74e02@redhat.com> Message-ID: Ok good. I remember I experimented with this stuff back in October or so, and at some point it probably touches the whole 'concurrent stuff processing' which we cannot do yet. But this is a different story. Please ensure the bug has Affects: 12 if it also affects 12, so that we get backports right. (I've asked to get 11-shenandoah and 8-shenandoah version tags, as soon as we have those, we might also put 11-shenandoah in affects-field ) Reviewed. Thanks! Roman > On 3/11/19 1:44 PM, Roman Kennke wrote: >> Very nice! >> >> Does the weakprocessor only handle the jni weak oops? I seem to >> remember it covers more 'weak roots' too? > > It covers more than jni weak oops. I intend to breakup "JNI Weak Roots" > in followup RFE, if Aleksey has not objection. > > Thanks, > > -Zhengyu > >> >> Roman >> >>> Shenandoah still uses serial version, should switch to parallel version. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8220444 >>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220444/webrev.00/ >>> >>> Test: >>> ?? hotspot_gc_shenandoah (fastdebug and release) >>> >>> ?? Benchmark: >>> ?? Compiler.compiler >>> ?? Baseline: http://cr.openjdk.java.net/~zgu/JDK-8220444/serial.log >>> ?? After Patch: http://cr.openjdk.java.net/~zgu/JDK-8220444/par.log >>> >>> >>> Thanks, >>> >>> -Zhengyu From rkennke at redhat.com Mon Mar 11 20:29:18 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 11 Mar 2019 21:29:18 +0100 Subject: RFR: Bulk backports jdk12 -> sh/jdk11 Message-ID: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> This backports all relevant Shenandoah changes (I hope) from jdk-updates/jdk12u to shenandoah/jdk11. They all applied mostly clean and trivial. Builds and tests look good. List of changes: http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt Full webrev: http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/ Ok? Roman From shade at redhat.com Mon Mar 11 20:45:00 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 11 Mar 2019 21:45:00 +0100 Subject: RFR: Bulk backports jdk12 -> sh/jdk11 In-Reply-To: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> References: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> Message-ID: <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> On 3/11/19 9:29 PM, Roman Kennke wrote: > This backports all relevant Shenandoah changes (I hope) from jdk-updates/jdk12u to shenandoah/jdk11. > > They all applied mostly clean and trivial. Builds and tests look good. > > List of changes: > http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt > > Full webrev: > http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/ Looks good to me. Thanks! Hold on for a minute, though. Andrew Hughes, notice the synopsis format for the changes: [backport] $BUGID $SYNOPSIS This is almost the same as we did over the years for Shenandoah-specific backports, but now it also mentions $BUGID, because Shenandoah is finally upstream. We would like to separate backports that are coming to our downstream version of Shenandoah versus the upstream changes (especially those coming via 11u updates), therefore Shenandoah-specific backports done by Shenandoah devs start with "[backport]". This would also avoid these backports to be accidentally matched by jcheck and/or hgupdater. Does it make sense to you? -Aleksey From rkennke at redhat.com Mon Mar 11 21:59:07 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 11 Mar 2019 22:59:07 +0100 Subject: RFR: Bulk backports jdk12 -> sh/jdk11 In-Reply-To: <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> References: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> Message-ID: Including Andrew H... > On 3/11/19 9:29 PM, Roman Kennke wrote: >> This backports all relevant Shenandoah changes (I hope) from jdk-updates/jdk12u to shenandoah/jdk11. >> >> They all applied mostly clean and trivial. Builds and tests look good. >> >> List of changes: >> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt >> >> Full webrev: >> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/ > > Looks good to me. Thanks! > > Hold on for a minute, though. > > Andrew Hughes, notice the synopsis format for the changes: > [backport] $BUGID $SYNOPSIS > > This is almost the same as we did over the years for Shenandoah-specific backports, but now it also > mentions $BUGID, because Shenandoah is finally upstream. We would like to separate backports that > are coming to our downstream version of Shenandoah versus the upstream changes (especially those > coming via 11u updates), therefore Shenandoah-specific backports done by Shenandoah devs start with > "[backport]". This would also avoid these backports to be accidentally matched by jcheck and/or > hgupdater. > > Does it make sense to you? > > -Aleksey > From gnu.andrew at redhat.com Tue Mar 12 04:32:06 2019 From: gnu.andrew at redhat.com (Andrew John Hughes) Date: Tue, 12 Mar 2019 04:32:06 +0000 Subject: RFR: Bulk backports jdk12 -> sh/jdk11 In-Reply-To: <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> References: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> Message-ID: <37cef6f8-4cab-1728-05c0-a161eb16c7c4@redhat.com> On 11/03/2019 20:45, Aleksey Shipilev wrote: > On 3/11/19 9:29 PM, Roman Kennke wrote: >> This backports all relevant Shenandoah changes (I hope) from jdk-updates/jdk12u to shenandoah/jdk11. >> >> They all applied mostly clean and trivial. Builds and tests look good. >> >> List of changes: >> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt >> >> Full webrev: >> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/ > > Looks good to me. Thanks! > > Hold on for a minute, though. > > Andrew Hughes, notice the synopsis format for the changes: > [backport] $BUGID $SYNOPSIS > > This is almost the same as we did over the years for Shenandoah-specific backports, but now it also > mentions $BUGID, because Shenandoah is finally upstream. We would like to separate backports that > are coming to our downstream version of Shenandoah versus the upstream changes (especially those > coming via 11u updates), therefore Shenandoah-specific backports done by Shenandoah devs start with > "[backport]". This would also avoid these backports to be accidentally matched by jcheck and/or > hgupdater. > > Does it make sense to you? > > -Aleksey > That makes sense to me. My concern is that this is *only* bugs that don't make sense for upstream 8u or 11u. Anything that can be applied upstream should be and then integrated into the Shenandoah repositories with a merge. Now we're handling the tagging/release process there, I don't expect that to have as many delays as in the past. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew From rkennke at redhat.com Tue Mar 12 07:04:55 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 12 Mar 2019 08:04:55 +0100 Subject: RFR: Bulk backports jdk12 -> sh/jdk11 In-Reply-To: <37cef6f8-4cab-1728-05c0-a161eb16c7c4@redhat.com> References: <73f0814c-21ab-872e-1a73-25d5be1a94f6@redhat.com> <568ae842-5021-b4d1-388e-aa2d7989d21b@redhat.com> <37cef6f8-4cab-1728-05c0-a161eb16c7c4@redhat.com> Message-ID: <9F620380-407D-441B-BB59-5526AF828948@redhat.com> Am 12. M?rz 2019 05:32:06 MEZ schrieb Andrew John Hughes : >On 11/03/2019 20:45, Aleksey Shipilev wrote: >> On 3/11/19 9:29 PM, Roman Kennke wrote: >>> This backports all relevant Shenandoah changes (I hope) from >jdk-updates/jdk12u to shenandoah/jdk11. >>> >>> They all applied mostly clean and trivial. Builds and tests look >good. >>> >>> List of changes: >>> >http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt >>> >>> Full webrev: >>> >http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/ >> >> Looks good to me. Thanks! >> >> Hold on for a minute, though. >> >> Andrew Hughes, notice the synopsis format for the changes: >> [backport] $BUGID $SYNOPSIS >> >> This is almost the same as we did over the years for >Shenandoah-specific backports, but now it also >> mentions $BUGID, because Shenandoah is finally upstream. We would >like to separate backports that >> are coming to our downstream version of Shenandoah versus the >upstream changes (especially those >> coming via 11u updates), therefore Shenandoah-specific backports done >by Shenandoah devs start with >> "[backport]". This would also avoid these backports to be >accidentally matched by jcheck and/or >> hgupdater. >> >> Does it make sense to you? >> >> -Aleksey >> > >That makes sense to me. > >My concern is that this is *only* bugs that don't make sense for >upstream 8u or 11u. Anything that can be applied upstream should be and >then integrated into the Shenandoah repositories with a merge. Now >we're >handling the tagging/release process there, I don't expect that to have >as many delays as in the past. Yes, that is the plan. Only Shenandoah backports would come this way because there is no Shenandoah in 8 or 11. Thanks, Roman -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From roman at kennke.org Tue Mar 12 10:40:30 2019 From: roman at kennke.org (roman at kennke.org) Date: Tue, 12 Mar 2019 10:40:30 +0000 Subject: hg: shenandoah/jdk11: 15 new changesets Message-ID: <201903121040.x2CAeVD5011277@aojmv0008.oracle.com> Changeset: 896c8d478d57 Author: roland Date: 2019-01-14 13:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/896c8d478d57 [backport] 8217043: Shenandoah: SIGSEGV in Type::meet_helper() at barrier expansion time Reviewed-by: shade, rkennke, thartmann ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Changeset: 1bce79e69590 Author: roland Date: 2019-01-11 14:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1bce79e69590 [backport] 8217042: Shenandoah: write barrier on backedge of strip mined loop causes c2 crash at expansion time Reviewed-by: rkennke, thartmann ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Changeset: 30db5820aa0a Author: shade Date: 2019-01-22 21:18 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/30db5820aa0a [backport] 8217467: Access barriers are missing in C2 intrinsic for Base64 Reviewed-by: thartmann, roland, rkennke, kvn ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: 49406f4fde5d Author: shade Date: 2019-01-28 10:24 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/49406f4fde5d [backport] 8217854: [TESTBUG] runtime/CompressedOops/UseCompressedOops.java fails with Shenandoah Reviewed-by: dcubed, zgu ! test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java Changeset: a0a16d58de0d Author: zgu Date: 2019-01-17 08:48 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/a0a16d58de0d [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file Reviewed-by: shade, tschatzl ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.cpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Changeset: e11d78ca213c Author: vlivanov Date: 2019-01-18 17:34 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e11d78ca213c [backport] 8217400: Optimized build is broken by Shenandoah changes Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp Changeset: db8dda47cb74 Author: rkennke Date: 2019-01-14 12:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/db8dda47cb74 [backport] 8216973: Kick up cleanup phases in the right places Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: c90a9999db3c Author: zgu Date: 2019-01-18 09:10 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c90a9999db3c [backport] 8217319: Cleanup Shenandoah includes Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMetrics.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp ! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Changeset: 9dad0571ec8d Author: shade Date: 2019-01-19 11:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9dad0571ec8d [backport] 8217343: Shenandoah control thread should be able to run at critical priority Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp + test/hotspot/jtreg/gc/shenandoah/options/TestCriticalControlThreadPriority.java Changeset: 12a61f3cf42a Author: zgu Date: 2019-01-20 12:20 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/12a61f3cf42a [backport] 8217342: Build failed with excluding JFR Reviewed-by: shade, pliden ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp ! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.hpp + src/hotspot/share/gc/shenandoah/shenandoahStringDedup.inline.hpp Changeset: 32de76f5afa4 Author: shade Date: 2019-02-21 15:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/32de76f5afa4 [backport] 8219524: Shenandoah misreports "committed" size in MemoryMXBean Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMemoryPool.cpp ! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java Changeset: 5d1cb06b8a6c Author: zgu Date: 2019-02-28 08:44 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/5d1cb06b8a6c [backport] 8219857: Shenandoah GC may initialize thread's gclab twice Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp Changeset: 4202904619b3 Author: zgu Date: 2019-03-02 08:33 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/4202904619b3 [backport] 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp Changeset: ce5dd140e23e Author: zgu Date: 2019-03-05 12:30 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/ce5dd140e23e [backport] 8220161: Shenandoah does not need to initialize PLABs for safepoint workers Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 325b69757111 Author: shade Date: 2019-03-07 10:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/325b69757111 [backport] 8220228: Improve Shenandoah pacing histogram message Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp From rkennke at redhat.com Tue Mar 12 13:21:26 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 12 Mar 2019 14:21:26 +0100 Subject: RFR: Merge upstream to tag jdk-13+11 Message-ID: <8bfb0335-008f-2900-e387-d770a9efd7e8@redhat.com> List of changes: http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-12/changes.txt Testing: hotspot_gc_shenandoah ok Ok? Roman From shade at redhat.com Tue Mar 12 13:23:02 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 12 Mar 2019 14:23:02 +0100 Subject: RFR: Merge upstream to tag jdk-13+11 In-Reply-To: <8bfb0335-008f-2900-e387-d770a9efd7e8@redhat.com> References: <8bfb0335-008f-2900-e387-d770a9efd7e8@redhat.com> Message-ID: <6db42df8-6761-d8c0-5a0e-8274b2e3886d@redhat.com> On 3/12/19 2:21 PM, Roman Kennke wrote: > List of changes: > http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-12/changes.txt > > Testing: hotspot_gc_shenandoah ok > > Ok? OK! -Aleksey From roman at kennke.org Tue Mar 12 13:52:05 2019 From: roman at kennke.org (roman at kennke.org) Date: Tue, 12 Mar 2019 13:52:05 +0000 Subject: hg: shenandoah/jdk: 152 new changesets Message-ID: <201903121352.x2CDqHAJ012599@aojmv0008.oracle.com> Changeset: 748932cafa41 Author: hseigel Date: 2019-02-20 16:20 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/748932cafa41 8218995: Deprecate the -XX:FailOverToOldVerifier option Summary: Deprecate the option and change affected tests so that they no longer need the option. Reviewed-by: dholmes, lfoltan ! src/hotspot/share/runtime/arguments.cpp Changeset: 6c13f5a67766 Author: jwilhelm Date: 2019-02-21 01:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6c13f5a67766 Added tag jdk-13+9 for changeset c081f3ea6b93 ! .hgtags Changeset: d001808c57e8 Author: jjg Date: 2019-02-20 16:15 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d001808c57e8 8218998: Add metadata to generated API documentation files Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java + test/langtools/jdk/javadoc/doclet/testMetadata/TestMetadata.java Changeset: 81a9748bc86c Author: dholmes Date: 2019-02-20 19:41 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/81a9748bc86c 8217765: Internal Error (javaCalls.cpp:61) guarantee(thread->can_call_java()) failed Reviewed-by: rehn, redestad, coleenp ! src/hotspot/share/oops/instanceKlass.cpp Changeset: c925e36a8e6d Author: xuelei Date: 2019-02-20 18:46 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c925e36a8e6d 8168069: X509TrustManagerImpl causes ClassLoader leaks with unparseable extensions Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java ! src/java.base/share/classes/sun/security/x509/CertificateExtensions.java ! test/jdk/sun/security/ssl/SSLContextImpl/BadKSProvider.java ! test/jdk/sun/security/ssl/SSLContextImpl/BadTSProvider.java Changeset: 880baf6db17b Author: pmuthuswamy Date: 2019-02-21 11:26 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/880baf6db17b 8213354: Support package-specific stylesheets Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/DocFilesHandler.java + test/langtools/jdk/javadoc/doclet/testPackageSpecificStylesheet/TestPackageSpecificStylesheet.java Changeset: 87ef165e7bcd Author: mbaesken Date: 2019-02-20 17:29 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/87ef165e7bcd 8219460: ppc: adjust NativeGeneralJump::insert_unconditional to stack allocated MacroAssembler Reviewed-by: mdoerr ! src/hotspot/cpu/ppc/nativeInst_ppc.cpp Changeset: 1bd7233074c1 Author: rkennke Date: 2019-02-21 09:48 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1bd7233074c1 8219486: Missing reg_mask_init() breaks x86_32 build Reviewed-by: vlivanov, dlong ! src/hotspot/cpu/x86/c2_init_x86.cpp Changeset: 34906de6c017 Author: gadams Date: 2019-02-21 05:06 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/34906de6c017 8219388: Misleading log message "issuspended002a debuggee launched" Reviewed-by: cjplummer, phh ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/newInstance/newinstance001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/newInstance/newinstance002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/setValue/setvalue001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/setValue/setvalue002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/setValue/setvalue003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/setValue/setvalue004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/setValue/setvalue005.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/LocalVariable/isVisible/isvisible001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Locatable/location/location001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Locatable/location/location004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Locatable/location/location005.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/codeIndex/codeindex001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/declaringType/declaringtype001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/equals/equals001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/hashCode/hashcode001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/lineNumber/linenumber001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/lineNumber_s/linenumber_s001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/sourceName/sourcename001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/sourceName_s/sourcename_s001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/sourcePath/sourcepath001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Location/sourcePath_s/sourcepath_s001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/allLineLocations/alllinelocations001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/allLineLocations/alllinelocations002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/allLineLocations_ss/alllinelocations_ss001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/locationOfCodeIndex/locationofcodeindex001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/locationsOfLine/locationsofline001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Method/locationsOfLine_ssi/locationsofline_ssi001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Mirror/toString/tostring001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Mirror/virtualMachine/virtualmachine001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/disableCollection/disablecollection001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/entryCount/entrycount001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/equals/equals001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValue/getvalue001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValue/getvalue002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValue/getvalue003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValue/getvalue004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValues/getvalues001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValues/getvalues002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/getValues/getvalues003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/hashCode/hashcode001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/invokeMethod/invokemethod001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/isCollected/iscollected001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/owningThread/owningthread001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype005.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype006.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referenceType/referencetype007.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/setValue/setvalue001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/uniqueID/uniqueid001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/PathSearchingVirtualMachine/baseDirectory/directory001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/PathSearchingVirtualMachine/bootClassPath/bootpath001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/PrimitiveValue/doubleValue/doublevalue002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allLineLocations/alllinelocations001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allLineLocations_ss/alllinelocations_ss001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/availableStrata/availablestrata001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/defaultStratum/defaultstratum001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/locationsOfLine_i/locationsofline_i001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/locationsOfLine_ssi/locationsofline_ssi001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/sourceNames/sourcenames001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/sourcePaths/sourcepaths001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/location/location001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/setValue/setvalue003/setvalue003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/thisObject/thisobject001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/thisObject/thisobject002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/thread/thread001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/visibleVariableByName/visiblevarbyname001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/visibleVariableByName/visiblevarbyname002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/visibleVariables/visiblevariables001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/visibleVariables/visiblevariables002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/name/name001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/parent/parent001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/resume/resume001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/suspend/suspend001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/threadGroups/threadgroups001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/threads/threads001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/currentContendedMonitor/currentcm001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frame/frame001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frameCount/framecount001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frames/frames001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frames_ii/frames_ii001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frames_ii/frames_ii002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/isAtBreakpoint/isatbreakpoint001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/name/name001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/resume/resume001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspend/suspend001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspendCount/suspendcount001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/threadGroup/threadgroup001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Value/_itself_/value001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Value/type/type002/type002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetBytecodes/cangetbytecodes001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetCurrentContendedMonitor/cangccm001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetMonitorInfo/cangetmonitorinfo001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetOwnedMonitorInfo/cangetinfo001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetSourceDebugExtension/cangetsde001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/canGetSyntheticAttribute/cangetattr001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/description/description001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose005.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/eventQueue/eventqueue001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/eventRequestManager/eventrmanager001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/exit/exit001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/exit/exit002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/getDefaultStratum/getdefaultstratum001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/name/name001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/process/process001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/setDefaultStratum/setdefaultstratum001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/topLevelThreadGroups/toplevelgroups001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/version/version001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachineManager/connectedVirtualMachines/convm001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachineManager/connectedVirtualMachines/convm002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachineManager/connectedVirtualMachines/convm003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VoidValue/equals/equals001/equals001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VoidValue/hashCode/hashcode001/hashcode001.java Changeset: 92263386a883 Author: ysuenaga Date: 2019-02-21 21:02 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/92263386a883 8219414: SA: jhsdb jsnap throws UnmappedAddressException with core generated by gcore Reviewed-by: cjplummer, jgeorge ! src/hotspot/os/linux/globals_linux.hpp ! src/hotspot/os/linux/os_linux.cpp Changeset: 0276cba45aac Author: jwilhelm Date: 2019-02-21 01:04 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0276cba45aac Added tag jdk-12+33 for changeset b67884871b5f ! .hgtags Changeset: cc9359f8c563 Author: jwilhelm Date: 2019-02-21 14:16 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/cc9359f8c563 Merge ! .hgtags Changeset: 5cf6623b1283 Author: shade Date: 2019-02-21 15:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5cf6623b1283 8219524: Shenandoah misreports "committed" size in MemoryMXBean Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMemoryPool.cpp ! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java Changeset: b2fb6f782d84 Author: coleenp Date: 2019-02-21 09:21 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b2fb6f782d84 8153413: Exceptions::_throw always logs exceptions, penalizing performance Summary: construct exception string into Event message directly add if (log_is_enabled) for logging. Reviewed-by: ysuenaga, dholmes ! src/hotspot/share/utilities/events.cpp ! src/hotspot/share/utilities/events.hpp ! src/hotspot/share/utilities/exceptions.cpp Changeset: 7a6fb8a48434 Author: roland Date: 2019-02-18 17:41 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7a6fb8a48434 8219335: "failed: unexpected type" assert failure in ConnectionGraph::split_unique_types() with unsafe accesses Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/escape.cpp + test/hotspot/jtreg/compiler/unsafe/MaybeOffHeapUnsafeAccessToNewObject.java Changeset: 8bc3d3eeaa53 Author: dfuchs Date: 2019-02-21 16:57 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8bc3d3eeaa53 8216363: NullPointerException in java.util.logging.Handler#isLoggable Summary: The implementation is changed to match the spec: isLoggable(null) returns false. Reviewed-by: mchung, lancea ! src/java.logging/share/classes/java/util/logging/Handler.java ! src/java.logging/share/classes/java/util/logging/MemoryHandler.java ! src/java.logging/share/classes/java/util/logging/StreamHandler.java + test/jdk/java/util/logging/IsLoggableHandlerTest.java Changeset: dfea18758dfa Author: naoto Date: 2019-02-21 10:26 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dfea18758dfa 8218960: CONFIG level logging statements printed in CLDRCalendarDataProviderImpl.java even when default log Level is INFO Reviewed-by: nishjain, rriggs ! src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java ! src/java.base/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/java.base/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java + test/jdk/sun/util/locale/provider/CheckLoggingFromLocaleProvider.java Changeset: 4584d0331318 Author: darcy Date: 2019-02-21 10:29 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4584d0331318 8219254: Update explicit uses of latest source/target in langtools tests to a property 8219256: Update javac diags tests to use properties Reviewed-by: jjg, jlahoda, darcy, iignatyev Contributed-by: joe.darcy at oracle.com, jonathan.gibbons at oracle.com ! test/langtools/TEST.ROOT ! test/langtools/tools/javac/6330997/T6330997.java ! test/langtools/tools/javac/ConditionalWithVoid.java ! test/langtools/tools/javac/diags/Example.java ! test/langtools/tools/javac/diags/examples/BreakAmbiguousTarget.java ! test/langtools/tools/javac/diags/examples/BreakExprNotImmediate.java ! test/langtools/tools/javac/diags/examples/BreakMissingValue.java ! test/langtools/tools/javac/diags/examples/BreakOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/ContinueOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/IncompatibleTypesInSwitchExpression.java ! test/langtools/tools/javac/diags/examples/MultipleCaseLabels.java ! test/langtools/tools/javac/diags/examples/NotExhaustive.java ! test/langtools/tools/javac/diags/examples/PreviewFeatureUse.java ! test/langtools/tools/javac/diags/examples/PreviewFilename.java ! test/langtools/tools/javac/diags/examples/PreviewFilenameAdditional.java ! test/langtools/tools/javac/diags/examples/PreviewPlural/PreviewPlural.java ! test/langtools/tools/javac/diags/examples/ReturnOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/RuleCompletesNormally.java ! test/langtools/tools/javac/diags/examples/SwitchCaseUnexpectedStatement.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionCompletesNormally.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionEmpty.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionTargetCantBeVoid.java ! test/langtools/tools/javac/diags/examples/SwitchExpressions.java ! test/langtools/tools/javac/diags/examples/SwitchMixingCaseTypes.java ! test/langtools/tools/javac/diags/examples/SwitchRules.java ! test/langtools/tools/javac/expswitch/ExpSwitchNestingTest.java ! test/langtools/tools/javac/lambda/BadSwitchExpressionLambda.java ! test/langtools/tools/javac/parser/JavacParserTest.java ! test/langtools/tools/javac/preview/classReaderTest/Client.java ! test/langtools/tools/javac/switchexpr/BlockExpression.java ! test/langtools/tools/javac/switchexpr/BooleanNumericNonNumeric.java ! test/langtools/tools/javac/switchexpr/BreakTest.java ! test/langtools/tools/javac/switchexpr/CRT.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment2.java ! test/langtools/tools/javac/switchexpr/EmptySwitch.java ! test/langtools/tools/javac/switchexpr/ExhaustiveEnumSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks1.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks2.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBugs.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBugsInGen.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchCodeFromJLS.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchDA.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchEmbedding.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough1.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFlow.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInExpressionSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchIntersectionTypes.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchNotExhaustive.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchUnreachable.java ! test/langtools/tools/javac/switchexpr/ParseIncomplete.java ! test/langtools/tools/javac/switchexpr/ParserRecovery.java ! test/langtools/tools/javac/switchexpr/SwitchExpressionIsNotAConstant.java ! test/langtools/tools/javac/switchexpr/SwitchExpressionScopesIsolated.java ! test/langtools/tools/javac/switchexpr/SwitchExpressionSimpleVisitorTest.java ! test/langtools/tools/javac/switchexpr/TryCatch.java ! test/langtools/tools/javac/switchextra/CaseTest.java ! test/langtools/tools/javac/switchextra/MultipleLabelsExpression.java ! test/langtools/tools/javac/switchextra/MultipleLabelsStatement.java ! test/langtools/tools/javac/switchextra/RuleParsingTest.java ! test/langtools/tools/javac/switchextra/SwitchArrowBrokenConstant.java ! test/langtools/tools/javac/switchextra/SwitchStatementArrow.java ! test/langtools/tools/javac/switchextra/SwitchStatementBroken.java ! test/langtools/tools/javac/switchextra/SwitchStatementBroken2.java ! test/langtools/tools/javac/switchextra/SwitchStatementScopesIsolated.java Changeset: e7cb0348fa1c Author: jjg Date: 2019-02-21 14:03 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e7cb0348fa1c 8215307: Pages do not have

Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java ! test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testHref/TestHref.java ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java ! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java ! test/langtools/jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java ! test/langtools/jdk/javadoc/doclet/testSummaryHeading/TestSummaryHeading.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java Changeset: 3f1e9372557f Author: jjg Date: 2019-02-21 15:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3f1e9372557f 8219497: Unused parameter in HtmlDocletWriter::printHtmlDocument Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java Changeset: db24a4cb8139 Author: jjg Date: 2019-02-21 15:17 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/db24a4cb8139 8216170: java.lang.IllegalArgumentException: directories not supported Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocTool.java + test/langtools/jdk/javadoc/doclet/testJavaPackage/TestJavaPackage.java Changeset: ca682d9d8db5 Author: mikael Date: 2019-02-21 16:56 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ca682d9d8db5 8214777: Avoid some GCC 8.X strncpy() errors in HotSpot Reviewed-by: kbarrett, rehn ! src/hotspot/os/aix/os_perf_aix.cpp ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/solaris/os_perf_solaris.cpp ! src/hotspot/os/windows/os_perf_windows.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classLoaderExt.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/services/diagnosticArgument.cpp ! src/hotspot/share/utilities/xmlstream.cpp Changeset: f41793b5b83f Author: jjg Date: 2019-02-21 17:50 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f41793b5b83f 8219558: jdk/javadoc tests fail with missing headings: h1 Reviewed-by: darcy ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java ! test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testHref/TestHref.java ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java ! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java ! test/langtools/jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java ! test/langtools/jdk/javadoc/doclet/testSummaryHeading/TestSummaryHeading.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java - test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java Changeset: 1a7b57d02107 Author: iklam Date: 2019-02-21 17:07 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1a7b57d02107 8218751: Do not store original classfiles inside the CDS archive Summary: remove the OD shared region and decode classfiles on the fly Reviewed-by: jiangli, ccheung, sspitsyn, redestad ! src/hotspot/share/classfile/classLoader.hpp ! src/hotspot/share/classfile/klassFactory.cpp ! src/hotspot/share/classfile/klassFactory.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/filemap.hpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/memory/metaspaceShared.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! test/hotspot/jtreg/runtime/SharedArchiveFile/SpaceUtilizationCheck.java Changeset: e03bbe023e50 Author: pmuthuswamy Date: 2019-02-22 11:10 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e03bbe023e50 8215584: Remove support for the "old" doclet API in com/sun/javadoc Reviewed-by: jjg, hannesw - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/package-info.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties ! src/jdk.javadoc/share/classes/module-info.java ! test/langtools/jdk/javadoc/tool/EncodingTest.java ! test/langtools/jdk/javadoc/tool/EnsureNewOldDoclet.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java + test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm + test/langtools/jdk/javadoc/tool/removeOldDoclet/RemoveOldDoclet.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java Changeset: e94ed0236046 Author: redestad Date: 2019-02-22 09:23 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e94ed0236046 8219247: Enable inlining of newly introduced PlatformMonitor methods Reviewed-by: dholmes, rehn ! src/hotspot/os/aix/os_aix.inline.hpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/bsd/os_bsd.inline.hpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.inline.hpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os/windows/os_windows.inline.hpp Changeset: 2e1896987ed8 Author: stefank Date: 2019-02-19 13:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2e1896987ed8 8219462: ZGC: Use wait/notify in ZNMethodTable Reviewed-by: pliden ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: a858ad440eb9 Author: stefank Date: 2019-02-20 10:46 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a858ad440eb9 8219463: ZGC: Remove redundant ZNMethodTable::_iter_lock Reviewed-by: pliden ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: 6a84ea153af0 Author: stefank Date: 2019-02-21 13:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6a84ea153af0 8219573: Add NMethodClosure Reviewed-by: pliden, eosterlund ! src/hotspot/share/memory/iterator.hpp Changeset: 70a6a7b15d36 Author: stefank Date: 2019-02-20 10:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/70a6a7b15d36 8219464: ZGC: Move nmethod oop properties from ZNMethodTableEntry to ZNMethodData Reviewed-by: pliden ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp ! src/hotspot/share/gc/z/zNMethodTableEntry.hpp ! src/hotspot/share/gc/z/zRootsIterator.cpp Changeset: 29273bb37241 Author: stefank Date: 2019-02-20 11:39 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/29273bb37241 8219466: ZGC: Extract allocation functionality into a new ZNMethodAllocator class Reviewed-by: pliden + src/hotspot/share/gc/z/zNMethodAllocator.cpp + src/hotspot/share/gc/z/zNMethodAllocator.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: 33790c8e4647 Author: stefank Date: 2019-02-20 11:42 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/33790c8e4647 8219467: ZGC: Move ZNMethodData to its own file Reviewed-by: pliden + src/hotspot/share/gc/z/zNMethodData.cpp + src/hotspot/share/gc/z/zNMethodData.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp Changeset: ad56513c7e07 Author: stefank Date: 2019-02-20 12:04 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ad56513c7e07 8219468: ZGC: Extract iteration functionality into a new ZNMethodTableIteration class Reviewed-by: pliden ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp + src/hotspot/share/gc/z/zNMethodTableIteration.cpp + src/hotspot/share/gc/z/zNMethodTableIteration.hpp Changeset: bf1133e7dfba Author: stefank Date: 2019-02-21 14:24 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/bf1133e7dfba 8219469: ZGC: Extract functions out from ZNMethodTable into new ZNMethod class Reviewed-by: pliden ! src/hotspot/share/gc/z/zBarrierSetNMethod.cpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp + src/hotspot/share/gc/z/zNMethod.cpp + src/hotspot/share/gc/z/zNMethod.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp ! src/hotspot/share/gc/z/zRootsIterator.cpp ! src/hotspot/share/gc/z/zUnload.cpp Changeset: b22d8ae270a2 Author: rehn Date: 2019-02-22 14:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b22d8ae270a2 8219436: Safepoint logs correction and misc Reviewed-by: mdoerr, coleenp ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp ! src/hotspot/share/runtime/vmOperations.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vmThread.hpp ! src/hotspot/share/services/runtimeService.cpp ! src/hotspot/share/services/runtimeService.hpp ! src/jdk.jfr/share/conf/jfr/default.jfc ! src/jdk.jfr/share/conf/jfr/profile.jfc ! test/hotspot/jtreg/runtime/logging/SafepointTest.java ! test/jdk/jdk/jfr/event/runtime/TestSafepointEvents.java ! test/lib/jdk/test/lib/jfr/EventNames.java Changeset: b47fd614c75e Author: pmuthuswamy Date: 2019-02-22 19:58 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b47fd614c75e 8219575: jdk/javadoc/tool/removeOldDoclet/RemoveOldDoclet test fails in mach5 Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java Changeset: 0abec72a3ac2 Author: bulasevich Date: 2019-02-22 17:30 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0abec72a3ac2 8217647: JFR: recordings on 32-bit systems unreadable Reviewed-by: egahlin Contributed-by: boris.ulasevich at bell-sw.com, markus.gronlund at oracle.com ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.cpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetWriter.hpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkRotation.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkRotation.hpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkState.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkState.hpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.hpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.hpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp ! src/hotspot/share/jfr/writers/jfrEventWriterHost.inline.hpp ! src/hotspot/share/jfr/writers/jfrPosition.hpp ! src/hotspot/share/jfr/writers/jfrPosition.inline.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.hpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp ! src/hotspot/share/jfr/writers/jfrWriterHost.hpp ! src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp Changeset: 853b82a25d53 Author: redestad Date: 2019-02-22 16:41 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/853b82a25d53 8219554: Redundant lookup_common in SymbolTable::add Reviewed-by: iklam, coleenp, mikael ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/symbolTable.hpp Changeset: bae1944fc279 Author: shade Date: 2019-02-22 17:54 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/bae1944fc279 8219574: Minimal VM build failure after JDK-8219414 Reviewed-by: jgeorge, dholmes, cjplummer ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/classfile/classLoader.cpp Changeset: 4008a1d5cfbc Author: iignatyev Date: 2019-02-22 09:47 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4008a1d5cfbc 8219417: bump jtreg requiredVersion to b14 Reviewed-by: alanb, dholmes ! test/hotspot/jtreg/TEST.ROOT ! test/jaxp/TEST.ROOT ! test/jdk/TEST.ROOT ! test/nashorn/TEST.ROOT Changeset: 0448cb38c418 Author: bpb Date: 2019-02-22 10:13 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0448cb38c418 8011135: (bf) CharBuffer.put(String) is slow because of String.charAt() call for each char Reviewed-by: alanb, redestad ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template + test/micro/org/openjdk/bench/java/nio/CharBuffers.java Changeset: 7a6fd71449e7 Author: bpb Date: 2019-02-22 10:13 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7a6fd71449e7 8048192: (bf) Out of direct buffer memory message should include the limits Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Bits.java Changeset: 68bbd727dd5f Author: iignatyev Date: 2019-02-22 11:07 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/68bbd727dd5f 8219158: use 'test.root' property instead of traversing test-src path Reviewed-by: dholmes ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/GenClassesBuilder.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/stress/classload/GenClassesBuilder.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/share/StratumClassesBuilder.java ! test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/shared/BuildJar.java ! test/lib/jdk/test/lib/Utils.java Changeset: 9c3fe09f69bc Author: coleenp Date: 2019-02-22 13:56 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9c3fe09f69bc 8078725: method adjustments can be done just once for all classes involved into redefinition Summary: walk all classes at the end of redefinition and adjust method entries and clean MethodData Reviewed-by: sspitsyn ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/klassVtable.hpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.hpp ! src/hotspot/share/prims/resolvedMethodTable.cpp Changeset: 5f8ab857f7e1 Author: stefank Date: 2019-02-22 20:42 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5f8ab857f7e1 8219571: ProblemList serviceability/sa/TestJmapCoreMetaspace.java Reviewed-by: iignatyev + test/hotspot/jtreg/ProblemList-zgc.txt Changeset: a6fb5e60588f Author: iignatyev Date: 2019-02-22 14:39 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a6fb5e60588f 8209807: improve handling exception in requires.VMProps Reviewed-by: vlivanov, mseledtsov ! test/jtreg-ext/requires/VMProps.java Changeset: c1885a1d62a3 Author: mikael Date: 2019-02-22 18:54 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c1885a1d62a3 8219611: Remove superfluous sigfillset code Reviewed-by: dholmes ! src/hotspot/os/posix/os_posix.cpp Changeset: 45a23c64d0f6 Author: shade Date: 2019-02-23 10:55 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/45a23c64d0f6 8219583: Windows build failure after JDK-8214777 (Avoid some GCC 8.X strncpy() errors in HotSpot) Reviewed-by: kbarrett, mikael ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classLoaderExt.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/services/diagnosticArgument.cpp ! src/hotspot/share/utilities/xmlstream.cpp Changeset: 446ec34c7838 Author: vromero Date: 2019-02-23 19:41 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/446ec34c7838 8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0 Reviewed-by: mchung, briangoetz ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! test/jdk/java/lang/constant/ClassDescTest.java Changeset: 072b382347db Author: dholmes Date: 2019-02-24 16:10 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/072b382347db 8208278: [mlvm] [TESTBUG] vm.mlvm.mixed.stress.java.findDeadlock.INDIFY_Test Deadlocked threads are not always detected Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/vm/mlvm/mixed/stress/java/findDeadlock/INDIFY_Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/mixed/stress/java/findDeadlock/INDIFY_Test.jmpp Changeset: 65f2a401e0eb Author: mbaesken Date: 2019-02-18 16:17 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/65f2a401e0eb 8218811: replace open by os::open in hotspot coding Reviewed-by: dholmes, iklam, stuefe ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os/linux/perfMemory_linux.cpp ! src/hotspot/os/solaris/os_perf_solaris.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/classfile/compactHashtable.cpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/utilities/ostream.cpp Changeset: 91f06b86c0da Author: jgeorge Date: 2019-02-25 13:50 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/91f06b86c0da 8214756: SA should ignore archived java heap objects that are not in use Summary: Ignore objects, the associated classes of which are unloaded while walking the heap to create a heapdump Reviewed-by: jiangli, redestad ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java Changeset: 4074a3d599cd Author: mullan Date: 2019-02-25 08:25 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4074a3d599cd 8159525: Add @FunctionalInterface annotation to PrivilegedAction and PrivilegedExceptionAction Reviewed-by: clanger ! src/java.base/share/classes/java/security/PrivilegedAction.java ! src/java.base/share/classes/java/security/PrivilegedExceptionAction.java Changeset: ee4488381c78 Author: mseledtsov Date: 2019-02-25 08:16 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ee4488381c78 8219553: [TESTBUG] Problem list JFR TestPeriod test Summary: Problem listed the test Reviewed-by: egahlin ! test/jdk/ProblemList.txt Changeset: 7fec83061f24 Author: darcy Date: 2019-02-25 14:45 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7fec83061f24 8219561: Update jdeprscan to avoid the need for start-of-release changes Reviewed-by: dfuchs, lancea, smarks ! src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java Changeset: ca1a2ca32885 Author: jjiang Date: 2019-02-26 07:26 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ca1a2ca32885 8215524: Finished message validation failure should be decrypt_error alert Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/Finished.java Changeset: 1ee9149df76f Author: mikael Date: 2019-02-25 16:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1ee9149df76f 8219675: Disable harfbuzz warnings with gcc 8 Reviewed-by: erikj, prr ! make/lib/Awt2dLibraries.gmk Changeset: 616a32d6b463 Author: cjplummer Date: 2019-02-25 18:54 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/616a32d6b463 8219143: jdb should support breakpoint thread filters Summary: add thread filter to stop command. Reviewed-by: sspitsyn, amenkov ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/BreakpointSpec.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/EventRequestSpecList.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources.java + test/jdk/com/sun/jdi/JdbStopThreadidTest.java ! test/jdk/com/sun/jdi/lib/jdb/JdbCommand.java Changeset: 554c3c813ad6 Author: rschmelter Date: 2019-02-22 04:59 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/554c3c813ad6 8219577: Returning NULL in a function which returns bools Reviewed-by: shade, zgu, clanger ! src/hotspot/os/windows/os_windows.cpp Changeset: 7a72441858bb Author: nishjain Date: 2019-02-26 14:57 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7a72441858bb 8209175: Handle 'B' character introduced in CLDR 33 JDK update for Burmese (my) locale Reviewed-by: naoto, rriggs ! make/data/cldr/common/main/my.xml ! make/jdk/src/classes/build/tools/cldrconverter/Bundle.java + test/jdk/java/text/Format/DateFormat/TestDayPeriodWithSDF.java + test/jdk/java/time/test/java/time/format/TestDayPeriodWithDTF.java Changeset: a590b6107ab3 Author: eosterlund Date: 2019-02-26 11:36 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a590b6107ab3 8218974: Free GC native structures in nmethod::flush Reviewed-by: pliden ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/gc/z/zNMethod.hpp ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zNMethodData.hpp ! src/hotspot/share/gc/z/zUnload.cpp Changeset: 00fcc1ef31e8 Author: eosterlund Date: 2019-02-26 11:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/00fcc1ef31e8 8219638: ZGC: Free ZNMethodDataOops under a lock Reviewed-by: pliden ! src/hotspot/share/gc/z/zNMethodData.cpp Changeset: c431ab7f9e85 Author: sgehwolf Date: 2019-02-13 12:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c431ab7f9e85 8218913: Rename --strip-debug jlink plugin Reviewed-by: alanb, mchung ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java + src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java + src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripJavaDebugAttributesPlugin.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties ! src/jdk.jlink/share/classes/module-info.java ! test/jdk/tools/jlink/IntegrationTest.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java + test/jdk/tools/jlink/plugins/StripJavaDebugAttributesPluginTest.java Changeset: 09cba396916f Author: coleenp Date: 2019-02-26 08:01 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/09cba396916f 8181171: Deleting method for RedefineClasses breaks ResolvedMethodName 8210457: JVM crash in ResolvedMethodTable::add_method(Handle) Summary: Add a function to call NSME in ResolvedMethodTable to replace deleted methods. Reviewed-by: sspitsyn, dholmes, dcubed ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/memory/universe.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/resolvedMethodTable.cpp ! src/hotspot/share/prims/resolvedMethodTable.hpp ! src/java.base/share/classes/jdk/internal/misc/Unsafe.java + test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java + test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c ! test/jdk/java/lang/instrument/NamedBuffer.java + test/jdk/java/lang/instrument/RedefineAddDeleteMethod/DeleteMethodHandle/MethodHandleDeletedMethod.java + test/jdk/java/lang/instrument/RedefineAddDeleteMethod/DeleteMethodHandle/redef/Xost.java Changeset: c216c40ba47b Author: ecaspole Date: 2019-02-26 10:39 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c216c40ba47b 8219664: LogCompilation: java.lang.Error: Unexpected method mismatch during late inlining Summary: Set lateInlining=true in task endElement Reviewed-by: vlivanov, kvn ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/LogParser.java Changeset: 7272e7c5164b Author: aleonard Date: 2019-02-19 16:13 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7272e7c5164b 8219378: Ensure ReflectionFactory.langReflectAccess is initialized correctly Reviewed-by: rriggs, alanb, mchung Contributed-by: andrew_m_leonard at uk.ibm.com ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java Changeset: 03924ad3f4d0 Author: lancea Date: 2019-02-26 13:14 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/03924ad3f4d0 8219548: Better Null paramenter checking in ToolProvider Reviewed-by: lancea, alanb, jjg Contributed-by: Philipp Kunz ! src/java.base/share/classes/java/util/spi/ToolProvider.java ! test/jdk/java/util/spi/ToolProviderTest.java Changeset: 20ee41e8740d Author: fyang Date: 2019-02-25 18:50 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/20ee41e8740d 8219635: aarch64: missing LoadStore barrier in TemplateTable::fast_storefield Reviewed-by: aph Contributed-by: patrick at os.amperecomputing.com ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Changeset: ca23d3475af0 Author: amenkov Date: 2019-02-26 15:29 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ca23d3475af0 8181383: com/sun/jdi/OptionTest.java fails intermittently with bind failed: Address already in use Reviewed-by: sspitsyn, cjplummer ! test/jdk/com/sun/jdi/OptionTest.java ! test/jdk/com/sun/jdi/RunToExit.java Changeset: df3d253aaf81 Author: valeriep Date: 2019-02-27 02:49 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/df3d253aaf81 8218780: Update MUSCLE PCSC-Lite header files Summary: update the PCSC-lite header files to 1.8.24 release Reviewed-by: coffeys ! src/java.smartcardio/share/native/libj2pcsc/pcsc.c - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING ! src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/pcsclite.h ! src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/winscard.h + src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/wintypes.h ! src/java.smartcardio/unix/native/libj2pcsc/pcsc_md.h Changeset: f47ca94f30b9 Author: mbaesken Date: 2019-02-26 09:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f47ca94f30b9 8219630: cleanup hotspot ostream.cpp Reviewed-by: clanger, dholmes, stuefe ! src/hotspot/share/utilities/ostream.cpp ! src/hotspot/share/utilities/ostream.hpp Changeset: 33839b74e47c Author: shade Date: 2019-02-27 10:03 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/33839b74e47c 8219814: Help-info for pns(...) on Linux/mips lost Reviewed-by: aoqi, shade Contributed-by: Jie Fu ! src/hotspot/share/utilities/debug.cpp Changeset: 2d8172254394 Author: psadhukhan Date: 2019-02-21 10:33 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2d8172254394 8219156: RTFEditorKit writes background color but doesn't read Reviewed-by: serb ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java + test/jdk/javax/swing/text/rtf/RTFReadBGColorTest.java Changeset: 2900b9f89465 Author: sveerabhadra Date: 2019-02-21 11:10 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2900b9f89465 8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe Reviewed-by: prr, mhalder ! src/jdk.accessibility/windows/native/jaccessinspector/jaccessinspectorWindow.rc ! src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalkerWindow.rc Changeset: 49b74aa7d2e3 Author: sveerabhadra Date: 2019-02-21 12:27 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/49b74aa7d2e3 8213071: [macos] The focus disappears after pressing return to close the "That was a pretty good movie!" dialog. Reviewed-by: serb ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m Changeset: 03163eb3b2d4 Author: sveerabhadra Date: 2019-02-25 11:02 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/03163eb3b2d4 8212202: [Windows] Exception if no printers are installed. Reviewed-by: prr ! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java ! src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp ! test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java Changeset: a986e16d8449 Author: psadhukhan Date: 2019-02-26 11:08 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a986e16d8449 8213781: web page background renders blue in JEditorPane 4895924: Strings in format #rgb not handled by Color.decode() (affects CSS / Swing) Reviewed-by: serb, sveerabhadra ! src/java.desktop/share/classes/javax/swing/text/html/CSS.java + test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java Changeset: c6b18dd94973 Author: psadhukhan Date: 2019-02-26 11:17 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c6b18dd94973 Merge - src/hotspot/share/gc/z/zStatTLAB.cpp - src/hotspot/share/gc/z/zStatTLAB.hpp - src/hotspot/share/oops/array.inline.hpp - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java Changeset: 7f715085caac Author: psadhukhan Date: 2019-02-27 13:53 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7f715085caac Merge - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java Changeset: f8b2179a55d0 Author: psadhukhan Date: 2019-02-27 14:45 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f8b2179a55d0 Merge Changeset: f9302cf718c9 Author: dchuyko Date: 2019-02-27 13:13 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f9302cf718c9 8215009: GCC 8 compilation error in libjli Reviewed-by: dholmes, mikael, rriggs ! src/java.base/macosx/native/libjli/java_md_macosx.m ! src/java.base/share/native/libjli/java.c ! src/java.base/share/native/libjli/java.h ! src/java.base/unix/native/libjli/java_md_solinux.c ! src/java.base/windows/native/libjli/java_md.c Changeset: d6cb11fa3773 Author: amlu Date: 2019-02-27 18:58 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d6cb11fa3773 8219802: Problem list java/net/MulticastSocket/SetGetNetworkInterfaceTest.java Reviewed-by: chegar, clanger ! test/jdk/ProblemList.txt Changeset: 72ce7dd54939 Author: fyang Date: 2019-02-26 10:52 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/72ce7dd54939 8219698: aarch64: SIGILL triggered when specifying unsupported hardware features Reviewed-by: aph ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Changeset: 2c50e900e8af Author: darcy Date: 2019-02-27 11:33 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2c50e900e8af 8219805: Cross-link javax.lang.model.{type, element} packages to utility interfaces Reviewed-by: vromero ! src/java.compiler/share/classes/javax/lang/model/element/package-info.java ! src/java.compiler/share/classes/javax/lang/model/type/package-info.java Changeset: 1f0b00fe27ed Author: valeriep Date: 2019-02-27 19:37 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1f0b00fe27ed 8183107: PKCS11 regression regarding checkKeySize Summary: Changed key size check in PKCS11 provider to only enforce positive return values Reviewed-by: jnimeh ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM_INFO.java Changeset: 7ed4312ac094 Author: valeriep Date: 2019-02-27 19:40 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7ed4312ac094 Merge Changeset: 8e069f7b4fab Author: darcy Date: 2019-02-27 12:19 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8e069f7b4fab 8218726: Minor Throwable.printStackTrace() typos Reviewed-by: bpb ! src/java.base/share/classes/java/lang/Throwable.java Changeset: 07dd34f487d4 Author: jwilhelm Date: 2019-02-28 02:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/07dd34f487d4 Added tag jdk-13+10 for changeset 8e069f7b4fab ! .hgtags Changeset: 4a99d3a6a86d Author: jjiang Date: 2019-02-28 13:37 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4a99d3a6a86d 8219723: javax/net/ssl/compatibility/Compatibility.java failed on some SNI cases Summary: Re-generates RSA and ECDSA certificates and set longer validity period Reviewed-by: xuelei ! test/jdk/javax/net/ssl/compatibility/Cert.java Changeset: cf47efcf7771 Author: pli Date: 2019-02-28 16:37 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/cf47efcf7771 8216259: AArch64: Vectorize Adler32 intrinsics Reviewed-by: aph ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.cpp ! src/hotspot/cpu/aarch64/stubRoutines_aarch64.hpp Changeset: 56089cf6152c Author: rschmelter Date: 2019-02-26 05:46 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/56089cf6152c 8219712: code_size2 (defined in stub_routines_x86.hpp) is too small on new Skylake CPUs Reviewed-by: mbaesken, dholmes, kvn ! src/hotspot/cpu/x86/stubRoutines_x86.hpp Changeset: 3ccf7e10ba07 Author: goetz Date: 2019-02-28 13:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3ccf7e10ba07 8219714: [testbug] com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java must pass classpath to subprocess Reviewed-by: dholmes, dcubed ! test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java Changeset: 235b0e817c32 Author: zgu Date: 2019-02-28 08:44 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/235b0e817c32 8219857: Shenandoah GC may initialize thread's gclab twice Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp Changeset: b5f4a8477a20 Author: gziemski Date: 2019-02-28 10:55 -0600 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b5f4a8477a20 8219789: [TESTBUG] TestOptionsWithRanges.java produces hs_err_pidXXXXX.log file for VMThreadStackSize=9007199254740991 Summary: Excluded test of mac range for VMThreadStackSize Reviewed-by: coleenp, mseledtsov ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java Changeset: d15d4d610de4 Author: gziemski Date: 2019-02-28 11:04 -0600 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d15d4d610de4 8212932: [TESTBUG] Clean up TestVirtualSpaceNode test Summary: Remove test/hotspot/gtest/memory/test_virtualSpaceNode.cpp Reviewed-by: stuefe, coleenp - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp Changeset: d5bd4d5483e4 Author: iignatyev Date: 2019-02-28 09:10 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d5bd4d5483e4 8219565: [deadcode] remove share/utilities/intHisto.* Reviewed-by: dholmes ! src/hotspot/share/gc/g1/g1RemSet.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp Changeset: 8b886d62ddc7 Author: iignatyev Date: 2019-02-28 09:10 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8b886d62ddc7 8219798: [deadcode] remove src/hotspot/share/prims/evmCompat.cpp Reviewed-by: dholmes - src/hotspot/share/prims/evmCompat.cpp Changeset: 196ab0abc685 Author: xuelei Date: 2019-02-28 10:04 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/196ab0abc685 8219658: Deadlock in sun.security.ssl.SSLSocketImpl Reviewed-by: jnimeh ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 1542e63eb537 Author: bpb Date: 2019-02-28 12:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1542e63eb537 5071718: (bf) Add ByteBuffer.slice(int offset, int length) Reviewed-by: alanb, bchristi, darcy, rriggs ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java ! src/java.base/share/classes/java/nio/X-Buffer.java.template ! test/jdk/java/nio/Buffer/Basic-X.java.template ! test/jdk/java/nio/Buffer/Basic.java ! test/jdk/java/nio/Buffer/BasicByte.java ! test/jdk/java/nio/Buffer/BasicChar.java ! test/jdk/java/nio/Buffer/BasicDouble.java ! test/jdk/java/nio/Buffer/BasicFloat.java ! test/jdk/java/nio/Buffer/BasicInt.java ! test/jdk/java/nio/Buffer/BasicLong.java ! test/jdk/java/nio/Buffer/BasicShort.java ! test/jdk/java/nio/Buffer/ByteBufferViews.java ! test/jdk/java/nio/Buffer/StringCharBufferSliceTest.java Changeset: 6c3fd94de35a Author: dtitov Date: 2019-02-28 13:12 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6c3fd94de35a 8207367: 10 vmTestbase/nsk/jdi tests timed out when running with jtreg Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassUnloadRequest/addClassExclusionFilter/exclfilter001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassUnloadRequest/addClassFilter/filter001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/_itself_/event001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspend/suspend001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001.java Changeset: e5b461681b88 Author: redestad Date: 2019-02-28 22:11 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e5b461681b88 8219922: Simplify and optimize IndexSetIterator::next using count_trailing_zeros Reviewed-by: kvn, neliasso ! src/hotspot/share/opto/indexSet.cpp ! src/hotspot/share/opto/indexSet.hpp Changeset: 2653e078b057 Author: coleenp Date: 2019-02-28 16:30 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2653e078b057 8218266: G1 crash in AccessInternal::PostRuntimeDispatch Summary: protection_domains can be unloaded in the dictionary pd_set. Reviewed-by: zgu, hseigel ! src/hotspot/share/classfile/dictionary.cpp ! src/hotspot/share/classfile/dictionary.hpp - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/protectionDomainCache.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java ! test/hotspot/jtreg/runtime/Dictionary/test.policy Changeset: 7f01a85f2710 Author: naoto Date: 2019-02-28 14:03 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7f01a85f2710 8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales Reviewed-by: lancea ! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java ! test/jdk/java/util/Calendar/JapaneseEraNameTest.java Changeset: 393348e562c1 Author: naoto Date: 2019-02-28 14:05 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/393348e562c1 Merge - src/hotspot/share/classfile/dictionary.inline.hpp Changeset: 86ee52ca11e3 Author: dholmes Date: 2019-02-28 18:28 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/86ee52ca11e3 8219492: Restore static callsite resolution for the current class Reviewed-by: redestad, lfoltan, vlivanov ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: b378fc877045 Author: kvn Date: 2019-02-28 17:16 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b378fc877045 8219951: Build failure on Mac and Windows after JDK-8219922 Summary: Add missing parentheses. Reviewed-by: dholmes ! src/hotspot/share/opto/indexSet.hpp Changeset: 2bd3e05d4c6f Author: ngasson Date: 2019-02-19 14:11 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2bd3e05d4c6f 8209413: AArch64: NPE in clhsdb jstack command Reviewed-by: aph ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64CurrentFrameGuess.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java Changeset: 6862a1997fbb Author: mbaesken Date: 2019-02-28 10:28 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6862a1997fbb 8219746: Provide virtualization related info in the hs_error file on linux ppc64 / ppc64le Reviewed-by: dholmes, lucy, mdoerr ! src/hotspot/os/linux/os_linux.cpp Changeset: b342deab639f Author: clanger Date: 2019-03-01 10:15 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b342deab639f 8219915: [TESTBUG] Fix test langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java in Standalone mode Reviewed-by: jlahoda ! test/langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java Changeset: 1ad7c590a6e7 Author: stuefe Date: 2019-02-10 09:10 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1ad7c590a6e7 8218988: Improve metaspace verifications Reviewed-by: zgu, coleenp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace/chunkManager.cpp ! src/hotspot/share/memory/metaspace/chunkManager.hpp ! src/hotspot/share/memory/metaspace/metaDebug.hpp ! src/hotspot/share/memory/metaspace/metaspaceCommon.hpp ! src/hotspot/share/memory/metaspace/spaceManager.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp ! src/hotspot/share/runtime/globals.hpp Changeset: 1019c97e1bde Author: dholmes Date: 2019-03-01 08:14 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1019c97e1bde 8219969: Backout JDK-8219492 Reviewed-by: goetz, hseigel, tschatzl ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: 43c2ab1bdfd3 Author: xuelei Date: 2019-03-01 08:35 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/43c2ab1bdfd3 8215430: Remove the internal package com.sun.net.ssl Reviewed-by: chegar, mullan, wetmore - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java ! src/java.base/share/classes/java/security/Security.java ! src/java.base/share/classes/java/security/Signature.java ! src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/java.base/share/classes/sun/security/jca/ProviderConfig.java ! src/java.base/share/classes/sun/security/ssl/SunJSSE.java ! test/jdk/TEST.groups - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java ! test/jdk/java/security/BasicPermission/Wildcard.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java ! test/jdk/javax/net/ssl/GetInstance.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CheckMethods.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java ! test/jdk/sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java Changeset: db37ce5664e3 Author: mdoerr Date: 2019-03-01 17:48 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/db37ce5664e3 8219582: PPC: Crash after C1 checkcast patched and GC Reviewed-by: akozlov, goetz ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp Changeset: c9f2b71057c1 Author: xuelei Date: 2019-03-01 09:42 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c9f2b71057c1 8219990: Backout JDK-8219658 Reviewed-by: dfuchs ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: b31780c0c4c9 Author: jiefu Date: 2019-03-01 10:00 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b31780c0c4c9 8219919: RuntimeStub name lost with PrintFrameConverterAssembly Reviewed-by: kvn ! src/hotspot/share/opto/output.cpp Changeset: 5d97784f08bf Author: jjg Date: 2019-03-01 11:01 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5d97784f08bf 8219803: Nodeca Pako license text needs to be inserted in JSZip license text Reviewed-by: darcy ! src/jdk.javadoc/share/legal/jszip.md Changeset: 723f665d0596 Author: igerasim Date: 2019-03-01 12:47 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/723f665d0596 8218228: The constructor StringBuffer(CharSequence) violates spec for negatively sized argument Reviewed-by: rriggs, darcy ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java ! src/java.base/share/classes/java/lang/StringBuffer.java ! test/jdk/java/lang/StringBuffer/AppendCharSequence.java Changeset: 581c2f4f82d3 Author: xuelei Date: 2019-03-01 13:08 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/581c2f4f82d3 8219994: CheckSecurityProvider.java fails with unexpected sun.security.ssl.SunJSSE Reviewed-by: mullan, wetmore ! test/jdk/java/lang/SecurityManager/CheckSecurityProvider.java Changeset: 70c7c4db9c9a Author: dchuyko Date: 2019-03-02 11:42 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/70c7c4db9c9a 8214854: JDWP: Unforseen output truncation in logging Reviewed-by: cjplummer, dholmes ! src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c Changeset: f3fd73c3a077 Author: zgu Date: 2019-03-02 08:33 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f3fd73c3a077 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp Changeset: d489081c5650 Author: dholmes Date: 2019-03-02 18:09 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d489081c5650 8219619: Remove UseFakeTimers and related code Reviewed-by: zgu, redestad ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 05d35241e1e9 Author: jlahoda Date: 2019-03-04 10:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/05d35241e1e9 8217868: Crash for overlap between source path and patch module path Summary: When analyzing implicit files, do not look for containing module, but rather use the already known one. Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocTool.java ! test/langtools/tools/javac/modules/PatchModulesTest.java Changeset: 7935353a466a Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7935353a466a 8218880: G1 crashes when issuing a periodic GC while the GCLocker is held Summary: Do not wait for the GC locker in the periodic GC thread as the GC locker being held is an indication for being busy anyway. Reviewed-by: kbarrett, shade ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1VMOperations.hpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp + test/hotspot/jtreg/gc/g1/TestPeriodicCollectionJNI.java + test/hotspot/jtreg/gc/g1/libTestPeriodicCollectionJNI.c Changeset: 31884d19e945 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/31884d19e945 8219369: Add named constants for iterating ExtRootScan phases Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp Changeset: 0da5c17f5e43 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0da5c17f5e43 8219747: Remove g1_ prefix to g1_remset and g1_policy members in G1CollectedHeap Reviewed-by: shade, sangheki ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/g1/g1HeapTransition.cpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/shared/gcVMOperations.cpp ! src/hotspot/share/prims/whitebox.cpp Changeset: 9ad20fd52b19 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9ad20fd52b19 8219748: Add and use getter for the timing object in G1 Reviewed-by: shade, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp Changeset: e1f707ed0757 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e1f707ed0757 8219856: Spell out G1CollectorPolicy::is_hetero_heap Reviewed-by: sangheki, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.hpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/prims/whitebox.cpp Changeset: efa9bc147d50 Author: gadams Date: 2019-03-04 08:45 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/efa9bc147d50 4903717: nsk/jdi/ThreadReference/isSuspended/issuspended002 failing Reviewed-by: amenkov, sspitsyn ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended002a.java Changeset: 247f1a85d736 Author: fyang Date: 2019-03-01 14:38 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/247f1a85d736 8219888: aarch64: add CPU detection code for HiSilicon TSV110 Reviewed-by: aph, drwhite, pzhang Contributed-by: dongbo4 at huawei.com ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp Changeset: 8c82412da698 Author: kevinw Date: 2019-03-01 04:34 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8c82412da698 8219513: compiler/codegen/aes/TestCipherBlockChainingEncrypt.java timeout on Solaris-sparc Reviewed-by: kvn, iignatyev Contributed-by: fairoz.matte at oracle.com ! test/hotspot/jtreg/compiler/codegen/aes/TestCipherBlockChainingEncrypt.java Changeset: 786825220790 Author: jjg Date: 2019-03-04 11:19 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/786825220790 8219801: Pages do not have

Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java ! test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testHref/TestHref.java ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java ! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java ! test/langtools/jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java ! test/langtools/jdk/javadoc/doclet/testSummaryHeading/TestSummaryHeading.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/A11yChecker.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java Changeset: cf4c3a118d2b Author: erikj Date: 2019-03-04 11:30 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/cf4c3a118d2b 8219988: Change to Visual Studio 2017 15.9.6 for building on Windows at Oracle Reviewed-by: tbell ! make/conf/jib-profiles.js - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh ! make/devkit/createWindowsDevkit2017.sh Changeset: 271f75d4b494 Author: erikj Date: 2019-03-04 11:28 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/271f75d4b494 8219986: Change to Xcode 10.1 for building on Macosx at Oracle Reviewed-by: tbell ! make/conf/jib-profiles.js + make/devkit/createMacosxDevkit.sh - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh Changeset: 77343f5c85cb Author: dholmes Date: 2019-03-04 19:38 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/77343f5c85cb 8219974: REDO JDK-8219492: Restore static callsite resolution for the current class Reviewed-by: redestad, vlivanov, coleenp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: ecc2bcc3beb0 Author: ihse Date: 2019-03-05 11:07 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ecc2bcc3beb0 8219971: Introduce SetupExecute in build system Reviewed-by: erikj ! make/CreateJmods.gmk ! make/Docs.gmk ! make/ExplodedImageOptimize.gmk ! make/Images.gmk ! make/Main.gmk ! make/UpdateX11Wrappers.gmk + make/common/Execute.gmk ! make/gensrc/GensrcCommonJdk.gmk ! make/gensrc/GensrcX11Wrappers.gmk ! make/hotspot/gensrc/GenerateSources.gmk ! make/hotspot/gensrc/GensrcAdlc.gmk ! make/hotspot/gensrc/GensrcDtrace.gmk ! make/hotspot/gensrc/GensrcJfr.gmk ! make/hotspot/gensrc/GensrcJvmti.gmk ! make/hotspot/ide/CreateVSProject.gmk Changeset: 35a30b432396 Author: aoqi Date: 2019-03-05 11:09 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/35a30b432396 8219906: Update test documentation with default test jobs settings Reviewed-by: ihse ! doc/testing.html ! doc/testing.md Changeset: 4ae746de6b86 Author: ihse Date: 2019-03-05 13:41 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4ae746de6b86 8220155: JDK-8219971 broke hotspot build Reviewed-by: dholmes ! make/hotspot/gensrc/GensrcAdlc.gmk Changeset: d870bb08194a Author: mullan Date: 2019-03-05 08:24 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d870bb08194a 8217878: ENVELOPING XML signature no longer works in JDK 11 8218629: XML Digital Signature throws NAMESPACE_ERR exception on OpenJDK 11, works 8/9/10 Summary: Backout and restore previous XML signature marshalling implementation Reviewed-by: weijun ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java + src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! test/jdk/javax/xml/crypto/dsig/GenerationTests.java + test/jdk/javax/xml/crypto/dsig/data/envelope2.xml Changeset: d7852bb72332 Author: mbaesken Date: 2019-03-05 09:55 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d7852bb72332 8219920: dependency help output in configure-step : support zypper tool Reviewed-by: erikj, ihse ! make/autoconf/configure ! make/autoconf/help.m4 Changeset: 3158fae17e80 Author: zgu Date: 2019-03-05 12:30 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3158fae17e80 8220161: Shenandoah does not need to initialize PLABs for safepoint workers Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: b4e59fc5edd1 Author: simonis Date: 2019-03-05 18:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b4e59fc5edd1 8220164: Fix build instructions for AIX Reviewed-by: mdoerr, erikj, mbaesken ! doc/building.html ! doc/building.md Changeset: fb9541185457 Author: jjg Date: 2019-03-05 10:35 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fb9541185457 8219946: Set class on body elements Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! test/langtools/jdk/javadoc/doclet/JavascriptWinTitle/JavascriptWinTitle.java ! test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testJavascript/TestJavascript.java ! test/langtools/jdk/javadoc/doclet/testMetadata/TestMetadata.java Changeset: f3468c1bdf5f Author: cjplummer Date: 2019-03-05 13:40 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f3468c1bdf5f 8220030: JdbStopThreadidTest.java failed due to "Unexpected IO error while writing command 'quit' to jdb stdin stream" Summary: Use contToExit(1) for safer approach to test exit. Reviewed-by: gadams, amenkov ! test/jdk/com/sun/jdi/JdbStopThreadidTest.java Changeset: 465beebb1071 Author: dtitov Date: 2019-03-05 13:41 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/465beebb1071 8218167: nsk/jvmti/scenarios/sampling/SP02/sp02t003 fails Reviewed-by: dlong, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP02/sp02t003/sp02t003.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003/sp06t003.cpp Changeset: 6ffb8d7fe1e4 Author: vdeshpande Date: 2019-03-05 14:07 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6ffb8d7fe1e4 8216580: Fix generation of VNNI vector code by allowing adjacent LoadS nodes to be isomorphic Reviewed-by: kvn, thartmann, rraghavan ! src/hotspot/share/opto/superword.cpp Changeset: a421bdf22394 Author: kbarrett Date: 2019-03-05 19:54 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a421bdf22394 8219613: Use NonJavaThread PtrQueues Summary: Init and use NJT queues, remove shared SATB queue. Reviewed-by: shade, zgu, pliden, tschatzl Contributed-by: kim.barrett at oracle.com, shade at redhat.com ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp ! src/hotspot/share/gc/z/zBarrierSet.cpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: b23068def105 Author: vdeshpande Date: 2019-03-05 21:26 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b23068def105 8220211: Small update to Fix generation of VNNI vector code by allowing adjacent LoadS nodes to be isomorphic (JDK-8216580) Reviewed-by: kvn ! src/hotspot/share/opto/superword.cpp Changeset: 8b341d6728fe Author: jiefu Date: 2019-02-28 09:43 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8b341d6728fe 8219519: Remove linux_sparc.ad and linux_aarch64.ad Reviewed-by: thartmann, pli, adinn - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad Changeset: 13acb4339895 Author: rehn Date: 2019-03-06 11:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/13acb4339895 8220151: SafepointTracing::end_of_last_safepoint_ms should return ms since epoch. Reviewed-by: dholmes, redestad ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp Changeset: 17fb726e6d8e Author: lucy Date: 2019-03-06 12:14 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/17fb726e6d8e 8219214: Infinite Loop in CodeSection::dump() Reviewed-by: kvn, thartmann ! src/hotspot/share/asm/codeBuffer.cpp ! src/hotspot/share/asm/codeBuffer.hpp Changeset: 21ea4076a275 Author: stuefe Date: 2019-02-28 14:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/21ea4076a275 8219650: [Testbug] Fix potential crashes in new test hotspot gtest "test_print_hex_dump" Reviewed-by: clanger, shade ! src/hotspot/share/runtime/os.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 7a9a828195c7 Author: rkennke Date: 2019-03-11 18:44 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7a9a828195c7 Merge ! .hgtags - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/windows/os_windows.cpp - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMemoryPool.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/superword.cpp - src/hotspot/share/prims/evmCompat.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp ! src/hotspot/share/runtime/vmOperations.hpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP02/sp02t003/sp02t003.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003/sp06t003.cpp - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java From shade at redhat.com Tue Mar 12 17:01:56 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 12 Mar 2019 18:01:56 +0100 Subject: [12u] RFR (S) 8220350: Refactor ShenandoahHeap::initialize Message-ID: Hi, Please review the backport for Shenandoah change that allows to unblock follow-up functionality fixes. Original RFE: https://bugs.openjdk.java.net/browse/JDK-8220350 Original change: http://cr.openjdk.java.net/~shade/8220350/webrev.02/ Patch does not apply cleanly, because there are minor changes in SATBQueue interface and whitespace difference. 12u change: http://cr.openjdk.java.net/~shade/8220350/webrev.12u.02/ Testing: hotspot_gc_shenandoah, eyeballing the differences against original change -Aleksey From rkennke at redhat.com Tue Mar 12 17:19:31 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 12 Mar 2019 18:19:31 +0100 Subject: [12u] RFR (S) 8220350: Refactor ShenandoahHeap::initialize In-Reply-To: References: Message-ID: <574a1ff1-7d2c-a728-2f36-352b13ac185d@redhat.com> > Please review the backport for Shenandoah change that allows to unblock follow-up functionality fixes. > > Original RFE: > https://bugs.openjdk.java.net/browse/JDK-8220350 > > Original change: > http://cr.openjdk.java.net/~shade/8220350/webrev.02/ > > Patch does not apply cleanly, because there are minor changes in SATBQueue interface and whitespace > difference. 12u change: > http://cr.openjdk.java.net/~shade/8220350/webrev.12u.02/ > > Testing: hotspot_gc_shenandoah, eyeballing the differences against original change Looks good to me! Thanks! Roman From zgu at redhat.com Wed Mar 13 15:08:08 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Wed, 13 Mar 2019 11:08:08 -0400 Subject: RFR(S) 8220546: Shenandoah Reports timing details for weak root processing Message-ID: <3f1e2300-a0f6-41e4-cc18-7d4326050ed1@redhat.com> Please review this patch that catches WeakProcessor's timings into shenandoah's timings. Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.00/ Sample output: http://cr.openjdk.java.net/~zgu/JDK-8220546/par_timings.log Test: hotspot_gc_sheanndoah (fastdebug and release) Thanks, -Zhengyu From rkennke at redhat.com Wed Mar 13 15:30:47 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 13 Mar 2019 16:30:47 +0100 Subject: RFR(S) 8220546: Shenandoah Reports timing details for weak root processing In-Reply-To: <3f1e2300-a0f6-41e4-cc18-7d4326050ed1@redhat.com> References: <3f1e2300-a0f6-41e4-cc18-7d4326050ed1@redhat.com> Message-ID: <98e0f51f-5694-95c6-eb33-d29b45061826@redhat.com> Hi Zhengyu, cool stuff! - I find the naming/style weird and out of place: WeakProcessorTimingToShenandoahTiming(..) can we stick to weak_processor_timing_... style? - I suppose it is intended and ok to have all threads do this: + _processed_weak_roots = true; Other than that, ok! Roman > Please review this patch that catches WeakProcessor's timings into > shenandoah's timings. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.00/ > > Sample output: http://cr.openjdk.java.net/~zgu/JDK-8220546/par_timings.log > > Test: > ? hotspot_gc_sheanndoah (fastdebug and release) > > > Thanks, > > -Zhengyu > From rkennke at redhat.com Wed Mar 13 15:36:15 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 13 Mar 2019 16:36:15 +0100 Subject: RFR: SA Best-effort heap walking implementation In-Reply-To: <1550861512.4234.9.camel@redhat.com> References: <1550861512.4234.9.camel@redhat.com> Message-ID: Very nice! The patch looks ok. I wonder if we'd rather push it to upstream right away? It doesn't seem very risky, does it? Thanks, Roman > This mirrors ZGC, provides best-effort heap walking implementation. > > The patch applies cleanly for jdk/jdk and shenandoah/jdk, depending on > if we want to bake for a while in shenandoah/jdk repo, or I can file > upstream bug. > > Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh-sa-heap-walk/webr > ev.00/index.html > > Test: > tier1, 2, 3_gc_shenandoah > hotspot_serviceability > vmTestbase/nsk/jdb > manual test: jhsdb hsdb > > Thanks, > > -Zhengyu > > From zgu at redhat.com Wed Mar 13 15:49:31 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Wed, 13 Mar 2019 11:49:31 -0400 Subject: RFR(S) 8220546: Shenandoah Reports timing details for weak root processing In-Reply-To: <98e0f51f-5694-95c6-eb33-d29b45061826@redhat.com> References: <3f1e2300-a0f6-41e4-cc18-7d4326050ed1@redhat.com> <98e0f51f-5694-95c6-eb33-d29b45061826@redhat.com> Message-ID: <50afd00d-2982-a411-9715-f749b15074a1@redhat.com> Thanks for the review. On 3/13/19 11:30 AM, Roman Kennke wrote: > Hi Zhengyu, > > cool stuff! > > - I find the naming/style weird and out of place: > WeakProcessorTimingToShenandoahTiming(..) can we stick to > weak_processor_timing_... style? Oops, no idea why I did that :-) > - I suppose it is intended and ok to have all threads do this: > +??? _processed_weak_roots = true; Correct. Updated: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.01/ Thanks, -Zhengyu > > Other than that, ok! > > Roman > >> Please review this patch that catches WeakProcessor's timings into >> shenandoah's timings. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 >> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.00/ >> >> Sample output: >> http://cr.openjdk.java.net/~zgu/JDK-8220546/par_timings.log >> >> Test: >> ?? hotspot_gc_sheanndoah (fastdebug and release) >> >> >> Thanks, >> >> -Zhengyu >> From zgu at redhat.com Wed Mar 13 15:53:50 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Wed, 13 Mar 2019 11:53:50 -0400 Subject: RFR: SA Best-effort heap walking implementation In-Reply-To: References: <1550861512.4234.9.camel@redhat.com> Message-ID: On 3/13/19 11:36 AM, Roman Kennke wrote: > Very nice! > > The patch looks ok. I wonder if we'd rather push it to upstream right > away? It doesn't seem very risky, does it? Okay, I will file upstream RFE. Thanks, -Zhengyu > > Thanks, > Roman > >> This mirrors ZGC, provides best-effort heap walking implementation. >> >> The patch applies cleanly for jdk/jdk and shenandoah/jdk, depending on >> if we want to bake for a while in shenandoah/jdk repo, or I can file >> upstream bug. >> >> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh-sa-heap-walk/webr >> ev.00/index.html >> >> Test: >> ?? tier1, 2, 3_gc_shenandoah >> ?? hotspot_serviceability >> ?? vmTestbase/nsk/jdb >> ?? manual test: jhsdb hsdb >> >> Thanks, >> >> -Zhengyu >> >> From rkennke at redhat.com Wed Mar 13 17:19:22 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 13 Mar 2019 18:19:22 +0100 Subject: RFR(S) 8220546: Shenandoah Reports timing details for weak root processing In-Reply-To: <50afd00d-2982-a411-9715-f749b15074a1@redhat.com> References: <3f1e2300-a0f6-41e4-cc18-7d4326050ed1@redhat.com> <98e0f51f-5694-95c6-eb33-d29b45061826@redhat.com> <50afd00d-2982-a411-9715-f749b15074a1@redhat.com> Message-ID: <78fe01a3-27c6-e3e7-177a-41681a6b1032@redhat.com> > On 3/13/19 11:30 AM, Roman Kennke wrote: >> Hi Zhengyu, >> >> cool stuff! >> >> - I find the naming/style weird and out of place: >> WeakProcessorTimingToShenandoahTiming(..) can we stick to >> weak_processor_timing_... style? > > Oops, no idea why I did that :-) > >> - I suppose it is intended and ok to have all threads do this: >> +??? _processed_weak_roots = true; > Correct. > > Updated: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.01/ Good! Thanks! Roman > Thanks, > > -Zhengyu > >> >> Other than that, ok! >> >> Roman >> >>> Please review this patch that catches WeakProcessor's timings into >>> shenandoah's timings. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 >>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546/webrev.00/ >>> >>> Sample output: >>> http://cr.openjdk.java.net/~zgu/JDK-8220546/par_timings.log >>> >>> Test: >>> ?? hotspot_gc_sheanndoah (fastdebug and release) >>> >>> >>> Thanks, >>> >>> -Zhengyu >>> From shade at redhat.com Wed Mar 13 17:46:05 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 13 Mar 2019 18:46:05 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+2 to sh/jdk11 Message-ID: <3699eddc-8103-8bfd-4ec5-30a4cbf697d0@redhat.com> Another minor tag update from jdk-updates/jdk11u, now it is jdk-11.0.3+3. Merge is trivial. Summary of changes: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/changesets.txt Webrev: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/webrev/ As usual, the plan is to push this merge, run it through the nightlies and then tag it shenandoah-jdk-11.0.3+3. Testing: hotspot_gc_shenandoah {fastdebug,release} -Aleksey From shade at redhat.com Wed Mar 13 17:47:25 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 13 Mar 2019 18:47:25 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+3 to sh/jdk11 In-Reply-To: <3699eddc-8103-8bfd-4ec5-30a4cbf697d0@redhat.com> References: <3699eddc-8103-8bfd-4ec5-30a4cbf697d0@redhat.com> Message-ID: (proper subject) -Aleksey On 3/13/19 6:46 PM, Aleksey Shipilev wrote: > Another minor tag update from jdk-updates/jdk11u, now it is jdk-11.0.3+3. Merge is trivial. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/webrev/ > > As usual, the plan is to push this merge, run it through the nightlies and then tag it > shenandoah-jdk-11.0.3+3. > > Testing: hotspot_gc_shenandoah {fastdebug,release} > > -Aleksey > From rkennke at redhat.com Wed Mar 13 17:47:27 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 13 Mar 2019 18:47:27 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+2 to sh/jdk11 In-Reply-To: <3699eddc-8103-8bfd-4ec5-30a4cbf697d0@redhat.com> References: <3699eddc-8103-8bfd-4ec5-30a4cbf697d0@redhat.com> Message-ID: Good! Do it! Roman > Another minor tag update from jdk-updates/jdk11u, now it is jdk-11.0.3+3. Merge is trivial. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b3/webrev/ > > As usual, the plan is to push this merge, run it through the nightlies and then tag it > shenandoah-jdk-11.0.3+3. > > Testing: hotspot_gc_shenandoah {fastdebug,release} > > -Aleksey > From shade at redhat.com Wed Mar 13 19:11:06 2019 From: shade at redhat.com (shade at redhat.com) Date: Wed, 13 Mar 2019 19:11:06 +0000 Subject: hg: shenandoah/jdk11: 8 new changesets Message-ID: <201903131911.x2DJB8jq007873@aojmv0008.oracle.com> Changeset: 8f8750fe8c0e Author: naoto Date: 2019-01-29 07:46 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/8f8750fe8c0e 8217609: New era placeholder not recognized by java.text.SimpleDateFormat Reviewed-by: nishjain, rriggs ! make/jdk/src/classes/build/tools/cldrconverter/CalendarType.java ! src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ja.xml ! src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/root.xml ! test/jdk/java/util/Calendar/JapaneseEraNameTest.java Changeset: 30892e0c9533 Author: goetz Date: 2019-03-06 08:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/30892e0c9533 Merge Changeset: 82b514d4e160 Author: gziemski Date: 2019-02-28 10:55 -0600 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/82b514d4e160 8219789: [TESTBUG] TestOptionsWithRanges.java produces hs_err_pidXXXXX.log file for VMThreadStackSize=9007199254740991 Summary: Excluded test of mac range for VMThreadStackSize Reviewed-by: coleenp, mseledtsov ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java Changeset: be6cffae4371 Author: goetz Date: 2019-03-06 16:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/be6cffae4371 8219651: compiler/ciReplay/TestServerVM.java is failing on windows Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java Changeset: baa2771d8104 Author: stuefe Date: 2019-02-28 14:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/baa2771d8104 8219650: [Testbug] Fix potential crashes in new test hotspot gtest "test_print_hex_dump" Reviewed-by: clanger, shade ! src/hotspot/share/runtime/os.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: d17a1764a0f3 Author: sgehwolf Date: 2019-03-07 16:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d17a1764a0f3 8220283: ZGC fails to build on GCC 4.4.7: ATTRIBUTE_ALIGNED compatibility issue Reviewed-by: shade, kbarrett ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: 36fc0ee64531 Author: goetz Date: 2019-03-13 07:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/36fc0ee64531 Added tag jdk-11.0.3+3 for changeset d17a1764a0f3 ! .hgtags Changeset: d4520549a0b8 Author: shade Date: 2019-03-13 18:39 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d4520549a0b8 Merge ! .hgtags ! src/hotspot/share/runtime/os.cpp From zgu at redhat.com Thu Mar 14 15:37:15 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Thu, 14 Mar 2019 11:37:15 -0400 Subject: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk Message-ID: Please review this patch that provides best-effort implementation of live regions iteration for Shenandoah GC. There are minor changes in shared code, to adjust oop offset from base of allocation cell. Bug: https://bugs.openjdk.java.net/browse/JDK-8220602 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220602/webrev.00/index.html Test: hotspot_gc_shenandoah hotspot_serviceability vmTestbase/nsk/jdb manual test: jhsdb hsdb on Linux x64 Passed submit test. Thanks, -Zhengyu From rkennke at redhat.com Thu Mar 14 16:21:05 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 14 Mar 2019 17:21:05 +0100 Subject: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk In-Reply-To: References: Message-ID: Hi Zhengyu, > Please review this patch that provides best-effort implementation of > live regions iteration for Shenandoah GC. > > There are minor changes in shared code, to adjust oop offset from base > of allocation cell. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220602 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8220602/webrev.00/index.html > > > Test: > ? hotspot_gc_shenandoah > ? hotspot_serviceability > ? vmTestbase/nsk/jdb > ? manual test: jhsdb hsdb > ? on Linux x64 > > ? Passed submit test. It looks mostly ok. But why do we need the change in CollectedHeap? Why not keep this an impl detail of Shenandoah heap? Roman From zgu at redhat.com Thu Mar 14 16:52:36 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Thu, 14 Mar 2019 12:52:36 -0400 Subject: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk In-Reply-To: References: Message-ID: <4c6c152f-66d2-c09c-2364-9c89089d633f@redhat.com> Hi Roman, Thanks for reviewing. >> ?? Passed submit test. > > It looks mostly ok. But why do we need the change in CollectedHeap? Why > not keep this an impl detail of Shenandoah heap? Because the region iteration code is in shared (ObjectHeap.java) Thanks, -Zhengyu > > Roman > From rkennke at redhat.com Thu Mar 14 17:46:05 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 14 Mar 2019 18:46:05 +0100 Subject: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk In-Reply-To: <4c6c152f-66d2-c09c-2364-9c89089d633f@redhat.com> References: <4c6c152f-66d2-c09c-2364-9c89089d633f@redhat.com> Message-ID: <382e4b54-6313-2029-0add-b80636d7f4da@redhat.com> Hi Zhengyu, >>> ?? Passed submit test. >> >> It looks mostly ok. But why do we need the change in CollectedHeap? >> Why not keep this an impl detail of Shenandoah heap? > > Because the region iteration code is in shared (ObjectHeap.java) Ah ok. I have a patch up my sleeve that eliminates the extra word ;-) But I suppose you should not wait for it (probably some weeks). Reviewed! Roman From zgu at redhat.com Thu Mar 14 17:51:15 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Thu, 14 Mar 2019 13:51:15 -0400 Subject: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk In-Reply-To: <382e4b54-6313-2029-0add-b80636d7f4da@redhat.com> References: <4c6c152f-66d2-c09c-2364-9c89089d633f@redhat.com> <382e4b54-6313-2029-0add-b80636d7f4da@redhat.com> Message-ID: <5bc4a0f7-11e2-fe58-842b-06f9b47262f6@redhat.com> On 3/14/19 1:46 PM, Roman Kennke wrote: > Hi Zhengyu, > >>>> ?? Passed submit test. >>> >>> It looks mostly ok. But why do we need the change in CollectedHeap? >>> Why not keep this an impl detail of Shenandoah heap? >> >> Because the region iteration code is in shared (ObjectHeap.java) > > > Ah ok. > > I have a patch up my sleeve that eliminates the extra word ;-) But I > suppose you should not wait for it (probably some weeks). Yep, we can revert this part once it arrives. Thanks, -Zhengyu > > Reviewed! > > Roman > From rkennke at redhat.com Thu Mar 14 18:03:49 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 14 Mar 2019 19:03:49 +0100 Subject: Fwd: Unsafe and jit bug Message-ID: <91aebf6f-5a4d-40d4-2956-3d18c93d0b8e@redhat.com> I believe I made a mistake in the list admin interface and accidentally dropped this email. Forwarding it manually. Roman -------- Weitergeleitete Nachricht -------- Betreff: Unsafe and jit bug Datum: Thu, 14 Mar 2019 20:18:59 +0300 Von: ????????? ??????? An: shenandoah-dev at openjdk.java.net Hi. Looking for shenandoah project for a long time, tried every new version, but still can't use it in out production. There is some sort of jit inlining bug when using Unsafe.get* methods which we are heavily using in production. I wroute a simpe test wich fails with shenandoah and runs smooth with every other option: 1) ?openjdk + any other gc ?= OK 2) ?openjdk + shenandoah + -XX:TieredStopAtLevel=1 = OK The problem (imho) is in insructions reordering at method NativIntArray.swap(): package test; import java.lang.reflect.Field; import java.util.ArrayList; import java.util.Collections; import java.util.Random; import sun.misc.Unsafe; public class Test { ??? private static final int TEST_ARRAY_SIZE = 1000000; ??? private static final long SEED = 0xDEADBEEFBEEFDEADL; ??? private static final Unsafe UNSAFE = getUnsafe(); ??? private static Unsafe getUnsafe() { ??????? try { ??????????? Field theUnsafe = Unsafe.class.getDeclaredField("theUnsafe"); ??????????? theUnsafe.setAccessible(true); ??????????? Unsafe unsafe = (Unsafe) theUnsafe.get(null); ??????????? return unsafe; ??????? } catch (NoSuchFieldException e) { ??????????? throw new RuntimeException(e); ??????? } catch (IllegalAccessException e) { ??????????? throw new RuntimeException(e); ??????? } ??? } ??? public static void main(String[] args) throws Exception { ??????? System.out.println("Test start"); ??????? for (int i = 0; i < 100; i++) { ??????????? test2(); ??????????? System.out.println(i + " iter passed"); ??????? } ??? } ??? private static void test2() throws Exception { ??????? final ArrayList reference = new ArrayList<>(); ??????? NativeIntArray arr = new NativeIntArray(TEST_ARRAY_SIZE); ??????? Random rnd = new Random(SEED); ??????? System.out.println("Filling arrays"); ??????? for (int i = 0; i < TEST_ARRAY_SIZE; i++) { ??????????? int value = rnd.nextInt(); ??????????? reference.add(value); ??????????? arr.set(i, value); ??????? } ??????? System.out.println("Testing random arrays"); ??????? for (int i = 0; i < TEST_ARRAY_SIZE; i++) { ??????????? final int value = arr.get(i); ??????????? final int refValue = reference.get(i); ??????????? if (value != refValue) { ??????????????? throw new Exception("Native array value doesn't matches " ??????????????????? + "reference: " + value + " <> " + refValue); ??????????? } ??????? } ??????? for (int i = 1; i < TEST_ARRAY_SIZE; i++) { ??????????? Collections.swap(reference, i - 1, i); ??????????? arr.swap(i - 1, i); ??????? } ??????? System.out.println("Testing sorted"); ??????? for (int i = 0; i < TEST_ARRAY_SIZE; i++) { ??????????? final int value = arr.get(i); ??????????? final int refValue = reference.get(i); ??????????? if (value != refValue) { ??????????????? throw new Exception("Native array value doesn't matches " ??????????????????? + "reference: " + value + " <> " + refValue); ??????????? } ??????? } ??? } ??? private static final class NativeIntArray { ??????? private final Memory mem; ? ? ? ?private volatile int fence; ??????? public NativeIntArray(final int size) { ??????????? mem = new Memory(size << 2); ??????? } ??????? public int get(final int index) { ??????????? return mem.getInt(index); ??????? } ??????? public void set(final int index, final int value) { ??????????? mem.setInt(index, value); ??????? } ? ? ? ?// The BUG is HERE :) ??????? public void swap(final int a, final int b) { ??????????? int tmp = mem.getInt(a); ? ? ? ? ? ?//Uncommenting the following line eliminates the problem ? ? ? ? ? ?//int fence = this.fence; ??????????? mem.setInt(a, mem.getInt(b)); ??????????? mem.setInt(b, tmp); ??????? } ??? } ??? private static final class Memory { ??????? private final long addr; ??????? Memory(final int size) { ??????????? addr = UNSAFE.allocateMemory(size); ??????? } ??????? public int getInt(final int index) { ??????????? return UNSAFE.getInt(addr + (index << 2)); ??????? } ??????? public void setInt(final int index, final int value) { ??????????? UNSAFE.putInt(addr + (index << 2), value); ??????? } ??? } } Could anyone take a professional look a this code please? Thanks a lot! From shade at redhat.com Fri Mar 15 07:56:11 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 15 Mar 2019 08:56:11 +0100 Subject: Fwd: Unsafe and jit bug In-Reply-To: <91aebf6f-5a4d-40d4-2956-3d18c93d0b8e@redhat.com> References: <91aebf6f-5a4d-40d4-2956-3d18c93d0b8e@redhat.com> Message-ID: On 3/14/19 7:03 PM, Roman Kennke wrote: > Could anyone take a professional look a this code please? > Thanks a lot! So far we believe this is genuine/generic C2 bug that is exposed by Shenandoah, and which leads to miscompilation of off-heap Unsafe accesses. Roman has a candidate fix for it, stay tuned. -Aleksey From shade at redhat.com Fri Mar 15 09:10:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 15 Mar 2019 10:10:53 +0100 Subject: RFR (XS) 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled Message-ID: <46f57682-8127-81ef-038b-fee4b5ac2762@redhat.com> Testbug: https://bugs.openjdk.java.net/browse/JDK-8220712 Fix: diff -r 1def2d745747 -r 64c61d4df33c test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java --- a/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Mon Mar 11 17:34:23 2019 +0530 +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Fri Mar 15 10:05:45 2019 +0100 @@ -28,7 +28,12 @@ * @requires vm.gc.Shenandoah * @modules java.base/jdk.internal.misc:+open * - * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation TestMaybeNullUnsafeAccess + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation + * TestMaybeNullUnsafeAccess + * + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation + * -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC + * TestMaybeNullUnsafeAccess * */ Testing: gc/shenandoah/compiler/ (includes the affected test) on Linux x86_64 {fastdebug|release} Thanks, -Aleksey From shade at redhat.com Fri Mar 15 09:36:00 2019 From: shade at redhat.com (shade at redhat.com) Date: Fri, 15 Mar 2019 09:36:00 +0000 Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.3+3 for changeset d4520549a0b8 Message-ID: <201903150936.x2F9a0uo028810@aojmv0008.oracle.com> Changeset: 88c1cf3c8ac9 Author: shade Date: 2019-03-15 10:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/88c1cf3c8ac9 Added tag shenandoah-jdk-11.0.3+3 for changeset d4520549a0b8 ! .hgtags From rkennke at redhat.com Fri Mar 15 11:41:24 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 15 Mar 2019 12:41:24 +0100 Subject: Fwd: Unsafe and jit bug In-Reply-To: References: <91aebf6f-5a4d-40d4-2956-3d18c93d0b8e@redhat.com> Message-ID: <7b59f3a1-5e9d-d1e7-a252-88c384849760@redhat.com> >> Could anyone take a professional look a this code please? >> Thanks a lot! > > So far we believe this is genuine/generic C2 bug that is exposed by Shenandoah, and which leads to > miscompilation of off-heap Unsafe accesses. Roman has a candidate fix for it, stay tuned. > Tracked under: https://bugs.openjdk.java.net/browse/JDK-8220714 Proposed fix and some additional analysis: https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-March/033172.html Thanks for reporing the bug! Roman From rkennke at redhat.com Fri Mar 15 11:57:32 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 15 Mar 2019 12:57:32 +0100 Subject: RFR (XS) 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled In-Reply-To: <46f57682-8127-81ef-038b-fee4b5ac2762@redhat.com> References: <46f57682-8127-81ef-038b-fee4b5ac2762@redhat.com> Message-ID: <38818552-e2df-dca4-5de9-75eba4d2fce0@redhat.com> Yes. (Duh?) Roman > Testbug: > https://bugs.openjdk.java.net/browse/JDK-8220712 > > Fix: > > diff -r 1def2d745747 -r 64c61d4df33c > test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java > --- a/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Mon Mar 11 17:34:23 > 2019 +0530 > +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Fri Mar 15 10:05:45 > 2019 +0100 > @@ -28,7 +28,12 @@ > * @requires vm.gc.Shenandoah > * @modules java.base/jdk.internal.misc:+open > * > - * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation > TestMaybeNullUnsafeAccess > + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation > + * TestMaybeNullUnsafeAccess > + * > + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation > + * -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC > + * TestMaybeNullUnsafeAccess > * > */ > > Testing: gc/shenandoah/compiler/ (includes the affected test) on Linux x86_64 {fastdebug|release} > > Thanks, > -Aleksey > From shade at redhat.com Fri Mar 15 12:02:03 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 15 Mar 2019 13:02:03 +0100 Subject: RFR (XS) 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled In-Reply-To: <38818552-e2df-dca4-5de9-75eba4d2fce0@redhat.com> References: <46f57682-8127-81ef-038b-fee4b5ac2762@redhat.com> <38818552-e2df-dca4-5de9-75eba4d2fce0@redhat.com> Message-ID: Going to push this under triviality rules, okay? -Aleksey On 3/15/19 12:57 PM, Roman Kennke wrote: > Yes. (Duh?) > > Roman > > >> Testbug: >> ?? https://bugs.openjdk.java.net/browse/JDK-8220712 >> >> Fix: >> >> diff -r 1def2d745747 -r 64c61d4df33c >> test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java >> --- a/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java? Mon Mar 11 17:34:23 >> 2019 +0530 >> +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java? Fri Mar 15 10:05:45 >> 2019 +0100 >> @@ -28,7 +28,12 @@ >> ?? * @requires vm.gc.Shenandoah >> ?? * @modules java.base/jdk.internal.misc:+open >> ?? * >> - * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >> TestMaybeNullUnsafeAccess >> + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >> + *?????????????????? TestMaybeNullUnsafeAccess >> + * >> + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >> + *?????????????????? -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC >> + *?????????????????? TestMaybeNullUnsafeAccess >> ?? * >> ?? */ >> >> Testing: gc/shenandoah/compiler/ (includes the affected test) on Linux x86_64 {fastdebug|release} >> >> Thanks, >> -Aleksey >> From rkennke at redhat.com Fri Mar 15 12:07:53 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 15 Mar 2019 13:07:53 +0100 Subject: RFR (XS) 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled In-Reply-To: References: <46f57682-8127-81ef-038b-fee4b5ac2762@redhat.com> <38818552-e2df-dca4-5de9-75eba4d2fce0@redhat.com> Message-ID: <56ca4d93-9d0b-e763-b302-00cc189fbccb@redhat.com> Sure, ok! Roman > Going to push this under triviality rules, okay? > > -Aleksey > > On 3/15/19 12:57 PM, Roman Kennke wrote: >> Yes. (Duh?) >> >> Roman >> >> >>> Testbug: >>> ?? https://bugs.openjdk.java.net/browse/JDK-8220712 >>> >>> Fix: >>> >>> diff -r 1def2d745747 -r 64c61d4df33c >>> test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java >>> --- a/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java? Mon Mar 11 17:34:23 >>> 2019 +0530 >>> +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java? Fri Mar 15 10:05:45 >>> 2019 +0100 >>> @@ -28,7 +28,12 @@ >>> ?? * @requires vm.gc.Shenandoah >>> ?? * @modules java.base/jdk.internal.misc:+open >>> ?? * >>> - * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >>> TestMaybeNullUnsafeAccess >>> + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >>> + *?????????????????? TestMaybeNullUnsafeAccess >>> + * >>> + * @run main/othervm -XX:-UseOnStackReplacement -XX:-BackgroundCompilation -XX:-TieredCompilation >>> + *?????????????????? -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC >>> + *?????????????????? TestMaybeNullUnsafeAccess >>> ?? * >>> ?? */ >>> >>> Testing: gc/shenandoah/compiler/ (includes the affected test) on Linux x86_64 {fastdebug|release} >>> >>> Thanks, >>> -Aleksey >>> > > From rkennke at redhat.com Fri Mar 15 21:48:59 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 15 Mar 2019 22:48:59 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u Message-ID: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> This backports outstanding changes from mid-Dec to ~now from shenandoah/jdk11 to shenandoah/jdk8u. Find the list of changes here: http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/changes.txt The full webrev: http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.00/ Disregard the C2 parts (under src/share/vm/opto) here. This backport contains a rather huge refactoring and reshaping of the barrier expansion code. It should now match (for the most part) what we have in jdk11+. Differences are: ripped-out loop-strip-mining, a couple of jdk8u specific idiosyncrasies (e.g. new (C) XYZNode), and for now split-if optimization path is disabled (I assume Roland is working on it and we might turn it on in a follow-up patch): http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev-c2barriershape/ This one needs careful reviewing and also testing. It is a somewhat risky change, but sortof necessary. Overall I believe it reduces our upstream exposure, and makes our backporting story much better. It also prepares the way for LRB which will arrive ... at some point ;-) Roman From shade at redhat.com Sat Mar 16 09:37:50 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Sat, 16 Mar 2019 10:37:50 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u In-Reply-To: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> References: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> Message-ID: <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> On 3/15/19 10:48 PM, Roman Kennke wrote: > This backports outstanding changes from mid-Dec to ~now from shenandoah/jdk11 to shenandoah/jdk8u. > > Find the list of changes here: > http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/changes.txt > > The full webrev: > http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.00/ *) This comment seem superfluous: 57 if (os::create_thread(this, os::cgc_thread)) { 58 // XXX: need to set this to low priority 59 // unless "agressive mode" set; priority 60 // should be just less than that of VMThread. 61 os::set_priority(this, ShenandoahCriticalControlThreadPriority ? CriticalPriority : NearMaxPriority); 62 if (!_should_terminate && !DisableStartThread) { 63 os::start_thread(this); 64 } 65 } *) Indenting is weird here: 58 template 59 void BufferedOverflowTaskQueue::clear() { 60 _buf_empty = true; 61 taskqueue_t::set_empty(); 62 taskqueue_t::overflow_stack()->clear(); 63 } *) Do we have "commonming" typo in other versions? 391 experimental(bool, ShenandoahCommonGCStateLoads, false, \ 392 "Enable commonming for GC state loads in generated code.") \ *) Asserts seem excessive here, already under UseShenandoahGC branch: 2349 #if INCLUDE_ALL_GCS 2350 if (UseShenandoahGC) { 2351 if (mode == LoopOptsShenandoahExpand) { 2352 assert(UseShenandoahGC, "only for shenandoah"); 2353 ShenandoahWriteBarrierNode::pin_and_expand(this); 2354 } else if (mode == LoopOptsShenandoahPostExpand) { 2355 assert(UseShenandoahGC, "only for shenandoah"); 2356 visited.Clear(); 2357 ShenandoahWriteBarrierNode::optimize_after_expansion(visited, nstack, worklist, this); 2358 } Otherwise looks good. I haven't reviewed C2 parts carefully. -Aleksey From rkennke at redhat.com Sat Mar 16 10:36:35 2019 From: rkennke at redhat.com (Roman Kennke) Date: Sat, 16 Mar 2019 11:36:35 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u In-Reply-To: <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> References: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> Message-ID: Hi Aleksey, Thanks for reviewing! Some comments below: > On 3/15/19 10:48 PM, Roman Kennke wrote: >> This backports outstanding changes from mid-Dec to ~now from shenandoah/jdk11 to shenandoah/jdk8u. >> >> Find the list of changes here: >> http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/changes.txt >> >> The full webrev: >> http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.00/ > > *) This comment seem superfluous: > > 57 if (os::create_thread(this, os::cgc_thread)) { > 58 // XXX: need to set this to low priority > 59 // unless "agressive mode" set; priority > 60 // should be just less than that of VMThread. > 61 os::set_priority(this, ShenandoahCriticalControlThreadPriority ? CriticalPriority : > NearMaxPriority); > 62 if (!_should_terminate && !DisableStartThread) { > 63 os::start_thread(this); > 64 } > 65 } I removed this. > *) Indenting is weird here: > > 58 template > 59 void BufferedOverflowTaskQueue::clear() { > 60 _buf_empty = true; > 61 taskqueue_t::set_empty(); > 62 taskqueue_t::overflow_stack()->clear(); > 63 } Yeah. It's also present in newer code. This warrants fwd-porting. > *) Do we have "commonming" typo in other versions? > > 391 experimental(bool, ShenandoahCommonGCStateLoads, false, \ > 392 "Enable commonming for GC state loads in generated code.") \ Yes, indeed. This also should be fwd ported. > *) Asserts seem excessive here, already under UseShenandoahGC branch: > > 2349 #if INCLUDE_ALL_GCS > 2350 if (UseShenandoahGC) { > 2351 if (mode == LoopOptsShenandoahExpand) { > 2352 assert(UseShenandoahGC, "only for shenandoah"); > 2353 ShenandoahWriteBarrierNode::pin_and_expand(this); > 2354 } else if (mode == LoopOptsShenandoahPostExpand) { > 2355 assert(UseShenandoahGC, "only for shenandoah"); > 2356 visited.Clear(); > 2357 ShenandoahWriteBarrierNode::optimize_after_expansion(visited, nstack, worklist, this); > 2358 } Newer versions don't have 'UseShenandoahGC' around the part, but should only ever executed (as asserted). I suggest we either remove the if (UseShenandoahGC) in 8, or add it to later versions. Or maybe just remove the assert in 8 and live with the difference? What do you think? > Otherwise looks good. I haven't reviewed C2 parts carefully. Updated webrev (haven't updated the C2 part): http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.01/ Roman From shade at redhat.com Mon Mar 18 09:07:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 18 Mar 2019 10:07:53 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u In-Reply-To: References: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> Message-ID: <952350be-0904-a280-db31-3b7d47facec0@redhat.com> On 3/16/19 11:36 AM, Roman Kennke wrote: >> *) Asserts seem excessive here, already under UseShenandoahGC branch: >> >> 2349 #if INCLUDE_ALL_GCS >> 2350?? if (UseShenandoahGC) { >> 2351???? if (mode == LoopOptsShenandoahExpand) { >> 2352?????? assert(UseShenandoahGC, "only for shenandoah"); >> 2353?????? ShenandoahWriteBarrierNode::pin_and_expand(this); >> 2354???? } else if (mode == LoopOptsShenandoahPostExpand) { >> 2355?????? assert(UseShenandoahGC, "only for shenandoah"); >> 2356?????? visited.Clear(); >> 2357?????? ShenandoahWriteBarrierNode::optimize_after_expansion(visited, nstack, worklist, this); >> 2358???? } > > Newer versions don't have 'UseShenandoahGC' around the part, but should only ever executed (as > asserted). I suggest we either remove the if (UseShenandoahGC) in 8, or add it to later versions. Or > maybe just remove the assert in 8 and live with the difference? What do you think? Nah, leave the assert as is. It is more important that the block contents are visually the same, even if it is doing excessive work for debug builds. -Aleksey From rkennke at redhat.com Mon Mar 18 15:17:50 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 18 Mar 2019 16:17:50 +0100 Subject: RFR: JDK-8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap_at ignores AS_NO_KEEPALIVE Message-ID: Aleksey discovered that we're ignoring AS_NO_KEEPALIVE for oop-stores. This is bad because it means we do extra processing for no good reason (enqueueing stuff in SATB) and worst case, keep stuff alive that we shouldn't. Bug: https://bugs.openjdk.java.net/browse/JDK-8220780 Cure: http://cr.openjdk.java.net/~rkennke/JDK-8220780/webrev.00/ Passes hotspot_gc_shenandoah Good to push? Roman From shade at redhat.com Mon Mar 18 15:27:05 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 18 Mar 2019 16:27:05 +0100 Subject: RFR: JDK-8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap_at ignores AS_NO_KEEPALIVE In-Reply-To: References: Message-ID: <4156cb5c-4b63-0812-64d0-edd826c4ffbb@redhat.com> On 3/18/19 4:17 PM, Roman Kennke wrote: > Aleksey discovered that we're ignoring AS_NO_KEEPALIVE for oop-stores. > This is bad because it means we do extra processing for no good reason > (enqueueing stuff in SATB) and worst case, keep stuff alive that we > shouldn't. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8220780 > Cure: > http://cr.openjdk.java.net/~rkennke/JDK-8220780/webrev.00/ Seems fine. -Aleksey From zgu at redhat.com Mon Mar 18 17:14:13 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Mon, 18 Mar 2019 13:14:13 -0400 Subject: [12u] 8220546: Shenandoah Reports timing details for weak root processing Message-ID: Please review this 12u backport. The patch did not apply cleanly, as string table is not processed by WeakProcessor in 12u. Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/8b61a38be0c5 Original review: https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-March/025070.html JDK12u webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546_12u/webrev.00/ Test: hotspot_gc_shenandoah on Linux 64. Thanks, -Zhengyu From rkennke at redhat.com Mon Mar 18 20:26:29 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 18 Mar 2019 21:26:29 +0100 Subject: Backports to sh/jdk1 2019-03-18 Message-ID: <75441b2f-da5b-8400-8eb9-404cabb0b8b7@redhat.com> This backports recent changes from jdk12 to sh/jdk11 (it's not all that much, but includes the important hugeTLBFS fixes by Aleksey): http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/changes.txt Full webrev: http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/webrev.00/ Backports was based for the first time on the awesomesauce backports monitor: https://builds.shipilev.net/backports-monitor/label-gc-shenandoah.txt Testing: passes hotspot_gc_shenandoah Good to push? Roman From shade at redhat.com Mon Mar 18 21:06:59 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 18 Mar 2019 22:06:59 +0100 Subject: Backports to sh/jdk1 2019-03-18 In-Reply-To: <75441b2f-da5b-8400-8eb9-404cabb0b8b7@redhat.com> References: <75441b2f-da5b-8400-8eb9-404cabb0b8b7@redhat.com> Message-ID: <321d11bd-44a5-a10d-34e2-5f4e33eeae01@redhat.com> On 3/18/19 9:26 PM, Roman Kennke wrote: > Full webrev: > http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/webrev.00/ Looks good. *) I checked that +UseTransparentHugePages and +UseLargePages work fine on my examples. *) Also diff'ed ShenandoahHeap::initialize with jdk12 version, and there is a teeny-tiny difference here: 141 size_t init_byte_size = collector_policy()->initial_heap_byte_size(); 142 size_t max_byte_size = collector_policy()->max_heap_byte_size(); 143 size_t heap_alignment = collector_policy()->heap_alignment(); L142 is aligned by "=" in jdk12 and jdk/jdk. *) This line should probably be moved from "Figure out heap sizing" block to "Initialize the rest of GC subsystems". hotspot_gc_shenandoah has to pass after this move :) 152 BarrierSet::set_barrier_set(new ShenandoahBarrierSet(this)); Thanks, -Aleksey From rkennke at redhat.com Mon Mar 18 21:40:13 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 18 Mar 2019 22:40:13 +0100 Subject: Backports to sh/jdk1 2019-03-18 In-Reply-To: <321d11bd-44a5-a10d-34e2-5f4e33eeae01@redhat.com> References: <75441b2f-da5b-8400-8eb9-404cabb0b8b7@redhat.com> <321d11bd-44a5-a10d-34e2-5f4e33eeae01@redhat.com> Message-ID: >> Full webrev: >> http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/webrev.00/ > > Looks good. > > *) I checked that +UseTransparentHugePages and +UseLargePages work fine on my examples. > > *) Also diff'ed ShenandoahHeap::initialize with jdk12 version, and there is a teeny-tiny difference > here: > > 141 size_t init_byte_size = collector_policy()->initial_heap_byte_size(); > 142 size_t max_byte_size = collector_policy()->max_heap_byte_size(); > 143 size_t heap_alignment = collector_policy()->heap_alignment(); > > L142 is aligned by "=" in jdk12 and jdk/jdk. > > *) This line should probably be moved from "Figure out heap sizing" block to "Initialize the rest of > GC subsystems". hotspot_gc_shenandoah has to pass after this move :) > > 152 BarrierSet::set_barrier_set(new ShenandoahBarrierSet(this)); http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/webrev.01/ Still passes hotspot_gc_shenandoah. From shade at redhat.com Mon Mar 18 21:41:35 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 18 Mar 2019 22:41:35 +0100 Subject: Backports to sh/jdk1 2019-03-18 In-Reply-To: References: <75441b2f-da5b-8400-8eb9-404cabb0b8b7@redhat.com> <321d11bd-44a5-a10d-34e2-5f4e33eeae01@redhat.com> Message-ID: <31b79f0e-8682-dea6-3a6b-3a06dc371630@redhat.com> On 3/18/19 10:40 PM, Roman Kennke wrote: > http://cr.openjdk.java.net/~rkennke/backports-jdk11-2019-03-18/webrev.01/ Thumbs up. -Aleksey From roman at kennke.org Mon Mar 18 21:43:31 2019 From: roman at kennke.org (roman at kennke.org) Date: Mon, 18 Mar 2019 21:43:31 +0000 Subject: hg: shenandoah/jdk11: 4 new changesets Message-ID: <201903182143.x2ILhWUD004880@aojmv0008.oracle.com> Changeset: 12cd9c6cc4c6 Author: zgu Date: 2018-09-19 16:51 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/12cd9c6cc4c6 [backport] 8210879: ClassLoaderStatsClosure does raw oop comparison Summary: Uses oopDesc::equals() for comparing oop equality Reviewed-by: shade ! src/hotspot/share/classfile/classLoaderStats.hpp Changeset: dc3b5ecee99d Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/dc3b5ecee99d [backport] 8220350: Refactor ShenandoahHeap::initialize Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp Changeset: 4844e39fd027 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/4844e39fd027 [backport] 8220153: Shenandoah does not work with TransparentHugePages properly Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: d1ab5dde2330 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/d1ab5dde2330 [backport] 8220162: Shenandoah should not commit HugeTLBFS memory Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp From rkennke at redhat.com Tue Mar 19 14:18:03 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 19 Mar 2019 15:18:03 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u In-Reply-To: <952350be-0904-a280-db31-3b7d47facec0@redhat.com> References: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> <952350be-0904-a280-db31-3b7d47facec0@redhat.com> Message-ID: After some more testing, we decided to cut out the C2 barrier reshapings. This requires more work, and we don't want to hold back the other stuff. Changes summary: http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/changes.txt Full webrev: http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.02/ Mercurial patch queue: http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/jdk8u-backports.tar.gz WDYT now? Roman > On 3/16/19 11:36 AM, Roman Kennke wrote: >>> *) Asserts seem excessive here, already under UseShenandoahGC branch: >>> >>> 2349 #if INCLUDE_ALL_GCS >>> 2350?? if (UseShenandoahGC) { >>> 2351???? if (mode == LoopOptsShenandoahExpand) { >>> 2352?????? assert(UseShenandoahGC, "only for shenandoah"); >>> 2353?????? ShenandoahWriteBarrierNode::pin_and_expand(this); >>> 2354???? } else if (mode == LoopOptsShenandoahPostExpand) { >>> 2355?????? assert(UseShenandoahGC, "only for shenandoah"); >>> 2356?????? visited.Clear(); >>> 2357?????? ShenandoahWriteBarrierNode::optimize_after_expansion(visited, nstack, worklist, this); >>> 2358???? } >> >> Newer versions don't have 'UseShenandoahGC' around the part, but should only ever executed (as >> asserted). I suggest we either remove the if (UseShenandoahGC) in 8, or add it to later versions. Or >> maybe just remove the assert in 8 and live with the difference? What do you think? > > Nah, leave the assert as is. It is more important that the block contents are visually the same, > even if it is doing excessive work for debug builds. > > -Aleksey > From shade at redhat.com Tue Mar 19 14:20:11 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 19 Mar 2019 15:20:11 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u In-Reply-To: References: <73339e36-414e-4311-c6a7-147e14596f9d@redhat.com> <2d04c77e-122f-d093-d43b-9d4599de6493@redhat.com> <952350be-0904-a280-db31-3b7d47facec0@redhat.com> Message-ID: On 3/19/19 3:18 PM, Roman Kennke wrote: > After some more testing, we decided to cut out the C2 barrier reshapings. This requires more work, > and we don't want to hold back the other stuff. > > Changes summary: > http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/changes.txt > > Full webrev: > http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/webrev.02/ > > Mercurial patch queue: > http://cr.openjdk.java.net/~rkennke/backports-sh-jdk8-2019-03-15/jdk8u-backports.tar.gz Looks good, let's do it. -Aleksey From roman at kennke.org Tue Mar 19 14:27:07 2019 From: roman at kennke.org (roman at kennke.org) Date: Tue, 19 Mar 2019 14:27:07 +0000 Subject: hg: shenandoah/jdk8u/hotspot: 11 new changesets Message-ID: <201903191427.x2JER7qo001735@aojmv0008.oracle.com> Changeset: 0f47e6f7b68b Author: zgu Date: 2018-12-14 08:20 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/0f47e6f7b68b [backport] Simplify Shenandoah task termination in aborted paths ! src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.inline.hpp Changeset: 9e51a475f478 Author: rkennke Date: 2019-01-08 20:12 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/9e51a475f478 [backport] Remove obsolete code snippet related to barriers on constants ! src/share/vm/opto/subnode.cpp Changeset: c1ac14fc153a Author: zgu Date: 2019-01-17 08:48 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/c1ac14fc153a [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file Reviewed-by: shade, tschatzl ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.inline.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.cpp Changeset: a998d3f2aa0c Author: vlivanov Date: 2019-01-18 17:34 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/a998d3f2aa0c [backport] 8217400: Optimized build is broken by Shenandoah changes Reviewed-by: shade ! src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp Changeset: da578e70b457 Author: rkennke Date: 2019-01-14 12:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/da578e70b457 [backport] 8216973: Kick up cleanup phases in the right places Reviewed-by: shade ! src/share/vm/gc_implementation/shenandoah/shenandoahControlThread.cpp Changeset: ed4bc1ad98dd Author: zgu Date: 2019-01-18 09:10 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/ed4bc1ad98dd [backport] 8217319: Cleanup Shenandoah includes Reviewed-by: shade ! src/share/vm/gc_implementation/shenandoah/shenandoahAsserts.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahMetrics.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahPacer.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahStrDedupQueue.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahStringDedup.cpp Changeset: 7f156a0e5239 Author: shade Date: 2019-01-19 11:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/7f156a0e5239 [backport] 8217343: Shenandoah control thread should be able to run at critical priority Reviewed-by: rkennke ! src/share/vm/gc_implementation/shenandoah/shenandoahControlThread.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoah_globals.hpp + test/gc/shenandoah/options/TestCriticalControlThreadPriority.java Changeset: 2363320932c5 Author: shade Date: 2019-02-21 15:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/2363320932c5 [backport] 8219524: Shenandoah misreports "committed" size in MemoryMXBean Reviewed-by: rkennke, zgu ! src/share/vm/services/shenandoahMemoryPool.cpp ! test/gc/shenandoah/mxbeans/TestMemoryMXBeans.java Changeset: 66f26cc91500 Author: zgu Date: 2019-02-28 08:44 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/66f26cc91500 [backport] 8219857: Shenandoah GC may initialize thread's gclab twice Reviewed-by: rkennke ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp Changeset: 31f411e81d42 Author: zgu Date: 2019-03-02 08:33 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/31f411e81d42 [backport] 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah Reviewed-by: rkennke ! src/share/vm/gc_implementation/shenandoah/shenandoahUtils.cpp Changeset: f671405d9687 Author: shade Date: 2019-03-07 10:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/f671405d9687 [backport] 8220228: Improve Shenandoah pacing histogram message Reviewed-by: rkennke ! src/share/vm/gc_implementation/shenandoah/shenandoahPacer.cpp From rkennke at redhat.com Tue Mar 19 15:17:19 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 19 Mar 2019 16:17:19 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u 2019-03-19 Message-ID: <1bacdf78-b4d6-be1e-68af-6079105109ca@redhat.com> This backports recent stuff (mostly hugetlbfs/THP stuff) from sh/jdk11 to sh/jdk8u. Major difference is that os::pretouch_memory() doesn't take page_size but defaults to vm_page_size instead. List of changes: http://cr.openjdk.java.net/~rkennke/backports-jdk8-2019-03-19/changes.txt Full webrev: http://cr.openjdk.java.net/~rkennke/backports-jdk8-2019-03-19/webrev.00/ Testing: hotspot_gc_shenandoah all fine Good? Roman From shade at redhat.com Tue Mar 19 16:29:32 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 19 Mar 2019 17:29:32 +0100 Subject: RFR: Bulk backports sh/jdk11 -> sh/jdk8u 2019-03-19 In-Reply-To: <1bacdf78-b4d6-be1e-68af-6079105109ca@redhat.com> References: <1bacdf78-b4d6-be1e-68af-6079105109ca@redhat.com> Message-ID: <28b77f46-420f-4141-a596-5b0238172a0b@redhat.com> On 3/19/19 4:17 PM, Roman Kennke wrote: > Full webrev: > http://cr.openjdk.java.net/~rkennke/backports-jdk8-2019-03-19/webrev.00/ Looks good! I again spot-checked -XX:+UseTransparentHugePages and -XX:+UseLargePages work fine on my examples. -Aleksey From roman at kennke.org Tue Mar 19 16:36:32 2019 From: roman at kennke.org (roman at kennke.org) Date: Tue, 19 Mar 2019 16:36:32 +0000 Subject: hg: shenandoah/jdk8u/hotspot: 4 new changesets Message-ID: <201903191636.x2JGaWsv018383@aojmv0008.oracle.com> Changeset: b7ac331c87d1 Author: zgu Date: 2018-09-19 16:51 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/b7ac331c87d1 [backport] 8210879: ClassLoaderStatsClosure does raw oop comparison Summary: Uses oopDesc::equals() for comparing oop equality Reviewed-by: shade ! src/share/vm/classfile/classLoaderStats.hpp Changeset: 03448f15a87d Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/03448f15a87d [backport] 8220350: Refactor ShenandoahHeap::initialize Reviewed-by: rkennke, zgu ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.inline.hpp Changeset: 3a8f37171aca Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/3a8f37171aca [backport] 8220153: Shenandoah does not work with TransparentHugePages properly Reviewed-by: rkennke, zgu ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp Changeset: bf9717f3e53b Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot/rev/bf9717f3e53b [backport] 8220162: Shenandoah should not commit HugeTLBFS memory Reviewed-by: rkennke, zgu ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp ! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp From rkennke at redhat.com Tue Mar 19 18:23:38 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 19 Mar 2019 19:23:38 +0100 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 Message-ID: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> JDK-8220671: Initialization race for non-JavaThread PtrQueue is making troubles in Shenandoah's testing. While we're working out a generally acceptable solution, we need a usable workaround in Shenandoah. Bug: https://bugs.openjdk.java.net/browse/JDK-8221086 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ The proposed fix places a SuspendibleThreadJoiner around the on_thread_attach() and on_thread_detach(), thereby preventing the race. As soon as we figured out a solution for JDK-8220671 (which may well be this 'workaround') we shall revert/overwrite this change. Testing: many rounds of hotspot_gc_shenandoah and even more rounds of the offending TestStringDedupStress. Ok? Roman From shade at redhat.com Tue Mar 19 18:30:25 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 19 Mar 2019 19:30:25 +0100 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 In-Reply-To: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> References: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> Message-ID: <044384ae-5a6c-3ef6-bd1c-c5fad68a627f@redhat.com> On 3/19/19 7:23 PM, Roman Kennke wrote: > Webrev: > http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ Code needs comment mentioning what is being worked around, e.g.: "// Join STS to workaround the initialization race, see JDK-8220671" Otherwise looks good. -Aleksey From rkennke at redhat.com Tue Mar 19 19:18:02 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 19 Mar 2019 20:18:02 +0100 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 In-Reply-To: References: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> Message-ID: <3dce9a71-0cbb-6760-ac60-1ff0a6e4785a@redhat.com> >> JDK-8220671: Initialization race for non-JavaThread PtrQueue is making >> troubles in Shenandoah's testing. While we're working out a generally >> acceptable solution, we need a usable workaround in Shenandoah. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8221086 >> Webrev: >> http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ >> >> The proposed fix places a SuspendibleThreadJoiner around the >> on_thread_attach() and on_thread_detach(), thereby preventing the race. >> >> As soon as we figured out a solution for JDK-8220671 (which may well be >> this 'workaround') we shall revert/overwrite this change. >> >> Testing: many rounds of hotspot_gc_shenandoah and even more rounds of >> the offending TestStringDedupStress. >> >> Ok? >> >> Roman > > I was expecting there to be some shared code changes here, and not a pure shenandoah > change. That's why I called it 'workaround'. It's not an all-inclusive solution. This allows others to make progress with their own patches. It's not helpful to have tests failing randomly for several days. Otherwise I'd have to ask you to back out the original JDK-8219613 ;-) This seems overkill. Also, having this run through our CI would give us some more confidence that the change is good (or not). > Doesn?t this have the same problem as your ?nope, needs coffee? proposal in the > main email thread from yesterday? The attach/list-add pair needs to be atomic wrto the > SATB state change, and this doesn?t cover the list-add. It does prevent the critical sections: 1. Global SATB flag change 2. New-thread SATB flag cache pickup to prevent from racing with each other, because it causes attaching threads to line up at safepoints if anything like that happens. The actual list addition doesn't seem to be problematic. Or is it? If you think it is, pls explain why? Also, probably take it back to the main thread then ;-) In any case, the testcase that used to fail once in ~5 runs has survived many dozens of runs now. Even if the fix is not complete and only covers up a deeper problem, it helps us to make progress with other stuff. Ok? Roman From kim.barrett at oracle.com Tue Mar 19 18:41:27 2019 From: kim.barrett at oracle.com (Kim Barrett) Date: Tue, 19 Mar 2019 14:41:27 -0400 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 In-Reply-To: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> References: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> Message-ID: > On Mar 19, 2019, at 2:23 PM, Roman Kennke wrote: > > JDK-8220671: Initialization race for non-JavaThread PtrQueue is making > troubles in Shenandoah's testing. While we're working out a generally > acceptable solution, we need a usable workaround in Shenandoah. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8221086 > Webrev: > http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ > > The proposed fix places a SuspendibleThreadJoiner around the > on_thread_attach() and on_thread_detach(), thereby preventing the race. > > As soon as we figured out a solution for JDK-8220671 (which may well be > this 'workaround') we shall revert/overwrite this change. > > Testing: many rounds of hotspot_gc_shenandoah and even more rounds of > the offending TestStringDedupStress. > > Ok? > > Roman I was expecting there to be some shared code changes here, and not a pure shenandoah change. Doesn?t this have the same problem as your ?nope, needs coffee? proposal in the main email thread from yesterday? The attach/list-add pair needs to be atomic wrto the SATB state change, and this doesn?t cover the list-add. From rkennke at redhat.com Tue Mar 19 19:36:56 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 19 Mar 2019 20:36:56 +0100 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 In-Reply-To: References: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> Message-ID: I'll investigate a little more... >> On Mar 19, 2019, at 2:23 PM, Roman Kennke wrote: >> >> JDK-8220671: Initialization race for non-JavaThread PtrQueue is making >> troubles in Shenandoah's testing. While we're working out a generally >> acceptable solution, we need a usable workaround in Shenandoah. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8221086 >> Webrev: >> http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ >> >> The proposed fix places a SuspendibleThreadJoiner around the >> on_thread_attach() and on_thread_detach(), thereby preventing the race. >> >> As soon as we figured out a solution for JDK-8220671 (which may well be >> this 'workaround') we shall revert/overwrite this change. >> >> Testing: many rounds of hotspot_gc_shenandoah and even more rounds of >> the offending TestStringDedupStress. >> >> Ok? >> >> Roman > > I was expecting there to be some shared code changes here, and not a pure shenandoah > change. Doesn?t this have the same problem as your ?nope, needs coffee? proposal in the > main email thread from yesterday? The attach/list-add pair needs to be atomic wrto the > SATB state change, and this doesn?t cover the list-add. > From kim.barrett at oracle.com Tue Mar 19 19:37:03 2019 From: kim.barrett at oracle.com (Kim Barrett) Date: Tue, 19 Mar 2019 15:37:03 -0400 Subject: RFR: JDK-8221086: Shenandoah-specific workaround for JDK-8220671 In-Reply-To: <3dce9a71-0cbb-6760-ac60-1ff0a6e4785a@redhat.com> References: <4e6933bf-bbbf-2b10-5a9f-1ac0c2a92139@redhat.com> <3dce9a71-0cbb-6760-ac60-1ff0a6e4785a@redhat.com> Message-ID: <409F5A00-2ABB-4B07-B040-9E4EB4830DC5@oracle.com> > On Mar 19, 2019, at 3:18 PM, Roman Kennke wrote: > >>> JDK-8220671: Initialization race for non-JavaThread PtrQueue is making >>> troubles in Shenandoah's testing. While we're working out a generally >>> acceptable solution, we need a usable workaround in Shenandoah. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8221086 >>> Webrev: >>> http://cr.openjdk.java.net/~rkennke/JDK-8221086/webrev.01/ >>> >>> The proposed fix places a SuspendibleThreadJoiner around the >>> on_thread_attach() and on_thread_detach(), thereby preventing the race. >>> >>> As soon as we figured out a solution for JDK-8220671 (which may well be >>> this 'workaround') we shall revert/overwrite this change. >>> >>> Testing: many rounds of hotspot_gc_shenandoah and even more rounds of >>> the offending TestStringDedupStress. >>> >>> Ok? >>> >>> Roman >> I was expecting there to be some shared code changes here, and not a pure shenandoah >> change. > > That's why I called it 'workaround'. It's not an all-inclusive solution. This allows others to make progress with their own patches. It's not helpful to have tests failing randomly for several days. Otherwise I'd have to ask you to back out the original JDK-8219613 ;-) This seems overkill. Also, having this run through our CI would give us some more confidence that the change is good (or not). > >> Doesn?t this have the same problem as your ?nope, needs coffee? proposal in the >> main email thread from yesterday? The attach/list-add pair needs to be atomic wrto the >> SATB state change, and this doesn?t cover the list-add. > > It does prevent the critical sections: > 1. Global SATB flag change > 2. New-thread SATB flag cache pickup > > to prevent from racing with each other, because it causes attaching threads to line up at safepoints if anything like that happens. The actual list addition doesn't seem to be problematic. Or is it? If you think it is, pls explain why? Also, probably take it back to the main thread then ;-) > > In any case, the testcase that used to fail once in ~5 runs has survived many dozens of runs now. Even if the fix is not complete and only covers up a deeper problem, it helps us to make progress with other stuff. Ok? > > Roman If it reduces noise in your CI enough to be useful to you, then I?ll withdraw from this (JDK-8221086) discussion. I?ll take further discussion of the approach over to the main thread. From shade at redhat.com Wed Mar 20 10:29:05 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 20 Mar 2019 11:29:05 +0100 Subject: Tuning ShenandoahGC with 420 GB heaps In-Reply-To: References: <85f97054-a769-83b6-8561-03da7e9acc89@redhat.com> <49d9e7ff-692d-8fea-02d7-0174167cc716@redhat.com> <423b251a-33d2-9584-afc8-cb788b76bafa@graven-ict.nl> <08c351f6-77b5-1d88-2274-18f7e7d600d6@redhat.com> <3595F90F-0273-4401-B1D2-C62D3F5303D0@graven-ict.nl> Message-ID: <9af6a878-cefb-a75a-5bb6-5e73c7153fdc@redhat.com> On 3/5/19 3:00 PM, Aleksey Shipilev wrote: > On 3/5/19 2:07 PM, Edwin Graven wrote: >> Okay so THP is a bug, is there any change it will be possible to use LargePages instead of THP >> like we do with G1?? If you can use LargePages there won?t be any risk of using swap. > Yes, except the teeny-tiny detail that hugetlbfs support is also broken (argh): > https://bugs.openjdk.java.net/browse/JDK-8220162 > > If everything goes right, patches would hit jdk/jdk (development head) this week, and Roman would > backport them to 11u and 8u next week. That took longer to figure out, but we have THP/LP fixes in 11u and 8u nightlies: https://builds.shipilev.net/openjdk-shenandoah-jdk11/ https://builds.shipilev.net/openjdk-shenandoah-jdk8/ You might want to try them. -Aleksey From shade at redhat.com Wed Mar 20 14:39:11 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 20 Mar 2019 15:39:11 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+4 to sh/jdk11 Message-ID: Upstream^W We have pushed the jdk-11.0.3+4 tag upstream to jdk-updates/jdk11u. Let's pick it up to sh/jdk11. The merge is not trivial, because AArch64 changes are in the same files. Summary of changes: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b4/changesets.txt Webrev: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b4/webrev.01/ You can cross-reference the changes with the changes in upstream: http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/43d6759c3b2e http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/33c0eba993dd http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/e58b6d05d723 http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/0402d1e99f13 http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/1bf93f4064ac http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/b3857fc867d7 The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+4. Testing: x86_64 hotspot_gc_shenandoah {fastdebug,release}, AArch64 build {fastdebug, release} Thanks, -Aleksey From rkennke at redhat.com Wed Mar 20 18:04:25 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 20 Mar 2019 19:04:25 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+4 to sh/jdk11 In-Reply-To: References: Message-ID: <5c5c5731-1228-c565-144b-fcab007f70c3@redhat.com> Looks good! Thanks! Roman > Upstream^W We have pushed the jdk-11.0.3+4 tag upstream to jdk-updates/jdk11u. Let's pick it up to > sh/jdk11. The merge is not trivial, because AArch64 changes are in the same files. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b4/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b4/webrev.01/ > > You can cross-reference the changes with the changes in upstream: > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/43d6759c3b2e > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/33c0eba993dd > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/e58b6d05d723 > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/0402d1e99f13 > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/1bf93f4064ac > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/b3857fc867d7 > > The plan is to push this merge, run it through nightlies and then tag it shenandoah-jdk-11.0.3+4. > > Testing: x86_64 hotspot_gc_shenandoah {fastdebug,release}, AArch64 build {fastdebug, release} > > Thanks, > -Aleksey > > From shade at redhat.com Wed Mar 20 18:13:38 2019 From: shade at redhat.com (shade at redhat.com) Date: Wed, 20 Mar 2019 18:13:38 +0000 Subject: hg: shenandoah/jdk11: 10 new changesets Message-ID: <201903201813.x2KIDeVY016646@aojmv0008.oracle.com> Changeset: 9954dc9308c2 Author: goetz Date: 2019-03-14 09:41 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/9954dc9308c2 Added tag jdk-11.0.3+0 for changeset 98e7354165d3 ! .hgtags Changeset: 0eaa2cfab40c Author: goetz Date: 2019-03-14 10:03 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/0eaa2cfab40c Merge ! .hgtags Changeset: b3857fc867d7 Author: sgehwolf Date: 2019-03-07 17:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/b3857fc867d7 8220294: ZGC fails to build on GCC 4.4.7: Type parameter issue Summary: Specify explicit type in the constructor Reviewed-by: shade, pliden ! src/hotspot/share/gc/z/zStat.cpp Changeset: 1bf93f4064ac Author: roland Date: 2018-10-04 09:24 +0200 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/1bf93f4064ac 8211320: Aarch64: unsafe.compareAndSetByte() and unsafe.compareAndSetShort() c2 intrinsics broken with negative expected value Reviewed-by: adinn, aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp + test/hotspot/jtreg/compiler/unsafe/CASandCAEwithNegExpected.java Changeset: 0402d1e99f13 Author: ngasson Date: 2019-03-12 10:48 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/0402d1e99f13 8216350: AArch64: monitor unlock fast path not called Reviewed-by: aph, drwhite, fyang ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp Changeset: e58b6d05d723 Author: fyang Date: 2019-01-05 10:48 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/e58b6d05d723 8215951: AArch64: jtreg test vmTestbase/nsk/jvmti/PopFrame/popframe005 segfaults Reviewed-by: aph Contributed-by: nick.gasson at arm.com ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp Changeset: 33c0eba993dd Author: aph Date: 2018-09-24 18:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/33c0eba993dd 8211064: [AArch64] Interpreter and c1 don't correctly handle jboolean results in native calls Reviewed-by: aph Contributed-by: andrey.petushkov at gmail.com ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp Changeset: 43d6759c3b2e Author: rraghavan Date: 2018-12-18 19:13 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/43d6759c3b2e 8211698: Crash in C2 compiled code during execution of double array heavy processing code Summary: Correctly registered new Opaque4Node in add_range_check_predicate Reviewed-by: roland, thartmann ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/node.cpp + test/hotspot/jtreg/compiler/loopopts/Test8211698.java Changeset: 16a3531cfc23 Author: goetz Date: 2019-03-20 08:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/16a3531cfc23 Added tag jdk-11.0.3+4 for changeset 43d6759c3b2e ! .hgtags Changeset: 25a1cef14fae Author: shade Date: 2019-03-20 15:26 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/25a1cef14fae Merge ! .hgtags ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/node.cpp From shade at redhat.com Thu Mar 21 18:02:41 2019 From: shade at redhat.com (shade at redhat.com) Date: Thu, 21 Mar 2019 18:02:41 +0000 Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.3+4 for changeset 25a1cef14fae Message-ID: <201903211802.x2LI2fdh016697@aojmv0008.oracle.com> Changeset: 6911cfdade55 Author: shade Date: 2019-03-21 19:02 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6911cfdade55 Added tag shenandoah-jdk-11.0.3+4 for changeset 25a1cef14fae ! .hgtags From rkennke at redhat.com Thu Mar 21 21:17:50 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 21 Mar 2019 22:17:50 +0100 Subject: RFR: JDK-8221278: Shenandoah should not enqueue string dedup candidates during root scan Message-ID: <9014b8bf-c6d0-6e8c-2d39-34166945747e@redhat.com> In Shenandoah, during the init-mark phase, we are scanning the StringDedup roots (queues and tables) when string deduplication is enabled. For this, we're using a closure that also enqueues dedup canidates. Which means that we may end up concurrently reading AND writing the queues, which leads to corruption. This seems to make the TestStringDedupStress occasionally crash. Bug: https://bugs.openjdk.java.net/browse/JDK-8221278 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8221278/webrev.00/ Proposed change is simple: Simply remove the ENQUEUE_DEDUP block and related template fluff from init-mark. It means that strings that are (only) reachable via local variables and such will not be string-dedup-candidates. So what? ;-) Testing: hotspot_gc_shenandoah fine. Failing test, amplified to fail more reliably, run in loop 30x, all good. Ok? Roman From shade at redhat.com Thu Mar 21 21:28:44 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 21 Mar 2019 22:28:44 +0100 Subject: RFR: JDK-8221278: Shenandoah should not enqueue string dedup candidates during root scan In-Reply-To: <9014b8bf-c6d0-6e8c-2d39-34166945747e@redhat.com> References: <9014b8bf-c6d0-6e8c-2d39-34166945747e@redhat.com> Message-ID: <27f5d22d-9b19-f45f-ae11-321983e0af8d@redhat.com> On 3/21/19 10:17 PM, Roman Kennke wrote: > Webrev: > http://cr.openjdk.java.net/~rkennke/JDK-8221278/webrev.00/ Looks good to me! Ugh. -Aleksey From rkennke at redhat.com Fri Mar 22 07:49:16 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 22 Mar 2019 08:49:16 +0100 Subject: RFR: Cherry-pick: JDK-8221278: Shenandoah should not enqueue string dedup candidates during root scan Message-ID: We need this in sh/jdk asap to get stable tests: http://cr.openjdk.java.net/~rkennke/JDK-8221278/webrev.00/ Ok? Roman From shade at redhat.com Fri Mar 22 07:57:53 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 22 Mar 2019 08:57:53 +0100 Subject: RFR: Cherry-pick: JDK-8221278: Shenandoah should not enqueue string dedup candidates during root scan In-Reply-To: References: Message-ID: <80dd2a6b-6300-ab81-aef1-d4c050fb4d10@redhat.com> On 3/22/19 8:49 AM, Roman Kennke wrote: > > We need this in sh/jdk asap to get stable tests: > > http://cr.openjdk.java.net/~rkennke/JDK-8221278/webrev.00/ > > Ok? OK -Aleksey From roman at kennke.org Fri Mar 22 08:50:55 2019 From: roman at kennke.org (roman at kennke.org) Date: Fri, 22 Mar 2019 08:50:55 +0000 Subject: hg: shenandoah/jdk: Cherry-pick: 8221278: Shenandoah should not enqueue string dedup candidates during root scan Message-ID: <201903220850.x2M8otmW006807@aojmv0008.oracle.com> Changeset: b7e14f52d050 Author: rkennke Date: 2019-03-21 22:10 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b7e14f52d050 Cherry-pick: 8221278: Shenandoah should not enqueue string dedup candidates during root scan ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp From rkennke at redhat.com Fri Mar 22 11:23:03 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 22 Mar 2019 12:23:03 +0100 Subject: RFR: Merge jdk/jdk -> shenandoah/jdk to jdk-13+13 Message-ID: <704ee8e7-2912-490d-55fc-0d017b71688d@redhat.com> The merge was mostly trivial, except for: 8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap ignores AS_NO_KEEPALIVE which needed to move around a little bit due to cleaned-up ShBS. Full list of changes: http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-22/changes.txt Testing: hotspot_gc_shenandoah good OK? Roman From shade at redhat.com Fri Mar 22 11:26:09 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 22 Mar 2019 12:26:09 +0100 Subject: RFR: Merge jdk/jdk -> shenandoah/jdk to jdk-13+13 In-Reply-To: <704ee8e7-2912-490d-55fc-0d017b71688d@redhat.com> References: <704ee8e7-2912-490d-55fc-0d017b71688d@redhat.com> Message-ID: <460bf52e-aa89-d33a-e666-325ba878821a@redhat.com> On 3/22/19 12:23 PM, Roman Kennke wrote: > Full list of changes: > http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-22/changes.txt > > Testing: hotspot_gc_shenandoah good > > OK? OK, let's do it. -Aleksey From roman at kennke.org Fri Mar 22 11:27:31 2019 From: roman at kennke.org (roman at kennke.org) Date: Fri, 22 Mar 2019 11:27:31 +0000 Subject: hg: shenandoah/jdk: 191 new changesets Message-ID: <201903221127.x2MBRj2c025119@aojmv0008.oracle.com> Changeset: 6684c75ab531 Author: dtitov Date: 2019-03-06 09:30 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6684c75ab531 8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed Reviewed-by: sspitsyn, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001.java Changeset: c5cf23055fcb Author: redestad Date: 2019-03-06 21:58 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c5cf23055fcb 8219713: Reduce work in DefaultMethods::generate_default_methods Reviewed-by: hseigel, dholmes, lfoltan, acorn ! src/hotspot/share/classfile/defaultMethods.cpp Changeset: 083d7a34bbfd Author: jwilhelm Date: 2019-03-07 00:23 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/083d7a34bbfd Added tag jdk-13+11 for changeset 21ea4076a275 ! .hgtags Changeset: cd701366fcf8 Author: thartmann Date: 2019-03-07 08:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/cd701366fcf8 8163511: Allocation of compile task fails with assert: "Leaking compilation tasks?" Summary: Use weak handles for compile tasks to allow unloading of referenced methods. Reviewed-by: kvn, coleenp, eosterlund ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/runtime/compilationPolicy.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp + test/hotspot/jtreg/compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java Changeset: a7cccbdf73f3 Author: goetz Date: 2019-03-06 16:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a7cccbdf73f3 8219651: compiler/ciReplay/TestServerVM.java is failing on windows Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java Changeset: 274361bd6915 Author: shade Date: 2019-03-07 10:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/274361bd6915 8220228: Improve Shenandoah pacing histogram message Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Changeset: 0f9a54a13803 Author: rehn Date: 2019-03-07 10:32 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0f9a54a13803 8220050: Deprecate -XX:-ThreadLocalHandshakes Reviewed-by: dcubed, mdoerr ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: 15595ecf9cf1 Author: shade Date: 2019-03-07 10:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/15595ecf9cf1 8215221: Serial GC misreports young GC time Reviewed-by: kbarrett, manc ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp Changeset: c112c2d5a856 Author: gadams Date: 2019-03-07 07:19 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c112c2d5a856 8201252: unquarantine nsk/jdi/ThreadReference/resume/resume001 Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: 6347ffe2c3c7 Author: redestad Date: 2019-03-05 16:39 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6347ffe2c3c7 8220159: Optimize various RegMask operations by introducing watermarks Reviewed-by: neliasso, thartmann ! src/hotspot/share/opto/chaitin.hpp ! src/hotspot/share/opto/regmask.cpp ! src/hotspot/share/opto/regmask.hpp Changeset: ff399127078a Author: bsrbnd Date: 2019-03-07 15:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ff399127078a 8217561: X86: Add floating-point Math.min/max intrinsics Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn Contributed-by: Jatin Bhateja ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopTransform.cpp ! test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java + test/micro/org/openjdk/bench/vm/compiler/FpMinMaxIntrinsics.java Changeset: a764c49570c6 Author: henryjen Date: 2019-03-07 10:18 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a764c49570c6 8217216: Launcher does not defend itself against LD_LIBRARY_PATH_64 (Solaris) Reviewed-by: rriggs ! src/java.base/unix/native/libjli/java_md_solinux.c ! test/jdk/tools/launcher/Test7029048.java Changeset: e445608fce9b Author: mullan Date: 2019-03-07 14:29 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e445608fce9b 8218618: Program fails when using JDK addressed by UNC path and using Security Manager Reviewed-by: weijun ! src/java.base/share/classes/sun/security/provider/PolicyFile.java Changeset: f0af7fd0c9ca Author: mseledtsov Date: 2019-03-07 12:15 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f0af7fd0c9ca 8213448: [TESTBUG] enhance jfr/jvm/TestDumpOnCrash Summary: added 2 more crash scenarios, removed dumponexit, and more Reviewed-by: egahlin ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 3e7fd3fe8411 Author: naoto Date: 2019-03-07 12:56 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3e7fd3fe8411 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time Reviewed-by: lancea, rgoel ! src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java ! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java + test/jdk/java/text/Format/DateFormat/SDFTCKZoneNamesTest.java Changeset: a37939761ff6 Author: neliasso Date: 2019-03-07 22:16 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a37939761ff6 8219448: split-if update_uses accesses stale idom data Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/split_if.cpp Changeset: dcaced4cbb83 Author: mseledtsov Date: 2019-03-07 13:20 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dcaced4cbb83 8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data Reviewed-by: egahlin + test/hotspot/jtreg/runtime/containers/docker/JfrReporter.java + test/hotspot/jtreg/runtime/containers/docker/TestJFREvents.java Changeset: 4ff6c8365b69 Author: ascarpino Date: 2019-03-07 19:35 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4ff6c8365b69 8220165: Encryption using GCM results in RuntimeException- input length out of bound Reviewed-by: valeriep ! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java + test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMLargeDataKAT.java Changeset: 889dae20c4c4 Author: sgehwolf Date: 2019-03-07 16:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/889dae20c4c4 8220283: ZGC fails to build on GCC 4.4.7: ATTRIBUTE_ALIGNED compatibility issue Reviewed-by: shade, kbarrett ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: feea57b38a1c Author: mdoerr Date: 2019-03-08 11:23 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/feea57b38a1c 8219584: Try to dump error file by thread which causes safepoint timeout Reviewed-by: stuefe, dholmes, kvn ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/utilities/vmError.cpp + test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java Changeset: ac09c2498c64 Author: shade Date: 2019-03-08 12:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ac09c2498c64 8220290: gc/arguments/TestSurvivorRatioFlag.java fails after JDK-8215221 with CMS Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/genCollectedHeap.cpp Changeset: 07540197d0fd Author: rehn Date: 2019-03-08 12:51 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/07540197d0fd 8220173: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark Reviewed-by: dcubed, redestad ! src/hotspot/share/runtime/handshake.cpp Changeset: fa9b16328e6a Author: hseigel Date: 2019-03-08 08:19 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fa9b16328e6a 8220085: runtime/CompressedOops/UseCompressedOops.java times out on Windows intermittently Summary: Increase the test's timeout to 480 and move it from tier1 to tier3. Reviewed-by: lfoltan, mseledtsov ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java Changeset: 65a9f034954f Author: sgehwolf Date: 2019-03-08 13:56 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/65a9f034954f 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions Reviewed-by: thartmann, shade ! test/hotspot/jtreg/compiler/runtime/safepoints/TestRegisterRestoring.java Changeset: c70747878f6f Author: neliasso Date: 2019-03-08 15:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c70747878f6f 8219642: ciReplay loads wrong data when MethodData size changes Reviewed-by: kvn, thartmann ! src/hotspot/share/ci/ciReplay.cpp Changeset: e693e12250d3 Author: mseledtsov Date: 2019-03-08 11:08 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e693e12250d3 8220313: [TESTBUG] Update base image for Docker testing to OL 7.6 Summary: Updated the OL version in Dockerfile in FROM field Reviewed-by: dcubed ! test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest ! test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest Changeset: 2915818a0237 Author: mseledtsov Date: 2019-03-08 11:09 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2915818a0237 Merge Changeset: fd6c13481231 Author: cushon Date: 2019-03-08 09:41 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fd6c13481231 8220377: Unused field SourceFileObject.flatname Reviewed-by: jjg Contributed-by: Ron Shapiro ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 56adab1e0edd Author: bobv Date: 2019-03-08 16:20 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/56adab1e0edd 8220323: Fix copyright header text Reviewed-by: lancea ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: bba6644b6fe3 Author: bobv Date: 2019-03-08 16:21 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/bba6644b6fe3 8220334: Fix copyright header text Reviewed-by: lancea ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java Changeset: 6dd6f988b4e4 Author: redestad Date: 2019-03-08 23:02 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6dd6f988b4e4 8219860: Cleanup ClassFileParser::parse_linenumber_table Reviewed-by: rehn, lfoltan, hseigel ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/classFileStream.cpp ! src/hotspot/share/classfile/classFileStream.hpp ! src/hotspot/share/code/compressedStream.cpp ! src/hotspot/share/code/compressedStream.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/method.inline.hpp ! src/hotspot/share/runtime/relocator.cpp Changeset: 0324b3756aa2 Author: ecaspole Date: 2019-03-08 17:45 -0500 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0324b3756aa2 8220368: Update String.indexOf to test all the C2 intrinsics Summary: Add new micros for Latin1 and UTF-16 Reviewed-by: kvn, redestad ! test/micro/org/openjdk/bench/java/lang/StringIndexOf.java Changeset: d9853137aa28 Author: dholmes Date: 2019-03-10 18:53 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d9853137aa28 8219685: Startup failure: assert(!Universe::is_module_initialized()) failed: Incorrect java.lang.Module pre module system initialization Reviewed-by: lfoltan, redestad ! src/hotspot/share/classfile/javaClasses.cpp Changeset: c97c87e96897 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c97c87e96897 8220350: Refactor ShenandoahHeap::initialize Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp Changeset: f02c6b980c04 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f02c6b980c04 8220153: Shenandoah does not work with TransparentHugePages properly Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 0a9cb99a98a0 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0a9cb99a98a0 8220162: Shenandoah should not commit HugeTLBFS memory Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp Changeset: 744dc9c33676 Author: kbarrett Date: 2019-03-11 02:05 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/744dc9c33676 8217417: Decorator name typo: C2_TIGHLY_COUPLED_ALLOC Summary: Fixed typo in decorator name, variables, and comments. Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp ! src/hotspot/share/gc/shared/c2/modRefBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/arraycopynode.hpp ! src/hotspot/share/opto/library_call.cpp Changeset: e4cc94318c37 Author: pmuthuswamy Date: 2019-03-11 14:17 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e4cc94318c37 8219632: Remove reference to com.sun.javadoc API in RemoveOldDoclet test Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm ! test/langtools/jdk/javadoc/tool/removeOldDoclet/RemoveOldDoclet.java Changeset: 95978e7e8da0 Author: nishjain Date: 2019-03-11 14:22 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/95978e7e8da0 8217254: CompactNumberFormat:: CompactNumberFormat???() constructor does not comply with spec. 8217721: CompactNumberFormat:: format???() method spec for IAEx is not complaint Reviewed-by: naoto ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! test/jdk/java/text/Format/CompactNumberFormat/TestCompactNumber.java ! test/jdk/java/text/Format/CompactNumberFormat/TestCompactPatternsValidity.java Changeset: 9a1dd1203a4f Author: pmuthuswamy Date: 2019-03-11 14:57 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9a1dd1203a4f 8220087: Remove remnants of HTML4 support Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/DocType.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTag.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! test/langtools/jdk/javadoc/doclet/testNavigation/TestNavigation.java Changeset: a2d3ca8062b9 Author: thartmann Date: 2019-03-11 11:42 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a2d3ca8062b9 8218201: Failures when vmIntrinsics::_getClass is not inlined Summary: Fix BCEscapeAnalyzer to correctly handle _getClass intrinsic. Reviewed-by: kvn, dlong, redestad, neliasso ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/ci/bcEscapeAnalyzer.hpp + test/hotspot/jtreg/compiler/escapeAnalysis/TestGetClass.java Changeset: ab7c5483df44 Author: shade Date: 2019-03-11 12:39 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ab7c5483df44 8074817: Resolve disabled warnings for libverify Reviewed-by: erikj, alanb ! make/lib/CoreLibraries.gmk ! src/java.base/share/native/libverify/check_code.c ! src/java.base/share/native/libverify/check_format.c Changeset: 1def2d745747 Author: rgoel Date: 2019-03-11 17:34 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1def2d745747 8220414: Correct copyright headers in Norm2AllModes.java and Normalizer2.java Summary: Updated copyright headers Reviewed-by: alanb ! src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java ! src/java.base/share/classes/sun/text/normalizer/Normalizer2.java Changeset: 289fd6cb7480 Author: clanger Date: 2019-03-11 15:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/289fd6cb7480 8220409: jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java - testOverlapWithBaseModule tests the wrong thing Reviewed-by: alanb ! test/jdk/jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java Changeset: 17a6681a5118 Author: redestad Date: 2019-03-11 17:33 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/17a6681a5118 8220420: Cleanup c1_LinearScan Reviewed-by: thartmann, neliasso ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/c1/c1_LinearScan.hpp Changeset: 687e10fefa11 Author: lancea Date: 2019-03-11 13:37 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/687e10fefa11 8220331: Remove extra spaces in copyright header Reviewed-by: naoto ! src/java.sql.rowset/share/classes/javax/sql/rowset/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package-info.java Changeset: be40860e8227 Author: zgu Date: 2019-03-11 14:06 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/be40860e8227 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots Reviewed-by: rkennke, shade ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp Changeset: 1bc8513104f2 Author: darcy Date: 2019-03-11 11:23 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1bc8513104f2 8220346: Refactor java.lang.Throwable to use Objects.requireNonNull Reviewed-by: lancea, mchung, tvaleev, forax, martin, plevart ! src/java.base/share/classes/java/lang/Throwable.java Changeset: 53a95878619f Author: jjg Date: 2019-03-11 12:59 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/53a95878619f 8220202: Simplify/standardize method naming for HtmlTree Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/LinkFactoryImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SubWriterHolderWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Comment.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/ContentBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/FixedStringContent.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/RawHtml.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Script.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/StringContent.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/TableHeader.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Content.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeFieldBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ConstructorBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/EnumConstantBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/FieldBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MethodBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PackageSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PropertyBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/UserTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkFactory.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkInfo.java ! test/langtools/jdk/javadoc/doclet/testHtmlDocument/TestHtmlDocument.java Changeset: c5d0b3acab98 Author: joehw Date: 2019-03-11 15:51 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c5d0b3acab98 8219705: Wrong media-type for a given serialization method Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java ! test/jaxp/TEST.ROOT + test/jaxp/javax/xml/jaxp/unittest/transform/OutputPropertiesTest.java Changeset: 62ab0859e7e5 Author: valeriep Date: 2019-03-11 23:48 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/62ab0859e7e5 8213008: Cipher with UNWRAP_MODE should support the generation of an AES key type Summary: Replaced CKK_GENERIC_SECRET with alorithm-specific key type in P11RSACipher unwrap impl Reviewed-by: ascarpino ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java Changeset: b17caf731e27 Author: valeriep Date: 2019-03-11 23:51 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b17caf731e27 Merge Changeset: d3888a37ad03 Author: bsrbnd Date: 2019-03-12 02:13 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d3888a37ad03 8220407: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java timedout Reviewed-by: kvn ! test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java Changeset: f984aca565c1 Author: dholmes Date: 2019-03-11 21:26 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f984aca565c1 8219721: jcmd from earlier release will hang attaching to VM with JDK-8215622 applied Summary: fix compatibility issue caused by jmap update of 8215622 Reviewed-by: dholmes, ysuenaga, phh, sspitsyn Contributed-by: zanglin5 at jd.com ! src/hotspot/share/services/attachListener.cpp ! src/hotspot/share/services/attachListener.hpp ! src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java ! test/jdk/java/util/logging/TestLoggerWeakRefLeak.java Changeset: 1dbe0c210134 Author: pli Date: 2019-03-07 02:39 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1dbe0c210134 8214922: Add vectorization support for fmin/fmax Reviewed-by: adinn, roland ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 94d1e2c8fe01 Author: thartmann Date: 2019-03-12 10:09 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/94d1e2c8fe01 8220341: Class redefinition fails with assert(!is_unloaded()) failed: unloaded method on the stack Summary: Skip unloaded methods in compile queue during marking. Reviewed-by: kvn, neliasso, eosterlund, coleenp ! src/hotspot/share/compiler/compileTask.cpp Changeset: b067bd7edc26 Author: chegar Date: 2019-03-12 09:22 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b067bd7edc26 8184315: Typo in java.net.JarURLConnection.getCertificates() method documentation Reviewed-by: dfuchs ! src/java.base/share/classes/java/net/JarURLConnection.java Changeset: c4fb912f3085 Author: mdoerr Date: 2019-03-12 11:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c4fb912f3085 8220441: [PPC64] Clobber memory effect missing for memory barriers in atomics Reviewed-by: simonis, goetz ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp Changeset: f9092c7d8677 Author: gadams Date: 2019-03-12 07:17 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f9092c7d8677 8013728: nsk/jdi/BScenarios/hotswap/tc10x001 Unrecognized Windows Sockets error: 0: recv failed Reviewed-by: cjplummer, amenkov ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001/newclass/tc10x001a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001a.java Changeset: ab17708ec5c3 Author: sgehwolf Date: 2019-03-07 17:34 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ab17708ec5c3 8220294: ZGC fails to build on GCC 4.4.7: Type parameter issue Summary: Specify explicit type in the constructor Reviewed-by: shade, pliden ! src/hotspot/share/gc/z/zStat.cpp Changeset: 9911f18d6a40 Author: rschmelter Date: 2019-03-11 05:09 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9911f18d6a40 8220363: hotspot-ide project fails Reviewed-by: clanger, erikj ! make/hotspot/ide/CreateVSProject.gmk Changeset: ee53a278b9d8 Author: zgu Date: 2019-03-12 09:59 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ee53a278b9d8 8220344: Build failures when using --with-jvm-features=-g1gc,-jfr Reviewed-by: tschatzl, zgu Contributed-by: Ao Qi ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp Changeset: 9c6508806663 Author: redestad Date: 2019-03-12 15:29 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9c6508806663 8220501: Improve c1_ValueStack locks handling Reviewed-by: thartmann, neliasso ! src/hotspot/share/c1/c1_ValueStack.cpp ! src/hotspot/share/c1/c1_ValueStack.hpp Changeset: daec95ed6795 Author: dfuchs Date: 2019-03-12 14:35 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/daec95ed6795 8220262: fix headings in java.logging Reviewed-by: lancea ! src/java.logging/share/classes/java/util/logging/LogManager.java Changeset: 4b4745d185eb Author: erikj Date: 2019-03-12 08:04 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4b4745d185eb 8220383: Incremental build is broken and inefficient Reviewed-by: tbell ! make/CompileJavaModules.gmk ! make/Images.gmk ! make/common/NativeCompilation.gmk ! make/common/ProcessMarkdown.gmk ! make/common/TestFilesCompilation.gmk ! make/hotspot/lib/CompileJvm.gmk ! make/test/JtregGraalUnit.gmk ! make/test/JtregNativeHotspot.gmk ! make/test/JtregNativeJdk.gmk Changeset: b4f4778cf3d9 Author: redestad Date: 2019-03-12 16:18 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b4f4778cf3d9 8220515: Revert removal of for_each_lock_value removal Reviewed-by: thartmann ! src/hotspot/share/c1/c1_ValueStack.hpp Changeset: 085309069d3c Author: kbarrett Date: 2019-03-12 11:13 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/085309069d3c 8217576: C1 atomic access handlers use incorrect decorators Summary: Fix decorator defaulting. Reviewed-by: tschatzl, eosterlund ! src/hotspot/share/c1/c1_LIRGenerator.cpp Changeset: 018217e30f5c Author: gadams Date: 2019-03-12 11:51 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/018217e30f5c 8220257: fix headings in java.instrument Reviewed-by: dfuchs ! src/java.instrument/share/classes/java/lang/instrument/package-info.java Changeset: 75268d993deb Author: gadams Date: 2019-03-12 11:53 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/75268d993deb 8220474: Incorrect GPL header in src/java.instrument/share/classes/java/lang/instrument/package-info.java Reviewed-by: dholmes ! src/java.instrument/share/classes/java/lang/instrument/package-info.java Changeset: da14083871bb Author: rriggs Date: 2019-03-12 12:48 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/da14083871bb 8220237: ProcessBuilder API documentation typo Reviewed-by: dfuchs ! src/java.base/share/classes/java/lang/ProcessBuilder.java Changeset: 6a15e411595e Author: lancea Date: 2019-03-12 14:56 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6a15e411595e 8220005: java/util/Arrays/TimSortStackSize2.java times out Reviewed-by: bchristi ! test/jdk/ProblemList.txt Changeset: d9bcf74fc56a Author: erikj Date: 2019-03-12 12:12 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d9bcf74fc56a 8220529: JDK-8220383 broke test image build Reviewed-by: tbell ! make/test/JtregNativeHotspot.gmk ! make/test/JtregNativeJdk.gmk Changeset: 84f10bbf993f Author: jwilhelm Date: 2019-03-12 19:17 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/84f10bbf993f 8218074: Update Graal Reviewed-by: kvn ! make/CompileJavaModules.gmk ! make/test/JtregGraalUnit.gmk ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Linker.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/ClassSearch.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64MacroAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64BaseAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.sparc/src/org/graalvm/compiler/asm/sparc/SPARCAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.test/src/org/graalvm/compiler/asm/test/AssemblerTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm/src/org/graalvm/compiler/asm/BranchTargetOutOfBoundsException.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.code/src/org/graalvm/compiler/code/CompilationResult.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.code/src/org/graalvm/compiler/code/HexCodeFileDisassemblerProvider.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64CbzTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64MembarOpTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64TestBitAndBranchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/SpeculativeExecutionAttacksMitigations.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/AbstractBlockBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/CFGVerifier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/Loop.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/doc-files/MitigateSpeculativeExecutionAttacksHelp.txt ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/AbstractObjectStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/AbstractPointerStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/IllegalStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/ObjectStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/PrimitiveStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/Stamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/StampPair.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/SymbolicJVMCIReference.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/VoidStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsignedLong.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTestBase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CountedLoopTest2.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/DumpPathTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraalCompilerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraphEncoderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GuardPrioritiesTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerDivRemConstantTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MemoryScheduleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/NestedLoopTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyCallerSensitiveMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/backend/BackendTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/deopt/RethrowDeoptMaterializeTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompiler.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/LIRCompilerBackend.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/LIRGenerationProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeLIRBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/HighTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/LowTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/target/Backend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugOptions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/IgvDumpChannel.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/PathUtilities.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/doc-files/PrintGraphHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph.test/src/org/graalvm/compiler/graph/test/graphio/GraphOutputTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeClass.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotJumpToExceptionHandlerInCallerOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/BinaryMathStubTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/UnaryMathStubTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotAddressLowering.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotJumpToExceptionHandlerInCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLoweringProvider.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64MathStub.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64X87MathIntrinsicNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64X87MathSnippets.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/StringUTF16ToBytesGetCharsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.lir.test/src/org/graalvm/compiler/hotspot/lir/test/BenchmarkCounterOverflowTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotMove.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/EliminateRedundantInitializationPhaseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/GraalOSRTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/JVMCIInfopointErrorTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/OptionsInFileTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ReservedStackAccessTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierVerificationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotCompiledCodeBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotDataBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompilerFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalJVMCIServiceLocator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalOptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotTTYStreamProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ArrayRangePostWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ArrayRangePreWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1BarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1PostWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1PreWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ReferentFieldReadBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/ArrayRangeWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/BarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/CardTableBarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/ObjectWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/SerialArrayRangeWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/SerialWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotClassInitializationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraalConstantFieldProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotNodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotUnsafeSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotWordOperationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/AllocaNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/DimensionsNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/type/KlassPointerStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/OnStackReplacementPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierAdditionPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierVerificationPhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ArraysSupportSubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/CounterModeSubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/DigestBaseSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotClassSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA2Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA5Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHASubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/WriteBarrierSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/OutOfBoundsExceptionStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/Stub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/IfNodeCanonicalizationsTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/SwitchHashTableTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Call.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ControlFlow.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayEqualsOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ControlFlow.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64HotSpotHelper.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathCosOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathExpOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathIntrinsicBinaryOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathIntrinsicUnaryOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathLog10Op.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathLogOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathPowOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathSinOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathTanOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.jtt/src/org/graalvm/compiler/lir/jtt/SPARCBranchBailoutTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIR.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIRValueUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/StandardOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/Variable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/lsra/LinearScanLifetimeAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/lsra/ssa/SSALinearScanLifetimeAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/asm/CompilationResultBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/asm/DataBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/HashFunction.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/Hasher.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/ssa/SSAUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/ConvertDeoptimizeToGuardPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopTransformations.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/BasicInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/CountedLoopInfo.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DefaultLoopPolicies.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedConvertedInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedOffsetInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedScaledInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/InductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopEx.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragment.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentInside.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentWhole.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/MathUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/lir/GraalCompilerState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/IfNodeCanonicalizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/AbstractFixedGuardNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ComputeObjectAddressNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ConstantNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/EncodedGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/FrameState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphEncoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/IfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LogicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LoopBeginNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LoopExitNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/PiNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/BinaryArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerDivRemNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerLessThanNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerMulHighNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IsNullNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/RightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedDivNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedRemNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/UnsignedRightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/Block.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/ControlFlowGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/JavaReadNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GeneratedInvocationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvocationPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/MethodSubstitutionPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/NodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/NewArrayNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/address/IndexAddressNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/NodeLIRBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/Replacements.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/type/NarrowOopStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/util/GraphUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options.processor/src/org/graalvm/compiler/options/processor/OptionProcessor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionDescriptor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionsParser.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/FixReadsPhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/OptimizeDivPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/RemoveValueProxyPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/graph/ReentrantBlockIterator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/util/GraphOrder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/GraphPrinterDumpHandler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringLatin1Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/GeneratedPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnIntegerExactTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/IntegerExactFoldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ReplacementsParseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringCompareToTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringIndexOfTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/classfile/ClassfileBytecodeProviderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/IntrinsicGraphBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetCounter.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetIntegerHistogram.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopySnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayCompareToNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayRegionEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicObjectCloneNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BinaryMathIntrinsicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/UnaryMathIntrinsicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerAddExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerAddExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticSplitNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulExactOverflowNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerSubExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerSubExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JavaVersionUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/SpeculationReasonGroup.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/GraalTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/SubprocessUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/EffectsClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphOutput.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphProtocol.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/ProtocolImpl.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/DirectAnnotationAccess.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/GuardedAnnotationAccess.java ! test/hotspot/jtreg/ProblemList-graal.txt + test/hotspot/jtreg/compiler/graalunit/EA9Test.java + test/hotspot/jtreg/compiler/graalunit/HotspotJdk9Test.java ! test/hotspot/jtreg/compiler/graalunit/TestPackages.txt Changeset: ab87b06dfdc0 Author: manc Date: 2019-01-15 15:59 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ab87b06dfdc0 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead Summary: Move check_gc_overhead_limit() and related code to its own class Reviewed-by: tschatzl, pliden, jiangli ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/parallel/psGCAdaptivePolicyCounters.cpp ! src/hotspot/share/gc/parallel/psGCAdaptivePolicyCounters.hpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp + src/hotspot/share/gc/shared/gcOverheadChecker.cpp + src/hotspot/share/gc/shared/gcOverheadChecker.hpp ! src/hotspot/share/gc/shared/gcPolicyCounters.cpp ! src/hotspot/share/gc/shared/gcPolicyCounters.hpp ! src/hotspot/share/gc/shared/gc_globals.hpp Changeset: ccb4a50bee06 Author: aeubanks Date: 2019-02-27 13:34 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ccb4a50bee06 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests Summary: Tests that hardcode "127.0.0.1" fail in an environment where only IPv6 is available and IPv4 is not. Reviewed-by: chegar, dfuchs, michaelm Contributed-by: aeubanks at google.com ! test/jdk/com/sun/net/httpserver/TestLogging.java ! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java ! test/jdk/com/sun/net/httpserver/bugs/B6361557.java ! test/jdk/com/sun/net/httpserver/bugs/TruncatedRequestBody.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java ! test/jdk/java/net/Authenticator/B6870935.java ! test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java ! test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestServer.java ! test/jdk/java/net/Socket/UrgentDataTest.java ! test/jdk/java/net/SocketOption/OptionsTest.java ! test/jdk/java/net/SocketOption/TcpKeepAliveTest.java ! test/jdk/java/net/httpclient/UnknownBodyLengthTest.java ! test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java ! test/jdk/java/nio/channels/AsynchronousChannelGroup/bootlib/Attack.java ! test/jdk/java/nio/channels/Selector/LotsOfCancels.java ! test/jdk/java/nio/channels/SocketChannel/AsyncCloseChannel.java ! test/jdk/java/nio/channels/SocketChannel/CloseRegisteredChannel.java ! test/jdk/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/jdk/java/nio/channels/SocketChannel/SocketInheritance.java ! test/jdk/java/nio/channels/etc/AdaptorCloseAndInterrupt.java ! test/jdk/java/nio/channels/etc/Shadow.java ! test/jdk/java/nio/charset/coders/StreamTimeout.java ! test/jdk/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/jdk/jdk/net/Sockets/QuickAckTest.java ! test/jdk/jdk/net/Sockets/Test.java ! test/jdk/sun/net/www/protocol/http/TunnelThroughProxy.java Changeset: 0bbff075bf41 Author: dtitov Date: 2019-03-12 17:55 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0bbff075bf41 8220244: vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003 hasn't been un-problemlisted Reviewed-by: dlong ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 1cef5fc16af8 Author: weijun Date: 2019-03-13 09:05 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1cef5fc16af8 8220256: fix headings in java.security.sasl Reviewed-by: mullan ! src/java.security.sasl/share/classes/javax/security/sasl/package-info.java Changeset: fc84d7c22132 Author: valeriep Date: 2019-03-13 02:48 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fc84d7c22132 8220258: fix headings in java.smartcardio Summary: Replace h3 with h2 Reviewed-by: ascarpino ! src/java.smartcardio/share/classes/javax/smartcardio/package-info.java Changeset: 3086f9259e97 Author: aoqi Date: 2019-03-13 00:48 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3086f9259e97 8170639: [Linux] jsig is limited to a maximum of 64 signals Reviewed-by: dholmes, iklam ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/aix/os_aix.hpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/bsd/os_bsd.hpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp Changeset: efb8569c95d5 Author: clanger Date: 2019-03-13 11:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/efb8569c95d5 8220504: Move definition of JAVA_VERSION_INFO_RESOURCE to Launcher-java.base.gmk Reviewed-by: erikj ! make/launcher/Launcher-java.base.gmk ! make/launcher/LauncherCommon.gmk Changeset: 48a02303574e Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/48a02303574e 8219816: Add IsArray/RemoveExtent type traits utilities Reviewed-by: kbarrett, eosterlund + src/hotspot/share/metaprogramming/isArray.hpp + src/hotspot/share/metaprogramming/removeExtent.hpp + test/hotspot/gtest/metaprogramming/test_isArray.cpp + test/hotspot/gtest/metaprogramming/test_removeExtent.cpp Changeset: 9d02451b536e Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9d02451b536e 8219817: Remove unused CollectedHeap::block_size() Reviewed-by: shade, stefank ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp Changeset: ed3c6f07faab Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ed3c6f07faab 8219633: ZGC: Rename ZPageSizeMin to ZGranuleSize Reviewed-by: eosterlund, stefank ! src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zCollectorPolicy.cpp ! src/hotspot/share/gc/z/zDebug.gdb ! src/hotspot/share/gc/z/zGlobals.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zHeapIterator.hpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobals.java ! test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp Changeset: 8b4a1177202d Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8b4a1177202d 8219634: ZGC: Rename ZAddressRangeMap to ZGranuleMap Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/vmStructs_z.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp + src/hotspot/share/gc/z/zGranuleMap.hpp + src/hotspot/share/gc/z/zGranuleMap.inline.hpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zHeapIterator.hpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPageTable.inline.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGranuleMapForPageTable.java < src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTable.java Changeset: acf36e8d61c6 Author: chegar Date: 2019-03-13 12:02 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/acf36e8d61c6 8220480: Typo in java.net.http.HttpResponse.BodySubscriber documentation Reviewed-by: alanb ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: 9fc262a75638 Author: tnakamura Date: 2019-03-13 13:05 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9fc262a75638 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 Summary: Adjusting to detect translated Unknown messages Reviewed-by: naoto ! src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c ! test/jdk/java/util/Locale/LocaleProviders.java ! test/jdk/java/util/Locale/LocaleProvidersRun.java Changeset: 6f75811126c3 Author: chegar Date: 2019-03-13 12:25 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6f75811126c3 8220475: Malformed copyright header in LinuxSocketOptions.java, MacOSXSocketOptions.java and MacOSXSocketOptions.c Reviewed-by: alanb, dfuchs ! src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java ! src/jdk.net/macosx/classes/jdk/net/MacOSXSocketOptions.java ! src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c Changeset: fd332722014c Author: xuelei Date: 2019-03-13 07:14 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fd332722014c 8160247: Mark deprecated javax.security.cert APIs with forRemoval=true Reviewed-by: weijun ! src/java.base/share/classes/com/sun/security/cert/internal/x509/X509V1CertImpl.java ! src/java.base/share/classes/javax/net/ssl/HandshakeCompletedEvent.java ! src/java.base/share/classes/javax/net/ssl/SSLSession.java ! src/java.base/share/classes/javax/security/cert/Certificate.java ! src/java.base/share/classes/javax/security/cert/CertificateEncodingException.java ! src/java.base/share/classes/javax/security/cert/CertificateException.java ! src/java.base/share/classes/javax/security/cert/CertificateExpiredException.java ! src/java.base/share/classes/javax/security/cert/CertificateNotYetValidException.java ! src/java.base/share/classes/javax/security/cert/CertificateParsingException.java ! src/java.base/share/classes/javax/security/cert/X509Certificate.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/ImmutableExtendedSSLSession.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/ImmutableSSLSession.java Changeset: 1a6a5a0260a7 Author: bpb Date: 2019-03-13 07:16 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1a6a5a0260a7 6504660: HPI panic callback is dead code Reviewed-by: dcubed, cjplummer, redestad ! src/jdk.jdwp.agent/unix/native/libjdwp/linker_md.c Changeset: 195309a6c7d5 Author: neliasso Date: 2019-03-13 15:22 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/195309a6c7d5 8219517: assert(false) failed: infinite loop in PhaseIterGVN::optimize Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/memnode.cpp Changeset: fab8496eb541 Author: redestad Date: 2019-03-13 17:32 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fab8496eb541 8220496: Race in java_lang_String::length() when deduplicating Reviewed-by: rkennke, pliden ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.hpp Changeset: 8b61a38be0c5 Author: zgu Date: 2019-03-13 13:33 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8b61a38be0c5 8220546: Shenandoah Reports timing details for weak root processing Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp Changeset: 954399cb6959 Author: aeubanks Date: 2019-03-13 09:12 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/954399cb6959 8220585: Incorrect code in MulticastSocket sample code Summary: Sample code shows that String.length() can be passed to a DatagramPacket along with String.getBytes(), but is incorrect for non-ASCII Strings. Reviewed-by: martin, chegar Contributed-by: aeubanks at google.com ! src/java.base/share/classes/java/net/MulticastSocket.java Changeset: d58599c7cdef Author: jiangli Date: 2019-03-13 10:37 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d58599c7cdef Merge Changeset: 9a90236ab64c Author: lancea Date: 2019-03-13 14:10 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9a90236ab64c 8220253: Fix Headings in java.sql.rowset Reviewed-by: darcy ! src/java.sql.rowset/share/classes/com/sun/rowset/package-info.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/RIOptimisticProvider.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/RIXMLProvider.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/BaseRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/CachedRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/JoinRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/Joinable.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/Predicate.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/WebRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncProvider.java Changeset: 1d7aec80147a Author: bpb Date: 2019-03-13 11:12 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1d7aec80147a 8219597: (bf) Heap buffer state changes could provoke unexpected exceptions Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template Changeset: 43a379369b0e Author: dfuchs Date: 2019-03-13 18:43 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value Summary: ThreadGroup.enumerate(list,n,recurse) should never return a value that is less than n. Reviewed-by: clanger, chegar, prappo ! src/java.base/share/classes/java/lang/ThreadGroup.java + test/jdk/java/lang/ThreadGroup/Destroy.java Changeset: debb15cc04ee Author: epavlova Date: 2019-03-13 12:30 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/debb15cc04ee 8219882: [AOT] Develop regression test for 8218859 Reviewed-by: kvn + test/hotspot/jtreg/compiler/aot/cli/jaotc/CompileAbsoluteDirectoryTest.java ! test/hotspot/jtreg/compiler/aot/cli/jaotc/CompileDirectoryTest.java Changeset: f4f0dce5d0bb Author: tschatzl Date: 2019-03-13 21:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f4f0dce5d0bb 8220301: Remove jbyte use in CardTable Summary: Use CardTable::CardValue aliased to uint8_t instead. Reviewed-by: kbarrett, shade ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler_arm.cpp ! src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler_arm.cpp ! src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/cardTableBarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/cardTableBarrierSetAssembler_ppc.hpp ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp ! src/hotspot/cpu/s390/gc/shared/cardTableBarrierSetAssembler_s390.cpp ! src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp ! src/hotspot/cpu/sparc/gc/shared/cardTableBarrierSetAssembler_sparc.cpp ! src/hotspot/cpu/sparc/gc/shared/cardTableBarrierSetAssembler_sparc.hpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp ! src/hotspot/share/ci/ciUtilities.cpp ! src/hotspot/share/ci/ciUtilities.hpp ! src/hotspot/share/gc/cms/cmsCardTable.cpp ! src/hotspot/share/gc/cms/cmsCardTable.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp ! src/hotspot/share/gc/g1/g1CardCounts.cpp ! src/hotspot/share/gc/g1/g1CardCounts.hpp ! src/hotspot/share/gc/g1/g1CardTable.cpp ! src/hotspot/share/gc/g1/g1CardTable.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp ! src/hotspot/share/gc/parallel/psCardTable.cpp ! src/hotspot/share/gc/parallel/psCardTable.hpp ! src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp ! src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp ! src/hotspot/share/gc/shared/cardTableRS.cpp ! src/hotspot/share/gc/shared/cardTableRS.hpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp Changeset: e8de5d46ecd4 Author: tschatzl Date: 2019-03-13 21:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e8de5d46ecd4 8220345: Use appropriate type for G1RemSetScanState::IsDirtyRegionState Reviewed-by: kbarrett, lkorinth ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: db545bf94fbc Author: cjplummer Date: 2019-03-13 19:42 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/db545bf94fbc 8220352: Crash with assert(external_guard || result != __null) failed: Invalid JNI handle Summary: Don't delete globalrefs that might still be referenced Reviewed-by: gadams, jcbeyler, sspitsyn ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWait/monitorwait001/monitorwait001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWaited/monitorwaited001/monitorwaited001.cpp Changeset: f7a745888a1e Author: jwilhelm Date: 2019-03-14 04:10 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f7a745888a1e Added tag jdk-13+12 for changeset 1d7aec80147a ! .hgtags Changeset: d295a7d2b933 Author: cushon Date: 2019-03-13 17:26 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d295a7d2b933 8220634: SymLinkArchiveTest should handle not being able to create symlinks Reviewed-by: jjg ! test/langtools/tools/javac/file/SymLinkArchiveTest.java Changeset: 17bf38efed0e Author: cushon Date: 2019-03-05 12:01 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/17bf38efed0e 8193277: SimpleFileObject inconsistency between getName and getShortName Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/PathFileObject.java + test/langtools/tools/javac/file/SymLinkShortNameTest.java Changeset: d21803f47416 Author: chegar Date: 2019-03-14 09:10 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d21803f47416 8220598: Malformed copyright year range in a few files in java.base Reviewed-by: dfuchs, lancea, rriggs, weijun ! src/java.base/share/classes/jdk/internal/util/ArraysSupport.java ! src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java ! src/java.base/share/classes/sun/security/util/IOUtils.java Changeset: a6221f993616 Author: pzhang Date: 2019-03-12 11:49 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a6221f993616 8220566: AArch64: Set default vm features for Ampere eMAG CPUs Summary: Set defaults for vendor specific features Reviewed-by: adinn ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Changeset: d611b76d1327 Author: mdoerr Date: 2019-03-14 12:30 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d611b76d1327 8220660: [s390]: debug build broken after JDK-8220301 Reviewed-by: shade ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp Changeset: 6bf8877eb1b9 Author: roland Date: 2019-03-12 15:42 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6bf8877eb1b9 8220374: C2: LoopStripMining doesn't strip as expected Reviewed-by: rkennke, thartmann, mdoerr ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java Changeset: 677cede5608e Author: stefank Date: 2019-03-14 09:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/677cede5608e 8220411: Remove ScavengeRootsInCode=0 code Reviewed-by: thartmann, coleenp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciBaseObject.cpp ! src/hotspot/share/ci/ciBaseObject.hpp ! src/hotspot/share/ci/ciObject.cpp ! src/hotspot/share/ci/ciObject.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/opto/type.cpp Changeset: fce463e39f72 Author: stefank Date: 2019-03-14 09:14 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fce463e39f72 8220342: Remove scavenge_root_nmethods_do from VM_HeapWalkOperation::collect_simple_roots Reviewed-by: sspitsyn, ehelin ! src/hotspot/share/prims/jvmtiTagMap.cpp Changeset: 4b1426ed1c44 Author: stefank Date: 2019-03-14 09:15 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4b1426ed1c44 8220343: Move scavenge_root_nmethods from shared code Reviewed-by: kvn, eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/pcTasks.cpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp + src/hotspot/share/gc/shared/scavengableNMethods.cpp + src/hotspot/share/gc/shared/scavengableNMethods.hpp + src/hotspot/share/gc/shared/scavengableNMethodsData.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java Changeset: 153419748bf8 Author: sgehwolf Date: 2019-02-25 15:41 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/153419748bf8 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't Reviewed-by: dfuchs, sballal ! test/jdk/sun/management/jmxremote/bootstrap/JMXAgentInterfaceBinding.java ! test/jdk/sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java Changeset: 5d48ae032588 Author: hseigel Date: 2019-03-14 09:38 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5d48ae032588 8219579: Remove redundant signature parsing from the verifier Summary: Change verifier signature checking into asserts because ClassFileParser checks signatures for files being verified. Reviewed-by: lfoltan, coleenp, redestad, dholmes ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp + test/hotspot/jtreg/runtime/verifier/BadSignatures.jcod + test/hotspot/jtreg/runtime/verifier/TestSigParse.java Changeset: 70a818b1d9db Author: redestad Date: 2019-03-14 15:31 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/70a818b1d9db 8220502: Inefficient pre-sizing of PhiResolverState arrays in c1_LIRGenerator Reviewed-by: thartmann, kvn ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp Changeset: 478f1483c511 Author: lancea Date: 2019-03-14 10:50 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/478f1483c511 8220252: Fix Headings in java.naming Reviewed-by: dfuchs ! src/java.naming/share/classes/com/sun/jndi/ldap/EventSupport.java ! src/java.naming/share/classes/javax/naming/CompositeName.java ! src/java.naming/share/classes/javax/naming/CompoundName.java ! src/java.naming/share/classes/javax/naming/Context.java ! src/java.naming/share/classes/javax/naming/directory/DirContext.java ! src/java.naming/share/classes/javax/naming/event/EventContext.java ! src/java.naming/share/classes/javax/naming/ldap/LdapContext.java Changeset: e6a1c4e28294 Author: gadams Date: 2019-03-14 10:58 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e6a1c4e28294 8218166: com/sun/jdi/SimulResumerTest.java failure Reviewed-by: dlong, jcbeyler ! test/jdk/com/sun/jdi/SimulResumerTest.java Changeset: c0fccca69aff Author: jcbeyler Date: 2019-03-14 09:35 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c0fccca69aff 8220628: Move the HeapMonitor library to C++ Summary: Migrate libHeapMonitorTest.c to libHeapMonitorTest.cpp Reviewed-by: cjplummer, sspitsyn - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c + test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp Changeset: deb99f13c6cd Author: bpb Date: 2019-03-14 09:43 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/deb99f13c6cd 8220614: (bf) Buffer absolute slice methods should use Objects.checkFromIndexSize() Reviewed-by: alanb, igerasim, rriggs ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java Changeset: 641768acb12e Author: cushon Date: 2019-03-08 09:58 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/641768acb12e 8220378: Unused Names constants Reviewed-by: jjg, mcimadamore Contributed-by: Ron Shapiro ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java Changeset: 41b79b3e21fb Author: itakiguchi Date: 2019-03-15 00:49 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/41b79b3e21fb 8220281: IBM-858 alias name is missing on IBM00858 charset Summary: Add aliases into IBM charsets Reviewed-by: naoto ! make/data/charsetmapping/charsets ! test/jdk/sun/nio/cs/TestIBMBugs.java Changeset: 2ab55d39fb5b Author: cushon Date: 2019-03-13 22:05 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2ab55d39fb5b 8220644: Align required/found pairs in diagnostics Reviewed-by: mcimadamore, jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: 829bf950287e Author: redestad Date: 2019-03-14 18:56 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/829bf950287e 8220366: Optimize Symbol handling in ClassVerifier and SignatureStream Reviewed-by: hseigel, coleenp, lfoltan ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp Changeset: 777110c61b1f Author: mseledtsov Date: 2019-03-14 11:26 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/777110c61b1f 8220676: [TESTBUG] ProblemList TestCPUSets until the test issue is resolved Summary: Added the test to problem list Reviewed-by: lfoltan ! test/hotspot/jtreg/ProblemList.txt Changeset: 67f72165dca5 Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/67f72165dca5 8220379: Fix doclint handling of headings Reviewed-by: erikj, jlahoda ! make/CompileJavaModules.gmk ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Checker.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Env.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java + test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadingsTest.java ! test/langtools/tools/doclint/AccessibilityTest.java ! test/langtools/tools/doclint/AccessibilityTest.out ! test/langtools/tools/doclint/html/BlockTagsTest.java ! test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/langtools/tools/doclint/tidy/MissingTag.java ! test/langtools/tools/doclint/tidy/MissingTag.out - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java + test/langtools/tools/javac/doclint/ImplicitHeadingsTest.java Changeset: 3cc19f34075b Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3cc19f34075b Merge Changeset: 943cfab99051 Author: jjg Date: 2019-03-14 13:33 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/943cfab99051 8219691: method summary table head should be enclosed in Reviewed-by: jjg Contributed-by: dthomson at google.com ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTag.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestIndirectExportsOpens.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testPackagePage/TestPackagePage.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java Changeset: b70c65a946a0 Author: ngasson Date: 2019-03-14 14:25 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b70c65a946a0 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm Reviewed-by: jjg, clanger ! test/langtools/jdk/javadoc/doclet/InheritDocForUserTags/DocTest.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java Changeset: b6134b6d75ff Author: jjg Date: 2019-03-14 15:30 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b6134b6d75ff 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! make/CompileJavaModules.gmk ! src/java.compiler/share/classes/javax/annotation/processing/Generated.java Changeset: 8a66c92526cb Author: iignatyev Date: 2019-03-14 16:17 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8a66c92526cb 8220689: problem list RandomCommandsTest in graal runs Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 421b47214391 Author: dtitov Date: 2019-03-14 16:28 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/421b47214391 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed Reviewed-by: dlong, sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp Changeset: 6ab293f66cae Author: iignatyev Date: 2019-03-14 19:37 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6ab293f66cae 8219139: move hotspot tests from test/jdk/vm Reviewed-by: dholmes, mseledtsov + test/hotspot/jtreg/compiler/codegen/BadLogicCode.java + test/hotspot/jtreg/compiler/codegen/ShiftTest.java + test/hotspot/jtreg/compiler/exceptions/ExceptionInInit.java + test/hotspot/jtreg/compiler/runtime/JITClassInit.java + test/hotspot/jtreg/gc/ArraySize.java + test/hotspot/jtreg/gc/InfiniteList.java + test/hotspot/jtreg/runtime/ErrorHandling/ExplicitArithmeticCheck.java + test/hotspot/jtreg/runtime/Thread/MonitorCacheMaybeExpand_DeadLock.java + test/hotspot/jtreg/runtime/interpreter/WideStrictInline.java + test/hotspot/jtreg/runtime/reflect/ReflectStackOverflow.java + test/hotspot/jtreg/runtime/verifier/TestStaticIF.java + test/hotspot/jtreg/runtime/verifier/VerifyProtectedConstructor.java + test/hotspot/jtreg/runtime/verifier/VerifyStackForExceptionHandlers.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java ! test/jdk/TEST.groups + test/jdk/tools/launcher/JniInvocationTest.java + test/jdk/tools/launcher/exeJniInvocationTest.c - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: 8ff8b3734549 Author: thartmann Date: 2019-03-15 08:27 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8ff8b3734549 8220611: compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java timeout Summary: Test should not be executed with Graal as JIT. Reviewed-by: kvn ! test/hotspot/jtreg/compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java Changeset: fb7a1fdeaea7 Author: gadams Date: 2019-03-15 06:16 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fb7a1fdeaea7 8220678: unquarantine nsk/jdi/ThreadReference/setEnabled/setenabled003 Reviewed-by: cjplummer, sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 6f14d52d5e10 Author: shade Date: 2019-03-15 13:01 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6f14d52d5e10 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled Reviewed-by: rkennke, roland ! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Changeset: 81605c74b980 Author: chegar Date: 2019-03-15 14:50 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/81605c74b980 8179549: Typo in network properties documentation Reviewed-by: clanger, coffeys ! src/java.base/share/classes/java/net/doc-files/net-properties.html Changeset: 8f91e1a7ebdc Author: chegar Date: 2019-03-15 14:54 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8f91e1a7ebdc 8213912: Semantic typo in HttpExchange.java Reviewed-by: dfuchs ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java Changeset: 62e4ada7c4c8 Author: erikj Date: 2019-03-15 09:13 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/62e4ada7c4c8 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: tbell ! make/autoconf/toolchain.m4 ! make/conf/jib-profiles.js ! make/devkit/Makefile + make/devkit/Tars.gmk ! make/devkit/Tools.gmk Changeset: c61f09122d3b Author: jwilhelm Date: 2019-03-15 18:59 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c61f09122d3b 8220704: ZGC: gc tests complain Java heap too small Reviewed-by: iignatyev, tschatzl ! test/hotspot/jtreg/gc/ArraySize.java ! test/hotspot/jtreg/gc/InfiniteList.java Changeset: 5529640c5f67 Author: coleenp Date: 2019-03-15 16:00 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5529640c5f67 8220512: Deoptimize redefinition functions that have dirty ICs Summary: Walk ICs to determine whether nmethods are dependent on redefined classes. Reviewed-by: sspitsyn, eosterlund ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCodeHeap.hpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/aot/aotLoader.cpp ! src/hotspot/share/aot/aotLoader.hpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciObjectFactory.cpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/metadataOnStackMark.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: d2f8b7b33013 Author: bpb Date: 2019-03-15 16:24 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d2f8b7b33013 8219876: (bf) Improve IndexOutOfBoundsException messages in $Type$Buffer classes Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java ! src/java.base/share/classes/java/nio/X-Buffer.java.template Changeset: 5274462d5725 Author: jwilhelm Date: 2019-03-16 02:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5274462d5725 8220745: Fix problemlist entry to refer to 8220613 Reviewed-by: dcubed ! test/jdk/ProblemList.txt Changeset: 4985c8ca55b9 Author: ysuenaga Date: 2019-03-16 21:27 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4985c8ca55b9 8220555: JFR tool shows potentially misleading message when it cannot access a file Reviewed-by: egahlin, mseledtsov ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Command.java ! test/jdk/jdk/jfr/tool/TestPrint.java Changeset: 1caf2daef7cf Author: alanb Date: 2019-03-16 12:31 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1caf2daef7cf 8220738: (sc) Move ServerSocketChannelImpl remaining native method to Net Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/unix/native/libnio/ch/Net.c - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c ! src/java.base/unix/native/libnio/ch/nio_util.h ! src/java.base/windows/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/Net.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c ! src/java.base/windows/native/libnio/ch/nio_util.h ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java Changeset: b5a73f22b2bd Author: alanb Date: 2019-03-16 19:44 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b5a73f22b2bd 8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl Reviewed-by: chegar Contributed-by: alan.bateman at oracle.com, michael.x.mcmahon at oracle.com ! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java + src/java.base/share/classes/java/net/DelegatingSocketImpl.java ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! src/java.base/share/classes/java/net/SocketImpl.java ! src/java.base/share/classes/java/net/SocksSocketImpl.java + src/java.base/share/classes/sun/net/PlatformSocketImpl.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketInputStreamInstrumentor.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketOutputStreamInstrumentor.java + test/jdk/java/net/SocketImpl/SocketImplCombinations.java ! test/jdk/jdk/jfr/event/io/TestInstrumentation.java Changeset: 56e9781e6044 Author: igerasim Date: 2019-03-16 13:44 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/56e9781e6044 6307456: UnixFileSystem_md.c use of chmod() and access() should handle EINTR signal appropriately (unix) Reviewed-by: bpb, dholmes, alanb ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/unix/native/libjava/io_util_md.h Changeset: 1a18b8d56d73 Author: igerasim Date: 2019-03-16 15:05 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1a18b8d56d73 8220684: Process.waitFor(long, TimeUnit) can return false for a process that exited within the timeout Reviewed-by: prappo, dholmes, rriggs ! src/java.base/share/classes/java/lang/Process.java + test/jdk/java/lang/Process/WaitFor.java Changeset: 5e1480a38a43 Author: chegar Date: 2019-03-17 08:26 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5e1480a38a43 8220719: Allow other named NetPermissions to be used Reviewed-by: mullan, alanb ! src/java.base/share/classes/java/net/NetPermission.java Changeset: 7c23a4432610 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7c23a4432610 8220569: ZGC: Rename and rework ZUnmapBadViews to ZVerifyViews Reviewed-by: stefank, eosterlund ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/hotspot/share/gc/z/z_globals.hpp ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 759a63069fac Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/759a63069fac 8220741: ZGC: Move CPU agnostic files from linux_x86 to linux Reviewed-by: stefank, eosterlund + src/hotspot/os/linux/gc/z/zLargePages_linux.cpp + src/hotspot/os/linux/gc/z/zNUMA_linux.cpp + src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp Changeset: 349843ebb209 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/349843ebb209 8220586: ZGC: Move relocation logic from ZPage to ZRelocate Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp Changeset: f344a0c6e19e Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f344a0c6e19e 8220587: ZGC: Break out forwarding information from ZPage Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zBarrier.cpp + src/hotspot/share/gc/z/zForwarding.cpp + src/hotspot/share/gc/z/zForwarding.hpp + src/hotspot/share/gc/z/zForwarding.inline.hpp + src/hotspot/share/gc/z/zForwardingEntry.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zForwardingTable.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp ! src/hotspot/share/gc/z/zGranuleMap.hpp ! src/hotspot/share/gc/z/zGranuleMap.inline.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp + test/hotspot/gtest/gc/z/test_zForwarding.cpp - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList-zgc.txt Changeset: 790679f86a51 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/790679f86a51 8220588: ZGC: Convert ZRelocationSet to hold ZForwardings instead of ZPages Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocationSet.cpp ! src/hotspot/share/gc/z/zRelocationSet.hpp ! src/hotspot/share/gc/z/zRelocationSet.inline.hpp ! src/hotspot/share/gc/z/zRelocationSetSelector.cpp ! src/hotspot/share/gc/z/zRelocationSetSelector.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: c585ef187216 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c585ef187216 8220589: ZGC: Remove superfluous ZPageTableEntry Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zDebug.gdb ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zMark.hpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPageTable.inline.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHeap.java Changeset: 84295bd6d359 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/84295bd6d359 8220590: ZGC: Remove ZPages from ZPageTable when freed Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageTable.cpp Changeset: b9f030844be4 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b9f030844be4 8220591: ZGC: Don't delay reclaimation of ZVirtualMemory Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPageAllocator.cpp Changeset: d0d26fc836dd Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d0d26fc836dd 8220592: ZGC: Move destruction of detached ZPages into ZPageAllocator Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: eb54b34af2be Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/eb54b34af2be 8220593: ZGC: Remove superfluous ZPage::is_detached() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageCache.cpp Changeset: 5748eae24183 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5748eae24183 8220594: ZGC: Remove superfluous ZPage::is_active() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: 8f1771ea1e39 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8f1771ea1e39 8220595: ZGC: Introduce ZAttachedArray Reviewed-by: stefank, eosterlund + src/hotspot/share/gc/z/zAttachedArray.hpp + src/hotspot/share/gc/z/zAttachedArray.inline.hpp Changeset: 07943af21b96 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/07943af21b96 8220596: ZGC: Convert ZNMethodData to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zNMethodData.hpp Changeset: f92f1f1045ad Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f92f1f1045ad 8220597: ZGC: Convert ZForwarding to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: e6a92f2f37a9 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e6a92f2f37a9 8220599: ZGC: Introduce ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zArray.hpp ! src/hotspot/share/gc/z/zArray.inline.hpp + src/hotspot/share/gc/z/zSafeDelete.hpp + src/hotspot/share/gc/z/zSafeDelete.inline.hpp Changeset: 6d1caebf8d37 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6d1caebf8d37 8220600: ZGC: Delete ZPages using ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: 36e0665773e7 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/36e0665773e7 8220601: ZGC: Delete ZNMethodTableEntry arrays using ZSafeDelete Reviewed-by: stefank, eosterlund - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: 2786541e4f91 Author: sgehwolf Date: 2019-03-13 20:07 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2786541e4f91 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp Reviewed-by: bobv, adinn ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java Changeset: b4779a44476b Author: stefank Date: 2019-03-18 15:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b4779a44476b 8220606: Move ScavengableNMethods unlinking to unregister_nmethod Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: 98e21d4da074 Author: stefank Date: 2019-03-18 15:21 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/98e21d4da074 8220609: Cleanups in ScavengableNMethods Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: e81b44c68680 Author: rkennke Date: 2019-03-18 16:33 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e81b44c68680 8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap ignores AS_NO_KEEPALIVE Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp Changeset: 564043cbe138 Author: erikj Date: 2019-03-18 17:33 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/564043cbe138 8220737: Jib based 32 bit windows builds fail Reviewed-by: tbell, dholmes ! make/conf/jib-profiles.js Changeset: d265655be483 Author: jjg Date: 2019-03-18 11:50 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d265655be483 8220693: jdk/javadoc/doclet/MetaTag/MetaTag.java with unexpected date Reviewed-by: hannesw ! test/langtools/jdk/javadoc/doclet/MetaTag/MetaTag.java Changeset: 2e586b74722e Author: jnimeh Date: 2019-03-18 15:26 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2e586b74722e 8218723: Use SunJCE Mac in SecretKeyFactory PBKDF2 implementation Reviewed-by: apetcher ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java + test/jdk/javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov.jar + test/jdk/javax/crypto/SecretKeyFactory/evilprov/Makefile + test/jdk/javax/crypto/SecretKeyFactory/evilprov/README + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilProvider.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/module-info.java Changeset: 7418b266e1c7 Author: jjiang Date: 2019-03-19 10:36 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7418b266e1c7 8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output Summary: Using the same timezone for jar verifying and date formatting Reviewed-by: weijun ! test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java ! test/jdk/sun/security/tools/jarsigner/warnings/Test.java Changeset: 5f4dedb4dcf5 Author: aoqi Date: 2019-03-19 17:03 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5f4dedb4dcf5 8220812: gc/shenandoah/options/TestLoopMiningArguments.java fails if default GC is serial/parallel/cms Reviewed-by: shade Contributed-by: Ao Qi ! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java Changeset: 8717d7424861 Author: chegar Date: 2019-03-19 11:15 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8717d7424861 8170705: sun/net/www/protocol/http/StackTraceTest.java fails intermittently with Invalid Http response Reviewed-by: dfuchs ! test/jdk/sun/net/www/protocol/http/StackTraceTest.java Changeset: 3827cd66e788 Author: mbaesken Date: 2019-03-18 16:04 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3827cd66e788 8220781: linux-s390 : os::get_summary_cpu_info gives bad output Reviewed-by: dholmes, lucy ! src/hotspot/os/linux/os_linux.cpp Changeset: f554d3e88da3 Author: mbaesken Date: 2019-03-18 15:29 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f554d3e88da3 8220355: Improve assertion texts and exception messages in eventHandlerVMInit Reviewed-by: alanb, sspitsyn, jcbeyler ! src/java.instrument/share/native/libinstrument/InvocationAdapter.c ! src/java.instrument/share/native/libinstrument/JPLISAgent.c Changeset: 791052cc88db Author: chegar Date: 2019-03-19 14:27 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/791052cc88db 8220663: Incorrect handling of IPv6 addresses in Socket(Proxy.HTTP) Reviewed-by: alanb, michaelm ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! test/jdk/java/net/Socket/HttpProxy.java Changeset: dfde3bb48c03 Author: rriggs Date: 2019-03-19 10:47 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dfde3bb48c03 8220613: java/util/Arrays/TimSortStackSize2.java times out with fastdebug build Reviewed-by: lancea, alanb ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT ! test/jdk/java/util/Arrays/TimSortStackSize2.java Changeset: 021448dc442c Author: kbarrett Date: 2019-03-19 14:08 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/021448dc442c 8220690: ATTRIBUTE_ALIGNED requires GNU extensions enabled Summary: Use __typeof__(x) instead of typeof(x). Reviewed-by: shade, sgehwolf ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: da7f6755ba71 Author: bobv Date: 2019-03-19 12:00 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/da7f6755ba71 8219562: Line of code in osContainer_linux.cpp L102 appears unreachable Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp Changeset: d909d0a883c4 Author: bobv Date: 2019-03-19 12:10 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d909d0a883c4 8212528: Wrong cgroup subsystem being used for some CPU Container Metrics Reviewed-by: rriggs, sgehwolf ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: d5da034032e9 Author: bobv Date: 2019-03-19 12:29 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d5da034032e9 8217766: Container Support doesn't work for some Join Controllers combinations Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: c2238a12f259 Author: bobv Date: 2019-03-19 14:31 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c2238a12f259 Merge Changeset: 4b6a629d0615 Author: kbarrett Date: 2019-03-19 14:32 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/4b6a629d0615 8218975: Bug in macOSX kernel's pthread support Summary: Use freelist of pthread_mutex/condvar pairs on macOSX. Reviewed-by: tschatzl, dholmes, dcubed Contributed-by: kim.barrett at oracle.com, patricio.chilano.mateo at oracle.com ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp ! src/hotspot/os/posix/os_posix.inline.hpp Changeset: 6146ab937899 Author: coleenp Date: 2019-03-19 14:22 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6146ab937899 8220744: Move RedefineTests to from runtime to serviceability Summary: move tests out of runtime to jvmti/RedefineClasses Reviewed-by: sspitsyn, dcubed, cjplummer, hseigel, mseledtsov ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasicTest.java ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java ! test/hotspot/jtreg/runtime/logging/RedefineClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/Agent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ModifyAnonymous.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAddLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDeleteJmethod.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDoubleDelete.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceCall.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithResolutionErrors.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSubtractLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RetransformClassesZeroLength.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestLambdaFormRetransformation.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestMultipleClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineWithUnresolvedClass.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.mf + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/WalkThroughInvoke.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDeleteJmethod.c + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf Changeset: ddfb658c8ce3 Author: apetcher Date: 2019-03-19 15:18 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ddfb658c8ce3 8147502: Digest is incorrectly truncated for ECDSA signatures when the bit length of n is less than the field size Summary: Truncate the digest according to the group order, not the field size Reviewed-by: jnimeh ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSASignature.java ! src/jdk.crypto.ec/share/native/libsunec/impl/ec.c + test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: 6ba98ff89499 Author: pmuthuswamy Date: 2019-03-20 09:58 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6ba98ff89499 8219958: Automatically load taglets from a jar file Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java + test/langtools/jdk/javadoc/doclet/testAutoLoadTaglets/TestAutoLoadTaglets.java Changeset: 40296a51aeb0 Author: chegar Date: 2019-03-20 08:33 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/40296a51aeb0 8153508: ContentHandler API contains link to private contentPathProp Reviewed-by: dfuchs, vtewari ! src/java.base/share/classes/java/net/ContentHandler.java Changeset: af3f568cbd2d Author: dcherepanov Date: 2019-03-20 11:51 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/af3f568cbd2d 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit Reviewed-by: iveresov, thartmann ! src/hotspot/share/c1/c1_LIRGenerator.cpp + test/hotspot/jtreg/compiler/c1/Test8211100.java Changeset: 83cace4142c8 Author: chegar Date: 2019-03-20 09:17 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/83cace4142c8 8221098: Run java/net/URL/HandlerLoop.java in othervm mode Reviewed-by: alanb, martin ! test/jdk/java/net/URL/HandlerLoop.java Changeset: fc45b52439df Author: rkennke Date: 2019-03-22 11:44 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fc45b52439df Merge ! .hgtags ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp ! src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad + src/hotspot/os/linux/gc/z/zLargePages_linux.cpp + src/hotspot/os/linux/gc/z/zNUMA_linux.cpp + src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/windows/os_windows.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp ! src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp + src/hotspot/share/gc/z/zForwarding.cpp + src/hotspot/share/gc/z/zForwarding.hpp + src/hotspot/share/gc/z/zForwarding.inline.hpp + src/hotspot/share/gc/z/zForwardingEntry.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp + src/hotspot/share/gc/z/zGranuleMap.hpp + src/hotspot/share/gc/z/zGranuleMap.inline.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/arraycopynode.hpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/split_if.cpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp ! src/hotspot/share/runtime/vmStructs.cpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGranuleMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c + test/hotspot/gtest/gc/z/test_zForwarding.cpp - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/compiler/codegen/BadLogicCode.java + test/hotspot/jtreg/compiler/codegen/ShiftTest.java + test/hotspot/jtreg/compiler/exceptions/ExceptionInInit.java + test/hotspot/jtreg/compiler/runtime/JITClassInit.java + test/hotspot/jtreg/gc/ArraySize.java + test/hotspot/jtreg/gc/InfiniteList.java ! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java ! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java ! test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java + test/hotspot/jtreg/runtime/ErrorHandling/ExplicitArithmeticCheck.java - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c + test/hotspot/jtreg/runtime/Thread/MonitorCacheMaybeExpand_DeadLock.java + test/hotspot/jtreg/runtime/interpreter/WideStrictInline.java + test/hotspot/jtreg/runtime/reflect/ReflectStackOverflow.java + test/hotspot/jtreg/runtime/verifier/TestStaticIF.java + test/hotspot/jtreg/runtime/verifier/VerifyProtectedConstructor.java + test/hotspot/jtreg/runtime/verifier/VerifyStackForExceptionHandlers.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c + test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/Agent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ModifyAnonymous.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAddLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDeleteJmethod.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDoubleDelete.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceCall.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithResolutionErrors.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSubtractLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RetransformClassesZeroLength.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestLambdaFormRetransformation.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestMultipleClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineWithUnresolvedClass.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.mf + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/WalkThroughInvoke.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDeleteJmethod.c + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWait/monitorwait001/monitorwait001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWaited/monitorwaited001/monitorwaited001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp + test/jdk/tools/launcher/JniInvocationTest.java + test/jdk/tools/launcher/exeJniInvocationTest.c - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java + test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadingsTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java + test/langtools/tools/javac/doclint/ImplicitHeadingsTest.java From shade at redhat.com Sat Mar 23 09:53:54 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Sat, 23 Mar 2019 10:53:54 +0100 Subject: [URGENT] RFR (XS) 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8221363 Super-class SATBMarkQueue dropped this: -SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset, bool permanent) : +SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset) : So the build fix is: diff -r c81fbf340ceb src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp --- a/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp +++ b/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp @@ -29,11 +29,11 @@ #include "runtime/mutex.hpp" #include "runtime/thread.hpp" class ShenandoahSATBMarkQueue: public SATBMarkQueue { public: - ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset, /* permanent = */ false) {} + ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset) {} virtual bool should_enqueue_buffer(); }; class ShenandoahSATBMarkQueueSet : public SATBMarkQueueSet { private: Testing: local Linux x86_64 build -Aleksey From thomas.stuefe at gmail.com Sat Mar 23 11:17:15 2019 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Sat, 23 Mar 2019 12:17:15 +0100 Subject: [URGENT] RFR (XS) 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) In-Reply-To: References: Message-ID: Looks good and trivial and fixes my build. Cheers Thomas On Sat, Mar 23, 2019 at 10:55 AM Aleksey Shipilev wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8221363 > > Super-class SATBMarkQueue dropped this: > > -SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset, bool permanent) : > +SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset) : > > So the build fix is: > > diff -r c81fbf340ceb > src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > --- a/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > +++ b/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > @@ -29,11 +29,11 @@ > #include "runtime/mutex.hpp" > #include "runtime/thread.hpp" > > class ShenandoahSATBMarkQueue: public SATBMarkQueue { > public: > - ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset, > /* permanent = */ false) {} > + ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset) {} > virtual bool should_enqueue_buffer(); > }; > > class ShenandoahSATBMarkQueueSet : public SATBMarkQueueSet { > private: > > > Testing: local Linux x86_64 build > > -Aleksey > > From shade at redhat.com Sat Mar 23 16:19:48 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Sat, 23 Mar 2019 17:19:48 +0100 Subject: [URGENT] RFR (XS) 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) In-Reply-To: References: Message-ID: On 3/23/19 12:17 PM, Thomas St?fe wrote: > Looks good and trivial and fixes my build. Thanks, pushed. -Aleksey From kim.barrett at oracle.com Sat Mar 23 20:48:14 2019 From: kim.barrett at oracle.com (Kim Barrett) Date: Sat, 23 Mar 2019 16:48:14 -0400 Subject: [URGENT] RFR (XS) 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) In-Reply-To: References: Message-ID: > On Mar 23, 2019, at 5:53 AM, Aleksey Shipilev wrote: > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8221363 > > Super-class SATBMarkQueue dropped this: > > -SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset, bool permanent) : > +SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset) : > > So the build fix is: > > diff -r c81fbf340ceb src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > --- a/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > +++ b/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp > @@ -29,11 +29,11 @@ > #include "runtime/mutex.hpp" > #include "runtime/thread.hpp" > > class ShenandoahSATBMarkQueue: public SATBMarkQueue { > public: > - ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset, /* permanent = */ false) {} > + ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset) {} > virtual bool should_enqueue_buffer(); > }; > > class ShenandoahSATBMarkQueueSet : public SATBMarkQueueSet { > private: > > > Testing: local Linux x86_64 build > > -Aleksey Looks good. (I see you?ve already pushed.) Sorry about that; I thought I?d updated Shenandoah too, but obviously missed this. From shade at redhat.com Sun Mar 24 21:50:54 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Sun, 24 Mar 2019 22:50:54 +0100 Subject: Heads-up: sh/jdk CTW failure with Traversal Message-ID: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> Seems to be 100% reproducible with: $ CONF=linux-x86_64-server-fastdebug make images run-test TEST=applications/ctw/modules/jdk_management_agent.java TEST_VM_OPTS="-XX:-TieredCompilation -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:ShenandoahGCHeuristics=traversal -XX:+ShenandoahVerifyOptoBarriers" # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/shade/trunks/shenandoah-jdk/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1606), pid=27479, tid=27489 # assert(is_dominator(phase->get_ctrl(pre_val), ctrl->in(0)->in(0), pre_val, ctrl->in(0), phase)) failed: can't move -Aleksey From shade at redhat.com Mon Mar 25 17:17:34 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 25 Mar 2019 18:17:34 +0100 Subject: LRB and 32-bit compressed oops Message-ID: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> Hi again, I was following up on experiments with LRB vs non-LRB, and spotted the thing about 32-bit compressed oops. Run the gc-bench test that writes a single int: https://icedtea.classpath.org/hg/gc-bench/ $ ~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC" writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee lrb.perfasm Run with -Xmx20g, thus enabling compressed oops, you shall see this: [Verified Entry Point] 6.94% 0x00007f60c0497050: mov %eax,-0x14000(%rsp) 5.80% 0x00007f60c0497057: push %rbp 0.30% 0x00007f60c0497058: sub $0x10,%rsp 11.81% 0x00007f60c049705c: mov 0xc(%rsi),%r11d 0.82% 0x00007f60c0497060: mov %r11,%r9 0.48% 0x00007f60c0497063: shl $0x3,%r9 .......................... LRB fastpath check .......................... 5.29% 0x00007f60c0497067: testb $0x1,0x20(%r15) 5.49% ? 0x00007f60c049706c: jne 0x00007f60c0497086 .........?......... LRB fastpath ends, store to %r9 follows ............ 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) 7.59% ?? ?? 0x00007f60c0497076: add $0x10,%rsp 6.12% ?? ?? 0x00007f60c049707a: pop %rbp 1.01% ?? ?? 0x00007f60c049707b: mov 0x108(%r15),%r10 0.63% ?? ?? 0x00007f60c0497082: test %eax,(%r10) 6.73% ?? ?? 0x00007f60c0497085: retq ---------??-??----------- LRB midpath starts -------------------------- .........?|.|?............ checking in-cset ........................... ?? ?? 0x00007f60c0497086: mov %r9,%r10 ? ?? 0x00007f60c0497089: shr $0x17,%r10 ? ?? 0x00007f60c049708d: movabs $0x7f60d00919f0,%r8 ? ?? 0x00007f60c0497097: cmpb $0x0,(%r8,%r10,1) ? ?? 0x00007f60c049709c: je 0x00007f60c049706e ............??............ checking is-forwarded ...................... ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 ?? 0x00007f60c04970a3: lea (%r12,%r11,8),%r10 ?? 0x00007f60c04970a7: cmp %r10,%r9 ?? 0x00007f60c04970aa: jne 0x00007f60c049706e .............?............... slow path call .......................... ? 0x00007f60c04970ac: mov %r9,%rdi ? 0x00007f60c04970af: movabs $0x7f60d7775030,%r10 ? 0x00007f60c04970b9: callq *%r10 ? 0x00007f60c04970bc: mov %rax,%r9 ? 0x00007f60c04970bf: jmp 0x00007f60c049706e This is actually good code. But if you add -Xmx1g, thus enabling 32-bit compressed oops, you would expect decode to go away in favor of just using the (extended) 32-bit value. Shifts are indeed gone, but register moves are still there. And that, I think, wastes registers, see: [Verified Entry Point] 6.85% 0x00007fb1284982d0: mov %eax,-0x14000(%rsp) 5.71% 0x00007fb1284982d7: push %rbp 3.14% 0x00007fb1284982d8: sub $0x10,%rsp 7.32% 0x00007fb1284982dc: mov 0xc(%rsi),%r11d 2.46% 0x00007fb1284982e0: mov %r11,%r9 <---- !!!! .......................... LRB fastpath check .......................... 2.97% 0x00007fb1284982e3: testb $0x1,0x20(%r15) 3.45% ? 0x00007fb1284982e8: jne 0x00007fb128498302 .........?......... LRB fastpath ends, store to %r9 follows ............ 3.51% ?? ?? 0x00007fb1284982ea: movl $0x2a,0xc(%r9) 7.30% ?? ?? 0x00007fb1284982f2: add $0x10,%rsp 3.12% ?? ?? 0x00007fb1284982f6: pop %rbp 2.91% ?? ?? 0x00007fb1284982f7: mov 0x108(%r15),%r10 3.23% ?? ?? 0x00007fb1284982fe: test %eax,(%r10) 4.63% ?? ?? 0x00007fb128498301: retq ---------??-??----------- LRB midpath starts -------------------------- .........?|.|?............ checking in-cset ........................... ?? ?? 0x00007fb128498302: mov %r9,%r10 ? ?? 0x00007fb128498305: shr $0x13,%r10 ? ?? 0x00007fb128498309: movabs $0x7fb13808d770,%r8 ? ?? 0x00007fb128498313: cmpb $0x0,(%r8,%r10,1) ? ?? 0x00007fb128498318: je 0x00007fb1284982ea ............??............ checking is-forwarded ...................... ?? 0x00007fb12849831a: mov -0x8(%r11),%r9 ?? 0x00007fb12849831e: mov %r11,%r10 <---- !!!! ?? 0x00007fb128498321: cmp %r10,%r9 ?? 0x00007fb128498324: jne 0x00007fb1284982ea .............?............... slow path call .......................... ? 0x00007fb128498326: mov %r9,%rdi ? 0x00007fb128498329: movabs $0x7fb13f963030,%r10 ? 0x00007fb128498333: callq *%r10 ? 0x00007fb128498336: mov %rax,%r9 ? 0x00007fb128498339: jmp 0x00007fb1284982ea 32-bit compressed oops mode is interesting, because it is the microservice range. Not sure it is LRB problem, or a generic C2 one. Thanks, -Aleksey From roman at kennke.org Mon Mar 25 18:57:16 2019 From: roman at kennke.org (roman at kennke.org) Date: Mon, 25 Mar 2019 18:57:16 +0000 Subject: hg: shenandoah/jdk: Added tag shenandoah-jdk-13+13 for changeset fc45b52439df Message-ID: <201903251857.x2PIvGkU000831@aojmv0008.oracle.com> Changeset: 6277fcfd1269 Author: rkennke Date: 2019-03-25 19:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6277fcfd1269 Added tag shenandoah-jdk-13+13 for changeset fc45b52439df ! .hgtags From rkennke at redhat.com Mon Mar 25 19:19:26 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 25 Mar 2019 20:19:26 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> Message-ID: <74b6f30e-0ab1-4733-a062-e4a44443712f@redhat.com> For some reason I don't seem to be getting your asm output. But can you try the following patch real quick? diff -r 6277fcfd1269 src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar 25 19:57:08 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar 25 20:18:53 2019 +0100 @@ -1508,7 +1508,7 @@ IfNode* iff = unc_ctrl->in(0)->as_If(); phase->igvn().replace_input_of(iff, 1, phase->igvn().intcon(1)); } - Node* addr = new AddPNode(new_val, uncasted_val, phase->igvn().MakeConX(ShenandoahBrooksPointer::byte_offset())); + Node* addr = new AddPNode(new_val, new_val, phase->igvn().MakeConX(ShenandoahBrooksPointer::byte_offset())); phase->register_new_node(addr, ctrl); assert(val->bottom_type()->isa_oopptr(), "what else?"); const TypePtr* obj_type = val->bottom_type()->is_oopptr(); Thanks, Roman Am 25.03.19 um 18:17 schrieb Aleksey Shipilev: > Hi again, > > I was following up on experiments with LRB vs non-LRB, and spotted the thing about 32-bit compressed > oops. > > Run the gc-bench test that writes a single int: > https://icedtea.classpath.org/hg/gc-bench/ > > $ ~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar > target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC" > writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee lrb.perfasm > > Run with -Xmx20g, thus enabling compressed oops, you shall see this: > > [Verified Entry Point] > 6.94% 0x00007f60c0497050: mov %eax,-0x14000(%rsp) > 5.80% 0x00007f60c0497057: push %rbp > 0.30% 0x00007f60c0497058: sub $0x10,%rsp > 11.81% 0x00007f60c049705c: mov 0xc(%rsi),%r11d > 0.82% 0x00007f60c0497060: mov %r11,%r9 > 0.48% 0x00007f60c0497063: shl $0x3,%r9 > .......................... LRB fastpath check .......................... > 5.29% 0x00007f60c0497067: testb $0x1,0x20(%r15) > 5.49% ? 0x00007f60c049706c: jne 0x00007f60c0497086 > .........?......... LRB fastpath ends, store to %r9 follows ............ > 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) > 7.59% ?? ?? 0x00007f60c0497076: add $0x10,%rsp > 6.12% ?? ?? 0x00007f60c049707a: pop %rbp > 1.01% ?? ?? 0x00007f60c049707b: mov 0x108(%r15),%r10 > 0.63% ?? ?? 0x00007f60c0497082: test %eax,(%r10) > 6.73% ?? ?? 0x00007f60c0497085: retq > ---------??-??----------- LRB midpath starts -------------------------- > .........?|.|?............ checking in-cset ........................... > ?? ?? 0x00007f60c0497086: mov %r9,%r10 > ? ?? 0x00007f60c0497089: shr $0x17,%r10 > ? ?? 0x00007f60c049708d: movabs $0x7f60d00919f0,%r8 > ? ?? 0x00007f60c0497097: cmpb $0x0,(%r8,%r10,1) > ? ?? 0x00007f60c049709c: je 0x00007f60c049706e > ............??............ checking is-forwarded ...................... > ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 > ?? 0x00007f60c04970a3: lea (%r12,%r11,8),%r10 > ?? 0x00007f60c04970a7: cmp %r10,%r9 > ?? 0x00007f60c04970aa: jne 0x00007f60c049706e > .............?............... slow path call .......................... > ? 0x00007f60c04970ac: mov %r9,%rdi > ? 0x00007f60c04970af: movabs $0x7f60d7775030,%r10 > ? 0x00007f60c04970b9: callq *%r10 > ? 0x00007f60c04970bc: mov %rax,%r9 > ? 0x00007f60c04970bf: jmp 0x00007f60c049706e > > This is actually good code. But if you add -Xmx1g, thus enabling 32-bit compressed oops, you would > expect decode to go away in favor of just using the (extended) 32-bit value. Shifts are indeed gone, > but register moves are still there. And that, I think, wastes registers, see: > > [Verified Entry Point] > 6.85% 0x00007fb1284982d0: mov %eax,-0x14000(%rsp) > 5.71% 0x00007fb1284982d7: push %rbp > 3.14% 0x00007fb1284982d8: sub $0x10,%rsp > 7.32% 0x00007fb1284982dc: mov 0xc(%rsi),%r11d > 2.46% 0x00007fb1284982e0: mov %r11,%r9 <---- !!!! > .......................... LRB fastpath check .......................... > 2.97% 0x00007fb1284982e3: testb $0x1,0x20(%r15) > 3.45% ? 0x00007fb1284982e8: jne 0x00007fb128498302 > .........?......... LRB fastpath ends, store to %r9 follows ............ > 3.51% ?? ?? 0x00007fb1284982ea: movl $0x2a,0xc(%r9) > 7.30% ?? ?? 0x00007fb1284982f2: add $0x10,%rsp > 3.12% ?? ?? 0x00007fb1284982f6: pop %rbp > 2.91% ?? ?? 0x00007fb1284982f7: mov 0x108(%r15),%r10 > 3.23% ?? ?? 0x00007fb1284982fe: test %eax,(%r10) > 4.63% ?? ?? 0x00007fb128498301: retq > ---------??-??----------- LRB midpath starts -------------------------- > .........?|.|?............ checking in-cset ........................... > ?? ?? 0x00007fb128498302: mov %r9,%r10 > ? ?? 0x00007fb128498305: shr $0x13,%r10 > ? ?? 0x00007fb128498309: movabs $0x7fb13808d770,%r8 > ? ?? 0x00007fb128498313: cmpb $0x0,(%r8,%r10,1) > ? ?? 0x00007fb128498318: je 0x00007fb1284982ea > ............??............ checking is-forwarded ...................... > ?? 0x00007fb12849831a: mov -0x8(%r11),%r9 > ?? 0x00007fb12849831e: mov %r11,%r10 <---- !!!! > ?? 0x00007fb128498321: cmp %r10,%r9 > ?? 0x00007fb128498324: jne 0x00007fb1284982ea > .............?............... slow path call .......................... > ? 0x00007fb128498326: mov %r9,%rdi > ? 0x00007fb128498329: movabs $0x7fb13f963030,%r10 > ? 0x00007fb128498333: callq *%r10 > ? 0x00007fb128498336: mov %rax,%r9 > ? 0x00007fb128498339: jmp 0x00007fb1284982ea > > 32-bit compressed oops mode is interesting, because it is the microservice range. Not sure it is LRB > problem, or a generic C2 one. > > Thanks, > -Aleksey > > From shade at redhat.com Mon Mar 25 20:17:21 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 25 Mar 2019 21:17:21 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <74b6f30e-0ab1-4733-a062-e4a44443712f@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <74b6f30e-0ab1-4733-a062-e4a44443712f@redhat.com> Message-ID: On 3/25/19 8:19 PM, Roman Kennke wrote: > For some reason I don't seem to be getting your asm output. But can you > try the following patch real quick? > > diff -r 6277fcfd1269 > src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp > --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar > 25 19:57:08 2019 +0100 > +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar > 25 20:18:53 2019 +0100 > @@ -1508,7 +1508,7 @@ > IfNode* iff = unc_ctrl->in(0)->as_If(); > phase->igvn().replace_input_of(iff, 1, phase->igvn().intcon(1)); > } > - Node* addr = new AddPNode(new_val, uncasted_val, > phase->igvn().MakeConX(ShenandoahBrooksPointer::byte_offset())); > + Node* addr = new AddPNode(new_val, new_val, > phase->igvn().MakeConX(ShenandoahBrooksPointer::byte_offset())); > phase->register_new_node(addr, ctrl); > assert(val->bottom_type()->isa_oopptr(), "what else?"); > const TypePtr* obj_type = val->bottom_type()->is_oopptr(); That does not work: the generated code is the same. -Aleksey From rkennke at redhat.com Mon Mar 25 20:35:44 2019 From: rkennke at redhat.com (Roman Kennke) Date: Mon, 25 Mar 2019 21:35:44 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> Message-ID: <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> I believe this might just be a consequence of how DecodeN is expanded in .ad: instruct decodeHeapOop(rRegP dst, rRegN src, rFlagsReg cr) %{ predicate(n->bottom_type()->is_ptr()->ptr() != TypePtr::NotNull && n->bottom_type()->is_ptr()->ptr() != TypePtr::Constant); match(Set dst (DecodeN src)); effect(KILL cr); format %{ "decode_heap_oop $dst,$src" %} ins_encode %{ Register s = $src$$Register; Register d = $dst$$Register; if (s != d) { __ movq(d, s); } __ decode_heap_oop(d); %} ins_pipe(ialu_reg_long); %} You see it takes two registers dst and src (which may or may not be the same, up to regalloc), and then : if (s != d) { __ movq(d, s); } Well. I know that C2 can handle instructions like: match(Set src (DecodeN src)); I have done this in my nofwdptr patch. However, I suspect this may not be possible here because of different reg types. Roland my know more? (Looping in...) Roman > Hi again, > > I was following up on experiments with LRB vs non-LRB, and spotted the thing about 32-bit compressed > oops. > > Run the gc-bench test that writes a single int: > https://icedtea.classpath.org/hg/gc-bench/ > > $ ~/trunks/shenandoah-jdk/build/linux-x86_64-server-release/images/jdk/bin/java -jar > target/benchmarks.jar -jvmArgs "-XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC" > writes.Plain.test_int -prof perfasm:printMargin=30 2>&1 | tee lrb.perfasm > > Run with -Xmx20g, thus enabling compressed oops, you shall see this: > > [Verified Entry Point] > 6.94% 0x00007f60c0497050: mov %eax,-0x14000(%rsp) > 5.80% 0x00007f60c0497057: push %rbp > 0.30% 0x00007f60c0497058: sub $0x10,%rsp > 11.81% 0x00007f60c049705c: mov 0xc(%rsi),%r11d > 0.82% 0x00007f60c0497060: mov %r11,%r9 > 0.48% 0x00007f60c0497063: shl $0x3,%r9 > .......................... LRB fastpath check .......................... > 5.29% 0x00007f60c0497067: testb $0x1,0x20(%r15) > 5.49% ? 0x00007f60c049706c: jne 0x00007f60c0497086 > .........?......... LRB fastpath ends, store to %r9 follows ............ > 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) > 7.59% ?? ?? 0x00007f60c0497076: add $0x10,%rsp > 6.12% ?? ?? 0x00007f60c049707a: pop %rbp > 1.01% ?? ?? 0x00007f60c049707b: mov 0x108(%r15),%r10 > 0.63% ?? ?? 0x00007f60c0497082: test %eax,(%r10) > 6.73% ?? ?? 0x00007f60c0497085: retq > ---------??-??----------- LRB midpath starts -------------------------- > .........?|.|?............ checking in-cset ........................... > ?? ?? 0x00007f60c0497086: mov %r9,%r10 > ? ?? 0x00007f60c0497089: shr $0x17,%r10 > ? ?? 0x00007f60c049708d: movabs $0x7f60d00919f0,%r8 > ? ?? 0x00007f60c0497097: cmpb $0x0,(%r8,%r10,1) > ? ?? 0x00007f60c049709c: je 0x00007f60c049706e > ............??............ checking is-forwarded ...................... > ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 > ?? 0x00007f60c04970a3: lea (%r12,%r11,8),%r10 > ?? 0x00007f60c04970a7: cmp %r10,%r9 > ?? 0x00007f60c04970aa: jne 0x00007f60c049706e > .............?............... slow path call .......................... > ? 0x00007f60c04970ac: mov %r9,%rdi > ? 0x00007f60c04970af: movabs $0x7f60d7775030,%r10 > ? 0x00007f60c04970b9: callq *%r10 > ? 0x00007f60c04970bc: mov %rax,%r9 > ? 0x00007f60c04970bf: jmp 0x00007f60c049706e > > This is actually good code. But if you add -Xmx1g, thus enabling 32-bit compressed oops, you would > expect decode to go away in favor of just using the (extended) 32-bit value. Shifts are indeed gone, > but register moves are still there. And that, I think, wastes registers, see: > > [Verified Entry Point] > 6.85% 0x00007fb1284982d0: mov %eax,-0x14000(%rsp) > 5.71% 0x00007fb1284982d7: push %rbp > 3.14% 0x00007fb1284982d8: sub $0x10,%rsp > 7.32% 0x00007fb1284982dc: mov 0xc(%rsi),%r11d > 2.46% 0x00007fb1284982e0: mov %r11,%r9 <---- !!!! > .......................... LRB fastpath check .......................... > 2.97% 0x00007fb1284982e3: testb $0x1,0x20(%r15) > 3.45% ? 0x00007fb1284982e8: jne 0x00007fb128498302 > .........?......... LRB fastpath ends, store to %r9 follows ............ > 3.51% ?? ?? 0x00007fb1284982ea: movl $0x2a,0xc(%r9) > 7.30% ?? ?? 0x00007fb1284982f2: add $0x10,%rsp > 3.12% ?? ?? 0x00007fb1284982f6: pop %rbp > 2.91% ?? ?? 0x00007fb1284982f7: mov 0x108(%r15),%r10 > 3.23% ?? ?? 0x00007fb1284982fe: test %eax,(%r10) > 4.63% ?? ?? 0x00007fb128498301: retq > ---------??-??----------- LRB midpath starts -------------------------- > .........?|.|?............ checking in-cset ........................... > ?? ?? 0x00007fb128498302: mov %r9,%r10 > ? ?? 0x00007fb128498305: shr $0x13,%r10 > ? ?? 0x00007fb128498309: movabs $0x7fb13808d770,%r8 > ? ?? 0x00007fb128498313: cmpb $0x0,(%r8,%r10,1) > ? ?? 0x00007fb128498318: je 0x00007fb1284982ea > ............??............ checking is-forwarded ...................... > ?? 0x00007fb12849831a: mov -0x8(%r11),%r9 > ?? 0x00007fb12849831e: mov %r11,%r10 <---- !!!! > ?? 0x00007fb128498321: cmp %r10,%r9 > ?? 0x00007fb128498324: jne 0x00007fb1284982ea > .............?............... slow path call .......................... > ? 0x00007fb128498326: mov %r9,%rdi > ? 0x00007fb128498329: movabs $0x7fb13f963030,%r10 > ? 0x00007fb128498333: callq *%r10 > ? 0x00007fb128498336: mov %rax,%r9 > ? 0x00007fb128498339: jmp 0x00007fb1284982ea > > 32-bit compressed oops mode is interesting, because it is the microservice range. Not sure it is LRB > problem, or a generic C2 one. > > Thanks, > -Aleksey > > From shade at redhat.com Mon Mar 25 20:40:33 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 25 Mar 2019 21:40:33 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> Message-ID: On 3/25/19 9:35 PM, Roman Kennke wrote: > I know that C2 can handle instructions like: > > match(Set src (DecodeN src)); > > I have done this in my nofwdptr patch. However, I suspect this may not > be possible here because of different reg types. > > Roland my know more? (Looping in...) Yeah, it has to happen before regalloc. I am thinking maybe DecodeNNode::Ideal should skip DecodeN when oop shift is null? But the input is probably LoadN, which is of wrong type (narrowoop), while we need just oop. -Aleksey From rkennke at redhat.com Tue Mar 26 08:03:52 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 26 Mar 2019 09:03:52 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> Message-ID: <95a6b622-e2b2-7773-5cd8-a1c8db6cd306@redhat.com> >> I know that C2 can handle instructions like: >> >> match(Set src (DecodeN src)); >> >> I have done this in my nofwdptr patch. However, I suspect this may not >> be possible here because of different reg types. >> >> Roland my know more? (Looping in...) > > Yeah, it has to happen before regalloc. I am thinking maybe DecodeNNode::Ideal should skip DecodeN > when oop shift is null? But the input is probably LoadN, which is of wrong type (narrowoop), while > we need just oop. No matter what you do, I don't think there is a way in C2 to treat rRegP and rRegN equivalent. Which means, you need some sort of cast, which may involve a mov. However, I guess the real question is, why does it want to preserve the N register. And why is it apparently doing the decode 2x later, when using the oop. It should see that the compressed oop is only used once (at the decode site), then 'decode' it once (ideally into the same register, because the original one is not needed anymore, thus avoiding the mov), and then use that subsequently. Roman From rkennke at redhat.com Tue Mar 26 08:14:44 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 26 Mar 2019 09:14:44 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> Message-ID: <580860D8-4F27-4CEE-86AE-FDC9E69EF358@redhat.com> And BTW, does that phenomenon also show with current WB? Am 25. M?rz 2019 21:40:33 MEZ schrieb Aleksey Shipilev : >On 3/25/19 9:35 PM, Roman Kennke wrote: >> I know that C2 can handle instructions like: >> >> match(Set src (DecodeN src)); >> >> I have done this in my nofwdptr patch. However, I suspect this may >not >> be possible here because of different reg types. >> >> Roland my know more? (Looping in...) > >Yeah, it has to happen before regalloc. I am thinking maybe >DecodeNNode::Ideal should skip DecodeN >when oop shift is null? But the input is probably LoadN, which is of >wrong type (narrowoop), while >we need just oop. > >-Aleksey -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From shade at redhat.com Tue Mar 26 09:10:44 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 26 Mar 2019 10:10:44 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <580860D8-4F27-4CEE-86AE-FDC9E69EF358@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> <580860D8-4F27-4CEE-86AE-FDC9E69EF358@redhat.com> Message-ID: <6827ba10-ffcd-73a2-8d4b-d5131d729a5f@redhat.com> On 3/26/19 9:14 AM, Roman Kennke wrote: > And BTW, does that phenomenon also show with current WB? I think WB does it right: [Verified Entry Point] 9.15% 0x00007f5a24490bd0: mov %eax,-0x14000(%rsp) 3.41% 0x00007f5a24490bd7: push %rbp 2.82% 0x00007f5a24490bd8: sub $0x10,%rsp 6.48% 0x00007f5a24490bdc: mov -0x8(%rsi),%r10 2.58% 0x00007f5a24490be0: mov 0xc(%r10),%r11d 3.28% 0x00007f5a24490be4: testb $0x1,0x20(%r15) <--- WB fastpath check 6.33% ? 0x00007f5a24490be9: jne 0x00007f5a24490bff 0.99% ? 0x00007f5a24490beb: movl $0x2a,0xc(%r11) <--- 32-bit coops access 11.81% ? 0x00007f5a24490bf3: add $0x10,%rsp 2.39% ? 0x00007f5a24490bf7: pop %rbp 2.65% ? 0x00007f5a24490bf8: test %eax,0x17c35402(%rip) 1.06% ? 0x00007f5a24490bfe: retq -Aleksey From rkennke at redhat.com Tue Mar 26 09:26:34 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 26 Mar 2019 10:26:34 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <6827ba10-ffcd-73a2-8d4b-d5131d729a5f@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <50cf4cc8-5d62-9830-98c8-3ef843ce9835@redhat.com> <580860D8-4F27-4CEE-86AE-FDC9E69EF358@redhat.com> <6827ba10-ffcd-73a2-8d4b-d5131d729a5f@redhat.com> Message-ID: <68791A5E-D3AE-4277-B6AF-91530FE1D101@redhat.com> Interesting. Need to see what is different there because expansion code should be almost the same as far as I know... Roman Am 26. M?rz 2019 10:10:44 MEZ schrieb Aleksey Shipilev : >On 3/26/19 9:14 AM, Roman Kennke wrote: >> And BTW, does that phenomenon also show with current WB? > >I think WB does it right: > > [Verified Entry Point] > 9.15% 0x00007f5a24490bd0: mov %eax,-0x14000(%rsp) > 3.41% 0x00007f5a24490bd7: push %rbp > 2.82% 0x00007f5a24490bd8: sub $0x10,%rsp > 6.48% 0x00007f5a24490bdc: mov -0x8(%rsi),%r10 > 2.58% 0x00007f5a24490be0: mov 0xc(%r10),%r11d >3.28% 0x00007f5a24490be4: testb $0x1,0x20(%r15) <--- WB >fastpath check > 6.33% ? 0x00007f5a24490be9: jne 0x00007f5a24490bff >0.99% ? 0x00007f5a24490beb: movl $0x2a,0xc(%r11) <--- >32-bit coops access > 11.81% ? 0x00007f5a24490bf3: add $0x10,%rsp > 2.39% ? 0x00007f5a24490bf7: pop %rbp > 2.65% ? 0x00007f5a24490bf8: test %eax,0x17c35402(%rip) > 1.06% ? 0x00007f5a24490bfe: retq > >-Aleksey -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From zgu at redhat.com Tue Mar 26 17:05:50 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Tue, 26 Mar 2019 13:05:50 -0400 Subject: RFR 8221435: Shenandoah should not mark through weak roots Message-ID: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> Please review this patch that fixes incorrectly marking through weak roots in Shenandoah. Bug: https://bugs.openjdk.java.net/browse/JDK-8221435 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221435/webrev.00/index.html Test: hotspot_gc_shenandoah on Linux x64 (fastdebug and release) Thanks, -Zhengyu From shade at redhat.com Tue Mar 26 17:21:34 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 26 Mar 2019 18:21:34 +0100 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> Message-ID: On 3/26/19 6:05 PM, Zhengyu Gu wrote: > Please review this patch that fixes incorrectly marking through weak roots in Shenandoah. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221435 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221435/webrev.00/index.html *) Please qrefresh the changeset comment *) shenandoahConcurrentMark.cpp, indenting at L660..L661 659 if (_heap->has_forwarded_objects()) { 660 ShenandoahWeakUpdateClosure cl; 661 WeakProcessor::weak_oops_do(workers, is_alive.is_alive_closure(), &cl, 1); 662 } else { 663 ShenandoahWeakAssertNotForwardedClosure cl; 664 WeakProcessor::weak_oops_do(workers, is_alive.is_alive_closure(), &cl, 1); 665 } *) I think the WeakProcessor::weak_oops_do is deliberately called with serial version when ShenandoahWeakAssertNotForwardedClosure is handled. Maybe that prolongs weak root handling unnecessarily? Anyhow, this comment needs to be moved to new code: 709 // Process leftover weak oops: update them, if needed (using parallel version), 710 // or assert they do not need updating (using serial version) otherwise. 711 // Weak processor API requires us to visit the oops, even if we are not doing 712 // anything to them. *) The distinction between ShenandoahRootProcessor::process_all_roots, ::update_all_roots, ::traversal_update_all_roots might be better? (I cannot see the better factoring right away, though). -Aleksey From zgu at redhat.com Tue Mar 26 18:01:44 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Tue, 26 Mar 2019 14:01:44 -0400 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> Message-ID: Updated: http://cr.openjdk.java.net/~zgu/JDK-8221435/webrev.01/ On 3/26/19 1:21 PM, Aleksey Shipilev wrote: > On 3/26/19 6:05 PM, Zhengyu Gu wrote: >> Please review this patch that fixes incorrectly marking through weak roots in Shenandoah. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8221435 >> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221435/webrev.00/index.html > > *) Please qrefresh the changeset comment > > *) shenandoahConcurrentMark.cpp, indenting at L660..L661 > > 659 if (_heap->has_forwarded_objects()) { > 660 ShenandoahWeakUpdateClosure cl; > 661 WeakProcessor::weak_oops_do(workers, is_alive.is_alive_closure(), &cl, 1); > 662 } else { > 663 ShenandoahWeakAssertNotForwardedClosure cl; > 664 WeakProcessor::weak_oops_do(workers, is_alive.is_alive_closure(), &cl, 1); > 665 } Fixed. > > *) I think the WeakProcessor::weak_oops_do is deliberately called with serial version when > ShenandoahWeakAssertNotForwardedClosure is handled. Maybe that prolongs weak root handling > unnecessarily? Anyhow, this comment needs to be moved to new code: I was puzzled by this also. It may be the case in early days, when there are few oop storages? seems we definitely can benefit parallel version, because there are more oop storages to process. Roman, do you recall the reason why it was done this way? ShenandoahWeakAssertNotForwardedClosure is debug only closure, surround the body with ifdef. > > 709 // Process leftover weak oops: update them, if needed (using parallel version), > 710 // or assert they do not need updating (using serial version) otherwise. > 711 // Weak processor API requires us to visit the oops, even if we are not doing > 712 // anything to them. > > *) The distinction between ShenandoahRootProcessor::process_all_roots, ::update_all_roots, > ::traversal_update_all_roots might be better? (I cannot see the better factoring right away, though). > There are inconsistencies in traversal, I am looking into them in follow up RFE, will address this there. Thanks, -Zhengyu > -Aleksey > From rkennke at redhat.com Tue Mar 26 19:31:10 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 26 Mar 2019 20:31:10 +0100 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> Message-ID: <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> >> *) I think the WeakProcessor::weak_oops_do is deliberately called with >> serial version when >> ShenandoahWeakAssertNotForwardedClosure is handled. Maybe that >> prolongs weak root handling >> unnecessarily? Anyhow, this comment needs to be moved to new code: > > I was puzzled by this also. It may be the case in early days, when there > are few oop storages? seems we definitely can benefit parallel version, > because there are more oop storages to process. > > Roman, do you recall the reason why it was done this way? > > ShenandoahWeakAssertNotForwardedClosure is debug only closure, surround > the body with ifdef. Well, as you say, it's debug-only, so shouldn't matter performance-wise. Except, as you say, it should be #ifdef ASSERT. It wasn't #ifdef'd before? WTF? Other than that, looks good. Maybe we should wait until we have fixes for: https://bugs.openjdk.java.net/browse/JDK-8221102 and https://bugs.openjdk.java.net/browse/JDK-8220671 in sh/jdk, so that we have a stable testing base? Roman >> ? 709???? // Process leftover weak oops: update them, if needed (using >> parallel version), >> ? 710???? // or assert they do not need updating (using serial >> version) otherwise. >> ? 711???? // Weak processor API requires us to visit the oops, even if >> we are not doing >> ? 712???? // anything to them. >> >> *) The distinction between ShenandoahRootProcessor::process_all_roots, >> ::update_all_roots, >> ::traversal_update_all_roots might be better? (I cannot see the better >> factoring right away, though). >> > There are inconsistencies in traversal, I am looking into them in follow > up RFE, will address this there. > > Thanks, > > -Zhengyu > > >> -Aleksey >> From shade at redhat.com Tue Mar 26 19:42:15 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 26 Mar 2019 20:42:15 +0100 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> Message-ID: <37dc92cc-f530-1739-af49-c2e8a22ce3a6@redhat.com> On 3/26/19 8:31 PM, Roman Kennke wrote: >> Roman, do you recall the reason why it was done this way? >> >> ShenandoahWeakAssertNotForwardedClosure is debug only closure, surround the body with ifdef. > > Well, as you say, it's debug-only, so shouldn't matter performance-wise. Except, as you say, it > should be #ifdef ASSERT. It wasn't #ifdef'd before? WTF? The comment says why. You need to go over them, even with no-op closure. Not sure if it is still relevant today: 711 // Weak processor API requires us to visit the oops, even if we are not doing 712 // anything to them. -Aleksey From zgu at redhat.com Tue Mar 26 19:54:19 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Tue, 26 Mar 2019 15:54:19 -0400 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: <37dc92cc-f530-1739-af49-c2e8a22ce3a6@redhat.com> References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> <37dc92cc-f530-1739-af49-c2e8a22ce3a6@redhat.com> Message-ID: On 3/26/19 3:42 PM, Aleksey Shipilev wrote: > On 3/26/19 8:31 PM, Roman Kennke wrote: >>> Roman, do you recall the reason why it was done this way? >>> >>> ShenandoahWeakAssertNotForwardedClosure is debug only closure, surround the body with ifdef. >> >> Well, as you say, it's debug-only, so shouldn't matter performance-wise. Except, as you say, it >> should be #ifdef ASSERT. It wasn't #ifdef'd before? WTF? > > The comment says why. You need to go over them, even with no-op closure. Not sure if it is still > relevant today: > > 711 // Weak processor API requires us to visit the oops, even if we are not doing > 712 // anything to them. Yes, it is still relevant: it only needs is_alive closure to NULL dead entries -Zhengyu > > -Aleksey > From zgu at redhat.com Tue Mar 26 19:59:12 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Tue, 26 Mar 2019 15:59:12 -0400 Subject: RFR 8221435: Shenandoah should not mark through weak roots In-Reply-To: <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> References: <52b59e27-2774-e998-2c9f-8fdbb3bffd7a@redhat.com> <2de912cc-6985-3414-dbb0-324cff39d2fa@redhat.com> Message-ID: <0ca6384c-0e58-1792-7c1c-2d9f37b39118@redhat.com> On 3/26/19 3:31 PM, Roman Kennke wrote: > > >>> *) I think the WeakProcessor::weak_oops_do is deliberately called >>> with serial version when >>> ShenandoahWeakAssertNotForwardedClosure is handled. Maybe that >>> prolongs weak root handling >>> unnecessarily? Anyhow, this comment needs to be moved to new code: >> >> I was puzzled by this also. It may be the case in early days, when >> there are few oop storages? seems we definitely can benefit parallel >> version, because there are more oop storages to process. >> >> Roman, do you recall the reason why it was done this way? >> >> ShenandoahWeakAssertNotForwardedClosure is debug only closure, >> surround the body with ifdef. > > Well, as you say, it's debug-only, so shouldn't matter performance-wise. > Except, as you say, it should be #ifdef ASSERT. It wasn't #ifdef'd > before? WTF? > > Other than that, looks good. Maybe we should wait until we have fixes for: > > https://bugs.openjdk.java.net/browse/JDK-8221102 > and > https://bugs.openjdk.java.net/browse/JDK-8220671 Okay, I can hold off for them. -Zhengyu > > in sh/jdk, so that we have a stable testing base? > > Roman > >>> ? 709???? // Process leftover weak oops: update them, if needed >>> (using parallel version), >>> ? 710???? // or assert they do not need updating (using serial >>> version) otherwise. >>> ? 711???? // Weak processor API requires us to visit the oops, even >>> if we are not doing >>> ? 712???? // anything to them. >>> >>> *) The distinction between >>> ShenandoahRootProcessor::process_all_roots, ::update_all_roots, >>> ::traversal_update_all_roots might be better? (I cannot see the >>> better factoring right away, though). >>> >> There are inconsistencies in traversal, I am looking into them in >> follow up RFE, will address this there. >> >> Thanks, >> >> -Zhengyu >> >> >>> -Aleksey >>> From kdobson at redhat.com Tue Mar 26 20:36:58 2019 From: kdobson at redhat.com (Ken Dobson) Date: Tue, 26 Mar 2019 16:36:58 -0400 Subject: RFR 8221507: Implement JFR Events for Shenandoah Message-ID: Hi all, Please review this patch that adds support for two new JFR events ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation. Bug: https://bugs.openjdk.java.net/browse/JDK-8221507 Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/ The events appears to result in ~2% overhead though there is some uncertainty as to whether some of that is noise. Thanks, Ken Dobson From rkennke at redhat.com Tue Mar 26 21:16:49 2019 From: rkennke at redhat.com (Roman Kennke) Date: Tue, 26 Mar 2019 22:16:49 +0100 Subject: RFR 8221507: Implement JFR Events for Shenandoah In-Reply-To: References: Message-ID: <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com> > Please review this patch that adds support for two new JFR events > ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221507 > Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/ > > The events appears to result in ~2% overhead though there is some > uncertainty as to whether some of that is noise. > > Thanks, > > Ken Dobson Very nice! The overhead is only present with JFR active, I assume? Have you run hotspot_gc_shenandoah tests? Other than that, the patch looks good. Thank you!! Roman From shade at redhat.com Wed Mar 27 12:33:55 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 27 Mar 2019 13:33:55 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+5 to sh/jdk11 Message-ID: <610084a7-b4df-ec50-24dd-74f2b311aeee@redhat.com> Upstream^W We have pushed the jdk-11.0.3+5 tag upstream to jdk-updates/jdk11u. Let's pick it up to sh/jdk11. The merge is trivial, and includes a single testbug fix. Summary of changes: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b5/changesets.txt Webrev: http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b5/webrev.01/ Since this is the trivial merge, I plan to skip any further testing, and just tag itshenandoah-jdk-11.0.3+5 right away. Testing: x86_64 fastdebug build Thanks, -Aleksey From rkennke at redhat.com Wed Mar 27 13:35:36 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 14:35:36 +0100 Subject: RFC/RFR: Pick up jdk-11.0.3+5 to sh/jdk11 In-Reply-To: <610084a7-b4df-ec50-24dd-74f2b311aeee@redhat.com> References: <610084a7-b4df-ec50-24dd-74f2b311aeee@redhat.com> Message-ID: <42e687e9-fa91-97cd-fb2e-1b7353bd6f51@redhat.com> Yup! Go! Roman > Upstream^W We have pushed the jdk-11.0.3+5 tag upstream to jdk-updates/jdk11u. Let's pick it up to > sh/jdk11. The merge is trivial, and includes a single testbug fix. > > Summary of changes: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b5/changesets.txt > > Webrev: > http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.3%2b5/webrev.01/ > > Since this is the trivial merge, I plan to skip any further testing, and just tag > itshenandoah-jdk-11.0.3+5 right away. > > Testing: x86_64 fastdebug build > > Thanks, > -Aleksey > From rwestrel at redhat.com Wed Mar 27 14:28:03 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 27 Mar 2019 15:28:03 +0100 Subject: Heads-up: sh/jdk CTW failure with Traversal In-Reply-To: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> References: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> Message-ID: <87d0mcs87g.fsf@redhat.com> Fix is below. If one enqueue barrier feeds into another one, we only need to keep one. Roland. diff -r 6277fcfd1269 src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar 25 19:57:08 2019 +0100 +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Wed Mar 27 15:25:24 2019 +0100 @@ -2101,6 +2101,7 @@ int ShenandoahEnqueueBarrierNode::needed(Node* n) { if (n == NULL || n->is_Allocate() || + n->Opcode() == Op_ShenandoahEnqueueBarrier || n->bottom_type() == TypePtr::NULL_PTR || (n->bottom_type()->make_oopptr() != NULL && n->bottom_type()->make_oopptr()->const_oop() != NULL)) { return NotNeeded; From rkennke at redhat.com Wed Mar 27 14:46:59 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 15:46:59 +0100 Subject: Heads-up: sh/jdk CTW failure with Traversal In-Reply-To: <87d0mcs87g.fsf@redhat.com> References: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> <87d0mcs87g.fsf@redhat.com> Message-ID: Great, thanks!! I'll run tests with it, and let you know! Roman > Fix is below. If one enqueue barrier feeds into another one, we only > need to keep one. > > Roland. > > diff -r 6277fcfd1269 src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp > --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar 25 19:57:08 2019 +0100 > +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Wed Mar 27 15:25:24 2019 +0100 > @@ -2101,6 +2101,7 @@ > int ShenandoahEnqueueBarrierNode::needed(Node* n) { > if (n == NULL || > n->is_Allocate() || > + n->Opcode() == Op_ShenandoahEnqueueBarrier || > n->bottom_type() == TypePtr::NULL_PTR || > (n->bottom_type()->make_oopptr() != NULL && n->bottom_type()->make_oopptr()->const_oop() != NULL)) { > return NotNeeded; > From shade at redhat.com Wed Mar 27 14:57:21 2019 From: shade at redhat.com (shade at redhat.com) Date: Wed, 27 Mar 2019 14:57:21 +0000 Subject: hg: shenandoah/jdk11: 4 new changesets Message-ID: <201903271457.x2REvLvF015671@aojmv0008.oracle.com> Changeset: c9865fee1a6d Author: clanger Date: 2019-03-21 09:16 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/c9865fee1a6d 8172695: (scanner) java/util/Scanner/ScanTest.java fails Reviewed-by: smarks, bpb ! test/jdk/java/util/Scanner/ScanTest.java Changeset: dd4470fa81fe Author: goetz Date: 2019-03-27 11:05 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/dd4470fa81fe Added tag jdk-11.0.3+5 for changeset c9865fee1a6d ! .hgtags Changeset: 414ba22887a8 Author: shade Date: 2019-03-27 13:18 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/414ba22887a8 Merge ! .hgtags Changeset: 6d805534abdc Author: shade Date: 2019-03-27 13:19 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk11/rev/6d805534abdc Added tag shenandoah-jdk-11.0.3+5 for changeset 414ba22887a8 ! .hgtags From rkennke at redhat.com Wed Mar 27 15:20:33 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 16:20:33 +0100 Subject: Heads-up: sh/jdk CTW failure with Traversal In-Reply-To: <87d0mcs87g.fsf@redhat.com> References: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> <87d0mcs87g.fsf@redhat.com> Message-ID: Testing looks good. Patch also looks good. Push it! :-) Roman > Fix is below. If one enqueue barrier feeds into another one, we only > need to keep one. > > Roland. > > diff -r 6277fcfd1269 src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp > --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Mon Mar 25 19:57:08 2019 +0100 > +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Wed Mar 27 15:25:24 2019 +0100 > @@ -2101,6 +2101,7 @@ > int ShenandoahEnqueueBarrierNode::needed(Node* n) { > if (n == NULL || > n->is_Allocate() || > + n->Opcode() == Op_ShenandoahEnqueueBarrier || > n->bottom_type() == TypePtr::NULL_PTR || > (n->bottom_type()->make_oopptr() != NULL && n->bottom_type()->make_oopptr()->const_oop() != NULL)) { > return NotNeeded; > From rkennke at redhat.com Wed Mar 27 15:23:26 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 16:23:26 +0100 Subject: Heads-up: sh/jdk CTW failure with Traversal In-Reply-To: References: <9c29b478-6763-1e39-57db-6d4617c83f82@redhat.com> <87d0mcs87g.fsf@redhat.com> Message-ID: > Testing looks good. Patch also looks good. Push it! :-) I meant to say, file bug and RFR it properly, then push to jdk/jdk ;-) Roman > Roman > > >> Fix is below. If one enqueue barrier feeds into another one, we only >> need to keep one. >> >> Roland. >> >> diff -r 6277fcfd1269 >> src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp >> --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp??? Mon >> Mar 25 19:57:08 2019 +0100 >> +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp??? Wed >> Mar 27 15:25:24 2019 +0100 >> @@ -2101,6 +2101,7 @@ >> ? int ShenandoahEnqueueBarrierNode::needed(Node* n) { >> ??? if (n == NULL || >> ??????? n->is_Allocate() || >> +????? n->Opcode() == Op_ShenandoahEnqueueBarrier || >> ??????? n->bottom_type() == TypePtr::NULL_PTR || >> ??????? (n->bottom_type()->make_oopptr() != NULL && >> n->bottom_type()->make_oopptr()->const_oop() != NULL)) { >> ????? return NotNeeded; >> From omar.kilani at gmail.com Wed Mar 27 18:34:09 2019 From: omar.kilani at gmail.com (Omar Kilani) Date: Wed, 27 Mar 2019 11:34:09 -0700 Subject: JVM crash in ShenandoahInitMarkRootsClosure Message-ID: Hi there, We're testing: OpenJDK 64-Bit Server VM (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) And had a crash in one of our applications: --------------- T H R E A D --------------- Current thread (0x00007febe8156000): GCTaskThread "Shenandoah GC Threads#5" [stack: 0x00007febec68a000,0x00007febec78a000] [id=2927] Stack: [0x00007febec68a000,0x00007febec78a000], sp=0x00007febec788ae0, free space=1018k Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0xd24b2d] ShenandoahInitMarkRootsClosure<(UpdateRefsMode)0, (StringDedupMode)1>::do_oop(oopDesc**)+0x7d V [libjvm.so+0xd7c6c6] ShenandoahStrDedupQueue::unlink_or_oops_do_impl(StringDedupUnlinkOrOopsDoClosure*, unsigned long)+0x96 V [libjvm.so+0xe09aa3] StringDedupQueue::unlink_or_oops_do(StringDedupUnlinkOrOopsDoClosure*)+0x43 V [libjvm.so+0xd7d3e8] ShenandoahStringDedup::parallel_oops_do(OopClosure*, unsigned int)+0x58 V [libjvm.so+0xd7b4f1] ShenandoahRootProcessor::process_vm_roots(OopClosure*, OopClosure*, OopClosure*, unsigned int)+0x111 V [libjvm.so+0xd7b87a] ShenandoahRootProcessor::process_all_roots(OopClosure*, OopClosure*, CLDClosure*, CodeBlobClosure*, ThreadClosure*, unsigned int)+0x7a V [libjvm.so+0xd19000] ShenandoahInitMarkRootsTask<(UpdateRefsMode)0>::work(unsigned int)+0x200 V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d V [libjvm.so+0xec2b35] Thread::call_run()+0x75 V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: 0x0000000000000000 -- Is this fixed by: https://bugs.openjdk.java.net/browse/JDK-8221278 ? :) Thanks! Regards, Omar From rkennke at redhat.com Wed Mar 27 18:39:04 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 19:39:04 +0100 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: Message-ID: Hi Omar, yes, that seems very likely. The fix should appear in nightlies very soon. Thanks, Roman > Hi there, > > We're testing: > > OpenJDK 64-Bit Server VM > (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) > > And had a crash in one of our applications: > > --------------- T H R E A D --------------- > Current thread (0x00007febe8156000): GCTaskThread "Shenandoah GC > Threads#5" [stack: 0x00007febec68a000,0x00007febec78a000] [id=2927] > Stack: [0x00007febec68a000,0x00007febec78a000], > sp=0x00007febec788ae0, free space=1018k > > Native frames: (J=compiled Java code, A=aot compiled Java code, > j=interpreted, Vv=VM code, C=native code) > > V [libjvm.so+0xd24b2d] > ShenandoahInitMarkRootsClosure<(UpdateRefsMode)0, > (StringDedupMode)1>::do_oop(oopDesc**)+0x7d > V [libjvm.so+0xd7c6c6] > ShenandoahStrDedupQueue::unlink_or_oops_do_impl(StringDedupUnlinkOrOopsDoClosure*, > unsigned long)+0x96 > V [libjvm.so+0xe09aa3] > StringDedupQueue::unlink_or_oops_do(StringDedupUnlinkOrOopsDoClosure*)+0x43 > V [libjvm.so+0xd7d3e8] > ShenandoahStringDedup::parallel_oops_do(OopClosure*, unsigned > int)+0x58 > V [libjvm.so+0xd7b4f1] > ShenandoahRootProcessor::process_vm_roots(OopClosure*, OopClosure*, > OopClosure*, unsigned int)+0x111 > V [libjvm.so+0xd7b87a] > ShenandoahRootProcessor::process_all_roots(OopClosure*, OopClosure*, > CLDClosure*, CodeBlobClosure*, ThreadClosure*, unsigned int)+0x7a > V [libjvm.so+0xd19000] > ShenandoahInitMarkRootsTask<(UpdateRefsMode)0>::work(unsigned > int)+0x200 > V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d > V [libjvm.so+0xec2b35] Thread::call_run()+0x75 > V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee > > siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: > 0x0000000000000000 > > -- > > Is this fixed by: > > https://bugs.openjdk.java.net/browse/JDK-8221278 > > ? :) > > Thanks! > > Regards, > Omar > From omar.kilani at gmail.com Wed Mar 27 18:42:30 2019 From: omar.kilani at gmail.com (Omar Kilani) Date: Wed, 27 Mar 2019 11:42:30 -0700 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: Message-ID: Hi Roman, We also see: --------------- T H R E A D --------------- Current thread (0x00007fa0ac192800): GCTaskThread "Shenandoah GC Threads#9" [stack: 0x00007fa08d1f6000,0x00007fa08d2f6000] [id=10523] Stack: [0x00007fa08d1f6000,0x00007fa08d2f6000], sp=0x00007fa08d2f4520, free space=1017k Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0xd6ccd8] void ShenandoahHeap::marked_object_iterate*, HeapWord*)+0x288 V [libjvm.so+0xd6d54d] ShenandoahUpdateHeapRefsTask::do_work()+0xad V [libjvm.so+0xd6d70c] ShenandoahUpdateHeapRefsTask::work(unsigned int)+0x5c V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d V [libjvm.so+0xec2b35] Thread::call_run()+0x75 V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x00007fa4af6422a0 -- In a different app. Is this the same bug, or a different thing? Thanks! Regards, Omar On Wed, Mar 27, 2019 at 11:39 AM Roman Kennke wrote: > > Hi Omar, > > yes, that seems very likely. The fix should appear in nightlies very soon. > > Thanks, Roman > > > > Hi there, > > > > We're testing: > > > > OpenJDK 64-Bit Server VM > > (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) > > > > And had a crash in one of our applications: > > > > --------------- T H R E A D --------------- > > Current thread (0x00007febe8156000): GCTaskThread "Shenandoah GC > > Threads#5" [stack: 0x00007febec68a000,0x00007febec78a000] [id=2927] > > Stack: [0x00007febec68a000,0x00007febec78a000], > > sp=0x00007febec788ae0, free space=1018k > > > > Native frames: (J=compiled Java code, A=aot compiled Java code, > > j=interpreted, Vv=VM code, C=native code) > > > > V [libjvm.so+0xd24b2d] > > ShenandoahInitMarkRootsClosure<(UpdateRefsMode)0, > > (StringDedupMode)1>::do_oop(oopDesc**)+0x7d > > V [libjvm.so+0xd7c6c6] > > ShenandoahStrDedupQueue::unlink_or_oops_do_impl(StringDedupUnlinkOrOopsDoClosure*, > > unsigned long)+0x96 > > V [libjvm.so+0xe09aa3] > > StringDedupQueue::unlink_or_oops_do(StringDedupUnlinkOrOopsDoClosure*)+0x43 > > V [libjvm.so+0xd7d3e8] > > ShenandoahStringDedup::parallel_oops_do(OopClosure*, unsigned > > int)+0x58 > > V [libjvm.so+0xd7b4f1] > > ShenandoahRootProcessor::process_vm_roots(OopClosure*, OopClosure*, > > OopClosure*, unsigned int)+0x111 > > V [libjvm.so+0xd7b87a] > > ShenandoahRootProcessor::process_all_roots(OopClosure*, OopClosure*, > > CLDClosure*, CodeBlobClosure*, ThreadClosure*, unsigned int)+0x7a > > V [libjvm.so+0xd19000] > > ShenandoahInitMarkRootsTask<(UpdateRefsMode)0>::work(unsigned > > int)+0x200 > > V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d > > V [libjvm.so+0xec2b35] Thread::call_run()+0x75 > > V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee > > > > siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: > > 0x0000000000000000 > > > > -- > > > > Is this fixed by: > > > > https://bugs.openjdk.java.net/browse/JDK-8221278 > > > > ? :) > > > > Thanks! > > > > Regards, > > Omar > > > From rkennke at redhat.com Wed Mar 27 18:48:39 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 19:48:39 +0100 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: Message-ID: It's hard to say. Does it happen without -XX:+UseStringDeduplication ? JDK-8221278 is only relevant with string deduplication explicitely turned on. Roman > We also see: > > --------------- T H R E A D --------------- > Current thread (0x00007fa0ac192800): GCTaskThread "Shenandoah GC > Threads#9" [stack: 0x00007fa08d1f6000,0x00007fa08d2f6000] [id=10523] > > Stack: [0x00007fa08d1f6000,0x00007fa08d2f6000], > sp=0x00007fa08d2f4520, free space=1017k > > Native frames: (J=compiled Java code, A=aot compiled Java code, > j=interpreted, Vv=VM code, C=native code) > > V [libjvm.so+0xd6ccd8] void > ShenandoahHeap::marked_object_iterate (ShenandoahHeapRegion*, > ShenandoahObjectToOopClosure*, > HeapWord*)+0x288 > V [libjvm.so+0xd6d54d] > ShenandoahUpdateHeapRefsTask::do_work()+0xad > V [libjvm.so+0xd6d70c] > ShenandoahUpdateHeapRefsTask::work(unsigned > int)+0x5c > V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d > V [libjvm.so+0xec2b35] Thread::call_run()+0x75 > V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee > > siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: > 0x00007fa4af6422a0 > > -- > > In a different app. Is this the same bug, or a different thing? > > Thanks! > > Regards, > Omar > > On Wed, Mar 27, 2019 at 11:39 AM Roman Kennke wrote: >> >> Hi Omar, >> >> yes, that seems very likely. The fix should appear in nightlies very soon. >> >> Thanks, Roman >> >> >>> Hi there, >>> >>> We're testing: >>> >>> OpenJDK 64-Bit Server VM >>> (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) >>> >>> And had a crash in one of our applications: >>> >>> --------------- T H R E A D --------------- >>> Current thread (0x00007febe8156000): GCTaskThread "Shenandoah GC >>> Threads#5" [stack: 0x00007febec68a000,0x00007febec78a000] [id=2927] >>> Stack: [0x00007febec68a000,0x00007febec78a000], >>> sp=0x00007febec788ae0, free space=1018k >>> >>> Native frames: (J=compiled Java code, A=aot compiled Java code, >>> j=interpreted, Vv=VM code, C=native code) >>> >>> V [libjvm.so+0xd24b2d] >>> ShenandoahInitMarkRootsClosure<(UpdateRefsMode)0, >>> (StringDedupMode)1>::do_oop(oopDesc**)+0x7d >>> V [libjvm.so+0xd7c6c6] >>> ShenandoahStrDedupQueue::unlink_or_oops_do_impl(StringDedupUnlinkOrOopsDoClosure*, >>> unsigned long)+0x96 >>> V [libjvm.so+0xe09aa3] >>> StringDedupQueue::unlink_or_oops_do(StringDedupUnlinkOrOopsDoClosure*)+0x43 >>> V [libjvm.so+0xd7d3e8] >>> ShenandoahStringDedup::parallel_oops_do(OopClosure*, unsigned >>> int)+0x58 >>> V [libjvm.so+0xd7b4f1] >>> ShenandoahRootProcessor::process_vm_roots(OopClosure*, OopClosure*, >>> OopClosure*, unsigned int)+0x111 >>> V [libjvm.so+0xd7b87a] >>> ShenandoahRootProcessor::process_all_roots(OopClosure*, OopClosure*, >>> CLDClosure*, CodeBlobClosure*, ThreadClosure*, unsigned int)+0x7a >>> V [libjvm.so+0xd19000] >>> ShenandoahInitMarkRootsTask<(UpdateRefsMode)0>::work(unsigned >>> int)+0x200 >>> V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d >>> V [libjvm.so+0xec2b35] Thread::call_run()+0x75 >>> V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee >>> >>> siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: >>> 0x0000000000000000 >>> >>> -- >>> >>> Is this fixed by: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8221278 >>> >>> ? :) >>> >>> Thanks! >>> >>> Regards, >>> Omar >>> >> From omar.kilani at gmail.com Wed Mar 27 18:52:35 2019 From: omar.kilani at gmail.com (Omar Kilani) Date: Wed, 27 Mar 2019 11:52:35 -0700 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: Message-ID: Hi Roman, I?ll try and let you know. It kind of ran fine for a week or so before the various crashes. There was another change that I saw that seemed related to this but can?t find it easily on my phone. Anyway, will report back. :) Regards, Omar On Wed, Mar 27, 2019 at 11:48 AM Roman Kennke wrote: > It's hard to say. Does it happen without -XX:+UseStringDeduplication ? > JDK-8221278 is only relevant with string deduplication explicitely > turned on. > > Roman > > > We also see: > > > > --------------- T H R E A D --------------- > > Current thread (0x00007fa0ac192800): GCTaskThread "Shenandoah GC > > Threads#9" [stack: 0x00007fa08d1f6000,0x00007fa08d2f6000] [id=10523] > > > > Stack: [0x00007fa08d1f6000,0x00007fa08d2f6000], > > sp=0x00007fa08d2f4520, free space=1017k > > > > Native frames: (J=compiled Java code, A=aot compiled Java code, > > j=interpreted, Vv=VM code, C=native code) > > > > V [libjvm.so+0xd6ccd8] void > > > ShenandoahHeap::marked_object_iterate > (ShenandoahHeapRegion*, > > ShenandoahObjectToOopClosure*, > > HeapWord*)+0x288 > > V [libjvm.so+0xd6d54d] > > > ShenandoahUpdateHeapRefsTask::do_work()+0xad > > V [libjvm.so+0xd6d70c] > > > ShenandoahUpdateHeapRefsTask::work(unsigned > > int)+0x5c > > V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d > > V [libjvm.so+0xec2b35] Thread::call_run()+0x75 > > V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee > > > > siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: > > 0x00007fa4af6422a0 > > > > -- > > > > In a different app. Is this the same bug, or a different thing? > > > > Thanks! > > > > Regards, > > Omar > > > > On Wed, Mar 27, 2019 at 11:39 AM Roman Kennke > wrote: > >> > >> Hi Omar, > >> > >> yes, that seems very likely. The fix should appear in nightlies very > soon. > >> > >> Thanks, Roman > >> > >> > >>> Hi there, > >>> > >>> We're testing: > >>> > >>> OpenJDK 64-Bit Server VM > >>> (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) > >>> > >>> And had a crash in one of our applications: > >>> > >>> --------------- T H R E A D --------------- > >>> Current thread (0x00007febe8156000): GCTaskThread "Shenandoah GC > >>> Threads#5" [stack: 0x00007febec68a000,0x00007febec78a000] [id=2927] > >>> Stack: [0x00007febec68a000,0x00007febec78a000], > >>> sp=0x00007febec788ae0, free space=1018k > >>> > >>> Native frames: (J=compiled Java code, A=aot compiled Java code, > >>> j=interpreted, Vv=VM code, C=native code) > >>> > >>> V [libjvm.so+0xd24b2d] > >>> ShenandoahInitMarkRootsClosure<(UpdateRefsMode)0, > >>> (StringDedupMode)1>::do_oop(oopDesc**)+0x7d > >>> V [libjvm.so+0xd7c6c6] > >>> > ShenandoahStrDedupQueue::unlink_or_oops_do_impl(StringDedupUnlinkOrOopsDoClosure*, > >>> unsigned long)+0x96 > >>> V [libjvm.so+0xe09aa3] > >>> > StringDedupQueue::unlink_or_oops_do(StringDedupUnlinkOrOopsDoClosure*)+0x43 > >>> V [libjvm.so+0xd7d3e8] > >>> ShenandoahStringDedup::parallel_oops_do(OopClosure*, unsigned > >>> int)+0x58 > >>> V [libjvm.so+0xd7b4f1] > >>> ShenandoahRootProcessor::process_vm_roots(OopClosure*, OopClosure*, > >>> OopClosure*, unsigned int)+0x111 > >>> V [libjvm.so+0xd7b87a] > >>> ShenandoahRootProcessor::process_all_roots(OopClosure*, OopClosure*, > >>> CLDClosure*, CodeBlobClosure*, ThreadClosure*, unsigned int)+0x7a > >>> V [libjvm.so+0xd19000] > >>> ShenandoahInitMarkRootsTask<(UpdateRefsMode)0>::work(unsigned > >>> int)+0x200 > >>> V [libjvm.so+0xf565bd] GangWorker::loop()+0x4d > >>> V [libjvm.so+0xec2b35] Thread::call_run()+0x75 > >>> V [libjvm.so+0xc000ce] thread_native_entry(Thread*)+0xee > >>> > >>> siginfo: si_signo: 11 (SIGSEGV), si_code: 128 (SI_KERNEL), si_addr: > >>> 0x0000000000000000 > >>> > >>> -- > >>> > >>> Is this fixed by: > >>> > >>> https://bugs.openjdk.java.net/browse/JDK-8221278 > >>> > >>> ? :) > >>> > >>> Thanks! > >>> > >>> Regards, > >>> Omar > >>> > >> > From shade at redhat.com Wed Mar 27 19:48:13 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 27 Mar 2019 20:48:13 +0100 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: Message-ID: <1cf68a6d-1d4b-7e4e-54a5-c8bb1ee9dace@redhat.com> On 3/27/19 7:39 PM, Roman Kennke wrote: > yes, that seems very likely. The fix should appear in nightlies very soon. Got the 12u maintainer's approval, finally. Pushed the fixes. The builds would trigger in due course, and I think they would be ready by tomorrow morning (e.g. within next 12 hrs). Omar, you have b140: (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) ...you need the build b149 or later. -Aleksey From omar.kilani at gmail.com Wed Mar 27 19:54:39 2019 From: omar.kilani at gmail.com (Omar Kilani) Date: Wed, 27 Mar 2019 12:54:39 -0700 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: <1cf68a6d-1d4b-7e4e-54a5-c8bb1ee9dace@redhat.com> References: <1cf68a6d-1d4b-7e4e-54a5-c8bb1ee9dace@redhat.com> Message-ID: Hi Aleksey, I have my own build system set up from the last thing, just haven't been using it. Will use it for this. :D Regards, Omar On Wed, Mar 27, 2019 at 12:48 PM Aleksey Shipilev wrote: > > On 3/27/19 7:39 PM, Roman Kennke wrote: > > yes, that seems very likely. The fix should appear in nightlies very soon. > > Got the 12u maintainer's approval, finally. Pushed the fixes. The builds would trigger in due > course, and I think they would be ready by tomorrow morning (e.g. within next 12 hrs). > > Omar, you have b140: > > (12-testing+0-builds.shipilev.net-openjdk-jdk12-b140-20190320-jdk-1233) > > ...you need the build b149 or later. > > -Aleksey > From shade at redhat.com Wed Mar 27 19:56:32 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 27 Mar 2019 20:56:32 +0100 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: References: <1cf68a6d-1d4b-7e4e-54a5-c8bb1ee9dace@redhat.com> Message-ID: <46083d23-f796-ce19-5928-04763568986f@redhat.com> On 3/27/19 8:54 PM, Omar Kilani wrote: > I have my own build system set up from the last thing, just haven't > been using it. Will use it for this. :D Okay, then make sure you use this repo, and you see this commit: http://hg.openjdk.java.net/jdk-updates/jdk12u/rev/798e844c555c -Aleksey From rkennke at redhat.com Wed Mar 27 21:30:36 2019 From: rkennke at redhat.com (Roman Kennke) Date: Wed, 27 Mar 2019 22:30:36 +0100 Subject: RFR: JDK-8220664: Simplify ShenandoahUpdateHeapRefsClosure Message-ID: We have split ShenandoahUpdateHeapRefsSuperClosure and ShenandoahUpdateHeapRefsClosure in our code for no reason. We can fold them into one class. (This is historical, we used to have a *Matrix variant there.) Bug: https://bugs.openjdk.java.net/browse/JDK-8220664 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8220664/webrev.00/ Testing: hotspot_gc_shenandoah Ok? Roman From shade at redhat.com Wed Mar 27 21:32:39 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 27 Mar 2019 22:32:39 +0100 Subject: RFR: JDK-8220664: Simplify ShenandoahUpdateHeapRefsClosure In-Reply-To: References: Message-ID: On 3/27/19 10:30 PM, Roman Kennke wrote: > Webrev: > http://cr.openjdk.java.net/~rkennke/JDK-8220664/webrev.00/ Looks good. -Aleksey From rkennke at redhat.com Thu Mar 28 13:54:19 2019 From: rkennke at redhat.com (Roman Kennke) Date: Thu, 28 Mar 2019 14:54:19 +0100 Subject: [12u] 8220546: Shenandoah Reports timing details for weak root processing In-Reply-To: References: Message-ID: <315104ca-a815-bf79-6be1-af14387247b7@redhat.com> Sorry, this somehow went under my radar. Patch looks good! Thanks, Roman > Please review this 12u backport. > > The patch did not apply cleanly, as string table is not processed by > WeakProcessor in 12u. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220546 > Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/8b61a38be0c5 > Original review: > https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-March/025070.html > > > JDK12u webrev: http://cr.openjdk.java.net/~zgu/JDK-8220546_12u/webrev.00/ > > Test: > ? hotspot_gc_shenandoah on Linux 64. > > Thanks, > > -Zhengyu > From omar.kilani at gmail.com Thu Mar 28 18:57:35 2019 From: omar.kilani at gmail.com (Omar Kilani) Date: Thu, 28 Mar 2019 11:57:35 -0700 Subject: JVM crash in ShenandoahInitMarkRootsClosure In-Reply-To: <46083d23-f796-ce19-5928-04763568986f@redhat.com> References: <1cf68a6d-1d4b-7e4e-54a5-c8bb1ee9dace@redhat.com> <46083d23-f796-ce19-5928-04763568986f@redhat.com> Message-ID: I'm running the equivalent of b150 with +UseStringDeduplication. Will report back if it crashes again. :) On Wed, Mar 27, 2019 at 12:56 PM Aleksey Shipilev wrote: > > On 3/27/19 8:54 PM, Omar Kilani wrote: > > I have my own build system set up from the last thing, just haven't > > been using it. Will use it for this. :D > > Okay, then make sure you use this repo, and you see this commit: > http://hg.openjdk.java.net/jdk-updates/jdk12u/rev/798e844c555c > > -Aleksey > From zgu at redhat.com Thu Mar 28 19:53:47 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Thu, 28 Mar 2019 15:53:47 -0400 Subject: RFR 8221629: Shenandoah: Cleanup class unloading logic Message-ID: When ClassUnloading = true, we should not mark through weak CLDS. Therefore, it does not make sense to have weak_cld_closure parameter for RootProcessor::process_strong_roots(). I also collapse update_all_roots/traversal_update_all_roots methods vs. template. Bug: https://bugs.openjdk.java.net/browse/JDK-8221629 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221629/webrev.00/index.html Test: hotspot_gc_shenandoah on Linux x64 (fastdebug and release) Specjvm with VM following VM options (fastdebug) -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -XX:+ClassUnloadingWithConcurrentMark -XX:ShenandoahGCHeuristics=traversal -XX:ShenandoahUnloadClassesFrequency=1 -XX:+UnlockDiagnosticVMOptions -XX:+ShenandoahVerify Thanks, -Zhengyu From rwestrel at redhat.com Fri Mar 29 08:32:35 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 29 Mar 2019 09:32:35 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> Message-ID: <8736n6rsgs.fsf@redhat.com> > Run with -Xmx20g, thus enabling compressed oops, you shall see this: > > [Verified Entry Point] > 6.94% 0x00007f60c0497050: mov %eax,-0x14000(%rsp) > 5.80% 0x00007f60c0497057: push %rbp > 0.30% 0x00007f60c0497058: sub $0x10,%rsp > 11.81% 0x00007f60c049705c: mov 0xc(%rsi),%r11d > 0.82% 0x00007f60c0497060: mov %r11,%r9 > 0.48% 0x00007f60c0497063: shl $0x3,%r9 > .......................... LRB fastpath check .......................... > 5.29% 0x00007f60c0497067: testb $0x1,0x20(%r15) > 5.49% ? 0x00007f60c049706c: jne 0x00007f60c0497086 > .........?......... LRB fastpath ends, store to %r9 follows ............ > 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) > 7.59% ?? ?? 0x00007f60c0497076: add $0x10,%rsp > 6.12% ?? ?? 0x00007f60c049707a: pop %rbp > 1.01% ?? ?? 0x00007f60c049707b: mov 0x108(%r15),%r10 > 0.63% ?? ?? 0x00007f60c0497082: test %eax,(%r10) > 6.73% ?? ?? 0x00007f60c0497085: retq > ---------??-??----------- LRB midpath starts -------------------------- > .........?|.|?............ checking in-cset ........................... > ?? ?? 0x00007f60c0497086: mov %r9,%r10 > ? ?? 0x00007f60c0497089: shr $0x17,%r10 > ? ?? 0x00007f60c049708d: movabs $0x7f60d00919f0,%r8 > ? ?? 0x00007f60c0497097: cmpb $0x0,(%r8,%r10,1) > ? ?? 0x00007f60c049709c: je 0x00007f60c049706e > ............??............ checking is-forwarded ...................... > ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 > ?? 0x00007f60c04970a3: lea (%r12,%r11,8),%r10 > ?? 0x00007f60c04970a7: cmp %r10,%r9 > ?? 0x00007f60c04970aa: jne 0x00007f60c049706e > .............?............... slow path call .......................... > ? 0x00007f60c04970ac: mov %r9,%rdi > ? 0x00007f60c04970af: movabs $0x7f60d7775030,%r10 > ? 0x00007f60c04970b9: callq *%r10 > ? 0x00007f60c04970bc: mov %rax,%r9 > ? 0x00007f60c04970bf: jmp 0x00007f60c049706e So why not store the forwarding pointer compressed? Decoding would then happen after the LRB. So this code: 0.82% 0x00007f60c0497060: mov %r11,%r9 0.48% 0x00007f60c0497063: shl $0x3,%r9 would fold into the following access: 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) and would be essentially free. I suppose this: ?? ?? 0x00007f60c0497086: mov %r9,%r10 ? ?? 0x00007f60c0497089: shr $0x17,%r10 could be adjusted so there's no need to decode the value here. And decoding here: ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 is already folded in the forwarding pointer access. I suppose this would help the other case you mention where decoding is a noop. Roland. From rkennke at redhat.com Fri Mar 29 09:07:54 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 10:07:54 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <8736n6rsgs.fsf@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <8736n6rsgs.fsf@redhat.com> Message-ID: I don't think that storing fwd ptr compressed is an option. It would have to be decoded and re-encoded in the barrier. It would complicate and slow down everything else in GC. And it would gain us nothing: we still need the 64bits because alignment. (And we already have a prototype to eliminate that word...) The question was really only, can we get rid of the superfluous mov and register usage in the noop-decode case? Roman Am 29. M?rz 2019 09:32:35 MEZ schrieb Roland Westrelin : >> Run with -Xmx20g, thus enabling compressed oops, you shall see this: >> >> [Verified Entry Point] >> 6.94% 0x00007f60c0497050: mov %eax,-0x14000(%rsp) >> 5.80% 0x00007f60c0497057: push %rbp >> 0.30% 0x00007f60c0497058: sub $0x10,%rsp >> 11.81% 0x00007f60c049705c: mov 0xc(%rsi),%r11d >> 0.82% 0x00007f60c0497060: mov %r11,%r9 >> 0.48% 0x00007f60c0497063: shl $0x3,%r9 >> .......................... LRB fastpath check >.......................... >> 5.29% 0x00007f60c0497067: testb $0x1,0x20(%r15) >> 5.49% ? 0x00007f60c049706c: jne 0x00007f60c0497086 >> .........?......... LRB fastpath ends, store to %r9 follows >............ >> 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) >> 7.59% ?? ?? 0x00007f60c0497076: add $0x10,%rsp >> 6.12% ?? ?? 0x00007f60c049707a: pop %rbp >> 1.01% ?? ?? 0x00007f60c049707b: mov 0x108(%r15),%r10 >> 0.63% ?? ?? 0x00007f60c0497082: test %eax,(%r10) >> 6.73% ?? ?? 0x00007f60c0497085: retq >> ---------??-??----------- LRB midpath starts >-------------------------- >> .........?|.|?............ checking in-cset >........................... >> ?? ?? 0x00007f60c0497086: mov %r9,%r10 >> ? ?? 0x00007f60c0497089: shr $0x17,%r10 >> ? ?? 0x00007f60c049708d: movabs $0x7f60d00919f0,%r8 >> ? ?? 0x00007f60c0497097: cmpb $0x0,(%r8,%r10,1) >> ? ?? 0x00007f60c049709c: je 0x00007f60c049706e >> ............??............ checking is-forwarded >...................... >> ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 >> ?? 0x00007f60c04970a3: lea (%r12,%r11,8),%r10 >> ?? 0x00007f60c04970a7: cmp %r10,%r9 >> ?? 0x00007f60c04970aa: jne 0x00007f60c049706e >> .............?............... slow path call >.......................... >> ? 0x00007f60c04970ac: mov %r9,%rdi >> ? 0x00007f60c04970af: movabs $0x7f60d7775030,%r10 >> ? 0x00007f60c04970b9: callq *%r10 >> ? 0x00007f60c04970bc: mov %rax,%r9 >> ? 0x00007f60c04970bf: jmp 0x00007f60c049706e > >So why not store the forwarding pointer compressed? Decoding would then >happen after the LRB. So this code: > > 0.82% 0x00007f60c0497060: mov %r11,%r9 > 0.48% 0x00007f60c0497063: shl $0x3,%r9 > >would fold into the following access: > > 0.87% ?? ?? 0x00007f60c049706e: movl $0x2a,0xc(%r9) > >and would be essentially free. I suppose this: > > ?? ?? 0x00007f60c0497086: mov %r9,%r10 > ? ?? 0x00007f60c0497089: shr $0x17,%r10 > >could be adjusted so there's no need to decode the value here. And >decoding here: > > ?? 0x00007f60c049709e: mov -0x8(%r12,%r11,8),%r9 > >is already folded in the forwarding pointer access. > >I suppose this would help the other case you mention where decoding is >a >noop. > >Roland. -- Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet. From rwestrel at redhat.com Fri Mar 29 09:14:42 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 29 Mar 2019 10:14:42 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <8736n6rsgs.fsf@redhat.com> Message-ID: <87zhpeqby5.fsf@redhat.com> > I don't think that storing fwd ptr compressed is an option. It would > have to be decoded and re-encoded in the barrier. It would complicate > and slow down everything else in GC. And it would gain us nothing: we > still need the 64bits because alignment. (And we already have a > prototype to eliminate that word...) > > The question was really only, can we get rid of the superfluous mov > and register usage in the noop-decode case? A compressed fwd ptr is a way to get rid of the extra movs. I think it would make compiled code better overall, too. Without a compressed fwd ptr, messing with the register allocator would be required. I have no idea how to do that. Roland. From rkennke at redhat.com Fri Mar 29 10:05:59 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 11:05:59 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <87zhpeqby5.fsf@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <8736n6rsgs.fsf@redhat.com> <87zhpeqby5.fsf@redhat.com> Message-ID: <5ead20aa-2434-cdbc-e33d-e7fabb538f81@redhat.com> >> I don't think that storing fwd ptr compressed is an option. It would >> have to be decoded and re-encoded in the barrier. It would complicate >> and slow down everything else in GC. And it would gain us nothing: we >> still need the 64bits because alignment. (And we already have a >> prototype to eliminate that word...) >> >> The question was really only, can we get rid of the superfluous mov >> and register usage in the noop-decode case? > > A compressed fwd ptr is a way to get rid of the extra movs. I think it > would make compiled code better overall, too. Yeah, but it would disturb a lot of other code. I don't think we want to go down that path. > Without a compressed fwd ptr, messing with the register allocator would > be required. I have no idea how to do that. Ok. That might be just fine. Any idea why it's apparently not a problem with WBs? Shouldn't they expand basically the same as LRBs? Roman From rkennke at redhat.com Fri Mar 29 12:35:49 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 13:35:49 +0100 Subject: RFR: Upstream merge to jdk-13+14 Message-ID: <17ec76bf-3906-9d66-c2e2-397d2c6216d5@redhat.com> See $SUBJECT. Merged trivially. Changes: http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-29/changes.txt Testing: the usual hotspot_gc_shenandoah Ok? From zgu at redhat.com Fri Mar 29 12:39:44 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 29 Mar 2019 08:39:44 -0400 Subject: RFR: Upstream merge to jdk-13+14 In-Reply-To: <17ec76bf-3906-9d66-c2e2-397d2c6216d5@redhat.com> References: <17ec76bf-3906-9d66-c2e2-397d2c6216d5@redhat.com> Message-ID: Good to me. -Zhengyu On 3/29/19 8:35 AM, Roman Kennke wrote: > See $SUBJECT. Merged trivially. > > Changes: > http://cr.openjdk.java.net/~rkennke/upstream-jdk13-merge-2019-03-29/changes.txt > > > Testing: the usual hotspot_gc_shenandoah > > Ok? From rkennke at redhat.com Fri Mar 29 12:48:43 2019 From: rkennke at redhat.com (rkennke at redhat.com) Date: Fri, 29 Mar 2019 12:48:43 +0000 Subject: hg: shenandoah/jdk: 114 new changesets Message-ID: <201903291248.x2TCmn3G022286@aojmv0008.oracle.com> Changeset: 06222165c35f Author: jwilhelm Date: 2019-03-20 17:13 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/06222165c35f Added tag jdk-12-ga for changeset b67884871b5f ! .hgtags Changeset: 18547cad9ec6 Author: jwilhelm Date: 2019-03-20 17:28 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/18547cad9ec6 Merge ! .hgtags Changeset: 55c262f4f5a1 Author: jwilhelm Date: 2019-03-20 22:53 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/55c262f4f5a1 8220389: Update Graal Reviewed-by: kvn, dlong + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerStampShiftTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompilerOptions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationFailureActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayEqualsStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/StringUTF16ToBytesGetCharsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/BigIntegerIntrinsicsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/GraalOSRTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalOptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/UnsignedRightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java Changeset: d9f43dfbe524 Author: dholmes Date: 2019-03-20 18:01 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d9f43dfbe524 8218446: SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 003cc64366da Author: jjg Date: 2019-03-20 15:35 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/003cc64366da 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! src/java.base/share/classes/java/io/DataInput.java ! src/java.base/share/classes/java/io/File.java ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/ModuleLayer.java ! src/java.base/share/classes/java/lang/doc-files/ValueBased.html ! src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/MutableCallSite.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/lang/invoke/package-info.java ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/package-info.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! src/java.base/share/classes/java/net/Inet4Address.java ! src/java.base/share/classes/java/net/Inet6Address.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/URI.java ! src/java.base/share/classes/java/text/ChoiceFormat.java ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DateFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/Format.java ! src/java.base/share/classes/java/text/MessageFormat.java ! src/java.base/share/classes/java/text/NumberFormat.java ! src/java.base/share/classes/java/text/SimpleDateFormat.java ! src/java.base/share/classes/java/time/Instant.java ! src/java.base/share/classes/java/time/ZoneId.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDate.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/java.base/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/java.base/share/classes/java/time/chrono/Chronology.java ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/time/temporal/IsoFields.java ! src/java.base/share/classes/java/time/temporal/JulianFields.java ! src/java.base/share/classes/java/time/temporal/Temporal.java ! src/java.base/share/classes/java/time/temporal/WeekFields.java ! src/java.base/share/classes/java/util/Calendar.java ! src/java.base/share/classes/java/util/Formatter.java ! src/java.base/share/classes/java/util/GregorianCalendar.java ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/java/util/ResourceBundle.java ! src/java.base/share/classes/java/util/Scanner.java ! src/java.base/share/classes/java/util/ServiceLoader.java ! src/java.base/share/classes/java/util/TimeZone.java ! src/java.base/share/classes/java/util/doc-files/coll-designfaq.html ! src/java.base/share/classes/java/util/regex/Pattern.java ! src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java ! src/java.base/share/classes/java/util/spi/ResourceBundleProvider.java Changeset: ce78fac1f6d5 Author: jwilhelm Date: 2019-03-21 01:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ce78fac1f6d5 Added tag jdk-13+13 for changeset 83cace4142c8 ! .hgtags Changeset: 79fcfc6c02e8 Author: dholmes Date: 2019-03-20 23:32 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/79fcfc6c02e8 8221180: Deprecate AllowJNIEnvProxy Reviewed-by: coleenp, dcubed ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: a8e7194c2b0d Author: dholmes Date: 2019-03-21 03:00 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a8e7194c2b0d 8221208: Backout JDK-8218446 Reviewed-by: iignatyev, rehn ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 8d9d71bba199 Author: clanger Date: 2019-03-21 09:16 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8d9d71bba199 8172695: (scanner) java/util/Scanner/ScanTest.java fails Reviewed-by: smarks, bpb ! test/jdk/java/util/Scanner/ScanTest.java Changeset: 67c58bd66e82 Author: jiefu Date: 2019-03-21 04:55 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/67c58bd66e82 8220658: Improve the readability of container information in the error log Reviewed-by: dholmes, bobv ! src/hotspot/os/linux/os_linux.cpp Changeset: ed40b61fed96 Author: ysuenaga Date: 2019-03-21 21:17 +0900 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ed40b61fed96 8220784: hsdis cannot be built with MinGW64 Reviewed-by: iklam, dholmes ! src/utils/hsdis/Makefile Changeset: d8d45286ffa9 Author: mbalao Date: 2019-03-21 01:51 -0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d8d45286ffa9 8220753: Re-introduce the test case for TLS 1.2 algorithms in SunPKCS11 crypto provider Reviewed-by: xuelei + test/jdk/sun/security/pkcs11/tls/tls12/TestTLS12.java + test/jdk/sun/security/pkcs11/tls/tls12/cert8.db + test/jdk/sun/security/pkcs11/tls/tls12/key3.db + test/jdk/sun/security/pkcs11/tls/tls12/keystore + test/jdk/sun/security/pkcs11/tls/tls12/nss.cfg + test/jdk/sun/security/pkcs11/tls/tls12/secmod.db Changeset: 0288c6919a20 Author: hseigel Date: 2019-03-21 10:47 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0288c6919a20 8221096: Description of -XX:+PrintFlagsRanges is incorrect Summary: Remove the phrase: and exit VM Reviewed-by: lfoltan ! src/hotspot/share/runtime/globals.hpp Changeset: b00a4187d5ec Author: apetcher Date: 2019-03-21 13:10 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b00a4187d5ec 8221172: SunEC specific test is not limited to SunEC Summary: Fixing a minor test bug in the SignatureDigestTruncate regression test Reviewed-by: mullan ! test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: f10ca228b22f Author: alanb Date: 2019-03-21 17:38 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f10ca228b22f 8221259: New tests for java.net.Socket to exercise long standing behavior Reviewed-by: chegar + test/jdk/java/net/Socket/AsyncShutdown.java + test/jdk/java/net/Socket/ConnectionReset.java + test/jdk/java/net/Socket/Timeouts.java + test/jdk/java/net/Socket/UdpSocket.java Changeset: 98a01c1344aa Author: bobv Date: 2019-03-21 14:40 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/98a01c1344aa 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs Reviewed-by: sspitsyn, sgehwolf ! test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java ! test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: 3fe41815505c Author: bchristi Date: 2019-03-21 11:58 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3fe41815505c 8211941: Enable checking/ignoring of non-conforming Class-Path entries Reviewed-by: alanb, mchung ! src/java.base/share/classes/jdk/internal/loader/URLClassPath.java Changeset: 35e8d1eb4040 Author: igerasim Date: 2019-03-21 12:28 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/35e8d1eb4040 8170494: JNI exception pending in PlainDatagramSocketImpl.c Reviewed-by: clanger, vtewari ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c Changeset: 7fbb4340b125 Author: dtitov Date: 2019-03-21 19:56 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7fbb4340b125 8218401: WRONG_PHASE: vmTestbase/nsk/jvmti test crash Reviewed-by: sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Breakpoint/breakpoint001/breakpoint001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/FramePop/framepop002/framepop002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep003/singlestep003.cpp Changeset: 727ab25a4e24 Author: xuelei Date: 2019-03-21 13:32 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/727ab25a4e24 8221270: Duplicated synchronized keywords in SSLSocketImpl Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 1928a50e7e83 Author: xuelei Date: 2019-03-21 14:18 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1928a50e7e83 8221273: put sun/security/pkcs11/tls/tls12/TestTLS12.java on ProblemList.txt Reviewed-by: mullan ! test/jdk/ProblemList.txt Changeset: 8478c8c48886 Author: rkennke Date: 2019-03-21 22:37 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8478c8c48886 8221278: Shenandoah should not enqueue string dedup candidates during root scan Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: eed9f74eab87 Author: rkennke Date: 2019-03-15 09:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/eed9f74eab87 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe Reviewed-by: vlivanov, roland ! src/hotspot/share/opto/library_call.cpp + test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java Changeset: ed34367d4e9f Author: ngasson Date: 2019-03-22 03:04 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ed34367d4e9f 8220451: jdi/EventQueue/remove/remove004 failed due to "ERROR: thread2 is not alive" 8220456: jdi/EventQueue/remove_l/remove_l004 failed due to "TIMEOUT while waiting for event" Reviewed-by: sspitsyn, dcubed, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004/TestDescription.java Changeset: fce15a3c1922 Author: clanger Date: 2019-03-22 08:56 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/fce15a3c1922 8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old! Reviewed-by: stuefe, jjg ! test/langtools/tools/javac/modules/MOptionTest.java Changeset: 17da5f618aaf Author: akolarkunnu Date: 2019-02-26 03:24 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/17da5f618aaf 8211322: Reduce the timeout of tooltip in SwingSet2DemoTest Reviewed-by: serb, shurailine Contributed-by: gauri.patil at oracle.com ! test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JToolTipOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: a17f46493e0b Author: dmarkov Date: 2019-02-26 18:12 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a17f46493e0b 8214109: XToolkit is not correctly displayed color on 16-bit high color setting Reviewed-by: serb, prr ! src/java.desktop/unix/classes/sun/awt/X11/XWindow.java Changeset: 6673d2b7e084 Author: psadhukhan Date: 2019-02-27 14:48 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6673d2b7e084 Merge - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java Changeset: d9d9655bb077 Author: prr Date: 2019-02-27 14:30 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d9d9655bb077 Merge Changeset: e4813eded7cb Author: serb Date: 2019-02-27 18:46 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e4813eded7cb 8213110: Remove the use of applets in automatic tests Reviewed-by: prr ! test/jdk/ProblemList.txt - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html ! test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.java - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html ! test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html ! test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.java - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.java ! test/jdk/java/awt/ComponentOrientation/BorderTest.java ! test/jdk/java/awt/ComponentOrientation/FlowTest.java - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowRetaining.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html ! test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.java ! test/jdk/java/awt/Focus/ClearLwQueueBreakTest/ClearLwQueueBreakTest.java ! test/jdk/java/awt/Focus/CloseDialogActivateOwnerTest/CloseDialogActivateOwnerTest.java ! test/jdk/java/awt/Focus/ConsumeNextKeyTypedOnModalShowTest/ConsumeNextKeyTypedOnModalShowTest.java ! test/jdk/java/awt/Focus/ContainerFocusAutoTransferTest/ContainerFocusAutoTransferTest.java - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java ! test/jdk/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java ! test/jdk/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html ! test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.java ! test/jdk/java/awt/Focus/FrameJumpingToMouse/FrameJumpingToMouse.java ! test/jdk/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.java - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html ! test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.java - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html ! test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java ! test/jdk/java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html ! test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.java ! test/jdk/java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java ! test/jdk/java/awt/Focus/RequestFocusToDisabledCompTest/RequestFocusToDisabledCompTest.java ! test/jdk/java/awt/Focus/ResetMostRecentFocusOwnerTest/ResetMostRecentFocusOwnerTest.java ! test/jdk/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java ! test/jdk/java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.java - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.java - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html ! test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java ! test/jdk/java/awt/Focus/WrongKeyTypedConsumedTest/WrongKeyTypedConsumedTest.java ! test/jdk/java/awt/FontClass/CreateFont/BigFont.java - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html ! test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.java - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html ! test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.java ! test/jdk/java/awt/FullScreen/SetFSWindow/FSFrame.java - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html ! test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html ! test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html ! test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.java - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html ! test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.java - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html ! test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.java - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.java - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html ! test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.java - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.java - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html ! test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html ! test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.java - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.java - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.java - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html ! test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.java - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.java - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.java - test/jdk/javax/imageio/AppletResourceTest.html ! test/jdk/javax/imageio/AppletResourceTest.java - test/jdk/javax/swing/JFrame/4962534/bug4962534.html ! test/jdk/javax/swing/JFrame/4962534/bug4962534.java - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html ! test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html ! test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.java - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html ! test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.java - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.java Changeset: 7c11a7cc7c1d Author: prr Date: 2019-03-01 16:59 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7c11a7cc7c1d 8210782: Upgrade HarfBuzz to the latest 2.3.1 Reviewed-by: serb, ihse, erikj ! make/lib/Awt2dLibraries.gmk ! src/java.desktop/share/legal/harfbuzz.md + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-fdsc-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-ankr-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-bsln-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-feat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-just-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-kerx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-lcar-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-morx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-trak-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-ltag-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-array.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-json.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-text.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-cs-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-dict-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff1-interp-cs.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff2-interp-cs.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-deprecated.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-fallback-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-iter.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-kern.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-machinery.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-null.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cbdt-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-colr-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cpal-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-sbix-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-svg-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-deprecated.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-gasp-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-glyf-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hdmx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-head-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hhea-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-base-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-jstf-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-maxp-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-unicode-ranges.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-macroman.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-win1256.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-default.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hangul.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-thai.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-stat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-vorg-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-list.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-static.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-emoji-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-vector.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-warning.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb.hh ! src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc Changeset: 9413f1a4dc2b Author: serb Date: 2019-03-04 01:44 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/9413f1a4dc2b 8061381: [macosx] Accelerators does not spelled for JMenuItems by Voice Over Reviewed-by: prr, kaddepalli ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 6b2f2ec0f618 Author: pbansal Date: 2019-03-05 13:09 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6b2f2ec0f618 8214253: Tooltip is transparent rather than having a black background Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: 63946f20c24f Author: pbansal Date: 2019-03-05 14:03 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/63946f20c24f 8214112: The whole text in target JPasswordField image are not selected Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: a5af6175d62b Author: kaddepalli Date: 2019-03-07 12:51 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a5af6175d62b 8218674: HTML Tooltip with "img=src" on component doesn't show Reviewed-by: serb, psadhukhan ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java + test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java + test/jdk/javax/swing/text/html/8218674/circle.png Changeset: 7d5e595cb7aa Author: psadhukhan Date: 2019-03-08 14:07 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7d5e595cb7aa 8215396: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT Reviewed-by: serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/jdk/javax/swing/JTabbedPane/TabProb.java Changeset: 371d29d4add5 Author: serb Date: 2019-03-09 14:48 -0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/371d29d4add5 8219504: Test for JDK-8211435 can be run on all platforms Reviewed-by: kaddepalli, dmarkov, sveerabhadra ! test/jdk/java/awt/Focus/NullActiveWindowOnFocusLost/NullActiveWindowOnFocusLost.java Changeset: 0804f29e8be7 Author: mbalao Date: 2019-03-01 12:21 -0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0804f29e8be7 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth Summary: Consider algorithmic bold in FontMetrics.getMaxAdvance value and update obliqueness. Reviewed-by: prr, serb ! src/java.desktop/share/native/libfontmanager/freetypeScaler.c + test/jdk/java/awt/FontMetrics/MaxAdvanceIsMax.java Changeset: 5294813fe931 Author: vagarwal Date: 2019-03-13 00:04 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5294813fe931 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ Reviewed-by: prr, iignatyev ! test/jdk/TEST.ROOT ! test/jdk/sanity/client/README ! test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java ! test/jdk/sanity/client/SwingSet/src/EditorPaneDemoTest.java - test/jdk/sanity/client/TEST.ROOT.template ! test/jdk/sanity/client/TEST.properties Changeset: 3c369ad8c4ac Author: vagarwal Date: 2019-03-13 00:51 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3c369ad8c4ac 8216353: Use utility APIs introduced in org/netbeans/jemmy/util/LookAndFeel class in client sanity test cases Reviewed-by: serb ! test/jdk/sanity/client/SwingSet/src/FileChooserDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SliderDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SplitPaneDemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JFileChooserOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java + test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/LookAndFeel.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: 132590e72765 Author: serb Date: 2019-03-16 17:50 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/132590e72765 7106851: Test should not use System.exit Reviewed-by: aivanov, psadhukhan, kaddepalli + test/jdk/javax/accessibility/6192422/bug6192422.java Changeset: 0b9fb3cfb6f2 Author: prr Date: 2019-03-18 14:55 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0b9fb3cfb6f2 8218914: Support fonts installed per-user on Windows 10 Reviewed-by: prr, serb Contributed-by: Mikhail Filippov ! src/java.desktop/windows/native/libfontmanager/fontpath.c Changeset: 3ee03f1d88c9 Author: psadhukhan Date: 2019-03-20 16:07 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3ee03f1d88c9 Merge - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java Changeset: 96c45aa61056 Author: psadhukhan Date: 2019-03-22 13:42 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/96c45aa61056 Merge - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt ! test/jdk/ProblemList.txt Changeset: f04e3492fd88 Author: alanb Date: 2019-03-22 11:35 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f04e3492fd88 8221252: (sc) SocketChannel and its socket adaptor need to handle connection reset Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/IOStatus.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/Net.c + src/java.base/unix/native/libnio/ch/SocketDispatcher.c ! src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/windows/native/libnio/ch/Net.c ! src/java.base/windows/native/libnio/ch/SocketDispatcher.c ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java + test/jdk/java/nio/channels/SocketChannel/ConnectionReset.java Changeset: 3e7fccdb6181 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3e7fccdb6181 8221212: ZGC: Command-line flags should be marked experimental Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/z_globals.hpp Changeset: b9cd87da3211 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b9cd87da3211 8221219: ZGC: Remove ZStallOnOutOfMemory option Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/z_globals.hpp Changeset: 931247e90857 Author: dbuck Date: 2019-03-22 09:05 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/931247e90857 8217564: idempotent protection missing in crc32c.h Summary: added include guard to crc32c.h Reviewed-by: dcubed ! src/hotspot/cpu/x86/crc32c.h Changeset: 601326fead41 Author: erikj Date: 2019-03-22 08:14 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/601326fead41 8221179: Zero builds fail when linking with gold and bundling libffi.so Reviewed-by: sgehwolf, tbell ! make/hotspot/lib/JvmFeatures.gmk Changeset: 51195881bd3a Author: bpb Date: 2019-03-22 08:18 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/51195881bd3a 8078860: (spec) InputStream.read(byte[] b, int off, int len) claims to not affect element b[off] Reviewed-by: lancea, darcy, rriggs ! src/java.base/share/classes/java/io/InputStream.java Changeset: 83deaa8f0c8e Author: naoto Date: 2019-03-22 09:31 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/83deaa8f0c8e 8220224: With CLDR provider, NumberFormat.format could not handle locale with number extension correctly. Reviewed-by: darcy ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java + test/jdk/java/text/Format/NumberFormat/DFSMinusPerCentMill.java Changeset: 01d8eae542ff Author: xuelei Date: 2019-03-22 13:47 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/01d8eae542ff 8218889: Improperly use of the Optional API Reviewed-by: jnimeh, wetmore ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java Changeset: a2956337451b Author: coleenp Date: 2019-03-22 16:16 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a2956337451b 8218399: runtime/RedefineObject/TestRedefineObject.java timeout Summary: exclude this test for graal Reviewed-by: hseigel, lfoltan ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java Changeset: c81fbf340ceb Author: kbarrett Date: 2019-03-22 15:42 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c81fbf340ceb 8220240: Refactor shared dirty card queue Summary: Add G1SharedDirtyCardQueue class. Reviewed-by: tschatzl, lkorinth ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp Changeset: aa937fac07f3 Author: shade Date: 2019-03-23 17:18 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/aa937fac07f3 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) Reviewed-by: stuefe ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp Changeset: 21702e87efdf Author: iklam Date: 2019-03-23 21:51 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/21702e87efdf 8220095: Assertion failure when symlink (with different name) is used for lib/modules file Summary: Removed confusing function ClassLoader::is_modules_image(char*) Reviewed-by: lfoltan, ccheung Contributed-by: Jiangli Zhou ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileStream.cpp ! src/hotspot/share/classfile/classFileStream.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoader.hpp ! src/hotspot/share/oops/instanceKlass.cpp + test/hotspot/jtreg/runtime/modules/ModulesSymLink.java Changeset: 0db90e99f13b Author: qpzhang Date: 2019-03-21 16:45 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0db90e99f13b 8221220: AArch64: Add StoreStore membar explicitly for Volatile Writes in TemplateTable Reviewed-by: aph ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Changeset: d25b24c70126 Author: dholmes Date: 2019-03-25 00:57 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/d25b24c70126 8221207: Redo JDK-8218446 - SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: bb8828626944 Author: gadams Date: 2019-03-25 07:31 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/bb8828626944 8221164: jstatLineCounts tests need to be more resilient for NaN outputs Reviewed-by: cjplummer, phh, jcbeyler ! test/jdk/sun/tools/jstat/lineCounts3.awk ! test/jdk/sun/tools/jstat/lineCounts4.awk Changeset: b1605a40e336 Author: gadams Date: 2019-03-25 08:37 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/b1605a40e336 8220295: sun/tools/jps/TestJps.java still timing out Reviewed-by: cjplummer, jcbeyler ! test/jdk/TEST.ROOT Changeset: 1f9ad92e337b Author: tschatzl Date: 2019-03-25 14:11 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1f9ad92e337b 8219100: Improve do_collection_pause_at_safepoint Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! test/hotspot/jtreg/gc/g1/TestVerifyGCType.java Changeset: 3cabb47758c9 Author: mgronlun Date: 2019-03-25 15:37 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3cabb47758c9 8217362: Emergency dump does not work when disk=false is set Reviewed-by: egahlin, ysuenaga Contributed-by: yasuenag at gmail.com ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 41af8d0546bc Author: lkorinth Date: 2019-03-25 14:46 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/41af8d0546bc 8221260: Initialize more class members on construction, remove some unused ones Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.cpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.hpp ! src/hotspot/share/gc/parallel/gcTaskThread.cpp ! src/hotspot/share/gc/parallel/gcTaskThread.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.cpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.hpp ! src/hotspot/share/gc/parallel/psMarkSweepDecorator.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.hpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/gcStats.cpp Changeset: 1b0163c877c0 Author: erikj Date: 2019-03-25 09:07 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1b0163c877c0 8220445: Support for side by side MSVC Toolset versions Reviewed-by: tbell Contributed-by: ali.ince at gmail.com, erik.joelsson at oracle.com ! make/autoconf/toolchain_windows.m4 Changeset: 7816d989bf21 Author: dpochepk Date: 2019-03-25 19:49 +0300 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/7816d989bf21 8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64 Reviewed-by: adinn ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 75445a7c2c04 Author: redestad Date: 2019-03-25 20:57 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/75445a7c2c04 8221343: x86_32 crashes on startup with "_hwm out of range" Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/matcher.cpp Changeset: 0cf2c87ce79a Author: dholmes Date: 2019-03-25 17:29 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0cf2c87ce79a 8221357: Update test documentation by deleting "cd test && make" Reviewed-by: dholmes, tbell, erikj Contributed-by: Jing Tian ! doc/testing.html ! doc/testing.md Changeset: 418fbdb1b581 Author: gromero Date: 2019-03-25 19:40 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/418fbdb1b581 8221434: Fix typo in lib-x11 autoconf error message about missing headers Reviewed-by: dholmes ! make/autoconf/lib-x11.m4 Changeset: 176e8aec3097 Author: sspitsyn Date: 2019-03-25 19:16 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/176e8aec3097 8146986: JDI: Signature lookups for unprepared classes can take a long time Summary: Do not cache classes if signature is not provided Reviewed-by: sspitsyn, jcbeyler ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 44edf64cb206 Author: darcy Date: 2019-03-25 19:40 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/44edf64cb206 8221264: Refactor and update SourceVersion.latestSupported Reviewed-by: jjg, cushon, martin ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java Changeset: 85657f4753e4 Author: dtitov Date: 2019-03-26 04:19 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/85657f4753e4 8217827: [Graal] Some vmTestbase/nsk/jvmti/ResourceExhausted tests failing Reviewed-by: cjplummer, jcbeyler, dholmes ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted002/TestDescription.java Changeset: f0490ada4712 Author: clanger Date: 2019-03-26 09:16 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f0490ada4712 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes Reviewed-by: alanb, igerasim ! src/java.base/unix/classes/java/io/UnixFileSystem.java ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: a7358438d463 Author: redestad Date: 2019-03-26 10:23 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a7358438d463 8220682: Heap dumping and inspection fails with JDK-8214712 Reviewed-by: jcbeyler, jiangli, sspitsyn ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: 5ee30b6991a7 Author: redestad Date: 2018-12-03 16:25 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5ee30b6991a7 8214712: Archive Attributes$Name.KNOWN_NAMES Reviewed-by: alanb, jiangli ! src/hotspot/share/memory/heapShared.cpp ! src/java.base/share/classes/java/util/jar/Attributes.java Changeset: 5487a925f70d Author: simonis Date: 2019-03-26 11:51 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/5487a925f70d 8221083: [ppc64] Wrong oop compare in C1-generated code Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp + test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: f283f6871336 Author: gadams Date: 2019-03-26 07:09 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f283f6871336 8203026: java.rmi.NoSuchObjectException: no such object in table Reviewed-by: rriggs, sspitsyn ! src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java ! src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java Changeset: 16999bd91ba6 Author: rehn Date: 2019-03-26 12:08 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/16999bd91ba6 8220774: Add HandshakeALot diag option Reviewed-by: dcubed, dholmes ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vmThread.hpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java + test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java ! test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java Changeset: 368757835b97 Author: gadams Date: 2019-03-26 07:24 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/368757835b97 8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes Reviewed-by: cjplummer, dholmes, lmesnik ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003.java + test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TEST.properties ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted004/TestDescription.java Changeset: a33c42262338 Author: rschmelter Date: 2019-03-22 04:47 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a33c42262338 8220570: Additonal trace when native thread creation fails Summary: Added additonal trace when native thread creation fails Reviewed-by: dholmes, goetz ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp Changeset: ca554363aed3 Author: weijun Date: 2019-03-26 21:33 +0800 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ca554363aed3 8217690: Update public suffix version Reviewed-by: mullan ! make/data/publicsuffixlist/VERSION ! make/data/publicsuffixlist/public_suffix_list.dat Changeset: 6ddb9e3f1654 Author: rehn Date: 2019-03-26 14:49 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6ddb9e3f1654 8221472: Fix HandshakeSuspendExitTest Reviewed-by: dcubed, redestad ! test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java Changeset: e61065c08924 Author: gromero Date: 2019-03-20 16:59 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e61065c08924 8220794: PPC64: Fix signal handler for SIGSEGV on branch to illegal address Reviewed-by: stuefe, goetz ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp Changeset: a2897fb258f1 Author: gromero Date: 2019-03-20 16:43 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/a2897fb258f1 8221175: Fix bad function case for controlled JVM crash on PPC64 big-endian Reviewed-by: chrisphi, stuefe, goetz ! src/hotspot/share/utilities/vmError.cpp Changeset: 33f0b34c9dd7 Author: redestad Date: 2019-03-26 15:20 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/33f0b34c9dd7 8221473: Configuration::reads can use Set.copyOf Reviewed-by: alanb, forax ! src/java.base/share/classes/java/lang/module/Configuration.java Changeset: 6640fd9196d9 Author: stuefe Date: 2019-03-26 15:46 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6640fd9196d9 8221406: Windows 32bit build error in NetworkInterface_winXP.c Reviewed-by: clanger ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: c02b8d6384ab Author: stuefe Date: 2019-03-26 15:52 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c02b8d6384ab 8221407: Windows 32bit build error in libsunmscapi/security.cpp Reviewed-by: clanger ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp Changeset: c12b897021ea Author: erikj Date: 2019-03-26 09:24 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c12b897021ea 8221414: Bump required boot jdk version to 12 Reviewed-by: mikael, tbell ! make/autoconf/version-numbers ! make/conf/jib-profiles.js Changeset: 6183f835b9b6 Author: chegar Date: 2019-03-26 17:02 +0000 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6183f835b9b6 8219446: Specify behaviour of timeout accepting methods of Socket and ServerSocket if timeout is negative Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! test/jdk/java/net/Socket/Timeouts.java Changeset: 8af48416e31f Author: simonis Date: 2019-03-26 18:42 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/8af48416e31f 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected" Reviewed-by: kvn, mdoerr ! test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: e6c86f6012bf Author: dcubed Date: 2019-03-26 15:27 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/e6c86f6012bf 8221350: more monitor logging updates from Async Monitor Deflation project Reviewed-by: dholmes, coleenp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: c31faeacf00a Author: zgu Date: 2019-03-26 15:50 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c31faeacf00a 8204552: NMT: Separate thread stack tracking from virtual memory tracking Reviewed-by: stuefe, minqi ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/share/services/memBaseline.cpp ! src/hotspot/share/services/memReporter.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp + src/hotspot/share/services/threadStackTracker.cpp + src/hotspot/share/services/threadStackTracker.hpp ! src/hotspot/share/services/virtualMemoryTracker.cpp Changeset: dae71635cc3a Author: mseledtsov Date: 2019-03-26 13:25 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dae71635cc3a 8221342: [TESTBUG] Generate Dockerfile for docker testing Summary: Dockerfile is generated; introduced properties to specify custom base image Reviewed-by: sgehwolf, dholmes, jiefu - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x ! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java + test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: add0810ec2fa Author: sspitsyn Date: 2019-03-26 14:43 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/add0810ec2fa 8221513: Add vmTestbase/nsk/jdb/eval/eval001/eval001.java to ProblemList.txt Summary: Add test to the ProblemList.txt Reviewed-by: dcubed ! test/hotspot/jtreg/ProblemList.txt Changeset: 49c4b23d8d0a Author: afarley Date: 2019-03-26 15:53 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/49c4b23d8d0a 8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields Reviewed-by: mchung ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! test/jdk/java/lang/invoke/MethodHandlesGeneralTest.java ! test/jdk/java/lang/invoke/MethodHandlesTest.java ! test/jdk/java/lang/invoke/VarHandles/accessibility/TestFieldLookupAccessibility.java Changeset: dc66ada06693 Author: cushon Date: 2019-03-26 15:36 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/dc66ada06693 8220633: Optimize CacheFSInfo Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/CacheFSInfo.java Changeset: f98f158c1db8 Author: iklam Date: 2019-03-26 11:34 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/f98f158c1db8 8217347: [TESTBUG] runtime/appcds/jvmti/InstrumentationTest.java timed out Summary: Avoid using VirtualMachine.list(). Use Process.pid() instead. Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationApp.java ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationTest.java Changeset: 6207397a6603 Author: cushon Date: 2019-03-26 15:00 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/6207397a6603 8220687: Add StandardJavaFileManager.getJavaFileObjectsFromPaths overload Reviewed-by: jjg ! src/java.compiler/share/classes/javax/tools/StandardJavaFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/DelegatingJavaFileManager.java ! test/langtools/tools/javac/api/file/SJFM_GetFileObjects.java Changeset: 656789f95658 Author: ghaug Date: 2019-03-26 16:00 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/656789f95658 8221479: Fix JFR profiling on s390 Reviewed-by: mdoerr, clanger ! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp Changeset: 1b85f55c9aa2 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1b85f55c9aa2 8221396: Clean up serviceability/sa/TestUniverse.java Reviewed-by: stefank, jcbeyler ! test/hotspot/jtreg/serviceability/sa/TestUniverse.java Changeset: 2f522c487791 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/2f522c487791 8221392: Reduce ConcurrentGCThreads spinning during start up Reviewed-by: eosterlund, kbarrett ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/init.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp Changeset: 0a2d73e02076 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0a2d73e02076 8221537: ZGC: Fix incorrect comment in zNMethod table entry layout Reviewed-by: stefank ! src/hotspot/share/gc/z/zNMethodTableEntry.hpp Changeset: 3022f7d70897 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3022f7d70897 8220198: Lots of com/sun/crypto/provider/Cipher tests fail on x86_32 due to missing SHA512 stubs Reviewed-by: kvn, thartmann ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: 78f88c4423a4 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/78f88c4423a4 8221400: java/lang/String/StringRepeat.java test requests too much heap Reviewed-by: stuefe, alanb ! test/jdk/java/lang/String/StringRepeat.java Changeset: 848859723503 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/848859723503 8221401: java/math/BigInteger/LargeValueExceptions.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, bpb ! test/jdk/java/math/BigInteger/LargeValueExceptions.java Changeset: 828c4889adfc Author: shade Date: 2019-03-27 12:38 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/828c4889adfc 8221524: java/util/Base64/TestEncodingDecodingLength.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, alanb ! test/jdk/java/util/Base64/TestEncodingDecodingLength.java Changeset: df62ea1da6ad Author: rraghavan Date: 2019-03-27 18:33 +0530 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/df62ea1da6ad 8219612: compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host Summary: Test rewritten to use top level classes rather then nested ones Reviewed-by: iignatyev, kvn, thartmann ! test/hotspot/jtreg/compiler/codecache/stress/Helper.java ! test/hotspot/jtreg/compiler/codecache/stress/RandomAllocationTest.java ! test/hotspot/jtreg/compiler/codecache/stress/ReturnBlobToWrongHeapTest.java + test/hotspot/jtreg/compiler/codecache/stress/TestCaseImpl.java ! test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationTest.java Changeset: 1dcacbe612ae Author: hseigel Date: 2019-03-27 09:29 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/1dcacbe612ae 8059357: ClassVerifier redundantly checks constant pool entries multiple times Summary: Store translated signature verificationTypes in a hashtable where they can be fetched, instead of having to re-translating the signatures Reviewed-by: iklam, coleenp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp Changeset: c4c225b49c5f Author: bpb Date: 2019-03-27 07:21 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/c4c225b49c5f 8219196: DataOutputStream.writeUTF may throw unexpected exceptions Reviewed-by: martin, darcy, rriggs Contributed-by: Martin Buchholz ! src/java.base/share/classes/java/io/DataOutputStream.java ! test/jdk/java/io/DataOutputStream/WriteUTF.java Changeset: 646c54d5989b Author: mseledtsov Date: 2019-03-27 08:38 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/646c54d5989b 8221527: [TESTBUG] DockerBasicTest.java contains hard-coded reference to JDK 10 Summary: Using Docker test library to get the image name Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java Changeset: 3fedbfdb25b6 Author: pliden Date: 2019-03-27 18:30 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/3fedbfdb25b6 8221456: nmethod::make_unloaded() clears _method member too early Reviewed-by: eosterlund, thartmann ! src/hotspot/share/code/nmethod.cpp Changeset: 0223b7b8a1c5 Author: simonis Date: 2019-03-27 19:47 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/0223b7b8a1c5 8220528: [AIX] Fix basic Xinerama and Xrender functionality Reviewed-by: clanger, stuefe, serb ! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c Changeset: 440cbcf3b268 Author: bpb Date: 2019-03-27 13:00 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/440cbcf3b268 8221531: Incorrect copyright header in src/java.base/windows/native/libnio/ch/FileChannelImpl.c Reviewed-by: lancea, bchristi ! src/java.base/windows/native/libnio/ch/FileChannelImpl.c Changeset: 46cf212cdcca Author: aeubanks Date: 2019-03-27 09:06 -0700 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/46cf212cdcca 8220575: Replace hardcoded 127.0.0.1 in URLs with new URI builder Reviewed-by: dfuchs, chegar Contributed-by: aeubanks at google.com ! test/jdk/com/sun/net/httpserver/TestLogging.java ! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java ! test/jdk/com/sun/net/httpserver/bugs/B6373555.java ! test/jdk/com/sun/net/httpserver/bugs/B6401598.java ! test/jdk/java/net/HttpCookie/ExpiredCookieTest.java ! test/jdk/java/net/HttpURLConnection/NoProxyTest.java ! test/jdk/java/net/ProxySelector/NullSelector.java ! test/jdk/java/net/ResponseCache/Test2.java ! test/jdk/java/net/URLClassLoader/closetest/CloseTest.java ! test/jdk/java/net/URLConnection/TimeoutTest.java ! test/jdk/java/net/URLPermission/OpenURL.java ! test/jdk/java/net/httpclient/AuthSchemesTest.java ! test/jdk/java/net/httpclient/LargeResponseContent.java ! test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/jdk/sun/net/www/protocol/http/6550798/test.java ! test/jdk/sun/net/www/protocol/http/B6890349.java ! test/jdk/sun/net/www/protocol/http/B8012625.java ! test/jdk/sun/net/www/protocol/http/NoNTLM.java ! test/jdk/sun/net/www/protocol/http/RedirectOnPost.java ! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java ! test/jdk/sun/net/www/protocol/http/RetryUponTimeout.java ! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java ! test/jdk/sun/net/www/protocol/http/UserAgent.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java + test/lib/jdk/test/lib/net/URIBuilder.java Changeset: ab466d7c678c Author: rkennke Date: 2019-03-29 12:21 +0100 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/ab466d7c678c Merge ! .hgtags ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Breakpoint/breakpoint001/breakpoint001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/FramePop/framepop002/framepop002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep003/singlestep003.cpp - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html From rwestrel at redhat.com Fri Mar 29 13:09:28 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 29 Mar 2019 14:09:28 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <5ead20aa-2434-cdbc-e33d-e7fabb538f81@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <8736n6rsgs.fsf@redhat.com> <87zhpeqby5.fsf@redhat.com> <5ead20aa-2434-cdbc-e33d-e7fabb538f81@redhat.com> Message-ID: <87wokhrfnb.fsf@redhat.com> > Any idea why it's apparently not a problem with WBs? Shouldn't they > expand basically the same as LRBs? AFAICT, same problem should apply to WBs. Roland. From zgu at redhat.com Fri Mar 29 13:47:59 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 29 Mar 2019 09:47:59 -0400 Subject: RFR(T) 8221688: Quarantine Shenandoah string dedup tests Message-ID: <4b4cc93b-2e8c-b134-26e3-269794a30002@redhat.com> I would like to quarantine Shenandoah string deduplication tests until JDK-8220671 and JDK-8221102 are fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8221688 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221688/webrev.00/ Thanks, -Zhengyu From rkennke at redhat.com Fri Mar 29 14:16:00 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 15:16:00 +0100 Subject: RFR(T) 8221688: Quarantine Shenandoah string dedup tests In-Reply-To: <4b4cc93b-2e8c-b134-26e3-269794a30002@redhat.com> References: <4b4cc93b-2e8c-b134-26e3-269794a30002@redhat.com> Message-ID: <4f6c1d95-2174-1ec2-7a04-daf7ef82e033@redhat.com> Yes, please! Also, please cherry-pick it into shenandoah/jdk straight away. Thanks, Roman > I would like to quarantine Shenandoah string deduplication tests until > JDK-8220671 and JDK-8221102 are fixed. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221688 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221688/webrev.00/ > > Thanks, > > -Zhengyu From rkennke at redhat.com Fri Mar 29 14:17:48 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 15:17:48 +0100 Subject: RFR 8221629: Shenandoah: Cleanup class unloading logic In-Reply-To: References: Message-ID: <6212d939-b9c7-7fbf-b806-f861f6d2721d@redhat.com> Looks good! Thanks! Roman > When ClassUnloading = true, we should not mark through weak CLDS. > Therefore, it does not make sense to have weak_cld_closure parameter for > RootProcessor::process_strong_roots(). > > I also collapse update_all_roots/traversal_update_all_roots methods vs. > template. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221629 > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8221629/webrev.00/index.html > > Test: > ? hotspot_gc_shenandoah on Linux x64 (fastdebug and release) > > ? Specjvm with VM following VM options (fastdebug) > ? -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC > ? -XX:+ClassUnloadingWithConcurrentMark > ? -XX:ShenandoahGCHeuristics=traversal > ? -XX:ShenandoahUnloadClassesFrequency=1 -XX:+UnlockDiagnosticVMOptions > ? -XX:+ShenandoahVerify > > Thanks, > > -Zhengyu From rkennke at redhat.com Fri Mar 29 14:20:39 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 15:20:39 +0100 Subject: LRB and 32-bit compressed oops In-Reply-To: <87wokhrfnb.fsf@redhat.com> References: <3a406888-74a5-66f6-cdbc-d6f1994e3747@redhat.com> <8736n6rsgs.fsf@redhat.com> <87zhpeqby5.fsf@redhat.com> <5ead20aa-2434-cdbc-e33d-e7fabb538f81@redhat.com> <87wokhrfnb.fsf@redhat.com> Message-ID: >> Any idea why it's apparently not a problem with WBs? Shouldn't they >> expand basically the same as LRBs? > > AFAICT, same problem should apply to WBs. Maybe, but Aleksey couldn't see it in experiments. Just lucky? Roman From zgu at redhat.com Fri Mar 29 14:45:35 2019 From: zgu at redhat.com (zgu at redhat.com) Date: Fri, 29 Mar 2019 14:45:35 +0000 Subject: hg: shenandoah/jdk: Cherry-pick: 8221688: Quarantine Shenandoah string dedup tests Message-ID: <201903291445.x2TEjaQZ001008@aojmv0008.oracle.com> Changeset: 223096d4a9ad Author: zgu Date: 2019-03-29 10:21 -0400 URL: http://hg.openjdk.java.net/shenandoah/jdk/rev/223096d4a9ad Cherry-pick: 8221688: Quarantine Shenandoah string dedup tests Reviewed-by: rkennke ! test/hotspot/jtreg/ProblemList.txt From kdobson at redhat.com Fri Mar 29 20:28:52 2019 From: kdobson at redhat.com (Ken Dobson) Date: Fri, 29 Mar 2019 16:28:52 -0400 Subject: RFR 8221507: Implement JFR Events for Shenandoah In-Reply-To: <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com> References: <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com> Message-ID: On Tue, Mar 26, 2019 at 5:16 PM Roman Kennke wrote: > > Please review this patch that adds support for two new JFR events > > ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221507 > > Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/ > > > > The events appears to result in ~2% overhead though there is some > > uncertainty as to whether some of that is noise. > > > > Thanks, > > > > Ken Dobson > > Very nice! > > The overhead is only present with JFR active, I assume? > > We've noticed that there is some overhead when JFR is included in the jdk but not running. This may be because the event object has to be instantiated at each transition whether it's enabled or not. You can see the exact numbers in the email I previously sent you. Have you run hotspot_gc_shenandoah tests? > > Yes and all of the tests pass. Thanks, Ken Dobson From zgu at redhat.com Fri Mar 29 20:36:19 2019 From: zgu at redhat.com (Zhengyu Gu) Date: Fri, 29 Mar 2019 16:36:19 -0400 Subject: RFR 8221507: Implement JFR Events for Shenandoah In-Reply-To: References: <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com> Message-ID: <2caf3cfa-f1c8-8ce9-dfd0-3a7243eeef11@redhat.com> On 3/29/19 4:28 PM, Ken Dobson wrote: > On Tue, Mar 26, 2019 at 5:16 PM Roman Kennke wrote: > >>> Please review this patch that adds support for two new JFR events >>> ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221507 >>> Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/ >>> >>> The events appears to result in ~2% overhead though there is some >>> uncertainty as to whether some of that is noise. >>> >>> Thanks, >>> >>> Ken Dobson >> >> Very nice! >> >> The overhead is only present with JFR active, I assume? >> >> We've noticed that there is some overhead when JFR is included in the jdk > but not running. This may be because the event object has to be > instantiated at each transition whether it's enabled or not. You can see > the exact numbers in the email I previously sent you. If it is the case (although, I am skeptic about it), we should file upstream JFR RFE to provide static method for should_commit(). -Zhengyu > > Have you run hotspot_gc_shenandoah tests? >> >> Yes and all of the tests pass. > > Thanks, > > Ken Dobson > From rkennke at redhat.com Fri Mar 29 22:08:20 2019 From: rkennke at redhat.com (Roman Kennke) Date: Fri, 29 Mar 2019 23:08:20 +0100 Subject: RFR 8221507: Implement JFR Events for Shenandoah In-Reply-To: References: <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com> Message-ID: <472df260-d308-f285-de4e-f61aebfef048@redhat.com> > On Tue, Mar 26, 2019 at 5:16 PM Roman Kennke > wrote: > > > Please review this patch that adds support for two new JFR events > > ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8221507 > > Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/ > > > > The events appears to result in ~2% overhead though there is some > > uncertainty as to whether some of that is noise. > > > > Thanks, > > > > Ken Dobson > > Very nice! > > The overhead is only present with JFR active, I assume? > > We've noticed that there is some overhead when JFR is included in the > jdk but not running. This may be because the event object has to be > instantiated at each transition whether it's enabled or not. You can see > the exact numbers in the email I previously sent you. Hmm, ok. This only ever happens when regions change state, right? I doubt that this is frequent enough to make an actual difference. I suspect that what you see is noise. I'm good. Let's also hear Aleksey's opinion though. Thanks! Roman > > Have you run hotspot_gc_shenandoah tests? > > Yes and all of the tests pass. > > Thanks, > > Ken Dobson