LRB midpath code quality

Aleksey Shipilev shade at redhat.com
Wed Mar 6 09:34:07 UTC 2019


On 3/6/19 10:29 AM, Roman Kennke wrote:
> I believe it does look better now:
> 
> https://paste.fedoraproject.org/paste/nMZb19apbJq0uOB9CboUOA

Yes, those back branches to 0x00007f46f04b9247 is what I wanted to see.

The leftover wrinkle is explicit NPE here, which should be implicit:

 ││  0x00007f46f04b9272: test   %rax,%rax
 ││  0x00007f46f04b9275: je     0x00007f46f04b9294

-Aleksey



More information about the shenandoah-dev mailing list