RFR: Bulk backports jdk12 -> sh/jdk11
Andrew John Hughes
gnu.andrew at redhat.com
Tue Mar 12 04:32:06 UTC 2019
On 11/03/2019 20:45, Aleksey Shipilev wrote:
> On 3/11/19 9:29 PM, Roman Kennke wrote:
>> This backports all relevant Shenandoah changes (I hope) from jdk-updates/jdk12u to shenandoah/jdk11.
>>
>> They all applied mostly clean and trivial. Builds and tests look good.
>>
>> List of changes:
>> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/changes.txt
>>
>> Full webrev:
>> http://cr.openjdk.java.net/~rkennke/upstream-jdk11-merge-2019-03-11/webrev.00/
>
> Looks good to me. Thanks!
>
> Hold on for a minute, though.
>
> Andrew Hughes, notice the synopsis format for the changes:
> [backport] $BUGID $SYNOPSIS
>
> This is almost the same as we did over the years for Shenandoah-specific backports, but now it also
> mentions $BUGID, because Shenandoah is finally upstream. We would like to separate backports that
> are coming to our downstream version of Shenandoah versus the upstream changes (especially those
> coming via 11u updates), therefore Shenandoah-specific backports done by Shenandoah devs start with
> "[backport]". This would also avoid these backports to be accidentally matched by jcheck and/or
> hgupdater.
>
> Does it make sense to you?
>
> -Aleksey
>
That makes sense to me.
My concern is that this is *only* bugs that don't make sense for
upstream 8u or 11u. Anything that can be applied upstream should be and
then integrated into the Shenandoah repositories with a merge. Now we're
handling the tagging/release process there, I don't expect that to have
as many delays as in the past.
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew
More information about the shenandoah-dev
mailing list