RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk

Zhengyu Gu zgu at redhat.com
Thu Mar 14 17:51:15 UTC 2019



On 3/14/19 1:46 PM, Roman Kennke wrote:
> Hi Zhengyu,
> 
>>>>    Passed submit test.
>>>
>>> It looks mostly ok. But why do we need the change in CollectedHeap? 
>>> Why not keep this an impl detail of Shenandoah heap?
>>
>> Because the region iteration code is in shared (ObjectHeap.java)
> 
> 
> Ah ok.
> 
> I have a patch up my sleeve that eliminates the extra word ;-) But I 
> suppose you should not wait for it (probably some weeks).

Yep, we can revert this part once it arrives.

Thanks,

-Zhengyu

> 
> Reviewed!
> 
> Roman
> 


More information about the shenandoah-dev mailing list