From shade at redhat.com  Wed May  1 10:19:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 1 May 2019 12:19:37 +0200
Subject: RFR(M) 8222992: Shenandoah: Pre-evacuate all roots
In-Reply-To: <22cabc5f-5116-07da-30f7-854248e1b932@redhat.com>
References: <2f6eeb40-ccf5-9dd8-7ccc-181e993dedf0@redhat.com>
 <a7d48993-42ae-313a-3899-94e630eba98e@redhat.com>
 <3cf86adc-6865-0b8a-23bd-c93884d6d456@redhat.com>
 <0f6499ee-7b2e-818d-96f8-2d8787b7a10f@redhat.com>
 <22cabc5f-5116-07da-30f7-854248e1b932@redhat.com>
Message-ID: <7166dbbb-71f3-2673-3afd-bc67efe572bc@redhat.com>

On 4/30/19 9:51 PM, Zhengyu Gu wrote:
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8222992/webrev.01/index.html

Something is wrong with the webrev. The patch has:

+void ShenandoahVerifier::verify_roots_no_forwarded() {
+  verify_at_safepoint(
+          "Roots Have Not Forwarded References",
+          _verify_forwarded_none,      // no forwarded references
+          _verify_marked_disable,      // walk only roots
+          _verify_cset_disable,        // no cset verification
+          _verify_liveness_disable,    // no reliable liveness data anymore
+          _verify_regions_notrash,     // trash regions have been recycled already
+          _verify_gcstate_disable      // no gc state check
+  );
+}

...yet webrevs has:

 943 void ShenandoahVerifier::verify_roots_no_forwarded() {
 944   guarantee(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "only when nothing else happens");
 945   ShenandoahRootProcessor rp(_heap, 1, ShenandoahPhaseTimings::_num_phases); // no need for stats
 946   ShenandoahVerifyNoForwared cl;
 947   rp.process_all_roots_slow(&cl);
 948 }


I think missing roots SRP::process_all_roots_slow require a separate changeset, as it should be
backported ahead of this change to other releases;

-Aleksey


From shade at redhat.com  Wed May  1 12:30:32 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 1 May 2019 14:30:32 +0200
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
Message-ID: <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>

On 3/29/19 11:08 PM, Roman Kennke wrote:
>> On Tue, Mar 26, 2019 at 5:16 PM Roman Kennke <rkennke at redhat.com <mailto:rkennke at redhat.com>> wrote:
>>
>> ???? > Please review this patch that adds support for two new JFR events
>> ???? > ShenandoahHeapRegionStateChange and ShenandoahHeapRegionInformation.
>> ???? >
>> ???? > Bug: https://bugs.openjdk.java.net/browse/JDK-8221507
>> ???? > Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/
>> ???? >
>> ???? > The events appears to result in ~2% overhead though there is some
>> ???? > uncertainty as to whether some of that is noise.
>> ???? >
>> ???? > Thanks,
>> ???? >
>> ???? > Ken Dobson
>>
>> ??? Very nice!
>>
>> ??? The overhead is only present with JFR active, I assume?
>>
>> We've noticed that there is some overhead when JFR is included in the jdk but not running. This
>> may be because the event object has to be instantiated at each transition whether it's enabled or
>> not. You can see the exact numbers in the email I previously sent you.
> 
> Hmm, ok. This only ever happens when regions change state, right? I doubt that this is frequent
> enough to make an actual difference. I suspect that what you see is noise. I'm good. Let's also hear
> Aleksey's opinion though.

It looks fine to me. I ran a few tests of my own, and overheads clearly visible with JFR turned on,
but are not bad. The overheads with JFR turned off are slim to none.

Ken, you might want to clean up trailing whitespaces here:

+void ShenandoahJFRSupport::register_jfr_type_serializers() {
+  JfrSerializer::register_serializer(TYPE_SHENANDOAHHEAPREGIONSTATE,
+                                     false,
+                                     true,
+                                     new ShenandoahHeapRegionStateConstant());
+}
+#endif


-Aleksey


From zgu at redhat.com  Wed May  1 12:32:25 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 May 2019 08:32:25 -0400
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
Message-ID: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>

Added missing roots in SRP::process_all_root_slow().

Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/

Test:
   hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)

Thanks,

-Zhengyu


From shade at redhat.com  Wed May  1 12:34:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 1 May 2019 14:34:37 +0200
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
In-Reply-To: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
References: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
Message-ID: <541dafa2-0977-d588-2946-c373f6a6f82a@redhat.com>

On 5/1/19 2:32 PM, Zhengyu Gu wrote:
> Added missing roots in SRP::process_all_root_slow().
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/

Looks good.

We have JvmtiExport::oops_do call in the same method, it does not catch what
JvmtiExport::weak_oops_do does?

-Aleksey


From zgu at redhat.com  Wed May  1 13:18:34 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 May 2019 09:18:34 -0400
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
In-Reply-To: <541dafa2-0977-d588-2946-c373f6a6f82a@redhat.com>
References: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
 <541dafa2-0977-d588-2946-c373f6a6f82a@redhat.com>
Message-ID: <75e6ef85-53c4-7e3d-7f13-ebc300ad34c3@redhat.com>



On 5/1/19 8:34 AM, Aleksey Shipilev wrote:
> On 5/1/19 2:32 PM, Zhengyu Gu wrote:
>> Added missing roots in SRP::process_all_root_slow().
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/
> 
> Looks good.

Thanks for reviewing.
> 
> We have JvmtiExport::oops_do call in the same method, it does not catch what
> JvmtiExport::weak_oops_do does?

No, they scan different things.

void JvmtiExport::oops_do(OopClosure* f) {
   JvmtiCurrentBreakpoints::oops_do(f);
   JvmtiObjectAllocEventCollector::oops_do_for_all_threads(f);
}

void JvmtiExport::weak_oops_do(BoolObjectClosure* is_alive, OopClosure* f) {
   JvmtiTagMap::weak_oops_do(is_alive, f);
}

-Zhengyu

> 
> -Aleksey
> 

From shade at redhat.com  Wed May  1 13:49:54 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 1 May 2019 15:49:54 +0200
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
In-Reply-To: <75e6ef85-53c4-7e3d-7f13-ebc300ad34c3@redhat.com>
References: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
 <541dafa2-0977-d588-2946-c373f6a6f82a@redhat.com>
 <75e6ef85-53c4-7e3d-7f13-ebc300ad34c3@redhat.com>
Message-ID: <67c0d871-fa19-5072-8af5-0c17978c7d43@redhat.com>

On 5/1/19 3:18 PM, Zhengyu Gu wrote:
>> We have JvmtiExport::oops_do call in the same method, it does not catch what
>> JvmtiExport::weak_oops_do does?
> 
> No, they scan different things.
> 
> void JvmtiExport::oops_do(OopClosure* f) {
> ? JvmtiCurrentBreakpoints::oops_do(f);
> ? JvmtiObjectAllocEventCollector::oops_do_for_all_threads(f);
> }
> 
> void JvmtiExport::weak_oops_do(BoolObjectClosure* is_alive, OopClosure* f) {
> ? JvmtiTagMap::weak_oops_do(is_alive, f);
> }

Ah. Okay then!

-Aleksey


From zgu at redhat.com  Wed May  1 14:22:16 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 May 2019 10:22:16 -0400
Subject: RFR(M) 8222992: Shenandoah: Pre-evacuate all roots
In-Reply-To: <7166dbbb-71f3-2673-3afd-bc67efe572bc@redhat.com>
References: <2f6eeb40-ccf5-9dd8-7ccc-181e993dedf0@redhat.com>
 <a7d48993-42ae-313a-3899-94e630eba98e@redhat.com>
 <3cf86adc-6865-0b8a-23bd-c93884d6d456@redhat.com>
 <0f6499ee-7b2e-818d-96f8-2d8787b7a10f@redhat.com>
 <22cabc5f-5116-07da-30f7-854248e1b932@redhat.com>
 <7166dbbb-71f3-2673-3afd-bc67efe572bc@redhat.com>
Message-ID: <49aab5a0-8f04-8f52-9b7e-c489cb3dbd93@redhat.com>



On 5/1/19 6:19 AM, Aleksey Shipilev wrote:
> On 4/30/19 9:51 PM, Zhengyu Gu wrote:
>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8222992/webrev.01/index.html
> 
> Something is wrong with the webrev. The patch has:
> 
> +void ShenandoahVerifier::verify_roots_no_forwarded() {
> +  verify_at_safepoint(
> +          "Roots Have Not Forwarded References",
> +          _verify_forwarded_none,      // no forwarded references
> +          _verify_marked_disable,      // walk only roots
> +          _verify_cset_disable,        // no cset verification
> +          _verify_liveness_disable,    // no reliable liveness data anymore
> +          _verify_regions_notrash,     // trash regions have been recycled already
> +          _verify_gcstate_disable      // no gc state check
> +  );
> +}
> 
> ...yet webrevs has:
> 
>   943 void ShenandoahVerifier::verify_roots_no_forwarded() {
>   944   guarantee(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "only when nothing else happens");
>   945   ShenandoahRootProcessor rp(_heap, 1, ShenandoahPhaseTimings::_num_phases); // no need for stats
>   946   ShenandoahVerifyNoForwared cl;
>   947   rp.process_all_roots_slow(&cl);
>   948 } >
> 
> I think missing roots SRP::process_all_roots_slow require a separate changeset, as it should be
> backported ahead of this change to other releases;
>

Fixed SRP::process_all_roots_slow() in JDK-8223184 and rebased this patch:

Updated webrev: 
http://cr.openjdk.java.net/~zgu/JDK-8222992/webrev.02/index.html

Reran hotspot_gc_shenandoah tests with -XX:+ShenandoahVerify

Thanks,

-Zhengyu



> -Aleksey
> 

From rkennke at redhat.com  Wed May  1 18:18:49 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 1 May 2019 20:18:49 +0200
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
In-Reply-To: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
References: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
Message-ID: <af1073f4-d211-7da3-6926-227879e3748e@redhat.com>

Isn't JvmtiExport::weak_oops_do() covered by WeakProcessor already?

Roman

> Added missing roots in SRP::process_all_root_slow().
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/
> 
> Test:
>  ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu
> 

From zgu at redhat.com  Wed May  1 18:57:03 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 1 May 2019 14:57:03 -0400
Subject: RFR(XXS) 8223184: Shenandoah: Missing roots in
 SRP::process_all_roots_slow
In-Reply-To: <af1073f4-d211-7da3-6926-227879e3748e@redhat.com>
References: <89fccd7c-f931-3496-2d2c-7a1f49161a73@redhat.com>
 <af1073f4-d211-7da3-6926-227879e3748e@redhat.com>
Message-ID: <386e73ab-53f4-5e46-e651-d73ac014d05c@redhat.com>

On 5/1/19 2:18 PM, Roman Kennke wrote:
> Isn't JvmtiExport::weak_oops_do() covered by WeakProcessor already?

You are right. Unfortunately, I pushed. Will file RFE to remove it.

-Zhengyu

> 
> Roman
> 
>> Added missing roots in SRP::process_all_root_slow().
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223184
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223184/webrev.00/
>>
>> Test:
>> ?? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and 
>> release)
>>
>> Thanks,
>>
>> -Zhengyu
>>

From gnu.andrew at redhat.com  Thu May  2 04:20:54 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Thu, 2 May 2019 05:20:54 +0100
Subject: RFR: Bulk integration shenandoah/jdk8u ->
 aarch64-port/jdk8u-shenandoah 2019-04-29
In-Reply-To: <8bf2849b-002e-3eb0-15e4-7c49f840f683@redhat.com>
References: <51050c8d-92dd-b0f0-3657-65d91a34fec0@redhat.com>
 <1a56142c-c531-ee06-f271-d6854dc6a72f@redhat.com>
 <084dff65-c8c2-dea4-6d36-9f7f4656dede@redhat.com>
 <8bf2849b-002e-3eb0-15e4-7c49f840f683@redhat.com>
Message-ID: <61b7b3c9-ef78-c5fd-4e8c-9aa4f1ddaece@redhat.com>



On 30/04/2019 13:27, Aleksey Shipilev wrote:
> On 4/29/19 10:35 PM, Roman Kennke wrote:
>>>> List of changes:
>>>> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2019-04-29/changes.txt
>>>>
>>>> Complete Webrev:
>>>> http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2019-04-29/webrev-all.00/
>>>
>>> Looks okay to me. My only wish is to wait a little while a few last (pretty innocuous in themselves)
>>> fixes pass the builds and tests in a day or two.
>>
>> Right, no problem. Just ping me when it's good. ;-)
> 
> Two rounds of build-tests have finished on sh/jdk8 that include all of the changesets this RFR
> suggests to integrate. Thumbs up from me. Andrew(s) need to ack the push now.
> 
> -Aleksey
> 

Yeah, it would have been nice to have chance to review this... :)
Maybe leave at least 24 hours next time for a change this big.

I've tagged this as
aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30, following
the same naming system we've used previously.

I'll push that along with aarch64-shenandoah-jdk8u222-b01 which I'll be
proposing for inclusion as soon as my build completes successfully.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Thu May  2 11:33:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 2 May 2019 13:33:45 +0200
Subject: RFR(M) 8222992: Shenandoah: Pre-evacuate all roots
In-Reply-To: <49aab5a0-8f04-8f52-9b7e-c489cb3dbd93@redhat.com>
References: <2f6eeb40-ccf5-9dd8-7ccc-181e993dedf0@redhat.com>
 <a7d48993-42ae-313a-3899-94e630eba98e@redhat.com>
 <3cf86adc-6865-0b8a-23bd-c93884d6d456@redhat.com>
 <0f6499ee-7b2e-818d-96f8-2d8787b7a10f@redhat.com>
 <22cabc5f-5116-07da-30f7-854248e1b932@redhat.com>
 <7166dbbb-71f3-2673-3afd-bc67efe572bc@redhat.com>
 <49aab5a0-8f04-8f52-9b7e-c489cb3dbd93@redhat.com>
Message-ID: <ddb7344b-44b5-6986-3320-523f406d84a8@redhat.com>

On 5/1/19 4:22 PM, Zhengyu Gu wrote:
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8222992/webrev.02/index.html

This looks okay to me.

Not a fan of the separate ShenandoahVerifier::verify_roots_no_forwarded, since we could "just" fold
stronger (non-forwarded) root verification to the generic verification code (e.g. in
ShenandoahVerifierReachableTask). That, however, might end up with some failures in Traversal and
such. We can do that as follow-up.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May  2 12:12:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 2 May 2019 14:12:46 +0200
Subject: RFC: Pick up jdk-13+19 to sh/jdk
Message-ID: <c83f204f-8823-bbed-3697-f1ee0403a4b8@redhat.com>

We have not synced up sh/jdk for a while now. Let's pick up to the latest upstream tag, jdk-13+17.
Merge is trivial, because sh/jdk has no diffs against jdk/jdk, except tags.

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b19/changesets.txt

Testing: tier1_gc_shenandoah {fastdebug, release}

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Thu May  2 12:18:21 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 2 May 2019 14:18:21 +0200
Subject: RFC: Pick up jdk-13+19 to sh/jdk
In-Reply-To: <c83f204f-8823-bbed-3697-f1ee0403a4b8@redhat.com>
References: <c83f204f-8823-bbed-3697-f1ee0403a4b8@redhat.com>
Message-ID: <30baf717-ca25-9f58-a52b-a77a75a56e2b@redhat.com>

Yes, please do it!

Roman


> We have not synced up sh/jdk for a while now. Let's pick up to the latest upstream tag, jdk-13+17.
> Merge is trivial, because sh/jdk has no diffs against jdk/jdk, except tags.
> 
> Changesets:
>    http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b19/changesets.txt
> 
> Testing: tier1_gc_shenandoah {fastdebug, release}
> 

From shade at redhat.com  Thu May  2 12:33:05 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 02 May 2019 12:33:05 +0000
Subject: hg: shenandoah/jdk: 62 new changesets
Message-ID: <201905021233.x42CXAPD018151@aojmv0008.oracle.com>

Changeset: c7eb491b05b7
Author:    jwilhelm
Date:      2019-04-25 02:14 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c7eb491b05b7

8222952: Typo in test/hotspot/jtreg/TEST.groups is causing test harness failures
Reviewed-by: darcy

! test/hotspot/jtreg/TEST.groups

Changeset: 3a34f5173c36
Author:    jwilhelm
Date:      2019-04-25 02:23 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a34f5173c36

Added tag jdk-13+18 for changeset bebb82ef3434

! .hgtags

Changeset: fe9f33555993
Author:    jcbeyler
Date:      2019-04-24 19:51 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fe9f33555993

8222935: Fix ExceptionCheckingJniEnv system
Summary: Added missing tests and fixed the code
Reviewed-by: cjplummer, sspitsyn, amenkov

+ test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001.java
+ test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/TestDescription.java
+ test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/exceptionjni001.cpp
+ test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/libexceptionjni001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv.cpp

Changeset: 9afd2868c18b
Author:    pliden
Date:      2019-04-25 08:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9afd2868c18b

8222664: runtime/appcds/sharedStrings/SharedStringsStress.java assert GC active during NoGCVerifier
Reviewed-by: iklam, stefank

! src/hotspot/share/gc/shared/stringdedup/stringDedupThread.cpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupThread.inline.hpp

Changeset: 3ab77d8dc60a
Author:    pliden
Date:      2019-04-25 08:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3ab77d8dc60a

8222462: Introduce CollectedHeap::unused()
Reviewed-by: stefank, eosterlund

! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
! src/hotspot/share/gc/z/zHeap.cpp
! src/hotspot/share/gc/z/zHeap.hpp
! src/hotspot/share/gc/z/zPageAllocator.cpp
! src/hotspot/share/gc/z/zPageAllocator.hpp
! src/hotspot/share/prims/jvm.cpp

Changeset: 24f6b0e413a0
Author:    pliden
Date:      2019-04-25 08:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/24f6b0e413a0

8221786: ZGC: Increase max heap size to 16TB
Reviewed-by: stefank

- src/hotspot/os_cpu/linux_x86/gc/z/zAddress_linux_x86.inline.hpp
! src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.hpp
! src/hotspot/share/gc/z/zAddress.cpp
! src/hotspot/share/gc/z/zAddress.hpp
! src/hotspot/share/gc/z/zAddress.inline.hpp
! src/hotspot/share/gc/z/zArguments.cpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zGlobals.cpp
! src/hotspot/share/gc/z/zGlobals.hpp
! src/hotspot/share/gc/z/zHeap.cpp
! src/hotspot/share/gc/z/zInitialize.cpp
! src/hotspot/share/gc/z/zVirtualMemory.cpp
! test/hotspot/gtest/gc/z/test_zAddress.cpp

Changeset: 152c6c501ba5
Author:    pliden
Date:      2019-04-25 08:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/152c6c501ba5

8222469: ZGC: Generalize ZPageCache::flush()
Reviewed-by: stefank

! src/hotspot/share/gc/z/zPageAllocator.cpp
! src/hotspot/share/gc/z/zPageAllocator.hpp
! src/hotspot/share/gc/z/zPageCache.cpp
! src/hotspot/share/gc/z/zPageCache.hpp

Changeset: b43cc3b9ef40
Author:    hannesw
Date:      2019-04-25 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b43cc3b9ef40

8220497: Improve Javadoc search feature and add test coverage
Reviewed-by: jjg

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js
! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/javadoc-search.js
+ test/langtools/jdk/javadoc/doclet/testSearchScript/listpkg/List.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/listpkg/ListProvider.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/listpkg/MyList.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/listpkg/MyListFactory.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/listpkg/Nolist.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/mapmodule/mappkg/Map.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/mapmodule/mappkg/impl/MyMap.java
+ test/langtools/jdk/javadoc/doclet/testSearchScript/mapmodule/module-info.java

Changeset: 13b67c1420b8
Author:    alanb
Date:      2019-04-25 10:41 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/13b67c1420b8

8222774: (ch) Replace uses of stateLock and blockingLock with j.u.c. locks
Reviewed-by: dfuchs, bpb, martin

! src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java
! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java
+ src/java.base/share/classes/sun/nio/ch/DummySocketImpl.java
! src/java.base/share/classes/sun/nio/ch/SelChImpl.java
! src/java.base/share/classes/sun/nio/ch/ServerSocketAdaptor.java
! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java
! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java
! src/java.base/unix/classes/sun/nio/ch/SinkChannelImpl.java
! src/java.base/unix/classes/sun/nio/ch/SourceChannelImpl.java
+ test/jdk/java/nio/channels/SocketChannel/AdaptorStreams.java
- test/jdk/java/nio/channels/SocketChannel/Stream.java

Changeset: 0b6dc5b93306
Author:    rwestberg
Date:      2019-04-24 14:03 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0b6dc5b93306

8220795: Rework naked_short_nanosleep on Windows to improve time-to-safepoint
Reviewed-by: dholmes, rehn

! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/runtime/safepoint.cpp

Changeset: a8dcacf95bff
Author:    robm
Date:      2019-04-25 05:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a8dcacf95bff

8139965: Hang seen when using com.sun.jndi.ldap.search.replyQueueSize
Reviewed-by: dfuchs

! src/java.naming/share/classes/com/sun/jndi/ldap/BerDecoder.java
! src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java
! src/java.naming/share/classes/com/sun/jndi/ldap/LdapRequest.java
! test/jdk/com/sun/jndi/ldap/LdapDnsProviderTest.java

Changeset: 1126f0607c70
Author:    coleenp
Date:      2019-04-25 10:56 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1126f0607c70

8222811: Consolidate MutexLockerEx and MutexLocker
Summary: Make MutexLocker be MutexLockerEx implementation, remove MutexLockerEx calls.
Reviewed-by: dcubed, dholmes, pliden, rehn

! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/share/aot/aotCompiledMethod.cpp
! src/hotspot/share/aot/aotLoader.cpp
! src/hotspot/share/c1/c1_Runtime1.cpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/dictionary.cpp
! src/hotspot/share/classfile/packageEntry.cpp
! src/hotspot/share/classfile/protectionDomainCache.cpp
! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/code/codeBlob.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/icBuffer.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/stubs.cpp
! src/hotspot/share/code/vtableStubs.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/compilerDirectives.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/cms/cmsVMOperations.cpp
! src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp
! src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp
! src/hotspot/share/gc/cms/yieldingWorkgroup.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.cpp
! src/hotspot/share/gc/g1/g1Allocator.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
! src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp
! src/hotspot/share/gc/g1/g1FullGCOopClosures.cpp
! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp
! src/hotspot/share/gc/g1/g1RootProcessor.cpp
! src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1StringDedupQueue.cpp
! src/hotspot/share/gc/g1/g1VMOperations.cpp
! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp
! src/hotspot/share/gc/g1/heapRegion.cpp
! src/hotspot/share/gc/g1/heapRegionRemSet.cpp
! src/hotspot/share/gc/g1/heapRegionRemSet.hpp
! src/hotspot/share/gc/parallel/gcTaskManager.cpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/concurrentGCPhaseManager.cpp
! src/hotspot/share/gc/shared/concurrentGCThread.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/oopStorage.cpp
! src/hotspot/share/gc/shared/owstTaskTerminator.cpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.hpp
! src/hotspot/share/gc/shared/suspendibleThreadSet.cpp
! src/hotspot/share/gc/shared/workgroup.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
! src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp
! src/hotspot/share/gc/z/zMessagePort.inline.hpp
! src/hotspot/share/gc/z/zMetronome.cpp
! src/hotspot/share/gc/z/zNMethodTable.cpp
! src/hotspot/share/gc/z/zReferenceProcessor.cpp
! src/hotspot/share/gc/z/zRuntimeWorkers.cpp
! src/hotspot/share/gc/z/zUnload.cpp
! src/hotspot/share/gc/z/zWorkers.cpp
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp
! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp
! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp
! src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderThreadLoop.cpp
! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp
! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/metaspace/chunkManager.cpp
! src/hotspot/share/memory/metaspace/spaceManager.cpp
! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvmtiCodeBlobEvents.cpp
! src/hotspot/share/prims/jvmtiEnv.cpp
! src/hotspot/share/prims/jvmtiEventController.cpp
! src/hotspot/share/prims/jvmtiExport.cpp
! src/hotspot/share/prims/methodHandles.cpp
! src/hotspot/share/prims/resolvedMethodTable.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/handshake.cpp
! src/hotspot/share/runtime/init.cpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/jniHandles.cpp
! src/hotspot/share/runtime/mutex.cpp
! src/hotspot/share/runtime/mutex.hpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/serviceThread.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/sweeper.cpp
! src/hotspot/share/runtime/task.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/threadSMR.cpp
! src/hotspot/share/runtime/threadSMR.inline.hpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/hotspot/share/runtime/vmThread.cpp
! src/hotspot/share/services/diagnosticFramework.cpp
! src/hotspot/share/services/gcNotifier.cpp
! src/hotspot/share/services/lowMemoryDetector.cpp
! src/hotspot/share/services/management.cpp
! src/hotspot/share/services/memoryManager.cpp
! src/hotspot/share/services/threadService.cpp
! src/hotspot/share/utilities/decoder.cpp
! src/hotspot/share/utilities/decoder.hpp
! src/hotspot/share/utilities/events.cpp
! src/hotspot/share/utilities/events.hpp
! src/hotspot/share/utilities/vmError.cpp
! test/hotspot/gtest/gc/shared/test_oopStorage.cpp
! test/hotspot/gtest/memory/test_is_metaspace_obj.cpp
! test/hotspot/gtest/memory/test_metaspace.cpp
! test/hotspot/gtest/memory/test_metaspace_allocation.cpp
! test/hotspot/gtest/runtime/test_threads.cpp
! test/hotspot/gtest/threadHelper.inline.hpp

Changeset: beaea3c10b0f
Author:    coleenp
Date:      2019-04-25 12:33 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/beaea3c10b0f

8222977: Fix shenandoah broken with JDK-8222811
Reviewed-by: dcubed, shade

! src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp

Changeset: 7f30741331ad
Author:    mseledtsov
Date:      2019-04-25 11:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7f30741331ad

8222888: [TESTBUG] docker/TestJFREvents.java fails due to "RuntimeException: JAVA_MAIN_CLASS_ is not defined"
Summary: Introduced unique environment variable
Reviewed-by: egahlin, lmesnik, sgehwolf

! test/hotspot/jtreg/containers/docker/TestJFREvents.java
! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java

Changeset: 3fb6efa2c9f1
Author:    dholmes
Date:      2019-04-25 18:41 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3fb6efa2c9f1

8222970: Update ProblemList for vmTestbase/nsk/jdb/eval/eval001/eval001.java
Reviewed-by: gadams, dcubed, sspitsyn

! test/hotspot/jtreg/ProblemList.txt

Changeset: 22323f20401b
Author:    aeubanks
Date:      2019-04-16 13:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/22323f20401b

8222562: Don't set IPV6_V6ONLY when IPv4 is not available
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! src/java.base/share/native/libnet/net_util.c
! src/java.base/share/native/libnet/net_util.h
! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c
! src/java.base/unix/native/libnet/PlainSocketImpl.c
! src/java.base/unix/native/libnet/net_util_md.c
! src/java.base/unix/native/libnio/ch/Net.c
! src/java.base/windows/native/libnet/net_util_md.c

Changeset: dcb78d2f07e5
Author:    joehw
Date:      2019-04-25 15:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dcb78d2f07e5

8222743: Xerces 2.12.0: DOM Implementation
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/AttrImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/AttrNSImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ChildNode.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDOMImplementationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentTypeImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementNSImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/NodeImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDOMImplementationImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ParentNode.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/TextImpl.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/ParserConfigurationSettings.java
! test/jaxp/javax/xml/jaxp/unittest/dom/DocumentTest.java

Changeset: 9ebb614d293d
Author:    dholmes
Date:      2019-04-26 00:57 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9ebb614d293d

8222518: Remove unnecessary caching of Parker object in java.lang.Thread
Reviewed-by: dcubed, rehn

! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/prims/unsafe.cpp
! src/java.base/share/classes/java/lang/Thread.java

Changeset: 04b17e84c87d
Author:    clanger
Date:      2019-04-26 08:53 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/04b17e84c87d

8222440: (zipfs) JarFileSystem does not correctly handle versioned entries if no root entry is present
Reviewed-by: lancea

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf4.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf4.txt

Changeset: 3a3e4e473622
Author:    rehn
Date:      2019-04-26 10:18 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a3e4e473622

8222637: Obsolete NeedsDeoptSuspend
Reviewed-by: dlong, coleenp, dholmes

! src/hotspot/cpu/aarch64/globals_aarch64.hpp
! src/hotspot/cpu/arm/globals_arm.hpp
! src/hotspot/cpu/ppc/globals_ppc.hpp
! src/hotspot/cpu/s390/globals_s390.hpp
! src/hotspot/cpu/sparc/globals_sparc.hpp
! src/hotspot/cpu/x86/globals_x86.hpp
! src/hotspot/cpu/zero/globals_zero.hpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/frame.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/thread.inline.hpp

Changeset: 2d0c05e71bd5
Author:    pliden
Date:      2019-04-26 12:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2d0c05e71bd5

8223016: ZGC: Fix misaligned statistics printout
Reviewed-by: tschatzl

! src/hotspot/share/gc/z/zStat.cpp

Changeset: 84261c6b227b
Author:    jwilhelm
Date:      2019-04-26 12:35 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/84261c6b227b

8223026: [BACKOUT] Typo in test/hotspot/jtreg/TEST.groups is causing test harness failures
Reviewed-by: dsimms

! test/hotspot/jtreg/TEST.groups

Changeset: 59c01214e478
Author:    dfuchs
Date:      2019-04-26 16:25 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/59c01214e478

8129315: java/net/Socket/LingerTest.java and java/net/Socket/ShutdownBoth.java timeout intermittently
Summary: tests are updated to use the loopback address instead of the wildcard to avoid traffic being routed to a different server than what was intended by the test.
Reviewed-by: chegar

! test/jdk/java/net/Socket/LingerTest.java
! test/jdk/java/net/Socket/ShutdownBoth.java
! test/jdk/java/net/Socks/SocksIPv6Test.java
! test/jdk/java/net/Socks/SocksServer.java
! test/jdk/sun/net/www/http/HttpURLConnection/PostOnDelete.java

Changeset: 14615b8ac24c
Author:    avoitylov
Date:      2019-04-26 18:56 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/14615b8ac24c

8221988: add possibility to build with Visual Studio 2019
Reviewed-by: erikj, ysuenaga

! doc/building.html
! doc/building.md
! make/autoconf/toolchain_windows.m4
+ make/devkit/createWindowsDevkit2019.sh

Changeset: 515568d2e85c
Author:    naoto
Date:      2019-04-26 09:09 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/515568d2e85c

8222980: Upgrade IANA Language Subtag Registry to Version 2019-04-03
Reviewed-by: bpb, lancea

! make/data/lsrdata/language-subtag-registry.txt
! test/jdk/java/util/Locale/Bug8040211.java

Changeset: b71940f7fa96
Author:    vromero
Date:      2019-04-26 12:49 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b71940f7fa96

8219487: j.l.c.ClassDesc spec should contain precise assertions for one parameter's methods
Reviewed-by: darcy, jlaskey

! src/java.base/share/classes/java/lang/constant/ClassDesc.java

Changeset: 9b8926bf85c1
Author:    lmesnik
Date:      2019-04-26 11:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9b8926bf85c1

8220813: update hotspot tier1_gc tests depending on GC to use @requires vm.gc.X
Reviewed-by: pliden, lmesnik
Contributed-by: aoqi at loongson.cn

! test/hotspot/jtreg/gc/TestAgeOutput.java
! test/hotspot/jtreg/gc/TestGenerationPerfCounter.java
! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/TestMemoryMXBeansAndPoolsPresence.java
! test/hotspot/jtreg/gc/TestNumWorkerOutput.java
! test/hotspot/jtreg/gc/TestPolicyNamePerfCounter.java
! test/hotspot/jtreg/gc/TestSmallHeap.java
! test/hotspot/jtreg/gc/TestSystemGC.java
! test/hotspot/jtreg/gc/arguments/TestAlignmentToUseLargePages.java
! test/hotspot/jtreg/gc/arguments/TestMaxNewSize.java
! test/hotspot/jtreg/gc/arguments/TestMinInitialErgonomics.java
! test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java
! test/hotspot/jtreg/gc/arguments/TestParallelHeapSizeFlags.java
! test/hotspot/jtreg/gc/arguments/TestParallelRefProc.java
! test/hotspot/jtreg/gc/arguments/TestSelectDefaultGC.java
! test/hotspot/jtreg/gc/arguments/TestUseCompressedOopsErgo.java
! test/hotspot/jtreg/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java
! test/hotspot/jtreg/gc/class_unloading/TestClassUnloadingDisabled.java
! test/hotspot/jtreg/gc/class_unloading/TestG1ClassUnloadingHWM.java
! test/hotspot/jtreg/gc/cms/GuardShrinkWarning.java
! test/hotspot/jtreg/gc/ergonomics/TestDynamicNumberOfGCThreads.java
! test/hotspot/jtreg/gc/ergonomics/TestInitialGCThreadLogging.java
! test/hotspot/jtreg/gc/g1/TestShrinkDefragmentedHeap.java
! test/hotspot/jtreg/gc/logging/TestGCId.java
! test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java
! test/hotspot/jtreg/gc/logging/TestPrintReferences.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspaceCMSCancel.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java
! test/hotspot/jtreg/gc/parallel/AdaptiveGCBoundary.java
! test/hotspot/jtreg/gc/startup_warnings/TestCMS.java
! test/hotspot/jtreg/gc/startup_warnings/TestG1.java
! test/hotspot/jtreg/gc/startup_warnings/TestParallelGC.java
! test/hotspot/jtreg/gc/startup_warnings/TestParallelScavengeSerialOld.java

Changeset: 2cac7d48db4c
Author:    weijun
Date:      2019-04-27 18:21 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2cac7d48db4c

8223003: SunMSCAPI keys are not cleaned up
Reviewed-by: igerasim

! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CKey.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CKeyPair.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPrivateKey.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java
! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp
! test/jdk/java/security/KeyPairGenerator/FinalizeHalf.java

Changeset: 2f4393ec54d4
Author:    thartmann
Date:      2019-04-29 09:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2f4393ec54d4

8221592: C2 compilation failed with assert(!q->is_MergeMem())
Summary: Transform the original MergeMem after transforming the slices to get rid of MergeMem inputs.
Reviewed-by: kvn, neliasso

! src/hotspot/share/opto/parse1.cpp

Changeset: ff0a691901c9
Author:    clanger
Date:      2019-04-29 10:27 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ff0a691901c9

8223015: Cleanups for zipfs tests
Reviewed-by: redestad, lancea

! test/jdk/jdk/nio/zipfs/Demo.java
- test/jdk/jdk/nio/zipfs/MultiReleaseJarTest.java
! test/jdk/jdk/nio/zipfs/PathOps.java
! test/jdk/jdk/nio/zipfs/ZipFSTester.java
+ test/jdk/jdk/nio/zipfs/jarfs/MultiReleaseJarTest.java
! test/jdk/lib/testlibrary/java/util/jar/CreateMultiReleaseTestJars.java

Changeset: d3dcec24a469
Author:    fyang
Date:      2019-04-26 16:38 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d3dcec24a469

8223020: aarch64: expand minI_rReg and maxI_rReg patterns into separate instructions
Reviewed-by: aph

! src/hotspot/cpu/aarch64/aarch64.ad

Changeset: 3edf22a7cbaf
Author:    bpb
Date:      2019-04-29 07:39 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3edf22a7cbaf

8218280: LineNumberReader throws "Mark invalid" exception if CRLF straddles buffer.
Reviewed-by: dfuchs, prappo

! src/java.base/share/classes/java/io/LineNumberReader.java
+ test/jdk/java/io/LineNumberReader/MarkSplitCRLF.java

Changeset: 8d52b4c6f9d8
Author:    mullan
Date:      2019-04-29 14:34 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8d52b4c6f9d8

8036608: Key.getAlgorithm link to standard algorithm names needs to be updated
Reviewed-by: xuelei

! src/java.base/share/classes/java/security/Key.java

Changeset: 05aaccf7d558
Author:    coleenp
Date:      2019-04-29 16:01 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/05aaccf7d558

8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
Summary: fixed use cases in code except CMS.
Reviewed-by: rehn, dcubed

! src/hotspot/share/compiler/abstractCompiler.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
! src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp
! src/hotspot/share/gc/g1/g1RootProcessor.cpp
! src/hotspot/share/gc/g1/g1VMOperations.cpp
! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp
! src/hotspot/share/gc/parallel/gcTaskManager.cpp
! src/hotspot/share/gc/shared/gcLocker.cpp
! src/hotspot/share/gc/shared/workgroup.cpp
! src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp
! src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp
! src/hotspot/share/prims/jvmtiRedefineClasses.cpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/sweeper.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/hotspot/share/runtime/vmThread.cpp

Changeset: 5b1eec609909
Author:    manc
Date:      2019-03-08 18:21 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5b1eec609909

8220388: Increase -inlinehint-threshold for Clang to avoid G1 pause time regression
Summary: Make Clang inline more aggressively for functions with inline keyword
Reviewed-by: erikj, jiangli, shade

! make/autoconf/flags-cflags.m4

Changeset: c0d9bc9b4e1f
Author:    dlong
Date:      2019-04-24 09:10 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c0d9bc9b4e1f

8219403: JVMCIRuntime::adjust_comp_level should be replaced
Reviewed-by: kvn, dnsimon, never

! src/hotspot/share/jvmci/jvmciCompiler.cpp
! src/hotspot/share/jvmci/jvmciCompiler.hpp
! src/hotspot/share/jvmci/jvmciJavaClasses.hpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/jvmci/jvmciRuntime.hpp
! src/hotspot/share/jvmci/vmSymbols_jvmci.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! src/hotspot/share/runtime/tieredThresholdPolicy.hpp
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicate.java
! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 89f2043ee67a
Author:    pmuthuswamy
Date:      2019-04-30 11:58 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/89f2043ee67a

8221991: Improve the HTML for the inheritance tree for a type
Reviewed-by: hannesw

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
! test/langtools/jdk/javadoc/doclet/AccessAsciiArt/AccessAsciiArt.java
! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java
! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java
! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java
! test/langtools/jdk/javadoc/doclet/testSingletonLists/TestSingletonLists.java

Changeset: 73a87b1aacc2
Author:    rschmelter
Date:      2019-04-17 01:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/73a87b1aacc2

8222529: sun.jdwp.listenerAddress agent property uses wrong encoding
Reviewed-by: sspitsyn, amenkov, clanger, erikj

! make/lib/Lib-jdk.jdwp.agent.gmk
! src/jdk.jdwp.agent/share/native/libjdwp/util.c

Changeset: d9208a660094
Author:    jlahoda
Date:      2019-04-30 10:39 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d9208a660094

8218152: [javac] fails and exits with no error if a bad annotation processor provided
Summary: Handle exceptions thrown while loading annotation processors.
Reviewed-by: jlahoda
Contributed-by: groeges at uk.ibm.com

! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/langtools/tools/javac/annotations/8218152/MalformedAnnotationProcessorTests.java
! test/langtools/tools/javac/diags/examples.not-yet.txt

Changeset: e6e327553024
Author:    sspitsyn
Date:      2019-04-30 01:56 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e6e327553024

8222934: mark new VM option AllowRedefinitionToAddOrDeleteMethods as deprecated
Summary: Mark new option depricated
Reviewed-by: dcubed, coleenp, dholmes

! src/hotspot/share/runtime/globals.hpp
! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestAddDeleteMethods.java

Changeset: 1cb0306f16d1
Author:    redestad
Date:      2019-04-30 12:54 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1cb0306f16d1

8222852: Reduce String concat combinator tree shapes by folding constants into prependers
Reviewed-by: shade, plevart, forax
Contributed-by: claes.redestad at oracle.com, peter.levart at gmail.com

! src/java.base/share/classes/java/lang/StringConcatHelper.java
! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java
- test/jdk/java/lang/String/concat/StringConcatFactoryEmptyMethods.java
+ test/jdk/java/lang/String/concat/StringConcatFactoryRepeatedConstants.java
! test/micro/org/openjdk/bench/java/lang/StringConcat.java

Changeset: 332f28c3a105
Author:    thartmann
Date:      2019-04-30 14:49 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/332f28c3a105

8219807: C2 crash in IfNode::up_one_dom(Node*, bool)
Summary: Guard against regions degraded to copies.
Reviewed-by: kvn

! src/hotspot/share/opto/ifnode.cpp
+ test/hotspot/jtreg/compiler/c2/TestIfWithDeadRegion.java

Changeset: 7acebe4d65e2
Author:    sgehwolf
Date:      2019-04-18 13:58 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7acebe4d65e2

8221639: [i386] expand_exec_shield_cs_limit workaround is undefined code after JDK-8199717
Summary: Only perform this optimization for x86_64
Reviewed-by: dholmes, andrew

! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp

Changeset: f7204876ce87
Author:    dtitov
Date:      2019-04-30 08:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f7204876ce87

8222749: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "eventSet1.size() != 3 :: 2"
Reviewed-by: sspitsyn, jcbeyler

! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001.java

Changeset: 3f72db799fbd
Author:    erikj
Date:      2019-04-30 10:24 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3f72db799fbd

8222913: Add Jib support for VERSION_EXTRA*
Reviewed-by: tbell, mikael

! make/conf/jib-profiles.js

Changeset: bcea46e28de0
Author:    rhalade
Date:      2019-04-30 11:04 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bcea46e28de0

8216577: Add GlobalSign's R6 Root certificate
Reviewed-by: mullan, clanger

! src/java.base/share/lib/security/cacerts
+ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: a86c5059749b
Author:    rhalade
Date:      2019-04-30 12:53 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a86c5059749b

8222137: Remove T-Systems root CA certificate
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 62d6baca22fc
Author:    jcbeyler
Date:      2019-04-30 15:39 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/62d6baca22fc

8215113: Sampling interval not always correct
Summary: Fix the sampling interval
Reviewed-by: phh, sspitsyn

! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp
! src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp
! src/hotspot/share/runtime/threadHeapSampler.cpp
! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java
! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorArrayAllSampledTest.java
! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

Changeset: 4dc2f6122252
Author:    dtitov
Date:      2019-04-30 16:11 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4dc2f6122252

8222821: com/sun/jdi/ExceptionEvents.java failed
Reviewed-by: dlong, sspitsyn, jcbeyler, cjplummer

! test/jdk/com/sun/jdi/ExceptionEvents.java

Changeset: 616618caad5e
Author:    jcbeyler
Date:      2019-04-30 20:26 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/616618caad5e

8223146: [TESTBUG] new test  vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows
Summary: Keep it simple and handle INT32_MIN separately
Reviewed-by: dholmes, sspitsyn

! test/hotspot/jtreg/vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv.cpp

Changeset: afce4a27f2c2
Author:    coleenp
Date:      2019-05-01 07:12 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/afce4a27f2c2

8213399: DecoderLocker is unused
Summary: remove DecoderLocker
Reviewed-by: iklam, dholmes

! src/hotspot/share/utilities/decoder.cpp
! src/hotspot/share/utilities/decoder.hpp

Changeset: f03d5a093093
Author:    coleenp
Date:      2019-05-01 08:56 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f03d5a093093

8074355: make MutexLocker smarter about non-JavaThreads
Summary: Use safepoint_check_always/safepoint_check_never instead of safepoint_check_sometimes for locks that are taken by JavaThreads and non-JavaThreads
Reviewed-by: dholmes, rehn, dcubed, lmesnik

! src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/cms/yieldingWorkgroup.cpp
! src/hotspot/share/gc/shared/oopStorage.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.cpp
! src/hotspot/share/runtime/mutex.cpp
! src/hotspot/share/runtime/mutex.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/vmThread.cpp
+ test/hotspot/jtreg/runtime/Shutdown/ShutdownTest.java

Changeset: 5ddea9d48649
Author:    zgu
Date:      2019-05-01 10:12 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5ddea9d48649

8223184: Shenandoah: Missing roots in SRP::process_all_roots_slow
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp

Changeset: f14a826e3c2e
Author:    coleenp
Date:      2019-05-01 10:54 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f14a826e3c2e

8223190: Test gc/arguments/TestShrinkHeapInSteps.java breaks with change for JDK-8074355
Summary: Remove too strict assert.
Reviewed-by: hseigel

! src/hotspot/share/runtime/mutex.cpp

Changeset: 1b5f0a3f9c41
Author:    martin
Date:      2019-05-01 09:06 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1b5f0a3f9c41

8223078: Add microbenchmark for array copying/clearing/resizing
Reviewed-by: dl, redestad

+ test/micro/org/openjdk/bench/java/lang/ArrayFiddle.java

Changeset: f8d2b5ce4491
Author:    rraghavan
Date:      2019-05-01 22:02 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f8d2b5ce4491

8202414: Unsafe write after primitive array creation may result in array length change
Summary: Avoided collecting unaligned stores in Initialize node by making can_capture_store return false for same
Reviewed-by: dlong, kvn, vlivanov

! src/hotspot/share/opto/memnode.cpp
+ test/hotspot/jtreg/compiler/c2/Test8202414.java

Changeset: 0bda2308eded
Author:    vromero
Date:      2019-05-01 12:41 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0bda2308eded

8222744: add support for generating method handles from a variable symbol
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

Changeset: ad45b3802d4e
Author:    kvn
Date:      2019-05-01 12:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ad45b3802d4e

8220623: [JVMCI] Update JVMCI to support JVMCI based Compiler compiled into shared library
Reviewed-by: dnsimon, never, stefank, rehn, neliasso, dholmes, kbarrett, coleenp

! make/autoconf/hotspot.m4
! src/hotspot/.mx.jvmci/suite.py
! src/hotspot/cpu/aarch64/jvmciCodeInstaller_aarch64.cpp
! src/hotspot/cpu/sparc/jvmciCodeInstaller_sparc.cpp
! src/hotspot/cpu/x86/jvmciCodeInstaller_x86.cpp
! src/hotspot/share/aot/aotCompiledMethod.cpp
! src/hotspot/share/aot/aotLoader.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/classfile/metadataOnStackMark.cpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/systemDictionary.hpp
! src/hotspot/share/classfile/vmSymbols.hpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/nmethod.hpp
! src/hotspot/share/compiler/abstractCompiler.hpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/compileTask.cpp
! src/hotspot/share/compiler/compilerDefinitions.cpp
! src/hotspot/share/compiler/disassembler.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp
! src/hotspot/share/gc/g1/g1RootProcessor.cpp
! src/hotspot/share/gc/g1/g1RootProcessor.hpp
! src/hotspot/share/gc/parallel/pcTasks.cpp
! src/hotspot/share/gc/parallel/pcTasks.hpp
! src/hotspot/share/gc/parallel/psMarkSweep.cpp
! src/hotspot/share/gc/parallel/psParallelCompact.cpp
! src/hotspot/share/gc/parallel/psScavenge.cpp
! src/hotspot/share/gc/parallel/psTasks.cpp
! src/hotspot/share/gc/parallel/psTasks.hpp
! src/hotspot/share/gc/serial/genMarkSweep.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.hpp
! src/hotspot/share/gc/shared/parallelCleaning.cpp
! src/hotspot/share/gc/shared/parallelCleaning.hpp
! src/hotspot/share/jfr/leakprofiler/chains/rootSetClosure.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp
! src/hotspot/share/jfr/leakprofiler/utilities/rootType.hpp
+ src/hotspot/share/jvmci/jniAccessMark.inline.hpp
+ src/hotspot/share/jvmci/jvmci.cpp
+ src/hotspot/share/jvmci/jvmci.hpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.hpp
! src/hotspot/share/jvmci/jvmciCompiler.cpp
! src/hotspot/share/jvmci/jvmciCompiler.hpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp
! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
! src/hotspot/share/jvmci/jvmciEnv.cpp
! src/hotspot/share/jvmci/jvmciEnv.hpp
+ src/hotspot/share/jvmci/jvmciExceptions.hpp
! src/hotspot/share/jvmci/jvmciJavaClasses.cpp
! src/hotspot/share/jvmci/jvmciJavaClasses.hpp
+ src/hotspot/share/jvmci/jvmciObject.hpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/jvmci/jvmciRuntime.hpp
! src/hotspot/share/jvmci/jvmci_globals.cpp
! src/hotspot/share/jvmci/jvmci_globals.hpp
+ src/hotspot/share/jvmci/metadataHandleBlock.cpp
+ src/hotspot/share/jvmci/metadataHandleBlock.hpp
- src/hotspot/share/jvmci/systemDictionary_jvmci.hpp
! src/hotspot/share/jvmci/vmStructs_jvmci.cpp
! src/hotspot/share/jvmci/vmSymbols_jvmci.hpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/methodData.cpp
! src/hotspot/share/oops/methodData.hpp
! src/hotspot/share/opto/chaitin.cpp
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jvmtiTagMap.cpp
! src/hotspot/share/prims/nativeLookup.hpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/deoptimization.cpp
! src/hotspot/share/runtime/frame.cpp
! src/hotspot/share/runtime/init.cpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/javaCalls.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/java.base/share/classes/module-info.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/Architecture.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodePosition.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/CodeCacheProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/InstalledCode.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/InvalidInstalledCodeException.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/InitTimer.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/NativeImageReinitialize.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotVMConfig.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotVMConfig.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/Cleaner.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/DirectHotSpotObjectConstantImpl.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HandleCleaner.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCodeCacheProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompilationRequest.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompiledNmethod.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPoolObject.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotInstalledCode.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJDKReflection.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIMetaAccessContext.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIReflection.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIUnsupportedOperationError.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMemoryAccessProviderImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaspaceConstantImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethod.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodData.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodHandleAccessProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotNmethod.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotObjectConstantImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaFieldImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaType.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotRuntimeStub.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSignature.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSpeculationEncoding.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSpeculationLog.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigAccess.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/IndirectHotSpotObjectConstantImpl.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/MetaspaceHandleObject.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/MetaspaceObject.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/MetaspaceWrapperObject.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/SharedLibraryJVMCIReflection.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/TranslatedException.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/VMEntryPoint.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/VMField.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/VMFlag.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/VMIntrinsicMethod.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/JavaTypeProfile.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaAccessProvider.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/PrimitiveConstant.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ResolvedJavaMethod.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/SpeculationLog.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.runtime/src/jdk/vm/ci/runtime/JVMCI.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/JVMCIServiceLocator.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/VMEntryPoint.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.sparc/src/jdk/vm/ci/sparc/SPARC.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLoweringProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java
! test/hotspot/jtreg/compiler/jvmci/SecurityRestrictionsTest.java
! test/hotspot/jtreg/compiler/jvmci/common/patches/jdk.internal.vm.ci/jdk/vm/ci/hotspot/CompilerToVMHelper.java
! test/hotspot/jtreg/compiler/jvmci/common/patches/jdk.internal.vm.ci/jdk/vm/ci/hotspot/PublicMetaspaceWrapperObject.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/ExecuteInstalledCodeTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetConstantPoolTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetResolvedJavaMethodTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetResolvedJavaTypeTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/InvalidateInstalledCodeTest.java
! test/hotspot/jtreg/compiler/jvmci/compilerToVM/JVM_RegisterJVMCINatives.java
! test/hotspot/jtreg/compiler/jvmci/errors/CodeInstallerTest.java
! test/hotspot/jtreg/compiler/jvmci/events/JvmciNotifyInstallEventTest.java
! test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventListener.java
+ test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHotSpotSpeculationLog.java
! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaField.java
! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaMethod.java
! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestSpeculationLog.java
! test/hotspot/jtreg/runtime/NMT/MallocSiteTypeChange.java

Changeset: a38438fcbbd2
Author:    bchristi
Date:      2019-05-01 13:07 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a38438fcbbd2

8221267: Document the jdk.net.URLClassPath.showIgnoredClassPathEntries system property
Reviewed-by: alanb, bpb, lancea

! src/java.base/share/classes/java/lang/ClassLoader.java

Changeset: 41339a468716
Author:    mseledtsov
Date:      2019-05-01 13:25 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/41339a468716

8222769: [TESTBUG] TestJFRNetworkEvents should not rely on hostname command
Summary: Using InetAddress.getLocalHost()
Reviewed-by: egahlin, lmesnik
Contributed-by: Severin Gehwolf <sgehwolf at redhat.com>

! test/hotspot/jtreg/containers/docker/JfrNetwork.java

Changeset: a43d6467317d
Author:    joehw
Date:      2019-05-01 14:35 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a43d6467317d

8220818: Validator does not find missing match for keyref error
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java
+ test/jaxp/javax/xml/jaxp/unittest/validation/ValidationTest.java
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818a.xsd
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818a_Invalid.xml
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818a_Valid.xml
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818a_Valid1.xml
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818b.xsd
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818b_Invalid.xml
+ test/jaxp/javax/xml/jaxp/unittest/validation/files/JDK8220818b_Valid.xml

Changeset: db976260a356
Author:    shade
Date:      2019-05-02 14:08 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/db976260a356

Merge

! .hgtags
! make/autoconf/hotspot.m4
! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/windows/os_windows.cpp
- src/hotspot/os_cpu/linux_x86/gc/z/zAddress_linux_x86.inline.hpp
! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/parallelCleaning.cpp
! src/hotspot/share/gc/shared/parallelCleaning.hpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahStrDedupQueue.cpp
- src/hotspot/share/jvmci/systemDictionary_jvmci.hpp
! src/hotspot/share/opto/ifnode.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/prims/jvmtiEnv.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! src/hotspot/share/runtime/tieredThresholdPolicy.hpp
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIMetaAccessContext.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/MetaspaceWrapperObject.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml
! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/TEST.groups
! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/TestSystemGC.java
! test/hotspot/jtreg/gc/arguments/TestAlignmentToUseLargePages.java
! test/hotspot/jtreg/gc/arguments/TestUseCompressedOopsErgo.java
! test/hotspot/jtreg/gc/class_unloading/TestClassUnloadingDisabled.java
! test/hotspot/jtreg/gc/ergonomics/TestDynamicNumberOfGCThreads.java
! test/hotspot/jtreg/gc/ergonomics/TestInitialGCThreadLogging.java
! test/hotspot/jtreg/gc/logging/TestGCId.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java
- test/jdk/java/lang/String/concat/StringConcatFactoryEmptyMethods.java
- test/jdk/java/nio/channels/SocketChannel/Stream.java
- test/jdk/jdk/nio/zipfs/MultiReleaseJarTest.java
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf4.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf4.txt


From zgu at redhat.com  Thu May  2 12:39:41 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 2 May 2019 08:39:41 -0400
Subject: RFR(M) 8222992: Shenandoah: Pre-evacuate all roots
In-Reply-To: <ddb7344b-44b5-6986-3320-523f406d84a8@redhat.com>
References: <2f6eeb40-ccf5-9dd8-7ccc-181e993dedf0@redhat.com>
 <a7d48993-42ae-313a-3899-94e630eba98e@redhat.com>
 <3cf86adc-6865-0b8a-23bd-c93884d6d456@redhat.com>
 <0f6499ee-7b2e-818d-96f8-2d8787b7a10f@redhat.com>
 <22cabc5f-5116-07da-30f7-854248e1b932@redhat.com>
 <7166dbbb-71f3-2673-3afd-bc67efe572bc@redhat.com>
 <49aab5a0-8f04-8f52-9b7e-c489cb3dbd93@redhat.com>
 <ddb7344b-44b5-6986-3320-523f406d84a8@redhat.com>
Message-ID: <413753d3-3ebf-8164-97ed-93c50ff9d478@redhat.com>



On 5/2/19 7:33 AM, Aleksey Shipilev wrote:
> On 5/1/19 4:22 PM, Zhengyu Gu wrote:
>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8222992/webrev.02/index.html
> 
> This looks okay to me.
> 
> Not a fan of the separate ShenandoahVerifier::verify_roots_no_forwarded, since we could "just" fold
> stronger (non-forwarded) root verification to the generic verification code (e.g. in
> ShenandoahVerifierReachableTask). 

Me neither. The early version I folded verify_roots_no_forwarded to use 
generic verification code, but that version always verifies marking, 
which could be long cycle. I intent to verify roots quite often in 
concurrent class unloading/concurrent roots evacuation work, and prefer 
shorter verification cycles.

Also, I also want to be able to verify subset of roots 
(https://bugs.openjdk.java.net/browse/JDK-8223215), which could 
complicate generic verification code quite a bit.

That, however, might end up with some failures in Traversal and
> such. We can do that as follow-up.
> 

Yes, we could do a follow-up RFE if needed.

Thanks,

-Zhengyu

From zgu at redhat.com  Thu May  2 18:02:17 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 2 May 2019 14:02:17 -0400
Subject: RFR(T) 8223258: Shenandoah: SRP::process_all_roots_slow processes
 JvmtiExport weak oops twice
Message-ID: <0b2066ab-a94c-f3c6-c001-1c3cc1896960@redhat.com>

WeakProcessor processes JvmtiExport weak oops.


Bug: https://bugs.openjdk.java.net/browse/JDK-8223258
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223258/webrev.00/

Test:
   hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)

Thanks,

-Zhengyu

From rkennke at redhat.com  Thu May  2 18:32:20 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 2 May 2019 20:32:20 +0200
Subject: RFR(T) 8223258: Shenandoah: SRP::process_all_roots_slow processes
 JvmtiExport weak oops twice
In-Reply-To: <0b2066ab-a94c-f3c6-c001-1c3cc1896960@redhat.com>
References: <0b2066ab-a94c-f3c6-c001-1c3cc1896960@redhat.com>
Message-ID: <de099eb2-f339-a78d-f74f-f6b16f4c2680@redhat.com>

Ok! Thanks!

Roman


> WeakProcessor processes JvmtiExport weak oops.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223258
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223258/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu


From kdobson at redhat.com  Thu May  2 19:31:45 2019
From: kdobson at redhat.com (Ken Dobson)
Date: Thu, 2 May 2019 15:31:45 -0400
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
Message-ID: <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>

Thank you for your review Aleksey, I've removed the trailing whitespaces
here.

http://cr.openjdk.java.net/~kdobson/53476/webrev

What are my next steps, should I send an exported patch to a committer?

Thanks,

Ken Dobson

On Wed, May 1, 2019 at 8:30 AM Aleksey Shipilev <shade at redhat.com> wrote:

> On 3/29/19 11:08 PM, Roman Kennke wrote:
> >> On Tue, Mar 26, 2019 at 5:16 PM Roman Kennke <rkennke at redhat.com
> <mailto:rkennke at redhat.com>> wrote:
> >>
> >>      > Please review this patch that adds support for two new JFR events
> >>      > ShenandoahHeapRegionStateChange and
> ShenandoahHeapRegionInformation.
> >>      >
> >>      > Bug: https://bugs.openjdk.java.net/browse/JDK-8221507
> >>      > Webrev: http://cr.openjdk.java.net/~kdobson/53476/webrev/
> >>      >
> >>      > The events appears to result in ~2% overhead though there is some
> >>      > uncertainty as to whether some of that is noise.
> >>      >
> >>      > Thanks,
> >>      >
> >>      > Ken Dobson
> >>
> >>     Very nice!
> >>
> >>     The overhead is only present with JFR active, I assume?
> >>
> >> We've noticed that there is some overhead when JFR is included in the
> jdk but not running. This
> >> may be because the event object has to be instantiated at each
> transition whether it's enabled or
> >> not. You can see the exact numbers in the email I previously sent you.
> >
> > Hmm, ok. This only ever happens when regions change state, right? I
> doubt that this is frequent
> > enough to make an actual difference. I suspect that what you see is
> noise. I'm good. Let's also hear
> > Aleksey's opinion though.
>
> It looks fine to me. I ran a few tests of my own, and overheads clearly
> visible with JFR turned on,
> but are not bad. The overheads with JFR turned off are slim to none.
>
> Ken, you might want to clean up trailing whitespaces here:
>
> +void ShenandoahJFRSupport::register_jfr_type_serializers() {
> +  JfrSerializer::register_serializer(TYPE_SHENANDOAHHEAPREGIONSTATE,
> +                                     false,
> +                                     true,
> +                                     new
> ShenandoahHeapRegionStateConstant());
> +}
> +#endif
>
>
> -Aleksey
>
>

From shade at redhat.com  Fri May  3 10:07:22 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 3 May 2019 12:07:22 +0200
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
Message-ID: <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>

On 5/2/19 9:31 PM, Ken Dobson wrote:
> Thank you for your review Aleksey, I've removed the trailing whitespaces here.
> 
> http://cr.openjdk.java.net/~kdobson/53476/webrev
> 
> What are my next steps, should I send an exported patch to a committer?

The code touches shared JFR parts. Have you got the acknowledgment from JFR people? You have to list
who had reviewed the patch. If everything is in order there, one of us (Shenandoah devs) can push.

-Aleksey


From rkennke at redhat.com  Fri May  3 14:46:15 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 3 May 2019 16:46:15 +0200
Subject: RFR: Implement ShenandoahBarrierSetC2::step_over_gc_barrier() to fix
 lock elimination bug with Shenandoah
Message-ID: <92a480c9-3dc1-dcd8-6178-8194989d3065@redhat.com>

This fixes the lock elimination bug that we have seen and fixed already
in sh/jdk8 and >11. We also did the fix in sh/jd11 but the bug persists
because step_over_gc_barrier() remained unimplemented. (Duh!)

http://cr.openjdk.java.net/~rkennke/fixlockelimination-shjdk11/webrev.00/

Testing: hotspot_gc_shenandoah, the whole lucene testsuite (that exposed
the failure)


Roman


From shade at redhat.com  Fri May  3 14:56:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 3 May 2019 16:56:45 +0200
Subject: RFR: Implement ShenandoahBarrierSetC2::step_over_gc_barrier() to
 fix lock elimination bug with Shenandoah
In-Reply-To: <92a480c9-3dc1-dcd8-6178-8194989d3065@redhat.com>
References: <92a480c9-3dc1-dcd8-6178-8194989d3065@redhat.com>
Message-ID: <4f42a7fe-3a4b-940c-d09b-b1cc1879de09@redhat.com>

On 5/3/19 4:46 PM, Roman Kennke wrote:
> This fixes the lock elimination bug that we have seen and fixed already
> in sh/jdk8 and >11. We also did the fix in sh/jd11 but the bug persists
> because step_over_gc_barrier() remained unimplemented. (Duh!)
> 
> http://cr.openjdk.java.net/~rkennke/fixlockelimination-shjdk11/webrev.00/

(facepalms)

Looks good!

-Aleksey


From rkennke at redhat.com  Fri May  3 15:56:13 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Fri, 03 May 2019 15:56:13 +0000
Subject: hg: shenandoah/jdk11: Implement
 ShenandoahBarrierSetC2::step_over_gc_barrier() to fix lock
 elimination bug with Shenandoah
Message-ID: <201905031556.x43FuEUm019969@aojmv0008.oracle.com>

Changeset: f5c9d4ff794a
Author:    rkennke
Date:      2019-05-03 16:42 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f5c9d4ff794a

Implement ShenandoahBarrierSetC2::step_over_gc_barrier() to fix lock elimination bug with Shenandoah

! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp


From rkennke at redhat.com  Mon May  6 20:58:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 6 May 2019 22:58:08 +0200
Subject: RFR (jdk11): Backport JDK-8217016 and JDK-8217874
Message-ID: <500532e1-7695-2500-e9f6-e5ae9f9dd5ec@redhat.com>

This backports two long-standing changes from jdk12 -> sh/jdk11.

This is by far not a straight backport. It also ports over a bunch of 
machinery to generate cmpxchg and xchg. The change is fairly large, but 
on the plus side it *reverts* a bunch of shared-code changes vs. 
upstream. Overall, the involved Shenandoah code is now much closer to jdk12.

Backported changes:
- JDK-8217016: Shenandoah: Streamline generation of CAS barriers
https://bugs.openjdk.java.net/browse/JDK-8217016
- JDK-8217874: Shenandoah: AArch64: Clobbered register in 
ShenandoahBarrierSetAssembler::cmpxchg_oop()
https://bugs.openjdk.java.net/browse/JDK-8217874


Webrev:
http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-06/webrev.00/

Testing: hotspot_gc_shenandoah (x86/aarch64)

Good to push?

Roman

From shade at redhat.com  Tue May  7 08:34:39 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 10:34:39 +0200
Subject: RFR (jdk11): Backport JDK-8217016 and JDK-8217874
In-Reply-To: <500532e1-7695-2500-e9f6-e5ae9f9dd5ec@redhat.com>
References: <500532e1-7695-2500-e9f6-e5ae9f9dd5ec@redhat.com>
Message-ID: <f713eb83-cc76-60d8-9d9b-3c386765fadb@redhat.com>

On 5/6/19 10:58 PM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-06/webrev.00/

*) c1_LIRAssembler_aarch64.cpp: stray assert

1585     }    assert(op->tmp1()->is_valid(), "must be");

Otherwise looks fine.

-Aleksey


From rkennke at redhat.com  Tue May  7 09:27:16 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 11:27:16 +0200
Subject: RFR (jdk11): Backport JDK-8217016 and JDK-8217874
In-Reply-To: <f713eb83-cc76-60d8-9d9b-3c386765fadb@redhat.com>
References: <500532e1-7695-2500-e9f6-e5ae9f9dd5ec@redhat.com>
 <f713eb83-cc76-60d8-9d9b-3c386765fadb@redhat.com>
Message-ID: <0ed46666-3a5d-4483-7bee-faa0a06aff24@redhat.com>

>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-06/webrev.00/
> 
> *) c1_LIRAssembler_aarch64.cpp: stray assert
> 
> 1585     }    assert(op->tmp1()->is_valid(), "must be");
> 
> Otherwise looks fine.
> 

Oops. Updated webrev:
http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-06/webrev.01/

Roland, can you eyeball the changes?

Thanks,
Roman


From shade at redhat.com  Tue May  7 10:22:08 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 12:22:08 +0200
Subject: RFR (XS) 8223448: Shenandoah disabled barriers blocks omit LRB
Message-ID: <f4f162d7-7875-a0c0-643e-dc9cb52cb082@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223448

This looks like a trivial omission, but it breaks x86_32 (when specifically enabled), which does not
have all the barriers implemented yet.

Fix:

diff -r 3a75a903a488 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:20:26 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:25:02 2019 +0200
@@ -45,6 +45,7 @@
   FLAG_SET_DEFAULT(ShenandoahGCHeuristics, "passive");

   FLAG_SET_DEFAULT(ShenandoahSATBBarrier, false);
+  FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier, false);
   FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier, false);
   FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
   FLAG_SET_DEFAULT(ShenandoahCASBarrier, false);
@@ -106,6 +107,7 @@
   // C2 barrier verification is only reliable when all default barriers are enabled
   if (ShenandoahVerifyOptoBarriers &&
           (!FLAG_IS_DEFAULT(ShenandoahSATBBarrier) ||
+           !FLAG_IS_DEFAULT(ShenandoahLoadRefBarrier) ||
            !FLAG_IS_DEFAULT(ShenandoahKeepAliveBarrier) ||
            !FLAG_IS_DEFAULT(ShenandoahStoreValEnqueueBarrier) ||
            !FLAG_IS_DEFAULT(ShenandoahCASBarrier) ||

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May  7 10:23:36 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 12:23:36 +0200
Subject: RFR (XS) 8223448: Shenandoah disabled barriers blocks omit LRB
In-Reply-To: <f4f162d7-7875-a0c0-643e-dc9cb52cb082@redhat.com>
References: <f4f162d7-7875-a0c0-643e-dc9cb52cb082@redhat.com>
Message-ID: <6dc6e32d-bb06-ea57-c3f5-230c1a033f2d@redhat.com>

Looks good.

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223448
> 
> This looks like a trivial omission, but it breaks x86_32 (when specifically enabled), which does not
> have all the barriers implemented yet.
> 
> Fix:
> 
> diff -r 3a75a903a488 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:20:26 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:25:02 2019 +0200
> @@ -45,6 +45,7 @@
>     FLAG_SET_DEFAULT(ShenandoahGCHeuristics, "passive");
> 
>     FLAG_SET_DEFAULT(ShenandoahSATBBarrier, false);
> +  FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier, false);
>     FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier, false);
>     FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
>     FLAG_SET_DEFAULT(ShenandoahCASBarrier, false);
> @@ -106,6 +107,7 @@
>     // C2 barrier verification is only reliable when all default barriers are enabled
>     if (ShenandoahVerifyOptoBarriers &&
>             (!FLAG_IS_DEFAULT(ShenandoahSATBBarrier) ||
> +           !FLAG_IS_DEFAULT(ShenandoahLoadRefBarrier) ||
>              !FLAG_IS_DEFAULT(ShenandoahKeepAliveBarrier) ||
>              !FLAG_IS_DEFAULT(ShenandoahStoreValEnqueueBarrier) ||
>              !FLAG_IS_DEFAULT(ShenandoahCASBarrier) ||
> 
> Testing: hotspot_gc_shenandoah
> 

From shade at redhat.com  Tue May  7 10:26:13 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 12:26:13 +0200
Subject: RFR (XS) 8223450: Disable Shenandoah C2 barriers verification for
 x86_32
Message-ID: <d688f2a3-d8c9-fc4a-eff9-12f87173352c@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223450

Shenandoah C2 barrier verification is disabled when unusual barrier configuration is requested.
However, that only takes care of options provided from the command line (as our tests assert). For
the configuration that disables barriers implicitly, e.g. x86_32, this is not enough, and tests fail
with false negatives. We need to disable C2 barriers verification explicitly there.

Fix:

diff -r 1c3292907e4b src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Tue May 07 12:19:28 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Tue May 07 12:23:15 2019 +0200
@@ -48,10 +48,12 @@
   FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier,         false);
   FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier,       false);
   FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
   FLAG_SET_DEFAULT(ShenandoahCASBarrier,             false);
   FLAG_SET_DEFAULT(ShenandoahCloneBarrier,           false);
+
+  FLAG_SET_DEFAULT(ShenandoahVerifyOptoBarriers,     false);
 #endif

 #ifdef _LP64
   // The optimized ObjArrayChunkedTask takes some bits away from the full 64 addressable
   // bits, fail if we ever attempt to address more than we can. Only valid on 64bit.

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



From shade at redhat.com  Tue May  7 10:32:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 12:32:20 +0200
Subject: RFR (XS) 8223449: Unprotected UseCompressedOops block in
 gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
Message-ID: <a571a1aa-b61d-14bb-b3af-889a0f3f1823@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223449

x86_32 fails to build because of this (when specifically enabled). This is a simple overlook during
recent refactoring of CAS barriers.

Fix;

diff -r edafae6da842 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
--- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp  Tue May 07 12:23:13 2019 +0200
+++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp  Tue May 07 12:28:00 2019 +0200
@@ -44,16 +44,18 @@
   // Apply storeval barrier to newval.
   ShenandoahBarrierSet::assembler()->storeval_barrier(masm->masm(), newval, tmp1);

+#ifdef _LP64
   if (UseCompressedOops) {
     __ encode_heap_oop(cmpval);
     __ mov(rscratch1, newval);
     __ encode_heap_oop(rscratch1);
     newval = rscratch1;
   }
+#endif

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Tue May  7 10:34:51 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 12:34:51 +0200
Subject: RFR (XS) 8223450: Disable Shenandoah C2 barriers verification for
 x86_32
In-Reply-To: <d688f2a3-d8c9-fc4a-eff9-12f87173352c@redhat.com>
References: <d688f2a3-d8c9-fc4a-eff9-12f87173352c@redhat.com>
Message-ID: <c0a51e62-8763-8b9e-1eac-ff2db5278849@redhat.com>

Looks good, thanks!

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223450
> 
> Shenandoah C2 barrier verification is disabled when unusual barrier configuration is requested.
> However, that only takes care of options provided from the command line (as our tests assert). For
> the configuration that disables barriers implicitly, e.g. x86_32, this is not enough, and tests fail
> with false negatives. We need to disable C2 barriers verification explicitly there.
> 
> Fix:
> 
> diff -r 1c3292907e4b src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Tue May 07 12:19:28 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp   Tue May 07 12:23:15 2019 +0200
> @@ -48,10 +48,12 @@
>     FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier,         false);
>     FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier,       false);
>     FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
>     FLAG_SET_DEFAULT(ShenandoahCASBarrier,             false);
>     FLAG_SET_DEFAULT(ShenandoahCloneBarrier,           false);
> +
> +  FLAG_SET_DEFAULT(ShenandoahVerifyOptoBarriers,     false);
>   #endif
> 
>   #ifdef _LP64
>     // The optimized ObjArrayChunkedTask takes some bits away from the full 64 addressable
>     // bits, fail if we ever attempt to address more than we can. Only valid on 64bit.
> 
> Testing: hotspot_gc_shenandoah
> 

From rkennke at redhat.com  Tue May  7 10:35:14 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 12:35:14 +0200
Subject: RFR (XS) 8223449: Unprotected UseCompressedOops block in
 gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
In-Reply-To: <a571a1aa-b61d-14bb-b3af-889a0f3f1823@redhat.com>
References: <a571a1aa-b61d-14bb-b3af-889a0f3f1823@redhat.com>
Message-ID: <2de42f45-dc99-a66c-6fd7-981f6c40229d@redhat.com>

Yep, go!

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223449
> 
> x86_32 fails to build because of this (when specifically enabled). This is a simple overlook during
> recent refactoring of CAS barriers.
> 
> Fix;
> 
> diff -r edafae6da842 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
> --- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp  Tue May 07 12:23:13 2019 +0200
> +++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp  Tue May 07 12:28:00 2019 +0200
> @@ -44,16 +44,18 @@
>     // Apply storeval barrier to newval.
>     ShenandoahBarrierSet::assembler()->storeval_barrier(masm->masm(), newval, tmp1);
> 
> +#ifdef _LP64
>     if (UseCompressedOops) {
>       __ encode_heap_oop(cmpval);
>       __ mov(rscratch1, newval);
>       __ encode_heap_oop(rscratch1);
>       newval = rscratch1;
>     }
> +#endif
> 
> Testing: hotspot_gc_shenandoah
> 

From shade at redhat.com  Tue May  7 10:44:14 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 12:44:14 +0200
Subject: RFR (S) 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
Message-ID: <e850e5d4-4bfb-4089-cd94-0ea8615693f0@redhat.com>

Test bug:
  https://bugs.openjdk.java.net/browse/JDK-8223447

I find that test failing with OOME almost reliably on x86_32. There are several things that are done
to stabilize the test: increased heap size, made sure the termination is time-based rather than
overwrite-iterations-based (which unties test configuration from heap size), pre-sized the hashmap,
added GC logging to simplify future investigations.

Webrev:
  http://cr.openjdk.java.net/~shade/8223447/webrev.01/

Testing: hotspot_gc_shenandoah, eyeballing test logs to see that dedup happened in most modes

-- 
Thanks,
-Aleksey



From shade at redhat.com  Tue May  7 10:48:41 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 12:48:41 +0200
Subject: RFR (S) 8223446: Shenandoah breaks alignment with some
 HumongousThreshold values
Message-ID: <6d858dad-d65e-0487-5cc8-94ba150d7947@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223446

HumongousThreshold is not aligned to MinObjAlignment. Since HumongousThreshold drives the
MaxTLABSize, issuing such max-sized TLAB would leave allocation top unaligned. This readily
manifests on x86_32. x86_64 is more or less safe as default alignment matches the single HeapWord.

Fix:
  http://cr.openjdk.java.net/~shade/8223446/webrev.01/

This aligns all affected values, adds asserts, makes some computations use multiplication rather
than division to avoid awkward precision issues, and extends the test to capture more problems.

Testing: hotspot_gc_shenandoah (x86_32, x86_64)

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Tue May  7 12:24:17 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 14:24:17 +0200
Subject: RFR (S) 8223446: Shenandoah breaks alignment with some
 HumongousThreshold values
In-Reply-To: <6d858dad-d65e-0487-5cc8-94ba150d7947@redhat.com>
References: <6d858dad-d65e-0487-5cc8-94ba150d7947@redhat.com>
Message-ID: <d95b8fbe-1def-e501-2930-a03d052f196f@redhat.com>

Looks good, thank you!

Roman


> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223446
> 
> HumongousThreshold is not aligned to MinObjAlignment. Since HumongousThreshold drives the
> MaxTLABSize, issuing such max-sized TLAB would leave allocation top unaligned. This readily
> manifests on x86_32. x86_64 is more or less safe as default alignment matches the single HeapWord.
> 
> Fix:
>    http://cr.openjdk.java.net/~shade/8223446/webrev.01/
> 
> This aligns all affected values, adds asserts, makes some computations use multiplication rather
> than division to avoid awkward precision issues, and extends the test to capture more problems.
> 
> Testing: hotspot_gc_shenandoah (x86_32, x86_64)
> 

From rwestrel at redhat.com  Tue May  7 13:25:38 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Tue, 07 May 2019 15:25:38 +0200
Subject: RFR (jdk11): Backport JDK-8217016 and JDK-8217874
In-Reply-To: <0ed46666-3a5d-4483-7bee-faa0a06aff24@redhat.com>
References: <500532e1-7695-2500-e9f6-e5ae9f9dd5ec@redhat.com>
 <f713eb83-cc76-60d8-9d9b-3c386765fadb@redhat.com>
 <0ed46666-3a5d-4483-7bee-faa0a06aff24@redhat.com>
Message-ID: <87o94emm5p.fsf@redhat.com>


> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-06/webrev.01/

Looks ok to me.

Roland.

From aph at redhat.com  Tue May  7 13:36:11 2019
From: aph at redhat.com (Andrew Haley)
Date: Tue, 7 May 2019 14:36:11 +0100
Subject: Version "8-aarch64" is live ...
Message-ID: <07843c9a-b9dd-8f5c-2e07-a309a7b8a4a9@redhat.com>

... for all bugs related to AArch64-port/JDK8.


i.e. hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

From rkennke at redhat.com  Tue May  7 13:44:09 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Tue, 07 May 2019 13:44:09 +0000
Subject: hg: shenandoah/jdk11: 2 new changesets
Message-ID: <201905071344.x47DiAL8025756@aojmv0008.oracle.com>

Changeset: e3554f3205c5
Author:    rkennke
Date:      2019-05-06 22:22 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e3554f3205c5

[backport] 8217016: Shenandoah: Streamline generation of CAS barriers
Reviewed-by: roland

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
+ src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp
! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
+ src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.hpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

Changeset: 7163b7229ecb
Author:    rkennke
Date:      2019-05-07 11:24 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7163b7229ecb

[backport] 8217874: Shenandoah: Clobbered register in ShenandoahBarrierSetAssembler::cmpxchg_oop()
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp


From shade at redhat.com  Tue May  7 14:12:17 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 16:12:17 +0200
Subject: RFR (XS) 8223448: Shenandoah disabled barriers blocks omit LRB
In-Reply-To: <6dc6e32d-bb06-ea57-c3f5-230c1a033f2d@redhat.com>
References: <f4f162d7-7875-a0c0-643e-dc9cb52cb082@redhat.com>
 <6dc6e32d-bb06-ea57-c3f5-230c1a033f2d@redhat.com>
Message-ID: <ad8f99b0-0024-713d-5ac9-49c4061e9de2@redhat.com>

Thanks, pushed under triviality rules.

-Aleksey

On 5/7/19 12:23 PM, Roman Kennke wrote:
> Looks good.
> 
> Roman
> 
> 
>> Bug:
>> ?? https://bugs.openjdk.java.net/browse/JDK-8223448
>>
>> This looks like a trivial omission, but it breaks x86_32 (when specifically enabled), which does not
>> have all the barriers implemented yet.
>>
>> Fix:
>>
>> diff -r 3a75a903a488 src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
>> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:20:26 2019 +0200
>> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Mon May 06 19:25:02 2019 +0200
>> @@ -45,6 +45,7 @@
>> ??? FLAG_SET_DEFAULT(ShenandoahGCHeuristics, "passive");
>>
>> ??? FLAG_SET_DEFAULT(ShenandoahSATBBarrier, false);
>> +? FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier, false);
>> ??? FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier, false);
>> ??? FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
>> ??? FLAG_SET_DEFAULT(ShenandoahCASBarrier, false);
>> @@ -106,6 +107,7 @@
>> ??? // C2 barrier verification is only reliable when all default barriers are enabled
>> ??? if (ShenandoahVerifyOptoBarriers &&
>> ??????????? (!FLAG_IS_DEFAULT(ShenandoahSATBBarrier) ||
>> +?????????? !FLAG_IS_DEFAULT(ShenandoahLoadRefBarrier) ||
>> ???????????? !FLAG_IS_DEFAULT(ShenandoahKeepAliveBarrier) ||
>> ???????????? !FLAG_IS_DEFAULT(ShenandoahStoreValEnqueueBarrier) ||
>> ???????????? !FLAG_IS_DEFAULT(ShenandoahCASBarrier) ||
>>
>> Testing: hotspot_gc_shenandoah
>>


-- 
Thanks,
-Aleksey

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander


From shade at redhat.com  Tue May  7 14:12:36 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 16:12:36 +0200
Subject: RFR (XS) 8223449: Unprotected UseCompressedOops block in
 gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
In-Reply-To: <2de42f45-dc99-a66c-6fd7-981f6c40229d@redhat.com>
References: <a571a1aa-b61d-14bb-b3af-889a0f3f1823@redhat.com>
 <2de42f45-dc99-a66c-6fd7-981f6c40229d@redhat.com>
Message-ID: <eaee4012-d17e-d520-11d2-5c968f099ed2@redhat.com>

Thanks, pushed under triviality rules.

-Aleksey

On 5/7/19 12:35 PM, Roman Kennke wrote:
> Yep, go!
> 
> Roman
> 
> 
>> Bug:
>> ?? https://bugs.openjdk.java.net/browse/JDK-8223449
>>
>> x86_32 fails to build because of this (when specifically enabled). This is a simple overlook during
>> recent refactoring of CAS barriers.
>>
>> Fix;
>>
>> diff -r edafae6da842 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
>> --- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp? Tue May 07 12:23:13 2019
>> +0200
>> +++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp? Tue May 07 12:28:00 2019
>> +0200
>> @@ -44,16 +44,18 @@
>> ??? // Apply storeval barrier to newval.
>> ??? ShenandoahBarrierSet::assembler()->storeval_barrier(masm->masm(), newval, tmp1);
>>
>> +#ifdef _LP64
>> ??? if (UseCompressedOops) {
>> ????? __ encode_heap_oop(cmpval);
>> ????? __ mov(rscratch1, newval);
>> ????? __ encode_heap_oop(rscratch1);
>> ????? newval = rscratch1;
>> ??? }
>> +#endif
>>
>> Testing: hotspot_gc_shenandoah
>>


-- 
Thanks,
-Aleksey

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander


From shade at redhat.com  Tue May  7 14:12:59 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 16:12:59 +0200
Subject: RFR (XS) 8223450: Disable Shenandoah C2 barriers verification for
 x86_32
In-Reply-To: <c0a51e62-8763-8b9e-1eac-ff2db5278849@redhat.com>
References: <d688f2a3-d8c9-fc4a-eff9-12f87173352c@redhat.com>
 <c0a51e62-8763-8b9e-1eac-ff2db5278849@redhat.com>
Message-ID: <4b836e5b-d5f2-4f64-8f5d-57d75fdd6eb4@redhat.com>

Thanks, pushed under triviality rules.

-Aleksey

On 5/7/19 12:34 PM, Roman Kennke wrote:
> Looks good, thanks!
> 
> Roman
> 
> 
>> Bug:
>> ?? https://bugs.openjdk.java.net/browse/JDK-8223450
>>
>> Shenandoah C2 barrier verification is disabled when unusual barrier configuration is requested.
>> However, that only takes care of options provided from the command line (as our tests assert). For
>> the configuration that disables barriers implicitly, e.g. x86_32, this is not enough, and tests fail
>> with false negatives. We need to disable C2 barriers verification explicitly there.
>>
>> Fix:
>>
>> diff -r 1c3292907e4b src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
>> --- a/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp?? Tue May 07 12:19:28 2019 +0200
>> +++ b/src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp?? Tue May 07 12:23:15 2019 +0200
>> @@ -48,10 +48,12 @@
>> ??? FLAG_SET_DEFAULT(ShenandoahLoadRefBarrier,???????? false);
>> ??? FLAG_SET_DEFAULT(ShenandoahKeepAliveBarrier,?????? false);
>> ??? FLAG_SET_DEFAULT(ShenandoahStoreValEnqueueBarrier, false);
>> ??? FLAG_SET_DEFAULT(ShenandoahCASBarrier,???????????? false);
>> ??? FLAG_SET_DEFAULT(ShenandoahCloneBarrier,?????????? false);
>> +
>> +? FLAG_SET_DEFAULT(ShenandoahVerifyOptoBarriers,???? false);
>> ? #endif
>>
>> ? #ifdef _LP64
>> ??? // The optimized ObjArrayChunkedTask takes some bits away from the full 64 addressable
>> ??? // bits, fail if we ever attempt to address more than we can. Only valid on 64bit.
>>
>> Testing: hotspot_gc_shenandoah
>>


-- 
Thanks,
-Aleksey

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander


From shade at redhat.com  Tue May  7 15:56:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 17:56:20 +0200
Subject: Version "8-aarch64" is live ...
In-Reply-To: <07843c9a-b9dd-8f5c-2e07-a309a7b8a4a9@redhat.com>
References: <07843c9a-b9dd-8f5c-2e07-a309a7b8a4a9@redhat.com>
Message-ID: <c818cb1e-0dd8-048e-a8f0-ac08f2cc1cfe@redhat.com>

On 5/7/19 3:36 PM, Andrew Haley wrote:
> ... for all bugs related to AArch64-port/JDK8.
> 
> i.e. hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/

Thank you. Backports monitor is aware of that affected-version now. For example, look for "AArch64
Backports:" in "redhat-openjdk" [1] report. There are only three issues there right now.

-Aleksey

[1] https://builds.shipilev.net/backports-monitor/label-actionable-redhat-openjdk.txt




From rkennke at redhat.com  Tue May  7 15:59:40 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 17:59:40 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
Message-ID: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>

Until now, Shenandoah had the 'limitation' that it required an extra 
word per object to keep the forwarding pointer. It either points to 
itself (most of the time) or to the forwarded object when evacuated. The 
forwarding pointer is updated atomically using CAS. This is the heart of 
Shenandoah's evacuation protocol.

With LRB, we have the opportunity to eliminate that extra word. The 
insight is that we really don't need the old copy of an object anymore 
and we can store the forwarding pointer in the mark word of it. We would 
distinguish a valid mark word from a forwarding pointer by checking the 
lowest 2 bits: if they are 0b11 then it's forwarded, otherwise it's not. 
0b11 is not a valid combination of bits otherwise. This is the same 
protocol that is used by other GCs.

The evacuation protocol changes slightly to CAS into the mark word 
instead of the extra word. But the basic mechanics are the same.

The extra decoding does not (significantly) affect performance because 
it's only done in the mid/slow-path of the LRB. (As opposed to earlier 
attempts at it where it'd have to be in the read-barrier.)

I've run SPECjvm2008. Performance benefits vary between 0 and ~+10%. One 
exception is one of the scimarks which is negatively impacted. The 
reason appears to be that this benchmark is very heavily contended on 
synchronizer objects, and the tighter spacing negatively impacts it when 
running with many threads. I don't consider this a true regression.

SPECjbb2015 shows +12% improvement in throughput and +9% improvement in 
latency.

I propose to push it to shenandoah/jdk and bake it there a little before 
upstreaming it into jdk/jdk.

Webrev:
http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.00/

Testing: hotspot_gc_shenandoah (x86,aarch64) specjvm, specjbb, most of 
them many many times

Opinions?

Thanks,
Roman

From shade at redhat.com  Tue May  7 16:20:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 7 May 2019 18:20:55 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
Message-ID: <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>

On 5/7/19 5:59 PM, Roman Kennke wrote:
> I propose to push it to shenandoah/jdk and bake it there a little before upstreaming it into jdk/jdk.

This plan is fine with me; but let's review it first.

> Webrev:
> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.00/

Brief look:

*) In shenandoahBarrierSetAssembler_aarch64.cpp there is comment about temp registers in
SBSA::resolve_forward_pointer_not_null. Yet, new code does clobber them? Maybe the comment is
obsolete now?

*) Maybe we should fork introducing new tmp to CAS? That would make the patch easier to backport, I
think.

*) Is there a compelling reason why we drop the midpath in SBSA::load_reference_barrier_not_null and
call into slowpath? I.e. is it required, or is it opportunistic optimization? Maybe it just works
around the complexity of parsing out the fwdptr?

*) In shenandoahAsserts, we deliberately not going via resolves, instead doing
SBP::get_raw_unchecked. Just replacing them with SBS::resolve_forwarded_not_null does not feel
sufficient. Instead, asserts/verifier needs to be adjusted to decode the fwdptrs properly (if present).

*) It seems in SH::evacuate_object, this needs to call some utility method?

 236   markOop old_mark = p->mark_raw();
 237   if (old_mark->is_marked()) {
 238     return (oop) old_mark->clear_lock_bits();
 239   }

...and here?

 281   markOop new_mark = markOopDesc::encode_pointer_as_mark(copy_val);
 282   markOop prev_mark = p->cas_set_mark_raw(new_mark, old_mark);
 283   if (prev_mark == old_mark) {

I actually think that we can keep ShenandoahBrooksPointer and put all that util code there. It would
still be doing its job: abstracting away the forwarding data handling.

*) In ShenandoahMarkCompact, do these need to be public?

  76 public:
  77   void preserve_mark(oop obj);
  78   void restore_marks();
  79   void adjust_marks();

-Aleksey


From rkennke at redhat.com  Tue May  7 18:50:45 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 20:50:45 +0200
Subject: RFR (S) 8223447: Stabilize gc/shenandoah/TestStringDedupStress
 test
In-Reply-To: <e850e5d4-4bfb-4089-cd94-0ea8615693f0@redhat.com>
References: <e850e5d4-4bfb-4089-cd94-0ea8615693f0@redhat.com>
Message-ID: <66ad845a-b181-6f0a-4c27-3b0606759a6b@redhat.com>

It looks good to me.

Roman

> Test bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223447
> 
> I find that test failing with OOME almost reliably on x86_32. There are several things that are done
> to stabilize the test: increased heap size, made sure the termination is time-based rather than
> overwrite-iterations-based (which unties test configuration from heap size), pre-sized the hashmap,
> added GC logging to simplify future investigations.
> 
> Webrev:
>    http://cr.openjdk.java.net/~shade/8223447/webrev.01/
> 
> Testing: hotspot_gc_shenandoah, eyeballing test logs to see that dedup happened in most modes
> 

From rkennke at redhat.com  Tue May  7 19:32:05 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 21:32:05 +0200
Subject: RFR: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Message-ID: <53a4cde2-a3d5-dc48-74c8-ae9737b1a966@redhat.com>

In preparation of elimination of the brooks pointer slot, I'd like to
rename ShenandoahBrooksPointer to ShenandoahForwarding. This name seems
more appropriate then. I also renamed some of the accessors to make more
sense in the new context.

http://cr.openjdk.java.net/~rkennke/renamebrooksptr/webrev.00/

Testing: hotspot_gc_shenandoah (x86,aarch64)

Ok?

Roman


From rkennke at redhat.com  Tue May  7 19:49:19 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 7 May 2019 21:49:19 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
Message-ID: <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>

Hi Aleksey,

>> I propose to push it to shenandoah/jdk and bake it there a little before upstreaming it into jdk/jdk.
> 
> This plan is fine with me; but let's review it first.
> 
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.00/
> 
> Brief look:
> 
> *) In shenandoahBarrierSetAssembler_aarch64.cpp there is comment about temp registers in
> SBSA::resolve_forward_pointer_not_null. Yet, new code does clobber them? Maybe the comment is
> obsolete now?

I changed the comment to allow using explicitely passed in tmp 
registers. :-)

> *) Maybe we should fork introducing new tmp to CAS? That would make the patch easier to backport, I
> think.

Not sure. The change would make the register allocators free one more 
register but then not use it. I left it out of this iteration for now.

> *) Is there a compelling reason why we drop the midpath in SBSA::load_reference_barrier_not_null and
> call into slowpath? I.e. is it required, or is it opportunistic optimization? Maybe it just works
> around the complexity of parsing out the fwdptr?

It works around the complexity of getting an extra register for 
decoding. This is much easier in the stub.

> *) In shenandoahAsserts, we deliberately not going via resolves, instead doing
> SBP::get_raw_unchecked. Just replacing them with SBS::resolve_forwarded_not_null does not feel
> sufficient. Instead, asserts/verifier needs to be adjusted to decode the fwdptrs properly (if present).

I re-instated the utility class as ShenandoahForwarding and this updated 
change keeps those utilities.

> *) It seems in SH::evacuate_object, this needs to call some utility method?
> 
>   236   markOop old_mark = p->mark_raw();
>   237   if (old_mark->is_marked()) {
>   238     return (oop) old_mark->clear_lock_bits();
>   239   }
> 
> ...and here?
> 
>   281   markOop new_mark = markOopDesc::encode_pointer_as_mark(copy_val);
>   282   markOop prev_mark = p->cas_set_mark_raw(new_mark, old_mark);
>   283   if (prev_mark == old_mark) {


> I actually think that we can keep ShenandoahBrooksPointer and put all that util code there. It would
> still be doing its job: abstracting away the forwarding data handling.


I reinstated the ShenandoahForwarding utility class. However, it is hard 
to abstract the protocol because the two parts strictly belong together. 
However, this seems all the more reason to abstract it properly. The 
only thing that happens in between the two blocks is actually allocating 
and copying the object. So we could call into, say, 
ShenandoahForwarding::evacuate() which would do the prefix and suffix, 
and call back to say copy = ShHeap::allocate_and_copy(obj); or such for 
the payload. What do you think?

> *) In ShenandoahMarkCompact, do these need to be public?
> 
>    76 public:
>    77   void preserve_mark(oop obj);
>    78   void restore_marks();
>    79   void adjust_marks();

I forgot to mention ShenandoahMarkCompact. This completely overhauls how 
ShMarkCompact stores forwarding information. It's changed to basically 
work like other GCs and stores the forwarding in the mark-word. However, 
the mark word must sometimes be preserved. Therefore we store it to the 
side. The 3 methods above handle that. They are public because they are 
called from closures. Alternatively, we could make the closures friends 
of ShMarkCompact. ?

Updated patch:
http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.01/

It's based on:
http://cr.openjdk.java.net/~rkennke/renamebrooksptr/webrev.00/

Still passes all tests.

Roman

From shade at redhat.com  Wed May  8 08:17:13 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 10:17:13 +0200
Subject: RFR: Rename ShenandoahBrooksPointer to ShenandoahForwarding
In-Reply-To: <53a4cde2-a3d5-dc48-74c8-ae9737b1a966@redhat.com>
References: <53a4cde2-a3d5-dc48-74c8-ae9737b1a966@redhat.com>
Message-ID: <e2f5eb16-562e-7aaf-4ccb-cdbc479775d8@redhat.com>

On 5/7/19 9:32 PM, Roman Kennke wrote:
> In preparation of elimination of the brooks pointer slot, I'd like to
> rename ShenandoahBrooksPointer to ShenandoahForwarding. This name seems
> more appropriate then. I also renamed some of the accessors to make more
> sense in the new context.
> 
> http://cr.openjdk.java.net/~rkennke/renamebrooksptr/webrev.00/

I thought it should go to upstream straight away? We can pull jdk/jdk -> sh/jdk early to get the
change into the sandbox.

Seeing how you modified the include lists, have you tried to build with --disable-precompiled-headers?

Otherwise looks good.

-Aleksey






From aoqi at loongson.cn  Wed May  8 08:43:48 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 16:43:48 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
Message-ID: <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>

Hi,

The patch [1] dose not apply cleanly again because of JDK-8223449. And
src/hotspot/share/jvmci/vmStructs_jvmci.cpp needs to be updated. Here
is a new version:

http://cr.openjdk.java.net/~aoqi/8222926/webrev.02/

Could I please get reviews? (cc'ed shenandoah-dev)

Thanks,
Ao Qi

[1] http://cr.openjdk.java.net/~aoqi/8222926/webrev.01/



On Fri, Apr 26, 2019 at 3:59 PM Ao Qi <aoqi at loongson.cn> wrote:
>
> Hi,
>
> The patch [1] dose not apply cleanly any more, because of the same
> copyright update in JDK-8222811 [2]. I updated a new version to
> exclude this copyright modification:
>
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.01/
>
> Could I please get reviews for this?
>
> Thanks,
> Ao Qi
>
> [1] http://cr.openjdk.java.net/~aoqi/8222926/webrev.00/
> [2] http://hg.openjdk.java.net/jdk/jdk/diff/1126f0607c70/src/hotspot/share/code/codeBlob.cpp#l1.6
>
>
> On Wed, Apr 24, 2019 at 9:56 PM Ao Qi <aoqi at loongson.cn> wrote:
> >
> > Hi,
> >
> > When I configure using --with-jvm-features=-compiler1, I found build
> > is broken. The main cause is that some shenandoah related part did not
> > consider the situation when compiler1 is disabled. I also found that
> > src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
> > and src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
> > were basically the same, with only small differences. I unified these
> > two files and moved the result to a c1 related file. I also fixed one
> > "#undef" only when COMPILER1 is true in
> > shenandoahBarrierSetAssembler_x86/aarch64.cpp and one missed include
> > in codeBlob.cpp.
> >
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8222926/
> >
> > Webrev:
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.00/
> >
> > Tested:
> >   - build: linux-x86_64-{server, zero, minimal}-{release, fastdebug},
> > linux-aarch64-server-release
> >   - jtreg: linux-x86_64-server-release tier1,
> > linux-aarch64-server-release tier1_gc_shenandoah
> >
> > Thanks,
> > Ao Qi

From shade at redhat.com  Wed May  8 08:49:59 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 10:49:59 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
Message-ID: <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>

On 5/8/19 10:43 AM, Ao Qi wrote:
> The patch [1] dose not apply cleanly again because of JDK-8223449. And
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp needs to be updated. Here
> is a new version:
> 
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.02/

I understand the need for fixing -compiler1 configuration. I am, however, against cobbling together
x86 and aarch64 code with sprinkled #ifdefs. It would be another story if the code was indeed the
same, but they are not.

What is the fix for -compiler1 build issue? Can it be done on its own?

-Aleksey


From simone.bordet at gmail.com  Wed May  8 09:09:44 2019
From: simone.bordet at gmail.com (Simone Bordet)
Date: Wed, 8 May 2019 11:09:44 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
Message-ID: <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>

Hi,

On Tue, May 7, 2019 at 9:50 PM Roman Kennke <rkennke at redhat.com> wrote:
>
> Until now, Shenandoah had the 'limitation' that it required an extra
> word per object to keep the forwarding pointer. It either points to
> itself (most of the time) or to the forwarded object when evacuated. The
> forwarding pointer is updated atomically using CAS. This is the heart of
> Shenandoah's evacuation protocol.
>
> With LRB, we have the opportunity to eliminate that extra word.

I obviously missed the memo, but can you clarify this?
What's exactly LRB? Is there any reference I can read about this technique?

Thanks!

-- 
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

From shade at redhat.com  Wed May  8 09:14:01 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 11:14:01 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>
Message-ID: <8d7ad4ce-c428-672b-5821-7a68a6fc619c@redhat.com>

On 5/8/19 11:09 AM, Simone Bordet wrote:
> Hi,
> 
> On Tue, May 7, 2019 at 9:50 PM Roman Kennke <rkennke at redhat.com> wrote:
>>
>> Until now, Shenandoah had the 'limitation' that it required an extra
>> word per object to keep the forwarding pointer. It either points to
>> itself (most of the time) or to the forwarded object when evacuated. The
>> forwarding pointer is updated atomically using CAS. This is the heart of
>> Shenandoah's evacuation protocol.
>>
>> With LRB, we have the opportunity to eliminate that extra word.
> 
> I obviously missed the memo, but can you clarify this?
> What's exactly LRB? Is there any reference I can read about this technique?

https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009203.html

LRB = LoadReferenceBarrier. LRB intercepts heap accesses at load-reference time, evacuates the
object then. This is stronger to-space invariant than we used to have. With LRB, we (almost) never
access collection set (from-space) objects. This avoids dealing with stores, acmp barriers, etc.
Also, it makes from-space object available for storing the forwarding data, as Roman's patch does.

-- 
Thanks,
-Aleksey


From aoqi at loongson.cn  Wed May  8 09:26:29 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 17:26:29 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
Message-ID: <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>

On Wed, May 8, 2019 at 4:49 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 10:43 AM, Ao Qi wrote:
> > The patch [1] dose not apply cleanly again because of JDK-8223449. And
> > src/hotspot/share/jvmci/vmStructs_jvmci.cpp needs to be updated. Here
> > is a new version:
> >
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.02/
>
> I understand the need for fixing -compiler1 configuration. I am, however, against cobbling together
> x86 and aarch64 code with sprinkled #ifdefs. It would be another story if the code was indeed the
> same, but they are not.
>
> What is the fix for -compiler1 build issue? Can it be done on its own?

Thanks for your reply, Aleksey.

If we want to fix -compiler1 build without cobbling together x86 and
aarch64 code, I think one way is to put all of the code in
shenandoahBarrierSetC1_x86.cpp and shenandoahBarrierSetC1_aarch64.cpp
into #ifdef COMPILER1 ... #endif. What do you think about this method?

>
> -Aleksey
>

From shade at redhat.com  Wed May  8 09:34:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 11:34:25 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
Message-ID: <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>

On 5/7/19 9:49 PM, Roman Kennke wrote:
>> *) Maybe we should fork introducing new tmp to CAS? That would make the patch easier to backport, I
>> think.
> 
> Not sure. The change would make the register allocators free one more register but then not use it.
> I left it out of this iteration for now.

Yeah, the extra cleanness in the final patch might not worth the effort of doing the CAS change
beforehand. Maybe we should break some overly long lines in AArch64 CAS code (compare sh_aarch64.ad
and sh_x86_64.ad), while we are at it.


>> I actually think that we can keep ShenandoahBrooksPointer and put all that util code there. It would
>> still be doing its job: abstracting away the forwarding data handling.
> 
> I reinstated the ShenandoahForwarding utility class. However, it is hard to abstract the protocol
> because the two parts strictly belong together. However, this seems all the more reason to abstract
> it properly. The only thing that happens in between the two blocks is actually allocating and
> copying the object. So we could call into, say, ShenandoahForwarding::evacuate() which would do the
> prefix and suffix, and call back to say copy = ShHeap::allocate_and_copy(obj); or such for the
> payload. What do you think?

I don't understand off-hand why the protocol is different. For example, why do you need to drag
old_mark in SH:evacuate_object? You can still have try_update_forwardee to check that "old" mark is
not forwarded yet, and use that?

Pseudocode for try_update_forwardee:

// returns "true" on success
bool try_update_forwardee(p, copy_val):
  markOop old = p->mark_raw();
  if (old->is_marked()):
    return false;
  markOop new_mark = markOopDesc::encode_pointer_as_mark(copy_val);
  markOop prev_mark = p->cas_set_mark_raw(new_mark, old_mark);
  return prev_mark == old_mark;

...then:

if (try_update_forwardee(p, copy_val)):
  shenandoah_assert_correct(NULL, copy_val);
  return copy_val;
} else {
  return ShenandoahForwarding::get_forwardee(p);
}


>> *) In ShenandoahMarkCompact, do these need to be public?
>>
>> ?? 76 public:
>> ?? 77?? void preserve_mark(oop obj);
>> ?? 78?? void restore_marks();
>> ?? 79?? void adjust_marks();
> 
> I forgot to mention ShenandoahMarkCompact. This completely overhauls how ShMarkCompact stores
> forwarding information. It's changed to basically work like other GCs and stores the forwarding in
> the mark-word. However, the mark word must sometimes be preserved. Therefore we store it to the
> side. The 3 methods above handle that. They are public because they are called from closures.
> Alternatively, we could make the closures friends of ShMarkCompact. ?

Yes, befriending closures would look cleaner, I think.

> Updated patch:
> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.01/

Other nits:

 *) The dance like that needs some rationale/pseudo-code?

 326   Label done;
 327   __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
 328   __ notptr(tmp);
 329   __ testb(tmp, markOopDesc::marked_value);
 330   __ jccb(Assembler::notZero, done);
 331   __ orptr(tmp, markOopDesc::marked_value);
 332   __ notptr(tmp);
 333   __ mov(dst, tmp);
 334   __ bind(done);

 *) In here, you can call get_forwardee_raw_unchecked to have only one shenandoah_assert_correct assert:

  45 inline oop ShenandoahForwarding::get_forwardee(oop obj) {
  46   shenandoah_assert_correct(NULL, obj);
  47   return oop(get_forwardee_raw(obj));
  48 }

-Aleksey


From shade at redhat.com  Wed May  8 09:40:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 11:40:55 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
Message-ID: <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>

On 5/8/19 11:26 AM, Ao Qi wrote:
> If we want to fix -compiler1 build without cobbling together x86 and
> aarch64 code, I think one way is to put all of the code in
> shenandoahBarrierSetC1_x86.cpp and shenandoahBarrierSetC1_aarch64.cpp
> into #ifdef COMPILER1 ... #endif. What do you think about this method?

That would be fine with me!

Better yet, there are exclusion lists in JvmFeature.gmk:

 ifeq ($(call check-jvm-feature, compiler1), true)
  JVM_CFLAGS_FEATURES += -DCOMPILER1
else
  JVM_EXCLUDE_PATTERNS += c1_ c1/
endif

So the fix might just amount to moving:
 ./src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
   ->
 ./src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp

...and
 ./src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
   ->
 ./src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp

-Aleksey


From simone.bordet at gmail.com  Wed May  8 09:42:18 2019
From: simone.bordet at gmail.com (Simone Bordet)
Date: Wed, 8 May 2019 11:42:18 +0200
Subject: Forwarding pointer elimination questions
In-Reply-To: <8d7ad4ce-c428-672b-5821-7a68a6fc619c@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>
 <8d7ad4ce-c428-672b-5821-7a68a6fc619c@redhat.com>
Message-ID: <CAFWmRJ28=UOftv8jFb5HzCLXmx+TSoW0L+RRvBzdMK6srZdo1A@mail.gmail.com>

Hi,

[new subject to avoid hijacking your RFR one]

On Wed, May 8, 2019 at 11:14 AM Aleksey Shipilev <shade at redhat.com> wrote:
> https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009203.html
>
> LRB = LoadReferenceBarrier. LRB intercepts heap accesses at load-reference time, evacuates the
> object then.

This is quite similar to the ZGC and C4 barrier, right?

Is the LRB used only during evacuation, or also in the other phases
(marking, update_reference)?
Are you storing metadata on the side when the mutator triggers the
LRB, so that the CAS is now performed on the side data structure
rather than the forwarding pointer?

What's the LRB looking like in ASM?

Feels like you just moved from a Brooks pointer algorithm to a C4-like
algorithm (as described in the C4 paper - perhaps not exactly the same
as C4 or ZGC implementation wise).
If so, I have to update my slides :)

Thanks!
-- 
Simone Bordet
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

From rkennke at redhat.com  Wed May  8 09:55:20 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 11:55:20 +0200
Subject: Forwarding pointer elimination questions
In-Reply-To: <CAFWmRJ28=UOftv8jFb5HzCLXmx+TSoW0L+RRvBzdMK6srZdo1A@mail.gmail.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>
 <8d7ad4ce-c428-672b-5821-7a68a6fc619c@redhat.com>
 <CAFWmRJ28=UOftv8jFb5HzCLXmx+TSoW0L+RRvBzdMK6srZdo1A@mail.gmail.com>
Message-ID: <93de8908-b5b8-f809-8c3b-41b8b1dab60e@redhat.com>

Hi Simone,

> [new subject to avoid hijacking your RFR one]
> 
> On Wed, May 8, 2019 at 11:14 AM Aleksey Shipilev <shade at redhat.com> wrote:
>> https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009203.html
>>
>> LRB = LoadReferenceBarrier. LRB intercepts heap accesses at load-reference time, evacuates the
>> object then.
> 
> This is quite similar to the ZGC and C4 barrier, right?

Not quite. ZGC and C4 also use the load-barriers to support marking. 
Shenandoah still has (and will have) SATB barriers for that. Also, the 
technique used to enforce the to-space-invariant is totally different.

> Is the LRB used only during evacuation, or also in the other phases
> (marking, update_reference)?

LRB is active whenever there are forwarded objects. That is evacuation, 
update-references, and marking if marking also does piggy-backed 
update-references.

A good way to think about this is:
Any object that is in-use has the lifecycle:
1. It gets loaded or created somewhere
2. It gets passed around
3. It is used for various things (reading from, writing to, comparing, etc)
eventually it goes out of scope

We used to employ the barriers, and ensure a reasonable invariant at 
use-sites (e.g. #3). Now we're employ the barriers and enforce *strong* 
invariant right when the object enters the system (#1). The advantages are:
1. Strong invariant means we don't need to worry about that later, e.g. 
when comparing or storing objects
2. Optimization is easier: placement at load-site is naturally less hot 
than placement at use-site. Our previous optimizations worked very hard 
to move barriers away from use-sites. Now we're basically starting out 
with almost-optimal placement and don't need to do very much.
3. Since all barriers are now basically what used to be write-barriers, 
and because those are conditional on GC phase and object-status (e.g. 
part of cset or not), the actual slow-path is not all that hot and it 
doesn't hurt to e.g. complicate the forward pointer resolution a tiny 
little bit by introducing decoding the mark word for it.

> Are you storing metadata on the side when the mutator triggers the
> LRB, so that the CAS is now performed on the side data structure
> rather than the forwarding pointer?

No. The CAS is performed on the mark word of the from-space copy. The 
protocol is not significantly different than before.

> What's the LRB looking like in ASM?

It's pretty much like the old WB.

> Feels like you just moved from a Brooks pointer algorithm to a C4-like
> algorithm (as described in the C4 paper - perhaps not exactly the same
> as C4 or ZGC implementation wise).

The actual algorithm is still the same: Evacuation performs an 
speculative copy of the object, then competes to CAS the forwarding 
pointer. The only difference is that before we CASed it into the extra 
slot, now it's CASed to the mark word slot.

The reason why LRB enables to do this is that in the old world, we'd 
have to do barriers on use-sites. In particular, we needed read-barriers 
when reading from fields. Those read-barriers tended to be very hot. 
Complicating those read-barriers by decoding a mark word would have been 
prohibitive. (I had a prototype for that, and it was no good.)

> If so, I have to update my slides :)

A little bit, yeah. OTOH, LRB and elimination for forward pointer word 
are quite new (jdk13) and only slowly coming down the pipeline (jdk12, 
jdk11 and jdk8).

Does the clarify the situation?

Roman


From shade at redhat.com  Wed May  8 09:56:17 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 11:56:17 +0200
Subject: Forwarding pointer elimination questions
In-Reply-To: <CAFWmRJ28=UOftv8jFb5HzCLXmx+TSoW0L+RRvBzdMK6srZdo1A@mail.gmail.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <CAFWmRJ2gW_8La3+rWqnQ0qvZaxmZuv67vDCQU-skA_XkMAod6A@mail.gmail.com>
 <8d7ad4ce-c428-672b-5821-7a68a6fc619c@redhat.com>
 <CAFWmRJ28=UOftv8jFb5HzCLXmx+TSoW0L+RRvBzdMK6srZdo1A@mail.gmail.com>
Message-ID: <0ac55056-320f-b01f-7c96-ae57d3b4d547@redhat.com>

On 5/8/19 11:42 AM, Simone Bordet wrote:
> On Wed, May 8, 2019 at 11:14 AM Aleksey Shipilev <shade at redhat.com> wrote:
>> https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009203.html
>>
>> LRB = LoadReferenceBarrier. LRB intercepts heap accesses at load-reference time, evacuates the
>> object then.
> 
> This is quite similar to the ZGC and C4 barrier, right?

No, it is not. The placement for barrier is similar, but the way forwarding data is encoded and how
the relocation is handled is still Shenandoah. LRB basically does what WB used to do, but in
different place: check the GC state, cset status, existing forwarding, and evacuate the object if
needed.

> Is the LRB used only during evacuation, or also in the other phases
> (marking, update_reference)?

LRB basically does what our WB used to do, it does not do anything new. SATB barrier is used to
support marking, as usual.

> Are you storing metadata on the side when the mutator triggers the
> LRB, so that the CAS is now performed on the side data structure
> rather than the forwarding pointer?

No. LRB still uses the same forwarding pointer slot as WB used before. Forwarding pointer *is*
metadata. New patch "just" moves the forwarding data that used to occupy the separate slot into the
mark word slot in the from-space object. (It requires some simple decoding to disambiguate fwdptr
from the "vanilla" mark word in not-yet-forwarded object).

> What's the LRB looking like in ASM?

https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-March/008995.html

> Feels like you just moved from a Brooks pointer algorithm to a C4-like
> algorithm (as described in the C4 paper - perhaps not exactly the same
> as C4 or ZGC implementation wise).

No, I would not say so. What is "Brooks pointer algorithm"? I assume you mean in-object indirection
pointer that points to the actual copy. It is still there: in mark word slot of the from-space
object. LRB only changes where that pointer is consulted with: with LRB, on the read side, rather
than both on read and write sides, as it used to be before.

-Aleksey




From rkennke at redhat.com  Wed May  8 10:07:14 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 12:07:14 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
Message-ID: <aa292c33-218a-7467-c05f-0dc4b393374f@redhat.com>

>>> *) Maybe we should fork introducing new tmp to CAS? That would make the patch easier to backport, I
>>> think.
>>
>> Not sure. The change would make the register allocators free one more register but then not use it.
>> I left it out of this iteration for now.
> 
> Yeah, the extra cleanness in the final patch might not worth the effort of doing the CAS change
> beforehand. Maybe we should break some overly long lines in AArch64 CAS code (compare sh_aarch64.ad
> and sh_x86_64.ad), while we are at it.
> 
> 
>>> I actually think that we can keep ShenandoahBrooksPointer and put all that util code there. It would
>>> still be doing its job: abstracting away the forwarding data handling.
>>
>> I reinstated the ShenandoahForwarding utility class. However, it is hard to abstract the protocol
>> because the two parts strictly belong together. However, this seems all the more reason to abstract
>> it properly. The only thing that happens in between the two blocks is actually allocating and
>> copying the object. So we could call into, say, ShenandoahForwarding::evacuate() which would do the
>> prefix and suffix, and call back to say copy = ShHeap::allocate_and_copy(obj); or such for the
>> payload. What do you think?
> 
> I don't understand off-hand why the protocol is different. For example, why do you need to drag
> old_mark in SH:evacuate_object? You can still have try_update_forwardee to check that "old" mark is
> not forwarded yet, and use that?

But that would complicate the protocol, wouldn't it?
Currently we check if object has been forwarded before we actually do 
the copy. If we see it is already forwarded, we bail out right away. If 
we didn't 'remember' the old_mark at this point, we wouldn't know what 
to compare with when attempting the CAS. Yes, we probably could re-load 
it afterwards but that would require that we check again if another 
thread beat us just like we did at the start. It seems more efficient 
(fewer mark-loads) and cleaner to me to enclose the actual copy with the 
protocol like I did.

> Pseudocode for try_update_forwardee:
> 
> // returns "true" on success
> bool try_update_forwardee(p, copy_val):
>    markOop old = p->mark_raw();
>    if (old->is_marked()):
>      return false;
>    markOop new_mark = markOopDesc::encode_pointer_as_mark(copy_val);
>    markOop prev_mark = p->cas_set_mark_raw(new_mark, old_mark);
>    return prev_mark == old_mark;
> 
> ...then:
> 
> if (try_update_forwardee(p, copy_val)):
>    shenandoah_assert_correct(NULL, copy_val);
>    return copy_val;
> } else {
>    return ShenandoahForwarding::get_forwardee(p);
> }

Yes, that would work, but doesn't look very efficient. The CAS already 
gives us the offending new mark-word, we don't actually need to re-load 
it. And also, we don't need to re-load it between head and tail of the 
protocol either. Let me try to come up with a cleaner expression of the 
protocol.

>>> *) In ShenandoahMarkCompact, do these need to be public?
>>>
>>>  ?? 76 public:
>>>  ?? 77?? void preserve_mark(oop obj);
>>>  ?? 78?? void restore_marks();
>>>  ?? 79?? void adjust_marks();
>>
>> I forgot to mention ShenandoahMarkCompact. This completely overhauls how ShMarkCompact stores
>> forwarding information. It's changed to basically work like other GCs and stores the forwarding in
>> the mark-word. However, the mark word must sometimes be preserved. Therefore we store it to the
>> side. The 3 methods above handle that. They are public because they are called from closures.
>> Alternatively, we could make the closures friends of ShMarkCompact. ?
> 
> Yes, befriending closures would look cleaner, I think.

Ok, will do.

>> Updated patch:
>> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.01/
> 
> Other nits:
> 
>   *) The dance like that needs some rationale/pseudo-code?
> 
>   326   Label done;
>   327   __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
>   328   __ notptr(tmp);
>   329   __ testb(tmp, markOopDesc::marked_value);
>   330   __ jccb(Assembler::notZero, done);
>   331   __ orptr(tmp, markOopDesc::marked_value);
>   332   __ notptr(tmp);
>   333   __ mov(dst, tmp);
>   334   __ bind(done);

Ah yeah. It is surprisingly awkward to write efficient asm for the 
decoding. I'll explain it in comments.

>   *) In here, you can call get_forwardee_raw_unchecked to have only one shenandoah_assert_correct assert:
> 
>    45 inline oop ShenandoahForwarding::get_forwardee(oop obj) {
>    46   shenandoah_assert_correct(NULL, obj);
>    47   return oop(get_forwardee_raw(obj));
>    48 }

Ok, will do.

Thanks,
Roman

From rkennke at redhat.com  Wed May  8 10:27:39 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 12:27:39 +0200
Subject: RFR: JDK-8223567: Rename ShenandoahBrooksPointer to
 ShenandoahForwarding
Message-ID: <1f163407-e8e2-14c6-4e28-578f8bdc624f@redhat.com>

In preparation of elimination of the brooks pointer slot, I'd like to
rename ShenandoahBrooksPointer to ShenandoahForwarding. This name seems 
more appropriate then.

I also renamed some of the accessors to make more
sense in the new context.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8223567
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8223567/webrev.00/

Testing: hotspot_gc_shenandoah (x86,aarch64), also with and without 
--disable-precompiled-headers

Ok?

Roman

From shade at redhat.com  Wed May  8 11:30:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 13:30:49 +0200
Subject: RFR: JDK-8223567: Rename ShenandoahBrooksPointer to
 ShenandoahForwarding
In-Reply-To: <1f163407-e8e2-14c6-4e28-578f8bdc624f@redhat.com>
References: <1f163407-e8e2-14c6-4e28-578f8bdc624f@redhat.com>
Message-ID: <097da3c1-80a2-4e32-d7b4-49c6132a2988@redhat.com>

On 5/8/19 12:27 PM, Roman Kennke wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8223567
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8223567/webrev.00/

This looks good to me.

-Aleksey


From shade at redhat.com  Wed May  8 11:39:00 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 13:39:00 +0200
Subject: RFR (XS) 8223570: Shenandoah needs to acquire lock before
 CLDG::clear_claimed_marks
Message-ID: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223570

New assert fails and exposes this legit GC bug. Shenandoah does CLDG::clear_claimed_marks in two
places, one under the safepoint (which is fine for that assert), and another one in concurrent
thread, which fails.

Fix:

diff -r 845f5a35241b src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Wed May 08 06:40:45 2019 -0400
+++ b/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Wed May 08 13:36:56 2019 +0200
@@ -552,11 +552,14 @@
 }

 void ShenandoahTraversalGC::concurrent_traversal_collection() {
-  ClassLoaderDataGraph::clear_claimed_marks();
+  {
+    MutexLocker ml(ClassLoaderDataGraph_lock);
+    ClassLoaderDataGraph::clear_claimed_marks();
+  }

   ShenandoahGCPhase phase_work(ShenandoahPhaseTimings::conc_traversal);
   if (!_heap->cancelled_gc()) {

Testing: hotspot_gc_shenandoah (running)

-- 
Thanks,
-Aleksey



From aoqi at loongson.cn  Wed May  8 11:52:08 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 19:52:08 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
Message-ID: <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>

On Wed, May 8, 2019 at 5:40 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 11:26 AM, Ao Qi wrote:
> > If we want to fix -compiler1 build without cobbling together x86 and
> > aarch64 code, I think one way is to put all of the code in
> > shenandoahBarrierSetC1_x86.cpp and shenandoahBarrierSetC1_aarch64.cpp
> > into #ifdef COMPILER1 ... #endif. What do you think about this method?
>
> That would be fine with me!
>
> Better yet, there are exclusion lists in JvmFeature.gmk:
>
>  ifeq ($(call check-jvm-feature, compiler1), true)
>   JVM_CFLAGS_FEATURES += -DCOMPILER1
> else
>   JVM_EXCLUDE_PATTERNS += c1_ c1/
> endif

Didn't know that. Thanks!

>
> So the fix might just amount to moving:
>  ./src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
>    ->
>  ./src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
>
> ...and
>  ./src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
>    ->
>  ./src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp

Done that. Please see:

http://cr.openjdk.java.net/~aoqi/8222926/webrev.03/

I also updated https://bugs.openjdk.java.net/browse/JDK-8222926.

Tested:
build: linux-x86_64-{server, zero, minimal}-{release, fastdebug},
linux-aarch64-server-release
build (-compiler1): linux-x86_64-server-release, linux-aarch64-server-release
hotspot:tier1 linux-x86_64-server-{release,fastdebug}

Thanks,
Ao Qi

>
> -Aleksey
>

From thomas.schatzl at oracle.com  Wed May  8 12:07:16 2019
From: thomas.schatzl at oracle.com (Thomas Schatzl)
Date: Wed, 08 May 2019 14:07:16 +0200
Subject: RFR (XS) 8223570: Shenandoah needs to acquire lock before
 CLDG::clear_claimed_marks
In-Reply-To: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>
References: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>
Message-ID: <4e9b02867ca48cafb7ef88ac55e538ee6d774926.camel@oracle.com>

Hi,

On Wed, 2019-05-08 at 13:39 +0200, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8223570
> 
> New assert fails and exposes this legit GC bug. Shenandoah does
> CLDG::clear_claimed_marks in two places, one under the safepoint
> (which is fine for that assert), and another one in concurrent
> thread, which fails.
> 
> Fix:
> [...]

  fix looks good.

Sorry for not thinking about Shenandoah too when reviewing the G1 fix.

Thanks,
  Thomas



From roman at kennke.org  Wed May  8 12:11:35 2019
From: roman at kennke.org (Roman Kennke)
Date: Wed, 8 May 2019 14:11:35 +0200
Subject: RFR (XS) 8223570: Shenandoah needs to acquire lock before
 CLDG::clear_claimed_marks
In-Reply-To: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>
References: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>
Message-ID: <45573a8b-53ed-2ea7-be15-0626e6ff0057@kennke.org>

Looks good. Thanks!

(how has that not failed before? Also, we shall revisit this 
clear_claimed_marks in traversal. It should not be necessary and only 
extend the traversal.)

Roman

> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223570
> 
> New assert fails and exposes this legit GC bug. Shenandoah does CLDG::clear_claimed_marks in two
> places, one under the safepoint (which is fine for that assert), and another one in concurrent
> thread, which fails.
> 
> Fix:
> 
> diff -r 845f5a35241b src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Wed May 08 06:40:45 2019 -0400
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Wed May 08 13:36:56 2019 +0200
> @@ -552,11 +552,14 @@
>   }
> 
>   void ShenandoahTraversalGC::concurrent_traversal_collection() {
> -  ClassLoaderDataGraph::clear_claimed_marks();
> +  {
> +    MutexLocker ml(ClassLoaderDataGraph_lock);
> +    ClassLoaderDataGraph::clear_claimed_marks();
> +  }
> 
>     ShenandoahGCPhase phase_work(ShenandoahPhaseTimings::conc_traversal);
>     if (!_heap->cancelled_gc()) {
> 
> Testing: hotspot_gc_shenandoah (running)
> 

From shade at redhat.com  Wed May  8 12:28:08 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 14:28:08 +0200
Subject: RFR (XS) 8223570: Shenandoah needs to acquire lock before
 CLDG::clear_claimed_marks
In-Reply-To: <45573a8b-53ed-2ea7-be15-0626e6ff0057@kennke.org>
References: <10143339-41cb-e1ad-4131-a8c2d680aaeb@redhat.com>
 <45573a8b-53ed-2ea7-be15-0626e6ff0057@kennke.org>
Message-ID: <d50d1387-e213-86c0-5e7f-505241440ef8@redhat.com>

On 5/8/19 2:11 PM, Roman Kennke wrote:
> (how has that not failed before? Also, we shall revisit this clear_claimed_marks in traversal. It
> should not be necessary and only extend the traversal.)

Yes. New assert, recently committed. It probably fails silently otherwise. Pushed.

> Roman
> 
>> Bug:
>> ?? https://bugs.openjdk.java.net/browse/JDK-8223570
>>
>> New assert fails and exposes this legit GC bug. Shenandoah does CLDG::clear_claimed_marks in two
>> places, one under the safepoint (which is fine for that assert), and another one in concurrent
>> thread, which fails.

-Aleksey


From shade at redhat.com  Wed May  8 12:30:41 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 14:30:41 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
Message-ID: <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>

On 5/8/19 1:52 PM, Ao Qi wrote:
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.03/

Webrev says the files were deleted, then added. This loses history. I think you need "hg mv -A" them
or something. Or, let me move the files myself, and then you would apply the rest of build fixes?

-Aleksey


From aoqi at loongson.cn  Wed May  8 12:47:16 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 20:47:16 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
Message-ID: <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>

On Wed, May 8, 2019 at 8:30 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 1:52 PM, Ao Qi wrote:
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.03/
>
> Webrev says the files were deleted, then added. This loses history. I think you need "hg mv -A" them
> or something. Or, let me move the files myself, and then you would apply the rest of build fixes?

Sorry for that. Is this one right?

http://cr.openjdk.java.net/~aoqi/8222926/webrev.04/

If not, maybe I need your help.

Cheers,
Ao Qi
>
> -Aleksey
>

From shade at redhat.com  Wed May  8 12:52:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 14:52:16 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
Message-ID: <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>

On 5/8/19 2:47 PM, Ao Qi wrote:
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.04/

Yes, this looks right. To be extra sure, ask Mercurial if it knows the file history:

$ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
$ hg log src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp

...it should go back all the way to:

changeset:   52925:9c18c9d839d3
user:        rkennke
date:        Mon Dec 10 15:47:44 2018 +0100
summary:     8214259: Implementation: JEP 189: Shenandoah: A Low-Pause-Time Garbage Collector
(Experimental)

I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
-- please change it for the changeset you are pushing.

-Aleksey


From aoqi at loongson.cn  Wed May  8 13:05:00 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 21:05:00 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
Message-ID: <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>

On Wed, May 8, 2019 at 8:52 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 2:47 PM, Ao Qi wrote:
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.04/
>
> Yes, this looks right. To be extra sure, ask Mercurial if it knows the file history:
>
> $ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
> $ hg log src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
>
> ...it should go back all the way to:
>
> changeset:   52925:9c18c9d839d3
> user:        rkennke
> date:        Mon Dec 10 15:47:44 2018 +0100
> summary:     8214259: Implementation: JEP 189: Shenandoah: A Low-Pause-Time Garbage Collector
> (Experimental)

$ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

changeset:   54423:6c0ab8bd8da5
user:        rkennke
date:        Tue Apr 02 23:00:22 2019 +0200
summary:     8221766: Load-reference barriers for Shenandoah

changeset:   53519:74a5ef4c81cc
user:        rkennke
date:        Sat Jan 26 01:21:33 2019 +0100
summary:     8217016: Shenandoah: Streamline generation of CAS barriers

changeset:   52925:9c18c9d839d3
user:        rkennke
date:        Mon Dec 10 15:47:44 2018 +0100
summary:     8214259: Implementation: JEP 189: Shenandoah: A
Low-Pause-Time Garbage Collector (Experimental)

$ hg log src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

$ hg log src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

$ hg log -f src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
changeset:   54760:a1a250da545f
tag:         tip
user:        aoqi
date:        Wed May 08 20:57:12 2019 +0800
summary:     8222926: Shenandoah build fails with --with-jvm-features=-compiler1

changeset:   54423:6c0ab8bd8da5
user:        rkennke
date:        Tue Apr 02 23:00:22 2019 +0200
summary:     8221766: Load-reference barriers for Shenandoah

changeset:   53519:74a5ef4c81cc
user:        rkennke
date:        Sat Jan 26 01:21:33 2019 +0100
summary:     8217016: Shenandoah: Streamline generation of CAS barriers

changeset:   52925:9c18c9d839d3
user:        rkennke
date:        Mon Dec 10 15:47:44 2018 +0100
summary:     8214259: Implementation: JEP 189: Shenandoah: A
Low-Pause-Time Garbage Collector (Experimental)

$ hg summ
parent: 54760:a1a250da545f tip
 8222926: Shenandoah build fails with --with-jvm-features=-compiler1
branch: default
commit: 350 unknown (clean)
update: (current)
phases: 1 draft

>
> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
> -- please change it for the changeset you are pushing.

Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/

I am not a Committers. I need a sponsor:(

Thanks,
Ao Qi
>
> -Aleksey
>

From shade at redhat.com  Wed May  8 13:32:51 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 15:32:51 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
Message-ID: <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>

On 5/8/19 3:05 PM, Ao Qi wrote:
>> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
>> -- please change it for the changeset you are pushing.
> 
> Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
> 
> I am not a Committers. I need a sponsor:(

I will sponsor.

-Aleksey


From aoqi at loongson.cn  Wed May  8 13:39:32 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 21:39:32 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
Message-ID: <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>

On Wed, May 8, 2019 at 9:32 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 3:05 PM, Ao Qi wrote:
> >> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
> >> -- please change it for the changeset you are pushing.
> >
> > Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
> >
> > I am not a Committers. I need a sponsor:(
>
> I will sponsor.

Thank you very much!
>
> -Aleksey
>

From shade at redhat.com  Wed May  8 13:49:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 15:49:25 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
 <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
Message-ID: <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>

On 5/8/19 3:39 PM, Ao Qi wrote:
> On Wed, May 8, 2019 at 9:32 PM Aleksey Shipilev <shade at redhat.com> wrote:
>>
>> On 5/8/19 3:05 PM, Ao Qi wrote:
>>>> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
>>>> -- please change it for the changeset you are pushing.
>>>
>>> Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
>>>
>>> I am not a Committers. I need a sponsor:(
>>
>> I will sponsor.

The patch does not pass my local builds without precompiled headers and compiler1. This is also
needed, agree?

diff -r 0e3ee2061ea7 src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
--- a/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp   Wed May 08
20:57:12 2019 +0800
+++ b/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp   Wed May 08
15:46:04 2019 +0200
@@ -29,12 +29,12 @@
 #ifdef COMPILER1
 class LIR_Assembler;
 class ShenandoahPreBarrierStub;
 class ShenandoahLoadReferenceBarrierStub;
 class StubAssembler;
+#endif
 class StubCodeGenerator;
-#endif

 class ShenandoahBarrierSetAssembler: public BarrierSetAssembler {
 private:

   static address _shenandoah_lrb;
diff -r 0e3ee2061ea7 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
--- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp   Wed May 08 20:57:12
2019 +0800
+++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp   Wed May 08 15:46:04
2019 +0200
@@ -29,12 +29,12 @@
 #ifdef COMPILER1
 class LIR_Assembler;
 class ShenandoahPreBarrierStub;
 class ShenandoahLoadReferenceBarrierStub;
 class StubAssembler;
+#endif
 class StubCodeGenerator;
-#endif

 class ShenandoahBarrierSetAssembler: public BarrierSetAssembler {
 private:

   static address _shenandoah_lrb;

--
-Aleksey


From rkennke at redhat.com  Wed May  8 14:10:16 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 16:10:16 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
Message-ID: <3f51025a-fa57-44a4-dab3-cb8cfd48f85e@redhat.com>

>> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
>> -- please change it for the changeset you are pushing.
> 
> Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/

This looks good. Thanks!
Roman

From rkennke at redhat.com  Wed May  8 14:28:41 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 16:28:41 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
Message-ID: <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>

Hi Aleksey,

>>> I actually think that we can keep ShenandoahBrooksPointer and put all that util code there. It would
>>> still be doing its job: abstracting away the forwarding data handling.
>>
>> I reinstated the ShenandoahForwarding utility class. However, it is hard to abstract the protocol
>> because the two parts strictly belong together. However, this seems all the more reason to abstract
>> it properly. The only thing that happens in between the two blocks is actually allocating and
>> copying the object. So we could call into, say, ShenandoahForwarding::evacuate() which would do the
>> prefix and suffix, and call back to say copy = ShHeap::allocate_and_copy(obj); or such for the
>> payload. What do you think?
> 
> I don't understand off-hand why the protocol is different. For example, why do you need to drag
> old_mark in SH:evacuate_object? You can still have try_update_forwardee to check that "old" mark is
> not forwarded yet, and use that?
> 
> Pseudocode for try_update_forwardee:
> 
> // returns "true" on success
> bool try_update_forwardee(p, copy_val):
>   markOop old = p->mark_raw();
>   if (old->is_marked()):
>     return false;
>   markOop new_mark = markOopDesc::encode_pointer_as_mark(copy_val);
>   markOop prev_mark = p->cas_set_mark_raw(new_mark, old_mark);
>   return prev_mark == old_mark;
> 
> ...then:
> 
> if (try_update_forwardee(p, copy_val)):
>   shenandoah_assert_correct(NULL, copy_val);
>   return copy_val;
> } else {
>   return ShenandoahForwarding::get_forwardee(p);
> }

Ok right, I got it. I moved all forwarding related code to
ShenandoahForwarding.

I also added ShenandoahForwarding::is_forwarded(oop obj) which can be
used in the GC threads evac path where we don't care about actually
decoding and comparing the oops. Should be slightly more efficient.

>>> *) In ShenandoahMarkCompact, do these need to be public?
>>>
>>> ?? 76 public:
>>> ?? 77?? void preserve_mark(oop obj);
>>> ?? 78?? void restore_marks();
>>> ?? 79?? void adjust_marks();
>>
>> I forgot to mention ShenandoahMarkCompact. This completely overhauls how ShMarkCompact stores
>> forwarding information. It's changed to basically work like other GCs and stores the forwarding in
>> the mark-word. However, the mark word must sometimes be preserved. Therefore we store it to the
>> side. The 3 methods above handle that. They are public because they are called from closures.
>> Alternatively, we could make the closures friends of ShMarkCompact. ?
> 
> Yes, befriending closures would look cleaner, I think.

Done.

>> Updated patch:
>> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.01/
> 
> Other nits:
> 
>  *) The dance like that needs some rationale/pseudo-code?
> 
>  326   Label done;
>  327   __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
>  328   __ notptr(tmp);
>  329   __ testb(tmp, markOopDesc::marked_value);
>  330   __ jccb(Assembler::notZero, done);
>  331   __ orptr(tmp, markOopDesc::marked_value);
>  332   __ notptr(tmp);
>  333   __ mov(dst, tmp);
>  334   __ bind(done);

I added comments.

>  *) In here, you can call get_forwardee_raw_unchecked to have only one shenandoah_assert_correct assert:
> 
>   45 inline oop ShenandoahForwarding::get_forwardee(oop obj) {
>   46   shenandoah_assert_correct(NULL, obj);
>   47   return oop(get_forwardee_raw(obj));
>   48 }

Done.

New webrev:
http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.02/

Better?

Roman


From shade at redhat.com  Wed May  8 14:46:07 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 16:46:07 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
 <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
Message-ID: <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>

On 5/8/19 4:28 PM, Roman Kennke wrote:
> New webrev:
> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.02/

I don't understand this part. Returning the oop makes the call ambiguous; this is why my example had
"bool" as return value to communicate success. What oop does SF::try_update_forwardee return? It
should be documented in the .hpp.

So I am trying to wrap my head around it:

  55 inline oop ShenandoahForwarding::try_update_forwardee(oop obj, oop update) {
  56   markOop old_mark = obj->mark_raw();
  57   if (old_mark->is_marked()) {
  58     return (oop) old_mark->clear_lock_bits();
  59   }
  60
  61   markOop new_mark = markOopDesc::encode_pointer_as_mark(update);
  62   markOop prev_mark = obj->cas_set_mark_raw(new_mark, old_mark);
  63   if (prev_mark == old_mark) {
  64     return obj;
  65   } else {
  66     return (oop) prev_mark->clear_lock_bits();
  67   }
  68 }

Is it supposed to return to-space object on all paths? I say we return "update" on L64 then, and
then here:

 275   oop result = ShenandoahForwarding::try_update_forwardee(p, copy_val);
 276   if (oopDesc::equals_raw(result, p)) {  // !!!!
 277     // Successfully evacuated. Our copy is now the public one!
         ...
 280   }  else {
 281     // Failed to evacuate. We need to deal with the object that is left behind. Since this
        ....
 297   }

...at L276 we check "equals_raw(result, copy_val)". This would make the code much more
straight-forward, I think: we would check if we indeed installed our copy_val.

-Aleksey


From shade at redhat.com  Wed May  8 14:55:03 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 16:55:03 +0200
Subject: Result: New Shenandoah Committer: Andrew Hughes
Message-ID: <7796f0bd-2a36-8a1f-ebef-03138d04c24a@redhat.com>

Voting for Andrew Hughes [1] is now closed.

Yes: 5
Veto: 0
Abstain: 0

According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination.

-Aleksey

[1] https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009385.html


From aoqi at loongson.cn  Wed May  8 15:02:14 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 23:02:14 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
 <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
 <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>
Message-ID: <CALjzQn45B5OWe5Nwkt-kFEEEG6FrXqUd1gL1GXkH-6z4+qV=rw@mail.gmail.com>

On Wed, May 8, 2019 at 9:49 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 3:39 PM, Ao Qi wrote:
> > On Wed, May 8, 2019 at 9:32 PM Aleksey Shipilev <shade at redhat.com> wrote:
> >>
> >> On 5/8/19 3:05 PM, Ao Qi wrote:
> >>>> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
> >>>> -- please change it for the changeset you are pushing.
> >>>
> >>> Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
> >>>
> >>> I am not a Committers. I need a sponsor:(
> >>
> >> I will sponsor.
>
> The patch does not pass my local builds without precompiled headers and compiler1. This is also
> needed, agree?

Agreed. Sorry for not testing that. Updated:
http://cr.openjdk.java.net/~aoqi/8222926/webrev.06/

Thanks,
Ao Qi


>
> diff -r 0e3ee2061ea7 src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
> --- a/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp   Wed May 08
> 20:57:12 2019 +0800
> +++ b/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp   Wed May 08
> 15:46:04 2019 +0200
> @@ -29,12 +29,12 @@
>  #ifdef COMPILER1
>  class LIR_Assembler;
>  class ShenandoahPreBarrierStub;
>  class ShenandoahLoadReferenceBarrierStub;
>  class StubAssembler;
> +#endif
>  class StubCodeGenerator;
> -#endif
>
>  class ShenandoahBarrierSetAssembler: public BarrierSetAssembler {
>  private:
>
>    static address _shenandoah_lrb;
> diff -r 0e3ee2061ea7 src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
> --- a/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp   Wed May 08 20:57:12
> 2019 +0800
> +++ b/src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp   Wed May 08 15:46:04
> 2019 +0200
> @@ -29,12 +29,12 @@
>  #ifdef COMPILER1
>  class LIR_Assembler;
>  class ShenandoahPreBarrierStub;
>  class ShenandoahLoadReferenceBarrierStub;
>  class StubAssembler;
> +#endif
>  class StubCodeGenerator;
> -#endif
>
>  class ShenandoahBarrierSetAssembler: public BarrierSetAssembler {
>  private:
>
>    static address _shenandoah_lrb;
>
> --
> -Aleksey
>

From rkennke at redhat.com  Wed May  8 15:03:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 17:03:08 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
 <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
 <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>
Message-ID: <67049c88-07cb-7e51-3b57-eea92538f916@redhat.com>

Hi Aleksey,

>> New webrev:
>> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.02/
> 
> I don't understand this part. Returning the oop makes the call ambiguous; this is why my example had
> "bool" as return value to communicate success. What oop does SF::try_update_forwardee return? It
> should be documented in the .hpp.
> 
> So I am trying to wrap my head around it:
> 
>    55 inline oop ShenandoahForwarding::try_update_forwardee(oop obj, oop update) {
>    56   markOop old_mark = obj->mark_raw();
>    57   if (old_mark->is_marked()) {
>    58     return (oop) old_mark->clear_lock_bits();
>    59   }
>    60
>    61   markOop new_mark = markOopDesc::encode_pointer_as_mark(update);
>    62   markOop prev_mark = obj->cas_set_mark_raw(new_mark, old_mark);
>    63   if (prev_mark == old_mark) {
>    64     return obj;
>    65   } else {
>    66     return (oop) prev_mark->clear_lock_bits();
>    67   }
>    68 }
> 
> Is it supposed to return to-space object on all paths? I say we return "update" on L64 then, and
> then here:
> 
>   275   oop result = ShenandoahForwarding::try_update_forwardee(p, copy_val);
>   276   if (oopDesc::equals_raw(result, p)) {  // !!!!
>   277     // Successfully evacuated. Our copy is now the public one!
>           ...
>   280   }  else {
>   281     // Failed to evacuate. We need to deal with the object that is left behind. Since this
>          ....
>   297   }
> 
> ...at L276 we check "equals_raw(result, copy_val)". This would make the code much more
> straight-forward, I think: we would check if we indeed installed our copy_val.
> 

Right. I tried to do what other CASes do and return the 
previous/expected value on success. But I agree that it's more intuitive 
to always return the successful forwardee and inverse the logic in 
evacuate_object().

http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.03/

Better?

Roman

From aoqi at loongson.cn  Wed May  8 15:04:52 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 8 May 2019 23:04:52 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <3f51025a-fa57-44a4-dab3-cb8cfd48f85e@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <3f51025a-fa57-44a4-dab3-cb8cfd48f85e@redhat.com>
Message-ID: <CALjzQn7OhJXHRrtRntv79mfuVHoSnH6QiPFw7tZ3jhhv9+_+0g@mail.gmail.com>

On Wed, May 8, 2019 at 10:10 PM Roman Kennke <rkennke at redhat.com> wrote:
>
> >> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
> >> -- please change it for the changeset you are pushing.
> >
> > Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
>
> This looks good. Thanks!

Thanks, Roman. I updated a new version. Do you agree with Aleksey and
are you ok with the new version?

Ao Qi

> Roman

From shade at redhat.com  Wed May  8 15:10:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 17:10:20 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn45B5OWe5Nwkt-kFEEEG6FrXqUd1gL1GXkH-6z4+qV=rw@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
 <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
 <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>
 <CALjzQn45B5OWe5Nwkt-kFEEEG6FrXqUd1gL1GXkH-6z4+qV=rw@mail.gmail.com>
Message-ID: <06f822d8-f5c9-3184-49cc-f6b159257670@redhat.com>

On 5/8/19 5:02 PM, Ao Qi wrote:
> Agreed. Sorry for not testing that. Updated:
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.06/

Yup, I'll put it through some testing and push on success.

-Aleksey


From rkennke at redhat.com  Wed May  8 15:14:23 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 17:14:23 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <CALjzQn7OhJXHRrtRntv79mfuVHoSnH6QiPFw7tZ3jhhv9+_+0g@mail.gmail.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <3f51025a-fa57-44a4-dab3-cb8cfd48f85e@redhat.com>
 <CALjzQn7OhJXHRrtRntv79mfuVHoSnH6QiPFw7tZ3jhhv9+_+0g@mail.gmail.com>
Message-ID: <9dcbd794-15c2-dad6-22ce-c21250308e23@redhat.com>

>>>> I changed the synopsis for the bug to: "Shenandoah build fails with --with-jvm-features=-compiler1"
>>>> -- please change it for the changeset you are pushing.
>>>
>>> Updated: http://cr.openjdk.java.net/~aoqi/8222926/webrev.05/
>>
>> This looks good. Thanks!
> 
> Thanks, Roman. I updated a new version. Do you agree with Aleksey and
> are you ok with the new version?

Yep, good!

Thanks,
Roman

From shade at redhat.com  Wed May  8 15:15:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 17:15:45 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <67049c88-07cb-7e51-3b57-eea92538f916@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
 <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
 <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>
 <67049c88-07cb-7e51-3b57-eea92538f916@redhat.com>
Message-ID: <eefb6e23-beff-502f-21bf-c0785f196f6d@redhat.com>

On 5/8/19 5:03 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.03/

Looks good. I think it is good to go to sh/jdk, and we would follow-up on any subsequent issues later.

Minor nit in shenandoahHeap.inline.hpp, need to fix indent a bit:

 445     assert (cs >= tams,  "only objects past TAMS here: "   PTR_FORMAT " (" PTR_FORMAT ")",
p2i(cs), p2i(tams));
 446     assert (cs < limit, "only objects below limit here: " PTR_FORMAT " (" PTR_FORMAT ")",
p2i(cs), p2i(limit));

-Aleksey


From rkennke at redhat.com  Wed May  8 15:27:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 17:27:08 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <eefb6e23-beff-502f-21bf-c0785f196f6d@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
 <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
 <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>
 <67049c88-07cb-7e51-3b57-eea92538f916@redhat.com>
 <eefb6e23-beff-502f-21bf-c0785f196f6d@redhat.com>
Message-ID: <35284830-3b42-74e3-b6b4-fbc47506ef5e@redhat.com>

> On 5/8/19 5:03 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.03/
> 
> Looks good. I think it is good to go to sh/jdk, and we would follow-up on any subsequent issues later.
> 
> Minor nit in shenandoahHeap.inline.hpp, need to fix indent a bit:
> 
>   445     assert (cs >= tams,  "only objects past TAMS here: "   PTR_FORMAT " (" PTR_FORMAT ")",
> p2i(cs), p2i(tams));
>   446     assert (cs < limit, "only objects below limit here: " PTR_FORMAT " (" PTR_FORMAT ")",
> p2i(cs), p2i(limit));
> 
> -Aleksey
> 

Good spot. Updated:
http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.04/

If you're ok, I will cherry-pick JDK-8223567 to sh/jdk and push this 
patch on top of it.

Roman

From shade at redhat.com  Wed May  8 15:28:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 17:28:16 +0200
Subject: RFR: Eliminate extra forwarding pointer per object
In-Reply-To: <35284830-3b42-74e3-b6b4-fbc47506ef5e@redhat.com>
References: <f9ade776-1aad-815b-2d9a-92231cc0704b@redhat.com>
 <2c92a3ae-5b5d-0f98-34e3-516c7f5a3e7b@redhat.com>
 <e76b544c-fa60-89aa-497b-dcb2f4fa3b32@redhat.com>
 <1bbdb8e3-1933-180a-4de1-b4975cb80e14@redhat.com>
 <f3a21750-99e7-a2e2-9202-37cb34455f44@redhat.com>
 <90bb82df-f5f7-6b78-04a4-b5000f7d13e4@redhat.com>
 <67049c88-07cb-7e51-3b57-eea92538f916@redhat.com>
 <eefb6e23-beff-502f-21bf-c0785f196f6d@redhat.com>
 <35284830-3b42-74e3-b6b4-fbc47506ef5e@redhat.com>
Message-ID: <a9756eb9-2c22-800c-87c7-d8ce58b07577@redhat.com>

On 5/8/19 5:27 PM, Roman Kennke wrote:
> Good spot. Updated:
> http://cr.openjdk.java.net/~rkennke/eliminate-fwdptr/webrev.04/
> 
> If you're ok, I will cherry-pick JDK-8223567 to sh/jdk and push this patch on top of it.

Yeah, that's fine, as long as it is the same patch.

-Aleksey


From shade at redhat.com  Wed May  8 16:06:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 18:06:46 +0200
Subject: RFR [11u]: Fix x86_32 build failures after CAS barriers backport
Message-ID: <d2bc4f3a-6508-2021-b19b-f8cda0bde63b@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/11-fix-cas/webrev.01/

CAS backport broke x86_32 builds, because Shenandoah identifiers are not accessible when Shenandoah
compilation is disabled. We can work that around until we backport more stuff.

Testing: Linux (x86_32, x86_64) builds; tier1_gc_shenandoah

-- 
Thanks,
-Aleksey



From shade at redhat.com  Wed May  8 16:10:24 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 18:10:24 +0200
Subject: RFR: JDK-8222926: Unify cpu related part of
 shenandoahBarrierSetC1 and fix build when compiler1 is disabled
In-Reply-To: <06f822d8-f5c9-3184-49cc-f6b159257670@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
 <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
 <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>
 <CALjzQn45B5OWe5Nwkt-kFEEEG6FrXqUd1gL1GXkH-6z4+qV=rw@mail.gmail.com>
 <06f822d8-f5c9-3184-49cc-f6b159257670@redhat.com>
Message-ID: <7a8892d4-97cb-a8d6-0c1c-05012abf71a9@redhat.com>

On 5/8/19 5:10 PM, Aleksey Shipilev wrote:
> On 5/8/19 5:02 PM, Ao Qi wrote:
>> Agreed. Sorry for not testing that. Updated:
>> http://cr.openjdk.java.net/~aoqi/8222926/webrev.06/
> 
> Yup, I'll put it through some testing and push on success.

Tests passed, pushed:
  http://hg.openjdk.java.net/jdk/jdk/rev/2584e5772546

-Aleksey


From rkennke at redhat.com  Wed May  8 16:23:55 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 18:23:55 +0200
Subject: RFR [11u]: Fix x86_32 build failures after CAS barriers backport
In-Reply-To: <d2bc4f3a-6508-2021-b19b-f8cda0bde63b@redhat.com>
References: <d2bc4f3a-6508-2021-b19b-f8cda0bde63b@redhat.com>
Message-ID: <efd3d434-1058-27f9-72a8-e97425bb8da8@redhat.com>

Looks Ok. Thanks!

Roman


> http://cr.openjdk.java.net/~shade/shenandoah/11-fix-cas/webrev.01/
> 
> CAS backport broke x86_32 builds, because Shenandoah identifiers are not accessible when Shenandoah
> compilation is disabled. We can work that around until we backport more stuff.
> 
> Testing: Linux (x86_32, x86_64) builds; tier1_gc_shenandoah
> 

From rkennke at redhat.com  Wed May  8 16:38:36 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Wed, 08 May 2019 16:38:36 +0000
Subject: hg: shenandoah/jdk: 2 new changesets
Message-ID: <201905081638.x48GcaKQ024399@aojmv0008.oracle.com>

Changeset: 6b79b1efc6c6
Author:    rkennke
Date:      2019-05-08 18:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6b79b1efc6c6

Cherry-pick: 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSetAssembler.hpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.hpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: c4d541020ff6
Author:    rkennke
Date:      2019-05-08 18:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c4d541020ff6

Eliminate extra forwarding pointer per object

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp


From shade at redhat.com  Wed May  8 16:45:05 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 08 May 2019 16:45:05 +0000
Subject: hg: shenandoah/jdk11: Fix x86_32 build failures after CAS barriers
 backport
Message-ID: <201905081645.x48Gj5k5029006@aojmv0008.oracle.com>

Changeset: 7d1ca2400ada
Author:    shade
Date:      2019-05-08 18:03 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d1ca2400ada

Fix x86_32 build failures after CAS barriers backport

! src/hotspot/cpu/x86/x86_64.ad


From shade at redhat.com  Wed May  8 18:02:52 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 20:02:52 +0200
Subject: RFC: Pick up 11.0.4+2 to sh/jdk11
Message-ID: <c4180fae-0281-c40f-8e16-46492fc98cb2@redhat.com>

Upstream tag 11.0.4+2 is now available:
  http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/3b9194001c2e

This includes all outstanding work in 11u updates project over the last several months. Let's pick
that up to sh/jdk11 for early testing. After we pull this huge thing, the other updates should be
smaller and incremental. As usual, the plan is to push this merge to sh/jdk11, run it through our
nightlies, and then tag it shenandoah-jdk-11.0.4+2.

Surprisingly, nothing is affected in GC code to require any conflict resolution.

Diffstat:
  492 files changed, 25218 insertions(+), 16525 deletions(-)

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b2/changesets.txt

Webrev (only src/hotspot to minimize cruft):
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b2/webrev.01/

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey



From shade at redhat.com  Wed May  8 19:30:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 21:30:25 +0200
Subject: [URGENT] RFR (XS) 8223583: Build failure after JDK-8223567 (Rename
 ShenandoahBrooksPointer to ShenandoahForwarding)
Message-ID: <62e24abc-8fb0-b805-323f-94b8cdc34640@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223583

This is a merge blunder: the code below was added recently, and Roman probably missed this when
pushing to jdk/jdk.

Fix:

diff -r 6ccc7cd7931e src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Wed May 08 11:56:19 2019 -0700
+++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Wed May 08 21:27:49 2019 +0200
@@ -925,11 +925,11 @@
   template <class T>
   void do_oop_work(T* p) {
     T o = RawAccess<>::oop_load(p);
     if (!CompressedOops::is_null(o)) {
       oop obj = CompressedOops::decode_not_null(o);
-      oop fwd = (oop) ShenandoahBrooksPointer::get_raw_unchecked(obj);
+      oop fwd = (oop) ShenandoahForwarding::get_forwardee_raw_unchecked(obj);
       if (!oopDesc::equals_raw(obj, fwd)) {
         ShenandoahAsserts::print_failure(ShenandoahAsserts::_safe_all, obj, p, NULL,
                                          "Verify Roots", "Should not be forwarded", __FILE__,
__LINE__);
       }
     }

Testing: Linux x86_64 build

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May  8 19:31:56 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 21:31:56 +0200
Subject: [URGENT] RFR (XS) 8223583: Build failure after JDK-8223567
 (Rename ShenandoahBrooksPointer to ShenandoahForwarding)
In-Reply-To: <62e24abc-8fb0-b805-323f-94b8cdc34640@redhat.com>
References: <62e24abc-8fb0-b805-323f-94b8cdc34640@redhat.com>
Message-ID: <c0c673fd-63c8-e68b-9189-fd4f9ffefc7b@redhat.com>

Ok. Goes under emergency-fix & triviality. :-)

Roman

> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8223583
> 
> This is a merge blunder: the code below was added recently, and Roman probably missed this when
> pushing to jdk/jdk.
> 
> Fix:
> 
> diff -r 6ccc7cd7931e src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Wed May 08 11:56:19 2019 -0700
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Wed May 08 21:27:49 2019 +0200
> @@ -925,11 +925,11 @@
>     template <class T>
>     void do_oop_work(T* p) {
>       T o = RawAccess<>::oop_load(p);
>       if (!CompressedOops::is_null(o)) {
>         oop obj = CompressedOops::decode_not_null(o);
> -      oop fwd = (oop) ShenandoahBrooksPointer::get_raw_unchecked(obj);
> +      oop fwd = (oop) ShenandoahForwarding::get_forwardee_raw_unchecked(obj);
>         if (!oopDesc::equals_raw(obj, fwd)) {
>           ShenandoahAsserts::print_failure(ShenandoahAsserts::_safe_all, obj, p, NULL,
>                                            "Verify Roots", "Should not be forwarded", __FILE__,
> __LINE__);
>         }
>       }
> 
> Testing: Linux x86_64 build
> 

From shade at redhat.com  Wed May  8 19:33:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 8 May 2019 21:33:46 +0200
Subject: [URGENT] RFR (XS) 8223583: Build failure after JDK-8223567
 (Rename ShenandoahBrooksPointer to ShenandoahForwarding)
In-Reply-To: <c0c673fd-63c8-e68b-9189-fd4f9ffefc7b@redhat.com>
References: <62e24abc-8fb0-b805-323f-94b8cdc34640@redhat.com>
 <c0c673fd-63c8-e68b-9189-fd4f9ffefc7b@redhat.com>
Message-ID: <7c78aedc-f1ff-2b9c-92c3-6e2c28cc879e@redhat.com>

Thanks, pushed.

-Aleksey

On 5/8/19 9:31 PM, Roman Kennke wrote:
> Ok. Goes under emergency-fix & triviality. :-)
> 
> Roman
> 
>> Bug:
>> ?? https://bugs.openjdk.java.net/browse/JDK-8223583
>>
>> This is a merge blunder: the code below was added recently, and Roman probably missed this when
>> pushing to jdk/jdk.
>>
>> Fix:
>>
>> diff -r 6ccc7cd7931e src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
>> --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp??? Wed May 08 11:56:19 2019 -0700
>> +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp??? Wed May 08 21:27:49 2019 +0200
>> @@ -925,11 +925,11 @@
>> ??? template <class T>
>> ??? void do_oop_work(T* p) {
>> ????? T o = RawAccess<>::oop_load(p);
>> ????? if (!CompressedOops::is_null(o)) {
>> ??????? oop obj = CompressedOops::decode_not_null(o);
>> -????? oop fwd = (oop) ShenandoahBrooksPointer::get_raw_unchecked(obj);
>> +????? oop fwd = (oop) ShenandoahForwarding::get_forwardee_raw_unchecked(obj);
>> ??????? if (!oopDesc::equals_raw(obj, fwd)) {
>> ????????? ShenandoahAsserts::print_failure(ShenandoahAsserts::_safe_all, obj, p, NULL,
>> ?????????????????????????????????????????? "Verify Roots", "Should not be forwarded", __FILE__,
>> __LINE__);
>> ??????? }
>> ????? }
>>
>> Testing: Linux x86_64 build
>>


-- 
Thanks,
-Aleksey

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander


From rkennke at redhat.com  Wed May  8 19:37:55 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 8 May 2019 21:37:55 +0200
Subject: RFC: Pick up 11.0.4+2 to sh/jdk11
In-Reply-To: <c4180fae-0281-c40f-8e16-46492fc98cb2@redhat.com>
References: <c4180fae-0281-c40f-8e16-46492fc98cb2@redhat.com>
Message-ID: <332b1132-9c2b-1da8-6c90-5b766981edfb@redhat.com>

It looks good to me. Thanks!

Roman

> Upstream tag 11.0.4+2 is now available:
>    http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/3b9194001c2e
> 
> This includes all outstanding work in 11u updates project over the last several months. Let's pick
> that up to sh/jdk11 for early testing. After we pull this huge thing, the other updates should be
> smaller and incremental. As usual, the plan is to push this merge to sh/jdk11, run it through our
> nightlies, and then tag it shenandoah-jdk-11.0.4+2.
> 
> Surprisingly, nothing is affected in GC code to require any conflict resolution.
> 
> Diffstat:
>    492 files changed, 25218 insertions(+), 16525 deletions(-)
> 
> Changesets:
>    http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b2/changesets.txt
> 
> Webrev (only src/hotspot to minimize cruft):
>    http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b2/webrev.01/
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}
> 

From shade at redhat.com  Wed May  8 19:40:42 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 08 May 2019 19:40:42 +0000
Subject: hg: shenandoah/jdk11: 163 new changesets
Message-ID: <201905081940.x48JesiP006037@aojmv0008.oracle.com>

Changeset: 1513c37187dc
Author:    andrew
Date:      2019-04-16 21:50 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1513c37187dc

Added tag jdk-11.0.3-ga for changeset 175eb80c253a

! .hgtags

Changeset: 7fdd8a358428
Author:    clanger
Date:      2019-02-27 12:46 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7fdd8a358428

Added tag jdk-11.0.4+0 for changeset cd1c042181e9

! .hgtags

Changeset: 83a926bc11f1
Author:    clanger
Date:      2019-02-27 12:52 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/83a926bc11f1

8219710: Bump update version for OpenJDK: jdk11.0.4
Reviewed-by: goetz

! make/autoconf/version-numbers

Changeset: 5d1cef3a47d6
Author:    roland
Date:      2018-11-09 10:52 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5d1cef3a47d6

8205574: Loop predication "assert(f <= 1 && f >= 0) failed Incorrect frequency"
Reviewed-by: kvn

! src/hotspot/share/opto/loopPredicate.cpp

Changeset: 77d9d51fa87e
Author:    shade
Date:      2018-08-20 10:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/77d9d51fa87e

8209573: [TESTBUG] gc/epsilon/TestMemoryMXBeans should retry on failure
Reviewed-by: kvn, pliden

! test/hotspot/jtreg/gc/epsilon/TestMemoryMXBeans.java

Changeset: 2a6b24793745
Author:    jlahoda
Date:      2018-11-12 09:35 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2a6b24793745

8209055: c.s.t.javac.code.DeferredCompletionFailureHandler seems to use WeakHashMap incorrectly
Summary: Do not keep speculative Symbols in DeferredCompletionFailureHandler.
Reviewed-by: jjg, vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/DeferredCompletionFailureHandler.java
+ test/langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java

Changeset: 7d9c0aa588fa
Author:    rraghavan
Date:      2018-12-18 19:13 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d9c0aa588fa

8211698: Crash in C2 compiled code during execution of double array heavy processing code
Summary: Correctly registered new Opaque4Node in add_range_check_predicate
Reviewed-by: roland, thartmann

! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/opto/node.cpp
+ test/hotspot/jtreg/compiler/loopopts/Test8211698.java

Changeset: 21d73cbc4dd6
Author:    cushon
Date:      2018-09-10 16:59 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/21d73cbc4dd6

8210483: AssertionError in DeferredAttr at setOverloadKind caused by JDK-8203679
Reviewed-by: mcimadamore, vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java
+ test/langtools/tools/javac/lambda/methodReference/MethodRefStuck.java
+ test/langtools/tools/javac/lambda/methodReference/MethodRefStuck.out

Changeset: 3bf4ad83cc97
Author:    iignatyev
Date:      2018-08-01 10:04 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3bf4ad83cc97

8174691: [TESTBUG] A number of native hotspot unit tests fail when executed in stand-alone mode
Reviewed-by: kvn, tschatzl

! src/hotspot/share/gc/g1/g1Arguments.hpp
! test/hotspot/gtest/gc/g1/test_g1HeapVerifier.cpp
! test/hotspot/gtest/runtime/test_os.cpp
! test/hotspot/gtest/utilities/test_spinYield.cpp

Changeset: 73a65a62f3dc
Author:    hseigel
Date:      2019-01-02 10:35 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/73a65a62f3dc

8215398: -Xlog option usage => Invalid decorator '\temp\app_cds.log'.
Summary: On Windows, do not treat ':' as a delimeter when it's in a string such as "C:..."
Reviewed-by: dholmes, sspitsyn

! src/hotspot/share/logging/logConfiguration.cpp
+ test/hotspot/jtreg/serviceability/logging/TestFullNames.java

Changeset: fe997ff98f68
Author:    valeriep
Date:      2018-07-13 02:36 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/fe997ff98f68

8179098: Crypto AES/ECB encryption/decryption performance regression (introduced in jdk9b73)
Summary: Do bounds check per encryption/decryption call instead of per block
Reviewed-by: ascarpino, redestad

! src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java
! src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
! src/java.base/share/classes/com/sun/crypto/provider/CipherFeedback.java
! src/java.base/share/classes/com/sun/crypto/provider/CounterMode.java
! src/java.base/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java
! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
! src/java.base/share/classes/com/sun/crypto/provider/OutputFeedback.java
! src/java.base/share/classes/com/sun/crypto/provider/PCBC.java
+ src/java.base/share/classes/sun/security/util/ArrayUtil.java

Changeset: bdef4b8bd745
Author:    ascarpino
Date:      2019-02-11 13:23 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bdef4b8bd745

8201633: Problems with AES-GCM native acceleration
Reviewed-by: valeriep

! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java

Changeset: 62b7feb2a424
Author:    serb
Date:      2018-11-10 18:48 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/62b7feb2a424

8211435: Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source
Reviewed-by: dmarkov, lbourges, kaddepalli, prr

! src/java.desktop/share/classes/java/awt/DefaultKeyboardFocusManager.java
+ test/jdk/java/awt/Focus/NullActiveWindowOnFocusLost/NullActiveWindowOnFocusLost.java

Changeset: 81ffc4400fd6
Author:    sveerabhadra
Date:      2019-02-21 11:10 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/81ffc4400fd6

8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe
Reviewed-by: prr, mhalder

! src/jdk.accessibility/windows/native/jaccessinspector/jaccessinspectorWindow.rc
! src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalkerWindow.rc

Changeset: af4c02487ee8
Author:    goetz
Date:      2019-03-06 08:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/af4c02487ee8

Merge

! .hgtags

Changeset: 4eeba4a93e01
Author:    itakiguchi
Date:      2018-10-19 15:26 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4eeba4a93e01

8211393: Memory leak issue on awt_InputMethod.c
Reviewed-by: naoto, clanger

! src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c
! src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c

Changeset: 487f5f38bf19
Author:    sherman
Date:      2018-08-07 16:07 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/487f5f38bf19

8208634: Add x-IBM-1129 charset
Reviewed-by: alanb, sherman
Contributed-by: enasser at in.ibm.com

+ make/data/charsetmapping/IBM1129.c2b
+ make/data/charsetmapping/IBM1129.map
! make/data/charsetmapping/charsets
! make/data/charsetmapping/stdcs-aix
! make/nb_native/nbproject/configurations.xml
! test/jdk/java/nio/charset/Charset/RegisteredCharsets.java
! test/jdk/java/nio/charset/RemovingSunIO/SunioAlias.java
! test/jdk/sun/nio/cs/CheckHistoricalNames.java

Changeset: cd14f3f1d702
Author:    itakiguchi
Date:      2018-12-02 11:09 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/cd14f3f1d702

8213618: IBM970 charset has missing entry and remove unexpected entries
Reviewed-by: srl, martin

! make/data/charsetmapping/IBM970.c2b
! make/data/charsetmapping/IBM970.map
! test/jdk/sun/nio/cs/TestIBMBugs.java

Changeset: cbec59639b24
Author:    itakiguchi
Date:      2018-12-06 10:22 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/cbec59639b24

8212794: IBM-964 is required for AIX default charset
Reviewed-by: rriggs, ihse, alanb

! make/data/charsetmapping/charsets
! make/data/charsetmapping/stdcs-aix
! src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java
- src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM964.java
+ src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM964.java.template
- src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java
+ src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java.template
! test/jdk/sun/nio/cs/TestIBMBugs.java

Changeset: c64dc31daf01
Author:    itakiguchi
Date:      2019-01-24 12:52 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c64dc31daf01

8214533: IBM-29626C is required for AIX default charset
Reviewed-by: alanb, rriggs

! make/data/charsetmapping/charsets
! make/data/charsetmapping/stdcs-aix
+ src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM29626C.java.template

Changeset: fe57931cf2e9
Author:    itakiguchi
Date:      2019-01-29 12:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/fe57931cf2e9

8217880: AIX build issue after JDK-8214533
Reviewed-by: goetz, ihse, mbaesken

! make/data/charsetmapping/stdcs-aix

Changeset: 4fc61287d36e
Author:    rraghavan
Date:      2018-11-12 01:15 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4fc61287d36e

8210803: Compilation failure in codeBlob.cpp for Windows 32-bit
Summary: Added ordinary operator delete declaration within class
Reviewed-by: kvn, rlichten, thartmann

! src/hotspot/share/code/codeBlob.hpp

Changeset: 82ca0bc39bca
Author:    simonis
Date:      2018-11-08 12:24 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/82ca0bc39bca

8213515: Improve freetype detection on linux/ppc64/ppc64le/s390x
Reviewed-by: shade, ihse, stuefe

! make/autoconf/lib-freetype.m4

Changeset: 13e7b95fb06c
Author:    mikael
Date:      2018-10-02 22:36 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/13e7b95fb06c

8211350: Remove jprt support
Reviewed-by: dholmes, erikj, mchung, alanb, jjg

- make/Jprt.gmk
! make/Main.gmk
! make/conf/jib-profiles.js
- make/jprt.properties
! src/hotspot/os/linux/os_linux.cpp
! test/TestCommon.gmk
! test/hotspot/jtreg/TEST.groups
- test/hotspot/jtreg/jprt.config
! test/jdk/ProblemList.txt
! test/jdk/TEST.groups
! test/jdk/com/sun/jdi/cds/CDSJDITest.java
! test/jdk/java/lang/String/CompactString/CompactString.java
! test/jdk/java/lang/StringBuffer/CompactStringBuffer.java
! test/jdk/java/lang/StringBuilder/CompactStringBuilder.java
- test/jdk/jprt.config
! test/jdk/lib/security/CheckBlacklistedCerts.java
! test/jdk/tools/jimage/JImageTest.java
! test/jdk/tools/jlink/plugins/StringSharingPluginTest.java
! test/jdk/tools/jlink/plugins/StripDebugPluginTest.java
! test/jdk/tools/lib/tests/Helper.java
! test/jdk/tools/pack200/Pack200Test.java
! test/jdk/tools/pack200/TestExceptions.java
! test/langtools/Makefile

Changeset: 81437133cd9e
Author:    weijun
Date:      2018-10-10 22:13 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/81437133cd9e

8211969: test/jdk/lib/security/CheckBlacklistedCerts.java searching for wrong paths
Reviewed-by: mullan

! test/jdk/lib/security/CheckBlacklistedCerts.java

Changeset: dd747064109e
Author:    jjiang
Date:      2018-10-16 10:16 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/dd747064109e

8211971: Move security/cacerts/VerifyCACerts.java and security/CheckBlacklistedCerts.java
Summary: Move lib/security tests to sun/security/lib
Reviewed-by: weijun

- test/jdk/lib/security/CheckBlacklistedCerts.java
- test/jdk/lib/security/cacerts/VerifyCACerts.java
+ test/jdk/sun/security/lib/CheckBlacklistedCerts.java
+ test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: ddb04368f21e
Author:    mdoerr
Date:      2019-03-01 17:48 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ddb04368f21e

8219582: PPC: Crash after C1 checkcast patched and GC
Reviewed-by: akozlov, goetz

! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp

Changeset: 0cfd4f0ef931
Author:    mullan
Date:      2018-10-19 09:31 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/0cfd4f0ef931

8195793: Remove GTE CyberTrust Global Root
Reviewed-by: rhalade

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: f3f367ec771b
Author:    jgeorge
Date:      2018-12-13 13:03 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f3f367ec771b

8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching
Summary: While doing a ptrace attach, do not attach to threads which are in the process of exiting or are zombies -- skip these threads.
Reviewed-by: jcbeyler, ysuenaga

! src/jdk.hotspot.agent/linux/native/libsaproc/libproc_impl.c
! src/jdk.hotspot.agent/linux/native/libsaproc/libproc_impl.h
! src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c

Changeset: 341b16ae32a7
Author:    aivanov
Date:      2018-12-11 14:11 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/341b16ae32a7

8215123: Crash in runtime image built with jlink --compress=2
Reviewed-by: ihse, alanb

! src/java.base/share/native/libjimage/imageDecompressor.cpp

Changeset: 9daced9e8d92
Author:    jcm
Date:      2019-01-23 23:24 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9daced9e8d92

8213825: assert(false) failed: Non-balanced monitor enter/exit! Likely JNI locking
Summary: skip sfpt optimization for Load is removed for Java Object's Markword Load.
Reviewed-by: kvn, dlong

! src/hotspot/share/opto/memnode.cpp

Changeset: 3393f6f6c1a2
Author:    dholmes
Date:      2019-02-20 19:41 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3393f6f6c1a2

8217765: Internal Error (javaCalls.cpp:61) guarantee(thread->can_call_java()) failed
Reviewed-by: rehn, redestad, coleenp

! src/hotspot/share/oops/instanceKlass.cpp

Changeset: a00d78251171
Author:    serb
Date:      2018-10-31 10:01 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a00d78251171

8208702: javax/swing/reliability/HangDuringStaticInitialization.java may hang on macos
Reviewed-by: prr, denis

! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m
! test/jdk/javax/swing/reliability/HangDuringStaticInitialization.java

Changeset: fba3c573d356
Author:    ascarpino
Date:      2019-03-07 19:35 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/fba3c573d356

8220165: Encryption using GCM results in RuntimeException- input length out of bound
Reviewed-by: valeriep

! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java
+ test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMLargeDataKAT.java

Changeset: e0d47c058971
Author:    fyang
Date:      2019-02-26 10:52 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e0d47c058971

8219698: aarch64: SIGILL triggered when specifying unsupported hardware features
Reviewed-by: aph

! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Changeset: 99ff09dbee34
Author:    stefank
Date:      2019-02-19 10:02 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/99ff09dbee34

8218733: SA: CollectedHeap provides broken implementation for used() and capacity()
Reviewed-by: shade, jgeorge, eosterlund

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/epsilon/EpsilonHeap.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeap.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZCollectedHeap.java

Changeset: ae39a79e3e37
Author:    xuelei
Date:      2018-12-18 12:08 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ae39a79e3e37

8215443: The use of TransportContext.fatal() leads to bad coding style
Reviewed-by: ascarpino

! src/java.base/share/classes/sun/security/ssl/Alert.java
! src/java.base/share/classes/sun/security/ssl/AlpnExtension.java
! src/java.base/share/classes/sun/security/ssl/CertSignAlgsExtension.java
! src/java.base/share/classes/sun/security/ssl/CertStatusExtension.java
! src/java.base/share/classes/sun/security/ssl/CertificateMessage.java
! src/java.base/share/classes/sun/security/ssl/CertificateRequest.java
! src/java.base/share/classes/sun/security/ssl/CertificateStatus.java
! src/java.base/share/classes/sun/security/ssl/CertificateVerify.java
! src/java.base/share/classes/sun/security/ssl/ChangeCipherSpec.java
! src/java.base/share/classes/sun/security/ssl/ClientHello.java
! src/java.base/share/classes/sun/security/ssl/ClientKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/CookieExtension.java
! src/java.base/share/classes/sun/security/ssl/DHClientKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/DHKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/DHServerKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/ECDHClientKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/ECPointFormatsExtension.java
! src/java.base/share/classes/sun/security/ssl/EncryptedExtensions.java
! src/java.base/share/classes/sun/security/ssl/ExtendedMasterSecretExtension.java
! src/java.base/share/classes/sun/security/ssl/Finished.java
! src/java.base/share/classes/sun/security/ssl/HandshakeContext.java
! src/java.base/share/classes/sun/security/ssl/HelloRequest.java
! src/java.base/share/classes/sun/security/ssl/HelloVerifyRequest.java
! src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java
! src/java.base/share/classes/sun/security/ssl/KeyUpdate.java
! src/java.base/share/classes/sun/security/ssl/MaxFragExtension.java
! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java
! src/java.base/share/classes/sun/security/ssl/PostHandshakeContext.java
! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java
! src/java.base/share/classes/sun/security/ssl/PskKeyExchangeModesExtension.java
! src/java.base/share/classes/sun/security/ssl/RSAClientKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/RSAKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/RSAServerKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/RenegoInfoExtension.java
! src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java
! src/java.base/share/classes/sun/security/ssl/SSLExtensions.java
! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java
! src/java.base/share/classes/sun/security/ssl/SSLTransport.java
! src/java.base/share/classes/sun/security/ssl/ServerHello.java
! src/java.base/share/classes/sun/security/ssl/ServerHelloDone.java
! src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java
! src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java
! src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java
! src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java
! src/java.base/share/classes/sun/security/ssl/SupportedVersionsExtension.java
! src/java.base/share/classes/sun/security/ssl/TransportContext.java

Changeset: f2793adec0db
Author:    ascarpino
Date:      2019-02-12 14:08 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f2793adec0db

8215790: Delegated task created by SSLEngine throws java.nio.BufferUnderflowException
Reviewed-by: jnimeh

! src/java.base/share/classes/sun/security/ssl/ClientHello.java
+ test/jdk/javax/net/ssl/interop/ClientHelloBufferUnderflowException.java

Changeset: 776e4a5fae09
Author:    xuelei
Date:      2019-02-20 10:20 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/776e4a5fae09

8219389: Delegated task created by SSLEngine throws BufferUnderflowException
Reviewed-by: ascarpino

! src/java.base/share/classes/sun/security/ssl/ClientHello.java
! src/java.base/share/classes/sun/security/ssl/HandshakeContext.java
! src/java.base/share/classes/sun/security/ssl/PostHandshakeContext.java
! test/jdk/javax/net/ssl/interop/ClientHelloBufferUnderflowException.java

Changeset: 05c8ba8443ca
Author:    vromero
Date:      2018-11-08 10:36 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/05c8ba8443ca

8210197: javac can't tell during speculative attribution if a diamond expression is creating an anonymous inner class or not
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java
+ test/langtools/tools/javac/T8210197/DiamondWithAnonymousInnerClassTest.java

Changeset: 71ccb47cfa8b
Author:    goetz
Date:      2019-03-13 08:02 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/71ccb47cfa8b

Merge

! .hgtags
! test/hotspot/gtest/runtime/test_os.cpp

Changeset: 51f3c245ec6f
Author:    goetz
Date:      2019-03-14 09:01 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/51f3c245ec6f

Merge


Changeset: a344c49b2d8c
Author:    apetcher
Date:      2018-08-29 12:00 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a344c49b2d8c

8201317: X25519/X448 code improvements
Summary: Minor code/comment improvements
Reviewed-by: xuelei

! src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial.java
! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyAgreement.java

Changeset: b04ec783f5fb
Author:    serb
Date:      2018-10-16 15:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b04ec783f5fb

8210739: Calling JSpinner's setFont with null throws NullPointerException
Reviewed-by: psadhukhan

! src/java.desktop/macosx/classes/com/apple/laf/AquaSpinnerUI.java
! src/java.desktop/share/classes/javax/swing/JSpinner.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSpinnerUI.java
+ test/jdk/javax/swing/JSpinner/WrongEditorTextFieldFont/FontSetToNull.java

Changeset: bdf10d7ca0c2
Author:    dfuchs
Date:      2019-01-16 19:09 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bdf10d7ca0c2

8217094: HttpClient SSL race if a socket IOException is raised before ALPN is available
Summary: The patch makes suer that the SSLFlowDelegate's ALPN CF is always completed
Reviewed-by: chegar

! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLFlowDelegate.java
! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java
! src/java.net.http/share/classes/jdk/internal/net/http/common/SubscriberWrapper.java
+ test/jdk/java/net/httpclient/ALPNFailureTest.java
+ test/jdk/java/net/httpclient/ALPNProxyFailureTest.java
! test/jdk/java/net/httpclient/DigestEchoServer.java

Changeset: 00d2660ba91b
Author:    xuelei
Date:      2019-01-16 11:19 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/00d2660ba91b

8216045: The size of key_exchange may be wrong on FFDHE
Reviewed-by: jnimeh

! src/java.base/share/classes/sun/security/ssl/DHKeyExchange.java

Changeset: 3086207c8650
Author:    mullan
Date:      2019-03-05 08:24 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3086207c8650

8217878: ENVELOPING XML signature no longer works in JDK 11
8218629: XML Digital Signature throws NAMESPACE_ERR exception on OpenJDK 11, works 8/9/10
Summary: Backout and restore previous XML signature marshalling implementation
Reviewed-by: weijun

! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java
+ src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java
! test/jdk/javax/xml/crypto/dsig/GenerationTests.java
+ test/jdk/javax/xml/crypto/dsig/data/envelope2.xml

Changeset: 3f4419405d57
Author:    mdoerr
Date:      2019-03-08 11:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3f4419405d57

8219584: Try to dump error file by thread which causes safepoint timeout
Reviewed-by: stuefe, dholmes, kvn

! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/utilities/vmError.cpp
! test/hotspot/jtreg/TEST.ROOT
+ test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java
! test/jdk/TEST.ROOT
! test/jtreg-ext/requires/VMProps.java

Changeset: a531fbd196bb
Author:    sgehwolf
Date:      2019-03-08 13:56 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a531fbd196bb

8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions
Reviewed-by: thartmann, shade

! test/hotspot/jtreg/compiler/runtime/safepoints/TestRegisterRestoring.java

Changeset: be7accf4c044
Author:    shade
Date:      2019-03-19 17:30 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/be7accf4c044

8220718: Missing ResourceMark in nmethod::metadata_do
Reviewed-by: mdoerr, zgu

! src/hotspot/share/code/nmethod.cpp

Changeset: 956096a88147
Author:    ssadetsky
Date:      2019-02-15 10:01 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/956096a88147

8218479: JTextPane display issue with GTKLookAndFeel
Reviewed-by: prr, serb

! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

Changeset: 619fc2e4250e
Author:    ssadetsky
Date:      2019-02-15 10:06 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/619fc2e4250e

8218473: JOptionPane display issue with GTKLookAndFeel
Reviewed-by: prr, serb

! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c

Changeset: fa3eed43d5fa
Author:    pbansal
Date:      2019-02-15 10:58 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/fa3eed43d5fa

8218469: JSlider display issue with slider for GTKLookAndFeel
8218470: JScrollBar display issue with GTKLookAndFeel
8218472: JProgressBar display issue with GTKLookAndFeel
8203627: Swing applications with JRadioButton and JCheckbox fail to render correctly when using GTK3 and the GTK L&F
Reviewed-by: serb, prr

! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c
! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.h

Changeset: 5acaa286c59f
Author:    pbansal
Date:      2019-03-05 13:09 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5acaa286c59f

8214253: Tooltip is transparent rather than having a black background
Reviewed-by: serb, psadhukhan

! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c

Changeset: d8055284208e
Author:    pbansal
Date:      2019-01-10 16:38 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d8055284208e

8214252: Expanded & Collapsed nodes of a JTree look the same on GTK3
Reviewed-by: serb, psadhukhan

! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c

Changeset: a1f3a677b63e
Author:    dmarkov
Date:      2019-02-26 18:12 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a1f3a677b63e

8214109: XToolkit is not correctly displayed color on 16-bit high color setting
Reviewed-by: serb, prr

! src/java.desktop/unix/classes/sun/awt/X11/XWindow.java

Changeset: 7d798bbbd870
Author:    nishjain
Date:      2018-12-03 12:35 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d798bbbd870

8213294: Upgrade IANA LSR data
Reviewed-by: naoto

! make/data/lsrdata/language-subtag-registry.txt

Changeset: f8520f3982d8
Author:    apetcher
Date:      2018-12-11 09:36 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f8520f3982d8

8208648: ECC Field Arithmetic Enhancements
Summary: interal library enhancements to support ECC implementatation
Reviewed-by: jnimeh

! src/java.base/share/classes/sun/security/util/ArrayUtil.java
! src/java.base/share/classes/sun/security/util/math/MutableIntegerModuloP.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/FieldGen.jsh
! src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial.java
! src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial1305.java
! src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial25519.java
! src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial448.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomialP256.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomialP384.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomialP521.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/P256OrderField.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/P384OrderField.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/P521OrderField.java
+ src/java.base/share/classes/sun/security/util/math/intpoly/header.txt
! test/jdk/sun/security/util/math/BigIntegerModuloP.java
! test/jdk/sun/security/util/math/TestIntegerModuloP.java

Changeset: 2f0cb96c5a8f
Author:    pbansal
Date:      2019-01-18 13:36 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2f0cb96c5a8f

8214111: There is no icon in all JOptionPane target image
Reviewed-by: serb, psadhukhan

! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

Changeset: 69b675266f36
Author:    kevinw
Date:      2019-01-31 04:49 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/69b675266f36

8209951: Problematic sparc intrinsic: com.sun.crypto.provider.CipherBlockChaining
Reviewed-by: kvn, thartmann
Contributed-by: fairoz.matte at oracle.com

! src/hotspot/cpu/sparc/stubGenerator_sparc.cpp
+ test/hotspot/jtreg/compiler/codegen/aes/TestCipherBlockChainingEncrypt.java

Changeset: bd5a1a075207
Author:    pbansal
Date:      2019-03-05 14:03 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bd5a1a075207

8214112: The whole text in target JPasswordField image are not selected
Reviewed-by: serb, psadhukhan

! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c

Changeset: e96de175ffdf
Author:    mbaesken
Date:      2019-02-20 17:29 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e96de175ffdf

8219460: ppc: adjust NativeGeneralJump::insert_unconditional to stack allocated MacroAssembler
Reviewed-by: mdoerr

! src/hotspot/cpu/ppc/nativeInst_ppc.cpp

Changeset: 9d08a9ff3e31
Author:    mbaesken
Date:      2019-02-18 09:38 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9d08a9ff3e31

8219112: name_and_sig_as_C_string usages in frame_s390 miss ResourceMark
Reviewed-by: shade, lucy

! src/hotspot/cpu/s390/frame_s390.cpp

Changeset: 1ecc2696e303
Author:    mbaesken
Date:      2019-01-09 14:46 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1ecc2696e303

8216355: missing NULL checks in libnet in interface iteration and potential resource leak in getMacAddress
Reviewed-by: clanger, rwestberg

! src/java.base/unix/native/libnet/Inet6AddressImpl.c
! src/java.base/unix/native/libnet/NetworkInterface.c

Changeset: b6a7d56a79da
Author:    pbansal
Date:      2018-12-21 11:43 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b6a7d56a79da

8215364: JavaFX crashes on Ubuntu 18.04 with Wayland while using Swing-FX interop
Reviewed-by: prr, kcr

! src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c

Changeset: 240e049e021e
Author:    goetz
Date:      2019-03-20 16:01 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/240e049e021e

Merge

! .hgtags

Changeset: 94ee5cc4e534
Author:    goetz
Date:      2019-03-21 08:31 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/94ee5cc4e534

Merge


Changeset: 4f3558358899
Author:    mbaesken
Date:      2019-01-30 09:57 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4f3558358899

8217786: Provide virtualization related info in the hs_error file on linux s390x
Reviewed-by: dholmes, stuefe

! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/linux/os_linux.hpp

Changeset: fe7205ebf226
Author:    tschatzl
Date:      2019-01-30 16:19 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/fe7205ebf226

8218060: JDK-8217786 breaks build due to remaining unused function
Summary: Remove unused function.
Reviewed-by: eosterlund

! src/hotspot/os/linux/os_linux.cpp

Changeset: 6f72ae155396
Author:    tschatzl
Date:      2019-01-30 17:02 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6f72ae155396

8218063: JDK-8218060 breaks build for S390
Summary: Reinstated function removed by JDK-8218060 and properly ifdef'ed it.
Reviewed-by: shade, eosterlund

! src/hotspot/os/linux/os_linux.cpp

Changeset: 2808dd19c481
Author:    aph
Date:      2018-11-13 11:21 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2808dd19c481

8209415: Fix JVMTI test failure HS202
Summary: Fix test for static method in exception throw handler
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp

Changeset: 3b5559109b41
Author:    coleenp
Date:      2019-03-21 10:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3b5559109b41

8210457: JVM crash in ResolvedMethodTable::add_method(Handle)
Summary: Add a function to call NSME in ResolvedMethodTable to replace deleted methods.
Reviewed-by: sspitsyn

! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/memory/universe.hpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/prims/jvmtiRedefineClasses.cpp
! src/hotspot/share/prims/resolvedMethodTable.cpp
! src/hotspot/share/prims/resolvedMethodTable.hpp
! src/java.base/share/classes/jdk/internal/misc/Unsafe.java
! test/jdk/java/lang/instrument/NamedBuffer.java
+ test/jdk/java/lang/instrument/RedefineAddDeleteMethod/DeleteMethodHandle/MethodHandleDeletedMethod.java
+ test/jdk/java/lang/instrument/RedefineAddDeleteMethod/DeleteMethodHandle/redef/Xost.java

Changeset: ea4f978b817d
Author:    aivanov
Date:      2019-02-07 13:57 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ea4f978b817d

8217263: Automate DashOffset test
Reviewed-by: prr, serb

+ test/jdk/java/awt/BasicStroke/DashOffset.java

Changeset: e8a240b57b8b
Author:    iklam
Date:      2018-10-25 11:23 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e8a240b57b8b

8212205: VM asserts after CDS archive has been unmapped
Reviewed-by: dholmes, jiangli, hseigel, stuefe

! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/metaspaceShared.hpp

Changeset: d2e560eba61b
Author:    stuefe
Date:      2018-10-18 15:56 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d2e560eba61b

8212828: (process) Provide a way for Runtime.exec to use posix_spawn on linux
Reviewed-by: alanb, rriggs
Contributed-by: david.lloyd at redhat.com

! make/launcher/Launcher-java.base.gmk
! src/java.base/unix/classes/java/lang/ProcessImpl.java
! src/java.base/unix/native/libjava/ProcessImpl_md.c
! test/jdk/java/lang/ProcessBuilder/Basic.java

Changeset: 41a10102e99e
Author:    mbaesken
Date:      2019-02-28 10:28 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/41a10102e99e

8219746: Provide virtualization related info in the hs_error file on linux ppc64 / ppc64le
Reviewed-by: dholmes, lucy, mdoerr

! src/hotspot/os/linux/os_linux.cpp

Changeset: 650a6e581819
Author:    roland
Date:      2019-02-18 17:41 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/650a6e581819

8219335: "failed: unexpected type" assert failure in ConnectionGraph::split_unique_types() with unsafe accesses
Reviewed-by: thartmann, kvn

! src/hotspot/share/opto/escape.cpp
+ test/hotspot/jtreg/compiler/unsafe/MaybeOffHeapUnsafeAccessToNewObject.java

Changeset: b5c9f0b44373
Author:    mbaesken
Date:      2018-12-21 14:42 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b5c9f0b44373

8215707: [macosx] fix pthread_getschedparam and pthread_setschedparam calls
Reviewed-by: clanger, dholmes

! src/hotspot/os/bsd/os_bsd.cpp

Changeset: d0cfc92bb8b9
Author:    dbuck
Date:      2019-03-22 09:05 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d0cfc92bb8b9

8217564: idempotent protection missing in crc32c.h
Summary: added include guard to crc32c.h
Reviewed-by: dcubed

! src/hotspot/cpu/x86/crc32c.h

Changeset: 5ad8c7615633
Author:    mbalao
Date:      2019-02-15 11:46 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5ad8c7615633

8219011: Implement MacroAssembler::warn method on AArch64
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

Changeset: 5fc5c10a6eae
Author:    adinn
Date:      2018-12-19 11:45 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5fc5c10a6eae

8209414: AArch64: method handle invocation does not respect JVMTI interp_only mode
Reviewed-by: adinn
Contributed-by: nick.gasson at arm.com

! src/hotspot/cpu/aarch64/methodHandles_aarch64.cpp

Changeset: 3ed37df2f5d8
Author:    clanger
Date:      2019-03-22 08:56 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3ed37df2f5d8

8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old!
Reviewed-by: stuefe, jjg

! test/langtools/tools/javac/modules/MOptionTest.java

Changeset: 4d24b1dc7598
Author:    aph
Date:      2019-02-15 12:10 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4d24b1dc7598

8219006: AArch64: Register corruption in slow subtype check
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

Changeset: 5ce122a0582e
Author:    goetz
Date:      2019-03-27 16:01 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5ce122a0582e

Merge

! .hgtags

Changeset: 869ed07fbf0f
Author:    roland
Date:      2019-03-12 15:42 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/869ed07fbf0f

8220374: C2: LoopStripMining doesn't strip as expected
Reviewed-by: rkennke, thartmann, mdoerr

! src/hotspot/share/opto/loopnode.cpp
+ test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java

Changeset: c481b31595b3
Author:    mbaesken
Date:      2019-03-22 09:29 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c481b31595b3

8215296: do not disable c99 on Solaris
Reviewed-by: dholmes, ihse, goetz, clanger

! make/autoconf/flags-cflags.m4

Changeset: 4b1ebc747064
Author:    rkennke
Date:      2019-03-15 09:57 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4b1ebc747064

8220714: C2 Compilation failure when accessing off-heap memory using Unsafe
Reviewed-by: vlivanov, roland

! src/hotspot/share/opto/library_call.cpp

Changeset: 6d754f2325fa
Author:    shade
Date:      2019-03-27 11:35 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6d754f2325fa

8220198: Lots of com/sun/crypto/provider/Cipher tests fail on x86_32 due to missing SHA512 stubs
Reviewed-by: kvn, thartmann

! src/hotspot/cpu/x86/vm_version_x86.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/library_call.cpp

Changeset: e38b14eaf6cb
Author:    shade
Date:      2019-03-27 11:35 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e38b14eaf6cb

8221401: java/math/BigInteger/LargeValueExceptions.java test should be disabled on 32-bit platforms
Reviewed-by: stuefe, bpb

! test/jdk/java/math/BigInteger/LargeValueExceptions.java

Changeset: 99d8f05969f7
Author:    shade
Date:      2019-03-27 11:35 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/99d8f05969f7

8221400: java/lang/String/StringRepeat.java test requests too much heap
Reviewed-by: stuefe, alanb

! test/jdk/java/lang/String/StringRepeat.java

Changeset: 4874e7a694a1
Author:    gromero
Date:      2019-03-20 16:59 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4874e7a694a1

8220794: PPC64: Fix signal handler for SIGSEGV on branch to illegal address
Reviewed-by: stuefe, goetz

! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Changeset: 9d681dbc5d5b
Author:    simonis
Date:      2019-03-26 11:51 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9d681dbc5d5b

8221083: [ppc64] Wrong oop compare in C1-generated code
Reviewed-by: mdoerr, goetz

! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp
+ test/hotspot/jtreg/compiler/codegen/TestOopCmp.java

Changeset: 387c726d22b7
Author:    simonis
Date:      2019-03-26 18:42 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/387c726d22b7

8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected"
Reviewed-by: kvn, mdoerr

! test/hotspot/jtreg/compiler/codegen/TestOopCmp.java

Changeset: 6728d04efc65
Author:    joehw
Date:      2019-04-02 07:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6728d04efc65

8207760: SAXException: Invalid UTF-16 surrogate detected: d83c ?
Summary: Properly handle unicode16 characters split across buffer chunks.
Reviewed-by: lancea, dfuchs

! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextStream.java
+ test/jaxp/javax/xml/jaxp/unittest/transform/JDK8207760.java

Changeset: e88fd2517548
Author:    kbarrett
Date:      2019-04-02 13:12 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e88fd2517548

8202353: os::readdir should use readdir instead of readdir_r
Summary: Summary: os::readdir uses POSIX readdir, drop buffer arg, fix JFR uses.
Reviewed-by: coleenp, tschatzl, bsrbnd

! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/aix/os_aix.inline.hpp
! src/hotspot/os/aix/os_perf_aix.cpp
! src/hotspot/os/aix/perfMemory_aix.cpp
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/bsd/os_bsd.inline.hpp
! src/hotspot/os/bsd/perfMemory_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/linux/os_linux.inline.hpp
! src/hotspot/os/linux/os_perf_linux.cpp
! src/hotspot/os/linux/perfMemory_linux.cpp
! src/hotspot/os/posix/os_posix.cpp
! src/hotspot/os/solaris/os_perf_solaris.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/os/solaris/os_solaris.inline.hpp
! src/hotspot/os/solaris/perfMemory_solaris.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/os/windows/os_windows.inline.hpp
! src/hotspot/os/windows/perfMemory_windows.cpp
! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp
! src/hotspot/share/runtime/os.hpp
! test/jdk/ProblemList.txt

Changeset: 713f422ed6ca
Author:    ghaug
Date:      2019-03-26 16:00 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/713f422ed6ca

8221479: Fix JFR profiling on s390
Reviewed-by: mdoerr, clanger

! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp

Changeset: 64751f2609eb
Author:    ngasson
Date:      2019-03-29 09:31 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/64751f2609eb

8220707: [TESTBUG] serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg -vmoption:-Xmx < 8g
Reviewed-by: clanger, sballal, jcbeyler

! test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java

Changeset: f7b8057430ee
Author:    bpb
Date:      2019-04-03 08:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f7b8057430ee

8202794: Native Unix code should use readdir rather than readdir_r
8207748: Fix for 8202794 breaks tier1 builds
Summary: Replace uses of readdir_r with readdir.
Reviewed-by: alanb, bsrbnd, kbarrett, darcy

! src/java.base/unix/native/libjava/TimeZone_md.c
! src/java.base/unix/native/libjava/UnixFileSystem_md.c
! src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c

Changeset: 3f987ff2aaf6
Author:    alanb
Date:      2019-04-03 09:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3f987ff2aaf6

8207340: (fs) UnixNativeDispatcher close and readdir usages should be fixed
Summary: Replace readdir_r with readdir, use RESTARTABLE for close only on aix.
Reviewed-by: bpb

! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c

Changeset: 2e7a852df177
Author:    xiaofeya
Date:      2018-08-09 15:42 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2e7a852df177

8208656: Move java/util/Calendar/CalendarTestScripts tests into OpenJDK
Reviewed-by: naoto

+ test/jdk/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/CalendarTestEngine.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/CalendarTestException.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/Exceptions.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/GregorianAdapter.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseRollDayOfWeekTestGenerator.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseRollTests.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseTests.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/README
+ test/jdk/java/util/Calendar/CalendarTestScripts/Result.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/Variable.java
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_exceptions.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_normalization.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/params/lenient.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/params/non-lenient.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_japan.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_novosibirsk.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_pst.cts
+ test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_sydney.cts

Changeset: cdb311e9a015
Author:    naoto
Date:      2018-09-25 13:57 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/cdb311e9a015

8210633: Cannot parse JapaneseDate string with DateTimeFormatterBuilder Mapped-values
Reviewed-by: scolebourne, rriggs

! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
! test/jdk/java/time/test/java/time/format/TestDateTimeFormatterBuilderWithLocale.java

Changeset: f63e72754ba7
Author:    naoto
Date:      2019-02-28 14:03 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f63e72754ba7

8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales
Reviewed-by: lancea

! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java
! test/jdk/java/util/Calendar/JapaneseEraNameTest.java

Changeset: e2cbdda3b446
Author:    andrew
Date:      2019-04-03 18:36 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e2cbdda3b446

Merge


Changeset: 952508675ebd
Author:    naoto
Date:      2019-04-03 02:25 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/952508675ebd

8205432: Replace the placeholder Japanese era name
Reviewed-by: rriggs, chegar, phh, clanger

! make/data/unicodedata/UnicodeData.txt
! src/java.base/share/classes/java/time/chrono/JapaneseEra.java
! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java
! src/java.base/share/classes/sun/text/resources/FormatData.java
! src/java.base/share/classes/sun/text/resources/JavaTimeSupplementary.java
! src/java.base/share/classes/sun/util/calendar/Era.java
! src/java.base/share/classes/sun/util/calendar/LocalGregorianCalendar.java
! src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ja.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ja.java
! src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ja.xml
! src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/root.xml
! test/jdk/java/lang/Character/UnicodeData.txt
! test/jdk/java/text/Format/DateFormat/WeekDateTest.java
! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseChronology.java
! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseEra.java
! test/jdk/java/time/test/java/time/chrono/TestJapaneseChronology.java
! test/jdk/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java
! test/jdk/java/time/test/java/time/format/TestNonIsoFormatter.java
! test/jdk/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java
! test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java
! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts
! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts
! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts
! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts
! test/jdk/java/util/Calendar/JapaneseEraNameTest.java
! test/jdk/java/util/Calendar/JapaneseLenientEraTest.java
! test/jdk/java/util/Calendar/NarrowNamesTest.java
! test/jdk/java/util/Calendar/ZoneOffsets.java

Changeset: a979b404a343
Author:    goetz
Date:      2019-04-03 15:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a979b404a343

Merge

! .hgtags
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java
! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextStream.java

Changeset: 4017ed587471
Author:    goetz
Date:      2019-04-04 09:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4017ed587471

Merge


Changeset: 38ceb89f449c
Author:    clanger
Date:      2019-03-01 10:15 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/38ceb89f449c

8219915: [TESTBUG] Fix test langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java in Standalone mode
Reviewed-by: jlahoda

! test/langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java

Changeset: 5d374228b598
Author:    shade
Date:      2019-04-04 19:58 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5d374228b598

8221870: use driver to run CtwRunner in applications/ctw tests
Reviewed-by: shade, epavlova

! test/hotspot/jtreg/applications/ctw/modules/generate.bash
! test/hotspot/jtreg/applications/ctw/modules/java_base.java
! test/hotspot/jtreg/applications/ctw/modules/java_base_2.java
! test/hotspot/jtreg/applications/ctw/modules/java_compiler.java
! test/hotspot/jtreg/applications/ctw/modules/java_datatransfer.java
! test/hotspot/jtreg/applications/ctw/modules/java_desktop.java
! test/hotspot/jtreg/applications/ctw/modules/java_desktop_2.java
! test/hotspot/jtreg/applications/ctw/modules/java_instrument.java
! test/hotspot/jtreg/applications/ctw/modules/java_logging.java
! test/hotspot/jtreg/applications/ctw/modules/java_management.java
! test/hotspot/jtreg/applications/ctw/modules/java_management_rmi.java
! test/hotspot/jtreg/applications/ctw/modules/java_naming.java
+ test/hotspot/jtreg/applications/ctw/modules/java_net_http.java
! test/hotspot/jtreg/applications/ctw/modules/java_prefs.java
! test/hotspot/jtreg/applications/ctw/modules/java_rmi.java
! test/hotspot/jtreg/applications/ctw/modules/java_scripting.java
! test/hotspot/jtreg/applications/ctw/modules/java_security_jgss.java
! test/hotspot/jtreg/applications/ctw/modules/java_security_sasl.java
! test/hotspot/jtreg/applications/ctw/modules/java_smartcardio.java
! test/hotspot/jtreg/applications/ctw/modules/java_sql.java
! test/hotspot/jtreg/applications/ctw/modules/java_sql_rowset.java
+ test/hotspot/jtreg/applications/ctw/modules/java_transaction_xa.java
! test/hotspot/jtreg/applications/ctw/modules/java_xml.java
! test/hotspot/jtreg/applications/ctw/modules/java_xml_crypto.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_accessibility.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_aot.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_attach.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_charsets.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_compiler.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_cryptoki.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_mscapi.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ucrypto.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_dynalink.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_editpad.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_hotspot_agent.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_httpserver.java
- test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_ed.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_jvmstat.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_le.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_opt.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_ci.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_compiler.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_compiler_management.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jartool.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_javadoc.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jcmd.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jconsole.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jdeps.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jdi.java
+ test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jlink.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jshell.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jsobject.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_jstatd.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_localedata.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_management.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_management_agent.java
+ test/hotspot/jtreg/applications/ctw/modules/jdk_management_jfr.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_naming_dns.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_naming_rmi.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_net.java
- test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java
- test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_rmic.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_scripting_nashorn.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_scripting_nashorn_shell.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_sctp.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_security_auth.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_security_jgss.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_unsupported.java
+ test/hotspot/jtreg/applications/ctw/modules/jdk_unsupported_desktop.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_xml_dom.java
! test/hotspot/jtreg/applications/ctw/modules/jdk_zipfs.java

Changeset: f13686e3cdad
Author:    clanger
Date:      2019-01-18 09:04 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f13686e3cdad

8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)
Reviewed-by: sgroeger, alanb, mbaesken, chegar

! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c

Changeset: 25f701d64a2f
Author:    goetz
Date:      2019-04-05 07:59 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/25f701d64a2f

8219918: ProblemList hotspot tests failing in SAP testing.
Reviewed-by: dholmes

! test/hotspot/jtreg/ProblemList.txt

Changeset: 765e95555f7d
Author:    twisti
Date:      2018-08-28 15:17 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/765e95555f7d

8210008: custom extension for make/SourceRevision.gmk
Reviewed-by: erikj

! make/SourceRevision.gmk

Changeset: 47c0aad7defb
Author:    erikj
Date:      2018-09-07 14:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/47c0aad7defb

8210283: Support git as an SCM alternative in the build
Reviewed-by: ihse, ehelin

+ .gitignore
! make/SourceRevision.gmk
! make/autoconf/basics.m4
! make/autoconf/spec.gmk.in
! make/common/MakeBase.gmk

Changeset: e6c3c14a3a48
Author:    erikj
Date:      2018-09-12 08:46 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e6c3c14a3a48

8210519: build/releaseFile/CheckSource.java failed additional sources found
Reviewed-by: mikael, dholmes, ihse

! test/jdk/build/releaseFile/CheckSource.java

Changeset: 1f01e3740bfe
Author:    clanger
Date:      2019-03-30 21:29 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1f01e3740bfe

8221610: Resurrect (legacy) JRE bundle target
Reviewed-by: erikj, azeller

! make/Bundles.gmk
! make/Main.gmk
! make/autoconf/spec.gmk.in

Changeset: ed1545a67cd7
Author:    clanger
Date:      2019-04-18 09:14 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ed1545a67cd7

Merge

! .hgtags

Changeset: 978904e76b35
Author:    mdoerr
Date:      2019-04-23 11:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/978904e76b35

8220625: tools/javac/classreader/8171132/BadConstantValue.java failed with "did not see expected error"
Reviewed-by: clanger

! test/langtools/tools/javac/classreader/8171132/BadConstantValue.java

Changeset: bfe88d507e00
Author:    mdoerr
Date:      2019-02-18 12:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bfe88d507e00

8218991: s390: Add intrinsic for GHASH algorithm
Reviewed-by: lucy, simonis

! src/hotspot/cpu/s390/stubGenerator_s390.cpp
! src/hotspot/cpu/s390/vm_version_s390.cpp

Changeset: 12cd93c30a63
Author:    mdoerr
Date:      2019-03-12 11:53 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/12cd93c30a63

8220441: [PPC64] Clobber memory effect missing for memory barriers in atomics
Reviewed-by: simonis, goetz

! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp
! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp

Changeset: a0348cb9c40e
Author:    mdoerr
Date:      2019-04-05 09:18 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a0348cb9c40e

8221833: Readability check in Symbol::is_valid not performed for some addresses
Reviewed-by: zgu, coleenp

! src/hotspot/share/runtime/os.cpp

Changeset: 20af96441b0c
Author:    pbansal
Date:      2019-04-04 12:14 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/20af96441b0c

8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour
Reviewed-by: serb, prr

! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c

Changeset: 53d58274bb8b
Author:    shade
Date:      2019-04-07 13:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/53d58274bb8b

8221917: serviceability/sa/TestPrintMdo.java fails on 32-bit platforms
Reviewed-by: cjplummer, dholmes

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/DataLayout.java

Changeset: 5a5b211016c8
Author:    shade
Date:      2019-04-07 13:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5a5b211016c8

8222032: x86_32 fails with "wrong size of mach node" on AVX-512 machine
Reviewed-by: kvn, vlivanov

! src/hotspot/cpu/x86/x86_32.ad

Changeset: 2eb4d0f91c0c
Author:    lfoltan
Date:      2019-01-29 11:56 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2eb4d0f91c0c

8216970: condy causes JVM crash
Summary: Fix issue with ConstantPool::constant_tag_at to correctly handle a condy whose return type is an array.
Reviewed-by: acorn, hseigel, jrose

! src/hotspot/share/oops/constantPool.cpp
+ test/hotspot/jtreg/runtime/condy/escapeAnalysis/TestEscapeCondy.java
+ test/hotspot/jtreg/runtime/condy/escapeAnalysis/TestEscapeThroughInvokeWithCondy$A.jasm
+ test/hotspot/jtreg/runtime/condy/escapeAnalysis/TestEscapeThroughInvokeWithCondy.jasm

Changeset: df5487678893
Author:    bulasevich
Date:      2019-02-22 17:30 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/df5487678893

8217647: JFR: recordings on 32-bit systems unreadable
Reviewed-by: egahlin
Contributed-by: boris.ulasevich at bell-sw.com, markus.gronlund at oracle.com

! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.cpp
! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointWriter.hpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetWriter.hpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkState.cpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkState.hpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp
! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.hpp
! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp
! src/hotspot/share/jfr/recorder/repository/jfrRepository.hpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp
! src/hotspot/share/jfr/writers/jfrEventWriterHost.inline.hpp
! src/hotspot/share/jfr/writers/jfrPosition.hpp
! src/hotspot/share/jfr/writers/jfrPosition.inline.hpp
! src/hotspot/share/jfr/writers/jfrStreamWriterHost.hpp
! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp
! src/hotspot/share/jfr/writers/jfrWriterHost.hpp
! src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp

Changeset: 7ec21d486b82
Author:    sherman
Date:      2018-09-18 19:44 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7ec21d486b82

8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field
Reviewed-by: bpb

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! test/jdk/jdk/nio/zipfs/ZipFSTester.java

Changeset: b729aab4ca10
Author:    amlu
Date:      2018-11-22 10:30 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b729aab4ca10

8211266: [TESTBUG] ZipFSTester.java failed intermittently in ZipFSTester.checkRead(): bound must be positive
Reviewed-by: lancea

! test/jdk/jdk/nio/zipfs/ZipFSTester.java

Changeset: 45731e89399b
Author:    clanger
Date:      2018-12-19 10:36 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/45731e89399b

8215472: (zipfs) Cleanups in implementation classes of jdk.zipfs and tests
Reviewed-by: redestad, lancea

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystemProvider.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipCoder.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipConstants.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipDirectoryStream.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileAttributeView.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileAttributes.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileStore.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipInfo.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipPath.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipUtils.java
! test/jdk/java/util/zip/zip.java

Changeset: 338118c86b93
Author:    vlivanov
Date:      2019-02-04 17:35 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/338118c86b93

8188133: C2: Static field accesses in clinit can trigger deoptimizations
Reviewed-by: kvn

! src/hotspot/share/ci/ciMethod.hpp
! src/hotspot/share/opto/bytecodeInfo.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/compile.hpp
! src/hotspot/share/opto/parse.hpp
! src/hotspot/share/opto/parse3.cpp

Changeset: b62e34cdb0fe
Author:    prr
Date:      2019-01-30 14:03 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b62e34cdb0fe

8218020: Fix version number in mesa.md 3rd party legal file
Reviewed-by: serb, psadhukhan

! src/java.desktop/share/legal/mesa3d.md

Changeset: e6a530dc3bc7
Author:    hannesw
Date:      2018-09-14 14:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e6a530dc3bc7

8209914: javadoc search sometimes generates bad URIs
Reviewed-by: jjg

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js

Changeset: a8f355ba5a7d
Author:    shade
Date:      2019-04-15 18:22 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a8f355ba5a7d

8222397: x86_32 tests with UseSHA1Intrinsics SEGV due to garbled registers
Reviewed-by: kvn, dsamersoff

! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp

Changeset: 3cdc82597319
Author:    shade
Date:      2019-04-15 18:22 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3cdc82597319

8222410: java/nio/file/attribute/BasicFileAttributeView/UnixSocketFile hangs when "nc" does not accept "-U"
Reviewed-by: alanb

! test/jdk/java/nio/file/attribute/BasicFileAttributeView/UnixSocketFile.java

Changeset: d87990ab7b2b
Author:    shade
Date:      2019-02-01 16:03 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d87990ab7b2b

8217879: hs_err should print more instructions in hex dump
Reviewed-by: stuefe, coleenp, dholmes, lucy, stefank

! src/hotspot/os_cpu/aix_ppc/os_aix_ppc.cpp
! src/hotspot/os_cpu/bsd_x86/os_bsd_x86.cpp
! src/hotspot/os_cpu/linux_aarch64/os_linux_aarch64.cpp
! src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp
! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp
! src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp
! src/hotspot/os_cpu/linux_sparc/os_linux_sparc.cpp
! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
! src/hotspot/os_cpu/solaris_sparc/os_solaris_sparc.cpp
! src/hotspot/os_cpu/solaris_x86/os_solaris_x86.cpp
! src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp

Changeset: 7f112a842f64
Author:    igerasim
Date:      2019-03-21 12:28 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7f112a842f64

8170494: JNI exception pending in PlainDatagramSocketImpl.c
Reviewed-by: clanger, vtewari

! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c

Changeset: 83a8e2e5d76e
Author:    mullan
Date:      2019-04-08 12:19 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/83a8e2e5d76e

8222089: [TESTBUG] sun/security/lib/cacerts/VerifyCACerts.java fails due to cert within 90-day expiry window
Reviewed-by: xuelei

! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: ca6708944494
Author:    mullan
Date:      2019-04-08 13:33 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ca6708944494

8222133: Add temporary exceptions for root certs that are due to expire soon
Reviewed-by: xuelei

! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 96f5b782b40a
Author:    clanger
Date:      2019-04-08 06:56 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/96f5b782b40a

8221880: Better customization for Windows RC properties FileDescription and ProductName
Reviewed-by: erikj

! make/autoconf/flags-other.m4
! make/autoconf/jdk-version.m4
! make/autoconf/spec.gmk.in

Changeset: db5c04dc87a5
Author:    clanger
Date:      2019-04-16 17:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/db5c04dc87a5

8222522: Add configure options for Mac Bundle creation
Reviewed-by: erikj

! make/autoconf/jdk-version.m4

Changeset: 1ffa9e8410e7
Author:    itakiguchi
Date:      2018-12-05 12:59 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1ffa9e8410e7

8214002: Cannot use italic font style if the font has embedded bitmap
Reviewed-by: prr

! src/java.desktop/share/native/libfontmanager/freetypeScaler.c
+ test/jdk/java/awt/font/TextLayout/FontGlyphCompare.java

Changeset: 21e3b55b05ef
Author:    mbalao
Date:      2019-03-01 12:21 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/21e3b55b05ef

8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth
Summary: Consider algorithmic bold in FontMetrics.getMaxAdvance value and update obliqueness.
Reviewed-by: prr, serb

! src/java.desktop/share/native/libfontmanager/freetypeScaler.c
+ test/jdk/java/awt/FontMetrics/MaxAdvanceIsMax.java

Changeset: ab9a99513499
Author:    prr
Date:      2019-03-21 21:37 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ab9a99513499

8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java
Reviewed-by: serb

! test/jdk/ProblemList.txt

Changeset: b2f7d11c5282
Author:    lzhai
Date:      2019-04-23 08:29 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b2f7d11c5282

8206955: MethodHandleProxies.asInterfaceInstance does not support default methods
Summary: Cache default method handles.
Reviewed-by: mchung, plevart

! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java
+ test/jdk/java/lang/invoke/MethodHandlesProxiesTest.java

Changeset: 62173baf701e
Author:    smarks
Date:      2019-04-09 09:49 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/62173baf701e

8221924: get(null) on single-entry unmodifiable Map returns null instead of throwing NPE
Reviewed-by: redestad, lancea

! src/java.base/share/classes/java/util/ImmutableCollections.java
! test/jdk/java/util/Map/MapFactories.java

Changeset: ab9db1fbc27f
Author:    mullan
Date:      2019-03-07 14:29 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ab9db1fbc27f

8218618: Program fails when using JDK addressed by UNC path and using Security Manager
Reviewed-by: weijun

! src/java.base/share/classes/sun/security/provider/PolicyFile.java

Changeset: 32cf83827c4e
Author:    itakiguchi
Date:      2019-03-15 00:49 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/32cf83827c4e

8220281: IBM-858 alias name is missing on IBM00858 charset
Summary: Add aliases into IBM charsets
Reviewed-by: naoto

! make/data/charsetmapping/charsets
! test/jdk/sun/nio/cs/TestIBMBugs.java

Changeset: b3f7a4c524f2
Author:    sgroeger
Date:      2019-04-08 15:01 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/b3f7a4c524f2

8222027: java/util/logging/LogManager/TestLoggerNames.java generates intermittent ClassCastException
Summary: Make a strong reference to TestLogger and dont fetch it from LogManager
Reviewed-by: dfuchs

! test/jdk/java/util/logging/LogManager/TestLoggerNames.java

Changeset: aa7816a7a6b0
Author:    goetz
Date:      2019-05-01 07:35 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/aa7816a7a6b0

Added tag jdk-11.0.4+1 for changeset b3f7a4c524f2

! .hgtags

Changeset: 7bb488236ac9
Author:    itakiguchi
Date:      2019-02-17 15:15 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7bb488236ac9

8212678: Windows IME related patch
Reviewed-by: serb, naoto

! src/java.desktop/windows/classes/sun/awt/windows/WInputMethod.java
! src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
! src/java.desktop/windows/native/libawt/windows/awt_InputMethod.cpp

Changeset: 6d22003f3a75
Author:    lfoltan
Date:      2018-07-16 11:34 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6d22003f3a75

8205611: Improve the wording of LinkageErrors to include module and class loader information
Summary: Clean up the wording of loader constraint violations to include the module and class loader information.
Reviewed-by: coleenp, goetz, hseigel

! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/interpreter/linkResolver.cpp
! src/hotspot/share/oops/klassVtable.cpp
! test/hotspot/jtreg/runtime/LoaderConstraints/differentLE/Test.java
! test/hotspot/jtreg/runtime/LoaderConstraints/duplicateLE/Test.java
! test/hotspot/jtreg/runtime/LoaderConstraints/duplicateParentLE/Test.java
! test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java
! test/hotspot/jtreg/runtime/LoaderConstraints/vtableLdrConstraint/Test.java

Changeset: 5d23a2e771f7
Author:    gromero
Date:      2019-05-02 18:01 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5d23a2e771f7

8223266: PPC64: Check for branch to illegal address before checking for mem serialization
Reviewed-by: goetz, mdoerr

! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Changeset: 9d0382d2027a
Author:    mdoerr
Date:      2019-01-16 10:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9d0382d2027a

8216556: Unnecessary liveness computation with JVMTI
Reviewed-by: redestad, dlong, kvn

! src/hotspot/share/ci/ciEnv.cpp
! src/hotspot/share/ci/ciEnv.hpp
! src/hotspot/share/ci/ciMethod.cpp

Changeset: 5b2edba303a6
Author:    gromero
Date:      2019-03-20 16:43 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5b2edba303a6

8221175: Fix bad function case for controlled JVM crash on PPC64 big-endian
Reviewed-by: chrisphi, stuefe, goetz

! src/hotspot/share/utilities/vmError.cpp

Changeset: 4a7e19049fb8
Author:    gromero
Date:      2019-05-06 09:53 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4a7e19049fb8

8223395: PPC64: Improve comments in the JVM signal handler to match ISA text
Reviewed-by: mdoerr

! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Changeset: c2e37b4d40f6
Author:    rhalade
Date:      2019-01-16 22:29 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c2e37b4d40f6

8216577: Add GlobalSign's R6 Root certificate
Reviewed-by: mullan, robm

! src/java.base/share/lib/security/cacerts
+ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 02d2b4656b06
Author:    avu
Date:      2018-11-14 13:52 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/02d2b4656b06

8213292: Input freezes after MacOS key-selector (press&hold) usage on macOS Mojave
Reviewed-by: serb

! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m

Changeset: f0388f64f3c3
Author:    sgehwolf
Date:      2019-04-18 13:58 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f0388f64f3c3

8221639: [i386] expand_exec_shield_cs_limit workaround is undefined code after JDK-8199717
Summary: Only perform this optimization for x86_64
Reviewed-by: dholmes, andrew

! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp

Changeset: 3040da27c3a1
Author:    jgeorge
Date:      2019-05-03 13:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3040da27c3a1

8204308: SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode
Summary: Use longs instead of ints while computing the identity hash of klass symbols
Reviewed-by: coleenp, lfoltan, jiangli, shade

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Symbol.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/Hashtable.java
! test/hotspot/jtreg/ProblemList-cds-mode.txt
! test/hotspot/jtreg/ProblemList.txt
+ test/hotspot/jtreg/serviceability/sa/CDSJMapClstats.java

Changeset: bb0627474430
Author:    lmesnik
Date:      2019-04-02 17:11 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bb0627474430

8221437: assert(java_lang_invoke_ResolvedMethodName::vmtarget(resolved_method()) == m()) failed: Should not change after link resolution
Reviewed-by: coleenp, sspitsyn

! src/hotspot/share/prims/methodHandles.cpp

Changeset: 2ea8d73a87c1
Author:    prr
Date:      2018-09-25 14:44 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2ea8d73a87c1

8210880: Remove HPKeysym.h from JDK sources
Reviewed-by: serb, dmarkov

! src/java.desktop/unix/legal/xwindows.md
- src/java.desktop/unix/native/libawt_xawt/awt/HPkeysym.h
! src/java.desktop/unix/native/libawt_xawt/xawt/XWindow.c

Changeset: 22de2f5f0795
Author:    vlivanov
Date:      2019-01-15 16:41 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/22de2f5f0795

8215757: C2: PhaseIdealLoop::create_new_if_for_predicate() computes wrong IDOM
Reviewed-by: kvn, roland

! src/hotspot/share/opto/loopPredicate.cpp

Changeset: 3b9194001c2e
Author:    neliasso
Date:      2019-03-07 22:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3b9194001c2e

8219448: split-if update_uses accesses stale idom data
Reviewed-by: thartmann, kvn

! src/hotspot/share/opto/split_if.cpp

Changeset: 7693d9f05c23
Author:    goetz
Date:      2019-05-08 07:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7693d9f05c23

Added tag jdk-11.0.4+2 for changeset 3b9194001c2e

! .hgtags

Changeset: 3908850f5027
Author:    shade
Date:      2019-05-08 19:40 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3908850f5027

Merge

! .hgtags
- make/Jprt.gmk
! make/autoconf/flags-cflags.m4
! make/autoconf/version-numbers
- make/jprt.properties
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp
! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp
! src/hotspot/cpu/x86/vm_version_x86.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/interpreter/linkResolver.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/compile.hpp
! src/hotspot/share/opto/escape.cpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/loopPredicate.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/parse.hpp
! src/hotspot/share/opto/parse3.cpp
! src/hotspot/share/opto/split_if.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/safepoint.cpp
- src/java.desktop/unix/native/libawt_xawt/awt/HPkeysym.h
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java
- src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java
- src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM964.java
- src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeap.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahHeap.java
! test/hotspot/jtreg/TEST.ROOT
! test/hotspot/jtreg/TEST.groups
- test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java
- test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java
- test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java
- test/hotspot/jtreg/jprt.config
! test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
- test/jdk/jprt.config
- test/jdk/lib/security/CheckBlacklistedCerts.java
- test/jdk/lib/security/cacerts/VerifyCACerts.java


From aoqi at loongson.cn  Thu May  9 01:06:31 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Thu, 9 May 2019 09:06:31 +0800
Subject: RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1
 and fix build when compiler1 is disabled
In-Reply-To: <7a8892d4-97cb-a8d6-0c1c-05012abf71a9@redhat.com>
References: <CALjzQn4adoa819Zu0KUsn5qaV1DVopvaeY=kKHC-EBq+GiSazQ@mail.gmail.com>
 <CALjzQn4K-Miy+=0dCD1902dm36LxiVC0txRu57oZc5cfHZrMsg@mail.gmail.com>
 <CALjzQn4cL2D1zdDA8EBCE+547xX6JQBYuC_iWRsGesAnFXbiOw@mail.gmail.com>
 <75d6106a-f162-73b6-c1c3-c622f47329fc@redhat.com>
 <CALjzQn57dTwLUQeT7CGHnhsnvfj2afnV9tZF40OfWCv9YT1ORQ@mail.gmail.com>
 <61a3211c-21c5-340b-5823-3825cba20243@redhat.com>
 <CALjzQn4BW_+ugkLX=eu-Cyd4vCjF9hH8oiUG4cs71ak40LYLGA@mail.gmail.com>
 <b08ffd49-a595-e10a-6dfd-9c23d8af99cb@redhat.com>
 <CALjzQn5P6e+KMP09h5ae_2FZ1JurzK829SuWUqbGehQstQFe+g@mail.gmail.com>
 <4cb3d53c-8990-542d-dc7b-2d70979a23b4@redhat.com>
 <CALjzQn7t3Sha48W2unwjhJSjOos18hpr0R+O-N84_WF0u+ZHHw@mail.gmail.com>
 <cfb0191d-852f-4051-d72d-95c2270c85b4@redhat.com>
 <CALjzQn7y=9JPEz0wCPCgzeEQ0X95WJqfOqx1SEypjYREfPFyYw@mail.gmail.com>
 <18f4ac22-6e90-9bcb-5cdf-73c7431afaf3@redhat.com>
 <CALjzQn45B5OWe5Nwkt-kFEEEG6FrXqUd1gL1GXkH-6z4+qV=rw@mail.gmail.com>
 <06f822d8-f5c9-3184-49cc-f6b159257670@redhat.com>
 <7a8892d4-97cb-a8d6-0c1c-05012abf71a9@redhat.com>
Message-ID: <CALjzQn4GRKsLzeLciQeqcNw5Cz5JS9nN3bwXW4y3YRmE7zpbKg@mail.gmail.com>

On Thu, May 9, 2019 at 12:10 AM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/8/19 5:10 PM, Aleksey Shipilev wrote:
> > On 5/8/19 5:02 PM, Ao Qi wrote:
> >> Agreed. Sorry for not testing that. Updated:
> >> http://cr.openjdk.java.net/~aoqi/8222926/webrev.06/
> >
> > Yup, I'll put it through some testing and push on success.
>
> Tests passed, pushed:
>   http://hg.openjdk.java.net/jdk/jdk/rev/2584e5772546

Thank you, Aleksey!

>
> -Aleksey
>

From rkennke at redhat.com  Fri May 10 09:36:32 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 10 May 2019 11:36:32 +0200
Subject: RFR: Fix mark-preserving in ShenandoahMarkCompact
Message-ID: <4550c880-1d50-8f7d-9970-908542f24f40@redhat.com>

CI found a bug in Shenandoah with eliminate-fwdptr-word applied: specjvm 
with +aggressive and +ShenandoahOOMDuringEvacALot would fail with 
mismatched locks.

The reason is that the mark-preserving in mark-compact has a few issues:
- It lacked preserving marks for humongous objects
- It lacked BiasedLocking::preserve_marks() / restore_marks()
- It used must_be_preserved() instead of 
must_be_preserved_for_promotion_failure(), the latter deals with biased 
locks a little differently (and I think correctly for our purpose).

All those issues are addressed in the patch. I switched from self-made 
mark-preserving to using gc/shared/preservedMarks.hpp which has the 
additional advantage that I don't have to resort to locking to protect 
the datastructures, and can instead use one stack per worker to record 
and restore marks.

http://cr.openjdk.java.net/~rkennke/fixpreservemark/webrev.00/

Testing: hotspot_gc_shenandoah, the failing specjvm test multiple times

Ok?

Thanks,
Roman


From zgu at redhat.com  Fri May 10 15:25:46 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 10 May 2019 11:25:46 -0400
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
Message-ID: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>

Please review this patch that allows to verify subset of roots.


Bug: https://bugs.openjdk.java.net/browse/JDK-8223215
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.00/index.html

Test:
   hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Fri May 10 15:37:33 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 10 May 2019 17:37:33 +0200
Subject: RFR: Fix mark-preserving in ShenandoahMarkCompact
In-Reply-To: <4550c880-1d50-8f7d-9970-908542f24f40@redhat.com>
References: <4550c880-1d50-8f7d-9970-908542f24f40@redhat.com>
Message-ID: <98d2805c-99fc-456c-f1da-e2b2beb8911a@redhat.com>

On 5/10/19 11:36 AM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/fixpreservemark/webrev.00/

Looks good.

Nits:

*) Let's break up long line here:

 249   ShenandoahPrepareForCompactionObjectClosure(PreservedMarks* preserved_marks,
GrowableArray<ShenandoahHeapRegion*>& empty_regions, ShenandoahHeapRegion* to_region) :

*) "heap" is already available at this point:

 835   SharedRestorePreservedMarksTaskExecutor exec(ShenandoahHeap::heap()->workers());


-Aleksey


From rkennke at redhat.com  Fri May 10 17:15:00 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Fri, 10 May 2019 17:15:00 +0000
Subject: hg: shenandoah/jdk: Fix mark-preserving in ShenandoahMarkCompact
Message-ID: <201905101715.x4AHF0FC009866@aojmv0008.oracle.com>

Changeset: 04ac51630884
Author:    rkennke
Date:      2019-05-10 11:29 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/04ac51630884

Fix mark-preserving in ShenandoahMarkCompact

! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.hpp


From rkennke at redhat.com  Fri May 10 19:12:01 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 10 May 2019 21:12:01 +0200
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
In-Reply-To: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
References: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
Message-ID: <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>

Hi Zhengyu,

this looks good.
Maybe the root-verifier code should be in its own files?
What's with the font it looks weird? ;-)

Roman

> Please review this patch that allows to verify subset of roots.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223215
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.00/index.html
> 
> Test:
> ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu


From shade at redhat.com  Fri May 10 20:10:01 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 10 May 2019 22:10:01 +0200
Subject: RFR: Simplify resolve_forwarded_pointer shape and uses
Message-ID: <937adab1-0cc0-e92e-9f28-60c8e311ff44@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/nofwdptr-simplify-rfp/webrev.01/

Compared to upstream, we need additional register in resolve_forwarded_pointer to decode the fwdptr.
This forces us to have new tmp3 register for all CAS shapes, which is not very clean, wastes
register, and also fails on x86_32 because there are not enough registers on some paths!

I suggest we make resolve_forwarded_pointer push/pop the register if needed. The only path where it
is needed is from CAS barriers, where the resolves are on slow/recovery paths anyway. LRB path just
passes the available register where possible.

The patch reverts a lot of stuff to upstream state, removing ~100 lines of difference. Notably, all
.ad changes are gone.

Testing: Linux {x86_64, aarch64} hotspot_gc_shenandoah; Linux x86_32 (ad-hoc tests that used to fail)

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Fri May 10 20:13:02 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 10 May 2019 22:13:02 +0200
Subject: RFR: Simplify resolve_forwarded_pointer shape and uses
In-Reply-To: <937adab1-0cc0-e92e-9f28-60c8e311ff44@redhat.com>
References: <937adab1-0cc0-e92e-9f28-60c8e311ff44@redhat.com>
Message-ID: <cae142a9-b7bd-38a2-51ae-296c0a755c62@redhat.com>

Very nice! Go for it!

Thank you!
Roman


> http://cr.openjdk.java.net/~shade/shenandoah/nofwdptr-simplify-rfp/webrev.01/
> 
> Compared to upstream, we need additional register in resolve_forwarded_pointer to decode the fwdptr.
> This forces us to have new tmp3 register for all CAS shapes, which is not very clean, wastes
> register, and also fails on x86_32 because there are not enough registers on some paths!
> 
> I suggest we make resolve_forwarded_pointer push/pop the register if needed. The only path where it
> is needed is from CAS barriers, where the resolves are on slow/recovery paths anyway. LRB path just
> passes the available register where possible.
> 
> The patch reverts a lot of stuff to upstream state, removing ~100 lines of difference. Notably, all
> .ad changes are gone.
> 
> Testing: Linux {x86_64, aarch64} hotspot_gc_shenandoah; Linux x86_32 (ad-hoc tests that used to fail)
> 


From zgu at redhat.com  Fri May 10 21:14:00 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 10 May 2019 17:14:00 -0400
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
In-Reply-To: <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>
References: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
 <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>
Message-ID: <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>


On 5/10/19 3:12 PM, Roman Kennke wrote:
> Hi Zhengyu,
> 
> this looks good.
> Maybe the root-verifier code should be in its own files?

Updated: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.01/

> What's with the font it looks weird? ;-)

Not sure why, default language got switched to Chinese :-)

-Zhengyu

> 
> Roman
> 
>> Please review this patch that allows to verify subset of roots.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223215
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.00/index.html
>>
>> Test:
>>  ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)
>>
>> Thanks,
>>
>> -Zhengyu
> 

From shade at redhat.com  Sat May 11 06:10:46 2019
From: shade at redhat.com (shade at redhat.com)
Date: Sat, 11 May 2019 06:10:46 +0000
Subject: hg: shenandoah/jdk: Simplify resolve_forwarded_pointer shape and uses
Message-ID: <201905110610.x4B6AkB8023149@aojmv0008.oracle.com>

Changeset: 6041f00b663f
Author:    shade
Date:      2019-05-10 21:43 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6041f00b663f

Simplify resolve_forwarded_pointer shape and uses

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp


From shade at redhat.com  Mon May 13 08:50:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 10:50:46 +0200
Subject: RFR (S) 8223759: Shenandoah should allow arbitrarily low initial heap
 size
Message-ID: <1624bd21-2f99-9009-f603-f958579df062@redhat.com>

RFE:
  https://bugs.openjdk.java.net/browse/JDK-8223759

Shenandoah heap regions checks verify that initial heap size covers at least 10 regions. This means
the lowest uncommitted size is at least 10*RegionSize, which is a lot for large heaps. This seems to
be the reminiscent of old resizing scheme, where Shenandoah could have run with "initial heap" for a
long time, before GC code decided to resize. There is little sense it in now: Shenandoah would
commit regions up to max_capacity if needed, including during the initial barrage of allocations. We
should instead check that "max" heap size covers at least 10 regions.

Patch:
  http://cr.openjdk.java.net/~shade/8223759/webrev.01/

Testing: hotspot_gc_shenandoah

-- 
Thanks,
-Aleksey



From shade at redhat.com  Mon May 13 10:30:41 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 12:30:41 +0200
Subject: RFR (S) 8223762: Shenandoah: overflows in calculations involving heap
 capacity
Message-ID: <98b79f57-cb8e-1885-d9c4-c99729ed7840@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223762

Heap capacity is in size_t. Which means expressions involving it are subject to overflow if done
without care. Consider the x86_32 case with max_capacity = 1G and ShenandoahMinFreeThreshold >= 5.
this overflows this expression here on 32-bit platforms:
   size_t min_threshold = ShenandoahMinFreeThreshold * heap->max_capacity() / 100;

This readily happens on x86_32 and wreck up heuristics calculations.

Fix:
  http://cr.openjdk.java.net/~shade/8223762/webrev.01/

Testing: hotspot_gc_shenandoah (x86_64, x86_32), plus ad-hoc x86_32 tests

-- 
Thanks,
-Aleksey



From roman at kennke.org  Mon May 13 10:33:54 2019
From: roman at kennke.org (Roman Kennke)
Date: Mon, 13 May 2019 12:33:54 +0200
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
In-Reply-To: <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>
References: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
 <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>
 <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>
Message-ID: <e5d9399c-fc1c-5a5a-f1ee-dfa21f02ff49@kennke.org>

Ok looks good.

Thanks,
Roman

> On 5/10/19 3:12 PM, Roman Kennke wrote:
>> Hi Zhengyu,
>>
>> this looks good.
>> Maybe the root-verifier code should be in its own files?
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.01/
> 
>> What's with the font it looks weird? ;-)
> 
> Not sure why, default language got switched to Chinese :-)
> 
> -Zhengyu
> 
>>
>> Roman
>>
>>> Please review this patch that allows to verify subset of roots.
>>>
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223215
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.00/index.html
>>>
>>> Test:
>>> ?? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and
>>> release)
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>
> 

From rkennke at redhat.com  Mon May 13 10:35:53 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 12:35:53 +0200
Subject: RFR (S) 8223759: Shenandoah should allow arbitrarily low initial
 heap size
In-Reply-To: <1624bd21-2f99-9009-f603-f958579df062@redhat.com>
References: <1624bd21-2f99-9009-f603-f958579df062@redhat.com>
Message-ID: <c483791c-3df6-63e9-e7c7-723da9d26b67@redhat.com>

Ok. Thanks,
Roman

> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8223759
> 
> Shenandoah heap regions checks verify that initial heap size covers at least 10 regions. This means
> the lowest uncommitted size is at least 10*RegionSize, which is a lot for large heaps. This seems to
> be the reminiscent of old resizing scheme, where Shenandoah could have run with "initial heap" for a
> long time, before GC code decided to resize. There is little sense it in now: Shenandoah would
> commit regions up to max_capacity if needed, including during the initial barrage of allocations. We
> should instead check that "max" heap size covers at least 10 regions.
> 
> Patch:
>   http://cr.openjdk.java.net/~shade/8223759/webrev.01/
> 
> Testing: hotspot_gc_shenandoah
> 


From rkennke at redhat.com  Mon May 13 10:37:34 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 12:37:34 +0200
Subject: RFR (S) 8223762: Shenandoah: overflows in calculations involving
 heap capacity
In-Reply-To: <98b79f57-cb8e-1885-d9c4-c99729ed7840@redhat.com>
References: <98b79f57-cb8e-1885-d9c4-c99729ed7840@redhat.com>
Message-ID: <648db01b-ac1d-bd4e-5784-40b90a6ab01f@redhat.com>

Looks good! Thanks!

Roman


> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8223762
> 
> Heap capacity is in size_t. Which means expressions involving it are subject to overflow if done
> without care. Consider the x86_32 case with max_capacity = 1G and ShenandoahMinFreeThreshold >= 5.
> this overflows this expression here on 32-bit platforms:
>    size_t min_threshold = ShenandoahMinFreeThreshold * heap->max_capacity() / 100;
> 
> This readily happens on x86_32 and wreck up heuristics calculations.
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8223762/webrev.01/
> 
> Testing: hotspot_gc_shenandoah (x86_64, x86_32), plus ad-hoc x86_32 tests
> 


From shade at redhat.com  Mon May 13 10:39:43 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 12:39:43 +0200
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
In-Reply-To: <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>
References: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
 <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>
 <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>
Message-ID: <596c24c0-95fc-e593-26a5-2bcb498223c4@redhat.com>

On 5/10/19 11:14 PM, Zhengyu Gu wrote:
> 
> On 5/10/19 3:12 PM, Roman Kennke wrote:
>> Hi Zhengyu,
>>
>> this looks good.
>> Maybe the root-verifier code should be in its own files?
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.01/

Stylistic nits:

*) New line is missing here in shenandoahRootVerifier.cpp?

  54   }
  55   if (verify(CLDGRoots)) {

*) You sure uint is not too narrow here? I think it's fine, but maybe casting through uintptr_t is
safer?

  42 void ShenandoahRootVerifier::excludes(RootTypes types) {
  43   _types = static_cast<ShenandoahRootVerifier::RootTypes>(static_cast<uint>(_types) &
(~static_cast<uint>(types)));
  44 }


-Aleksey


From zgu at redhat.com  Mon May 13 12:43:07 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 13 May 2019 08:43:07 -0400
Subject: RFR(XS) 8223215: Shenandoah: Support verifying subset of roots
In-Reply-To: <596c24c0-95fc-e593-26a5-2bcb498223c4@redhat.com>
References: <d230f7e0-548c-327a-2ea7-8696a3838c5f@redhat.com>
 <255952db-976e-fa5e-a847-cb92cc049a4a@redhat.com>
 <53165b5d-1303-9178-a1a6-34062203f2ad@redhat.com>
 <596c24c0-95fc-e593-26a5-2bcb498223c4@redhat.com>
Message-ID: <9c2b67ac-fa03-93fe-650f-be3faded7625@redhat.com>

Hi Aleksey,

On 5/13/19 6:39 AM, Aleksey Shipilev wrote:
> On 5/10/19 11:14 PM, Zhengyu Gu wrote:
>>
>> On 5/10/19 3:12 PM, Roman Kennke wrote:
>>> Hi Zhengyu,
>>>
>>> this looks good.
>>> Maybe the root-verifier code should be in its own files?
>>
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223215/webrev.01/
> 
> Stylistic nits:
> 
> *) New line is missing here in shenandoahRootVerifier.cpp?
> 
>    54   }
>    55   if (verify(CLDGRoots)) {

Fixed.
> 
> *) You sure uint is not too narrow here? I think it's fine, but maybe casting through uintptr_t is
> safer?
> 
>    42 void ShenandoahRootVerifier::excludes(RootTypes types) {
>    43   _types = static_cast<ShenandoahRootVerifier::RootTypes>(static_cast<uint>(_types) &
> (~static_cast<uint>(types)));
>    44 }
> 

Change to uintptr_t won't do any good for newly supported 32-bit 
platforms :-) Added STATIC_ASSERT instead.

--- a/src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp 
Mon May 13 08:14:19 2019 -0400
+++ b/src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp 
Mon May 13 08:29:56 2019 -0400
@@ -36,6 +36,10 @@
  #include "memory/universe.hpp"
  #include "runtime/thread.hpp"
  #include "services/management.hpp"
+#include "utilities/debug.hpp"
+
+// Check for overflow of number of root types.
+STATIC_ASSERT((static_cast<uint>(ShenandoahRootVerifier::AllRoots) + 1) 
 > static_cast<uint>(ShenandoahRootVerifier::AllRoots));


Thanks,

-Zhengyu






> 
> -Aleksey
> 

From shade at redhat.com  Mon May 13 14:38:23 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 16:38:23 +0200
Subject: RFR: Improve C2 no-fwdptr codegen: assume object is forwarded, avoid
 long immediate
Message-ID: <665fc277-8f51-4127-912d-1bedb38c075b@redhat.com>

Continuing to meditate over no-fwdptr generated code. Two wrinkles are there: a) we better assume
that the object is forwarded, this is likely because obj is evacuated once; b) avoid long immediate
0xfff...fc, instead use the already available bits. Both these things seem to cut out about 5..7
bytes from LRB midpath.

diff -r 6041f00b663f src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
--- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp  Fri May 10 21:43:07 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp  Mon May 13 16:30:38 2019 +0200
@@ -1521,19 +1521,20 @@

     // Only branch to LRB stub if object is not forwarded; otherwise reply with fwd ptr
     Node* bol = new BoolNode(cmp, BoolTest::eq); // Equals 3 means it's forwarded
     phase->register_new_node(bol, ctrl);

-    IfNode* iff = new IfNode(ctrl, bol, PROB_UNLIKELY(0.999), COUNT_UNKNOWN);
+    IfNode* iff = new IfNode(ctrl, bol, PROB_LIKELY(0.999), COUNT_UNKNOWN);
     phase->register_control(iff, loop, ctrl);
     Node* if_fwd = new IfTrueNode(iff);
     phase->register_control(if_fwd, loop, iff);
     Node* if_not_fwd = new IfFalseNode(iff);
     phase->register_control(if_not_fwd, loop, iff);

-    // Decode forward pointer.
-    Node* masked2 = new AndXNode(markword, phase->igvn().MakeConX(~markOopDesc::lock_mask_in_place));
+    // Decode forward pointer: since we already have the lowest bits, we can just subtract them
+    // from the mark word without the need for large immediate mask.
+    Node* masked2 = new SubXNode(markword, masked);
     phase->register_new_node(masked2, if_fwd);
     Node* fwdraw = new CastX2PNode(masked2);
     fwdraw->init_req(0, if_fwd);
     phase->register_new_node(fwdraw, if_fwd);
     Node* fwd = new CheckCastPPNode(NULL, fwdraw, val->bottom_type());

Testing: hotspot_gc_shenandoah x86_64

--
Thanks,
-Aleksey


From rkennke at redhat.com  Mon May 13 14:51:12 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 16:51:12 +0200
Subject: RFR: Improve C2 no-fwdptr codegen: assume object is forwarded,
 avoid long immediate
In-Reply-To: <665fc277-8f51-4127-912d-1bedb38c075b@redhat.com>
References: <665fc277-8f51-4127-912d-1bedb38c075b@redhat.com>
Message-ID: <99aa3e8e-418e-74e2-05db-ca7e3bcdb5ac@redhat.com>

Yes that seems good.

However, what I'm really asking myself is if we shouldn't just generate
the same inversion-based path that we do in assembly. And optimize the
asm path too (see comments below):

  Label done;
  __ movptr(tmp, Address(dst, oopDesc::mark_offset_in_bytes()));
  // Is the an instruction that only inverts the lowest N bits while
leaving the upper alone?
  __ notptr(tmp);
  __ testb(tmp, markOopDesc::marked_value);
  __ jccb(Assembler::notZero, done);
  // Should also be possible via orb(..)
  __ orptr(tmp, markOopDesc::marked_value);
  // See above?
  __ notptr(tmp);
  __ mov(dst, tmp);
  __ bind(done);

It avoids the extra reg for the immediates altogether, and uses
byte-sized-ops in most/all cases.

What do you think?

Roman

> Continuing to meditate over no-fwdptr generated code. Two wrinkles are there: a) we better assume
> that the object is forwarded, this is likely because obj is evacuated once; b) avoid long immediate
> 0xfff...fc, instead use the already available bits. Both these things seem to cut out about 5..7
> bytes from LRB midpath.
> 
> diff -r 6041f00b663f src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
> --- a/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp  Fri May 10 21:43:07 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp  Mon May 13 16:30:38 2019 +0200
> @@ -1521,19 +1521,20 @@
> 
>      // Only branch to LRB stub if object is not forwarded; otherwise reply with fwd ptr
>      Node* bol = new BoolNode(cmp, BoolTest::eq); // Equals 3 means it's forwarded
>      phase->register_new_node(bol, ctrl);
> 
> -    IfNode* iff = new IfNode(ctrl, bol, PROB_UNLIKELY(0.999), COUNT_UNKNOWN);
> +    IfNode* iff = new IfNode(ctrl, bol, PROB_LIKELY(0.999), COUNT_UNKNOWN);
>      phase->register_control(iff, loop, ctrl);
>      Node* if_fwd = new IfTrueNode(iff);
>      phase->register_control(if_fwd, loop, iff);
>      Node* if_not_fwd = new IfFalseNode(iff);
>      phase->register_control(if_not_fwd, loop, iff);
> 
> -    // Decode forward pointer.
> -    Node* masked2 = new AndXNode(markword, phase->igvn().MakeConX(~markOopDesc::lock_mask_in_place));
> +    // Decode forward pointer: since we already have the lowest bits, we can just subtract them
> +    // from the mark word without the need for large immediate mask.
> +    Node* masked2 = new SubXNode(markword, masked);
>      phase->register_new_node(masked2, if_fwd);
>      Node* fwdraw = new CastX2PNode(masked2);
>      fwdraw->init_req(0, if_fwd);
>      phase->register_new_node(fwdraw, if_fwd);
>      Node* fwd = new CheckCastPPNode(NULL, fwdraw, val->bottom_type());
> 
> Testing: hotspot_gc_shenandoah x86_64
> 
> --
> Thanks,
> -Aleksey
> 


From zgu at redhat.com  Mon May 13 15:00:48 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 13 May 2019 11:00:48 -0400
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and family
Message-ID: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>

I would like to refactor ShenandoahRootProcessor and family, because it 
is bit hard to track and reason the combinations of incoming parameters, 
and combinations are likely to increase when moving more processing to 
concurrent phases.

Also, fixed a traversal bug that did not do 
StringDedup::gc_prologue()/gc_epilogue() in 
ShenandoahInitTraversalCollectionTask, bug showed up with refactored code.

The refacoring removed some verification assertions, but we now have 
equivalent functionality in verifier.

Bug: https://bugs.openjdk.java.net/browse/JDK-8223774
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.00/index.html

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From rkennke at redhat.com  Mon May 13 15:34:13 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 17:34:13 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
Message-ID: <d904fec2-9ea1-6635-eb51-a6d59b8f24c6@redhat.com>

The webrev lists both:

rev 54809 : 8223215: Shenandoah: Support verifying subset of roots
rev 54810 : 8223774: Shenandoah: Refactor ShenandoahRootProcessor and family

Not a big deal though.

The templatization of ShenandoahRootUpdater... wouldn't it make sense to
also do this for the other root iterators? Right now, the interesting
stuff e.g. Thread::oops_do() is not templatized, but I suspect it would
benefit if it did, and avoid virtual calls in the thread scanning code.

Other than that, looks good to me. Let Aleksey also have a look.

Roman


> I would like to refactor ShenandoahRootProcessor and family, because it
> is bit hard to track and reason the combinations of incoming parameters,
> and combinations are likely to increase when moving more processing to
> concurrent phases.
> 
> Also, fixed a traversal bug that did not do
> StringDedup::gc_prologue()/gc_epilogue() in
> ShenandoahInitTraversalCollectionTask, bug showed up with refactored code.
> 
> The refacoring removed some verification assertions, but we now have
> equivalent functionality in verifier.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223774
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.00/index.html
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu


From boris.ulasevich at bell-sw.com  Mon May 13 15:27:37 2019
From: boris.ulasevich at bell-sw.com (Boris Ulasevich)
Date: Mon, 13 May 2019 18:27:37 +0300
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
Message-ID: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>

Hi all,

Please review a set of simple changes to satisfy Oracle Solaris Studio 
12.4 which complains about last comma in enums, private access specifier 
for the given enum used outside, and finds names conflict between 
function parameter and struct field names.

http://bugs.openjdk.java.net/browse/JDK-8223767
http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00

With the given change release and fastdebug builds are Ok, and 
hotspot_gc_shenandoah tests works good.

thanks,
Boris

From shade at redhat.com  Mon May 13 15:43:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 17:43:49 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
Message-ID: <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>

On 5/13/19 5:27 PM, Boris Ulasevich wrote:
> http://bugs.openjdk.java.net/browse/JDK-8223767
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00

Thank you, this looks good.

-Aleksey


From rkennke at redhat.com  Mon May 13 16:05:49 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 18:05:49 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
Message-ID: <a11b82dd-1f42-0e48-0213-5b1d2b71e8a8@redhat.com>

> Please review a set of simple changes to satisfy Oracle Solaris Studio
> 12.4 which complains about last comma in enums, private access specifier
> for the given enum used outside, and finds names conflict between
> function parameter and struct field names.
> 
> http://bugs.openjdk.java.net/browse/JDK-8223767
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
> 
> With the given change release and fastdebug builds are Ok, and
> hotspot_gc_shenandoah tests works good.

Looks good to me! Thank you!!
Roman


From shade at redhat.com  Mon May 13 16:41:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 18:41:37 +0200
Subject: RFR: Improve C2 no-fwdptr codegen: assume object is forwarded,
 avoid long immediate
In-Reply-To: <99aa3e8e-418e-74e2-05db-ca7e3bcdb5ac@redhat.com>
References: <665fc277-8f51-4127-912d-1bedb38c075b@redhat.com>
 <99aa3e8e-418e-74e2-05db-ca7e3bcdb5ac@redhat.com>
Message-ID: <5686cfb1-6395-4c2c-f2e9-3d024e926234@redhat.com>

On 5/13/19 4:51 PM, Roman Kennke wrote:
> What do you think?

Right. I can try to make C2 do this, but that is not guaranteed to work the way we want due to
register alloc quirks. Current C2 code (with this patch) does this;

----- LRB midpath
----- Check in-cset
         ???  0x00007f9140437320: mov    %rax,%r10
          ??  0x00007f9140437323: shr    $0x17,%r10
          ??  0x00007f9140437327: cmpb   $0x0,(%rbx,%r10,1)
          ??  0x00007f914043732c: je     0x00007f91404372f8
----- Null-check
           ?  0x00007f914043732e: test   %r11d,%r11d
           ?  0x00007f9140437331: je     0x00007f91404373ae
----- Decode fwdptr
           ?  0x00007f9140437333: lea    (%r12,%r11,8),%rdi
           ?  0x00007f9140437337: mov    (%rdi),%r10
           ?  0x00007f914043733a: mov    %r10,%r11
           ?  0x00007f914043733d: and    $0x3,%r11
           ?  0x00007f9140437341: mov    %r10,%rax
           ?  0x00007f9140437344: mov    %r11,%r10
           ?  0x00007f9140437347: neg    %r10
           ?  0x00007f914043734a: add    %r10,%rax     // rax = mw - (mw & 0x3) [clean ptr]
           ?  0x00007f914043734d: cmp    $0x3,%r11     // if (mw & 0x3) == 0x3
           ?  0x00007f9140437351: je     0x00007f91404372f8
----- Slow path
              0x00007f9140437353: movabs $0x7f9158175cd0,%r10
              0x00007f914043735d: callq  *%r10

...which I think is quite good already. We can certainly try to improve it further.

-Aleksey


From shade at redhat.com  Mon May 13 16:58:01 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 13 May 2019 16:58:01 +0000
Subject: hg: shenandoah/jdk: Improve C2 no-fwdptr codegen: assume object is
 forwarded, avoid long immediate
Message-ID: <201905131658.x4DGw1fb009581@aojmv0008.oracle.com>

Changeset: c6b8918d6ca0
Author:    shade
Date:      2019-05-13 16:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c6b8918d6ca0

Improve C2 no-fwdptr codegen: assume object is forwarded, avoid long immediate

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp


From rkennke at redhat.com  Mon May 13 17:05:43 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 13 May 2019 19:05:43 +0200
Subject: RFR: Improve C2 no-fwdptr codegen: assume object is forwarded,
 avoid long immediate
In-Reply-To: <5686cfb1-6395-4c2c-f2e9-3d024e926234@redhat.com>
References: <665fc277-8f51-4127-912d-1bedb38c075b@redhat.com>
 <99aa3e8e-418e-74e2-05db-ca7e3bcdb5ac@redhat.com>
 <5686cfb1-6395-4c2c-f2e9-3d024e926234@redhat.com>
Message-ID: <D60133F9-82FF-4828-999C-ACAF3C444F6A@redhat.com>

OK let's do this, then see if it makes sense to take further. Thanks!
Roman


Am 13. Mai 2019 18:41:37 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>On 5/13/19 4:51 PM, Roman Kennke wrote:
>> What do you think?
>
>Right. I can try to make C2 do this, but that is not guaranteed to work
>the way we want due to
>register alloc quirks. Current C2 code (with this patch) does this;
>
>----- LRB midpath
>----- Check in-cset
>         ???  0x00007f9140437320: mov    %rax,%r10
>          ??  0x00007f9140437323: shr    $0x17,%r10
>          ??  0x00007f9140437327: cmpb   $0x0,(%rbx,%r10,1)
>          ??  0x00007f914043732c: je     0x00007f91404372f8
>----- Null-check
>           ?  0x00007f914043732e: test   %r11d,%r11d
>           ?  0x00007f9140437331: je     0x00007f91404373ae
>----- Decode fwdptr
>           ?  0x00007f9140437333: lea    (%r12,%r11,8),%rdi
>           ?  0x00007f9140437337: mov    (%rdi),%r10
>           ?  0x00007f914043733a: mov    %r10,%r11
>           ?  0x00007f914043733d: and    $0x3,%r11
>           ?  0x00007f9140437341: mov    %r10,%rax
>           ?  0x00007f9140437344: mov    %r11,%r10
>           ?  0x00007f9140437347: neg    %r10
>?  0x00007f914043734a: add    %r10,%rax     // rax = mw - (mw & 0x3)
>[clean ptr]
>    ?  0x00007f914043734d: cmp    $0x3,%r11     // if (mw & 0x3) == 0x3
>           ?  0x00007f9140437351: je     0x00007f91404372f8
>----- Slow path
>              0x00007f9140437353: movabs $0x7f9158175cd0,%r10
>              0x00007f914043735d: callq  *%r10
>
>...which I think is quite good already. We can certainly try to improve
>it further.
>
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Ger?t mit K-9 Mail gesendet.

From gnu.andrew at redhat.com  Mon May 13 18:06:53 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Mon, 13 May 2019 19:06:53 +0100
Subject: [RFR] [8u] 8u222-b01 Upstream Sync
Message-ID: <4f38f4af-47a5-b3ec-9a2f-04b4efb6fa11@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u222-b01:
  - S8022879: TEST_BUG: sun/nio/cs/MalformedSurrogates.java fails
intermittently
  - S8025209: Intermittent test failure
java/net/Socket/asyncClose/AsyncClose.java
  - S8030690: TEST_BUG java/nio/Buffer/Chars.java fails intermittently
  - S8031113: TEST_BUG:
java/nio/channels/AsynchronousChannelGroup/Basic.java fails intermittently
  - S8031563: TEST_BUG:
java/nio/channels/Selector/ChangingInterests.java failed once
  - S8031666: TEST_BUG: java/net/ipv6tests/UdpTest.java failed because
of SocketTimeoutException
  - S8048782: OpenJDK: PiscesCache : xmax/ymax rounding up can cause
RasterFormatException
  - S8055814: [TESTBUG] runtime/NMT/NMTWithCDS.java fails with product
builds due to missing UnlockDiagnosticVMOptions
  - S8073078: java/nio/file/FileStore/Basic.java sensitive to NFS
configuration
  - S8129988: JSSE should create a single instance of the cacerts KeyStore
  - S8137231: sun/security/rsa/SpecTest.java timeout with Agent error:
java.lang.Exception
  - S8150013: ParNew: Prune nmethods scavengable list.
  - S8151225: Mark SpecTest.java as intermittently failing
  - S8154156: PPC64: improve array copy stubs by using vector instructions
  - S8156035: Remove intermittent key from sun/security/rsa/SpecTest.java
  - S8157287: java/nio/file/FileStore/Basic.java failed with
"java.nio.file.AccessDeniedException : /zones/zoneone/root "
  - S8171000: Robot.createScreenCapture() crashes in wayland mode
  - S8192854: FONTCONFIG_CFLAGS missing from spec.gmk.in
  - S8197546: Fix for 8171000 breaks Solaris + Linux builds
  - S8202768: [macos] Appkit thread slows when any Window Manager active
  - S8203627: Swing applications with JRadioButton and JCheckbox fail to
render correctly when using GTK3 and the GTK L&F
  - S8205916: [test] Fix jdk/tools/launcher/RunpathTest to handle both,
RPATH and RUNPATH
  - S8206955: MethodHandleProxies.asInterfaceInstance does not support
default methods
  - S8207760: SAXException: Invalid UTF-16 surrogate detected: d83c ?
  - S8209951: Problematic sparc intrinsic:
com.sun.crypto.provider.CipherBlockChaining
  - S8210633: Cannot parse JapaneseDate string with
DateTimeFormatterBuilder Mapped-values
  - S8213825: assert(false) failed: Non-balanced monitor enter/exit!
Likely JNI locking
  - S8214109: XToolkit is not correctly displayed color on 16-bit high
color setting
  - S8214111: There is no icon in all JOptionPane target image
  - S8214112: The whole text in target JPasswordField image are not selected
  - S8214252: Expanded & Collapsed nodes of a JTree look the same on GTK3
  - S8214253: Tooltip is transparent rather than having a black background
  - S8217263: Automate DashOffset test
  - S8217597: [TESTBUG] old version docker does not support --cpus
  - S8218469: JSlider display issue with slider for GTKLookAndFeel
  - S8218470: JScrollBar display issue with GTKLookAndFeel
  - S8218472: JProgressBar display issue with GTKLookAndFeel
  - S8218473: JOptionPane display issue with GTKLookAndFeel
  - S8218479: JTextPane display issue with GTKLookAndFeel
  - S8220349: The fix done for JDK-8214253 have caused issues in JTree
behaviour
  - S8220718: Missing ResourceMark in nmethod::metadata_do
  - S8221789: make reconfigure broken (jdk8u only)
  - S8222965: Backport of JDK-8129988 broke the build
  - S8222975: Fix 'release' file to reflect actual repo checkin used to
compile JDK

(I've omitted the Japanese era changes & 8221355 which were already
imported from jdk8u212-ga)

diffstat for corba
 b/.hgtags |    3 +++
 1 file changed, 3 insertions(+)
diffstat for hotspot
 b/.hgtags                                                        |    3
 b/src/cpu/ppc/vm/assembler_ppc.hpp                               |   27 +
 b/src/cpu/ppc/vm/assembler_ppc.inline.hpp                        |   12
 b/src/cpu/ppc/vm/globals_ppc.hpp                                 |   17 +
 b/src/cpu/ppc/vm/register_ppc.cpp                                |   15 -
 b/src/cpu/ppc/vm/register_ppc.hpp                                |  104
+++++++
 b/src/cpu/ppc/vm/stubGenerator_ppc.cpp                           |   80
++++-
 b/src/cpu/ppc/vm/vm_version_ppc.cpp                              |  104
++++++-
 b/src/cpu/ppc/vm/vm_version_ppc.hpp                              |   17 +
 b/src/cpu/sparc/vm/stubGenerator_sparc.cpp                       |    4
 b/src/share/vm/code/codeCache.cpp                                |   58
++--
 b/src/share/vm/code/codeCache.hpp                                |   16 -
 b/src/share/vm/code/nmethod.cpp                                  |    2
 b/src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp |    8
 b/src/share/vm/memory/genCollectedHeap.cpp                       |    6
 b/src/share/vm/memory/genCollectedHeap.hpp                       |    4
 b/src/share/vm/memory/iterator.hpp                               |    5
 b/src/share/vm/opto/memnode.cpp                                  |    6
 b/test/compiler/8209951/TestCipherBlockChainingEncrypt.java      |  136
++++++++++
 b/test/runtime/NMT/NMTWithCDS.java                               |    5
 b/test/runtime/containers/docker/TestCPUAwareness.java           |    5
 21 files changed, 550 insertions(+), 84 deletions(-)
diffstat for jaxp
 b/.hgtags                                                          |    3
 b/src/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java |   23
 b/src/com/sun/org/apache/xml/internal/serializer/ToStream.java     |
248 +++++-----
 b/src/com/sun/org/apache/xml/internal/serializer/ToTextStream.java |   39 -
 4 files changed, 167 insertions(+), 146 deletions(-)
diffstat for jaxws
 b/.hgtags |    3 +++
 1 file changed, 3 insertions(+)
diffstat for jdk
 b/.hgtags
                |    3
 b/src/macosx/native/sun/awt/JavaComponentAccessibility.m
                |   17
 b/src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
                |   40 -
 b/src/share/classes/java/lang/invoke/MethodHandleProxies.java
                |   56 +
 b/src/share/classes/java/util/JapaneseImperialCalendar.java
                |   20
 b/src/share/classes/sun/java2d/pisces/PiscesCache.java
                |    9
 b/src/share/classes/sun/java2d/pisces/PiscesTileGenerator.java
                |    5
 b/src/share/classes/sun/security/ssl/SSLContextImpl.java
                |   18
 b/src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java
                |  146 ---
 b/src/share/classes/sun/security/ssl/TrustStoreManager.java
                |  395 ++++++++++
 b/src/share/classes/sun/security/ssl/X509TrustManagerImpl.java
                |   54 -
 b/src/share/classes/sun/security/validator/TrustStoreUtil.java
                |   77 -
 b/src/share/classes/sun/security/validator/Validator.java
                |    4
 b/src/share/classes/sun/util/calendar/Era.java
                |   17
 b/src/solaris/classes/sun/awt/X11/XWindow.java
                |    9
 b/src/solaris/native/sun/awt/gtk3_interface.c
                |  233 ++++-
 b/src/solaris/native/sun/awt/gtk3_interface.h
                |   15
 b/src/solaris/native/sun/awt/multiVis.c
                |   93 --
 b/test/java/awt/BasicStroke/DashOffset.java
                |  239 ++++++
 b/test/java/lang/invoke/MethodHandlesProxiesTest.java
                |  102 ++
 b/test/java/net/Socket/asyncClose/AsyncClose.java
                |   33
 b/test/java/net/Socket/asyncClose/AsyncCloseTest.java
                |   19
 b/test/java/net/Socket/asyncClose/DatagramSocket_receive.java
                |   72 -
 b/test/java/net/Socket/asyncClose/ServerSocket_accept.java
                |   48 -
 b/test/java/net/Socket/asyncClose/Socket_getInputStream_read.java
                |   78 -
 b/test/java/net/Socket/asyncClose/Socket_getOutputStream_write.java
                |   62 -
 b/test/java/net/ipv6tests/UdpTest.java
                |    3
 b/test/java/nio/Buffer/Chars.java
                |    4
 b/test/java/nio/channels/AsynchronousChannelGroup/Basic.java
                |   34
 b/test/java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java
                |    2
 b/test/java/nio/channels/AsynchronousChannelGroup/Restart.java
                |    2
 b/test/java/nio/channels/Selector/ChangingInterests.java
                |    2
 b/test/java/nio/file/FileStore/Basic.java
                |   20
 b/test/java/time/test/java/time/chrono/TestJapaneseChronology.java
                |    2
 b/test/javax/accessibility/SlowPanelIteration/SlowPanelIteration.java
                |  107 ++
 b/test/javax/xml/jaxp/transform/8207760/JDK8207760.java
                |  171 ++++
 b/test/sun/java2d/pisces/OpenJDKFillBug.java
                |  173 ++++
 b/test/sun/nio/cs/MalformedSurrogates.java
                |  162 ++--
 b/test/sun/security/rsa/SpecTest.java
                |   84 --
 b/test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/BadTSProvider.java |   21
 b/test/sun/security/validator/EndEntityExtensionCheck.java
                |    6
 b/test/tools/launcher/RunpathTest.java
                |    6
 42 files changed, 1999 insertions(+), 664 deletions(-)
diffstat for langtools
 b/.hgtags |    3 +++
 1 file changed, 3 insertions(+)
diffstat for nashorn
 b/.hgtags |    3 +++
 1 file changed, 3 insertions(+)
diffstat for root
 b/.hgtags                     |    3 +++
 b/common/autoconf/spec.gmk.in |    1 +
 b/make/Main.gmk               |    2 +-
 b/make/common/MakeBase.gmk    |   10 +++++-----
 4 files changed, 10 insertions(+), 6 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Mon May 13 18:19:05 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 13 May 2019 20:19:05 +0200
Subject: [RFR] [8u] 8u222-b01 Upstream Sync
In-Reply-To: <4f38f4af-47a5-b3ec-9a2f-04b4efb6fa11@redhat.com>
References: <4f38f4af-47a5-b3ec-9a2f-04b4efb6fa11@redhat.com>
Message-ID: <ff07dbfd-8d84-4723-2376-76b9761d8618@redhat.com>

On 5/13/19 8:06 PM, Andrew John Hughes wrote:
> Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b01/

corba: trivially good.
jaxws: trivially good.
langtools: trivially good.
nashorn: trivially good.

root: looks good.
jaxp: looks good.
jdk: looks good.
hotspot: looks good.

Thumbs up!

Once you push, webrevs against upstream would regenerate here, and we can double-check:
  https://builds.shipilev.net/patch-openjdk-jdk8-redhat/

-Aleksey


From boris.ulasevich at bell-sw.com  Tue May 14 04:39:01 2019
From: boris.ulasevich at bell-sw.com (Boris Ulasevich)
Date: Tue, 14 May 2019 07:39:01 +0300
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
Message-ID: <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>

Thanks for the review!

13.05.2019 18:43, Aleksey Shipilev:
> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>> http://bugs.openjdk.java.net/browse/JDK-8223767
>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
> Thank you, this looks good.
>
> -Aleksey

From rkennke at redhat.com  Tue May 14 07:27:24 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 09:27:24 +0200
Subject: RFR: sh/jdk8 backport of JDK-8217016: Shenandoah: Streamline
 generation of CAS barriers
Message-ID: <5c7e83a6-c033-b5b1-e601-f2803b435892@redhat.com>

Now that we re-seeded sh/jdk8, we can finally resume backporting jdk8
fixes. :-)

This backports the streamlining of CAS barriers and related fix to jdk8.

Since much of it was shuffling around of the GC interfaces, which we
don't have in 8, I focused on getting the actual implementation to be
the same as in 11.

Curiously, there was nothing to do for x86. We probably ran in circle
with the cmpxchg_oop_shenandoah stuff :-)

The aarch64 cmpxchg_oop_shenandoah is now equivalent to the jdk11 impl.

http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-14/webrev.00/

Testing: hotspot_gc_shenandoah ok

Good to push?

Roman



From shade at redhat.com  Tue May 14 07:36:18 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 09:36:18 +0200
Subject: RFR: sh/jdk8 backport of JDK-8217016: Shenandoah: Streamline
 generation of CAS barriers
In-Reply-To: <5c7e83a6-c033-b5b1-e601-f2803b435892@redhat.com>
References: <5c7e83a6-c033-b5b1-e601-f2803b435892@redhat.com>
Message-ID: <008a91b0-3229-17c2-c130-0b2f8ba18edc@redhat.com>

On 5/14/19 9:27 AM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-14/webrev.00/

*) Closing parenthesis is missing here in MacroAssembler::cmpxchg_oop_shenandoah:

2260   // Check if rb(expected)==rb(tmp1

Otherwise good.

-Aleksey


From rkennke at redhat.com  Tue May 14 07:56:52 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Tue, 14 May 2019 07:56:52 +0000
Subject: hg: shenandoah/jdk8/hotspot: 2 new changesets
Message-ID: <201905140756.x4E7uqKp019004@aojmv0008.oracle.com>

Changeset: 71a266dc7a71
Author:    rkennke
Date:      2019-05-14 08:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/71a266dc7a71

[backport] 8217016: Shenandoah: Streamline generation of CAS barriers
Reviewed-by: roland

! src/cpu/aarch64/vm/aarch64.ad
! src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp
! src/cpu/aarch64/vm/macroAssembler_aarch64.cpp
! src/cpu/aarch64/vm/macroAssembler_aarch64.hpp

Changeset: 01e96891c861
Author:    rkennke
Date:      2019-05-14 09:56 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/01e96891c861

[backport] 8217874: Shenandoah: Clobbered register in ShenandoahBarrierSetAssembler::cmpxchg_oop()
Reviewed-by: adinn

! src/cpu/aarch64/vm/macroAssembler_aarch64.cpp


From shade at redhat.com  Tue May 14 09:09:18 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 11:09:18 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
Message-ID: <9d14f592-9866-8b16-9600-37868e4b2407@redhat.com>

Feel free to push it to jdk/jdk, whenever you are ready.

-Aleksey

On 5/14/19 6:39 AM, Boris Ulasevich wrote:
> Thanks for the review!
> 
> 13.05.2019 18:43, Aleksey Shipilev:
>> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>>> http://bugs.openjdk.java.net/browse/JDK-8223767
>>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
>> Thank you, this looks good.



From rkennke at redhat.com  Tue May 14 09:25:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 11:25:08 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
Message-ID: <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>

Hi Boris,

Would you help backporting the patch to sh/jdk11 and sh/jdk8 at some
point? It would be cool to have there, but we have no way to test it...

Thanks,
Roman

> Thanks for the review!
> 
> 13.05.2019 18:43, Aleksey Shipilev:
>> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>>> http://bugs.openjdk.java.net/browse/JDK-8223767
>>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
>> Thank you, this looks good.
>>
>> -Aleksey


From shade at redhat.com  Tue May 14 09:29:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 11:29:26 +0200
Subject: shenandoah/jdk8 repository
Message-ID: <5abde2c8-73ad-32ea-9c41-15a2e6815084@redhat.com>

Hi,

As another step in many to streamline our delivery pipelines, we have re-seeded the sh/jdk8
repository from the one we use for overall integration to 8u RPMs. It is available at new URL here
(notice the absence of "u", which is consistent with other JDK-flavored versions in the same area):
  http://hg.openjdk.java.net/shenandoah/jdk8/

As the result, sh/jdk8 got the latest 8u212-b04, plus all the updates in AArch64 port.

Your old pipelines should break now, as old shenandoah/jdk8u was moved to shenandoah/jdk8u-archive.
This would require you to reseed/rebase to the new repository. Note that repositories are not
related, so the full re-clone is needed. Other helpful links below.

Workspace tarball:
  https://builds.shipilev.net/workspaces/shenandoah-jdk8.tar.xz

Sources snapshot:
  https://builds.shipilev.net/source-snapshots/shenandoah-jdk8.tar.xz

Builds:
  https://builds.shipilev.net/openjdk-shenandoah-jdk8/

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May 14 09:29:41 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 11:29:41 +0200
Subject: RFR: Outstanding backports to sh/jdk8
Message-ID: <781c276e-a5c6-5100-b20c-5535f05f40f4@redhat.com>

Those seem to be the two remaining outstanding jdk11->jdk8 backports.

- JDK-8221278: Shenandoah should not enqueue string dedup candidates
during root scan
- JDK-8222425: Shenandoah: Move commonly used closures to separate files

http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-14-02/webrev.00/

Testing: hotspot_gc_shenandoah

Ok to push?

Roman


From shade at redhat.com  Tue May 14 09:34:15 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 11:34:15 +0200
Subject: RFR: Outstanding backports to sh/jdk8
In-Reply-To: <781c276e-a5c6-5100-b20c-5535f05f40f4@redhat.com>
References: <781c276e-a5c6-5100-b20c-5535f05f40f4@redhat.com>
Message-ID: <a84fa119-094b-8e79-f01f-218ac97099c9@redhat.com>

On 5/14/19 11:29 AM, Roman Kennke wrote:
> Those seem to be the two remaining outstanding jdk11->jdk8 backports.
> 
> - JDK-8221278: Shenandoah should not enqueue string dedup candidates
> during root scan
> - JDK-8222425: Shenandoah: Move commonly used closures to separate files
> 
> http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-14-02/webrev.00/
> 
> Testing: hotspot_gc_shenandoah
> 
> Ok to push?

Yes, looks good.

-Aleksey


From rkennke at redhat.com  Tue May 14 09:36:32 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Tue, 14 May 2019 09:36:32 +0000
Subject: hg: shenandoah/jdk8/hotspot: 2 new changesets
Message-ID: <201905140936.x4E9aWGE013870@aojmv0008.oracle.com>

Changeset: a12d87c31c30
Author:    rkennke
Date:      2019-05-14 10:16 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a12d87c31c30

[backport] 8221278: Shenandoah should not enqueue string dedup candidates during root scan
Reviewed-by: shade

! src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp

Changeset: a651c9a82748
Author:    rkennke
Date:      2019-05-14 10:16 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a651c9a82748

[backport] 8222425: Shenandoah: Move commonly used closures to separate files
Reviewed-by: shade

+ src/share/vm/gc_implementation/shenandoah/shenandoahClosures.hpp
+ src/share/vm/gc_implementation/shenandoah/shenandoahClosures.inline.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.inline.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp


From shade at redhat.com  Tue May 14 10:45:48 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 12:45:48 +0200
Subject: RFR/RFC: Shenandoah support for x86_32
Message-ID: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/32-bit/webrev.01/

This is the preliminary review request for Shenandoah x86_32 support.

Some history: Shenandoah used to support x86_32 in "passive" mode long time ago. This mode relies
only on stop-the-world GC to avoid implementing barriers (basically, runs Degenerated GC all the
time). It was an interesting mode to see the footprint numbers you can get with uncommits and
slimmer native pointers with really small microservice-size VMs. This mode was dropped before
integration upstream, because many Shenandoah tests expect all heuristics/modes to work properly,
and having the rudimentary x86_32 support was breaking tier1 tests. So we disabled it.

Today, we have significantly simplified runtime interface thanks to LRB [1] and elimination of
separate forwarding pointer slot [2], and we can build the fully concurrent x86_32 on top of that.
This allows us to maintain 32-bit cleanness in Shenandoah code (we have fixed >5 bugs ahead of this
patch!), plus serves are proof of concept that Shenandoah can be implemented on 32-bit platform.

Current patch applies on top of sh/jdk. Compiler changes are mostly to cover a few corner cases that
are needed for !LP64 paths, including the shenandoah_x86_32.ad file that carries Shenandoah CAS
barriers. Otherwise most of the changes are in rewiring ShenandoahBarrierSetAssembler for x86 to
properly share 32- and 64-bit paths. Plus there are test changes that make sure we don't run test we
know would fail on 32-bit VMs.

The patch passes hotspot_gc_shenandoah tests, CTW tests, jcstress (although there are upstream
failures that are being fixed now). Please spot mistakes and problems before I rush to propose it
for inclusion a few weeks later.

-- 
Thanks,
-Aleksey

[1] https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-April/009203.html
[2] https://mail.openjdk.java.net/pipermail/shenandoah-dev/2019-May/009480.html



From shade at redhat.com  Tue May 14 12:06:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 14:06:25 +0200
Subject: RFC: Pick up jdk/jdk -> sh/jdk at jdk-13+20+
Message-ID: <9b2d7fdc-8f0e-582c-0dc9-d81f56f91b5b@redhat.com>

We need to pick up latest jdk/jdk for nofwdptr and x86_32 stabilization. Last week's jdk/jdk was
riddled with build/test failures, which seem to be resolved at current state. I don't think we want
to risk waiting for another tag, and instead merge at latest buildable changeset:

changeset:   55778:d7819bedfaaf
tag:         tip
user:        redestad
date:        Tue May 14 12:00:49 2019 +0200
summary:     8221478: Disable VerifySharedSpaces by default

There is one lingering fastdebug/accounting bug not fixed:
  https://bugs.openjdk.java.net/browse/JDK-8223502

...but again, it seems dubious to wait for it, as jdk/jdk may regress. I would deal with that bug
upstream as soon as possible. We would hopefully catch jdk-13+21 on Thursday as the follow-up.

This merge changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b20-plus/changesets.txt

Brings in:
  8222992: Shenandoah: Pre-evacuate all roots
  8223258: Shenandoah: SRP::process_all_roots_slow processes JvmtiExport weak oops twice
  8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())
  8222738: Shenandoah: assert(is_Proj()) failed when running cometd benchmarks
  8223448: Shenandoah disabled barriers blocks omit LRB
  8223450: Disable Shenandoah C2 barriers verification for x86_32
  8223449: Unprotected UseCompressedOops block in gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
  8223446: Shenandoah breaks alignment with some HumongousThreshold values
  8223447: Stabilize gc/shenandoah/TestStringDedupStress test
  8223570: Shenandoah needs to acquire lock before CLDG::clear_claimed_marks
  8222926: Shenandoah build fails with --with-jvm-features=-compiler1
  8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
  8223583: Build failure after JDK-8223567 (Rename ShenandoahBrooksPointer to ShenandoahForwarding)
  8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
  8223759: Shenandoah should allow arbitrarily low initial heap size
  8223762: Shenandoah: overflows in calculations involving heap capacity

This merge webrev:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b20-plus/webrev.01/

I also eyeballed that current sh/jdk diff does not miss anything from nofwdptr patch.

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Tue May 14 12:23:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 14:23:25 +0200
Subject: RFC: Pick up jdk/jdk -> sh/jdk at jdk-13+20+
In-Reply-To: <9b2d7fdc-8f0e-582c-0dc9-d81f56f91b5b@redhat.com>
References: <9b2d7fdc-8f0e-582c-0dc9-d81f56f91b5b@redhat.com>
Message-ID: <7c0c5c07-25aa-cec8-a404-9d5774d8f3a7@redhat.com>

Yep, let's do it!

Thanks,
Roman

> We need to pick up latest jdk/jdk for nofwdptr and x86_32 stabilization. Last week's jdk/jdk was
> riddled with build/test failures, which seem to be resolved at current state. I don't think we want
> to risk waiting for another tag, and instead merge at latest buildable changeset:
> 
> changeset:   55778:d7819bedfaaf
> tag:         tip
> user:        redestad
> date:        Tue May 14 12:00:49 2019 +0200
> summary:     8221478: Disable VerifySharedSpaces by default
> 
> There is one lingering fastdebug/accounting bug not fixed:
>   https://bugs.openjdk.java.net/browse/JDK-8223502
> 
> ...but again, it seems dubious to wait for it, as jdk/jdk may regress. I would deal with that bug
> upstream as soon as possible. We would hopefully catch jdk-13+21 on Thursday as the follow-up.
> 
> This merge changesets:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b20-plus/changesets.txt
> 
> Brings in:
>   8222992: Shenandoah: Pre-evacuate all roots
>   8223258: Shenandoah: SRP::process_all_roots_slow processes JvmtiExport weak oops twice
>   8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())
>   8222738: Shenandoah: assert(is_Proj()) failed when running cometd benchmarks
>   8223448: Shenandoah disabled barriers blocks omit LRB
>   8223450: Disable Shenandoah C2 barriers verification for x86_32
>   8223449: Unprotected UseCompressedOops block in gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
>   8223446: Shenandoah breaks alignment with some HumongousThreshold values
>   8223447: Stabilize gc/shenandoah/TestStringDedupStress test
>   8223570: Shenandoah needs to acquire lock before CLDG::clear_claimed_marks
>   8222926: Shenandoah build fails with --with-jvm-features=-compiler1
>   8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
>   8223583: Build failure after JDK-8223567 (Rename ShenandoahBrooksPointer to ShenandoahForwarding)
>   8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
>   8223759: Shenandoah should allow arbitrarily low initial heap size
>   8223762: Shenandoah: overflows in calculations involving heap capacity
> 
> This merge webrev:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b20-plus/webrev.01/
> 
> I also eyeballed that current sh/jdk diff does not miss anything from nofwdptr patch.
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}
> 


From shade at redhat.com  Tue May 14 13:00:53 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 14 May 2019 13:00:53 +0000
Subject: hg: shenandoah/jdk: 167 new changesets
Message-ID: <201905141301.x4ED12F5002446@aojmv0008.oracle.com>

Changeset: 67b040623a12
Author:    darcy
Date:      2019-05-01 16:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/67b040623a12

8146726: Improve AbstractProcessor to issue warnings for repeated information
Reviewed-by: jjg, smarks, serb, igerasim

! src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java
! src/java.compiler/share/classes/javax/annotation/processing/Processor.java
+ test/langtools/tools/javac/processing/warnings/TestRepeatedSupportedItems.java
+ test/langtools/tools/javac/processing/warnings/au_8.out
+ test/langtools/tools/javac/processing/warnings/au_current.out

Changeset: 27c8a2e0b0e5
Author:    manc
Date:      2019-04-30 18:44 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/27c8a2e0b0e5

8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking
Summary: Add memory fences on accesses to JvmtiEnvBase::_tag_map
Reviewed-by: dholmes, jcbeyler, sspitsyn

! src/hotspot/share/prims/jvmtiEnvBase.hpp
! src/hotspot/share/prims/jvmtiTagMap.cpp

Changeset: 4a4bf48f76a4
Author:    jwilhelm
Date:      2019-05-02 03:20 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4a4bf48f76a4

Added tag jdk-13+19 for changeset a43d6467317d

! .hgtags

Changeset: 5b6177741464
Author:    coleenp
Date:      2019-05-01 20:48 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5b6177741464

8223194: runtime/Shutdown/ShutdownTest.java due to "OutOfMemoryError: Java heap too small"
Summary: Use default memory for the test.
Reviewed-by: dholmes, kvn

! test/hotspot/jtreg/runtime/Shutdown/ShutdownTest.java

Changeset: beca9f8524c1
Author:    redestad
Date:      2019-05-02 10:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/beca9f8524c1

8222895: StackOverflowError in custom security manager that relies on ClassSpecializer
Reviewed-by: alanb

! make/jdk/src/classes/build/tools/classlist/HelloClasslist.java
! src/java.base/share/classes/java/lang/invoke/ClassSpecializer.java
! test/jdk/java/lang/String/concat/WithSecurityManager.java

Changeset: 93f09ca4a7f8
Author:    stefank
Date:      2019-04-15 11:47 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/93f09ca4a7f8

8198505: Remove CollectorPolicy and its subclasses
Reviewed-by: pliden, shade

! src/hotspot/share/gc/cms/cmsArguments.cpp
! src/hotspot/share/gc/cms/cmsArguments.hpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.cpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.hpp
! src/hotspot/share/gc/cms/cmsHeap.cpp
! src/hotspot/share/gc/cms/cmsHeap.hpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp
! src/hotspot/share/gc/cms/parNewGeneration.cpp
! src/hotspot/share/gc/cms/parNewGeneration.hpp
! src/hotspot/share/gc/epsilon/epsilonArguments.cpp
! src/hotspot/share/gc/epsilon/epsilonArguments.hpp
! src/hotspot/share/gc/epsilon/epsilonBarrierSet.cpp
- src/hotspot/share/gc/epsilon/epsilonCollectorPolicy.hpp
! src/hotspot/share/gc/epsilon/epsilonHeap.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/g1/g1Arguments.cpp
! src/hotspot/share/gc/g1/g1Arguments.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.hpp
! src/hotspot/share/gc/g1/g1FullCollector.cpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.hpp
! src/hotspot/share/gc/g1/g1HeterogeneousHeapPolicy.cpp
! src/hotspot/share/gc/g1/g1HeterogeneousHeapPolicy.hpp
! src/hotspot/share/gc/g1/g1HeterogeneousHeapYoungGenSizer.cpp
! src/hotspot/share/gc/g1/g1Policy.cpp
! src/hotspot/share/gc/g1/g1Policy.hpp
! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp
! src/hotspot/share/gc/g1/g1YoungGenSizer.hpp
! src/hotspot/share/gc/g1/heapRegionManager.cpp
! src/hotspot/share/gc/g1/heapRegionManager.hpp
! src/hotspot/share/gc/parallel/adjoiningGenerations.cpp
! src/hotspot/share/gc/parallel/adjoiningGenerations.hpp
! src/hotspot/share/gc/parallel/adjoiningGenerationsForHeteroHeap.cpp
! src/hotspot/share/gc/parallel/adjoiningGenerationsForHeteroHeap.hpp
! src/hotspot/share/gc/parallel/asPSOldGen.cpp
! src/hotspot/share/gc/parallel/asPSYoungGen.cpp
- src/hotspot/share/gc/parallel/generationSizer.cpp
- src/hotspot/share/gc/parallel/generationSizer.hpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.cpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.hpp
! src/hotspot/share/gc/parallel/parallelArguments.cpp
! src/hotspot/share/gc/parallel/parallelArguments.hpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp
! src/hotspot/share/gc/parallel/pcTasks.hpp
! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp
! src/hotspot/share/gc/parallel/psMarkSweep.cpp
! src/hotspot/share/gc/parallel/psOldGen.cpp
! src/hotspot/share/gc/parallel/psParallelCompact.cpp
! src/hotspot/share/gc/parallel/psScavenge.cpp
! src/hotspot/share/gc/parallel/psYoungGen.cpp
! src/hotspot/share/gc/serial/defNewGeneration.cpp
! src/hotspot/share/gc/serial/defNewGeneration.hpp
! src/hotspot/share/gc/serial/serialArguments.cpp
! src/hotspot/share/gc/serial/serialArguments.hpp
! src/hotspot/share/gc/serial/serialHeap.cpp
! src/hotspot/share/gc/serial/serialHeap.hpp
! src/hotspot/share/gc/serial/tenuredGeneration.cpp
! src/hotspot/share/gc/serial/tenuredGeneration.hpp
! src/hotspot/share/gc/shared/ageTable.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
- src/hotspot/share/gc/shared/collectorPolicy.cpp
- src/hotspot/share/gc/shared/collectorPolicy.hpp
! src/hotspot/share/gc/shared/concurrentGCPhaseManager.hpp
! src/hotspot/share/gc/shared/gcArguments.cpp
! src/hotspot/share/gc/shared/gcArguments.hpp
- src/hotspot/share/gc/shared/gcArguments.inline.hpp
! src/hotspot/share/gc/shared/gcConfiguration.cpp
! src/hotspot/share/gc/shared/gcOverheadChecker.cpp
+ src/hotspot/share/gc/shared/genArguments.cpp
+ src/hotspot/share/gc/shared/genArguments.hpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.hpp
! src/hotspot/share/gc/shared/generation.cpp
! src/hotspot/share/gc/shared/generationSpec.cpp
! src/hotspot/share/gc/shared/generationSpec.hpp
! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.hpp
! src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/z/zArguments.cpp
! src/hotspot/share/gc/z/zArguments.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
- src/hotspot/share/gc/z/zCollectorPolicy.cpp
- src/hotspot/share/gc/z/zCollectorPolicy.hpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/memory/universe.hpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/arguments.hpp
! test/hotspot/gtest/gc/shared/test_collectorPolicy.cpp

Changeset: 3a2e45820d77
Author:    stefank
Date:      2019-05-02 10:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a2e45820d77

8222986: Add parameter to skip clearing CHeapBitMaps when resizing
Reviewed-by: pliden

! src/hotspot/share/utilities/bitMap.cpp
! src/hotspot/share/utilities/bitMap.hpp

Changeset: 5b168a63cec5
Author:    stefank
Date:      2019-05-02 10:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5b168a63cec5

8223064: Minor cleanups in ResolvedMethodTable
Reviewed-by: hseigel, coleenp

! src/hotspot/share/prims/resolvedMethodTable.cpp

Changeset: edd709e64ea1
Author:    dfuchs
Date:      2019-05-02 11:55 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/edd709e64ea1

8223145: Replace wildcard address with loopback or local host in tests - part 1
Summary: Replaces binding to wildacard with alternative less susceptible to intermittent failure in some intermittently failing tests.
Reviewed-by: chegar, msheppar

! test/jdk/com/sun/net/httpserver/bugs/B6361557.java
! test/jdk/java/net/Authenticator/B4722333.java
! test/jdk/java/net/HttpURLConnection/UnmodifiableMaps.java
! test/jdk/java/net/ResponseCache/ResponseCacheTest.java
! test/jdk/java/net/Socket/GetLocalAddress.java
! test/jdk/java/net/Socket/SetReceiveBufferSize.java
! test/jdk/java/net/Socket/SoTimeout.java
! test/jdk/java/net/Socket/TestAfterClose.java
! test/jdk/java/net/Socket/UrgentDataTest.java
! test/jdk/java/net/SocketOption/OptionsTest.java
! test/jdk/java/net/URL/GetContent.java
! test/jdk/java/net/URLConnection/B5052093.java
! test/jdk/java/net/URLPermission/nstest/LookupTest.java
! test/jdk/sun/net/ftp/TestFtpClientNameListWithNull.java
! test/jdk/sun/net/www/http/HttpClient/ProxyTest.java
! test/jdk/sun/net/www/http/HttpURLConnection/NTLMAuthWithSM.java
! test/jdk/sun/net/www/http/HttpURLConnection/PostOnDelete.java
! test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
! test/jdk/sun/net/www/httptest/TestHttpServer.java
! test/jdk/sun/net/www/protocol/http/B8012625.java
! test/jdk/sun/net/www/protocol/http/Finalizer.java
! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java
! test/lib/jdk/test/lib/net/URIBuilder.java

Changeset: 79d13fd7db9c
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/79d13fd7db9c

8222930: ConcurrentSkipListMap.clone() shares size variable between original and clone
Reviewed-by: martin, smarks
Contributed-by: Adam Farley8 <adam.farley at uk.ibm.com>, Martin Buchholz <martinrb at google.com>

! src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
! test/jdk/java/util/concurrent/tck/MapTest.java

Changeset: 3ffdc15cd044
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3ffdc15cd044

8221120: CopyOnWriteArrayList.set should always have volatile write semantics
Reviewed-by: martin

! src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java

Changeset: c277ec29ee12
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c277ec29ee12

8221892: ThreadPoolExecutor: Thread.isAlive() is not equivalent to not being startable
Reviewed-by: martin, dholmes

! src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java
! test/jdk/java/util/concurrent/tck/ThreadPoolExecutorTest.java

Changeset: e1bec7613945
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e1bec7613945

8220248: fix headings in java.util.concurrent
Reviewed-by: martin, jjg

! src/java.base/share/classes/java/util/concurrent/ExecutorService.java
! src/java.base/share/classes/java/util/concurrent/ScheduledExecutorService.java
! src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java
! src/java.base/share/classes/java/util/concurrent/locks/Condition.java
! src/java.base/share/classes/java/util/concurrent/locks/Lock.java
! src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java

Changeset: 09f09b4e7808
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/09f09b4e7808

8219138: Miscellaneous changes imported from jsr166 CVS 2019-05
Reviewed-by: martin

! test/jdk/java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java
! test/jdk/java/util/concurrent/tck/Atomic8Test.java
! test/jdk/java/util/concurrent/tck/AtomicIntegerArray9Test.java
! test/jdk/java/util/concurrent/tck/AtomicLongArray9Test.java
! test/jdk/java/util/concurrent/tck/AtomicReferenceArray9Test.java
! test/jdk/java/util/concurrent/tck/Collection8Test.java
! test/jdk/java/util/concurrent/tck/CompletableFutureTest.java
! test/jdk/java/util/concurrent/tck/ForkJoinTask8Test.java
+ test/jdk/java/util/concurrent/tck/HashtableTest.java
! test/jdk/java/util/concurrent/tck/JSR166TestCase.java
! test/jdk/java/util/concurrent/tck/SplittableRandomTest.java
! test/jdk/java/util/concurrent/tck/StampedLockTest.java
! test/jdk/java/util/concurrent/tck/ThreadLocalRandom8Test.java
! test/jdk/java/util/concurrent/tck/VectorTest.java

Changeset: df2b3565f343
Author:    zgu
Date:      2019-05-02 09:49 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/df2b3565f343

8222992: Shenandoah: Pre-evacuate all roots
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahClosures.hpp
! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp

Changeset: 96ad739cfc39
Author:    cushon
Date:      2019-04-29 17:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/96ad739cfc39

8219202: Use Unsynchronized StringBuilder in sun.net.www.ParseUtil
Reviewed-by: chegar
Contributed-by: Alan Malloy <amalloy at google.com>

! src/java.base/share/classes/sun/net/www/ParseUtil.java

Changeset: b28b7f631301
Author:    michaelm
Date:      2019-05-02 17:29 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b28b7f631301

8216978: Drop support for pre JDK 1.4 SocketImpl implementations
Reviewed-by: chegar, alanb, dfuchs

! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java
! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java
! src/java.base/share/classes/java/net/ServerSocket.java
! src/java.base/share/classes/java/net/Socket.java
! src/java.base/share/classes/java/net/SocketImpl.java
! src/java.base/share/classes/java/net/SocketInputStream.java
! src/java.base/share/classes/java/net/SocketOutputStream.java
! src/java.base/share/classes/java/net/SocksSocketImpl.java
! src/java.base/unix/classes/java/net/PlainSocketImpl.java
! src/java.base/unix/native/libnet/PlainSocketImpl.c
! src/java.base/windows/classes/java/net/PlainSocketImpl.java
- test/jdk/java/net/Socket/OldImpl.java
- test/jdk/java/net/Socket/OldSocketImpl.java
+ test/jdk/java/net/Socket/OldSocketImplTest.java
- test/jdk/java/net/Socket/OldSocketImplTestDriver.java

Changeset: 7ab4310ed472
Author:    manc
Date:      2019-05-01 20:25 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7ab4310ed472

8223227: Rename acquire_tag_map() to tag_map_acquire() in jvmtiEnvBase
Reviewed-by: dholmes, jcbeyler

! src/hotspot/share/prims/jvmtiEnvBase.hpp
! src/hotspot/share/prims/jvmtiTagMap.cpp

Changeset: 764addae3e37
Author:    zgu
Date:      2019-05-02 15:20 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/764addae3e37

8223258: Shenandoah: SRP::process_all_roots_slow processes JvmtiExport weak oops twice
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp

Changeset: 22866513a80e
Author:    bpb
Date:      2019-05-02 13:25 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/22866513a80e

8220793: (fs) No support for changing modification time of symlink
Reviewed-by: alanb, rriggs

! src/java.base/unix/classes/sun/nio/fs/UnixFileAttributeViews.java
! src/java.base/unix/classes/sun/nio/fs/UnixNativeDispatcher.java
! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c
+ test/jdk/java/nio/file/Files/SymlinkTime.java

Changeset: d890ba18f64b
Author:    lancea
Date:      2019-05-02 17:08 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d890ba18f64b

8218875: Add new FileSystems.newFileSystem methods
Reviewed-by: rriggs, alanb, clanger, dfuchs

! src/java.base/share/classes/java/nio/file/FileSystems.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JDKPlatformProvider.java
! test/jdk/jdk/nio/zipfs/Basic.java
+ test/jdk/jdk/nio/zipfs/NewFileSystemTests.java
! test/jdk/jdk/nio/zipfs/PathOps.java
! test/jdk/jdk/nio/zipfs/ZipFSTester.java
! test/langtools/tools/javac/api/file/SJFM_TestBase.java
! test/langtools/tools/javac/modules/ContainsTest.java

Changeset: 948644e20013
Author:    bpb
Date:      2019-05-02 14:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/948644e20013

8223254: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space"
Reviewed-by: lancea, rriggs

! test/jdk/java/io/DataOutputStream/WriteUTF.java

Changeset: 0bbac18e3959
Author:    joehw
Date:      2019-05-02 14:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0bbac18e3959

8223052: Cleanup: NodeSortRecord
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java

Changeset: 0907dce4b90e
Author:    coffeys
Date:      2019-05-02 22:52 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0907dce4b90e

8217364: Custom URLStreamHandler for jrt or file protocol can override default handler
Reviewed-by: redestad

! src/java.base/share/classes/java/net/URL.java
+ test/jdk/java/net/URL/NonOverridableHandlerFactory.java

Changeset: 251090f84412
Author:    jjiang
Date:      2019-05-03 15:57 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/251090f84412

8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed
Summary: Build NSS 3.41 with VS2017 and also upgrade to this NSS for macosx
Reviewed-by: valeriep

! test/jdk/ProblemList.txt
! test/jdk/sun/security/pkcs11/PKCS11Test.java
! test/jdk/sun/security/tools/keytool/NssTest.java

Changeset: 3ebf58dbf5d8
Author:    phedlin
Date:      2019-04-17 14:52 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3ebf58dbf5d8

8223137: Rename predicate 'do_unroll_only()' to 'is_unroll_only()'.
Reviewed-by: vlivanov

! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopUnswitch.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/opto/superword.cpp

Changeset: 1a5305f51bfd
Author:    phedlin
Date:      2019-05-02 11:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1a5305f51bfd

8223138: Small clean-up in loop-tree support.
Summary: Rename predicate 'is_inner()' to 'is_innermost()' to be accurate. Added 'is_root()' predicate for root parent test in loop-tree. Changed definition of 'is_loop()' to always lazy-read the tail, since it should never be NULL. Cleanup of 'tail()' definition.
Reviewed-by: vlivanov, neliasso

! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopnode.hpp

Changeset: d6f55ea4e325
Author:    phedlin
Date:      2019-04-17 14:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d6f55ea4e325

8223139: Rename mandatory policy-do routines.
Summary: Rename 'policy_do_remove_empty_loop' to 'do_remove_empty_loop', 'policy_do_one_iteration_loop' to 'do_one_iteration_loop'.
Reviewed-by: vlivanov, dl

! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopnode.hpp

Changeset: 6b77693eda6a
Author:    phedlin
Date:      2019-04-17 14:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6b77693eda6a

8223140: Clean-up in 'ok_to_convert()'.
Summary: Simplify logic in function. Added precond/postcond macros.
Reviewed-by: vlivanov, neliasso

! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/opto/subnode.cpp
! src/hotspot/share/utilities/debug.hpp

Changeset: 45b84dd85b9e
Author:    phedlin
Date:      2019-04-17 14:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/45b84dd85b9e

8223141: Change (count) suffix _ct into _cnt.
Reviewed-by: vlivanov

! src/hotspot/share/opto/loopTransform.cpp

Changeset: e09f3ad6147d
Author:    phedlin
Date:      2019-04-17 14:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e09f3ad6147d

8223142: Clean-up WS and CB.
Reviewed-by: vlivanov

! src/hotspot/share/opto/loopTransform.cpp

Changeset: 3a79044dd980
Author:    phedlin
Date:      2019-04-17 14:56 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a79044dd980

8223143: Restructure/clean-up for 'loopexit_or_null()'.
Summary: Minor restructure and clean-up for 'loopexit_or_null()' and its use.
Reviewed-by: vlivanov

! src/hotspot/share/opto/loopnode.hpp

Changeset: fc7627bf4b01
Author:    phedlin
Date:      2019-04-17 14:57 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fc7627bf4b01

8216137: assert failed: Live node limit exceeded.
8219520: assert failed: Live node limit exceeded.
Summary: Adding simplistic node budget support for loop-transformations. This /should/attempts to/ resolve most cases of: "assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit".
Reviewed-by: vlivanov, neliasso

! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopUnswitch.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/opto/loopopts.cpp

Changeset: 81d57ba42425
Author:    hseigel
Date:      2019-05-03 07:54 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/81d57ba42425

8222500: runtime/8176717/TestInheritFD.java failed with java.nio.file.NoSuchFileException: /tmp/communication7071713601211876892.txt
Summary: Create the test's temporary files inside of jtreg scratch directories instead of /tmp
Reviewed-by: coleenp, lfoltan, dholmes

! test/hotspot/jtreg/runtime/8176717/TestInheritFD.java

Changeset: 8390399b09f9
Author:    mdoerr
Date:      2019-05-03 16:31 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8390399b09f9

8223248: [AIX] Remove old xlC 10 workaround for load acquire
Reviewed-by: goetz, lucy

! src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp

Changeset: b7e6fc77c2f3
Author:    kvn
Date:      2019-05-03 09:07 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b7e6fc77c2f3

8223262: [AOT] jaotc crashes with assert(!(((ThreadShadow*)__the_thread__)->has_pending_exception())) failed: Should not allocate with exception pending
Summary: Added missing checks for pending exception.
Reviewed-by: never, gdub, dnsimon

! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

Changeset: 90855d9c3c39
Author:    darcy
Date:      2019-05-03 09:25 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/90855d9c3c39

8223265: Clarify operational semantics of java.util.Objects.equals()
Reviewed-by: bpb, alanb

! src/java.base/share/classes/java/util/Objects.java

Changeset: aa29971a17a1
Author:    pchilanomate
Date:      2019-05-03 12:33 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/aa29971a17a1

8220724: TestBiasedLockRevocationEvents fails while matching revoke events to VMOperation events
Summary: Safepoint id used by JavaThread when posting event is now set inside appropiate safepoint
Reviewed-by: dholmes, rehn

! src/hotspot/share/runtime/biasedLocking.cpp

Changeset: 297ddf282627
Author:    erikj
Date:      2019-05-03 09:34 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/297ddf282627

8223309: test failing due to self-assign-overloaded
Reviewed-by: tbell
Contributed-by: johan.vos at gluonhq.com, erik.joelsson at oracle.com

! make/autoconf/flags-cflags.m4
! make/hotspot/lib/CompileGtest.gmk

Changeset: 029b56549e22
Author:    darcy
Date:      2019-05-03 14:09 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/029b56549e22

8223178: Improve FileSystems.newFileSystem example with map factory methods
Reviewed-by: alanb, clanger, bpb

! src/java.base/share/classes/java/nio/file/FileSystems.java

Changeset: 040bf087ae39
Author:    kbarrett
Date:      2019-05-03 23:35 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/040bf087ae39

8221359: Eliminate SATBMarkQueueSet::filter_thread_buffers
Summary: Removed filter_thread_buffers
Reviewed-by: tschatzl, sangheki

! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp
! src/hotspot/share/gc/g1/g1RootProcessor.cpp
! src/hotspot/share/gc/g1/g1RootProcessor.hpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java

Changeset: 37630ad8fa67
Author:    igerasim
Date:      2019-05-03 23:00 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/37630ad8fa67

8223174: Pattern.compile() can throw confusing NegativeArraySizeException
Reviewed-by: martin

! src/java.base/share/classes/java/util/regex/Pattern.java
+ test/jdk/java/util/regex/NegativeArraySize.java

Changeset: 239bc23e76cc
Author:    kbarrett
Date:      2019-05-05 09:10 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/239bc23e76cc

8223359: JDK-8221359 breaks TestG1ParallelPhases.java
Summary: Removed check for SATBFiltering event.
Reviewed-by: tschatzl

! test/jdk/jdk/jfr/event/gc/collection/TestG1ParallelPhases.java

Changeset: 61d0e96a6b2d
Author:    manc
Date:      2019-05-02 15:46 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/61d0e96a6b2d

8223267: Fix incorrect usage of GCTraceTime in g1FullCollector and g1CollectedHeap
Reviewed-by: kbarrett, tschatzl

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1FullCollector.cpp

Changeset: b39365cebb73
Author:    gromero
Date:      2019-05-06 09:53 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b39365cebb73

8223395: PPC64: Improve comments in the JVM signal handler to match ISA text
Reviewed-by: mdoerr

! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp

Changeset: ca251ef47e0b
Author:    xuelei
Date:      2019-05-06 08:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ca251ef47e0b

8219991: New fix of the deadlock in sun.security.ssl.SSLSocketImpl
Reviewed-by: alanb, dfuchs

! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java

Changeset: 4f2fd02922b1
Author:    dtitov
Date:      2019-05-06 09:58 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4f2fd02922b1

8222667: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter002/TestDescription.java failed with "event IS NOT a breakpoint"
Reviewed-by: gadams, sspitsyn, jcbeyler, cjplummer

! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter002.java

Changeset: c48f141e7c5b
Author:    vromero
Date:      2019-05-06 14:47 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c48f141e7c5b

8219483: j.l.c.ClassDesc::nested(String, String...) doesn't throw NPE if any arg is null
Reviewed-by: darcy

! src/java.base/share/classes/java/lang/constant/ClassDesc.java
! test/jdk/java/lang/constant/ClassDescTest.java

Changeset: 3661ad97da8f
Author:    vlivanov
Date:      2019-05-06 12:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3661ad97da8f

8223171: Redundant nmethod dependencies for effectively final methods
Reviewed-by: dlong

! src/hotspot/share/c1/c1_GraphBuilder.cpp
! src/hotspot/share/ci/ciMethod.cpp
! src/hotspot/share/ci/ciMethod.hpp
! src/hotspot/share/code/dependencies.cpp
! src/hotspot/share/code/dependencies.hpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/method.hpp
! src/hotspot/share/opto/doCall.cpp

Changeset: f0bce2f93e72
Author:    vlivanov
Date:      2019-05-06 12:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f0bce2f93e72

8219902: C2: MemNode::can_see_stored_value() ignores casts which carry control dependency
Reviewed-by: kvn

! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/node.cpp
! src/hotspot/share/opto/node.hpp

Changeset: 1abca1170080
Author:    jiefu
Date:      2019-05-06 12:17 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1abca1170080

8221542: ~15% performance degradation due to less optimized inline decision
Reviewed-by: vlivanov, coleenp

! src/hotspot/share/interpreter/abstractInterpreter.cpp
! src/hotspot/share/interpreter/bytecodeStream.hpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/opto/bytecodeInfo.cpp
! src/hotspot/share/opto/parse.hpp
! src/hotspot/share/runtime/deoptimization.cpp

Changeset: 62f373a53296
Author:    jwilhelm
Date:      2019-05-06 21:50 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/62f373a53296

8222665: Update Graal
Reviewed-by: kvn

! src/jdk.internal.vm.compiler.management/share/classes/org.graalvm.compiler.hotspot.management/src/org/graalvm/compiler/hotspot/management/JMXServiceProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64Assembler.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/FloatStamp.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/BciBlockMappingTest.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationPiTest.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest16.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLoweringProvider.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/JVMCIVersionCheckTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/MonitorSnippets.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BciBlockMapping.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Move.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ZeroMemoryOp.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/ArithmeticLIRGeneratorTool.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/PrimitiveStampBoundaryTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedRemNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/ArrayLengthNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/LoadIndexedNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/NewInstanceNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/StoreFieldNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/StoreIndexedNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/LoweringProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConditionalEliminationPhase.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/BinaryGraphPrinter.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ZeroMemoryNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/GraphEffectList.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphProtocol.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.micro.benchmarks/src/micro/benchmarks/ArrayAllocationBenchmark.java

Changeset: bfa52d3068f5
Author:    coleenp
Date:      2019-05-06 15:25 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bfa52d3068f5

8222893: markOopDesc::print_on() is a bit confused
Summary: Add print_on for ObjectMonitor and make markOop printing sensible and add test.
Reviewed-by: dcubed, pchilanomate

! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/markOop.cpp
! src/hotspot/share/runtime/objectMonitor.cpp
! src/hotspot/share/runtime/objectMonitor.hpp
+ test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 671e35cf611b
Author:    sangheki
Date:      2019-05-06 14:19 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/671e35cf611b

8221509: Refactor assert( G1CollectedHeap::used() == recalculate_used() ) with better message
Reviewed-by: tschatzl, manc

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1Policy.cpp

Changeset: 0f798f21e8c2
Author:    coleenp
Date:      2019-05-06 18:01 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0f798f21e8c2

8223412: tier1 build failure after 8222893
Summary: disable the test in PRODUCT
Reviewed-by: dcubed, pliden, kvn

! test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 6188582d58b5
Author:    igerasim
Date:      2019-05-06 18:07 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6188582d58b5

8222955: Optimize String.replace(CharSequence, CharSequence) for common cases
Reviewed-by: redestad, tvaleev

! src/java.base/share/classes/java/lang/String.java
! src/java.base/share/classes/java/lang/StringLatin1.java
! src/java.base/share/classes/java/lang/StringUTF16.java
! test/jdk/java/lang/String/LiteralReplace.java
+ test/micro/org/openjdk/bench/java/lang/StringReplace.java

Changeset: f72402697b2f
Author:    dholmes
Date:      2019-05-06 21:23 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f72402697b2f

8222534: VerifyBeforeExit is not honored when System.exit is called
Reviewed-by: coleenp, rehn

! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/vmOperations.cpp

Changeset: 8bca46822c05
Author:    pli
Date:      2019-05-07 00:58 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8bca46822c05

8223054: [TESTBUG] Put graalJarsCP before existing classpath in GraalUnitTestLauncher
Reviewed-by: iignatyev, dlong

! test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java

Changeset: 81de17a33575
Author:    weijun
Date:      2019-05-07 10:21 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/81de17a33575

8219013: Update Apache Santuario (XML Signature) to version 2.1.3
Reviewed-by: mullan

! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyValue.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/ECKeyValue.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/ECKeyValueResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RSAKeyValueResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java
+ src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/VerifiedReference.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathFilterCHGPContainer.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Constants.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Signature11ElementProxy.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java
! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java
! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java
! src/java.xml.crypto/share/legal/santuario.md

Changeset: 2d012a75d35c
Author:    kvn
Date:      2019-05-06 20:05 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2d012a75d35c

8223332: Update JVMCI
Reviewed-by: never, dnsimon

! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp
! src/hotspot/share/jvmci/jvmciEnv.cpp
! src/hotspot/share/jvmci/jvmciEnv.hpp
! src/hotspot/share/jvmci/jvmciExceptions.hpp
! src/hotspot/share/jvmci/jvmciJavaClasses.cpp
! src/hotspot/share/jvmci/jvmciJavaClasses.hpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/jvmci/jvmci_globals.cpp
! src/hotspot/share/jvmci/jvmci_globals.hpp
! src/hotspot/share/jvmci/vmStructs_jvmci.cpp
! src/hotspot/share/runtime/objectMonitor.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigStore.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/TranslatedException.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java
! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java
+ src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/SuppressFBWarnings.java
! src/jdk.internal.vm.ci/share/classes/module-info.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/LoadConstantIndirectlyNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveConstantStubCall.java
! test/hotspot/jtreg/compiler/jvmci/common/patches/jdk.internal.vm.ci/jdk/vm/ci/hotspot/CompilerToVMHelper.java
+ test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHotSpotJVMCIRuntime.java
+ test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestServices.java
! test/jdk/jdk/modules/etc/JdkQualifiedExportTest.java

Changeset: 28dd27202591
Author:    dlong
Date:      2019-04-25 13:35 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/28dd27202591

8218700: infinite loop in HotSpotJVMCIMetaAccessContext.fromClass after OutOfMemoryError
Reviewed-by: never, kvn

! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java
! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: e8f1b9fc82cc
Author:    vlivanov
Date:      2019-05-06 21:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e8f1b9fc82cc

8223422: [Graal] assert(!m->can_be_statically_bound(InstanceKlass::cast(ctxk))) failed: redundant
Reviewed-by: kvn

! src/hotspot/share/code/dependencies.hpp

Changeset: a9f729b641a3
Author:    pliden
Date:      2019-05-07 07:44 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a9f729b641a3

8223308: ZGC: Remove ZGranuleMap::size()
Reviewed-by: stefank, eosterlund

! src/hotspot/share/gc/z/zGranuleMap.hpp
! src/hotspot/share/gc/z/zGranuleMap.inline.hpp

Changeset: 1dc9bf9d016b
Author:    xliu
Date:      2019-05-07 09:17 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1dc9bf9d016b

8222670: pathological case of JIT recompilation and code cache bloat
Summary: Prevent downgraded compilation tasks from recompiling.
Reviewed-by: sgehwolf, thartmann

! src/hotspot/share/compiler/compileBroker.hpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
+ test/hotspot/jtreg/compiler/tiered/Level2RecompilationTest.java
! test/lib/sun/hotspot/WhiteBox.java

Changeset: 0d35df96db33
Author:    roland
Date:      2019-05-06 13:51 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0d35df96db33

8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())
Reviewed-by: thartmann

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Changeset: 26748009f2e5
Author:    roland
Date:      2019-05-02 20:47 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/26748009f2e5

8222738: Shenandoah: assert(is_Proj()) failed when running cometd benchmarks
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Changeset: 0dcb89221c93
Author:    erikj
Date:      2019-05-07 06:58 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0dcb89221c93

8223335: Compare baseline builds on linux are failing
Reviewed-by: tbell

! make/InitSupport.gmk

Changeset: bdccc8c06ac7
Author:    shade
Date:      2019-05-07 16:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bdccc8c06ac7

8223448: Shenandoah disabled barriers blocks omit LRB
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

Changeset: abffbe8557ab
Author:    shade
Date:      2019-05-07 16:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/abffbe8557ab

8223450: Disable Shenandoah C2 barriers verification for x86_32
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

Changeset: f7b4471933d3
Author:    shade
Date:      2019-05-07 16:06 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f7b4471933d3

8223449: Unprotected UseCompressedOops block in gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
Reviewed-by: rkennke

! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp

Changeset: ba74d2de9a01
Author:    michaelm
Date:      2019-05-07 15:39 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ba74d2de9a01

8223457: java.net.ServerSocket protected constructor should throw NPE if impl null
Reviewed-by: dfuchs

! src/java.base/share/classes/java/net/ServerSocket.java
+ test/jdk/java/net/ServerSocket/NullConstructor.java

Changeset: be7839b9493f
Author:    jcbeyler
Date:      2019-05-07 07:43 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/be7839b9493f

8223044: Add back exception checking in tests
Summary: Add exception checking to previously modified tests
Reviewed-by: sspitsyn, cjplummer

! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach002/attach002Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/attach021Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach022/attach022Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t001/bi01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t002/bi01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t002/libbi01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/bi04t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/libbi04t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t001/em01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t001/libem01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/em01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/libem01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t001/em02t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t001/libem02t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t010/em02t010.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t010/libem02t010.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t011/em02t011.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t011/libem02t011.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t012/em02t012.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t012/libem02t012.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/exceptionjni001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/BooleanArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/ByteArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/CharArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/DoubleArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/FloatArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/IntArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/LongArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/ShortArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/StringCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIGlobalRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNILocalRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIWeakGlobalRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/jni/ExceptionCheckingJniEnv.hpp

Changeset: 87d01c0d7b45
Author:    naoto
Date:      2019-05-07 09:37 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/87d01c0d7b45

8220037: Inconsistencies of generated timezone files between Windows and Linux
Reviewed-by: rriggs

! make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java
! test/jdk/java/util/TimeZone/CLDRDisplayNamesTest.java

Changeset: 61049e91eae5
Author:    dfuchs
Date:      2019-05-07 18:10 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/61049e91eae5

8223463: Replace wildcard address with loopback or local host in tests - part 2
Summary: Removes (or documents) some usages of the wildcard address in intermittently failing tests.
Reviewed-by: alanb

! test/jdk/java/net/ServerSocket/AcceptInheritHandle.java
! test/jdk/java/net/URLConnection/Responses.java
! test/jdk/java/net/ipv6tests/TcpTest.java
! test/jdk/sun/net/ftp/FtpURL.java

Changeset: 0082ede5dc53
Author:    erikj
Date:      2019-05-07 12:32 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0082ede5dc53

8223319: Add copyright footer to specs and man pages
Reviewed-by: iris, sspitsyn

! make/Docs.gmk
! make/common/TextFileProcessing.gmk
! src/hotspot/share/prims/jvmti.xml
! src/hotspot/share/prims/jvmti.xsl

Changeset: b0e23da4c8e0
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b0e23da4c8e0

8223446: Shenandoah breaks alignment with some HumongousThreshold values
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java

Changeset: 98558b7544c7
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/98558b7544c7

8223447: Stabilize gc/shenandoah/TestStringDedupStress test
Reviewed-by: rkennke

! test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java

Changeset: 1851a532ddfe
Author:    sviswanathan
Date:      2019-05-07 13:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1851a532ddfe

8222074: Enhance auto vectorization for x86
Reviewed-by: kvn, vlivanov

! src/hotspot/cpu/x86/assembler_x86.cpp
! src/hotspot/cpu/x86/assembler_x86.hpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.hpp
! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp
! src/hotspot/cpu/x86/stubRoutines_x86.cpp
! src/hotspot/cpu/x86/stubRoutines_x86.hpp
! src/hotspot/cpu/x86/x86.ad
! src/hotspot/cpu/x86/x86_32.ad
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/adlc/formssel.cpp
! src/hotspot/share/classfile/vmSymbols.cpp
! src/hotspot/share/classfile/vmSymbols.hpp
! src/hotspot/share/opto/c2compiler.cpp
! src/hotspot/share/opto/classes.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/subnode.hpp
! src/hotspot/share/opto/superword.cpp
! src/hotspot/share/opto/vectornode.cpp
! src/hotspot/share/opto/vectornode.hpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/java.base/share/classes/java/lang/Math.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
! test/hotspot/jtreg/compiler/c2/cr6340864/TestDoubleVect.java
! test/hotspot/jtreg/compiler/c2/cr6340864/TestFloatVect.java
! test/hotspot/jtreg/compiler/c2/cr6340864/TestIntVect.java

Changeset: 5600f5c38b0b
Author:    erikj
Date:      2019-05-07 14:05 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5600f5c38b0b

8223464: Improve version string for Oracle CI builds
Reviewed-by: tbell

! make/autoconf/version-numbers
! make/conf/jib-profiles.js

Changeset: 3fbaea4b1f1c
Author:    dholmes
Date:      2019-05-07 17:33 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3fbaea4b1f1c

8223437: Backout JDK-8219974 Restore static callsite resolution for the current class
Reviewed-by: jwilhelm, vlivanov

! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/oops/cpCache.hpp
! src/hotspot/share/runtime/sharedRuntime.cpp

Changeset: a8535f04b465
Author:    coleenp
Date:      2019-05-07 18:24 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a8535f04b465

8223481: gtest/GTestWrapper.java failed due to "assert(ret == 0) failed: sem_post failed; error='Invalid argument' (errno=EINVAL)"
Summary: Remove the test for now.
Reviewed-by: dholmes

- test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 193a8f1a4f3b
Author:    alanb
Date:      2019-05-08 08:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/193a8f1a4f3b

8223353: (ch) Change channel close implementation to not wait for I/O threads
Reviewed-by: dfuchs, chegar

! src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java
! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java
! src/java.base/unix/classes/sun/nio/ch/SinkChannelImpl.java
! src/java.base/unix/classes/sun/nio/ch/SourceChannelImpl.java

Changeset: de34f4b370b0
Author:    rkennke
Date:      2019-05-08 11:59 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/de34f4b370b0

8223244: Fix usage of ARRAYCOPY_DISJOINT decorator
Reviewed-by: eosterlund, shade

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

Changeset: 845f5a35241b
Author:    coleenp
Date:      2019-05-08 06:40 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/845f5a35241b

8223391: Unsynchronized iteration of ClassLoaderDataGraph
Summary: lock in G1 before clear_claimed_marks
Reviewed-by: hseigel, lfoltan, tschatzl

! src/hotspot/share/classfile/classLoaderDataGraph.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp

Changeset: 6c1a7c2ee530
Author:    gadams
Date:      2019-05-08 07:56 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6c1a7c2ee530

8223416: Exclude javax/management/monitor/DerivedGaugeMonitorTest.java until JDK-8042211 is fixed.
Reviewed-by: dcubed

! test/jdk/ProblemList.txt

Changeset: 5e5535d25467
Author:    shade
Date:      2019-05-08 14:27 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5e5535d25467

8223570: Shenandoah needs to acquire lock before CLDG::clear_claimed_marks
Reviewed-by: rkennke, tschatzl

! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 7dbe51e680d1
Author:    rraghavan
Date:      2019-05-08 18:05 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7dbe51e680d1

8223445: compiler/intrinsics/mathexact/LongMulOverflowTest.java java timeout
Summary: Problem list the test with Graal because it uses -Xcomp in combination with -XX:-TieredCompilation
Reviewed-by: kvn, thartmann

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 57fbbef65a26
Author:    tonyp
Date:      2019-05-08 09:38 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/57fbbef65a26

8223397: gc+promotion log lines are missing the GC id
Reviewed-by: tschatzl, pliden

! src/hotspot/share/logging/logPrefix.hpp

Changeset: a5b33a664b4f
Author:    hseigel
Date:      2019-05-08 10:08 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a5b33a664b4f

8217846: [Graal] vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts003/instancecounts003.java crash
Summary: Make sure the array calls's mirror was successfully created before putting the array class on its class loader data list
Reviewed-by: lfoltan, coleenp

! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/typeArrayKlass.cpp

Changeset: 64d9a4d582bc
Author:    vromero
Date:      2019-05-08 10:10 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/64d9a4d582bc

8222949: add condy support to javac's pool API
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Items.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/PoolWriter.java
+ test/langtools/tools/javac/T8222949/TestConstantDynamic.java

Changeset: 2584e5772546
Author:    aoqi
Date:      2019-05-08 20:57 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2584e5772546

8222926: Shenandoah build fails with --with-jvm-features=-compiler1
Reviewed-by: shade, rkennke
Contributed-by: Ao Qi <aoqi at loongson.cn>

+ src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
- src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
+ src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
- src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/share/code/codeBlob.cpp
! src/hotspot/share/jvmci/vmStructs_jvmci.cpp

Changeset: 865ec913f916
Author:    gziemski
Date:      2019-05-08 11:11 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/865ec913f916

8185525: Add JFR event for DictionarySizes
Summary: Added TableStatistics event
Reviewed-by: egahlin, coleenp

! src/hotspot/share/classfile/classLoaderDataGraph.cpp
! src/hotspot/share/classfile/classLoaderDataGraph.hpp
! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/stringTable.hpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/symbolTable.hpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/systemDictionary.hpp
! src/hotspot/share/jfr/metadata/metadata.xml
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/hotspot/share/memory/allocation.hpp
! src/hotspot/share/utilities/concurrentHashTable.hpp
! src/hotspot/share/utilities/concurrentHashTable.inline.hpp
! src/hotspot/share/utilities/hashtable.cpp
! src/hotspot/share/utilities/hashtable.hpp
! src/hotspot/share/utilities/hashtable.inline.hpp
+ src/hotspot/share/utilities/tableStatistics.cpp
+ src/hotspot/share/utilities/tableStatistics.hpp
! src/jdk.jfr/share/conf/jfr/default.jfc
! src/jdk.jfr/share/conf/jfr/profile.jfc
+ test/jdk/jdk/jfr/event/runtime/TestTableStatisticsEvent.java
! test/lib/jdk/test/lib/jfr/EventNames.java

Changeset: cc6053cbd811
Author:    coleenp
Date:      2019-05-08 13:22 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cc6053cbd811

8223534: add back fixed test_markOop.cpp
Summary: The test needed wait_with_safepoint_check in the main thread.
Reviewed-by: dcubed

+ test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 1321f8cf9de5
Author:    rkennke
Date:      2019-05-08 20:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1321f8cf9de5

8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSetAssembler.hpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.hpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: 6ccc7cd7931e
Author:    epavlova
Date:      2019-05-08 11:56 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6ccc7cd7931e

8223414: ProblemList java/lang/ref/ReachabilityFenceTest.java when running in Graal as JIT mode
Reviewed-by: kvn

! test/jdk/ProblemList-graal.txt

Changeset: 6f6b636d2909
Author:    shade
Date:      2019-05-08 21:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6f6b636d2909

8223583: Build failure after JDK-8223567 (Rename ShenandoahBrooksPointer to ShenandoahForwarding)
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: 925ee7a89325
Author:    naoto
Date:      2019-05-08 12:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/925ee7a89325

8221432: Upgrade CLDR to Version 35.1
Reviewed-by: rriggs, srl

! make/data/cldr/README
! make/data/cldr/common/bcp47/timezone.xml
! make/data/cldr/common/dtd/ldml.dtd
! make/data/cldr/common/dtd/ldmlBCP47.dtd
! make/data/cldr/common/dtd/ldmlSupplemental.dtd
! make/data/cldr/common/main/af.xml
! make/data/cldr/common/main/af_NA.xml
! make/data/cldr/common/main/af_ZA.xml
! make/data/cldr/common/main/agq.xml
! make/data/cldr/common/main/agq_CM.xml
! make/data/cldr/common/main/ak.xml
! make/data/cldr/common/main/ak_GH.xml
! make/data/cldr/common/main/am.xml
! make/data/cldr/common/main/am_ET.xml
! make/data/cldr/common/main/ar.xml
! make/data/cldr/common/main/ar_001.xml
! make/data/cldr/common/main/ar_AE.xml
! make/data/cldr/common/main/ar_BH.xml
! make/data/cldr/common/main/ar_DJ.xml
! make/data/cldr/common/main/ar_DZ.xml
! make/data/cldr/common/main/ar_EG.xml
! make/data/cldr/common/main/ar_EH.xml
! make/data/cldr/common/main/ar_ER.xml
! make/data/cldr/common/main/ar_IL.xml
! make/data/cldr/common/main/ar_IQ.xml
! make/data/cldr/common/main/ar_JO.xml
! make/data/cldr/common/main/ar_KM.xml
! make/data/cldr/common/main/ar_KW.xml
! make/data/cldr/common/main/ar_LB.xml
! make/data/cldr/common/main/ar_LY.xml
! make/data/cldr/common/main/ar_MA.xml
! make/data/cldr/common/main/ar_MR.xml
! make/data/cldr/common/main/ar_OM.xml
! make/data/cldr/common/main/ar_PS.xml
! make/data/cldr/common/main/ar_QA.xml
! make/data/cldr/common/main/ar_SA.xml
! make/data/cldr/common/main/ar_SD.xml
! make/data/cldr/common/main/ar_SO.xml
! make/data/cldr/common/main/ar_SS.xml
! make/data/cldr/common/main/ar_SY.xml
! make/data/cldr/common/main/ar_TD.xml
! make/data/cldr/common/main/ar_TN.xml
! make/data/cldr/common/main/ar_YE.xml
! make/data/cldr/common/main/as.xml
! make/data/cldr/common/main/as_IN.xml
! make/data/cldr/common/main/asa.xml
! make/data/cldr/common/main/asa_TZ.xml
! make/data/cldr/common/main/ast.xml
! make/data/cldr/common/main/ast_ES.xml
! make/data/cldr/common/main/az.xml
! make/data/cldr/common/main/az_Cyrl.xml
! make/data/cldr/common/main/az_Cyrl_AZ.xml
! make/data/cldr/common/main/az_Latn.xml
! make/data/cldr/common/main/az_Latn_AZ.xml
! make/data/cldr/common/main/bas.xml
! make/data/cldr/common/main/bas_CM.xml
! make/data/cldr/common/main/be.xml
! make/data/cldr/common/main/be_BY.xml
! make/data/cldr/common/main/bem.xml
! make/data/cldr/common/main/bem_ZM.xml
! make/data/cldr/common/main/bez.xml
! make/data/cldr/common/main/bez_TZ.xml
! make/data/cldr/common/main/bg.xml
! make/data/cldr/common/main/bg_BG.xml
! make/data/cldr/common/main/bm.xml
! make/data/cldr/common/main/bm_ML.xml
! make/data/cldr/common/main/bn.xml
! make/data/cldr/common/main/bn_BD.xml
! make/data/cldr/common/main/bn_IN.xml
! make/data/cldr/common/main/bo.xml
! make/data/cldr/common/main/bo_CN.xml
! make/data/cldr/common/main/bo_IN.xml
! make/data/cldr/common/main/br.xml
! make/data/cldr/common/main/br_FR.xml
! make/data/cldr/common/main/brx.xml
! make/data/cldr/common/main/brx_IN.xml
! make/data/cldr/common/main/bs.xml
! make/data/cldr/common/main/bs_Cyrl.xml
! make/data/cldr/common/main/bs_Cyrl_BA.xml
! make/data/cldr/common/main/bs_Latn.xml
! make/data/cldr/common/main/bs_Latn_BA.xml
! make/data/cldr/common/main/ca.xml
! make/data/cldr/common/main/ca_AD.xml
! make/data/cldr/common/main/ca_ES.xml
! make/data/cldr/common/main/ca_ES_VALENCIA.xml
! make/data/cldr/common/main/ca_FR.xml
! make/data/cldr/common/main/ca_IT.xml
! make/data/cldr/common/main/ccp.xml
! make/data/cldr/common/main/ccp_BD.xml
! make/data/cldr/common/main/ccp_IN.xml
! make/data/cldr/common/main/ce.xml
! make/data/cldr/common/main/ce_RU.xml
+ make/data/cldr/common/main/ceb.xml
+ make/data/cldr/common/main/ceb_PH.xml
! make/data/cldr/common/main/cgg.xml
! make/data/cldr/common/main/cgg_UG.xml
! make/data/cldr/common/main/chr.xml
! make/data/cldr/common/main/chr_US.xml
! make/data/cldr/common/main/ckb.xml
! make/data/cldr/common/main/ckb_IQ.xml
! make/data/cldr/common/main/ckb_IR.xml
! make/data/cldr/common/main/cs.xml
! make/data/cldr/common/main/cs_CZ.xml
! make/data/cldr/common/main/cu.xml
! make/data/cldr/common/main/cu_RU.xml
! make/data/cldr/common/main/cy.xml
! make/data/cldr/common/main/cy_GB.xml
! make/data/cldr/common/main/da.xml
! make/data/cldr/common/main/da_DK.xml
! make/data/cldr/common/main/da_GL.xml
! make/data/cldr/common/main/dav.xml
! make/data/cldr/common/main/dav_KE.xml
! make/data/cldr/common/main/de.xml
! make/data/cldr/common/main/de_AT.xml
! make/data/cldr/common/main/de_BE.xml
! make/data/cldr/common/main/de_CH.xml
! make/data/cldr/common/main/de_DE.xml
! make/data/cldr/common/main/de_IT.xml
! make/data/cldr/common/main/de_LI.xml
! make/data/cldr/common/main/de_LU.xml
! make/data/cldr/common/main/dje.xml
! make/data/cldr/common/main/dje_NE.xml
! make/data/cldr/common/main/dsb.xml
! make/data/cldr/common/main/dsb_DE.xml
! make/data/cldr/common/main/dua.xml
! make/data/cldr/common/main/dua_CM.xml
! make/data/cldr/common/main/dyo.xml
! make/data/cldr/common/main/dyo_SN.xml
! make/data/cldr/common/main/dz.xml
! make/data/cldr/common/main/dz_BT.xml
! make/data/cldr/common/main/ebu.xml
! make/data/cldr/common/main/ebu_KE.xml
! make/data/cldr/common/main/ee.xml
! make/data/cldr/common/main/ee_GH.xml
! make/data/cldr/common/main/ee_TG.xml
! make/data/cldr/common/main/el.xml
! make/data/cldr/common/main/el_CY.xml
! make/data/cldr/common/main/el_GR.xml
! make/data/cldr/common/main/en.xml
! make/data/cldr/common/main/en_001.xml
! make/data/cldr/common/main/en_150.xml
+ make/data/cldr/common/main/en_AE.xml
! make/data/cldr/common/main/en_AG.xml
! make/data/cldr/common/main/en_AI.xml
! make/data/cldr/common/main/en_AS.xml
! make/data/cldr/common/main/en_AT.xml
! make/data/cldr/common/main/en_AU.xml
! make/data/cldr/common/main/en_BB.xml
! make/data/cldr/common/main/en_BE.xml
! make/data/cldr/common/main/en_BI.xml
! make/data/cldr/common/main/en_BM.xml
! make/data/cldr/common/main/en_BS.xml
! make/data/cldr/common/main/en_BW.xml
! make/data/cldr/common/main/en_BZ.xml
! make/data/cldr/common/main/en_CA.xml
! make/data/cldr/common/main/en_CC.xml
! make/data/cldr/common/main/en_CH.xml
! make/data/cldr/common/main/en_CK.xml
! make/data/cldr/common/main/en_CM.xml
! make/data/cldr/common/main/en_CX.xml
! make/data/cldr/common/main/en_CY.xml
! make/data/cldr/common/main/en_DE.xml
! make/data/cldr/common/main/en_DG.xml
! make/data/cldr/common/main/en_DK.xml
! make/data/cldr/common/main/en_DM.xml
! make/data/cldr/common/main/en_ER.xml
! make/data/cldr/common/main/en_FI.xml
! make/data/cldr/common/main/en_FJ.xml
! make/data/cldr/common/main/en_FK.xml
! make/data/cldr/common/main/en_FM.xml
! make/data/cldr/common/main/en_GB.xml
! make/data/cldr/common/main/en_GD.xml
! make/data/cldr/common/main/en_GG.xml
! make/data/cldr/common/main/en_GH.xml
! make/data/cldr/common/main/en_GI.xml
! make/data/cldr/common/main/en_GM.xml
! make/data/cldr/common/main/en_GU.xml
! make/data/cldr/common/main/en_GY.xml
! make/data/cldr/common/main/en_HK.xml
! make/data/cldr/common/main/en_IE.xml
! make/data/cldr/common/main/en_IL.xml
! make/data/cldr/common/main/en_IM.xml
! make/data/cldr/common/main/en_IN.xml
! make/data/cldr/common/main/en_IO.xml
! make/data/cldr/common/main/en_JE.xml
! make/data/cldr/common/main/en_JM.xml
! make/data/cldr/common/main/en_KE.xml
! make/data/cldr/common/main/en_KI.xml
! make/data/cldr/common/main/en_KN.xml
! make/data/cldr/common/main/en_KY.xml
! make/data/cldr/common/main/en_LC.xml
! make/data/cldr/common/main/en_LR.xml
! make/data/cldr/common/main/en_LS.xml
! make/data/cldr/common/main/en_MG.xml
! make/data/cldr/common/main/en_MH.xml
! make/data/cldr/common/main/en_MO.xml
! make/data/cldr/common/main/en_MP.xml
! make/data/cldr/common/main/en_MS.xml
! make/data/cldr/common/main/en_MT.xml
! make/data/cldr/common/main/en_MU.xml
! make/data/cldr/common/main/en_MW.xml
! make/data/cldr/common/main/en_MY.xml
! make/data/cldr/common/main/en_NA.xml
! make/data/cldr/common/main/en_NF.xml
! make/data/cldr/common/main/en_NG.xml
! make/data/cldr/common/main/en_NL.xml
! make/data/cldr/common/main/en_NR.xml
! make/data/cldr/common/main/en_NU.xml
! make/data/cldr/common/main/en_NZ.xml
! make/data/cldr/common/main/en_PG.xml
! make/data/cldr/common/main/en_PH.xml
! make/data/cldr/common/main/en_PK.xml
! make/data/cldr/common/main/en_PN.xml
! make/data/cldr/common/main/en_PR.xml
! make/data/cldr/common/main/en_PW.xml
! make/data/cldr/common/main/en_RW.xml
! make/data/cldr/common/main/en_SB.xml
! make/data/cldr/common/main/en_SC.xml
! make/data/cldr/common/main/en_SD.xml
! make/data/cldr/common/main/en_SE.xml
! make/data/cldr/common/main/en_SG.xml
! make/data/cldr/common/main/en_SH.xml
! make/data/cldr/common/main/en_SI.xml
! make/data/cldr/common/main/en_SL.xml
! make/data/cldr/common/main/en_SS.xml
! make/data/cldr/common/main/en_SX.xml
! make/data/cldr/common/main/en_SZ.xml
! make/data/cldr/common/main/en_TC.xml
! make/data/cldr/common/main/en_TK.xml
! make/data/cldr/common/main/en_TO.xml
! make/data/cldr/common/main/en_TT.xml
! make/data/cldr/common/main/en_TV.xml
! make/data/cldr/common/main/en_TZ.xml
! make/data/cldr/common/main/en_UG.xml
! make/data/cldr/common/main/en_UM.xml
! make/data/cldr/common/main/en_US.xml
! make/data/cldr/common/main/en_US_POSIX.xml
! make/data/cldr/common/main/en_VC.xml
! make/data/cldr/common/main/en_VG.xml
! make/data/cldr/common/main/en_VI.xml
! make/data/cldr/common/main/en_VU.xml
! make/data/cldr/common/main/en_WS.xml
! make/data/cldr/common/main/en_ZA.xml
! make/data/cldr/common/main/en_ZM.xml
! make/data/cldr/common/main/en_ZW.xml
! make/data/cldr/common/main/eo.xml
! make/data/cldr/common/main/eo_001.xml
! make/data/cldr/common/main/es.xml
! make/data/cldr/common/main/es_419.xml
! make/data/cldr/common/main/es_AR.xml
! make/data/cldr/common/main/es_BO.xml
! make/data/cldr/common/main/es_BR.xml
! make/data/cldr/common/main/es_BZ.xml
! make/data/cldr/common/main/es_CL.xml
! make/data/cldr/common/main/es_CO.xml
! make/data/cldr/common/main/es_CR.xml
! make/data/cldr/common/main/es_CU.xml
! make/data/cldr/common/main/es_DO.xml
! make/data/cldr/common/main/es_EA.xml
! make/data/cldr/common/main/es_EC.xml
! make/data/cldr/common/main/es_ES.xml
! make/data/cldr/common/main/es_GQ.xml
! make/data/cldr/common/main/es_GT.xml
! make/data/cldr/common/main/es_HN.xml
! make/data/cldr/common/main/es_IC.xml
! make/data/cldr/common/main/es_MX.xml
! make/data/cldr/common/main/es_NI.xml
! make/data/cldr/common/main/es_PA.xml
! make/data/cldr/common/main/es_PE.xml
! make/data/cldr/common/main/es_PH.xml
! make/data/cldr/common/main/es_PR.xml
! make/data/cldr/common/main/es_PY.xml
! make/data/cldr/common/main/es_SV.xml
! make/data/cldr/common/main/es_US.xml
! make/data/cldr/common/main/es_UY.xml
! make/data/cldr/common/main/es_VE.xml
! make/data/cldr/common/main/et.xml
! make/data/cldr/common/main/et_EE.xml
! make/data/cldr/common/main/eu.xml
! make/data/cldr/common/main/eu_ES.xml
! make/data/cldr/common/main/ewo.xml
! make/data/cldr/common/main/ewo_CM.xml
! make/data/cldr/common/main/fa.xml
! make/data/cldr/common/main/fa_AF.xml
! make/data/cldr/common/main/fa_IR.xml
! make/data/cldr/common/main/ff.xml
- make/data/cldr/common/main/ff_CM.xml
- make/data/cldr/common/main/ff_GN.xml
+ make/data/cldr/common/main/ff_Latn.xml
+ make/data/cldr/common/main/ff_Latn_BF.xml
+ make/data/cldr/common/main/ff_Latn_CM.xml
+ make/data/cldr/common/main/ff_Latn_GH.xml
+ make/data/cldr/common/main/ff_Latn_GM.xml
+ make/data/cldr/common/main/ff_Latn_GN.xml
+ make/data/cldr/common/main/ff_Latn_GW.xml
+ make/data/cldr/common/main/ff_Latn_LR.xml
+ make/data/cldr/common/main/ff_Latn_MR.xml
+ make/data/cldr/common/main/ff_Latn_NE.xml
+ make/data/cldr/common/main/ff_Latn_NG.xml
+ make/data/cldr/common/main/ff_Latn_SL.xml
+ make/data/cldr/common/main/ff_Latn_SN.xml
- make/data/cldr/common/main/ff_MR.xml
- make/data/cldr/common/main/ff_SN.xml
! make/data/cldr/common/main/fi.xml
! make/data/cldr/common/main/fi_FI.xml
! make/data/cldr/common/main/fil.xml
! make/data/cldr/common/main/fil_PH.xml
! make/data/cldr/common/main/fo.xml
! make/data/cldr/common/main/fo_DK.xml
! make/data/cldr/common/main/fo_FO.xml
! make/data/cldr/common/main/fr.xml
! make/data/cldr/common/main/fr_BE.xml
! make/data/cldr/common/main/fr_BF.xml
! make/data/cldr/common/main/fr_BI.xml
! make/data/cldr/common/main/fr_BJ.xml
! make/data/cldr/common/main/fr_BL.xml
! make/data/cldr/common/main/fr_CA.xml
! make/data/cldr/common/main/fr_CD.xml
! make/data/cldr/common/main/fr_CF.xml
! make/data/cldr/common/main/fr_CG.xml
! make/data/cldr/common/main/fr_CH.xml
! make/data/cldr/common/main/fr_CI.xml
! make/data/cldr/common/main/fr_CM.xml
! make/data/cldr/common/main/fr_DJ.xml
! make/data/cldr/common/main/fr_DZ.xml
! make/data/cldr/common/main/fr_FR.xml
! make/data/cldr/common/main/fr_GA.xml
! make/data/cldr/common/main/fr_GF.xml
! make/data/cldr/common/main/fr_GN.xml
! make/data/cldr/common/main/fr_GP.xml
! make/data/cldr/common/main/fr_GQ.xml
! make/data/cldr/common/main/fr_HT.xml
! make/data/cldr/common/main/fr_KM.xml
! make/data/cldr/common/main/fr_LU.xml
! make/data/cldr/common/main/fr_MA.xml
! make/data/cldr/common/main/fr_MC.xml
! make/data/cldr/common/main/fr_MF.xml
! make/data/cldr/common/main/fr_MG.xml
! make/data/cldr/common/main/fr_ML.xml
! make/data/cldr/common/main/fr_MQ.xml
! make/data/cldr/common/main/fr_MR.xml
! make/data/cldr/common/main/fr_MU.xml
! make/data/cldr/common/main/fr_NC.xml
! make/data/cldr/common/main/fr_NE.xml
! make/data/cldr/common/main/fr_PF.xml
! make/data/cldr/common/main/fr_PM.xml
! make/data/cldr/common/main/fr_RE.xml
! make/data/cldr/common/main/fr_RW.xml
! make/data/cldr/common/main/fr_SC.xml
! make/data/cldr/common/main/fr_SN.xml
! make/data/cldr/common/main/fr_SY.xml
! make/data/cldr/common/main/fr_TD.xml
! make/data/cldr/common/main/fr_TG.xml
! make/data/cldr/common/main/fr_TN.xml
! make/data/cldr/common/main/fr_VU.xml
! make/data/cldr/common/main/fr_WF.xml
! make/data/cldr/common/main/fr_YT.xml
! make/data/cldr/common/main/fur.xml
! make/data/cldr/common/main/fur_IT.xml
! make/data/cldr/common/main/fy.xml
! make/data/cldr/common/main/fy_NL.xml
! make/data/cldr/common/main/ga.xml
! make/data/cldr/common/main/ga_IE.xml
! make/data/cldr/common/main/gd.xml
! make/data/cldr/common/main/gd_GB.xml
! make/data/cldr/common/main/gl.xml
! make/data/cldr/common/main/gl_ES.xml
! make/data/cldr/common/main/gsw.xml
! make/data/cldr/common/main/gsw_CH.xml
! make/data/cldr/common/main/gsw_FR.xml
! make/data/cldr/common/main/gsw_LI.xml
! make/data/cldr/common/main/gu.xml
! make/data/cldr/common/main/gu_IN.xml
! make/data/cldr/common/main/guz.xml
! make/data/cldr/common/main/guz_KE.xml
! make/data/cldr/common/main/gv.xml
! make/data/cldr/common/main/gv_IM.xml
! make/data/cldr/common/main/ha.xml
! make/data/cldr/common/main/ha_GH.xml
! make/data/cldr/common/main/ha_NE.xml
! make/data/cldr/common/main/ha_NG.xml
! make/data/cldr/common/main/haw.xml
! make/data/cldr/common/main/haw_US.xml
! make/data/cldr/common/main/he.xml
! make/data/cldr/common/main/he_IL.xml
! make/data/cldr/common/main/hi.xml
! make/data/cldr/common/main/hi_IN.xml
! make/data/cldr/common/main/hr.xml
! make/data/cldr/common/main/hr_BA.xml
! make/data/cldr/common/main/hr_HR.xml
! make/data/cldr/common/main/hsb.xml
! make/data/cldr/common/main/hsb_DE.xml
! make/data/cldr/common/main/hu.xml
! make/data/cldr/common/main/hu_HU.xml
! make/data/cldr/common/main/hy.xml
! make/data/cldr/common/main/hy_AM.xml
+ make/data/cldr/common/main/ia.xml
+ make/data/cldr/common/main/ia_001.xml
! make/data/cldr/common/main/id.xml
! make/data/cldr/common/main/id_ID.xml
! make/data/cldr/common/main/ig.xml
! make/data/cldr/common/main/ig_NG.xml
! make/data/cldr/common/main/ii.xml
! make/data/cldr/common/main/ii_CN.xml
! make/data/cldr/common/main/is.xml
! make/data/cldr/common/main/is_IS.xml
! make/data/cldr/common/main/it.xml
! make/data/cldr/common/main/it_CH.xml
! make/data/cldr/common/main/it_IT.xml
! make/data/cldr/common/main/it_SM.xml
! make/data/cldr/common/main/it_VA.xml
! make/data/cldr/common/main/ja.xml
! make/data/cldr/common/main/ja_JP.xml
! make/data/cldr/common/main/jgo.xml
! make/data/cldr/common/main/jgo_CM.xml
! make/data/cldr/common/main/jmc.xml
! make/data/cldr/common/main/jmc_TZ.xml
+ make/data/cldr/common/main/jv.xml
+ make/data/cldr/common/main/jv_ID.xml
! make/data/cldr/common/main/ka.xml
! make/data/cldr/common/main/ka_GE.xml
! make/data/cldr/common/main/kab.xml
! make/data/cldr/common/main/kab_DZ.xml
! make/data/cldr/common/main/kam.xml
! make/data/cldr/common/main/kam_KE.xml
! make/data/cldr/common/main/kde.xml
! make/data/cldr/common/main/kde_TZ.xml
! make/data/cldr/common/main/kea.xml
! make/data/cldr/common/main/kea_CV.xml
! make/data/cldr/common/main/khq.xml
! make/data/cldr/common/main/khq_ML.xml
! make/data/cldr/common/main/ki.xml
! make/data/cldr/common/main/ki_KE.xml
! make/data/cldr/common/main/kk.xml
! make/data/cldr/common/main/kk_KZ.xml
! make/data/cldr/common/main/kkj.xml
! make/data/cldr/common/main/kkj_CM.xml
! make/data/cldr/common/main/kl.xml
! make/data/cldr/common/main/kl_GL.xml
! make/data/cldr/common/main/kln.xml
! make/data/cldr/common/main/kln_KE.xml
! make/data/cldr/common/main/km.xml
! make/data/cldr/common/main/km_KH.xml
! make/data/cldr/common/main/kn.xml
! make/data/cldr/common/main/kn_IN.xml
! make/data/cldr/common/main/ko.xml
! make/data/cldr/common/main/ko_KP.xml
! make/data/cldr/common/main/ko_KR.xml
! make/data/cldr/common/main/kok.xml
! make/data/cldr/common/main/kok_IN.xml
! make/data/cldr/common/main/ks.xml
! make/data/cldr/common/main/ks_IN.xml
! make/data/cldr/common/main/ksb.xml
! make/data/cldr/common/main/ksb_TZ.xml
! make/data/cldr/common/main/ksf.xml
! make/data/cldr/common/main/ksf_CM.xml
! make/data/cldr/common/main/ksh.xml
! make/data/cldr/common/main/ksh_DE.xml
+ make/data/cldr/common/main/ku.xml
+ make/data/cldr/common/main/ku_TR.xml
! make/data/cldr/common/main/kw.xml
! make/data/cldr/common/main/kw_GB.xml
! make/data/cldr/common/main/ky.xml
! make/data/cldr/common/main/ky_KG.xml
! make/data/cldr/common/main/lag.xml
! make/data/cldr/common/main/lag_TZ.xml
! make/data/cldr/common/main/lb.xml
! make/data/cldr/common/main/lb_LU.xml
! make/data/cldr/common/main/lg.xml
! make/data/cldr/common/main/lg_UG.xml
! make/data/cldr/common/main/lkt.xml
! make/data/cldr/common/main/lkt_US.xml
! make/data/cldr/common/main/ln.xml
! make/data/cldr/common/main/ln_AO.xml
! make/data/cldr/common/main/ln_CD.xml
! make/data/cldr/common/main/ln_CF.xml
! make/data/cldr/common/main/ln_CG.xml
! make/data/cldr/common/main/lo.xml
! make/data/cldr/common/main/lo_LA.xml
! make/data/cldr/common/main/lrc.xml
! make/data/cldr/common/main/lrc_IQ.xml
! make/data/cldr/common/main/lrc_IR.xml
! make/data/cldr/common/main/lt.xml
! make/data/cldr/common/main/lt_LT.xml
! make/data/cldr/common/main/lu.xml
! make/data/cldr/common/main/lu_CD.xml
! make/data/cldr/common/main/luo.xml
! make/data/cldr/common/main/luo_KE.xml
! make/data/cldr/common/main/luy.xml
! make/data/cldr/common/main/luy_KE.xml
! make/data/cldr/common/main/lv.xml
! make/data/cldr/common/main/lv_LV.xml
! make/data/cldr/common/main/mas.xml
! make/data/cldr/common/main/mas_KE.xml
! make/data/cldr/common/main/mas_TZ.xml
! make/data/cldr/common/main/mer.xml
! make/data/cldr/common/main/mer_KE.xml
! make/data/cldr/common/main/mfe.xml
! make/data/cldr/common/main/mfe_MU.xml
! make/data/cldr/common/main/mg.xml
! make/data/cldr/common/main/mg_MG.xml
! make/data/cldr/common/main/mgh.xml
! make/data/cldr/common/main/mgh_MZ.xml
! make/data/cldr/common/main/mgo.xml
! make/data/cldr/common/main/mgo_CM.xml
+ make/data/cldr/common/main/mi.xml
+ make/data/cldr/common/main/mi_NZ.xml
! make/data/cldr/common/main/mk.xml
! make/data/cldr/common/main/mk_MK.xml
! make/data/cldr/common/main/ml.xml
! make/data/cldr/common/main/ml_IN.xml
! make/data/cldr/common/main/mn.xml
! make/data/cldr/common/main/mn_MN.xml
! make/data/cldr/common/main/mr.xml
! make/data/cldr/common/main/mr_IN.xml
! make/data/cldr/common/main/ms.xml
! make/data/cldr/common/main/ms_BN.xml
! make/data/cldr/common/main/ms_MY.xml
! make/data/cldr/common/main/ms_SG.xml
! make/data/cldr/common/main/mt.xml
! make/data/cldr/common/main/mt_MT.xml
! make/data/cldr/common/main/mua.xml
! make/data/cldr/common/main/mua_CM.xml
! make/data/cldr/common/main/my.xml
! make/data/cldr/common/main/my_MM.xml
! make/data/cldr/common/main/mzn.xml
! make/data/cldr/common/main/mzn_IR.xml
! make/data/cldr/common/main/naq.xml
! make/data/cldr/common/main/naq_NA.xml
! make/data/cldr/common/main/nb.xml
! make/data/cldr/common/main/nb_NO.xml
! make/data/cldr/common/main/nb_SJ.xml
! make/data/cldr/common/main/nd.xml
! make/data/cldr/common/main/nd_ZW.xml
! make/data/cldr/common/main/nds.xml
! make/data/cldr/common/main/nds_DE.xml
! make/data/cldr/common/main/nds_NL.xml
! make/data/cldr/common/main/ne.xml
! make/data/cldr/common/main/ne_IN.xml
! make/data/cldr/common/main/ne_NP.xml
! make/data/cldr/common/main/nl.xml
! make/data/cldr/common/main/nl_AW.xml
! make/data/cldr/common/main/nl_BE.xml
! make/data/cldr/common/main/nl_BQ.xml
! make/data/cldr/common/main/nl_CW.xml
! make/data/cldr/common/main/nl_NL.xml
! make/data/cldr/common/main/nl_SR.xml
! make/data/cldr/common/main/nl_SX.xml
! make/data/cldr/common/main/nmg.xml
! make/data/cldr/common/main/nmg_CM.xml
! make/data/cldr/common/main/nn.xml
! make/data/cldr/common/main/nn_NO.xml
! make/data/cldr/common/main/nnh.xml
! make/data/cldr/common/main/nnh_CM.xml
! make/data/cldr/common/main/nus.xml
! make/data/cldr/common/main/nus_SS.xml
! make/data/cldr/common/main/nyn.xml
! make/data/cldr/common/main/nyn_UG.xml
! make/data/cldr/common/main/om.xml
! make/data/cldr/common/main/om_ET.xml
! make/data/cldr/common/main/om_KE.xml
! make/data/cldr/common/main/or.xml
! make/data/cldr/common/main/or_IN.xml
! make/data/cldr/common/main/os.xml
! make/data/cldr/common/main/os_GE.xml
! make/data/cldr/common/main/os_RU.xml
! make/data/cldr/common/main/pa.xml
! make/data/cldr/common/main/pa_Arab.xml
! make/data/cldr/common/main/pa_Arab_PK.xml
! make/data/cldr/common/main/pa_Guru.xml
! make/data/cldr/common/main/pa_Guru_IN.xml
! make/data/cldr/common/main/pl.xml
! make/data/cldr/common/main/pl_PL.xml
! make/data/cldr/common/main/prg.xml
! make/data/cldr/common/main/prg_001.xml
! make/data/cldr/common/main/ps.xml
! make/data/cldr/common/main/ps_AF.xml
+ make/data/cldr/common/main/ps_PK.xml
! make/data/cldr/common/main/pt.xml
! make/data/cldr/common/main/pt_AO.xml
! make/data/cldr/common/main/pt_BR.xml
! make/data/cldr/common/main/pt_CH.xml
! make/data/cldr/common/main/pt_CV.xml
! make/data/cldr/common/main/pt_GQ.xml
! make/data/cldr/common/main/pt_GW.xml
! make/data/cldr/common/main/pt_LU.xml
! make/data/cldr/common/main/pt_MO.xml
! make/data/cldr/common/main/pt_MZ.xml
! make/data/cldr/common/main/pt_PT.xml
! make/data/cldr/common/main/pt_ST.xml
! make/data/cldr/common/main/pt_TL.xml
! make/data/cldr/common/main/qu.xml
! make/data/cldr/common/main/qu_BO.xml
! make/data/cldr/common/main/qu_EC.xml
! make/data/cldr/common/main/qu_PE.xml
! make/data/cldr/common/main/rm.xml
! make/data/cldr/common/main/rm_CH.xml
! make/data/cldr/common/main/rn.xml
! make/data/cldr/common/main/rn_BI.xml
! make/data/cldr/common/main/ro.xml
! make/data/cldr/common/main/ro_MD.xml
! make/data/cldr/common/main/ro_RO.xml
! make/data/cldr/common/main/rof.xml
! make/data/cldr/common/main/rof_TZ.xml
! make/data/cldr/common/main/root.xml
! make/data/cldr/common/main/ru.xml
! make/data/cldr/common/main/ru_BY.xml
! make/data/cldr/common/main/ru_KG.xml
! make/data/cldr/common/main/ru_KZ.xml
! make/data/cldr/common/main/ru_MD.xml
! make/data/cldr/common/main/ru_RU.xml
! make/data/cldr/common/main/ru_UA.xml
! make/data/cldr/common/main/rw.xml
! make/data/cldr/common/main/rw_RW.xml
! make/data/cldr/common/main/rwk.xml
! make/data/cldr/common/main/rwk_TZ.xml
! make/data/cldr/common/main/sah.xml
! make/data/cldr/common/main/sah_RU.xml
! make/data/cldr/common/main/saq.xml
! make/data/cldr/common/main/saq_KE.xml
! make/data/cldr/common/main/sbp.xml
! make/data/cldr/common/main/sbp_TZ.xml
! make/data/cldr/common/main/sd.xml
! make/data/cldr/common/main/sd_PK.xml
! make/data/cldr/common/main/se.xml
! make/data/cldr/common/main/se_FI.xml
! make/data/cldr/common/main/se_NO.xml
! make/data/cldr/common/main/se_SE.xml
! make/data/cldr/common/main/seh.xml
! make/data/cldr/common/main/seh_MZ.xml
! make/data/cldr/common/main/ses.xml
! make/data/cldr/common/main/ses_ML.xml
! make/data/cldr/common/main/sg.xml
! make/data/cldr/common/main/sg_CF.xml
! make/data/cldr/common/main/shi.xml
! make/data/cldr/common/main/shi_Latn.xml
! make/data/cldr/common/main/shi_Latn_MA.xml
! make/data/cldr/common/main/shi_Tfng.xml
! make/data/cldr/common/main/shi_Tfng_MA.xml
! make/data/cldr/common/main/si.xml
! make/data/cldr/common/main/si_LK.xml
! make/data/cldr/common/main/sk.xml
! make/data/cldr/common/main/sk_SK.xml
! make/data/cldr/common/main/sl.xml
! make/data/cldr/common/main/sl_SI.xml
! make/data/cldr/common/main/smn.xml
! make/data/cldr/common/main/smn_FI.xml
! make/data/cldr/common/main/sn.xml
! make/data/cldr/common/main/sn_ZW.xml
! make/data/cldr/common/main/so.xml
! make/data/cldr/common/main/so_DJ.xml
! make/data/cldr/common/main/so_ET.xml
! make/data/cldr/common/main/so_KE.xml
! make/data/cldr/common/main/so_SO.xml
! make/data/cldr/common/main/sq.xml
! make/data/cldr/common/main/sq_AL.xml
! make/data/cldr/common/main/sq_MK.xml
! make/data/cldr/common/main/sq_XK.xml
! make/data/cldr/common/main/sr.xml
! make/data/cldr/common/main/sr_Cyrl.xml
! make/data/cldr/common/main/sr_Cyrl_BA.xml
! make/data/cldr/common/main/sr_Cyrl_ME.xml
! make/data/cldr/common/main/sr_Cyrl_RS.xml
! make/data/cldr/common/main/sr_Cyrl_XK.xml
! make/data/cldr/common/main/sr_Latn.xml
! make/data/cldr/common/main/sr_Latn_BA.xml
! make/data/cldr/common/main/sr_Latn_ME.xml
! make/data/cldr/common/main/sr_Latn_RS.xml
! make/data/cldr/common/main/sr_Latn_XK.xml
! make/data/cldr/common/main/sv.xml
! make/data/cldr/common/main/sv_AX.xml
! make/data/cldr/common/main/sv_FI.xml
! make/data/cldr/common/main/sv_SE.xml
! make/data/cldr/common/main/sw.xml
! make/data/cldr/common/main/sw_CD.xml
! make/data/cldr/common/main/sw_KE.xml
! make/data/cldr/common/main/sw_TZ.xml
! make/data/cldr/common/main/sw_UG.xml
! make/data/cldr/common/main/ta.xml
! make/data/cldr/common/main/ta_IN.xml
! make/data/cldr/common/main/ta_LK.xml
! make/data/cldr/common/main/ta_MY.xml
! make/data/cldr/common/main/ta_SG.xml
! make/data/cldr/common/main/te.xml
! make/data/cldr/common/main/te_IN.xml
! make/data/cldr/common/main/teo.xml
! make/data/cldr/common/main/teo_KE.xml
! make/data/cldr/common/main/teo_UG.xml
! make/data/cldr/common/main/tg.xml
! make/data/cldr/common/main/tg_TJ.xml
! make/data/cldr/common/main/th.xml
! make/data/cldr/common/main/th_TH.xml
! make/data/cldr/common/main/ti.xml
! make/data/cldr/common/main/ti_ER.xml
! make/data/cldr/common/main/ti_ET.xml
! make/data/cldr/common/main/tk.xml
! make/data/cldr/common/main/tk_TM.xml
! make/data/cldr/common/main/to.xml
! make/data/cldr/common/main/to_TO.xml
! make/data/cldr/common/main/tr.xml
! make/data/cldr/common/main/tr_CY.xml
! make/data/cldr/common/main/tr_TR.xml
! make/data/cldr/common/main/tt.xml
! make/data/cldr/common/main/tt_RU.xml
! make/data/cldr/common/main/twq.xml
! make/data/cldr/common/main/twq_NE.xml
! make/data/cldr/common/main/tzm.xml
! make/data/cldr/common/main/tzm_MA.xml
! make/data/cldr/common/main/ug.xml
! make/data/cldr/common/main/ug_CN.xml
! make/data/cldr/common/main/uk.xml
! make/data/cldr/common/main/uk_UA.xml
! make/data/cldr/common/main/ur.xml
! make/data/cldr/common/main/ur_IN.xml
! make/data/cldr/common/main/ur_PK.xml
! make/data/cldr/common/main/uz.xml
! make/data/cldr/common/main/uz_Arab.xml
! make/data/cldr/common/main/uz_Arab_AF.xml
! make/data/cldr/common/main/uz_Cyrl.xml
! make/data/cldr/common/main/uz_Cyrl_UZ.xml
! make/data/cldr/common/main/uz_Latn.xml
! make/data/cldr/common/main/uz_Latn_UZ.xml
! make/data/cldr/common/main/vai.xml
! make/data/cldr/common/main/vai_Latn.xml
! make/data/cldr/common/main/vai_Latn_LR.xml
! make/data/cldr/common/main/vai_Vaii.xml
! make/data/cldr/common/main/vai_Vaii_LR.xml
! make/data/cldr/common/main/vi.xml
! make/data/cldr/common/main/vi_VN.xml
! make/data/cldr/common/main/vo.xml
! make/data/cldr/common/main/vo_001.xml
! make/data/cldr/common/main/vun.xml
! make/data/cldr/common/main/vun_TZ.xml
! make/data/cldr/common/main/wae.xml
! make/data/cldr/common/main/wae_CH.xml
! make/data/cldr/common/main/wo.xml
! make/data/cldr/common/main/wo_SN.xml
+ make/data/cldr/common/main/xh.xml
+ make/data/cldr/common/main/xh_ZA.xml
! make/data/cldr/common/main/xog.xml
! make/data/cldr/common/main/xog_UG.xml
! make/data/cldr/common/main/yav.xml
! make/data/cldr/common/main/yav_CM.xml
! make/data/cldr/common/main/yi.xml
! make/data/cldr/common/main/yi_001.xml
! make/data/cldr/common/main/yo.xml
! make/data/cldr/common/main/yo_BJ.xml
! make/data/cldr/common/main/yo_NG.xml
! make/data/cldr/common/main/yue.xml
- make/data/cldr/common/main/yue_HK.xml
! make/data/cldr/common/main/yue_Hans.xml
! make/data/cldr/common/main/yue_Hans_CN.xml
! make/data/cldr/common/main/yue_Hant.xml
! make/data/cldr/common/main/yue_Hant_HK.xml
! make/data/cldr/common/main/zgh.xml
! make/data/cldr/common/main/zgh_MA.xml
! make/data/cldr/common/main/zh.xml
! make/data/cldr/common/main/zh_Hans.xml
! make/data/cldr/common/main/zh_Hans_CN.xml
! make/data/cldr/common/main/zh_Hans_HK.xml
! make/data/cldr/common/main/zh_Hans_MO.xml
! make/data/cldr/common/main/zh_Hans_SG.xml
! make/data/cldr/common/main/zh_Hant.xml
! make/data/cldr/common/main/zh_Hant_HK.xml
! make/data/cldr/common/main/zh_Hant_MO.xml
! make/data/cldr/common/main/zh_Hant_TW.xml
! make/data/cldr/common/main/zu.xml
! make/data/cldr/common/main/zu_ZA.xml
! make/data/cldr/common/supplemental/attributeValueValidity.xml
! make/data/cldr/common/supplemental/coverageLevels.xml
! make/data/cldr/common/supplemental/dayPeriods.xml
+ make/data/cldr/common/supplemental/languageGroup.xml
! make/data/cldr/common/supplemental/languageInfo.xml
! make/data/cldr/common/supplemental/likelySubtags.xml
! make/data/cldr/common/supplemental/metaZones.xml
! make/data/cldr/common/supplemental/numberingSystems.xml
! make/data/cldr/common/supplemental/ordinals.xml
! make/data/cldr/common/supplemental/pluralRanges.xml
! make/data/cldr/common/supplemental/plurals.xml
! make/data/cldr/common/supplemental/subdivisions.xml
! make/data/cldr/common/supplemental/supplementalData.xml
! make/data/cldr/common/supplemental/supplementalMetadata.xml
- make/data/cldr/common/supplemental/telephoneCodeData.xml
! make/data/cldr/common/supplemental/windowsZones.xml
! make/data/cldr/unicode-license.txt
! make/jdk/src/classes/build/tools/cldrconverter/Bundle.java
! src/java.base/share/legal/cldr.md
! src/jdk.localedata/share/legal/cldr.md
! test/jdk/java/text/Format/CompactNumberFormat/TestUExtensionOverride.java
! test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java
! test/jdk/java/time/test/java/time/format/TestNonIsoFormatter.java
! test/jdk/java/util/Calendar/CalendarDataTest.java
! test/jdk/java/util/Calendar/JapaneseEraNameTest.java
! test/jdk/java/util/Formatter/Basic-X.java.template
! test/jdk/java/util/Formatter/Basic.sh
! test/jdk/java/util/Formatter/BasicBigDecimal.java
! test/jdk/java/util/Formatter/BasicBigInteger.java
! test/jdk/java/util/Formatter/BasicDouble.java
! test/jdk/java/util/Formatter/BasicDoubleObject.java
! test/jdk/java/util/Formatter/BasicFloat.java
! test/jdk/java/util/Formatter/BasicInt.java
! test/jdk/java/util/Formatter/BasicLong.java
! test/jdk/sun/text/resources/LocaleData.cldr
! test/jdk/sun/text/resources/LocaleDataTest.java
! test/jdk/sun/util/resources/cldr/Bug8145136.java
! test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java

Changeset: 62b6e7587b1f
Author:    aeubanks
Date:      2019-04-16 13:06 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/62b6e7587b1f

8220673: Add test library support for determining platform IP support
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java
+ test/jdk/java/net/IPSupport/MinimumPermissions.java
+ test/jdk/java/net/IPSupport/MinimumPermissions.policy
! test/jdk/java/net/Inet4Address/PingThis.java
! test/jdk/java/net/Inet6Address/PreferIPv6AddressesTest.java
! test/jdk/java/net/InetAddress/GetLocalHostWithSM.java
! test/jdk/java/net/MulticastSocket/JoinLeave.java
! test/jdk/java/net/MulticastSocket/NoLoopbackPackets.java
! test/jdk/java/net/MulticastSocket/Promiscuous.java
! test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java
! test/jdk/java/net/MulticastSocket/Test.java
! test/jdk/java/net/MulticastSocket/UnreferencedMulticastSockets.java
! test/jdk/java/net/NetworkInterface/NetworkInterfaceStreamTest.java
! test/jdk/java/net/NetworkInterface/Test.java
! test/jdk/java/net/ServerSocket/AcceptInheritHandle.java
! test/jdk/java/net/ServerSocket/UnreferencedSockets.java
! test/jdk/java/net/Socket/AddressTest.java
! test/jdk/java/net/Socket/B6210227.java
! test/jdk/java/net/Socket/CloseAvailable.java
! test/jdk/java/net/Socket/DeadlockTest.java
! test/jdk/java/net/Socket/GetLocalAddress.java
! test/jdk/java/net/Socket/HttpProxy.java
! test/jdk/java/net/Socket/InheritHandle.java
! test/jdk/java/net/Socket/InheritTimeout.java
! test/jdk/java/net/Socket/LingerTest.java
! test/jdk/java/net/Socket/LinkLocal.java
! test/jdk/java/net/Socket/ProxyCons.java
! test/jdk/java/net/Socket/RST.java
! test/jdk/java/net/Socket/ReadTimeout.java
! test/jdk/java/net/Socket/RejectIPv6.java
! test/jdk/java/net/Socket/SetSoLinger.java
! test/jdk/java/net/Socket/ShutdownInput.java
! test/jdk/java/net/Socket/SocksConnectTimeout.java
! test/jdk/java/net/Socket/TestAfterClose.java
! test/jdk/java/net/Socket/TestClose.java
! test/jdk/java/net/Socket/TestTcpNoDelay.java
! test/jdk/java/net/Socket/Timeout.java
! test/jdk/java/net/Socket/TrafficClass.java
! test/jdk/java/net/Socket/UrgentDataTest.java
! test/jdk/java/net/Socket/asyncClose/AsyncClose.java
! test/jdk/java/net/Socket/asyncClose/BrokenPipe.java
! test/jdk/java/net/Socket/setReuseAddress/Basic.java
! test/jdk/java/net/Socket/setReuseAddress/Restart.java
! test/jdk/java/net/SocketInputStream/SocketClosedException.java
! test/jdk/java/net/SocketInputStream/SocketTimeout.java
! test/jdk/java/net/SocketOption/ImmutableOptions.java
! test/jdk/java/net/SocketOption/MinimumRcvBufferSize.java
! test/jdk/java/net/SocketOption/OptionsTest.java
! test/jdk/java/net/SocketOption/SupportedOptionsSet.java
! test/jdk/java/net/SocketOption/UnsupportedOptionsTest.java
! test/jdk/java/nio/channels/DatagramChannel/BindNull.java
! test/jdk/java/nio/channels/DatagramChannel/Disconnect.java
! test/jdk/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
! test/jdk/java/nio/channels/DatagramChannel/Promiscuous.java
! test/jdk/java/nio/channels/DatagramChannel/UseDGWithIPv6.java
! test/jdk/java/nio/channels/etc/PrintSupportedOptions.java
+ test/lib/jdk/test/lib/net/IPSupport.java

Changeset: d266d24b6a0e
Author:    shade
Date:      2019-05-08 23:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d266d24b6a0e

8223589: Build failures after JDK-8223534 (add back fixed test_markOop.cpp)
Reviewed-by: coleenp

! test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 7e172c330a15
Author:    kvn
Date:      2019-05-08 16:42 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7e172c330a15

8223539: compiler/graalunit/HotspotTest.java hotspot.test.CheckGraalIntrinsics AssertionError: found plugins for intrinsics
Reviewed-by: vlivanov

! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java

Changeset: c4b7ad8467c9
Author:    kvn
Date:      2019-05-08 16:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c4b7ad8467c9

8223380: [Graal] compiler/c2/Test8062950.java failed with time out.
Summary: put test on Graal problem list.
Reviewed-by: vlivanov

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 271ee240244c
Author:    weijun
Date:      2019-05-09 08:49 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/271ee240244c

8222987: sun/security/tools/keytool/PSS.java times out on Solaris-SPARC
Reviewed-by: mullan, xuelei

! test/jdk/sun/security/tools/keytool/PSS.java

Changeset: 6fbbf466fc6d
Author:    jwilhelm
Date:      2019-05-09 03:11 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6fbbf466fc6d

Added tag jdk-13+20 for changeset 6ccc7cd7931e

! .hgtags

Changeset: 7eb3d3ec9b36
Author:    jcbeyler
Date:      2019-05-08 20:28 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7eb3d3ec9b36

8223441: HeapMonitorStatArrayCorrectnessTest fails due to sampling determinism
Summary: Added an error loop to help with convergence
Reviewed-by: cjplummer, sspitsyn

! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

Changeset: 206afa6372ae
Author:    pli
Date:      2019-05-08 09:50 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/206afa6372ae

8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
Reviewed-by: shade

! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocHumongousFragment.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocIntArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjectArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyCheckCast.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyStress.java
! test/hotspot/jtreg/gc/shenandoah/TestElasticTLAB.java
! test/hotspot/jtreg/gc/shenandoah/TestEvilSyncBug.java
! test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java
! test/hotspot/jtreg/gc/shenandoah/TestHeapUncommit.java
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java
! test/hotspot/jtreg/gc/shenandoah/TestLargeObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/TestLotsOfCycles.java
! test/hotspot/jtreg/gc/shenandoah/TestParallelRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestPeriodicGC.java
! test/hotspot/jtreg/gc/shenandoah/TestRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestRegionSampling.java
! test/hotspot/jtreg/gc/shenandoah/TestRetainObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSieveObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSmallHeap.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedup.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java
! test/hotspot/jtreg/gc/shenandoah/TestStringInternCleanup.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyLevels.java
! test/hotspot/jtreg/gc/shenandoah/TestWithLogLevel.java
! test/hotspot/jtreg/gc/shenandoah/TestWrongArrayMember.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1ArrayCopyNPE.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1VectorizedMismatch.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestCommonGCLoads.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestExpandedWBLostNullCheckDep.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestNullCheck.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestReferenceCAS.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestWriteBarrierClearControl.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNICritical.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNIGlobalRefs.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestPinnedGarbage.java
! test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestChurnNotifications.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryPools.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestPauseNotifications.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargeObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargerThanHeap.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocSmallObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestClassLoaderLeak.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
! test/hotspot/jtreg/gc/shenandoah/options/TestAlwaysPreTouch.java
! test/hotspot/jtreg/gc/shenandoah/options/TestArgumentRanges.java
! test/hotspot/jtreg/gc/shenandoah/options/TestClassUnloadingArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestCodeCacheRootStyles.java
! test/hotspot/jtreg/gc/shenandoah/options/TestCriticalControlThreadPriority.java
! test/hotspot/jtreg/gc/shenandoah/options/TestEnabled.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGC.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGCNoConcurrent.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHumongousThresholdArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/options/TestPacing.java
! test/hotspot/jtreg/gc/shenandoah/options/TestParallelRegionStride.java
! test/hotspot/jtreg/gc/shenandoah/options/TestRegionSizeArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSafepointWorkers.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSingleThreaded.java
! test/hotspot/jtreg/gc/shenandoah/options/TestWrongBarrierDisable.java
! test/hotspot/jtreg/gc/startup_warnings/TestShenandoah.java
! test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java
! test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithShenandoah.java
! test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java

Changeset: d1d6e939803f
Author:    jlahoda
Date:      2019-05-09 11:58 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d1d6e939803f

8221759: Crash when completing \"java.io.File.path\"
Summary: Do not provide documentation for inaccessible elements.
Reviewed-by: rfield

! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java
! test/langtools/jdk/jshell/CompletionSuggestionTest.java
! test/langtools/jdk/jshell/ToolTabSnippetTest.java

Changeset: e0bd4c7a176e
Author:    gadams
Date:      2019-05-09 07:21 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e0bd4c7a176e

8042215: javax/management/remote/mandatory/connection/ReconnectTest.java NoSuchObjectException no such object in table
Reviewed-by: dcubed

! test/jdk/ProblemList.txt

Changeset: f8d182aedc92
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f8d182aedc92

8223136: Move compressed oops functions to CompressedOops class
Reviewed-by: coleenp, lkorinth

! make/hotspot/src/native/dtrace/generateJvmOffsets.cpp
! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp
! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp
! src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp
! src/hotspot/cpu/ppc/ppc.ad
! src/hotspot/cpu/ppc/relocInfo_ppc.cpp
! src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp
! src/hotspot/cpu/s390/macroAssembler_s390.cpp
! src/hotspot/cpu/s390/s390.ad
! src/hotspot/cpu/sparc/macroAssembler_sparc.cpp
! src/hotspot/cpu/sparc/relocInfo_sparc.cpp
! src/hotspot/cpu/sparc/sparc.ad
! src/hotspot/cpu/sparc/vm_version_sparc.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/relocInfo_x86.cpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/aot/aotCodeHeap.cpp
! src/hotspot/share/aot/aotLoader.cpp
! src/hotspot/share/asm/assembler.cpp
! src/hotspot/share/classfile/compactHashtable.cpp
! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/compiler/oopMap.hpp
! src/hotspot/share/gc/shared/gcConfiguration.cpp
! src/hotspot/share/gc/shared/gcConfiguration.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/memory/heapShared.hpp
! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/memory/universe.hpp
! src/hotspot/share/memory/virtualspace.cpp
+ src/hotspot/share/oops/compressedOops.cpp
+ src/hotspot/share/oops/compressedOops.hpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/oops/instanceRefKlass.inline.hpp
! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/klass.hpp
! src/hotspot/share/oops/klass.inline.hpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/oops/oop.inline.hpp
! src/hotspot/share/opto/lcm.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/opto/matcher.cpp
! src/hotspot/share/opto/matcher.hpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/stackValue.cpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/hotspot/share/utilities/vmError.cpp
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/CompressedKlassPointers.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/CompressedOops.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java

Changeset: f3f07c76d3d1
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f3f07c76d3d1

8223619: Move VerifyOption out of Universe
Reviewed-by: coleenp, lkorinth

! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp
! src/hotspot/share/gc/g1/g1FullCollector.cpp
! src/hotspot/share/gc/g1/g1FullGCMarker.cpp
! src/hotspot/share/gc/g1/g1FullGCOopClosures.hpp
! src/hotspot/share/gc/g1/g1HeapVerifier.hpp
! src/hotspot/share/gc/g1/heapRegion.hpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
+ src/hotspot/share/gc/shared/verifyOption.hpp
! src/hotspot/share/memory/universe.hpp

Changeset: 095f10996dcf
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/095f10996dcf

8223620: Move IsGCActiveMark implementation out of header
Reviewed-by: coleenp, lkorinth

+ src/hotspot/share/gc/shared/isGCActiveMark.cpp
! src/hotspot/share/gc/shared/isGCActiveMark.hpp

Changeset: 3331dad9cb30
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3331dad9cb30

8223621: Move Universe usage out of oopRecorder.hpp
Reviewed-by: coleenp, lkorinth

! src/hotspot/share/asm/codeBuffer.cpp
! src/hotspot/share/code/oopRecorder.cpp
! src/hotspot/share/code/oopRecorder.hpp
+ src/hotspot/share/code/oopRecorder.inline.hpp

Changeset: 31b27600b5db
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/31b27600b5db

8223622: Move Universe usage out of memAllocator.hpp
Reviewed-by: coleenp, lkorinth

! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/memAllocator.hpp

Changeset: 83b3671d9e30
Author:    stefank
Date:      2019-05-09 14:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/83b3671d9e30

8223623: Move oopFactory function definitions out of oopFactory.hpp
Reviewed-by: coleenp, lkorinth

! src/hotspot/share/memory/oopFactory.cpp
! src/hotspot/share/memory/oopFactory.hpp

Changeset: ebf733a324d4
Author:    stefank
Date:      2019-05-09 14:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ebf733a324d4

8223624: Cleanup includes of universe.hpp
Reviewed-by: coleenp, lkorinth

! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp
! src/hotspot/cpu/aarch64/frame_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
! src/hotspot/cpu/arm/c1_Runtime1_arm.cpp
! src/hotspot/cpu/arm/frame_arm.cpp
! src/hotspot/cpu/arm/gc/shared/barrierSetAssembler_arm.cpp
! src/hotspot/cpu/arm/interpreterRT_arm.cpp
! src/hotspot/cpu/arm/stubGenerator_arm.cpp
! src/hotspot/cpu/ppc/frame_ppc.cpp
! src/hotspot/cpu/ppc/interpreterRT_ppc.cpp
! src/hotspot/cpu/s390/c1_Runtime1_s390.cpp
! src/hotspot/cpu/s390/frame_s390.cpp
! src/hotspot/cpu/s390/interpreterRT_s390.cpp
! src/hotspot/cpu/s390/stubGenerator_s390.cpp
! src/hotspot/cpu/sparc/c1_Runtime1_sparc.cpp
! src/hotspot/cpu/sparc/frame_sparc.cpp
! src/hotspot/cpu/sparc/interpreterRT_sparc.cpp
! src/hotspot/cpu/x86/c1_Runtime1_x86.cpp
! src/hotspot/cpu/x86/frame_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/interpreterRT_x86_32.cpp
! src/hotspot/cpu/x86/interpreterRT_x86_64.cpp
! src/hotspot/cpu/x86/relocInfo_x86.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp
! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp
! src/hotspot/cpu/zero/frame_zero.cpp
! src/hotspot/cpu/zero/interpreterRT_zero.cpp
! src/hotspot/share/aot/aotCodeHeap.cpp
! src/hotspot/share/asm/assembler.cpp
! src/hotspot/share/c1/c1_Runtime1.cpp
! src/hotspot/share/ci/ciEnv.cpp
! src/hotspot/share/ci/ciField.cpp
! src/hotspot/share/ci/ciObjectFactory.cpp
! src/hotspot/share/ci/ciReplay.cpp
! src/hotspot/share/ci/ciSymbol.cpp
! src/hotspot/share/ci/ciType.cpp
! src/hotspot/share/ci/ciTypeArrayKlass.cpp
! src/hotspot/share/ci/ciUtilities.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/defaultMethods.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/moduleEntry.cpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/classfile/vmSymbols.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/compiledIC.cpp
! src/hotspot/share/code/debugInfo.cpp
! src/hotspot/share/code/icBuffer.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/oopRecorder.hpp
! src/hotspot/share/code/relocInfo.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/compilerOracle.cpp
! src/hotspot/share/compiler/disassembler.cpp
! src/hotspot/share/compiler/methodMatcher.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/cms/cmsHeap.cpp
! src/hotspot/share/gc/cms/cmsLockVerifier.cpp
! src/hotspot/share/gc/cms/cmsVMOperations.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp
! src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.cpp
! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/g1/g1Allocator.inline.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
! src/hotspot/share/gc/g1/g1FullGCOopClosures.hpp
! src/hotspot/share/gc/g1/g1FullGCOopClosures.inline.hpp
! src/hotspot/share/gc/g1/g1HeapVerifier.cpp
! src/hotspot/share/gc/g1/g1HeapVerifier.hpp
! src/hotspot/share/gc/g1/g1RootProcessor.cpp
! src/hotspot/share/gc/g1/g1VMOperations.cpp
! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp
! src/hotspot/share/gc/parallel/mutableSpace.cpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/parallel/psMarkSweep.cpp
! src/hotspot/share/gc/parallel/psParallelCompact.cpp
! src/hotspot/share/gc/parallel/psPromotionLAB.cpp
! src/hotspot/share/gc/parallel/psScavenge.cpp
! src/hotspot/share/gc/serial/genMarkSweep.cpp
! src/hotspot/share/gc/serial/markSweep.cpp
! src/hotspot/share/gc/serial/serialHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/gcConfiguration.hpp
! src/hotspot/share/gc/shared/gcLocker.cpp
! src/hotspot/share/gc/shared/gcVMOperations.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shared/generation.hpp
! src/hotspot/share/gc/shared/isGCActiveMark.hpp
! src/hotspot/share/gc/shared/markBitMap.cpp
! src/hotspot/share/gc/shared/markBitMap.inline.hpp
! src/hotspot/share/gc/shared/plab.cpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/scavengableNMethods.cpp
! src/hotspot/share/gc/shared/space.inline.hpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zNMethod.cpp
! src/hotspot/share/interpreter/bytecodeInterpreter.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/interpreter/interpreterRuntime.hpp
! src/hotspot/share/interpreter/linkResolver.cpp
! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderThread.cpp
! src/hotspot/share/jvmci/jvmci.cpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp
! src/hotspot/share/jvmci/jvmciEnv.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/memory/allocation.cpp
! src/hotspot/share/memory/arena.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/memory/heapInspection.cpp
! src/hotspot/share/memory/heapShared.cpp
! src/hotspot/share/memory/heapShared.hpp
! src/hotspot/share/memory/iterator.cpp
! src/hotspot/share/memory/iterator.inline.hpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/oopFactory.hpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/arrayKlass.hpp
! src/hotspot/share/oops/arrayOop.hpp
! src/hotspot/share/oops/constantPool.cpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/oops/cpCache.hpp
! src/hotspot/share/oops/generateOopMap.hpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/instanceMirrorKlass.cpp
! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/klass.inline.hpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/methodData.hpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.inline.hpp
! src/hotspot/share/oops/oopsHierarchy.cpp
! src/hotspot/share/oops/oopsHierarchy.hpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/oops/typeArrayKlass.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/opto/macro.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp
! src/hotspot/share/prims/jvmtiExport.cpp
! src/hotspot/share/prims/jvmtiImpl.cpp
! src/hotspot/share/prims/jvmtiRedefineClasses.cpp
! src/hotspot/share/prims/jvmtiTagMap.cpp
! src/hotspot/share/prims/jvmtiTagMap.hpp
! src/hotspot/share/prims/methodHandles.cpp
! src/hotspot/share/prims/nativeLookup.cpp
! src/hotspot/share/prims/resolvedMethodTable.cpp
! src/hotspot/share/prims/stackwalk.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/deoptimization.cpp
! src/hotspot/share/runtime/fieldDescriptor.cpp
! src/hotspot/share/runtime/fieldType.cpp
! src/hotspot/share/runtime/interfaceSupport.cpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/jniHandles.cpp
! src/hotspot/share/runtime/memprofiler.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/relocator.cpp
! src/hotspot/share/runtime/serviceThread.cpp
! src/hotspot/share/runtime/signature.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/unhandledOops.cpp
! src/hotspot/share/runtime/vframeArray.cpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/hotspot/share/runtime/vmThread.cpp
! src/hotspot/share/runtime/vm_version.cpp
! src/hotspot/share/services/attachListener.cpp
! src/hotspot/share/services/classLoadingService.cpp
! src/hotspot/share/services/diagnosticCommand.cpp
! src/hotspot/share/services/management.cpp
! src/hotspot/share/services/threadService.cpp
! src/hotspot/share/utilities/exceptions.cpp
! src/hotspot/share/utilities/vmError.cpp
! test/hotspot/gtest/gc/shared/test_collectedHeap.cpp

Changeset: 7748aa47b4e2
Author:    dfuchs
Date:      2019-05-09 14:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7748aa47b4e2

8223573: Replace wildcard address with loopback or local host in tests - part 4
Summary: Makes a few intermittently failing tests more resilient to port reuse issues by ensuring they bind to the loopback address instead of the wildcard.
Reviewed-by: alanb, chegar

! test/jdk/java/net/Socket/Streams.java
! test/jdk/sun/net/ftp/FtpURLConnectionLeak.java
! test/jdk/sun/net/www/AuthHeaderTest.java
! test/jdk/sun/net/www/ftptest/FtpServer.java
! test/jdk/sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
! test/jdk/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
! test/jdk/sun/net/www/http/ChunkedInputStream/TestAvailable.java
! test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java
! test/jdk/sun/net/www/http/HttpURLConnection/DigestAuth.java
! test/jdk/sun/net/www/protocol/http/6550798/test.java
! test/jdk/sun/net/www/protocol/http/CloseOptionHeader.java

Changeset: 7f782ee493f7
Author:    vromero
Date:      2019-05-09 10:04 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7f782ee493f7

8222251: preflow visitor is not visiting lambda expressions
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/langtools/tools/javac/T8222251/PreflowNotVisitingLambdaExpTest.java

Changeset: 77e95181b5d6
Author:    erikj
Date:      2019-05-09 07:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/77e95181b5d6

8223627: jdk-13+20 bundle name contains null instead of ea
Reviewed-by: dholmes, tbell

! make/conf/jib-profiles.js

Changeset: b77bf7f216f4
Author:    mbaesken
Date:      2019-05-03 14:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b77bf7f216f4

8223307: enable the Stack Execution Disable flag for JDK binaries on AIX
Reviewed-by: erikj, mdoerr

! make/autoconf/flags-ldflags.m4

Changeset: 04f603ebb6c2
Author:    redestad
Date:      2019-05-09 17:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/04f603ebb6c2

8223454: Reduce String concatenation shapes by folding initialLengthCoder into last mixer
Reviewed-by: jlaskey

! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java

Changeset: 81607d4919c0
Author:    joehw
Date:      2019-05-09 09:23 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/81607d4919c0

8222991: Xerces 2.12.0: Validation
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TypeValidator.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractTraverser.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java
! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDSimpleTypeTraverser.java
! test/jaxp/javax/xml/jaxp/unittest/validation/SchemaTest.java

Changeset: f4c8f88c665e
Author:    aph
Date:      2019-05-09 12:52 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f4c8f88c665e

8223645: AArch64 build broken by fix for 8223136
Reviewed-by: stefank

! src/hotspot/cpu/aarch64/compiledIC_aot_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp

Changeset: 019b3db480f4
Author:    aph
Date:      2019-05-09 12:56 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/019b3db480f4

Merge


Changeset: fd08f5a976e6
Author:    gziemski
Date:      2019-05-09 12:04 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fd08f5a976e6

8189208: Cleanup ancient argument processing code
Summary: Remove bits thread_park_blocker, post_vm_init_hook_enabled and pending_list_uses_discovered_fields
Reviewed-by: hseigel, dholmes

! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/include/jvm.h
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/java.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/services/threadService.cpp
! src/java.base/share/native/libjava/jdk_util.c

Changeset: 3c16c876b094
Author:    mullan
Date:      2019-05-09 13:49 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3c16c876b094

8191808: Configurable read timeout for CRLs
Reviewed-by: xuelei, coffeys

! src/java.base/share/classes/sun/security/provider/certpath/URICertStore.java
+ test/jdk/sun/security/x509/URICertStore/CRLReadTimeout.java

Changeset: c90da1272d7f
Author:    aoqi
Date:      2019-05-10 01:37 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c90da1272d7f

8223599: minimal build fails after JDK-8185525
Reviewed-by: shade, gziemski, dholmes
Contributed-by: Wang Haomin <wanghaomin at loongson.cn>

! src/hotspot/share/utilities/tableStatistics.cpp

Changeset: 9c18785a13bf
Author:    aoqi
Date:      2019-05-10 01:41 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9c18785a13bf

8223651: Build fails with --with-jvm-features=-jfr and --disable-precompiled-headers
Reviewed-by: shade
Contributed-by: Wang Haomin <wanghaomin at loongson.cn>

! src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp

Changeset: 2a25ece54fd8
Author:    gziemski
Date:      2019-05-09 16:34 -0500
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2a25ece54fd8

8223639: [JVMCI] jvmciCompiler.cpp needs to include "oops/objArrayOop.inline.hpp""
Summary: Added missing header
Reviewed-by: dlong, kvn

! src/hotspot/share/jvmci/jvmciCompiler.cpp

Changeset: ad757676262c
Author:    dholmes
Date:      2019-05-09 18:42 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ad757676262c

8222292: runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java timeout but test passed
Reviewed-by: goetz, lfoltan, kvn

! test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java

Changeset: ac8493c4a747
Author:    xliu
Date:      2019-05-09 18:38 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ac8493c4a747

8223537: testlibrary_tests/ctw/ClassesListTest.java fails with Agent timeout frequently
Reviewed-by: thartmann, kvn

! src/hotspot/share/compiler/compileBroker.cpp

Changeset: b0a1572ec64a
Author:    weijun
Date:      2019-05-10 09:39 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b0a1572ec64a

8200400: Restrict Sasl mechanisms
Reviewed-by: mullan

! src/java.base/share/conf/security/java.security
! src/java.security.sasl/share/classes/javax/security/sasl/Sasl.java
+ test/jdk/javax/security/sasl/Sasl/DisabledMechanisms.java

Changeset: 293d45e5108b
Author:    clanger
Date:      2019-05-10 06:31 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/293d45e5108b

8223555: Cleanups in cacerts tests
Reviewed-by: xuelei

! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 6870b259b170
Author:    rschmelter
Date:      2019-05-09 05:04 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6870b259b170

8223617: code_size2 needs adjustments
Reviewed-by: mdoerr, simonis

! src/hotspot/cpu/x86/stubRoutines_x86.hpp

Changeset: d26653aca0bd
Author:    shade
Date:      2019-05-10 09:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d26653aca0bd

8223676: Minimal VM build failure after 8223136 (Move compressed oops functions to CompressedOops class)
Reviewed-by: rkennke

! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

Changeset: 45bbef01a6ae
Author:    shade
Date:      2019-05-10 09:56 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/45bbef01a6ae

8223675: arm32 build failure after 8223136 (Move compressed oops functions to CompressedOops class)
Reviewed-by: rkennke

! src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp
! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp
! src/hotspot/os_cpu/linux_arm/thread_linux_arm.cpp

Changeset: 33fe50b6d707
Author:    coleenp
Date:      2019-05-10 09:05 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/33fe50b6d707

8223626: move print() functions to cpp files
Summary: improve debugging experience
Reviewed-by: dholmes, dlong

! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/classLoaderData.hpp
! src/hotspot/share/classfile/classLoaderDataGraph.cpp
! src/hotspot/share/classfile/classLoaderDataGraph.hpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/systemDictionary.hpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/classfile/systemDictionaryShared.hpp
! src/hotspot/share/code/codeBlob.cpp
! src/hotspot/share/code/codeBlob.hpp
! src/hotspot/share/code/vmreg.cpp
! src/hotspot/share/code/vmreg.hpp
! src/hotspot/share/code/vtableStubs.cpp
! src/hotspot/share/code/vtableStubs.hpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/compiler/oopMap.hpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
! src/hotspot/share/gc/shared/workgroup.cpp
! src/hotspot/share/gc/shared/workgroup.hpp
! src/hotspot/share/interpreter/interpreter.cpp
! src/hotspot/share/interpreter/interpreter.hpp
! src/hotspot/share/oops/metadata.cpp
! src/hotspot/share/oops/metadata.hpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/oops/symbol.hpp
! src/hotspot/share/runtime/biasedLocking.cpp
! src/hotspot/share/runtime/biasedLocking.hpp
! src/hotspot/share/runtime/fieldDescriptor.cpp
! src/hotspot/share/runtime/fieldDescriptor.hpp
! src/hotspot/share/runtime/jniHandles.cpp
! src/hotspot/share/runtime/jniHandles.hpp
! src/hotspot/share/runtime/objectMonitor.cpp
! src/hotspot/share/runtime/objectMonitor.hpp
! src/hotspot/share/runtime/osThread.cpp
! src/hotspot/share/runtime/osThread.hpp
! src/hotspot/share/runtime/rtmLocking.cpp
! src/hotspot/share/runtime/rtmLocking.hpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/safepoint.hpp
! src/hotspot/share/runtime/stubCodeGenerator.cpp
! src/hotspot/share/runtime/stubCodeGenerator.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp

Changeset: cf94f5c214f6
Author:    coleenp
Date:      2019-05-10 09:07 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cf94f5c214f6

Merge

! src/hotspot/share/runtime/thread.cpp

Changeset: 351da897f409
Author:    aefimov
Date:      2019-05-10 15:34 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/351da897f409

8223465: Replace wildcard address with loopback or local host in tests - part 3
Reviewed-by: dfuchs

! test/jdk/java/net/DatagramSocket/PortUnreachable.java
! test/jdk/java/net/Socket/HttpProxy.java
! test/jdk/java/net/Socket/asyncClose/ServerSocket_accept.java
! test/jdk/java/net/Socks/SocksV4Test.java
! test/jdk/sun/net/www/protocol/http/ChunkedErrorStream.java

Changeset: 258170da6d3a
Author:    ysuenaga
Date:      2019-05-11 01:17 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/258170da6d3a

8223186: HotSpot compile warnings from GCC 9
Reviewed-by: dholmes, aeubanks

! src/hotspot/os/linux/osContainer_linux.cpp
! src/hotspot/share/compiler/disassembler.cpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/prims/jvmtiExport.hpp

Changeset: 9db7c0f561a6
Author:    aeubanks
Date:      2019-05-09 10:28 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9db7c0f561a6

8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid() to IPSupport.throwSkippedExceptionIfNonOperational()
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! test/jdk/java/net/DatagramSocket/UnreferencedDatagramSockets.java
! test/jdk/java/net/IPSupport/MinimumPermissions.java
! test/jdk/java/net/Inet4Address/PingThis.java
! test/jdk/java/net/InetAddress/GetLocalHostWithSM.java
! test/jdk/java/net/MulticastSocket/JoinLeave.java
! test/jdk/java/net/MulticastSocket/Promiscuous.java
! test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java
! test/jdk/java/net/MulticastSocket/Test.java
! test/jdk/java/net/MulticastSocket/UnreferencedMulticastSockets.java
! test/jdk/java/net/NetworkInterface/NetworkInterfaceStreamTest.java
! test/jdk/java/net/NetworkInterface/Test.java
! test/jdk/java/net/ServerSocket/UnreferencedSockets.java
! test/jdk/java/net/Socket/AddressTest.java
! test/jdk/java/net/Socket/B6210227.java
! test/jdk/java/net/Socket/CloseAvailable.java
! test/jdk/java/net/Socket/DeadlockTest.java
! test/jdk/java/net/Socket/GetLocalAddress.java
! test/jdk/java/net/Socket/HttpProxy.java
! test/jdk/java/net/Socket/InheritHandle.java
! test/jdk/java/net/Socket/InheritTimeout.java
! test/jdk/java/net/Socket/LingerTest.java
! test/jdk/java/net/Socket/LinkLocal.java
! test/jdk/java/net/Socket/ProxyCons.java
! test/jdk/java/net/Socket/RST.java
! test/jdk/java/net/Socket/ReadTimeout.java
! test/jdk/java/net/Socket/RejectIPv6.java
! test/jdk/java/net/Socket/SetSoLinger.java
! test/jdk/java/net/Socket/ShutdownInput.java
! test/jdk/java/net/Socket/SocksConnectTimeout.java
! test/jdk/java/net/Socket/TestAfterClose.java
! test/jdk/java/net/Socket/TestClose.java
! test/jdk/java/net/Socket/TestTcpNoDelay.java
! test/jdk/java/net/Socket/Timeout.java
! test/jdk/java/net/Socket/TrafficClass.java
! test/jdk/java/net/Socket/UrgentDataTest.java
! test/jdk/java/net/Socket/asyncClose/AsyncClose.java
! test/jdk/java/net/Socket/asyncClose/BrokenPipe.java
! test/jdk/java/net/Socket/setReuseAddress/Basic.java
! test/jdk/java/net/Socket/setReuseAddress/Restart.java
! test/jdk/java/net/SocketInputStream/SocketClosedException.java
! test/jdk/java/net/SocketInputStream/SocketTimeout.java
! test/jdk/java/net/SocketOption/ImmutableOptions.java
! test/jdk/java/net/SocketOption/MinimumRcvBufferSize.java
! test/jdk/java/net/SocketOption/OptionsTest.java
! test/jdk/java/net/SocketOption/SupportedOptionsSet.java
! test/jdk/java/net/SocketOption/UnsupportedOptionsTest.java
! test/jdk/java/nio/channels/DatagramChannel/Disconnect.java
! test/jdk/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
! test/jdk/java/nio/channels/DatagramChannel/Promiscuous.java
! test/jdk/java/nio/channels/DatagramChannel/UseDGWithIPv6.java
! test/jdk/java/nio/channels/etc/PrintSupportedOptions.java
! test/lib/jdk/test/lib/net/IPSupport.java

Changeset: f2d5f44d994e
Author:    dnsimon
Date:      2019-05-10 10:30 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f2d5f44d994e

8223531: [Graal] assert(type() == T_INT) failed: type check
Reviewed-by: dlong, thartmann, never, kvn

! src/hotspot/share/jvmci/jvmciEnv.hpp
! src/hotspot/share/jvmci/vmStructs_jvmci.cpp

Changeset: 0fe908af327e
Author:    bobv
Date:      2019-05-10 11:15 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0fe908af327e

8221340: [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562
Reviewed-by: mseledtsov, rriggs

! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java
! test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java

Changeset: 207b7bf04f49
Author:    bobv
Date:      2019-05-10 11:18 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/207b7bf04f49

8222533: jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine
Reviewed-by: mseledtsov, dholmes

! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java

Changeset: 1e83e1a600cb
Author:    cito
Date:      2019-05-10 20:56 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1e83e1a600cb

8221569: JFR tool produces incorrect output when both --categories and --events are specified
Reviewed-by: mgronlun
Contributed-by: chihiro.ito at oracle.com, erik.gahlin at oracle.com

! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Print.java

Changeset: b27f33bef884
Author:    xuelei
Date:      2019-05-10 12:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b27f33bef884

8221253: TLSv1.3 may generate TLSInnerPlainText longer than 2^14+1 bytes
Reviewed-by: jnimeh

! src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java
! src/java.base/share/classes/sun/security/ssl/OutputRecord.java
! src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java
! src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java
+ test/jdk/javax/net/ssl/SSLSocket/Tls13PacketSize.java

Changeset: ef73702a906e
Author:    jjg
Date:      2019-05-10 13:37 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ef73702a906e

8223654: Clean up @jls references in com.sun.source
Reviewed-by: darcy

! src/jdk.compiler/share/classes/com/sun/source/tree/AnnotationTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ArrayAccessTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ArrayTypeTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/AssertTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/AssignmentTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/BinaryTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/BlockTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/BreakTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/CaseTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/CatchTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ClassTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/CompilationUnitTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/CompoundAssignmentTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ConditionalExpressionTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ContinueTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/DoWhileLoopTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/EmptyStatementTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/EnhancedForLoopTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ExpressionStatementTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ExpressionTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ForLoopTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/IdentifierTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/IfTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ImportTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/InstanceOfTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/LabeledStatementTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/LiteralTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/MemberSelectTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/MethodInvocationTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/MethodTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ModifiersTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/NewArrayTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/NewClassTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/PackageTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ParameterizedTypeTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ParenthesizedTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/PrimitiveTypeTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ReturnTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/StatementTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/SwitchExpressionTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/SwitchTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/SynchronizedTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ThrowTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/TryTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/TypeCastTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/TypeParameterTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/UnaryTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/VariableTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/WhileLoopTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/WildcardTree.java

Changeset: ea4774a27d9f
Author:    jcbeyler
Date:      2019-05-08 15:36 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ea4774a27d9f

8223040: Add a AsyncGetCallTrace test
Summary: Add a AsyncGetCallTrace test
Reviewed-by: sspitsyn, dcubed

! make/test/JtregNativeHotspot.gmk
+ test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
+ test/hotspot/jtreg/serviceability/AsyncGetCallTrace/libAsyncGetCallTraceTest.cpp

Changeset: c2551d161358
Author:    aeubanks
Date:      2019-05-10 17:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c2551d161358

8223667: ASAN build broken
Reviewed-by: erikj, manc

! make/autoconf/spec.gmk.in

Changeset: fcf83b204c27
Author:    stuefe
Date:      2019-04-05 11:52 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fcf83b204c27

8222015: Small VM.metaspace improvements
Reviewed-by: jiangli, coleenp

! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/metaspace/metaspaceCommon.cpp
! src/hotspot/share/memory/metaspace/metaspaceCommon.hpp
! src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp
! src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.hpp
! src/hotspot/share/memory/metaspace/printMetaspaceInfoKlassClosure.cpp
! src/hotspot/share/memory/metaspace/printMetaspaceInfoKlassClosure.hpp

Changeset: 85ccac8a8c13
Author:    hannesw
Date:      2019-05-13 16:43 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/85ccac8a8c13

8219060: -linksource broken with modules
Reviewed-by: jjg

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java
! test/langtools/jdk/javadoc/doclet/testMetadata/TestMetadata.java
! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java
! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java

Changeset: f542a3a135bd
Author:    dfuchs
Date:      2019-05-13 17:31 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f542a3a135bd

8223632: Replace wildcard address with loopback or local host in tests - part 5
Summary: Replaces wildcard usage by loopback, when possible, adds intermittent keyword and a comment, when not.
Reviewed-by: chegar

! test/jdk/java/net/ProxySelector/LoopbackAddresses.java
! test/jdk/java/net/ProxySelector/ProxyTest.java
! test/jdk/java/net/ResponseCache/B6181108.java
! test/jdk/java/net/SocketInputStream/SocketClosedException.java
! test/jdk/java/net/SocketPermission/SocketPermissionTest.java
! test/jdk/java/net/URLConnection/DisconnectAfterEOF.java
! test/jdk/java/net/URLConnection/contentHandler/UserContentHandler.java
! test/jdk/sun/net/www/http/HttpClient/B7025238.java
! test/jdk/sun/net/www/http/HttpClient/ProxyFromCache.java

Changeset: 1b940da275d2
Author:    adinn
Date:      2019-04-25 17:27 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1b940da275d2

8221696: MappedByteBuffer.force method to specify range
Summary: Overload MappedByteBuffer.force to accept index and length arguments
Reviewed-by: dfuchs, alanb, bpb

! src/java.base/share/classes/java/nio/MappedByteBuffer.java
! test/jdk/java/nio/channels/FileChannel/MapTest.java

Changeset: adb3a3aa2e52
Author:    sgehwolf
Date:      2019-03-14 14:04 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/adb3a3aa2e52

8214796: Create a jlink plugin for stripping debug info symbols from native libraries
Reviewed-by: alanb, mchung, erikj, ihse

! make/common/TestFilesCompilation.gmk
! make/gensrc/Gensrc-jdk.jlink.gmk
! make/test/JtregNativeJdk.gmk
+ src/jdk.jlink/linux/classes/jdk/tools/jlink/internal/plugins/StripNativeDebugSymbolsPlugin.java
+ src/jdk.jlink/linux/classes/jdk/tools/jlink/resources/strip_native_debug_symbols_plugin.properties
+ src/jdk.jlink/linux/classes/module-info.java.extra
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/PluginsResourceBundle.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties
! test/jdk/tools/jlink/IntegrationTest.java
+ test/jdk/tools/jlink/plugins/DefaultStripDebugPluginTest.java
+ test/jdk/tools/jlink/plugins/StripNativeDebugSymbolsPlugin/FakeObjCopy.java
+ test/jdk/tools/jlink/plugins/StripNativeDebugSymbolsPlugin/StripNativeDebugSymbolsPluginTest.java
+ test/jdk/tools/jlink/plugins/StripNativeDebugSymbolsPlugin/src/fib/FibJNI.java
+ test/jdk/tools/jlink/plugins/StripNativeDebugSymbolsPlugin/src/libFib.c

Changeset: 1b03400e5a8f
Author:    stefank
Date:      2019-05-11 13:10 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1b03400e5a8f

8223637: Fix build breakage after 8223136
Reviewed-by: stefank, coleenp
Contributed-by: stefan.karlsson at oracle.com, lutz.schmidt at sap.com, glaubitz at physik.fu-berlin.de, shade at redhat.com

! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp
! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp
! src/hotspot/cpu/ppc/macroAssembler_ppc.inline.hpp
! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp
! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/share/adlc/main.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/oops/compressedOops.hpp
! src/hotspot/share/runtime/deoptimization.cpp

Changeset: 4ef4d55a129b
Author:    epavlova
Date:      2019-05-13 13:32 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4ef4d55a129b

8223235: [Graal] compiler/jsr292/NonInlinedCall/InvokeTest.java failed time out
Reviewed-by: kvn

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 01fa7f06f806
Author:    weijun
Date:      2019-05-14 08:47 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/01fa7f06f806

8223063: Support CNG RSA keys
Reviewed-by: mullan

! src/java.base/share/classes/sun/security/tools/keytool/Main.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPrivateKey.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java
! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CSignature.java
! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp
+ test/jdk/sun/security/mscapi/VeryLongAlias.java

Changeset: a7abac394abb
Author:    igerasim
Date:      2019-05-13 18:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a7abac394abb

8223730: URLClassLoader.findClass() can throw IndexOutOfBoundsException
Reviewed-by: prappo, bchristi

! src/java.base/share/classes/jdk/internal/loader/Resource.java

Changeset: 6a60270af76b
Author:    jcbeyler
Date:      2019-05-13 20:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6a60270af76b

8223779: Build failure after 8223040 (Add a AsyncGetCallTrace test)
Summary: Fix a build flag for the AGCT test
Reviewed-by: cjplummer, sspitsyn

! make/test/JtregNativeHotspot.gmk

Changeset: 855c803e6f1d
Author:    mbaesken
Date:      2019-05-10 09:58 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/855c803e6f1d

8223574: add more thread-related system settings info to hs_error file on AIX
Reviewed-by: goetz, mdoerr

! src/hotspot/os/aix/os_aix.cpp

Changeset: 88954c14eb57
Author:    mbaesken
Date:      2019-05-14 09:14 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/88954c14eb57

8223685: used bundled zlib on AIX by default
Reviewed-by: erikj, simonis

! make/autoconf/lib-bundled.m4

Changeset: 0eee5adb22d7
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0eee5adb22d7

8223759: Shenandoah should allow arbitrarily low initial heap size
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! test/hotspot/jtreg/gc/shenandoah/options/TestRegionSizeArgs.java

Changeset: 76751d3faf7b
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/76751d3faf7b

8223762: Shenandoah: overflows in calculations involving heap capacity
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp

Changeset: 39ba09047e19
Author:    pliden
Date:      2019-05-14 09:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/39ba09047e19

8222480: Implementation: JEP 351: ZGC: Uncommit Unused Memory
Reviewed-by: stefank, eosterlund

! src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.hpp
! src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp
! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp
! src/hotspot/share/gc/z/vmStructs_z.hpp
! src/hotspot/share/gc/z/zCollectedHeap.cpp
! src/hotspot/share/gc/z/zCollectedHeap.hpp
! src/hotspot/share/gc/z/zHeap.cpp
! src/hotspot/share/gc/z/zHeap.hpp
! src/hotspot/share/gc/z/zList.hpp
! src/hotspot/share/gc/z/zList.inline.hpp
! src/hotspot/share/gc/z/zLiveMap.cpp
! src/hotspot/share/gc/z/zLiveMap.hpp
! src/hotspot/share/gc/z/zLiveMap.inline.hpp
! src/hotspot/share/gc/z/zMemory.cpp
! src/hotspot/share/gc/z/zMemory.hpp
! src/hotspot/share/gc/z/zPage.cpp
! src/hotspot/share/gc/z/zPage.hpp
! src/hotspot/share/gc/z/zPage.inline.hpp
! src/hotspot/share/gc/z/zPageAllocator.cpp
! src/hotspot/share/gc/z/zPageAllocator.hpp
! src/hotspot/share/gc/z/zPageCache.cpp
! src/hotspot/share/gc/z/zPageCache.hpp
! src/hotspot/share/gc/z/zPageCache.inline.hpp
! src/hotspot/share/gc/z/zPhysicalMemory.cpp
! src/hotspot/share/gc/z/zPhysicalMemory.hpp
! src/hotspot/share/gc/z/zPhysicalMemory.inline.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.cpp
- src/hotspot/share/gc/z/zPreMappedMemory.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.inline.hpp
+ src/hotspot/share/gc/z/zUncommitter.cpp
+ src/hotspot/share/gc/z/zUncommitter.hpp
! src/hotspot/share/gc/z/zVirtualMemory.cpp
! src/hotspot/share/gc/z/zVirtualMemory.hpp
! src/hotspot/share/gc/z/zVirtualMemory.inline.hpp
! src/hotspot/share/gc/z/z_globals.hpp
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageAllocator.java
- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPhysicalMemoryManager.java
! test/hotspot/gtest/gc/z/test_zForwarding.cpp
! test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp
! test/hotspot/gtest/gc/z/test_zVirtualMemory.cpp
! test/hotspot/jtreg/ProblemList-zgc.txt
+ test/hotspot/jtreg/gc/z/TestUncommit.java

Changeset: 43764a3a986d
Author:    clanger
Date:      2019-05-14 09:25 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/43764a3a986d

8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc <entries20> failed 6af4413c vs 0 ...)
Reviewed-by: redestad, lancea

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! test/jdk/jdk/nio/zipfs/ZipFSTester.java

Changeset: e2ed0691ae79
Author:    sspitsyn
Date:      2019-05-14 02:07 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e2ed0691ae79

8219023: Investigate syncing JVMTI spec version with JDK version
Summary: Auto sync versions with the jdk versions
Reviewed-by: dholmes, jcbeyler, cjplummer

! make/hotspot/gensrc/GensrcJvmti.gmk
! src/hotspot/share/prims/jvmti.xml
! src/hotspot/share/prims/jvmti.xsl
! src/hotspot/share/prims/jvmtiExport.cpp
! src/hotspot/share/prims/jvmtiH.xsl
! src/hotspot/share/prims/jvmtiLib.xsl
! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java
! src/jdk.jdwp.agent/share/native/libjdwp/VirtualMachineImpl.c

Changeset: 6b06de11e78e
Author:    yzhou
Date:      2019-05-14 11:06 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6b06de11e78e

8222969: Migrate RuleBasedCollatorTest to JDK Repo
Reviewed-by: naoto

+ test/jdk/java/text/Collator/RuleBasedCollatorTest.java

Changeset: d7819bedfaaf
Author:    redestad
Date:      2019-05-14 12:00 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d7819bedfaaf

8221478: Disable VerifySharedSpaces by default
Reviewed-by: iklam, dholmes

! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/globals.hpp
! test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java

Changeset: 0b408b0d1886
Author:    shade
Date:      2019-05-14 14:57 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0b408b0d1886

Merge

! .hgtags
- make/data/cldr/common/main/ff_CM.xml
- make/data/cldr/common/main/ff_GN.xml
- make/data/cldr/common/main/ff_MR.xml
- make/data/cldr/common/main/ff_SN.xml
- make/data/cldr/common/main/yue_HK.xml
- make/data/cldr/common/supplemental/telephoneCodeData.xml
! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp
+ src/hotspot/cpu/aarch64/gc/shenandoah/c1/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
- src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp
! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp
! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp
! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp
! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp
+ src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
- src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.hpp
! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp
! src/hotspot/share/adlc/formssel.cpp
! src/hotspot/share/asm/assembler.cpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/classLoaderData.hpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/relocInfo.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/oopMap.cpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.cpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.hpp
- src/hotspot/share/gc/epsilon/epsilonCollectorPolicy.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.hpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.hpp
- src/hotspot/share/gc/parallel/generationSizer.cpp
- src/hotspot/share/gc/parallel/generationSizer.hpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.cpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.hpp
! src/hotspot/share/gc/shared/collectedHeap.cpp
! src/hotspot/share/gc/shared/collectedHeap.hpp
- src/hotspot/share/gc/shared/collectorPolicy.cpp
- src/hotspot/share/gc/shared/collectorPolicy.hpp
- src/hotspot/share/gc/shared/gcArguments.inline.hpp
! src/hotspot/share/gc/shared/markBitMap.cpp
! src/hotspot/share/gc/shared/markBitMap.inline.hpp
! src/hotspot/share/gc/shared/memAllocator.cpp
! src/hotspot/share/gc/shared/memAllocator.hpp
! src/hotspot/share/gc/shared/plab.cpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/referenceProcessor.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp
! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSetAssembler.hpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp
- src/hotspot/share/gc/z/zCollectorPolicy.cpp
- src/hotspot/share/gc/z/zCollectorPolicy.hpp
! src/hotspot/share/gc/z/zGranuleMap.hpp
! src/hotspot/share/gc/z/zGranuleMap.inline.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.cpp
- src/hotspot/share/gc/z/zPreMappedMemory.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.inline.hpp
! src/hotspot/share/oops/compressedOops.inline.hpp
! src/hotspot/share/oops/instanceMirrorKlass.cpp
! src/hotspot/share/oops/instanceRefKlass.inline.hpp
! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/oops/oop.hpp
! src/hotspot/share/oops/oop.inline.hpp
! src/hotspot/share/oops/oopsHierarchy.hpp
! src/hotspot/share/opto/classes.hpp
! src/hotspot/share/opto/lcm.cpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/loopTransform.cpp
! src/hotspot/share/opto/loopUnswitch.cpp
! src/hotspot/share/opto/loopnode.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/opto/loopopts.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/opto/macro.cpp
! src/hotspot/share/opto/matcher.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/node.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/opto/parse.hpp
! src/hotspot/share/opto/subnode.cpp
! src/hotspot/share/opto/subnode.hpp
! src/hotspot/share/opto/superword.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/fieldDescriptor.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/os.cpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/sharedRuntime.cpp
! src/hotspot/share/runtime/synchronizer.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/hotspot/share/utilities/bitMap.cpp
! src/hotspot/share/utilities/bitMap.hpp
- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPhysicalMemoryManager.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java
! test/hotspot/gtest/gc/z/test_zForwarding.cpp
! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocHumongousFragment.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocIntArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjectArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyCheckCast.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyStress.java
! test/hotspot/jtreg/gc/shenandoah/TestElasticTLAB.java
! test/hotspot/jtreg/gc/shenandoah/TestEvilSyncBug.java
! test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java
! test/hotspot/jtreg/gc/shenandoah/TestHeapUncommit.java
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java
! test/hotspot/jtreg/gc/shenandoah/TestLargeObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/TestLotsOfCycles.java
! test/hotspot/jtreg/gc/shenandoah/TestParallelRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestPeriodicGC.java
! test/hotspot/jtreg/gc/shenandoah/TestRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestRegionSampling.java
! test/hotspot/jtreg/gc/shenandoah/TestRetainObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSieveObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSmallHeap.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedup.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java
! test/hotspot/jtreg/gc/shenandoah/TestStringInternCleanup.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyLevels.java
! test/hotspot/jtreg/gc/shenandoah/TestWithLogLevel.java
! test/hotspot/jtreg/gc/shenandoah/TestWrongArrayMember.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1ArrayCopyNPE.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1VectorizedMismatch.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestCommonGCLoads.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestExpandedWBLostNullCheckDep.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestNullCheck.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestReferenceCAS.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestWriteBarrierClearControl.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNICritical.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNIGlobalRefs.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestPinnedGarbage.java
! test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestChurnNotifications.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryPools.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestPauseNotifications.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargeObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargerThanHeap.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocSmallObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestClassLoaderLeak.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
! test/hotspot/jtreg/gc/shenandoah/options/TestAlwaysPreTouch.java
! test/hotspot/jtreg/gc/shenandoah/options/TestArgumentRanges.java
! test/hotspot/jtreg/gc/shenandoah/options/TestClassUnloadingArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestCodeCacheRootStyles.java
! test/hotspot/jtreg/gc/shenandoah/options/TestEnabled.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGC.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGCNoConcurrent.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHumongousThresholdArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/options/TestPacing.java
! test/hotspot/jtreg/gc/shenandoah/options/TestParallelRegionStride.java
! test/hotspot/jtreg/gc/shenandoah/options/TestRegionSizeArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSingleThreaded.java
! test/hotspot/jtreg/gc/startup_warnings/TestShenandoah.java
! test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java
! test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithShenandoah.java
! test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach002/attach002Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/attach021Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach022/attach022Agent00.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t001/bi01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t002/bi01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI01/bi01t002/libbi01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/bi04t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/bcinstr/BI04/bi04t002/libbi04t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t001/em01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t001/libem01t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/em01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM01/em01t002/libem01t002.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t001/em02t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t001/libem02t001.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t010/em02t010.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t010/libem02t010.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t011/em02t011.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t011/libem02t011.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t012/em02t012.cpp
! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t012/libem02t012.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/BooleanArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/ByteArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/CharArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/DoubleArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/FloatArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/IntArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/LongArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/ShortArrayCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jni/StringCriticalLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIGlobalRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNILocalRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIRefLocker.cpp
! test/hotspot/jtreg/vmTestbase/nsk/share/gc/lock/jniref/JNIWeakGlobalRefLocker.cpp
- test/jdk/java/net/Socket/OldImpl.java
- test/jdk/java/net/Socket/OldSocketImpl.java
- test/jdk/java/net/Socket/OldSocketImplTestDriver.java


From gnu.andrew at redhat.com  Tue May 14 13:57:11 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Tue, 14 May 2019 14:57:11 +0100
Subject: [RFR] [8u] 8u222-b02 Upstream Sync
Message-ID: <c8f06a86-3738-4b8b-2b7e-9e3a31d64bea@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u222-b02:
  - S8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify
the dump
  - S8151539: Remove duplicate AlwaysTrueClosures
  - S8176100: [AArch64] [REDO][REDO] G1 Needs pre barrier on dereference
of weak JNI handles
  - S8176100: [REDO][REDO] G1 Needs pre barrier on dereference of weak
JNI handles
  - S8210416: [linux] Poor StrictMath performance due to non-optimized
compilation
  - S8217315: Proper units should print more significant digits
  - S8218674: HTML Tooltip with "img=src" on component doesn't show

Main issues of note:

The one to watch out for is JDK-8176100 and the changes to
src/share/vm/runtime/jniHandles.hpp in particular. In addition to having
to backport the AArch64 part of this from OpenJDK 9,
JNIHandles::guard_value was altered to continue the use of
oopDesc:equals and oopDesc:unsafe_equals used in the deleted parts of
resolve_external_guard and resolve_non_null.

diffstat for corba
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for hotspot (just the merge, not including AArch64 change)
 b/.hgtags
 |    1
 b/src/cpu/ppc/vm/frame_ppc.cpp
 |    9
 b/src/cpu/ppc/vm/interpreter_ppc.cpp
 |   11
 b/src/cpu/ppc/vm/macroAssembler_ppc.cpp
 |   34 ++
 b/src/cpu/ppc/vm/macroAssembler_ppc.hpp
 |    4
 b/src/cpu/ppc/vm/sharedRuntime_ppc.cpp
 |   11
 b/src/cpu/sparc/vm/jniFastGetField_sparc.cpp
 |    5
 b/src/cpu/sparc/vm/sharedRuntime_sparc.cpp
 |   31 +-
 b/src/cpu/sparc/vm/templateInterpreter_sparc.cpp
 |   24 +-
 b/src/cpu/x86/vm/jniFastGetField_x86_32.cpp
 |   25 +-
 b/src/cpu/x86/vm/jniFastGetField_x86_64.cpp
 |   20 +
 b/src/cpu/x86/vm/macroAssembler_x86.cpp
 |   36 +++
 b/src/cpu/x86/vm/macroAssembler_x86.hpp
 |    3
 b/src/cpu/x86/vm/sharedRuntime_x86_32.cpp
 |   11
 b/src/cpu/x86/vm/sharedRuntime_x86_64.cpp
 |   11
 b/src/cpu/x86/vm/templateInterpreter_x86_32.cpp
 |   15 -
 b/src/cpu/x86/vm/templateInterpreter_x86_64.cpp
 |   12 -
 b/src/cpu/zero/vm/cppInterpreter_zero.cpp
 |   10
 b/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
 |    8
 b/src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
 |    9
 b/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
|    9
 b/src/share/vm/memory/genCollectedHeap.cpp
 |    8
 b/src/share/vm/memory/iterator.hpp
 |   10
 b/src/share/vm/memory/referenceProcessor.cpp
 |    8
 b/src/share/vm/prims/jni.cpp
 |   10
 b/src/share/vm/prims/jvmtiEnv.cpp
 |    9
 b/src/share/vm/prims/whitebox.cpp
 |    6
 b/src/share/vm/runtime/javaCalls.cpp
 |  116 ++++++----
 b/src/share/vm/runtime/javaCalls.hpp
 |   95 ++++++--
 b/src/share/vm/runtime/jniHandles.cpp
 |   55 +++-
 b/src/share/vm/runtime/jniHandles.hpp
 |  108 +++++++--
 b/src/share/vm/services/heapDumper.cpp
 |   10
 b/src/share/vm/shark/sharkNativeWrapper.cpp
 |    3
 b/src/share/vm/utilities/globalDefinitions.cpp
 |   63 +++++
 b/src/share/vm/utilities/globalDefinitions.hpp
 |   18 +
 35 files changed, 576 insertions(+), 242 deletions(-)
diffstat for jaxp
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for jaxws
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for jdk
 b/.hgtags                                                  |    1
 b/make/lib/CoreLibraries.gmk                               |   19 +--
 b/src/share/classes/javax/swing/text/html/ImageView.java   |   72
++++++++----
 b/test/javax/swing/text/html/8218674/TooltipImageTest.java |   76
+++++++++++++
 4 files changed, 137 insertions(+), 31 deletions(-)
diffstat for langtools
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for nashorn
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for root
 b/.hgtags                                |    1
 b/common/autoconf/flags.m4               |   33 ++++++
 b/common/autoconf/generated-configure.sh |  147
++++++++++++++++++++++++++++++-
 b/common/autoconf/spec.gmk.in            |    1
 4 files changed, 181 insertions(+), 1 deletion(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Tue May 14 14:55:28 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 16:55:28 +0200
Subject: [RFR] [8u] 8u222-b02 Upstream Sync
In-Reply-To: <c8f06a86-3738-4b8b-2b7e-9e3a31d64bea@redhat.com>
References: <c8f06a86-3738-4b8b-2b7e-9e3a31d64bea@redhat.com>
Message-ID: <501d0fdd-82ea-f694-8785-ee7ac74f8b29@redhat.com>

On 5/14/19 3:57 PM, Andrew John Hughes wrote:
> Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b02/

corba: trivially fine.
jaxp: trivially fine.
jaxws: trivially fine.
langtools: trivially fine.
nashorn: trivially fine.

root: looks good.
jdk: looks good.

hotspot:

*) sharedRuntime_aarch64.cpp, templateInterpreter_aarch64.cpp, macroAssembler_x86.cpp,
jniHandles.cpp: new G1 blocks have to handle Shenandoah too. Luckily, we have this done in sh/jdk9
(archived), and it could be just picked up from there:

http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp#l2067
http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/templateInterpreterGenerator_aarch64.cpp#l1419
http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/x86/vm/macroAssembler_x86.cpp#l5272
http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/share/vm/runtime/jniHandles.cpp#l118

Otherwise looks okay.

-Aleksey


From shade at redhat.com  Tue May 14 15:10:22 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 17:10:22 +0200
Subject: [RFR] [8u] 8u222-b02 Upstream Sync
In-Reply-To: <501d0fdd-82ea-f694-8785-ee7ac74f8b29@redhat.com>
References: <c8f06a86-3738-4b8b-2b7e-9e3a31d64bea@redhat.com>
 <501d0fdd-82ea-f694-8785-ee7ac74f8b29@redhat.com>
Message-ID: <4c0b9bf8-2ee0-9775-2483-0179814db17e@redhat.com>

On 5/14/19 4:55 PM, Aleksey Shipilev wrote:
> hotspot:
> 
> *) sharedRuntime_aarch64.cpp, templateInterpreter_aarch64.cpp, macroAssembler_x86.cpp,
> jniHandles.cpp: new G1 blocks have to handle Shenandoah too. Luckily, we have this done in sh/jdk9
> (archived), and it could be just picked up from there:
> 
> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp#l2067
> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/templateInterpreterGenerator_aarch64.cpp#l1419
> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/x86/vm/macroAssembler_x86.cpp#l5272
> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/share/vm/runtime/jniHandles.cpp#l118
> 
> Otherwise looks okay.

I now remember another thing. The absence of Shenandoah additions in those blocks probably do not
crash the VM yet, because we have the Shenandoah-specific workaround for it:
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/119e9a5b24d5
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/d305c31da9f5

Merge is not the proper place to remove that workaround. Maybe we just push this merge verbatim, and
then we would do downstream work to remove the workaround and fix the issue properly with the
changes above, then integrate it back wholesale.

-Aleksey


From shade at redhat.com  Tue May 14 16:32:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 18:32:16 +0200
Subject: RFR/RFC: Shenandoah support for x86_32
In-Reply-To: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>
References: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>
Message-ID: <96073858-f2a3-0c9d-25d5-a23394ebf80d@redhat.com>

On 5/14/19 12:45 PM, Aleksey Shipilev wrote:
> http://cr.openjdk.java.net/~shade/shenandoah/32-bit/webrev.01/

Rebased for the actual sh/jdk:
 http://cr.openjdk.java.net/~shade/shenandoah/32-bit/webrev.02/

-Aleksey


From shade at redhat.com  Tue May 14 17:25:50 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 19:25:50 +0200
Subject: RFR: Remove superfluous verifier line
Message-ID: <15cacd13-3064-2048-d06c-80026608a21f@redhat.com>

There is a weird change in Verifier here:

https://builds.shipilev.net/patch-openjdk-shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp.sdiff.html

Roman does not know how it got there. I don't know what purpose would it serve. Anyhow, this does
not seem related to nofwdptr patch that is currently in sh/jdk stabilization. Let's ditch it.

diff -r a6e1d65b71d1 src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 17:32:18 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 19:15:25 2019 +0200
@@ -276,11 +276,10 @@
    * Verify oop fields from this object.
    * @param obj host object for verified fields
    */
   void verify_oops_from(oop obj) {
     _loc = obj;
-    obj = ShenandoahBarrierSet::resolve_forwarded_not_null(obj);
     obj->oop_iterate(this);
     _loc = NULL;
   }

   virtual void do_oop(oop* p) { do_oop_work(p); }

Testing: hotspot_gc_shenandoah (x86_64)

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May 14 17:27:31 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 19:27:31 +0200
Subject: RFR: Remove superfluous verifier line
In-Reply-To: <15cacd13-3064-2048-d06c-80026608a21f@redhat.com>
References: <15cacd13-3064-2048-d06c-80026608a21f@redhat.com>
Message-ID: <f46f2917-ec3a-33ce-56fc-b37124282c4a@redhat.com>

Yep. Good spot!
Thanks,
Roman


> There is a weird change in Verifier here:
> 
> https://builds.shipilev.net/patch-openjdk-shenandoah-jdk/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp.sdiff.html
> 
> Roman does not know how it got there. I don't know what purpose would it serve. Anyhow, this does
> not seem related to nofwdptr patch that is currently in sh/jdk stabilization. Let's ditch it.
> 
> diff -r a6e1d65b71d1 src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 17:32:18 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp    Tue May 14 19:15:25 2019 +0200
> @@ -276,11 +276,10 @@
>     * Verify oop fields from this object.
>     * @param obj host object for verified fields
>     */
>    void verify_oops_from(oop obj) {
>      _loc = obj;
> -    obj = ShenandoahBarrierSet::resolve_forwarded_not_null(obj);
>      obj->oop_iterate(this);
>      _loc = NULL;
>    }
> 
>    virtual void do_oop(oop* p) { do_oop_work(p); }
> 
> Testing: hotspot_gc_shenandoah (x86_64)
> 


From shade at redhat.com  Tue May 14 17:30:06 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 14 May 2019 17:30:06 +0000
Subject: hg: shenandoah/jdk: Remove superfluous verifier line
Message-ID: <201905141730.x4EHU6GT007709@aojmv0008.oracle.com>

Changeset: 3f469394848c
Author:    shade
Date:      2019-05-14 19:29 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3f469394848c

Remove superfluous verifier line

! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp


From shade at redhat.com  Tue May 14 18:25:54 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 14 May 2019 20:25:54 +0200
Subject: RFR: Move BiasedLocking and general mark preservation to prolog/epilog
Message-ID: <6112c8f4-a02e-5464-640d-b4c2d4385f80@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/nofwdptr-mc-marks/webrev.01/

Another this spotted in sh/jdk: preserved marks preparation/restoration is not at the same nesting
level in mark-compact. It is cleaner to have them near each other in more "general" prolog/epilog
sections.

Testing: hotspot_gc_shenadoah

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Tue May 14 19:04:16 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 21:04:16 +0200
Subject: RFR: Move BiasedLocking and general mark preservation to
 prolog/epilog
In-Reply-To: <6112c8f4-a02e-5464-640d-b4c2d4385f80@redhat.com>
References: <6112c8f4-a02e-5464-640d-b4c2d4385f80@redhat.com>
Message-ID: <46450eca-8a4e-7891-4339-20d959c54d8a@redhat.com>

That seems better indeed. Thanks!
Roman


> http://cr.openjdk.java.net/~shade/shenandoah/nofwdptr-mc-marks/webrev.01/
> 
> Another this spotted in sh/jdk: preserved marks preparation/restoration is not at the same nesting
> level in mark-compact. It is cleaner to have them near each other in more "general" prolog/epilog
> sections.
> 
> Testing: hotspot_gc_shenadoah
> 


From shade at redhat.com  Tue May 14 19:16:25 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 14 May 2019 19:16:25 +0000
Subject: hg: shenandoah/jdk: Move BiasedLocking and general mark preservation
 to prolog/epilog
Message-ID: <201905141916.x4EJGQXJ013775@aojmv0008.oracle.com>

Changeset: 50d6ac06b5a9
Author:    shade
Date:      2019-05-14 20:16 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/50d6ac06b5a9

Move BiasedLocking and general mark preservation to prolog/epilog

! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp


From rkennke at redhat.com  Tue May 14 20:23:57 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 14 May 2019 22:23:57 +0200
Subject: RFR/RFC: Shenandoah support for x86_32
In-Reply-To: <96073858-f2a3-0c9d-25d5-a23394ebf80d@redhat.com>
References: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>
 <96073858-f2a3-0c9d-25d5-a23394ebf80d@redhat.com>
Message-ID: <9bd7d193-53a5-84ae-d936-f4e3367a2781@redhat.com>

Very cute! This looks good to me.

Nope, we don't care about src in those places ;-) But we will when my
reshuffled arraycopy stuff lands, but this will probably take a little
while... no need to hold this here back.

I guess we will want to wait until the nofwdptr train has left the
station to jdk/jdk?

Roman

> On 5/14/19 12:45 PM, Aleksey Shipilev wrote:
>> http://cr.openjdk.java.net/~shade/shenandoah/32-bit/webrev.01/
> 
> Rebased for the actual sh/jdk:
>  http://cr.openjdk.java.net/~shade/shenandoah/32-bit/webrev.02/
> 
> -Aleksey
> 


From shade at redhat.com  Wed May 15 14:17:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 15 May 2019 16:17:26 +0200
Subject: RFR/RFC: Shenandoah support for x86_32
In-Reply-To: <9bd7d193-53a5-84ae-d936-f4e3367a2781@redhat.com>
References: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>
 <96073858-f2a3-0c9d-25d5-a23394ebf80d@redhat.com>
 <9bd7d193-53a5-84ae-d936-f4e3367a2781@redhat.com>
Message-ID: <6c30c0ef-0934-bad1-1fce-893c9bb86ce2@redhat.com>

On 5/14/19 10:23 PM, Roman Kennke wrote:
> I guess we will want to wait until the nofwdptr train has left the
> station to jdk/jdk?

Yes. Because otherwise I would need to implement and test Shenandoah-specific allocation path for
x86_32, which I don't want to do. It is fine to linger in my mq for a while.

-Aleksey


From shade at redhat.com  Wed May 15 14:23:24 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 15 May 2019 16:23:24 +0200
Subject: RFR: Print mark word in asserts
Message-ID: <a11e6fee-efe8-f292-5fd2-17d4ed0b9c77@redhat.com>

This is useful for debugging failures with nofwdptr patch. So this is destined to sh/jdk:

diff -r 50d6ac06b5a9 src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp     Tue May 14 20:16:20 2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp     Wed May 15 16:22:10 2019 +0200
@@ -60,6 +60,9 @@
   stringStream ss;
   r->print_on(&ss);

+  stringStream mw_ss;
+  obj->mark()->print_on(&mw_ss);
+
   ShenandoahMarkingContext* const ctx = heap->marking_context();

   msg.append("  " PTR_FORMAT " - klass " PTR_FORMAT " %s\n", p2i(obj), p2i(obj->klass()),
obj->klass()->external_name());
@@ -69,6 +72,7 @@
   if (heap->traversal_gc() != NULL) {
     msg.append("    %3s in traversal set\n",
heap->traversal_gc()->traversal_set()->is_in((HeapWord*) obj) ? "" : "not");
   }
+  msg.append("  mark:%s\n", mw_ss.as_string());
   msg.append("  region: %s", ss.as_string());
 }

Testing: hotspot_gc_shenandoah, eyeballing failures

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 15 14:26:00 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 15 May 2019 16:26:00 +0200
Subject: RFR: Print mark word in asserts
In-Reply-To: <a11e6fee-efe8-f292-5fd2-17d4ed0b9c77@redhat.com>
References: <a11e6fee-efe8-f292-5fd2-17d4ed0b9c77@redhat.com>
Message-ID: <0bfc5805-b565-7131-d36b-75d486072ca8@redhat.com>

Good!

Roman


> This is useful for debugging failures with nofwdptr patch. So this is destined to sh/jdk:
> 
> diff -r 50d6ac06b5a9 src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp     Tue May 14 20:16:20 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp     Wed May 15 16:22:10 2019 +0200
> @@ -60,6 +60,9 @@
>    stringStream ss;
>    r->print_on(&ss);
> 
> +  stringStream mw_ss;
> +  obj->mark()->print_on(&mw_ss);
> +
>    ShenandoahMarkingContext* const ctx = heap->marking_context();
> 
>    msg.append("  " PTR_FORMAT " - klass " PTR_FORMAT " %s\n", p2i(obj), p2i(obj->klass()),
> obj->klass()->external_name());
> @@ -69,6 +72,7 @@
>    if (heap->traversal_gc() != NULL) {
>      msg.append("    %3s in traversal set\n",
> heap->traversal_gc()->traversal_set()->is_in((HeapWord*) obj) ? "" : "not");
>    }
> +  msg.append("  mark:%s\n", mw_ss.as_string());
>    msg.append("  region: %s", ss.as_string());
>  }
> 
> Testing: hotspot_gc_shenandoah, eyeballing failures
> 


From shade at redhat.com  Wed May 15 14:27:10 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 15 May 2019 14:27:10 +0000
Subject: hg: shenandoah/jdk: Print mark word in asserts
Message-ID: <201905151427.x4FERAf3012831@aojmv0008.oracle.com>

Changeset: baac5053d215
Author:    shade
Date:      2019-05-15 15:55 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/baac5053d215

Print mark word in asserts

! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp


From shade at redhat.com  Wed May 15 17:52:30 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 15 May 2019 19:52:30 +0200
Subject: RFR (S) 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask
 verification
Message-ID: <7b6f57bc-6d63-86ec-fe1f-f98d62fd9a6f@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8223980

Fix:
  http://cr.openjdk.java.net/~shade/8223980/webrev.01/

Testing on old Solaris exposed funny bugs. We need verification done more consistently here. The
change is mostly equivalent, except the startup check moved to ShenandoahHeap where we know the heap
region addresses.

Testing: hotspot_gc_shenandoah; eyeballing failure messages after increasing {chunk|pow}_bits

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Wed May 15 18:32:13 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 15 May 2019 20:32:13 +0200
Subject: RFR (S) 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask
 verification
In-Reply-To: <7b6f57bc-6d63-86ec-fe1f-f98d62fd9a6f@redhat.com>
References: <7b6f57bc-6d63-86ec-fe1f-f98d62fd9a6f@redhat.com>
Message-ID: <c233a7d1-3d60-59f2-fe84-e218784a29c6@redhat.com>

Ok.

Roman

> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8223980
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8223980/webrev.01/
> 
> Testing on old Solaris exposed funny bugs. We need verification done more consistently here. The
> change is mostly equivalent, except the startup check moved to ShenandoahHeap where we know the heap
> region addresses.
> 
> Testing: hotspot_gc_shenandoah; eyeballing failure messages after increasing {chunk|pow}_bits
> 


From rkennke at redhat.com  Wed May 15 19:25:07 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 15 May 2019 21:25:07 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
Message-ID: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>

This backports the two changes:

- JDK-8221435: Shenandoah should not mark through weak roots
- JDK-8221629: Shenandoah: Cleanup class unloading logic

to shenandoah/jdk11

They are a fairly tricky beast, that's why I post them separately. They
should be functionally and structurally equivalent to what's in jdk/jdk,
but required some changes because weakProcessor is entirely different in
jdk11, and not as capable (no parallel processing). Zhengyu and I
eyeballed that it's doing the right thing (i.e. not mark through weak
roots).

Testing: hotspot_gc_shenandoah and eyeballing

Webrev:
http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/

Good?

Roman


From shade at redhat.com  Thu May 16 08:47:04 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 10:47:04 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
In-Reply-To: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
References: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
Message-ID: <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>

On 5/15/19 9:25 PM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/

Looks okay. Feels like a risky backport, are we good on testing?

Metadata does not follow our "[backport] ..." format:
  8221435: Shenandoah should not mark through weak roots
  8221629: Shenandoah: Cleanup class unloading logic

Also here:

 460   // And finally finish class unloading
 461   if (_heap->unload_classes()) {
 462     _heap->unload_classes_and_cleanup_tables(full_gc);
 463   } else if (ShenandoahStringDedup::is_enabled()) {
 464     ShenandoahIsAliveSelector alive;
 465     BoolObjectClosure* is_alive = alive.is_alive_closure();
 466     ShenandoahStringDedup::unlink_or_oops_do(is_alive, NULL, false);
 467   }

Are we sure class unloading and strdedup are exclusive here?

-Aleksey


From rkennke at redhat.com  Thu May 16 09:04:57 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 11:04:57 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
In-Reply-To: <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
References: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
 <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
Message-ID: <c1c5b656-8d5f-d9f3-8a82-9c003ac4b371@redhat.com>

Hi Aleksey,

>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/
> 
> Looks okay. Feels like a risky backport, are we good on testing?

Yeah, looks somewhat risky. I had Zhengyu help with backporting, runs
some tests and programs and eyeball that it does the right thing. I did
myself run the usual tests and some specjvm stuff, and it seems to look
good.

> Metadata does not follow our "[backport] ..." format:
>   8221435: Shenandoah should not mark through weak roots
>   8221629: Shenandoah: Cleanup class unloading logic

Oops:
http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.01/

> Also here:
> 
>  460   // And finally finish class unloading
>  461   if (_heap->unload_classes()) {
>  462     _heap->unload_classes_and_cleanup_tables(full_gc);
>  463   } else if (ShenandoahStringDedup::is_enabled()) {
>  464     ShenandoahIsAliveSelector alive;
>  465     BoolObjectClosure* is_alive = alive.is_alive_closure();
>  466     ShenandoahStringDedup::unlink_or_oops_do(is_alive, NULL, false);
>  467   }
> 
> Are we sure class unloading and strdedup are exclusive here?

I am not. We should raise this to Zhengyu, he should know. Also, this is
the same in sh/jdk and jdk/jdk, if it needs fixing, let's fix it there
first.

Ok?

Roman


From rkennke at redhat.com  Thu May 16 09:08:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 11:08:25 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
In-Reply-To: <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
References: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
 <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
Message-ID: <ea0de49c-0e0e-f43e-20db-86675ea74825@redhat.com>

>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/
> 
> Looks okay. Feels like a risky backport, are we good on testing?
> 
> Metadata does not follow our "[backport] ..." format:
>   8221435: Shenandoah should not mark through weak roots
>   8221629: Shenandoah: Cleanup class unloading logic
> 
> Also here:
> 
>  460   // And finally finish class unloading
>  461   if (_heap->unload_classes()) {
>  462     _heap->unload_classes_and_cleanup_tables(full_gc);
>  463   } else if (ShenandoahStringDedup::is_enabled()) {
>  464     ShenandoahIsAliveSelector alive;
>  465     BoolObjectClosure* is_alive = alive.is_alive_closure();
>  466     ShenandoahStringDedup::unlink_or_oops_do(is_alive, NULL, false);
>  467   }
> 
> Are we sure class unloading and strdedup are exclusive here?

Hmm actually I can see why that is the case for sh/jdk: there, the
strdedup stuff is unlinked by parallelCleaning, which is called by
_heap->unload_classes_and_cleanup_tables(full_gc), however, that doesn't
seem to be the case for jdk11. I'll look at it again...

Roman


From shade at redhat.com  Thu May 16 09:44:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 11:44:16 +0200
Subject: [cherrypick] JDK-8223911: Disable bad node budget verification until
 the fix
Message-ID: <16faa15c-e869-23c7-b287-2f6d57113fea@redhat.com>

We cannot pick up unstable jdk/jdk just yet, so let's just cherry-pick this one to sh/jdk:

diff -r baac5053d215 -r f5405ca2edea src/hotspot/share/opto/loopnode.hpp
--- a/src/hotspot/share/opto/loopnode.hpp       Wed May 15 15:55:12 2019 +0200
+++ b/src/hotspot/share/opto/loopnode.hpp       Wed May 15 11:53:47 2019 +0200
@@ -1384,7 +1384,8 @@
     uint required = _nodes_required;
     require_nodes_final();
     uint delta = C->live_nodes() - live_at_begin;
-    assert(delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
+    // Assert is disabled, see JDK-8223911 and related issues.
+    assert(true || delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
            delta, required);
   }

Testing: tier1_gc_shenandoah

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Thu May 16 09:58:28 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 11:58:28 +0200
Subject: [cherrypick] JDK-8223911: Disable bad node budget verification
 until the fix
In-Reply-To: <16faa15c-e869-23c7-b287-2f6d57113fea@redhat.com>
References: <16faa15c-e869-23c7-b287-2f6d57113fea@redhat.com>
Message-ID: <29e5c53a-0207-48d1-f010-1fd0d7b4a26a@redhat.com>

Ok.

Thanks,
Roman

> We cannot pick up unstable jdk/jdk just yet, so let's just cherry-pick this one to sh/jdk:
> 
> diff -r baac5053d215 -r f5405ca2edea src/hotspot/share/opto/loopnode.hpp
> --- a/src/hotspot/share/opto/loopnode.hpp       Wed May 15 15:55:12 2019 +0200
> +++ b/src/hotspot/share/opto/loopnode.hpp       Wed May 15 11:53:47 2019 +0200
> @@ -1384,7 +1384,8 @@
>      uint required = _nodes_required;
>      require_nodes_final();
>      uint delta = C->live_nodes() - live_at_begin;
> -    assert(delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
> +    // Assert is disabled, see JDK-8223911 and related issues.
> +    assert(true || delta <= 2 * required, "Bad node estimate (actual: %d, request: %d)",
>             delta, required);
>    }
> 
> Testing: tier1_gc_shenandoah
> 


From rkennke at redhat.com  Thu May 16 10:01:04 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 12:01:04 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
In-Reply-To: <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
References: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
 <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
Message-ID: <d502928f-5df8-8278-3c4a-fec2ee9b517f@redhat.com>

>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.00/
> 
> Looks okay. Feels like a risky backport, are we good on testing?
> 
> Metadata does not follow our "[backport] ..." format:
>   8221435: Shenandoah should not mark through weak roots
>   8221629: Shenandoah: Cleanup class unloading logic
> 
> Also here:
> 
>  460   // And finally finish class unloading
>  461   if (_heap->unload_classes()) {
>  462     _heap->unload_classes_and_cleanup_tables(full_gc);
>  463   } else if (ShenandoahStringDedup::is_enabled()) {
>  464     ShenandoahIsAliveSelector alive;
>  465     BoolObjectClosure* is_alive = alive.is_alive_closure();
>  466     ShenandoahStringDedup::unlink_or_oops_do(is_alive, NULL, false);
>  467   }
> 
> Are we sure class unloading and strdedup are exclusive here?

We should do StringDedup unlink stuff even when unloading classes. In
sh/jdk, this is done by ParallelCleaning, but jdk11 version doesn't do
that for us.

Testing: hotspot_gc_shenandoah still good

http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.02/

Roman



From shade at redhat.com  Thu May 16 10:09:30 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 12:09:30 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
Message-ID: <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>

On 5/13/19 5:00 PM, Zhengyu Gu wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223774
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.00/index.html

Oh, this is a cute refactoring!

First sweep:

*) Maybe make ShenandoahRoot{Processor,Evacuator,Updater} the superclass and give them
ShenandoahHeap in a const field? Then replace uses of ShenandoahHeap::heap() everywhere in them.
Maybe even move phase_timings() and safepoint asserts there.

*) Is there really a significant difference between ShenandoahRootAdjuster and
ShenandoahRootUpdater? Current thing is fine, just wanted to understand if they are common enough to
merge.

*) I think names should be "Root*s*" for e.g. ShenandoahClassLoaderDataRoot, etc.

*) "const" on new fields, where applicable?

*) shenandoahArguments.cpp: this block is better be in ShenandoahTraversalHeuristics?

 186   if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
 187     FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
 188   }
 189

*) This comment mentions ShenandoahConcurrentScanCodeRoots, but there are no uses in the subsequent
block. Need to move point (c) to somewhere else?

 118  //   c. With ShenandoahConcurrentScanCodeRoots, we avoid scanning the entire code cache here,
 119  //      and instead do that in concurrent phase under the relevant lock. This saves init mark
 120  //      pause time.


*) Indents:

 154 ShenandoahRootProcessor::ShenandoahRootProcessor(uint n_workers, ShenandoahPhaseTimings::Phase
phase) :
 155   _thread_roots(n_workers > 1),
 156    _phase(phase) {
 157   assert(SafepointSynchronize::is_at_safepoint(), "Must at safepoint");

*) Stick with one message here? E.g. "Should be during class unloading".

 178   assert(!ShenandoahHeap::heap()->unload_classes(), "Use without class unloading");
...
 192   assert(ShenandoahHeap::heap()->unload_classes(), "Use with class unloading cycle");


-Aleksey


From shade at redhat.com  Thu May 16 10:11:00 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 16 May 2019 10:11:00 +0000
Subject: hg: shenandoah/jdk: [cherrypick] JDK-8223911: Disable bad node budget
 verification until the fix
Message-ID: <201905161011.x4GAB030024183@aojmv0008.oracle.com>

Changeset: f5405ca2edea
Author:    shade
Date:      2019-05-15 11:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f5405ca2edea

[cherrypick] JDK-8223911: Disable bad node budget verification until the fix

! src/hotspot/share/opto/loopnode.hpp


From shade at redhat.com  Thu May 16 10:13:56 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 12:13:56 +0200
Subject: RFR: Backport JDK-8221435 and JDK-8221629
In-Reply-To: <d502928f-5df8-8278-3c4a-fec2ee9b517f@redhat.com>
References: <5e7cba05-cd09-917c-164d-c3e486dcd00b@redhat.com>
 <1b35394a-2289-1fd2-9c87-5126cb75b844@redhat.com>
 <d502928f-5df8-8278-3c4a-fec2ee9b517f@redhat.com>
Message-ID: <272dc9f7-4684-fa5a-88ad-cba8a54b984c@redhat.com>

On 5/16/19 12:01 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-15/webrev.02/

Okay!

-Aleksey


From rkennke at redhat.com  Thu May 16 10:25:33 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Thu, 16 May 2019 10:25:33 +0000
Subject: hg: shenandoah/jdk11: 2 new changesets
Message-ID: <201905161025.x4GAPY5H002140@aojmv0008.oracle.com>

Changeset: 6e176ad4e069
Author:    zgu
Date:      2019-03-26 12:12 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6e176ad4e069

[backport] 8221435: Shenandoah should not mark through weak roots
Reviewed-by: rkennke, shade

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.cpp
! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 3a1e23d1eadf
Author:    zgu
Date:      2019-03-28 13:53 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3a1e23d1eadf

[backport] 8221629: Shenandoah: Cleanup class unloading logic
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp


From rkennke at redhat.com  Thu May 16 10:46:29 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Thu, 16 May 2019 10:46:29 +0000
Subject: hg: shenandoah/jdk11: Added missing file from 'Shenandoah: Cleanup
 class unloading logic'
Message-ID: <201905161046.x4GAkUTA014928@aojmv0008.oracle.com>

Changeset: 0769efa9dbd8
Author:    rkennke
Date:      2019-05-16 12:46 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/0769efa9dbd8

Added missing file from 'Shenandoah: Cleanup class unloading logic'

+ src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp


From shade at redhat.com  Thu May 16 11:43:56 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 13:43:56 +0200
Subject: [11u] RFR/RFC: Bulk backport to sh/jdk11
Message-ID: <c7b4cdd9-1c72-e08e-db82-df8145bd978a@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190516/webrev.01/

This bunch includes:

 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
 8223762: Shenandoah: overflows in calculations involving heap capacity
 8223759: Shenandoah should allow arbitrarily low initial heap size
 8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
 8223446: Shenandoah breaks alignment with some HumongousThreshold values

Testing: hotspot_gc_shenandoah {fastdebug|release}, also with Graal enabled

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 16 12:19:03 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 14:19:03 +0200
Subject: [11u] RFR/RFC: Backport the remaining test for JDK-8220714
Message-ID: <114fe9df-364c-f2f9-57ad-7c683ef76ad9@redhat.com>

We have a special bug:
 https://bugs.openjdk.java.net/browse/JDK-8220714

It has shared fix, backported to 11.0.4, and we got it in sh/jdk11 with regular merge. And there is
Shenandoah-specific test that was obviously missing in upstream backports, and we need to backport
it separately. This is it:

$ hg qdiff --stat
 test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java |  109
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 109 insertions(+), 0 deletions(-)

[backport] 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe
Reviewed-by: vlivanov, roland

$ hg export
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java      Fri Mar 15 09:57:42
2019 +0100
@@ -0,0 +1,109 @@
+/*
+ * Copyright (c) 2019, Red Hat, Inc. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
...

Testing: new test, with/without Graal

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Thu May 16 12:42:38 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 14:42:38 +0200
Subject: [11u] RFR/RFC: Bulk backport to sh/jdk11
In-Reply-To: <c7b4cdd9-1c72-e08e-db82-df8145bd978a@redhat.com>
References: <c7b4cdd9-1c72-e08e-db82-df8145bd978a@redhat.com>
Message-ID: <ce271baf-97b0-c4a8-5957-1e1e90a7b122@redhat.com>

Ok looks good.
I'm taking care of remaining non-LRB backports. Sorry, I'm a bit slow
today, kids making troubles...

Cheers,
Roman


> http://cr.openjdk.java.net/~shade/shenandoah/backports/jdk11-20190516/webrev.01/
> 
> This bunch includes:
> 
>  8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
>  8223762: Shenandoah: overflows in calculations involving heap capacity
>  8223759: Shenandoah should allow arbitrarily low initial heap size
>  8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
>  8223447: Stabilize gc/shenandoah/TestStringDedupStress test
>  8223446: Shenandoah breaks alignment with some HumongousThreshold values
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}, also with Graal enabled
> 


From rkennke at redhat.com  Thu May 16 12:43:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 14:43:08 +0200
Subject: [11u] RFR/RFC: Backport the remaining test for JDK-8220714
In-Reply-To: <114fe9df-364c-f2f9-57ad-7c683ef76ad9@redhat.com>
References: <114fe9df-364c-f2f9-57ad-7c683ef76ad9@redhat.com>
Message-ID: <5a4f3459-ad63-4407-a58e-851cf29db660@redhat.com>

Yes, thanks!

Roman


> We have a special bug:
>  https://bugs.openjdk.java.net/browse/JDK-8220714
> 
> It has shared fix, backported to 11.0.4, and we got it in sh/jdk11 with regular merge. And there is
> Shenandoah-specific test that was obviously missing in upstream backports, and we need to backport
> it separately. This is it:
> 
> $ hg qdiff --stat
>  test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java |  109
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 109 insertions(+), 0 deletions(-)
> 
> [backport] 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe
> Reviewed-by: vlivanov, roland
> 
> $ hg export
> --- /dev/null   Thu Jan 01 00:00:00 1970 +0000
> +++ b/test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java      Fri Mar 15 09:57:42
> 2019 +0100
> @@ -0,0 +1,109 @@
> +/*
> + * Copyright (c) 2019, Red Hat, Inc. All rights reserved.
> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 only, as
> + * published by the Free Software Foundation.
> + *
> ...
> 
> Testing: new test, with/without Graal
> 


From zgu at redhat.com  Thu May 16 13:13:59 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 16 May 2019 09:13:59 -0400
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
Message-ID: <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>

Thanks for reviewing.

On 5/16/19 6:09 AM, Aleksey Shipilev wrote:
> On 5/13/19 5:00 PM, Zhengyu Gu wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223774
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.00/index.html
> 
> Oh, this is a cute refactoring!
> 
> First sweep:
> 
> *) Maybe make ShenandoahRoot{Processor,Evacuator,Updater} the superclass and give them
> ShenandoahHeap in a const field? Then replace uses of ShenandoahHeap::heap() everywhere in them.
> Maybe even move phase_timings() and safepoint asserts there.
> 
Done.

> *) Is there really a significant difference between ShenandoahRootAdjuster and
> ShenandoahRootUpdater? Current thing is fine, just wanted to understand if they are common enough to
> merge.

Not at this point, but will be with concurrent stuffs. Let's revisit 
this after that.

> 
> *) I think names should be "Root*s*" for e.g. ShenandoahClassLoaderDataRoot, etc.
> 
Done.

> *) "const" on new fields, where applicable?
Done

> 
> *) shenandoahArguments.cpp: this block is better be in ShenandoahTraversalHeuristics?
> 
>   186   if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
>   187     FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>   188   }
>   189

We don't have this heuristic, let's do it in follow up RFE.

> 
> *) This comment mentions ShenandoahConcurrentScanCodeRoots, but there are no uses in the subsequent
> block. Need to move point (c) to somewhere else?
> 
>   118  //   c. With ShenandoahConcurrentScanCodeRoots, we avoid scanning the entire code cache here,
>   119  //      and instead do that in concurrent phase under the relevant lock. This saves init mark
>   120  //      pause time.
>

Moved to right place.

> 
> *) Indents:
> 
>   154 ShenandoahRootProcessor::ShenandoahRootProcessor(uint n_workers, ShenandoahPhaseTimings::Phase
> phase) :
>   155   _thread_roots(n_workers > 1),
>   156    _phase(phase) {
>   157   assert(SafepointSynchronize::is_at_safepoint(), "Must at safepoint");
> 
> *) Stick with one message here? E.g. "Should be during class unloading".
> 
>   178   assert(!ShenandoahHeap::heap()->unload_classes(), "Use without class unloading");
> ...
>   192   assert(ShenandoahHeap::heap()->unload_classes(), "Use with class unloading cycle");
> 
Done.

Updated: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.01/

Reran hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

> 
> -Aleksey
> 

From rkennke at redhat.com  Thu May 16 13:30:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 15:30:25 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
Message-ID: <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>

>> *) shenandoahArguments.cpp: this block is better be in
>> ShenandoahTraversalHeuristics?
>>
>> ? 186?? if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
>> ? 187???? FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>> ? 188?? }
>> ? 189
> 
> We don't have this heuristic, let's do it in follow up RFE.

We do:
src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.hpp

and

src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp

Roman


From rkennke at redhat.com  Thu May 16 13:57:38 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 15:57:38 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
Message-ID: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>

This backports the following changes to sh/jdk11:

JDK-8221751: Shenandoah: Improve SATB enqueueing
JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
JDK-8222227: Shenandoah: Fix Traversal GC weak roots handling in
final-traversal pause
JDK-8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
JDK-8222188: Shenandoah: Adjust Shenandoah work gang types
JDK-8218468: Load barrier slow path node should be MachTypeNode
JDK-8223651: Build fails with --with-jvm-features=-jfr and
--disable-precompiled-headers

Changes transplanted with minimal and simple changes.
Testing: hotspot_gc_shenandoah fine

Ok?

Note: I cut out the following change:
JDK-8223570: Shenandoah needs to acquire lock before
CLDG::clear_claimed_marks

We have no ClassLoaderDataGraph_lock in jdk11, and the change made me
think that we either move the clear_claimed_marks() to the end of
init_traversal(), or look into removing it, because it should not be
necessary (it's a smell). In any case, this should be reworked in
jdk/jdk and then percolated down.

Roman


From zgu at redhat.com  Thu May 16 14:25:54 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 16 May 2019 10:25:54 -0400
Subject: RFR(S) 8223951: Shenandoah: Only need to update thread roots during
 final update refs
Message-ID: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>

After switching to strong to-space invariant and pre-evacuating all 
root, thread roots are only places that may contain to-space oops after 
updating references during normal concurrent cycles, we only need to 
update them during final updaterefs pause, which should reduce pause time.

Bug: https://bugs.openjdk.java.net/browse/JDK-8223951
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223951/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From zgu at redhat.com  Thu May 16 14:33:23 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 16 May 2019 10:33:23 -0400
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
Message-ID: <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>



On 5/16/19 9:30 AM, Roman Kennke wrote:
>>> *) shenandoahArguments.cpp: this block is better be in
>>> ShenandoahTraversalHeuristics?
>>>
>>>  ? 186?? if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
>>>  ? 187???? FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>>>  ? 188?? }
>>>  ? 189
>>
>> We don't have this heuristic, let's do it in follow up RFE.
> 
> We do:
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.hpp
> 
> and
> 
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
> 

Sorry, I meant can_concurrent_scan_code_roots() in heuristics ...

-Zhengyu


> Roman
> 

From rkennke at redhat.com  Thu May 16 14:39:39 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 16:39:39 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
 <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
Message-ID: <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>



> On 5/16/19 9:30 AM, Roman Kennke wrote:
>>>> *) shenandoahArguments.cpp: this block is better be in
>>>> ShenandoahTraversalHeuristics?
>>>>
>>>> ?? 186?? if (strcmp(ShenandoahGCHeuristics, "traversal") == 0) {
>>>> ?? 187???? FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>>>> ?? 188?? }
>>>> ?? 189
>>>
>>> We don't have this heuristic, let's do it in follow up RFE.
>>
>> We do:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.hpp
>>
>>
>> and
>>
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
>>
>>
> 
> Sorry, I meant can_concurrent_scan_code_roots() in heuristics ...
> 

But you can put the line:

FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);

in the constructor of the ShenandoahTraversalHeuristics, together with
other similar lines.

Roman



From boris.ulasevich at bell-sw.com  Thu May 16 14:43:37 2019
From: boris.ulasevich at bell-sw.com (Boris Ulasevich)
Date: Thu, 16 May 2019 17:43:37 +0300
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
 <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
Message-ID: <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>

Roman,

I prepared backporting patch to sh/jdk11 and sh/jdk8:

http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk11
- added minor change in shared code: share/opto/compile.hpp

http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk8.hotspot
- stdarg.h include added to satisfy va_list in shenandoahLogging.hpp

Both backports passed hotspot_gc_shenandoah on Solaris 11. For Solaris 
10 JDK-8223980 (Refactor and fix ObjArrayChunkedTask verification) needs 
to be backported as well.

What is the correct backport procedure?

regards,
Boris

On 14.05.2019 12:25, Roman Kennke wrote:
> Hi Boris,
> 
> Would you help backporting the patch to sh/jdk11 and sh/jdk8 at some
> point? It would be cool to have there, but we have no way to test it...
> 
> Thanks,
> Roman
> 
>> Thanks for the review!
>>
>> 13.05.2019 18:43, Aleksey Shipilev:
>>> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>>>> http://bugs.openjdk.java.net/browse/JDK-8223767
>>>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
>>> Thank you, this looks good.
>>>
>>> -Aleksey
> 

From zgu at redhat.com  Thu May 16 15:09:17 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 16 May 2019 11:09:17 -0400
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
 <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
 <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>
Message-ID: <60b7f75e-b8ec-7122-4e39-f7dca14a2ea8@redhat.com>

>>
> 
> But you can put the line:
> 
> FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
> 
> in the constructor of the ShenandoahTraversalHeuristics, together with
> other similar lines.
Ah, I misunderstood.

Updated: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.02/

-Zhengyu

> 
> Roman
> 
> 

From rkennke at redhat.com  Thu May 16 15:43:22 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 17:43:22 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
 <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
 <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>
Message-ID: <596a0613-97f1-5673-01c9-06f63f8edbcb@redhat.com>

Hi Boris,

> I prepared backporting patch to sh/jdk11 and sh/jdk8:
> 
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk11
> - added minor change in shared code: share/opto/compile.hpp
> 
> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00.shenandoah.jdk8.hotspot
> 
> - stdarg.h include added to satisfy va_list in shenandoahLogging.hpp
> 
> Both backports passed hotspot_gc_shenandoah on Solaris 11. For Solaris
> 10 JDK-8223980 (Refactor and fix ObjArrayChunkedTask verification) needs
> to be backported as well.

Cool! Thanks you!!

> What is the correct backport procedure?

I think for the Shenandoah parts it's fine to post them here for review,
and one of us can integrate them to shenandoah/jdk11 and shenandoah/jdk8
for you. Please prepare the changesets with prefixed [backport] in the
commit msg, e.g.:

[backport] 8223767: Shenandoah fails to build on Solaris x86_64


To be honest, I am not sure about the rather trivial change in
compile.hpp. I guess ideally this would have to go via separate change
through jdk-updates/jdk11u.

Thanks,
Roman

> regards,
> Boris
> 
> On 14.05.2019 12:25, Roman Kennke wrote:
>> Hi Boris,
>>
>> Would you help backporting the patch to sh/jdk11 and sh/jdk8 at some
>> point? It would be cool to have there, but we have no way to test it...
>>
>> Thanks,
>> Roman
>>
>>> Thanks for the review!
>>>
>>> 13.05.2019 18:43, Aleksey Shipilev:
>>>> On 5/13/19 5:27 PM, Boris Ulasevich wrote:
>>>>> http://bugs.openjdk.java.net/browse/JDK-8223767
>>>>> http://cr.openjdk.java.net/~bulasevich/8223767/webrev.00
>>>> Thank you, this looks good.
>>>>
>>>> -Aleksey
>>


From rkennke at redhat.com  Thu May 16 16:02:47 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 18:02:47 +0200
Subject: RFR: JDK-8224043: Shenandoah: Remove clear_claimed_marks() from start
 of concurrent_traversal()
Message-ID: <a311925a-0958-5df4-7c52-e8a88dc9eddd@redhat.com>

Currently we clear claimed marks in the CLD at the start of concurrent
traversal phase. This is (no more) necessary, and in fact leads to
marking through CLD structures during traversal again, even when they
have already been seen during init-traversal.

This changeset simply removes the little block. I've tested by running
all of hotspot_gc_shenandoah on it, plus a bunch of applications
including specjvm with traversal and +ShenandoahVerify. Looks all good.

http://cr.openjdk.java.net/~rkennke/JDK-8224043/webrev.00/

Ok?

Roman


From shade at redhat.com  Thu May 16 16:45:41 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 16 May 2019 16:45:41 +0000
Subject: hg: shenandoah/jdk11: 7 new changesets
Message-ID: <201905161645.x4GGjgEm016621@aojmv0008.oracle.com>

Changeset: 97640d3c6b2b
Author:    shade
Date:      2019-05-15 22:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/97640d3c6b2b

[backport] 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp

Changeset: c817d35db4b3
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c817d35db4b3

[backport] 8223762: Shenandoah: overflows in calculations involving heap capacity
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp
! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp

Changeset: 9e8f15cea713
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9e8f15cea713

[backport] 8223759: Shenandoah should allow arbitrarily low initial heap size
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! test/hotspot/jtreg/gc/shenandoah/options/TestRegionSizeArgs.java

Changeset: d83a256be807
Author:    pli
Date:      2019-05-08 09:50 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d83a256be807

[backport] 8223427: [TESTBUG] Disable JTReg Shenandoah tests when Graal is enabled
Reviewed-by: shade

! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocHumongousFragment.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocIntArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjectArrays.java
! test/hotspot/jtreg/gc/shenandoah/TestAllocObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyCheckCast.java
! test/hotspot/jtreg/gc/shenandoah/TestArrayCopyStress.java
! test/hotspot/jtreg/gc/shenandoah/TestElasticTLAB.java
! test/hotspot/jtreg/gc/shenandoah/TestEvilSyncBug.java
! test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java
! test/hotspot/jtreg/gc/shenandoah/TestHeapUncommit.java
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java
! test/hotspot/jtreg/gc/shenandoah/TestLargeObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/TestLotsOfCycles.java
! test/hotspot/jtreg/gc/shenandoah/TestParallelRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestPeriodicGC.java
! test/hotspot/jtreg/gc/shenandoah/TestRefprocSanity.java
! test/hotspot/jtreg/gc/shenandoah/TestRegionSampling.java
! test/hotspot/jtreg/gc/shenandoah/TestRetainObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSieveObjects.java
! test/hotspot/jtreg/gc/shenandoah/TestSmallHeap.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedup.java
! test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java
! test/hotspot/jtreg/gc/shenandoah/TestStringInternCleanup.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java
! test/hotspot/jtreg/gc/shenandoah/TestVerifyLevels.java
! test/hotspot/jtreg/gc/shenandoah/TestWithLogLevel.java
! test/hotspot/jtreg/gc/shenandoah/TestWrongArrayMember.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1ArrayCopyNPE.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestC1VectorizedMismatch.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestCommonGCLoads.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestExpandedWBLostNullCheckDep.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestNullCheck.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestReferenceCAS.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestWriteBarrierClearControl.java
! test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeArgs.java
! test/hotspot/jtreg/gc/shenandoah/jni/CriticalNativeStress.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNICritical.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestJNIGlobalRefs.java
! test/hotspot/jtreg/gc/shenandoah/jni/TestPinnedGarbage.java
! test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestChurnNotifications.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryPools.java
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestPauseNotifications.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargeObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocLargerThanHeap.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestAllocSmallObj.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestClassLoaderLeak.java
! test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
! test/hotspot/jtreg/gc/shenandoah/options/TestAlwaysPreTouch.java
! test/hotspot/jtreg/gc/shenandoah/options/TestArgumentRanges.java
! test/hotspot/jtreg/gc/shenandoah/options/TestClassUnloadingArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestCodeCacheRootStyles.java
! test/hotspot/jtreg/gc/shenandoah/options/TestCriticalControlThreadPriority.java
! test/hotspot/jtreg/gc/shenandoah/options/TestEnabled.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGC.java
! test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGCNoConcurrent.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java
! test/hotspot/jtreg/gc/shenandoah/options/TestHumongousThresholdArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java
! test/hotspot/jtreg/gc/shenandoah/options/TestObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/options/TestPacing.java
! test/hotspot/jtreg/gc/shenandoah/options/TestParallelRegionStride.java
! test/hotspot/jtreg/gc/shenandoah/options/TestRegionSizeArgs.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSafepointWorkers.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java
! test/hotspot/jtreg/gc/shenandoah/options/TestSingleThreaded.java
! test/hotspot/jtreg/gc/shenandoah/options/TestWrongBarrierDisable.java
! test/hotspot/jtreg/gc/startup_warnings/TestShenandoah.java
! test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java
! test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithShenandoah.java
! test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java

Changeset: c8af35e37519
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c8af35e37519

[backport] 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
Reviewed-by: rkennke

! test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java

Changeset: 0e07de3ab51e
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/0e07de3ab51e

[backport] 8223446: Shenandoah breaks alignment with some HumongousThreshold values
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java

Changeset: 95e58cb56199
Author:    rkennke
Date:      2019-03-15 09:57 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/95e58cb56199

[backport] 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe
Reviewed-by: vlivanov, roland

+ test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java


From shade at redhat.com  Thu May 16 16:47:39 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 18:47:39 +0200
Subject: RFR: JDK-8224043: Shenandoah: Remove clear_claimed_marks() from
 start of concurrent_traversal()
In-Reply-To: <a311925a-0958-5df4-7c52-e8a88dc9eddd@redhat.com>
References: <a311925a-0958-5df4-7c52-e8a88dc9eddd@redhat.com>
Message-ID: <8986dbe1-8de8-6840-c7fc-a9a318de1bba@redhat.com>

On 5/16/19 6:02 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/JDK-8224043/webrev.00/

Okay then. We should have done it from the beginning! Eh.

-Aleksey


From shade at redhat.com  Thu May 16 16:49:22 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 18:49:22 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
In-Reply-To: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
References: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
Message-ID: <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>

On 5/16/19 3:57 PM, Roman Kennke wrote:
> This backports the following changes to sh/jdk11:
> 
> JDK-8221751: Shenandoah: Improve SATB enqueueing
> JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
> JDK-8222227: Shenandoah: Fix Traversal GC weak roots handling in
> final-traversal pause
> JDK-8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
> JDK-8222188: Shenandoah: Adjust Shenandoah work gang types
> JDK-8218468: Load barrier slow path node should be MachTypeNode
> JDK-8223651: Build fails with --with-jvm-features=-jfr and
> --disable-precompiled-headers
> 
> Changes transplanted with minimal and simple changes.
> Testing: hotspot_gc_shenandoah fine
> 
> Ok?

Okay. Is there a webrev that shows the changes, for the record?

-Aleksey


From shade at redhat.com  Thu May 16 16:53:34 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 18:53:34 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <596a0613-97f1-5673-01c9-06f63f8edbcb@redhat.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
 <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
 <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>
 <596a0613-97f1-5673-01c9-06f63f8edbcb@redhat.com>
Message-ID: <9f832ee6-2f06-d29f-807b-125e1f853646@redhat.com>

On 5/16/19 5:43 PM, Roman Kennke wrote:
>> What is the correct backport procedure?
> 
> I think for the Shenandoah parts it's fine to post them here for review,
> and one of us can integrate them to shenandoah/jdk11 and shenandoah/jdk8
> for you. Please prepare the changesets with prefixed [backport] in the
> commit msg, e.g.:
> 
> [backport] 8223767: Shenandoah fails to build on Solaris x86_64

I can do this myself while sponsoring fixes for Boris. Thanks for the backport!

> To be honest, I am not sure about the rather trivial change in
> compile.hpp. I guess ideally this would have to go via separate change
> through jdk-updates/jdk11u.

This change is our own code, no need (or use) to go via upstream:

https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/share/opto/compile.hpp.sdiff.html

-Aleksey


From rkennke at redhat.com  Thu May 16 17:06:23 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 19:06:23 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
In-Reply-To: <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>
References: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
 <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>
Message-ID: <6e9f7ad4-a78c-a0f1-807d-c8946ece713b@redhat.com>

>> This backports the following changes to sh/jdk11:
>>
>> JDK-8221751: Shenandoah: Improve SATB enqueueing
>> JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
>> JDK-8222227: Shenandoah: Fix Traversal GC weak roots handling in
>> final-traversal pause
>> JDK-8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
>> JDK-8222188: Shenandoah: Adjust Shenandoah work gang types
>> JDK-8218468: Load barrier slow path node should be MachTypeNode
>> JDK-8223651: Build fails with --with-jvm-features=-jfr and
>> --disable-precompiled-headers
>>
>> Changes transplanted with minimal and simple changes.
>> Testing: hotspot_gc_shenandoah fine
>>
>> Ok?
> 
> Okay. Is there a webrev that shows the changes, for the record?

Oops, forgot to include it:

http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-16/webrev.00/

Roman


From shade at redhat.com  Thu May 16 17:18:03 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 19:18:03 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
In-Reply-To: <6e9f7ad4-a78c-a0f1-807d-c8946ece713b@redhat.com>
References: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
 <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>
 <6e9f7ad4-a78c-a0f1-807d-c8946ece713b@redhat.com>
Message-ID: <d33f5910-3f81-8d44-4c0c-a962406b8f89@redhat.com>

On 5/16/19 7:06 PM, Roman Kennke wrote:
>>> This backports the following changes to sh/jdk11:
>>>
>>> JDK-8221751: Shenandoah: Improve SATB enqueueing
>>> JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
>>> JDK-8222227: Shenandoah: Fix Traversal GC weak roots handling in
>>> final-traversal pause
>>> JDK-8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
>>> JDK-8222188: Shenandoah: Adjust Shenandoah work gang types
>>> JDK-8218468: Load barrier slow path node should be MachTypeNode
>>> JDK-8223651: Build fails with --with-jvm-features=-jfr and
>>> --disable-precompiled-headers
>>>
>>> Changes transplanted with minimal and simple changes.
>>> Testing: hotspot_gc_shenandoah fine
>>>
>>> Ok?
>>
>> Okay. Is there a webrev that shows the changes, for the record?
> 
> Oops, forgot to include it:
> 
> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-16/webrev.00/

*) The indenting is weird here in shenandoahBarrierSetAssembler_aarch64.cpp -- is it the same way in
upstream?

  90   if (is_oop) {
  91       Label done;
  92
  93       // Avoid calling runtime if count == 0
  94       __ cbz(count, done);
  95
  96       // Is updating references?
  97       Address gc_state(rthread, in_bytes(ShenandoahThreadLocalData::gc_state_offset()));
  98       __ ldrb(rscratch1, gc_state);
  99       __ tbz(rscratch1, ShenandoahHeap::UPDATEREFS_BITPOS, done);
 100
 101     __ push(saved_regs, sp);

Otherwise looks fine.

-Aleksey


From shade at redhat.com  Thu May 16 17:56:45 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 16 May 2019 17:56:45 +0000
Subject: hg: shenandoah/jdk11: [backport] 8223767: Shenandoah fails to build
 on Solaris x86_64
Message-ID: <201905161756.x4GHukOK006643@aojmv0008.oracle.com>

Changeset: 159ea4412948
Author:    bulasevich
Date:      2019-05-16 19:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/159ea4412948

[backport] 8223767: Shenandoah fails to build on Solaris x86_64

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAllocRequest.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahControlThread.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.hpp
! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp
! src/hotspot/share/opto/compile.hpp


From shade at redhat.com  Thu May 16 17:58:41 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 16 May 2019 17:58:41 +0000
Subject: hg: shenandoah/jdk8/hotspot: [backport] 8223767: Shenandoah fails to
 build on Solaris x86_64
Message-ID: <201905161758.x4GHwf7A007218@aojmv0008.oracle.com>

Changeset: 468dd92b90f9
Author:    bulasevich
Date:      2019-05-16 19:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/468dd92b90f9

[backport] 8223767: Shenandoah fails to build on Solaris x86_64

! src/share/vm/gc_implementation/shenandoah/shenandoahAllocRequest.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahAsserts.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahControlThread.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahLogging.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahNumberSeq.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahOopClosures.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahSharedVariables.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.hpp
! src/share/vm/opto/shenandoahSupport.hpp


From shade at redhat.com  Thu May 16 18:00:18 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 20:00:18 +0200
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <9f832ee6-2f06-d29f-807b-125e1f853646@redhat.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
 <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
 <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>
 <596a0613-97f1-5673-01c9-06f63f8edbcb@redhat.com>
 <9f832ee6-2f06-d29f-807b-125e1f853646@redhat.com>
Message-ID: <27b5d599-b25f-073d-0609-1c84c2433d1d@redhat.com>

On 5/16/19 6:53 PM, Aleksey Shipilev wrote:
> On 5/16/19 5:43 PM, Roman Kennke wrote:
>>> What is the correct backport procedure?
>>
>> I think for the Shenandoah parts it's fine to post them here for review,
>> and one of us can integrate them to shenandoah/jdk11 and shenandoah/jdk8
>> for you. Please prepare the changesets with prefixed [backport] in the
>> commit msg, e.g.:
>>
>> [backport] 8223767: Shenandoah fails to build on Solaris x86_64
> 
> I can do this myself while sponsoring fixes for Boris. Thanks for the backport!

There:
  http://hg.openjdk.java.net/shenandoah/jdk11/rev/159ea4412948
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/468dd92b90f9

Pushed them with "author" set to "bulasevich" to give credit.

-Aleksey


From rkennke at redhat.com  Thu May 16 18:02:43 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 20:02:43 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
In-Reply-To: <d33f5910-3f81-8d44-4c0c-a962406b8f89@redhat.com>
References: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
 <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>
 <6e9f7ad4-a78c-a0f1-807d-c8946ece713b@redhat.com>
 <d33f5910-3f81-8d44-4c0c-a962406b8f89@redhat.com>
Message-ID: <fdfd13e7-9da3-c0d1-0dda-4128055072aa@redhat.com>

>>>> This backports the following changes to sh/jdk11:
>>>>
>>>> JDK-8221751: Shenandoah: Improve SATB enqueueing
>>>> JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
>>>> JDK-8222227: Shenandoah: Fix Traversal GC weak roots handling in
>>>> final-traversal pause
>>>> JDK-8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
>>>> JDK-8222188: Shenandoah: Adjust Shenandoah work gang types
>>>> JDK-8218468: Load barrier slow path node should be MachTypeNode
>>>> JDK-8223651: Build fails with --with-jvm-features=-jfr and
>>>> --disable-precompiled-headers
>>>>
>>>> Changes transplanted with minimal and simple changes.
>>>> Testing: hotspot_gc_shenandoah fine
>>>>
>>>> Ok?
>>>
>>> Okay. Is there a webrev that shows the changes, for the record?
>>
>> Oops, forgot to include it:
>>
>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-2019-05-16/webrev.00/
> 
> *) The indenting is weird here in shenandoahBarrierSetAssembler_aarch64.cpp -- is it the same way in
> upstream?
> 
>   90   if (is_oop) {
>   91       Label done;
>   92
>   93       // Avoid calling runtime if count == 0
>   94       __ cbz(count, done);
>   95
>   96       // Is updating references?
>   97       Address gc_state(rthread, in_bytes(ShenandoahThreadLocalData::gc_state_offset()));
>   98       __ ldrb(rscratch1, gc_state);
>   99       __ tbz(rscratch1, ShenandoahHeap::UPDATEREFS_BITPOS, done);
>  100
>  101     __ push(saved_regs, sp);
> 
> Otherwise looks fine.

Yes:
http://hg.openjdk.java.net/jdk/jdk/file/b6ee58ec8814/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp#l90

Want me to change it for 11 now?

Roman


From shade at redhat.com  Thu May 16 18:04:04 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 16 May 2019 20:04:04 +0200
Subject: RFR: Remaining Shenandoah backports jdk/jdk -> sh/jdk11
In-Reply-To: <fdfd13e7-9da3-c0d1-0dda-4128055072aa@redhat.com>
References: <8cc3ca3f-bb36-8937-bf33-e0988bc82e14@redhat.com>
 <b5146bc0-2819-00ac-16fa-bc733282f23e@redhat.com>
 <6e9f7ad4-a78c-a0f1-807d-c8946ece713b@redhat.com>
 <d33f5910-3f81-8d44-4c0c-a962406b8f89@redhat.com>
 <fdfd13e7-9da3-c0d1-0dda-4128055072aa@redhat.com>
Message-ID: <58add158-193d-8216-f642-62e519880599@redhat.com>

On 5/16/19 8:02 PM, Roman Kennke wrote:
>> *) The indenting is weird here in shenandoahBarrierSetAssembler_aarch64.cpp -- is it the same way in
>> upstream?
>>
>>   90   if (is_oop) {
>>   91       Label done;
>>   92
>>   93       // Avoid calling runtime if count == 0
>>   94       __ cbz(count, done);
>>   95
>>   96       // Is updating references?
>>   97       Address gc_state(rthread, in_bytes(ShenandoahThreadLocalData::gc_state_offset()));
>>   98       __ ldrb(rscratch1, gc_state);
>>   99       __ tbz(rscratch1, ShenandoahHeap::UPDATEREFS_BITPOS, done);
>>  100
>>  101     __ push(saved_regs, sp);
>>
> Yes:
> http://hg.openjdk.java.net/jdk/jdk/file/b6ee58ec8814/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp#l90
> 
> Want me to change it for 11 now?

No. Better have the same code. Reformats would apply later as we refactor code nearby in upstream.

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Thu May 16 19:09:18 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Thu, 16 May 2019 19:09:18 +0000
Subject: hg: shenandoah/jdk11: 7 new changesets
Message-ID: <201905161909.x4GJ9JfV022465@aojmv0008.oracle.com>

Changeset: 0d5e66cf201a
Author:    rkennke
Date:      2019-04-02 18:13 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/0d5e66cf201a

[backport] 8221751: Shenandoah: Improve SATB enqueueing
Reviewed-by: shade

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp

Changeset: eb8efa1f5c90
Author:    rkennke
Date:      2019-04-04 21:29 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/eb8efa1f5c90

[backport] 8221848: Shenandoah: ArrayCopy post-barrier improvements
Reviewed-by: zgu

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: 3289ddff172e
Author:    rkennke
Date:      2019-04-09 23:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3289ddff172e

[backport] 8222227: Shenandoah: Fix Traversal GC weak roots handling in final-traversal pause
Reviewed-by: shade, zgu

! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 5620e87eb8dd
Author:    rkennke
Date:      2019-04-10 13:21 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5620e87eb8dd

[backport] 8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 3093109f12c2
Author:    zgu
Date:      2019-04-12 07:51 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3093109f12c2

[backport] 8222188: Shenandoah: Adjust Shenandoah work gang types
Reviewed-by: shade, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTimingTracker.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp

Changeset: 37149dafd962
Author:    neliasso
Date:      2019-04-17 09:54 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/37149dafd962

[backport] 8218468: Load barrier slow path node should be MachTypeNode
Reviewed-by: shade, pliden, kvn

! src/hotspot/share/adlc/formssel.cpp

Changeset: 649b5a98e413
Author:    aoqi
Date:      2019-05-10 01:41 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/649b5a98e413

[backport] 8223651: Build fails with --with-jvm-features=-jfr and --disable-precompiled-headers
Reviewed-by: shade
Contributed-by: Wang Haomin <wanghaomin at loongson.cn>

! src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp


From rkennke at redhat.com  Thu May 16 20:32:37 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 16 May 2019 22:32:37 +0200
Subject: RFR (sh/jdk11): [backport] 8224043: Shenandoah: Remove
 clear_claimed_marks() from start of concurrent_traversal()
Message-ID: <8654a372-0e1a-cb99-aafe-4ff8597be33a@redhat.com>

Let's backport today's change to remove clear_claimed_marks() to jdk11.

Testing: hotspot_gc_shenandoah and some point-testing specjvm

Ok?

The other remaining changes seem to be LRB or arraycopy related, which I
would do separately. (And arraycopy is actually missing the real change
JDK-8223240 and JDK-8222859, so maybe we wait for them...)

Roman


# HG changeset patch
# User rkennke
# Date 1558026451 -7200
#      Thu May 16 19:07:31 2019 +0200
# Node ID a2f8baebe8ce4254881fdb53c4ddffe5bed9b3b1
# Parent  649b5a98e4138a1e4e066579f4c89fa7dce15b1c
[backport] 8224043: Shenandoah: Remove clear_claimed_marks() from start
of concurrent_traversal()
Reviewed-by: shade

diff -r 649b5a98e413 -r a2f8baebe8ce
src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp	Fri May
10 01:41:45 2019 +0800
+++ b/src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp	Thu May
16 19:07:31 2019 +0200
@@ -564,8 +564,6 @@
 }

 void ShenandoahTraversalGC::concurrent_traversal_collection() {
-  ClassLoaderDataGraph::clear_claimed_marks();
-
   ShenandoahGCPhase phase_work(ShenandoahPhaseTimings::conc_traversal);
   if (!_heap->cancelled_gc()) {
     uint nworkers = _heap->workers()->active_workers();


From shade at redhat.com  Fri May 17 07:52:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 09:52:45 +0200
Subject: RFR (sh/jdk11): [backport] 8224043: Shenandoah: Remove
 clear_claimed_marks() from start of concurrent_traversal()
In-Reply-To: <8654a372-0e1a-cb99-aafe-4ff8597be33a@redhat.com>
References: <8654a372-0e1a-cb99-aafe-4ff8597be33a@redhat.com>
Message-ID: <681059c1-6682-d696-c877-956e0a95eea6@redhat.com>

On 5/16/19 10:32 PM, Roman Kennke wrote:
> Let's backport today's change to remove clear_claimed_marks() to jdk11.
> 
> Testing: hotspot_gc_shenandoah and some point-testing specjvm
> 
> Ok?

OK.

-Aleksey


From rkennke at redhat.com  Fri May 17 08:03:01 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Fri, 17 May 2019 08:03:01 +0000
Subject: hg: shenandoah/jdk11: [backport] 8224043: Shenandoah: Remove
 clear_claimed_marks() from start of concurrent_traversal()
Message-ID: <201905170803.x4H832UW018152@aojmv0008.oracle.com>

Changeset: a2f8baebe8ce
Author:    rkennke
Date:      2019-05-16 19:07 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a2f8baebe8ce

[backport] 8224043: Shenandoah: Remove clear_claimed_marks() from start of concurrent_traversal()
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp


From boris.ulasevich at bell-sw.com  Fri May 17 08:05:24 2019
From: boris.ulasevich at bell-sw.com (Boris Ulasevich)
Date: Fri, 17 May 2019 11:05:24 +0300
Subject: RFR: 8223767: Shenandoah fails to build on Solaris x86_64
In-Reply-To: <27b5d599-b25f-073d-0609-1c84c2433d1d@redhat.com>
References: <eab379e5-7fdc-75ca-feb3-f8f9ac6e7448@bell-sw.com>
 <87dcfaac-f351-b8d5-ba30-4029124e33f6@redhat.com>
 <3387252d-af57-0f52-5219-98abccdf810b@bell-sw.com>
 <ca8966ac-5a9f-7cde-3463-91ea633c22c0@redhat.com>
 <55bb8152-3ec6-dcc0-65fe-3b7efd0b7919@bell-sw.com>
 <596a0613-97f1-5673-01c9-06f63f8edbcb@redhat.com>
 <9f832ee6-2f06-d29f-807b-125e1f853646@redhat.com>
 <27b5d599-b25f-073d-0609-1c84c2433d1d@redhat.com>
Message-ID: <9fcac029-e789-dc33-b58f-365e4084b7da@bell-sw.com>

Thank you!

On 16.05.2019 21:00, Aleksey Shipilev wrote:
> On 5/16/19 6:53 PM, Aleksey Shipilev wrote:
>> On 5/16/19 5:43 PM, Roman Kennke wrote:
>>>> What is the correct backport procedure?
>>>
>>> I think for the Shenandoah parts it's fine to post them here for review,
>>> and one of us can integrate them to shenandoah/jdk11 and shenandoah/jdk8
>>> for you. Please prepare the changesets with prefixed [backport] in the
>>> commit msg, e.g.:
>>>
>>> [backport] 8223767: Shenandoah fails to build on Solaris x86_64
>>
>> I can do this myself while sponsoring fixes for Boris. Thanks for the backport!
> 
> There:
>    http://hg.openjdk.java.net/shenandoah/jdk11/rev/159ea4412948
>    http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/468dd92b90f9
> 
> Pushed them with "author" set to "bulasevich" to give credit.
> 
> -Aleksey
> 

From shade at redhat.com  Fri May 17 11:22:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 13:22:40 +0200
Subject: [8u] RFR/RFC: Bulk backports to sh/jdk8
Message-ID: <e31e8553-a81b-5910-a670-69ed3079ef02@redhat.com>

http://cr.openjdk.java.net/~shade/shenandoah/backports/jdk8u-20190517/webrev.01/

This bunch includes:

 [backport] 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
 [backport] 8223446: Shenandoah breaks alignment with some HumongousThreshold values
 [backport] 8223759: Shenandoah should allow arbitrarily low initial heap size
 [backport] 8223762: Shenandoah: overflows in calculations involving heap capacity
 [backport] 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
 [backport] 8223651: Build fails with --with-jvm-features=-jfr and --disable-precompiled-headers

It does require usual polishing for 8u: reshuffles, asserts with err_msgs, oopDesc::equals_unsafe,
missing align_*, etc.

Testing: Linux x86_64 hotspot_gc_shenandoah {fastdebug, release}

-- 
Thanks,
-Aleksey



From rkennke at redhat.com  Fri May 17 11:41:40 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 13:41:40 +0200
Subject: [8u] RFR/RFC: Bulk backports to sh/jdk8
In-Reply-To: <e31e8553-a81b-5910-a670-69ed3079ef02@redhat.com>
References: <e31e8553-a81b-5910-a670-69ed3079ef02@redhat.com>
Message-ID: <98f811e4-6ffd-5660-5c0c-a10afb03e4fb@redhat.com>

Looks good! Thanks!

Roman

> http://cr.openjdk.java.net/~shade/shenandoah/backports/jdk8u-20190517/webrev.01/
> 
> This bunch includes:
> 
>  [backport] 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
>  [backport] 8223446: Shenandoah breaks alignment with some HumongousThreshold values
>  [backport] 8223759: Shenandoah should allow arbitrarily low initial heap size
>  [backport] 8223762: Shenandoah: overflows in calculations involving heap capacity
>  [backport] 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
>  [backport] 8223651: Build fails with --with-jvm-features=-jfr and --disable-precompiled-headers
> 
> It does require usual polishing for 8u: reshuffles, asserts with err_msgs, oopDesc::equals_unsafe,
> missing align_*, etc.
> 
> Testing: Linux x86_64 hotspot_gc_shenandoah {fastdebug, release}
> 


From shade at redhat.com  Fri May 17 11:43:46 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 17 May 2019 11:43:46 +0000
Subject: hg: shenandoah/jdk8/hotspot: 6 new changesets
Message-ID: <201905171143.x4HBhkCG001857@aojmv0008.oracle.com>

Changeset: c97a6ff02c31
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/c97a6ff02c31

[backport] 8223447: Stabilize gc/shenandoah/TestStringDedupStress test
Reviewed-by: rkennke

! test/gc/shenandoah/TestStringDedupStress.java

Changeset: 642a909a1659
Author:    shade
Date:      2019-05-07 21:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/642a909a1659

[backport] 8223446: Shenandoah breaks alignment with some HumongousThreshold values
Reviewed-by: rkennke

! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.inline.hpp
! test/gc/shenandoah/TestHumongousThreshold.java

Changeset: 2c2c36c22485
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/2c2c36c22485

[backport] 8223759: Shenandoah should allow arbitrarily low initial heap size
Reviewed-by: rkennke

! src/share/vm/gc_implementation/shenandoah/shenandoahCollectorPolicy.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.hpp
! test/gc/shenandoah/options/TestRegionSizeArgs.java

Changeset: 9e62225104d0
Author:    shade
Date:      2019-05-14 09:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/9e62225104d0

[backport] 8223762: Shenandoah: overflows in calculations involving heap capacity
Reviewed-by: rkennke

! src/share/vm/gc_implementation/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp
! src/share/vm/gc_implementation/shenandoah/heuristics/shenandoahCompactHeuristics.cpp
! src/share/vm/gc_implementation/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp
! src/share/vm/gc_implementation/shenandoah/heuristics/shenandoahStaticHeuristics.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahPacer.cpp

Changeset: 85148fc38c06
Author:    shade
Date:      2019-05-15 22:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/85148fc38c06

[backport] 8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
Reviewed-by: rkennke

! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp
! src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: e98f7c348290
Author:    aoqi
Date:      2019-05-10 01:41 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/e98f7c348290

[backport] 8223651: Build fails with --with-jvm-features=-jfr and --disable-precompiled-headers
Reviewed-by: shade
Contributed-by: Wang Haomin <wanghaomin at loongson.cn>

! src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.cpp


From shade at redhat.com  Fri May 17 11:59:34 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 13:59:34 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <60b7f75e-b8ec-7122-4e39-f7dca14a2ea8@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
 <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
 <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>
 <60b7f75e-b8ec-7122-4e39-f7dca14a2ea8@redhat.com>
Message-ID: <d1629ddd-5342-2f25-714a-ce7839fb4bf6@redhat.com>

On 5/16/19 5:09 PM, Zhengyu Gu wrote:
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.02/

I like it.

*) No, this block should be in ShenandoahTraversalGC*Heuristics*, not in ShenandoahTraversalGC
itself, look:
http://hg.openjdk.java.net/jdk/jdk/file/23837d614c17/src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp#l36

 313   // Traversal does not support concurrent code root scanning
 314   FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);

*) One more naming suggestion (see if it makes sense!). Current hierarchy is:

 ShenandoahRootProcessingPhase
   -> ShenandoahRootProcessor
   -> ShenandoahRootEvacuator
   -> ShenandoahRootUpdater
   -> ShenandoahRootAdjuster

It leads to awkward superclass name. Maybe we should rename ShenandoahRootProcessor to reflect what
it does to also match Evacuator/Updater/Adjuster? This frees ShenandoahRootProcessor to become the
superclass. For example:

 ShenandoahRootProcessor
   -> ShenandoahRootScanner [Does it *only* scan, though? Dunno.]
   -> ShenandoahRootEvacuator
   -> ShenandoahRootUpdater
   -> ShenandoahRootAdjuster

-Aleksey



From zgu at redhat.com  Fri May 17 12:15:21 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 17 May 2019 08:15:21 -0400
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <d1629ddd-5342-2f25-714a-ce7839fb4bf6@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
 <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
 <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>
 <60b7f75e-b8ec-7122-4e39-f7dca14a2ea8@redhat.com>
 <d1629ddd-5342-2f25-714a-ce7839fb4bf6@redhat.com>
Message-ID: <c863714b-fc44-6b95-53b3-8eb17614cc96@redhat.com>



On 5/17/19 7:59 AM, Aleksey Shipilev wrote:
> On 5/16/19 5:09 PM, Zhengyu Gu wrote:
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.02/
> 
> I like it.
> 
> *) No, this block should be in ShenandoahTraversalGC*Heuristics*, not in ShenandoahTraversalGC
> itself, look:
> http://hg.openjdk.java.net/jdk/jdk/file/23837d614c17/src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp#l36
> 
>   313   // Traversal does not support concurrent code root scanning
>   314   FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
> 
> *) One more naming suggestion (see if it makes sense!). Current hierarchy is:
> 
>   ShenandoahRootProcessingPhase
>     -> ShenandoahRootProcessor
>     -> ShenandoahRootEvacuator
>     -> ShenandoahRootUpdater
>     -> ShenandoahRootAdjuster
> 
> It leads to awkward superclass name. Maybe we should rename ShenandoahRootProcessor to reflect what
> it does to also match Evacuator/Updater/Adjuster? This frees ShenandoahRootProcessor to become the
> superclass. For example:
> 
>   ShenandoahRootProcessor
>     -> ShenandoahRootScanner [Does it *only* scan, though? Dunno.]
>     -> ShenandoahRootEvacuator
>     -> ShenandoahRootUpdater
>     -> ShenandoahRootAdjuster
Was in my mind too, too lazy to rename :-( will do before push.

Thanks,

-Zhengyu

> 
> -Aleksey
> 
> 

From rkennke at redhat.com  Fri May 17 12:29:18 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 14:29:18 +0200
Subject: RFR (jdk8): Backport weakroots stuff to sh/jdk8
Message-ID: <f7b672f7-06b2-2f3b-1f35-51c43fc87fb2@redhat.com>

This backports the following two changes from sh/jdk11 -> sh/jdk8:

49: JDK-8221435: Shenandoah should not mark through weak roots
49: JDK-8221629: Shenandoah: Cleanup class unloading logic


This is a bit risky and complicated. I added a compat class in
shenandoahWeakProcessor.hpp/cpp which is basically the same (with minor
removals) as jdk11's weakProcessor.hpp/cpp.

Other than that, the weakroots-handling in systemDictionary is a bit
different and more messy than in jdk11, which is why I moved those bits
into process_strong_roots() (only scans strong sys-dict roots) and
process_weak_roots (scans both strong+weak sys-dict roots). This keeps
the interfaces the same as in jdk11 and 13 and does the right thing.
Unfortunately, we can't drive the strong and weak sys-dict roots
separately as it's done in jdk11 and upwards.

The stringdedup stuff is also different. I believe I got it right, as
much as it is possible.

Testing: hotspot_gc_shenandoah looks good. Some point testing in specjvm
did not show up any problems. We want to test this thouroughly in our CI
before shipping it anywhere.

http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-17-1/webrev.00/

Ok to go?

Roman


From rkennke at redhat.com  Fri May 17 12:33:46 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 14:33:46 +0200
Subject: RFR 8223774: Shenandoah: Refactor ShenandoahRootProcessor and
 family
In-Reply-To: <c863714b-fc44-6b95-53b3-8eb17614cc96@redhat.com>
References: <b31ec2f8-5c1b-25de-dd3d-4d88755e8a11@redhat.com>
 <f55171cf-1ebc-a787-7485-03dbed5f5267@redhat.com>
 <451b6348-8c37-9a46-31d3-6f6ea960de4a@redhat.com>
 <57c55b42-c03e-2649-e8c5-37a9101e93a1@redhat.com>
 <102078db-5b2b-804b-556c-b8114bd40bff@redhat.com>
 <83d496a1-c767-755e-13af-46ee4102dc97@redhat.com>
 <60b7f75e-b8ec-7122-4e39-f7dca14a2ea8@redhat.com>
 <d1629ddd-5342-2f25-714a-ce7839fb4bf6@redhat.com>
 <c863714b-fc44-6b95-53b3-8eb17614cc96@redhat.com>
Message-ID: <37c69240-f89c-42f3-9ed7-d835c5b6f0be@redhat.com>

>>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8223774/webrev.02/

Looks good (with Aleksey's suggestion).

Thanks & cheers,
Roman

>>
>> I like it.
>>
>> *) No, this block should be in ShenandoahTraversalGC*Heuristics*, not
>> in ShenandoahTraversalGC
>> itself, look:
>> http://hg.openjdk.java.net/jdk/jdk/file/23837d614c17/src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp#l36
>>
>>
>> ? 313?? // Traversal does not support concurrent code root scanning
>> ? 314?? FLAG_SET_DEFAULT(ShenandoahConcurrentScanCodeRoots, false);
>>
>> *) One more naming suggestion (see if it makes sense!). Current
>> hierarchy is:
>>
>> ? ShenandoahRootProcessingPhase
>> ??? -> ShenandoahRootProcessor
>> ??? -> ShenandoahRootEvacuator
>> ??? -> ShenandoahRootUpdater
>> ??? -> ShenandoahRootAdjuster
>>
>> It leads to awkward superclass name. Maybe we should rename
>> ShenandoahRootProcessor to reflect what
>> it does to also match Evacuator/Updater/Adjuster? This frees
>> ShenandoahRootProcessor to become the
>> superclass. For example:
>>
>> ? ShenandoahRootProcessor
>> ??? -> ShenandoahRootScanner [Does it *only* scan, though? Dunno.]
>> ??? -> ShenandoahRootEvacuator
>> ??? -> ShenandoahRootUpdater
>> ??? -> ShenandoahRootAdjuster
> Was in my mind too, too lazy to rename :-( will do before push.
> 
> Thanks,
> 
> -Zhengyu
> 
>>
>> -Aleksey
>>
>>


From shade at redhat.com  Fri May 17 14:12:33 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 16:12:33 +0200
Subject: RFR(S) 8223951: Shenandoah: Only need to update thread roots
 during final update refs
In-Reply-To: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>
References: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>
Message-ID: <cebbc94a-70f1-0282-b2e3-d55b40e33940@redhat.com>

On 5/16/19 4:25 PM, Zhengyu Gu wrote:
> After switching to strong to-space invariant and pre-evacuating all root, thread roots are only
> places that may contain to-space oops after updating references during normal concurrent cycles, we
> only need to update them during final updaterefs pause, which should reduce pause time.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223951
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223951/webrev.00/

Looks fine to me.

Aside: I wonder how would be get the thread root with from-space ptr if we don't have safepoints
between loads and the LRBs that give us to-space ptrs after potential evac.

-Aleksey


From rkennke at redhat.com  Fri May 17 14:17:51 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 16:17:51 +0200
Subject: RFR(S) 8223951: Shenandoah: Only need to update thread roots
 during final update refs
In-Reply-To: <cebbc94a-70f1-0282-b2e3-d55b40e33940@redhat.com>
References: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>
 <cebbc94a-70f1-0282-b2e3-d55b40e33940@redhat.com>
Message-ID: <9ff8320d-8750-1ce0-9130-207e4d49c617@redhat.com>

>> After switching to strong to-space invariant and pre-evacuating all root, thread roots are only
>> places that may contain to-space oops after updating references during normal concurrent cycles, we
>> only need to update them during final updaterefs pause, which should reduce pause time.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223951
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223951/webrev.00/
> 
> Looks fine to me.
> 
> Aside: I wonder how would be get the thread root with from-space ptr if we don't have safepoints
> between loads and the LRBs that give us to-space ptrs after potential evac.

I don't think we cann guarantee that we don't get a safepoint between
load and LRB.

Roman



From shade at redhat.com  Fri May 17 14:20:25 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 16:20:25 +0200
Subject: RFR(S) 8223951: Shenandoah: Only need to update thread roots
 during final update refs
In-Reply-To: <9ff8320d-8750-1ce0-9130-207e4d49c617@redhat.com>
References: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>
 <cebbc94a-70f1-0282-b2e3-d55b40e33940@redhat.com>
 <9ff8320d-8750-1ce0-9130-207e4d49c617@redhat.com>
Message-ID: <52d5756d-eb04-1dc1-45ca-d669045d6370@redhat.com>

On 5/17/19 4:17 PM, Roman Kennke wrote:
>>> After switching to strong to-space invariant and pre-evacuating all root, thread roots are only
>>> places that may contain to-space oops after updating references during normal concurrent cycles, we
>>> only need to update them during final updaterefs pause, which should reduce pause time.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223951
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223951/webrev.00/
>>
>> Looks fine to me.
>>
>> Aside: I wonder how would be get the thread root with from-space ptr if we don't have safepoints
>> between loads and the LRBs that give us to-space ptrs after potential evac.
> 
> I don't think we cann guarantee that we don't get a safepoint between
> load and LRB.

Ah, that sucks. Oh well! But that is the only plausible way we can get the non-updated thread root,
right?

-Aleksey


From rkennke at redhat.com  Fri May 17 14:55:49 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 16:55:49 +0200
Subject: RFR(S) 8223951: Shenandoah: Only need to update thread roots
 during final update refs
In-Reply-To: <52d5756d-eb04-1dc1-45ca-d669045d6370@redhat.com>
References: <52773c59-62fc-d763-0e9d-b79131eeba19@redhat.com>
 <cebbc94a-70f1-0282-b2e3-d55b40e33940@redhat.com>
 <9ff8320d-8750-1ce0-9130-207e4d49c617@redhat.com>
 <52d5756d-eb04-1dc1-45ca-d669045d6370@redhat.com>
Message-ID: <9c44bd43-92a0-d81b-ea4d-6fca1ee91727@redhat.com>

>>>> After switching to strong to-space invariant and pre-evacuating all root, thread roots are only
>>>> places that may contain to-space oops after updating references during normal concurrent cycles, we
>>>> only need to update them during final updaterefs pause, which should reduce pause time.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223951
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8223951/webrev.00/
>>>
>>> Looks fine to me.
>>>
>>> Aside: I wonder how would be get the thread root with from-space ptr if we don't have safepoints
>>> between loads and the LRBs that give us to-space ptrs after potential evac.
>>
>> I don't think we cann guarantee that we don't get a safepoint between
>> load and LRB.
> 
> Ah, that sucks. Oh well!

Positively speaking: it allows C2 more freedom and move barriers across
safepoints :-) OTOH, with LRB it probably doesn't matter that much. We
may actually attempt to prevent it and save this extra pass. It may not
actually be very difficult: wire up current ctrl in ShLoadBarrierNode
instead of NULL. Knowing C2 I can see all hell break loose though... ;-)

> But that is the only plausible way we can get the non-updated thread root,
> right?

Well, yeah. I think/hope so ;-)

Roman


From gnu.andrew at redhat.com  Fri May 17 15:03:34 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Fri, 17 May 2019 16:03:34 +0100
Subject: [RFR] [8u] 8u222-b02 Upstream Sync
In-Reply-To: <4c0b9bf8-2ee0-9775-2483-0179814db17e@redhat.com>
References: <c8f06a86-3738-4b8b-2b7e-9e3a31d64bea@redhat.com>
 <501d0fdd-82ea-f694-8785-ee7ac74f8b29@redhat.com>
 <4c0b9bf8-2ee0-9775-2483-0179814db17e@redhat.com>
Message-ID: <413da0e7-b02d-e331-7f11-28df749e3df2@redhat.com>



On 14/05/2019 16:10, Aleksey Shipilev wrote:
> On 5/14/19 4:55 PM, Aleksey Shipilev wrote:
>> hotspot:
>>
>> *) sharedRuntime_aarch64.cpp, templateInterpreter_aarch64.cpp, macroAssembler_x86.cpp,
>> jniHandles.cpp: new G1 blocks have to handle Shenandoah too. Luckily, we have this done in sh/jdk9
>> (archived), and it could be just picked up from there:
>>
>> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp#l2067
>> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/aarch64/vm/templateInterpreterGenerator_aarch64.cpp#l1419
>> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/cpu/x86/vm/macroAssembler_x86.cpp#l5272
>> http://hg.openjdk.java.net/shenandoah/jdk9/hotspot/file/37b802a7a71b/src/share/vm/runtime/jniHandles.cpp#l118
>>
>> Otherwise looks okay.
> 
> I now remember another thing. The absence of Shenandoah additions in those blocks probably do not
> crash the VM yet, because we have the Shenandoah-specific workaround for it:
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/119e9a5b24d5
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/d305c31da9f5
> 
> Merge is not the proper place to remove that workaround. Maybe we just push this merge verbatim, and
> then we would do downstream work to remove the workaround and fix the issue properly with the
> changes above, then integrate it back wholesale.
> 
> -Aleksey
> 

I concur that a merge is not the proper place to fix this. Indeed, this
is why I included the AArch64 code for 8176100 as a separate changeset,
and not as part of the merge changeset.

I only tend to include additions to a merge changeset where it is
necessary to complete a product build on my development platform
(x86_64). I wouldn't expect that to break as x86_64 is supported in
upstream. It's expected that a merge may break for AArch64 & Shenandoah
as these are not considered upstream, and I think it adds clarity if the
necessary fixes are included as changesets in their own right.

I've pushed the merge. It'd be good if you could follow with the fixes
ASAP, so I can include them in testing of b03.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Fri May 17 15:14:28 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 17 May 2019 15:14:28 +0000
Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.4+2 for changeset
 3908850f5027
Message-ID: <201905171514.x4HFETDZ013400@aojmv0008.oracle.com>

Changeset: a868ba03fd3d
Author:    shade
Date:      2019-05-17 17:14 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a868ba03fd3d

Added tag shenandoah-jdk-11.0.4+2 for changeset 3908850f5027

! .hgtags


From rwestrel at redhat.com  Fri May 17 15:44:50 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Fri, 17 May 2019 17:44:50 +0200
Subject: RFR: C2 reloads oop from memory in the middle of the LRB
Message-ID: <87k1epkrv1.fsf@redhat.com>


http://cr.openjdk.java.net/~roland/shenandoah/nofwdptr-matcher-fix/webrev.00/

The matcher must find Nodes that must be emitted only once such as a
field/array Load. It does that by finding shared nodes (nodes with
multiple uses). With compressed oops, the actual pattern for an oop load
is (DecodeN (LoadN )) so the Load is not shared but the DecodeN
is. There is code to deal with that:

        if( mop == Op_AddP && m->in(AddPNode::Base)->is_DecodeNarrowPtr()) {
          // Bases used in addresses must be shared but since
          // they are shared through a DecodeN they may appear
          // to have a single use so force sharing here.
          set_shared(m->in(AddPNode::Base)->in(1));
        }

But with the load of the mark work, offset is null so there's not AddP
and that logic doesn't work.

Roland.

From shade at redhat.com  Fri May 17 15:47:21 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 17:47:21 +0200
Subject: RFR: C2 reloads oop from memory in the middle of the LRB
In-Reply-To: <87k1epkrv1.fsf@redhat.com>
References: <87k1epkrv1.fsf@redhat.com>
Message-ID: <a392e156-f017-2ac7-2a15-6883399271c3@redhat.com>

On 5/17/19 5:44 PM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/shenandoah/nofwdptr-matcher-fix/webrev.00/

Yes, cool; let's have it in sh/jdk for weekend testing.

-Aleksey


From rkennke at redhat.com  Fri May 17 15:49:05 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 17:49:05 +0200
Subject: RFR: C2 reloads oop from memory in the middle of the LRB
In-Reply-To: <87k1epkrv1.fsf@redhat.com>
References: <87k1epkrv1.fsf@redhat.com>
Message-ID: <8cc7908b-d806-6ee1-204c-264144ea1165@redhat.com>

I've run the patch against the failing test, and it's good now. I've
also run hotspot_gc_shenandoah and it's good. Go!

Thank you!!
Roman


> 
> http://cr.openjdk.java.net/~roland/shenandoah/nofwdptr-matcher-fix/webrev.00/
> 
> The matcher must find Nodes that must be emitted only once such as a
> field/array Load. It does that by finding shared nodes (nodes with
> multiple uses). With compressed oops, the actual pattern for an oop load
> is (DecodeN (LoadN )) so the Load is not shared but the DecodeN
> is. There is code to deal with that:
> 
>         if( mop == Op_AddP && m->in(AddPNode::Base)->is_DecodeNarrowPtr()) {
>           // Bases used in addresses must be shared but since
>           // they are shared through a DecodeN they may appear
>           // to have a single use so force sharing here.
>           set_shared(m->in(AddPNode::Base)->in(1));
>         }
> 
> But with the load of the mark work, offset is null so there's not AddP
> and that logic doesn't work.
> 
> Roland.
> 


From rwestrel at redhat.com  Fri May 17 15:49:15 2019
From: rwestrel at redhat.com (rwestrel at redhat.com)
Date: Fri, 17 May 2019 15:49:15 +0000
Subject: hg: shenandoah/jdk: no fwd ptr matcher fix
Message-ID: <201905171549.x4HFnF3F005713@aojmv0008.oracle.com>

Changeset: bf5886740a30
Author:    roland
Date:      2019-05-17 17:39 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bf5886740a30

no fwd ptr matcher fix

! src/hotspot/share/opto/matcher.cpp


From zgu at redhat.com  Fri May 17 15:57:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Fri, 17 May 2019 11:57:47 -0400
Subject: RFR(M) 8224115: Shenandoah: Eliminate RWLock that protects recorded
 nmethod data array
Message-ID: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>

I would like to eliminate RWLock that used to protect recorded nmethod 
data array in ShenandoahCodeRoots, because the methods that update the 
array, are already guarded by CodeCache_lock.

The patch also helps concurrent class unloading work, by avoiding two 
lock dances, which are deadlock prone.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224115
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From kdobson at redhat.com  Fri May 17 16:01:33 2019
From: kdobson at redhat.com (Ken Dobson)
Date: Fri, 17 May 2019 12:01:33 -0400
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
 <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
Message-ID: <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>

Hi all,

I've now received review from the hotspot-jfr-dev list and the patch has
been updated with tests and is now good to go.

Here is the final patch:
http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests/webrev/

Would someone here be able to sponsor it?

Thanks,

Ken Dobson

On Fri, May 3, 2019 at 6:07 AM Aleksey Shipilev <shade at redhat.com> wrote:

> On 5/2/19 9:31 PM, Ken Dobson wrote:
> > Thank you for your review Aleksey, I've removed the trailing whitespaces
> here.
> >
> > http://cr.openjdk.java.net/~kdobson/53476/webrev
> >
> > What are my next steps, should I send an exported patch to a committer?
>
> The code touches shared JFR parts. Have you got the acknowledgment from
> JFR people? You have to list
> who had reviewed the patch. If everything is in order there, one of us
> (Shenandoah devs) can push.
>
> -Aleksey
>
>

From rkennke at redhat.com  Fri May 17 16:05:23 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 18:05:23 +0200
Subject: RFR (8): [backport]: 8221751: Shenandoah: Improve SATB enqueueing
Message-ID: <557f433c-88bc-ce3a-925f-c43edbd684f9@redhat.com>

Another rather nasty backport.

Original JDK11 change:
https://hg.openjdk.java.net/shenandoah/jdk11/rev/0d5e66cf201a
Backport:
http://cr.openjdk.java.net/~rkennke/backport-jdk8-JDK-8221751/webrev.00/

It's nasty for two reasons:

1. We have no GC interface for the arraycopy stuff. The next best thing
is to splice the implementation, and backport the jdk11
arraycopy_prologue() stuff into the switch, under a separate branch for
Shenandoah.
2. We have no single-loop arraycopy in shenandoahBarrierSet. Ok, that's
actually not nasty, because we can just drop that part. But I needed to
add some checks in the other paths that lead to arraycopy pre-barriers
in runtime.

Testing: hotspot_gc_shenandoah on x86_64 and aarch64 (there is no _32
bit impl, but should be easy to deduce from the jdk11 mixed impl soon),
point testing specjvm.

Ok?

Roman


From shade at redhat.com  Fri May 17 16:18:36 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 17 May 2019 18:18:36 +0200
Subject: RFC: Pick up 11.0.4+3 to sh/jdk11
Message-ID: <f92cdec7-cbe5-bc1e-6a2b-3a0460cbda30@redhat.com>

Incoming changes:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b3/changesets.txt

Merges are all trivial.

Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Fri May 17 16:39:31 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 17 May 2019 18:39:31 +0200
Subject: RFC: Pick up 11.0.4+3 to sh/jdk11
In-Reply-To: <f92cdec7-cbe5-bc1e-6a2b-3a0460cbda30@redhat.com>
References: <f92cdec7-cbe5-bc1e-6a2b-3a0460cbda30@redhat.com>
Message-ID: <2f21ad09-5775-f0d0-8dce-5952ccbe9832@redhat.com>

Ok, do it!

Thanks,
Roman

> Incoming changes:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b3/changesets.txt
> 
> Merges are all trivial.
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 


From shade at redhat.com  Fri May 17 16:42:43 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 17 May 2019 16:42:43 +0000
Subject: hg: shenandoah/jdk11: 19 new changesets
Message-ID: <201905171642.x4HGgjuw015701@aojmv0008.oracle.com>

Changeset: 5083d3d15b64
Author:    dl
Date:      2019-05-02 06:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5083d3d15b64

8222930: ConcurrentSkipListMap.clone() shares size variable between original and clone
Reviewed-by: martin, smarks
Contributed-by: Adam Farley8 <adam.farley at uk.ibm.com>, Martin Buchholz <martinrb at google.com>

! src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
! test/jdk/java/util/concurrent/tck/MapTest.java

Changeset: 93a1eb47888b
Author:    bae
Date:      2018-11-30 23:21 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/93a1eb47888b

8139178: Wrong fontMetrics when printing in Landscape (OpenJDK)
Reviewed-by: prr

! src/java.desktop/share/native/libfontmanager/freetypeScaler.c
+ test/jdk/java/awt/font/Rotate/RotatedFontMetricsTest.java

Changeset: 7dfdc7743c54
Author:    rhalade
Date:      2019-04-30 12:53 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7dfdc7743c54

8222137: Remove T-Systems root CA certificate
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 02a9a702a3cc
Author:    ysuenaga
Date:      2019-04-24 17:09 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/02a9a702a3cc

8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun

! src/hotspot/share/jfr/periodic/sampling/jfrCallTrace.cpp
! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp
! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp
! src/hotspot/share/jfr/utilities/jfrTypes.hpp

Changeset: 3e04374c6b3b
Author:    goetz
Date:      2019-05-08 07:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3e04374c6b3b

Merge


Changeset: 0dd2a97a6d9c
Author:    jlahoda
Date:      2019-04-30 10:39 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/0dd2a97a6d9c

8218152: [javac] fails and exits with no error if a bad annotation processor provided
Summary: Handle exceptions thrown while loading annotation processors.
Reviewed-by: jlahoda
Contributed-by: groeges at uk.ibm.com

! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/langtools/tools/javac/annotations/8218152/MalformedAnnotationProcessorTests.java
! test/langtools/tools/javac/diags/examples.not-yet.txt

Changeset: a132e94a5334
Author:    kaddepalli
Date:      2019-05-13 07:44 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a132e94a5334

8218674: HTML Tooltip with "img=src" on component doesn't show
Summary: Make sure image is scaled appropriately if synchronous loading flag is set.
Reviewed-by: serb, psadhukhan

! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java
+ test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java
+ test/jdk/javax/swing/text/html/8218674/circle.png

Changeset: a4b23b6e8914
Author:    redestad
Date:      2019-04-24 15:37 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a4b23b6e8914

8222532: (zipfs) Performance regression when writing ZipFileSystem entries in parallel
Reviewed-by: lancea, clanger, alanb

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipPath.java

Changeset: e61acffc0b16
Author:    clanger
Date:      2019-05-10 06:31 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e61acffc0b16

8223555: Cleanups in cacerts tests
Reviewed-by: xuelei

! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: a267d045754a
Author:    prr
Date:      2019-03-01 16:59 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a267d045754a

8210782: Upgrade HarfBuzz to the latest 2.3.1
Reviewed-by: serb, ihse, erikj

! make/lib/Awt2dLibraries.gmk
! src/java.desktop/share/legal/harfbuzz.md
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-fdsc-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-ankr-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-bsln-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-feat-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-just-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-kerx-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-lcar-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-morx-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-trak-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-ltag-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-array.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-json.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-text.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-cs-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-dict-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff1-interp-cs.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff2-interp-cs.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.h
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-deprecated.h
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-fallback-shape.cc
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-iter.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-kern.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-machinery.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-null.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cbdt-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-colr-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cpal-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-sbix-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-svg-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-deprecated.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-gasp-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-glyf-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hdmx-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-head-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hhea-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-base-table.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-jstf-table.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-maxp-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.h
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-unicode-ranges.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-macroman.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-win1256.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-default.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hangul.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-machine.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-thai.cc
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-stat-table.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-vorg-table.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot.h
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.cc
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-list.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-static.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.cc
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-emoji-table.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf.hh
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb-vector.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-warning.cc
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb.h
+ src/java.desktop/share/native/libfontmanager/harfbuzz/hb.hh
! src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc

Changeset: 89bfcd380e1a
Author:    prr
Date:      2018-10-31 16:58 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/89bfcd380e1a

8210863: Remove Xrandr include files from JDK sources
Reviewed-by: serb

- src/java.desktop/unix/native/libawt_xawt/awt/Xrandr.h
! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c
- src/java.desktop/unix/native/libawt_xawt/awt/randr.h

Changeset: e3cd6d9d43e2
Author:    simonis
Date:      2018-11-22 09:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e3cd6d9d43e2

8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it
Reviewed-by: shade, erikj, stuefe, ihse, goetz

! make/autoconf/help.m4
! make/autoconf/lib-x11.m4
! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c

Changeset: 931d7abed2c0
Author:    sveerabhadra
Date:      2019-02-25 11:02 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/931d7abed2c0

8212202: [Windows] Exception if no printers are installed.
Reviewed-by: prr

! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
! src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp
! test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java

Changeset: da1735dc082e
Author:    aivanov
Date:      2019-03-28 14:52 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/da1735dc082e

8221412: lookupPrintServices() does not always update the list of Windows remote printers
Reviewed-by: prr, serb

! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
! src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp

Changeset: a5c7c4a6df59
Author:    serb
Date:      2019-03-31 16:57 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a5c7c4a6df59

8220495: Update GIFlib library to the 5.1.8
Reviewed-by: prr

! src/java.desktop/share/legal/giflib.md
! src/java.desktop/share/native/libsplashscreen/giflib/dgif_lib.c
! src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h
! src/java.desktop/share/native/libsplashscreen/giflib/gif_lib.h
! src/java.desktop/share/native/libsplashscreen/giflib/gif_lib_private.h
! src/java.desktop/share/native/libsplashscreen/giflib/gifalloc.c
! src/java.desktop/share/native/libsplashscreen/giflib/openbsd-reallocarray.c

Changeset: dfe11b9e6f1f
Author:    prr
Date:      2018-10-31 11:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/dfe11b9e6f1f

8210886: Remove references in xwindows.md to non-existent files.
Reviewed-by: serb, dmarkov

! src/java.desktop/unix/legal/xwindows.md

Changeset: 3b6fc7cd5946
Author:    dcherepanov
Date:      2019-03-27 13:14 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3b6fc7cd5946

8221244: Unexpected behavior of PropertyDescription.getReadMethod for boolean properties
Reviewed-by: serb

! src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java
+ test/jdk/java/beans/Introspector/Test8221244.java

Changeset: e321dd1f202a
Author:    goetz
Date:      2019-05-15 09:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e321dd1f202a

Added tag jdk-11.0.4+3 for changeset 3b6fc7cd5946

! .hgtags

Changeset: 403b6dbf9f7e
Author:    shade
Date:      2019-05-17 18:14 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/403b6dbf9f7e

Merge

! .hgtags
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh
- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh
- src/java.desktop/unix/native/libawt_xawt/awt/Xrandr.h
- src/java.desktop/unix/native/libawt_xawt/awt/randr.h


From kdobson at redhat.com  Fri May 17 20:29:00 2019
From: kdobson at redhat.com (Ken Dobson)
Date: Fri, 17 May 2019 16:29:00 -0400
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
 <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
 <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>
Message-ID: <CADPaBqnGZe2CWPgME_Q1uBD2uun6jTctPDm3s6WQ2BxNPR9xjQ@mail.gmail.com>

Apologies there was one tiny typo in a String that is now fixed here:
http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests1/webrev

Thanks,

Ken Dobson

On Fri, May 17, 2019 at 12:01 PM Ken Dobson <kdobson at redhat.com> wrote:

> Hi all,
>
> I've now received review from the hotspot-jfr-dev list and the patch has
> been updated with tests and is now good to go.
>
> Here is the final patch:
> http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests/webrev/
>
> Would someone here be able to sponsor it?
>
> Thanks,
>
> Ken Dobson
>
> On Fri, May 3, 2019 at 6:07 AM Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 5/2/19 9:31 PM, Ken Dobson wrote:
>> > Thank you for your review Aleksey, I've removed the trailing
>> whitespaces here.
>> >
>> > http://cr.openjdk.java.net/~kdobson/53476/webrev
>> >
>> > What are my next steps, should I send an exported patch to a committer?
>>
>> The code touches shared JFR parts. Have you got the acknowledgment from
>> JFR people? You have to list
>> who had reviewed the patch. If everything is in order there, one of us
>> (Shenandoah devs) can push.
>>
>> -Aleksey
>>
>>

From shade at redhat.com  Sat May 18 11:04:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Sat, 18 May 2019 13:04:26 +0200
Subject: Heads-up: sh/jdk11 aarch64 build failure
Message-ID: <5c970fed-3647-baf8-446c-feb95f01dacc@redhat.com>

This is due to recent backports:

/home/shade/shenandoah-jdk11/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp:
In member function ?virtual void ShenandoahBarrierSetAssembler::arraycopy_epilogue(MacroAssembler*,
DecoratorSet, bool, Register, Register, Register, RegSet)?:
/home/shade/shenandoah-jdk11/src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp:94:14:
error: ?count? was not declared in this scope
       __ cbz(count, done);
              ^~~~~

...there is no "count" register there indeed.

-Aleksey


From shade at redhat.com  Sat May 18 12:27:27 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Sat, 18 May 2019 14:27:27 +0200
Subject: Heads-up: jdk/jdk CTW test failures
Message-ID: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>

Lots of CTW failures in jdk/jdk with Shenandoah enabled. Seems to be problematic with Traversal:

$ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/
TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+UseShenandoahGC
-XX:-TieredCompilation -XX:+ShenandoahVerifyOptoBarriers -XX:ShenandoahGCHeuristics=traversal"

Sample hs_errs:
 http://cr.openjdk.java.net/~shade/shenandoah/crashes/ctw-traversal/

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/shade/trunks/jdk-jdk/src/hotspot/cpu/x86/relocInfo_x86.cpp:56), pid=25735,
tid=25748
#  guarantee(*(uint32_t*) disp == CompressedOops::encode((oop)x)) failed: instructions must match

...
V  [libjvm.so+0x1559b99]  Relocation::pd_set_data_value(unsigned char*, long, bool)+0x369
V  [libjvm.so+0x9dcfb3]  CompiledMethod::verify_oop_relocations()+0x133
V  [libjvm.so+0x138f962]  nmethod::oops_do_marking_epilogue()+0x72
V  [libjvm.so+0x1694541]  ShenandoahTraversalGC::init_traversal_collection()+0x381
V  [libjvm.so+0x163e8c1]  ShenandoahHeap::entry_init_traversal()+0x101
V  [libjvm.so+0x16c618a]  VM_ShenandoahInitTraversalGC::doit()+0x2a
V  [libjvm.so+0x18d7b21]  VM_Operation::evaluate()+0x1f1
V  [libjvm.so+0x19080f0]  VMThread::evaluate_operation(VM_Operation*) [clone .constprop.64]+0x180
V  [libjvm.so+0x1908b4c]  VMThread::loop()+0x71c
V  [libjvm.so+0x190919a]  VMThread::run()+0xca
V  [libjvm.so+0x1813b66]  Thread::call_run()+0xf6
V  [libjvm.so+0x141c40e]  thread_native_entry(Thread*)+0x10e

-- 
Thanks,
-Aleksey



From zgu at redhat.com  Sat May 18 23:04:13 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Sat, 18 May 2019 19:04:13 -0400
Subject: Heads-up: jdk/jdk CTW test failures
In-Reply-To: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
References: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
Message-ID: <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>

Saw this before, likely called nmethod::oops_marking_prologue/epilogue 
twice. Which repo?

Thanks,

-Zhengyu

On 5/18/19 8:27 AM, Aleksey Shipilev wrote:
> Lots of CTW failures in jdk/jdk with Shenandoah enabled. Seems to be problematic with Traversal:
> 
> $ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/
> TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+UseShenandoahGC
> -XX:-TieredCompilation -XX:+ShenandoahVerifyOptoBarriers -XX:ShenandoahGCHeuristics=traversal"
> 
> Sample hs_errs:
>   http://cr.openjdk.java.net/~shade/shenandoah/crashes/ctw-traversal/
> 
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  Internal Error (/home/shade/trunks/jdk-jdk/src/hotspot/cpu/x86/relocInfo_x86.cpp:56), pid=25735,
> tid=25748
> #  guarantee(*(uint32_t*) disp == CompressedOops::encode((oop)x)) failed: instructions must match
> 
> ...
> V  [libjvm.so+0x1559b99]  Relocation::pd_set_data_value(unsigned char*, long, bool)+0x369
> V  [libjvm.so+0x9dcfb3]  CompiledMethod::verify_oop_relocations()+0x133
> V  [libjvm.so+0x138f962]  nmethod::oops_do_marking_epilogue()+0x72
> V  [libjvm.so+0x1694541]  ShenandoahTraversalGC::init_traversal_collection()+0x381
> V  [libjvm.so+0x163e8c1]  ShenandoahHeap::entry_init_traversal()+0x101
> V  [libjvm.so+0x16c618a]  VM_ShenandoahInitTraversalGC::doit()+0x2a
> V  [libjvm.so+0x18d7b21]  VM_Operation::evaluate()+0x1f1
> V  [libjvm.so+0x19080f0]  VMThread::evaluate_operation(VM_Operation*) [clone .constprop.64]+0x180
> V  [libjvm.so+0x1908b4c]  VMThread::loop()+0x71c
> V  [libjvm.so+0x190919a]  VMThread::run()+0xca
> V  [libjvm.so+0x1813b66]  Thread::call_run()+0xf6
> V  [libjvm.so+0x141c40e]  thread_native_entry(Thread*)+0x10e
> 

From shade at redhat.com  Sun May 19 07:45:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Sun, 19 May 2019 09:45:55 +0200
Subject: Heads-up: jdk/jdk CTW test failures
In-Reply-To: <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>
References: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
 <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>
Message-ID: <46e2dca2-f95e-ce42-def6-9a450bb13f47@redhat.com>

jdk/jdk.

-Aleksey

On 5/19/19 1:04 AM, Zhengyu Gu wrote:
> Saw this before, likely called nmethod::oops_marking_prologue/epilogue twice. Which repo?
> 
> Thanks,
> 
> -Zhengyu
> 
> On 5/18/19 8:27 AM, Aleksey Shipilev wrote:
>> Lots of CTW failures in jdk/jdk with Shenandoah enabled. Seems to be problematic with Traversal:
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/
>> TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+UseShenandoahGC
>> -XX:-TieredCompilation -XX:+ShenandoahVerifyOptoBarriers -XX:ShenandoahGCHeuristics=traversal"
>>
>> Sample hs_errs:
>> ? http://cr.openjdk.java.net/~shade/shenandoah/crashes/ctw-traversal/
>>
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #? Internal Error (/home/shade/trunks/jdk-jdk/src/hotspot/cpu/x86/relocInfo_x86.cpp:56), pid=25735,
>> tid=25748
>> #? guarantee(*(uint32_t*) disp == CompressedOops::encode((oop)x)) failed: instructions must match
>>
>> ...
>> V? [libjvm.so+0x1559b99]? Relocation::pd_set_data_value(unsigned char*, long, bool)+0x369
>> V? [libjvm.so+0x9dcfb3]? CompiledMethod::verify_oop_relocations()+0x133
>> V? [libjvm.so+0x138f962]? nmethod::oops_do_marking_epilogue()+0x72
>> V? [libjvm.so+0x1694541]? ShenandoahTraversalGC::init_traversal_collection()+0x381
>> V? [libjvm.so+0x163e8c1]? ShenandoahHeap::entry_init_traversal()+0x101
>> V? [libjvm.so+0x16c618a]? VM_ShenandoahInitTraversalGC::doit()+0x2a
>> V? [libjvm.so+0x18d7b21]? VM_Operation::evaluate()+0x1f1
>> V? [libjvm.so+0x19080f0]? VMThread::evaluate_operation(VM_Operation*) [clone .constprop.64]+0x180
>> V? [libjvm.so+0x1908b4c]? VMThread::loop()+0x71c
>> V? [libjvm.so+0x190919a]? VMThread::run()+0xca
>> V? [libjvm.so+0x1813b66]? Thread::call_run()+0xf6
>> V? [libjvm.so+0x141c40e]? thread_native_entry(Thread*)+0x10e
>>


-- 
Thanks,
-Aleksey

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander


From zgu at redhat.com  Sun May 19 10:24:09 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Sun, 19 May 2019 06:24:09 -0400
Subject: Heads-up: jdk/jdk CTW test failures
In-Reply-To: <46e2dca2-f95e-ce42-def6-9a450bb13f47@redhat.com>
References: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
 <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>
 <46e2dca2-f95e-ce42-def6-9a450bb13f47@redhat.com>
Message-ID: <27acb2b5-6acb-e099-d314-e48d2d328c9a@redhat.com>

Fixed in http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.00/

@@ -191,15 +189,11 @@
      {
        ShenandoahTraversalClosure roots_cl(q, rp);
        ShenandoahMarkCLDClosure cld_cl(&roots_cl);
        MarkingCodeBlobClosure code_cl(&roots_cl, 
CodeBlobToOopClosure::FixRelocations);
        if (unload_classes) {
-        _rp->strong_roots_do(worker_id, &roots_cl);
-        // Need to pre-evac code roots here. Otherwise we might see 
from-space constants.
-        ShenandoahWorkerTimings* worker_times = 
_heap->phase_timings()->worker_times();
-        ShenandoahWorkerTimingsTracker timer(worker_times, 
ShenandoahPhaseTimings::CodeCacheRoots, worker_id);
-        _cset_coderoots->possibly_parallel_blobs_do(&code_cl);
+        _rp->roots_do(worker_id, &roots_cl, NULL, &code_cl);
        } else {
          _rp->roots_do(worker_id, &roots_cl, &cld_cl, &code_cl);
        }

        AlwaysTrueClosure is_alive;

-Zhengyu

On 5/19/19 3:45 AM, Aleksey Shipilev wrote:
> jdk/jdk.
> 
> -Aleksey
> 
> On 5/19/19 1:04 AM, Zhengyu Gu wrote:
>> Saw this before, likely called nmethod::oops_marking_prologue/epilogue twice. Which repo?
>>
>> Thanks,
>>
>> -Zhengyu
>>
>> On 5/18/19 8:27 AM, Aleksey Shipilev wrote:
>>> Lots of CTW failures in jdk/jdk with Shenandoah enabled. Seems to be problematic with Traversal:
>>>
>>> $ CONF=linux-x86_64-server-fastdebug make run-test TEST=applications/ctw/modules/
>>> TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+UseShenandoahGC
>>> -XX:-TieredCompilation -XX:+ShenandoahVerifyOptoBarriers -XX:ShenandoahGCHeuristics=traversal"
>>>
>>> Sample hs_errs:
>>>  ? http://cr.openjdk.java.net/~shade/shenandoah/crashes/ctw-traversal/
>>>
>>> #
>>> # A fatal error has been detected by the Java Runtime Environment:
>>> #
>>> #? Internal Error (/home/shade/trunks/jdk-jdk/src/hotspot/cpu/x86/relocInfo_x86.cpp:56), pid=25735,
>>> tid=25748
>>> #? guarantee(*(uint32_t*) disp == CompressedOops::encode((oop)x)) failed: instructions must match
>>>
>>> ...
>>> V? [libjvm.so+0x1559b99]? Relocation::pd_set_data_value(unsigned char*, long, bool)+0x369
>>> V? [libjvm.so+0x9dcfb3]? CompiledMethod::verify_oop_relocations()+0x133
>>> V? [libjvm.so+0x138f962]? nmethod::oops_do_marking_epilogue()+0x72
>>> V? [libjvm.so+0x1694541]? ShenandoahTraversalGC::init_traversal_collection()+0x381
>>> V? [libjvm.so+0x163e8c1]? ShenandoahHeap::entry_init_traversal()+0x101
>>> V? [libjvm.so+0x16c618a]? VM_ShenandoahInitTraversalGC::doit()+0x2a
>>> V? [libjvm.so+0x18d7b21]? VM_Operation::evaluate()+0x1f1
>>> V? [libjvm.so+0x19080f0]? VMThread::evaluate_operation(VM_Operation*) [clone .constprop.64]+0x180
>>> V? [libjvm.so+0x1908b4c]? VMThread::loop()+0x71c
>>> V? [libjvm.so+0x190919a]? VMThread::run()+0xca
>>> V? [libjvm.so+0x1813b66]? Thread::call_run()+0xf6
>>> V? [libjvm.so+0x141c40e]? thread_native_entry(Thread*)+0x10e
>>>
> 
> 

From shade at redhat.com  Sun May 19 14:00:35 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Sun, 19 May 2019 16:00:35 +0200
Subject: Heads-up: jdk/jdk CTW test failures
In-Reply-To: <27acb2b5-6acb-e099-d314-e48d2d328c9a@redhat.com>
References: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
 <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>
 <46e2dca2-f95e-ce42-def6-9a450bb13f47@redhat.com>
 <27acb2b5-6acb-e099-d314-e48d2d328c9a@redhat.com>
Message-ID: <32c91303-9fd3-74ab-4a3d-d5f899b29e0c@redhat.com>

On 5/19/19 12:24 PM, Zhengyu Gu wrote:
> Fixed in http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.00/
> 
> @@ -191,15 +189,11 @@
> ???? {
> ?????? ShenandoahTraversalClosure roots_cl(q, rp);
> ?????? ShenandoahMarkCLDClosure cld_cl(&roots_cl);
> ?????? MarkingCodeBlobClosure code_cl(&roots_cl, CodeBlobToOopClosure::FixRelocations);
> ?????? if (unload_classes) {
> -??????? _rp->strong_roots_do(worker_id, &roots_cl);
> -??????? // Need to pre-evac code roots here. Otherwise we might see from-space constants.
> -??????? ShenandoahWorkerTimings* worker_times = _heap->phase_timings()->worker_times();
> -??????? ShenandoahWorkerTimingsTracker timer(worker_times, ShenandoahPhaseTimings::CodeCacheRoots,
> worker_id);
> -??????? _cset_coderoots->possibly_parallel_blobs_do(&code_cl);
> +??????? _rp->roots_do(worker_id, &roots_cl, NULL, &code_cl);
> ?????? } else {
> ???????? _rp->roots_do(worker_id, &roots_cl, &cld_cl, &code_cl);
> ?????? }
> 
> ?????? AlwaysTrueClosure is_alive;

Okay. I cannot see off-hand how this is safe: do we walk coderoots somewhere else? I don't think we
are, because the assert below happens if I remove that block from jdk/jdk. Anyway, why is it even
there in "eliminate RWLock" patch? Please split it up as the separate patch.

#  Error: Shenandoah assert_not_forwarded failed; Object should not be forwarded

Referenced from:
  interior location: 0x00007f6c40d4dbb0
  outside of Java heap
  0x00007f6c40d4dbb0 points into unknown readable memory: 88 ef ec 0e 07 00 00 00

Object:
  0x000000070eecef88 - klass 0x0000000800b5dcf0 jdk.internal.jimage.ImageBufferCache$1
    not allocated after mark start
    not marked
        in collection set
        in traversal set
  region: |    1|CS |BTE    70ee00000,    70ef00000,    70ef00000|TAMS    70ef00000|U  1024K|T
1024K|G     0B|S     0B|L     0B|CP   0|SN            2,        2,        0,        0

Forwardee:
  0x00000007ffe48098 - klass 0x0000000800b5dcf0 jdk.internal.jimage.ImageBufferCache$1
    not allocated after mark start
        marked
    not in collection set
        in traversal set
  region: | 3857|R  |BTE    7ffe00000,    7fff00000,    7fff00000|TAMS    7fff00000|U  1024K|T
0B|G   761K|S   262K|L   968K|CP   0|SN            0,        0,      238,      26a

Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native
code)
V  [libjvm.so+0x18d52ef]  VMError::report_and_die(int, char const*, char const*, __va_list_tag*,
Thread*, unsigned char*, void*, void*, char const*, int, unsigned long)+0x36f
V  [libjvm.so+0x18d603f]  VMError::report_and_die(Thread*, void*, char const*, int, char const*,
char const*, __va_list_tag*)+0x2f
V  [libjvm.so+0xa80b61]  report_vm_error(char const*, int, char const*, char const*, ...)+0x111
V  [libjvm.so+0x15cec41]  ShenandoahAsserts::print_failure(ShenandoahAsserts::SafeLevel, oop, void*,
oop, char const*, char const*, char const*, int)+0x501
V  [libjvm.so+0x15d1ca7]  ShenandoahAsserts::assert_not_forwarded(void*, oop, char const*, int)+0x127
V  [libjvm.so+0x16c29ce]  ShenandoahTraversalSATBBufferClosure::do_buffer(void**, unsigned long)+0x7e
V  [libjvm.so+0x15910a2]  SATBMarkQueue::apply_closure_and_empty(SATBBufferClosure*)+0x122
V  [libjvm.so+0x167163d]  ShenandoahParallelOopsDoThreadClosure::do_thread(Thread*)+0xed
V  [libjvm.so+0x18109d9]  Threads::possibly_parallel_threads_do(bool, ThreadClosure*)+0xa9
V  [libjvm.so+0x166fe08]  ShenandoahThreadRoots::threads_do(ThreadClosure*, unsigned int)+0xe8
V  [libjvm.so+0x1670aae]  ShenandoahRootScanner::strong_roots_do(unsigned int, OopClosure*,
CLDClosure*, CodeBlobClosure*, ThreadClosure*)+0x18e
V  [libjvm.so+0x16c04bf]  ShenandoahFinalTraversalCollectionTask::work(unsigned int)+0x20f
V  [libjvm.so+0x1948b20]  GangWorker::loop()+0xe0
V  [libjvm.so+0x1813b06]  Thread::call_run()+0xf6
V  [libjvm.so+0x141c40e]  thread_native_entry(Thread*)+0x10e

-Aleksey


From zgu at redhat.com  Sun May 19 15:45:13 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Sun, 19 May 2019 11:45:13 -0400
Subject: Heads-up: jdk/jdk CTW test failures
In-Reply-To: <32c91303-9fd3-74ab-4a3d-d5f899b29e0c@redhat.com>
References: <c016ce91-9e66-99de-831c-4ce19e25dd60@redhat.com>
 <f4046505-f773-6afb-361c-418b73f3dd72@redhat.com>
 <46e2dca2-f95e-ce42-def6-9a450bb13f47@redhat.com>
 <27acb2b5-6acb-e099-d314-e48d2d328c9a@redhat.com>
 <32c91303-9fd3-74ab-4a3d-d5f899b29e0c@redhat.com>
Message-ID: <dca34c5d-96a2-0779-e027-c85afca38d0c@redhat.com>

Were you using whole patch? if not, sorry for confusing you.

The code roots now are processed inside roots_do() by passing codecache 
closure. Let me split the fix out of eliminating RWLock patch, it was 
not discovered before.

-Zhengyu





On 5/19/19 10:00 AM, Aleksey Shipilev wrote:
> On 5/19/19 12:24 PM, Zhengyu Gu wrote:
>> Fixed in http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.00/
>>
>> @@ -191,15 +189,11 @@
>>  ???? {
>>  ?????? ShenandoahTraversalClosure roots_cl(q, rp);
>>  ?????? ShenandoahMarkCLDClosure cld_cl(&roots_cl);
>>  ?????? MarkingCodeBlobClosure code_cl(&roots_cl, CodeBlobToOopClosure::FixRelocations);
>>  ?????? if (unload_classes) {
>> -??????? _rp->strong_roots_do(worker_id, &roots_cl);
>> -??????? // Need to pre-evac code roots here. Otherwise we might see from-space constants.
>> -??????? ShenandoahWorkerTimings* worker_times = _heap->phase_timings()->worker_times();
>> -??????? ShenandoahWorkerTimingsTracker timer(worker_times, ShenandoahPhaseTimings::CodeCacheRoots,
>> worker_id);
>> -??????? _cset_coderoots->possibly_parallel_blobs_do(&code_cl);
>> +??????? _rp->roots_do(worker_id, &roots_cl, NULL, &code_cl);
>>  ?????? } else {
>>  ???????? _rp->roots_do(worker_id, &roots_cl, &cld_cl, &code_cl);
>>  ?????? }
>>
>>  ?????? AlwaysTrueClosure is_alive;
> 
> Okay. I cannot see off-hand how this is safe: do we walk coderoots somewhere else? I don't think we
> are, because the assert below happens if I remove that block from jdk/jdk. Anyway, why is it even
> there in "eliminate RWLock" patch? Please split it up as the separate patch.
> 
> #  Error: Shenandoah assert_not_forwarded failed; Object should not be forwarded
> 
> Referenced from:
>    interior location: 0x00007f6c40d4dbb0
>    outside of Java heap
>    0x00007f6c40d4dbb0 points into unknown readable memory: 88 ef ec 0e 07 00 00 00
> 
> Object:
>    0x000000070eecef88 - klass 0x0000000800b5dcf0 jdk.internal.jimage.ImageBufferCache$1
>      not allocated after mark start
>      not marked
>          in collection set
>          in traversal set
>    region: |    1|CS |BTE    70ee00000,    70ef00000,    70ef00000|TAMS    70ef00000|U  1024K|T
> 1024K|G     0B|S     0B|L     0B|CP   0|SN            2,        2,        0,        0
> 
> Forwardee:
>    0x00000007ffe48098 - klass 0x0000000800b5dcf0 jdk.internal.jimage.ImageBufferCache$1
>      not allocated after mark start
>          marked
>      not in collection set
>          in traversal set
>    region: | 3857|R  |BTE    7ffe00000,    7fff00000,    7fff00000|TAMS    7fff00000|U  1024K|T
> 0B|G   761K|S   262K|L   968K|CP   0|SN            0,        0,      238,      26a
> 
> Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native
> code)
> V  [libjvm.so+0x18d52ef]  VMError::report_and_die(int, char const*, char const*, __va_list_tag*,
> Thread*, unsigned char*, void*, void*, char const*, int, unsigned long)+0x36f
> V  [libjvm.so+0x18d603f]  VMError::report_and_die(Thread*, void*, char const*, int, char const*,
> char const*, __va_list_tag*)+0x2f
> V  [libjvm.so+0xa80b61]  report_vm_error(char const*, int, char const*, char const*, ...)+0x111
> V  [libjvm.so+0x15cec41]  ShenandoahAsserts::print_failure(ShenandoahAsserts::SafeLevel, oop, void*,
> oop, char const*, char const*, char const*, int)+0x501
> V  [libjvm.so+0x15d1ca7]  ShenandoahAsserts::assert_not_forwarded(void*, oop, char const*, int)+0x127
> V  [libjvm.so+0x16c29ce]  ShenandoahTraversalSATBBufferClosure::do_buffer(void**, unsigned long)+0x7e
> V  [libjvm.so+0x15910a2]  SATBMarkQueue::apply_closure_and_empty(SATBBufferClosure*)+0x122
> V  [libjvm.so+0x167163d]  ShenandoahParallelOopsDoThreadClosure::do_thread(Thread*)+0xed
> V  [libjvm.so+0x18109d9]  Threads::possibly_parallel_threads_do(bool, ThreadClosure*)+0xa9
> V  [libjvm.so+0x166fe08]  ShenandoahThreadRoots::threads_do(ThreadClosure*, unsigned int)+0xe8
> V  [libjvm.so+0x1670aae]  ShenandoahRootScanner::strong_roots_do(unsigned int, OopClosure*,
> CLDClosure*, CodeBlobClosure*, ThreadClosure*)+0x18e
> V  [libjvm.so+0x16c04bf]  ShenandoahFinalTraversalCollectionTask::work(unsigned int)+0x20f
> V  [libjvm.so+0x1948b20]  GangWorker::loop()+0xe0
> V  [libjvm.so+0x1813b06]  Thread::call_run()+0xf6
> V  [libjvm.so+0x141c40e]  thread_native_entry(Thread*)+0x10e
> 
> -Aleksey
> 

From zgu at redhat.com  Mon May 20 00:59:59 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Sun, 19 May 2019 20:59:59 -0400
Subject: RFR 8224179: Shenandoah: CTW test failures with traversal GC
Message-ID: <0a13c972-9a15-917a-ef0a-7cfe351ea15b@redhat.com>

The failures were due to nested 
nmethod::oops_do_marking_prologue()/nmethod::oops_do_marking_epilogue() 
calls. This patch is split from early JDK-8224115.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224179
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224179/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)
   applications/ctw/modules/ fastdebug.


Thanks,

-Zhengyu

From shade at redhat.com  Mon May 20 07:35:57 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 09:35:57 +0200
Subject: RFR 8224179: Shenandoah: CTW test failures with traversal GC
In-Reply-To: <0a13c972-9a15-917a-ef0a-7cfe351ea15b@redhat.com>
References: <0a13c972-9a15-917a-ef0a-7cfe351ea15b@redhat.com>
Message-ID: <5f521f87-28f1-811b-3aad-9dff2457d9bb@redhat.com>

On 5/20/19 2:59 AM, Zhengyu Gu wrote:
> The failures were due to nested
> nmethod::oops_do_marking_prologue()/nmethod::oops_do_marking_epilogue() calls. This patch is split
> from early JDK-8224115.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224179
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224179/webrev.00/

Looks okay. The synopsis for the change does not reflect what is going on: it should mention what
the change does, i.e. "Introduce all- and cset-specialized ShenandoahRootScanner"?

The patch does lots of code moves. Are those moves necessary to fix the failure? Ideally, the
refactoring and the functional change should go separately. In other words, the fix should make it
absolutely clear what is done, not obscure most of it with reshuffling the code.

-Aleksey


From shade at redhat.com  Mon May 20 10:26:24 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 12:26:24 +0200
Subject: RFR/RFC: Pick up aarch64-shenandoah-jdk8u222-b02 to sh/jdk8
Message-ID: <dc392693-a164-f51c-a7a8-00b6ffffa041@redhat.com>

Hi,

This is our first ever merge from aarch64-port/jdk8u-shenandoah to sh/jdk8. This picks up
aarch64-shenandoah-jdk8u222-b02 tag and merges it into sh/jdk8.

Changesets (only hotspot, others are trivial):
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/changesets.txt

Webrev (only hotspot, others are trivial):
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/webrev.01/

Testing: hotspot_gc_shenandoah {fastdebug,release}

Andrew Hughes, we need to agree on process here. The way it is done right now, we are doing this:
 a. Pull aarch64-port/jdk8u-shenandoah -> sh/jdk8, merge
 b. Test it, pile on our backports
 c. Repeat (a)-(b) until Shenandoah is stable
 d. RFR the pull sh/jdk8 -> aarch64-port/jdk8u-shenandoah, tag it appropriately

Since aarch64-port/jdk8u-shenandoah and sh/jdk8 are related now, this allows us to push/pull between
them without any Mercurial voodoo. The caveat there is that the pull at (d) would include a few
local "merge" changesets from (a), are you fine with that? I also prefer not to introduce new
sh/jdk8-specific tags to avoid contaminating aarch64-port/jdk8u-shenandoah with them, so those
merges would be untagged.

You could ask why don't we just push the backports to aarch64-port/jdk8u-shenandoah, but the trouble
is that 8u is a mess GC-interface-wise, and we would like to have sh/jdk8 as additional sandbox to
test for ourselves before integrating. It would be better as we backport more simplifications like
LRB and nofwdptr features into sh/jdk8u, which would get Shenandoah upstream exposure down
significantly. But so far it is what it is.

-- 
Thanks,
-Aleksey



From shade at redhat.com  Mon May 20 10:34:02 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 12:34:02 +0200
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <CADPaBqnGZe2CWPgME_Q1uBD2uun6jTctPDm3s6WQ2BxNPR9xjQ@mail.gmail.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
 <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
 <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>
 <CADPaBqnGZe2CWPgME_Q1uBD2uun6jTctPDm3s6WQ2BxNPR9xjQ@mail.gmail.com>
Message-ID: <0d538ec3-5532-70fc-8ad4-85916b681e19@redhat.com>

On 5/17/19 10:29 PM, Ken Dobson wrote:
> Apologies there was one tiny typo in a String that is now fixed here:
> http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests1/webrev

I can sponsor this week, after we stabilize jdk/jdk enough to accept it.

-Aleksey


From rkennke at redhat.com  Mon May 20 10:57:32 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 20 May 2019 12:57:32 +0200
Subject: RFR (11/aarch64): Fix Shenandoah aarch64 arraycopy epilogue
Message-ID: <ffa256ba-c979-246d-2285-1a4bbaf024e4@redhat.com>

We have no count register in Shenandoah's arraycopy_epilogue() in
jdk11/aarch64. But we're computing count a little later. We can use that
instead:

http://cr.openjdk.java.net/~rkennke/jdk11-fix-epilogue/webrev.00/

This unbreaks the build of sh/jdk11.

Testing: hotspot_gc_shenandoah runs fine

Ok?

Roman


From zgu at redhat.com  Mon May 20 11:26:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 20 May 2019 07:26:47 -0400
Subject: RFR(XS) 8224115: Shenandoah: Eliminate RWLock that protects
 recorded nmethod data array
In-Reply-To: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
References: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
Message-ID: <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>

Split the original patch, moved root processing changes that deal with 
traversal GC problem into JDK-8224179.

Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.01/

Test:
   reran hotspot_gc_shenandoah (fastdebug and release)
   applications/ctw/modules (fastdebug)

Thanks,

-Zhengyu


On 5/17/19 11:57 AM, Zhengyu Gu wrote:
> I would like to eliminate RWLock that used to protect recorded nmethod 
> data array in ShenandoahCodeRoots, because the methods that update the 
> array, are already guarded by CodeCache_lock.
> 
> The patch also helps concurrent class unloading work, by avoiding two 
> lock dances, which are deadlock prone.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224115
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.00/
> 
> Test:
>  ? hotspot_gc_shenandoah (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu

From shade at redhat.com  Mon May 20 11:56:08 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 13:56:08 +0200
Subject: RFR (11/aarch64): Fix Shenandoah aarch64 arraycopy epilogue
In-Reply-To: <ffa256ba-c979-246d-2285-1a4bbaf024e4@redhat.com>
References: <ffa256ba-c979-246d-2285-1a4bbaf024e4@redhat.com>
Message-ID: <466ca17b-e853-fa76-a1e7-72c93473ad58@redhat.com>

On 5/20/19 12:57 PM, Roman Kennke wrote:
> We have no count register in Shenandoah's arraycopy_epilogue() in
> jdk11/aarch64. But we're computing count a little later. We can use that
> instead:
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-fix-epilogue/webrev.00/

OK! Please push.

-Aleksey


From rkennke at redhat.com  Mon May 20 12:04:08 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Mon, 20 May 2019 12:04:08 +0000
Subject: hg: shenandoah/jdk11: Fix Shenandoah aarch64 arraycopy epilogue
Message-ID: <201905201204.x4KC48cZ026161@aojmv0008.oracle.com>

Changeset: 06578a13ee61
Author:    rkennke
Date:      2019-05-20 06:52 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/06578a13ee61

Fix Shenandoah aarch64 arraycopy epilogue

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp


From zgu at redhat.com  Mon May 20 13:11:53 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 20 May 2019 09:11:53 -0400
Subject: RFR(S) 8224210: Shenandoah: Refactor ShenandoahRootScanner to support
 scanning CSet codecache roots
Message-ID: <fbf12a41-3ea6-f4e4-8d3b-a1eb7c2f97b2@redhat.com>

Split the refactoring from early JDK-8224179 patch, as suggested by Aleksey.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224210
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224210/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)
   Failed CTW tests in traversal mode as expected.

Thanks,

-Zhengyu

From shade at redhat.com  Mon May 20 13:16:47 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 15:16:47 +0200
Subject: RFR(S) 8224210: Shenandoah: Refactor ShenandoahRootScanner to
 support scanning CSet codecache roots
In-Reply-To: <fbf12a41-3ea6-f4e4-8d3b-a1eb7c2f97b2@redhat.com>
References: <fbf12a41-3ea6-f4e4-8d3b-a1eb7c2f97b2@redhat.com>
Message-ID: <aac1e2cb-768f-1c68-072a-30c64e2e3f81@redhat.com>

On 5/20/19 3:11 PM, Zhengyu Gu wrote:
> Split the refactoring from early JDK-8224179 patch, as suggested by Aleksey.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224210
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224210/webrev.00/

Looks fine to me.

-Aleksey


From rkennke at redhat.com  Mon May 20 13:31:24 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 20 May 2019 15:31:24 +0200
Subject: RFR (jdk11/aarch64): Shenandoah: Fix unbalanced push/pop in arraycopy
 epilogue
Message-ID: <be154886-044e-83b2-dab4-189d02545c04@redhat.com>

I made a mistake in my recent arraycopy epilogue fix, which can leave
the registers push/pop unbalanced. We need to place the push and pop
symmetrically inside the slow-path block:

http://cr.openjdk.java.net/~rkennke/jdk11-fix-epilogue-2/webrev.00/

Testing: hotspot_gc_shenandoah still passes

Ok?

Roman


From shade at redhat.com  Mon May 20 13:33:15 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 15:33:15 +0200
Subject: RFR (jdk11/aarch64): Shenandoah: Fix unbalanced push/pop in
 arraycopy epilogue
In-Reply-To: <be154886-044e-83b2-dab4-189d02545c04@redhat.com>
References: <be154886-044e-83b2-dab4-189d02545c04@redhat.com>
Message-ID: <8b989672-14a1-e7bd-a9db-4ac6c614765f@redhat.com>

On 5/20/19 3:31 PM, Roman Kennke wrote:
> I made a mistake in my recent arraycopy epilogue fix, which can leave
> the registers push/pop unbalanced. We need to place the push and pop
> symmetrically inside the slow-path block:
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-fix-epilogue-2/webrev.00/

OK.

-Aleksey


From zgu at redhat.com  Mon May 20 13:36:13 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 20 May 2019 09:36:13 -0400
Subject: RFR 8224179: Shenandoah: CTW test failures with traversal GC
In-Reply-To: <5f521f87-28f1-811b-3aad-9dff2457d9bb@redhat.com>
References: <0a13c972-9a15-917a-ef0a-7cfe351ea15b@redhat.com>
 <5f521f87-28f1-811b-3aad-9dff2457d9bb@redhat.com>
Message-ID: <1143128f-a899-5ddd-02f2-b02ee1645615@redhat.com>



On 5/20/19 3:35 AM, Aleksey Shipilev wrote:
> On 5/20/19 2:59 AM, Zhengyu Gu wrote:
>> The failures were due to nested
>> nmethod::oops_do_marking_prologue()/nmethod::oops_do_marking_epilogue() calls. This patch is split
>> from early JDK-8224115.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224179
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224179/webrev.00/
> 
> Looks okay. The synopsis for the change does not reflect what is going on: it should mention what
> the change does, i.e. "Introduce all- and cset-specialized ShenandoahRootScanner"?

Split the changeset, ShenandoahRootScanner refactoring now is done by 
JDK-8224210.

Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224179/webrev.01/

Test:
   hotspot_gc_shenandoah and CTW test in traversal mode.

Thanks,

-Zhengyu



> 
> The patch does lots of code moves. Are those moves necessary to fix the failure? Ideally, the
> refactoring and the functional change should go separately. In other words, the fix should make it
> absolutely clear what is done, not obscure most of it with reshuffling the code.
> 
> -Aleksey
> 

From rkennke at redhat.com  Mon May 20 13:38:40 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Mon, 20 May 2019 13:38:40 +0000
Subject: hg: shenandoah/jdk11: Shenandoah: Fix unbalanced push/pop in
 arraycopy epilogue
Message-ID: <201905201338.x4KDcfIV022413@aojmv0008.oracle.com>

Changeset: d91ed2953f04
Author:    rkennke
Date:      2019-05-20 09:25 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d91ed2953f04

Shenandoah: Fix unbalanced push/pop in arraycopy epilogue

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp


From shade at redhat.com  Mon May 20 13:38:51 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 20 May 2019 15:38:51 +0200
Subject: RFR 8224179: Shenandoah: CTW test failures with traversal GC
In-Reply-To: <1143128f-a899-5ddd-02f2-b02ee1645615@redhat.com>
References: <0a13c972-9a15-917a-ef0a-7cfe351ea15b@redhat.com>
 <5f521f87-28f1-811b-3aad-9dff2457d9bb@redhat.com>
 <1143128f-a899-5ddd-02f2-b02ee1645615@redhat.com>
Message-ID: <bb2735f8-aaa4-e164-4384-8c059c75240f@redhat.com>

On 5/20/19 3:36 PM, Zhengyu Gu wrote:
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224179/webrev.01/

Excellent. So we clearly see that !unload_classes path only does not scan CLDs. Coderoots are
scanned normally by passing the code_cl to the same RootScanner. Thumbs up!

-Aleksey


From zgu at redhat.com  Mon May 20 14:19:53 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 20 May 2019 10:19:53 -0400
Subject: RFR (jdk8): Backport weakroots stuff to sh/jdk8
In-Reply-To: <f7b672f7-06b2-2f3b-1f35-51c43fc87fb2@redhat.com>
References: <f7b672f7-06b2-2f3b-1f35-51c43fc87fb2@redhat.com>
Message-ID: <6a59c752-6661-360e-9e9f-b54eaa7ba497@redhat.com>

Hi Roman,

1) Should StringTable also belong to WeakProcessor?

2) Why SRP::processor_vm_roots() still contains JNIHandles' weak oops

3) SRP::process_all_roots(), should we call WeakProcessor::oops_do() 
instead? when we need to mark through all roots?

Thanks,

-Zhengyu


On 5/17/19 8:29 AM, Roman Kennke wrote:
> This backports the following two changes from sh/jdk11 -> sh/jdk8:
> 
> 49: JDK-8221435: Shenandoah should not mark through weak roots
> 49: JDK-8221629: Shenandoah: Cleanup class unloading logic
> 
> 
> This is a bit risky and complicated. I added a compat class in
> shenandoahWeakProcessor.hpp/cpp which is basically the same (with minor
> removals) as jdk11's weakProcessor.hpp/cpp.
> 
> Other than that, the weakroots-handling in systemDictionary is a bit
> different and more messy than in jdk11, which is why I moved those bits
> into process_strong_roots() (only scans strong sys-dict roots) and
> process_weak_roots (scans both strong+weak sys-dict roots). This keeps
> the interfaces the same as in jdk11 and 13 and does the right thing.
> Unfortunately, we can't drive the strong and weak sys-dict roots
> separately as it's done in jdk11 and upwards.
> 
> The stringdedup stuff is also different. I believe I got it right, as
> much as it is possible.
> 
> Testing: hotspot_gc_shenandoah looks good. Some point testing in specjvm
> did not show up any problems. We want to test this thouroughly in our CI
> before shipping it anywhere.
> 
> http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-17-1/webrev.00/
> 
> Ok to go?
> 
> Roman
> 

From shade at redhat.com  Tue May 21 06:47:18 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 21 May 2019 06:47:18 +0000
Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.4+3 for changeset
 d91ed2953f04
Message-ID: <201905210647.x4L6lJdO024778@aojmv0008.oracle.com>

Changeset: 88e728841ec7
Author:    shade
Date:      2019-05-21 08:46 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/88e728841ec7

Added tag shenandoah-jdk-11.0.4+3 for changeset d91ed2953f04

! .hgtags


From shade at redhat.com  Tue May 21 07:36:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 09:36:55 +0200
Subject: RFR/RFC: Pick up jdk-13+21+ to sh/jdk
Message-ID: <9a10782b-9fce-c65e-47af-c2bbd5e1298b@redhat.com>

We have caught the moment in jdk/jdk where it is not broken anywhere. Let's pick that up. There is a
trivial merge required after ShRootProcessor changes.

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/changesets.txt

Webrev (only "shenandoah" parts, since there is a huge Graal update):
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/webrev.01/

Testing: hotspot_gc_shenandoah {fastdebug|release}, eyeballing webrev

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May 21 07:56:50 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 21 May 2019 09:56:50 +0200
Subject: RFR/RFC: Pick up jdk-13+21+ to sh/jdk
In-Reply-To: <9a10782b-9fce-c65e-47af-c2bbd5e1298b@redhat.com>
References: <9a10782b-9fce-c65e-47af-c2bbd5e1298b@redhat.com>
Message-ID: <b3afab91-d249-f117-fdb6-cc91c4e5f166@redhat.com>

Finally! :-)

Changes look good. Go!

Thanks,
Roman


> We have caught the moment in jdk/jdk where it is not broken anywhere. Let's pick that up. There is a
> trivial merge required after ShRootProcessor changes.
> 
> Changesets:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/changesets.txt
> 
> Webrev (only "shenandoah" parts, since there is a huge Graal update):
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/webrev.01/
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}, eyeballing webrev
> 


From shade at redhat.com  Tue May 21 08:15:22 2019
From: shade at redhat.com (shade at redhat.com)
Date: Tue, 21 May 2019 08:15:22 +0000
Subject: hg: shenandoah/jdk: 104 new changesets
Message-ID: <201905210815.x4L8FTxm015208@aojmv0008.oracle.com>

Changeset: e9db10a375d9
Author:    eosterlund
Date:      2019-05-14 12:07 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e9db10a375d9

8222841: Incorrect static call stub interactions with class unloading
Reviewed-by: kvn, coleenp

! src/hotspot/cpu/x86/compiledIC_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.hpp
! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
! src/hotspot/share/aot/aotCompiledMethod.cpp
! src/hotspot/share/classfile/classLoaderData.hpp
! src/hotspot/share/code/compiledMethod.cpp
! src/hotspot/share/code/compiledMethod.hpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/oops/klass.hpp

Changeset: a82655619efd
Author:    stefank
Date:      2019-05-14 10:54 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a82655619efd

8223822: Add gc IDs in the log of gc verification
Reviewed-by: stefank, tschatzl
Contributed-by: fujie at loongson.cn

! src/hotspot/share/logging/logPrefix.hpp

Changeset: 43439afaab4a
Author:    aefimov
Date:      2019-05-14 13:34 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/43439afaab4a

8223638: Replace wildcard address with loopback or local host in tests - part 6
Reviewed-by: dfuchs

! test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java
! test/jdk/java/net/ServerSocket/UnreferencedSockets.java
! test/jdk/java/net/URL/PerConnectionProxy.java
! test/jdk/java/net/URLConnection/Redirect307Test.java
! test/jdk/java/net/URLConnection/RedirectLimit.java
! test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarHttpProperties.java
! test/jdk/lib/testlibrary/java/util/jar/SimpleHttpServer.java
! test/jdk/sun/net/www/protocol/http/RetryUponTimeout.java
! test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java

Changeset: f9c8e16db3dd
Author:    coleenp
Date:      2019-05-14 08:52 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f9c8e16db3dd

8219459: oopDesc::is_valid() is broken
Summary: Use Metaspace::contains() to test address ranges.
Reviewed-by: mdoerr, stuefe, jiangli

! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/metaspace.hpp
! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/oop.cpp

Changeset: 25c329958c70
Author:    tschatzl
Date:      2019-05-14 15:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/25c329958c70

8200545: Improve filter for enqueued deferred cards
Reviewed-by: kbarrett, sangheki

! src/hotspot/share/gc/g1/g1AllocRegion.hpp
! src/hotspot/share/gc/g1/g1Allocator.cpp
! src/hotspot/share/gc/g1/g1Allocator.hpp
! src/hotspot/share/gc/g1/g1Allocator.inline.hpp
! src/hotspot/share/gc/g1/g1BiasedArray.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp
! src/hotspot/share/gc/g1/g1CollectionSet.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp
+ src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp
! src/hotspot/share/gc/g1/g1HeapVerifier.cpp
- src/hotspot/share/gc/g1/g1InCSetState.hpp
! src/hotspot/share/gc/g1/g1OopClosures.hpp
! src/hotspot/share/gc/g1/g1OopClosures.inline.hpp
! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp
! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp
! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp
! src/hotspot/share/gc/g1/g1Policy.hpp
! src/hotspot/share/gc/g1/g1RemSet.cpp
! src/hotspot/share/gc/g1/g1RemSet.hpp
! test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java
! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java

Changeset: 571732021d59
Author:    tschatzl
Date:      2019-05-14 15:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/571732021d59

8223018: Rename G1RemSet::*oops_into_collection_set_do methods
Reviewed-by: manc, sangheki

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1RemSet.cpp
! src/hotspot/share/gc/g1/g1RemSet.hpp

Changeset: 63ba0b902181
Author:    stuefe
Date:      2019-04-07 09:13 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/63ba0b902181

8221738: ErrorFile option does not handle pre-existing error files of the same name
Reviewed-by: coleenp, clanger

! src/hotspot/share/utilities/vmError.cpp
+ test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileOverwriteTest.java

Changeset: e4049522b074
Author:    vromero
Date:      2019-05-14 11:28 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e4049522b074

8215470: Bad EnclosingMethod attribute on classes declared in lambdas
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
+ test/langtools/tools/javac/T8215470/BadEnclosingMethodAttrTest.java
! test/langtools/tools/javac/classfiles/attributes/EnclosingMethod/EnclosingMethodTest.java
! test/langtools/tools/javac/lambda/LambdaInnerTypeVarReflect.java

Changeset: 59ea39bb2809
Author:    coleenp
Date:      2019-05-14 11:29 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/59ea39bb2809

8223657: Remove unused THREAD argument from SymbolTable functions
Summary: also made lookup and lookup_only functions private to SymbolTable.  External callers use new_symbol or probe.
Reviewed-by: dholmes, gziemski

! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp
! src/hotspot/cpu/s390/sharedRuntime_s390.cpp
! src/hotspot/cpu/sparc/sharedRuntime_sparc.cpp
! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp
! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
! src/hotspot/share/ci/ciEnv.cpp
! src/hotspot/share/ci/ciReplay.cpp
! src/hotspot/share/ci/ciSignature.cpp
! src/hotspot/share/ci/ciSymbol.cpp
! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classListParser.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/defaultMethods.cpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/classfile/modules.cpp
! src/hotspot/share/classfile/stackMapFrame.cpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/symbolTable.hpp
! src/hotspot/share/classfile/systemDictionary.cpp
! src/hotspot/share/classfile/verificationType.cpp
! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/classfile/verifier.hpp
! src/hotspot/share/classfile/vmSymbols.cpp
! src/hotspot/share/compiler/compilerOracle.cpp
! src/hotspot/share/compiler/methodMatcher.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp
! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp
! src/hotspot/share/jfr/jni/jfrGetAllEventClasses.cpp
! src/hotspot/share/jfr/jni/jfrJavaCall.cpp
! src/hotspot/share/jfr/jni/jfrJavaCall.hpp
! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp
! src/hotspot/share/jfr/jni/jfrUpcalls.cpp
! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleDescription.cpp
! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp
! src/hotspot/share/jfr/utilities/jfrJavaLog.cpp
! src/hotspot/share/jfr/writers/jfrJavaEventWriter.cpp
! src/hotspot/share/jvmci/compilerRuntime.cpp
! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp
! src/hotspot/share/jvmci/jvmciEnv.cpp
! src/hotspot/share/jvmci/jvmciJavaClasses.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/memory/heapShared.cpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/oops/symbol.hpp
! src/hotspot/share/oops/typeArrayKlass.cpp
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jvm.cpp
! src/hotspot/share/prims/jvmtiImpl.cpp
! src/hotspot/share/prims/methodHandles.cpp
! src/hotspot/share/prims/nativeLookup.cpp
! src/hotspot/share/prims/wbtestmethods/parserTests.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/deoptimization.cpp
! src/hotspot/share/runtime/fieldType.cpp
! src/hotspot/share/runtime/reflection.cpp
! src/hotspot/share/runtime/signature.cpp
! src/hotspot/share/runtime/signature.hpp
! test/hotspot/gtest/classfile/test_symbolTable.cpp

Changeset: 5d8c5c7bca95
Author:    dsamersoff
Date:      2019-05-14 21:36 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5d8c5c7bca95

8223767: Shenandoah fails to build on Solaris x86_64
Summary: Trivial changes to make Solaris Studio 12.4 happy
Reviewed-by: shade, rkennke
Contributed-by: boris.ulasevich at bell-sw.com

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAllocRequest.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahControlThread.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.hpp
! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp

Changeset: 1e4ab8f5bc77
Author:    jwilhelm
Date:      2019-05-14 22:31 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1e4ab8f5bc77

8223917: Problemlist compiler/ciReplay/TestServerVM.java
Reviewed-by: kbarrett, mikael

! test/hotspot/jtreg/ProblemList.txt

Changeset: f8d45530b75e
Author:    skuksenko
Date:      2019-05-14 15:09 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f8d45530b75e

8223921: Update SocketReadWrite benchmark
Reviewed-by: redestad

! test/micro/org/openjdk/bench/java/net/SocketReadWrite.java

Changeset: f67269c129f9
Author:    dholmes
Date:      2019-05-14 20:29 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f67269c129f9

8223810: HotSpot compile warnings from VS2017
Reviewed-by: dholmes, stuefe
Contributed-by: Andrew Luo <andrewluotechnologies at outlook.com>

! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/services/attachListener.hpp
! test/hotspot/gtest/gtestMain.cpp

Changeset: ddb27517396c
Author:    mbaesken
Date:      2019-05-10 10:18 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ddb27517396c

8222720: Provide extended VMWare/vSphere virtualization related info in the hs_error file on linux/windows x86_64
Reviewed-by: dholmes, rehn

! src/hotspot/cpu/x86/vm_version_x86.cpp
! src/hotspot/share/runtime/os.hpp
+ src/hotspot/share/utilities/virtualizationSupport.cpp
+ src/hotspot/share/utilities/virtualizationSupport.hpp

Changeset: 2ed7d59e725d
Author:    kaddepalli
Date:      2019-04-22 17:02 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2ed7d59e725d

8218917: KeyEvent.getModifiers() returns inconsistent values for ALT keys
Reviewed-by: serb

! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m
! test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java
+ test/jdk/java/awt/keyboard/8218917/AltKeyBug.java

Changeset: 23ff4073267f
Author:    itakiguchi
Date:      2019-04-22 18:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/23ff4073267f

8212676: AWT SystemColor setting on CDE
Reviewed-by: serb

! src/java.desktop/share/classes/sun/awt/OSInfo.java
! src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java

Changeset: cd796dd64044
Author:    serb
Date:      2019-04-22 12:35 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cd796dd64044

8216008: -Djavax.accessibility.assistive_technologies empty list leads to exception
Reviewed-by: prr

! src/java.desktop/share/classes/java/awt/Toolkit.java
! test/jdk/javax/accessibility/AccessibilityProvider/basic.sh

Changeset: 4fcc1f1d7dd8
Author:    serb
Date:      2019-04-22 12:40 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4fcc1f1d7dd8

8222789: Replace the usage of "Sun's Xinerama API" by the "XFree86's Xinerama API" on Solaris
Reviewed-by: prr

! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c

Changeset: 1353a7ca8a37
Author:    psadhukhan
Date:      2019-04-23 14:22 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1353a7ca8a37

Merge


Changeset: bbc7c176c168
Author:    prr
Date:      2019-04-24 09:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bbc7c176c168

8212701: remove sun.desktop property from launcher code
Reviewed-by: serb, alanb, rriggs

! src/demo/share/java2d/J2DBench/src/j2dbench/report/XMLHTMLReporter.java
! src/java.base/share/classes/jdk/internal/util/SystemProps.java
! src/java.base/share/native/libjava/System.c
! src/java.base/share/native/libjava/java_props.h
! src/java.base/unix/native/libjava/java_props_md.c
! src/java.base/windows/native/libjava/java_props_md.c
! src/java.desktop/share/classes/javax/swing/UIManager.java
! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
! src/java.desktop/share/classes/sun/awt/SunToolkit.java
! src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java
+ test/jdk/java/awt/Toolkit/SunDesktopProperty/CheckSunDesktopProperty.java

Changeset: 360c0955b06b
Author:    kaddepalli
Date:      2019-04-25 15:19 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/360c0955b06b

8219914: Change the environment variable for Java Access Bridge logging to have a directory.
Reviewed-by: prr

! src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp
! src/jdk.accessibility/windows/native/common/AccessBridgeDebug.h
! src/jdk.accessibility/windows/native/libjavaaccessbridge/JavaAccessBridge.cpp
! src/jdk.accessibility/windows/native/libwindowsaccessbridge/WinAccessBridge.cpp

Changeset: 1372fbbde8dd
Author:    serb
Date:      2019-04-25 15:13 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1372fbbde8dd

8222438: Drop of outdated logging in the com.sun.media.sound package
Reviewed-by: amenkov

! src/java.desktop/share/classes/com/sun/media/sound/AbstractDataLine.java
! src/java.desktop/share/classes/com/sun/media/sound/AbstractLine.java
! src/java.desktop/share/classes/com/sun/media/sound/AbstractMidiDevice.java
! src/java.desktop/share/classes/com/sun/media/sound/AbstractMidiDeviceProvider.java
! src/java.desktop/share/classes/com/sun/media/sound/AbstractMixer.java
! src/java.desktop/share/classes/com/sun/media/sound/DataPusher.java
! src/java.desktop/share/classes/com/sun/media/sound/DirectAudioDevice.java
! src/java.desktop/share/classes/com/sun/media/sound/DirectAudioDeviceProvider.java
! src/java.desktop/share/classes/com/sun/media/sound/EventDispatcher.java
! src/java.desktop/share/classes/com/sun/media/sound/JSSecurityManager.java
! src/java.desktop/share/classes/com/sun/media/sound/JavaSoundAudioClip.java
! src/java.desktop/share/classes/com/sun/media/sound/MidiInDevice.java
! src/java.desktop/share/classes/com/sun/media/sound/MidiInDeviceProvider.java
! src/java.desktop/share/classes/com/sun/media/sound/MidiOutDevice.java
! src/java.desktop/share/classes/com/sun/media/sound/MidiOutDeviceProvider.java
! src/java.desktop/share/classes/com/sun/media/sound/MidiUtils.java
! src/java.desktop/share/classes/com/sun/media/sound/PCMtoPCMCodec.java
! src/java.desktop/share/classes/com/sun/media/sound/Platform.java
! src/java.desktop/share/classes/com/sun/media/sound/PortMixer.java
! src/java.desktop/share/classes/com/sun/media/sound/PortMixerProvider.java
! src/java.desktop/share/classes/com/sun/media/sound/Printer.java
! src/java.desktop/share/classes/com/sun/media/sound/RealTimeSequencer.java

Changeset: 769dbf384c44
Author:    serb
Date:      2019-04-25 15:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/769dbf384c44

8214046: [macosx] Undecorated Frame does not Iconify when set to
Reviewed-by: dmarkov

! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m
! test/jdk/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java

Changeset: 3464146f4a1c
Author:    serb
Date:      2019-04-25 15:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3464146f4a1c

8222799: java.beans.Introspector uses an obsolete methods cache
Reviewed-by: prr

! src/java.desktop/share/classes/java/beans/Introspector.java
! src/java.desktop/share/classes/java/beans/ThreadGroupContext.java

Changeset: 1e6f7f30943d
Author:    prr
Date:      2019-04-26 12:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1e6f7f30943d

8208179: Devanagari not shown with logical fonts on Windows after removal of Lucida Sans from JDK
Reviewed-by: jdv, naoto

! make/data/fontconfig/windows.fontconfig.properties
! src/java.desktop/share/classes/sun/font/SunFontManager.java
+ test/jdk/java/awt/font/WindowsIndicFonts.java

Changeset: 6b1bac001aaf
Author:    psadhukhan
Date:      2019-04-28 12:34 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6b1bac001aaf

8222830: PIT: java/awt/Window/AlwaysOnTop/AutoTestOnTop.java listed twice in ProblemList
Reviewed-by: serb

! test/jdk/ProblemList.txt

Changeset: 99337f94b04d
Author:    prr
Date:      2019-04-29 10:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/99337f94b04d

8130266: Change the mechanism by which JDK loads the platform-specific GraphicsEnvironment class
Reviewed-by: serb, bchristi

! src/demo/share/java2d/J2DBench/src/j2dbench/ResultSet.java
! src/java.base/share/classes/jdk/internal/util/SystemProps.java
! src/java.base/share/native/libjava/System.c
! src/java.base/share/native/libjava/java_props.h
! src/java.base/unix/native/libjava/java_props_md.c
! src/java.base/windows/native/libjava/java_props_md.c
+ src/java.desktop/macosx/classes/sun/awt/PlatformGraphicsInfo.java
! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m
! src/java.desktop/share/classes/java/awt/GraphicsEnvironment.java
+ src/java.desktop/unix/classes/sun/awt/PlatformGraphicsInfo.java
+ src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java
+ test/jdk/java/awt/GraphicsEnvironment/CheckGraphicsEnvSystemProperty.java

Changeset: a7a436e080c1
Author:    vagarwal
Date:      2019-04-30 04:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a7a436e080c1

8222519: ButtonDemoScreenshotTest fails randomly with "still state to be reached"
Reviewed-by: serb

! test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java

Changeset: 65297f60ba19
Author:    itakiguchi
Date:      2019-04-30 14:30 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/65297f60ba19

8213232: Unix/X11 setCompositionEnableNative issue
Reviewed-by: serb

! src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c
! src/java.desktop/share/classes/sun/awt/im/InputContext.java
! src/java.desktop/unix/classes/sun/awt/X11InputMethod.java
! src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c

Changeset: 88b769ae99c7
Author:    prr
Date:      2019-05-02 10:48 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/88b769ae99c7

Merge

- src/hotspot/os_cpu/linux_x86/gc/z/zAddress_linux_x86.inline.hpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.cpp
- src/hotspot/share/gc/cms/cmsCollectorPolicy.hpp
- src/hotspot/share/gc/epsilon/epsilonCollectorPolicy.hpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1CollectorPolicy.hpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp
- src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.hpp
- src/hotspot/share/gc/parallel/generationSizer.cpp
- src/hotspot/share/gc/parallel/generationSizer.hpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.cpp
- src/hotspot/share/gc/parallel/heterogeneousGenerationSizer.hpp
- src/hotspot/share/gc/shared/collectorPolicy.cpp
- src/hotspot/share/gc/shared/collectorPolicy.hpp
- src/hotspot/share/gc/shared/gcArguments.inline.hpp
- src/hotspot/share/gc/z/zCollectorPolicy.cpp
- src/hotspot/share/gc/z/zCollectorPolicy.hpp
- src/hotspot/share/jvmci/systemDictionary_jvmci.hpp
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIMetaAccessContext.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/MetaspaceWrapperObject.java
- src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml
- src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64IntegerSubstitutions.java
- src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64LongSubstitutions.java
- src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyWithSlowPathNode.java
- test/jdk/java/lang/String/concat/StringConcatFactoryEmptyMethods.java
- test/jdk/java/net/Socket/OldImpl.java
- test/jdk/java/net/Socket/OldSocketImpl.java
- test/jdk/java/net/Socket/OldSocketImplTestDriver.java
- test/jdk/java/nio/channels/SocketChannel/Stream.java
- test/jdk/jdk/nio/zipfs/MultiReleaseJarTest.java
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/root/dir2/leaf4.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf1.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir1/leaf2.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf3.txt
- test/jdk/jdk/nio/zipfs/jarfs/v9/root/dir2/leaf4.txt
- test/jdk/sun/security/pkcs11/tls/tls12/TestTLS12.java

Changeset: 72d194129803
Author:    prr
Date:      2019-05-03 17:06 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/72d194129803

8222819: Remove setting of headless property on MacOS from launcher code.
Reviewed-by: serb, rriggs

! src/java.base/macosx/native/libjava/java_props_macosx.c
! src/java.base/macosx/native/libjava/java_props_macosx.h
! src/java.base/share/classes/jdk/internal/util/SystemProps.java
! src/java.base/share/native/libjava/System.c
! src/java.base/share/native/libjava/java_props.h
! src/java.base/unix/native/libjava/java_props_md.c

Changeset: 0d49e7c0b4fa
Author:    prr
Date:      2019-05-07 11:52 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0d49e7c0b4fa

Merge

! test/jdk/ProblemList.txt

Changeset: c2e4aef5edf2
Author:    serb
Date:      2019-05-07 18:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c2e4aef5edf2

8223237: Replace use of string.equals("") with isEmpty() in java.desktop
Reviewed-by: prr

! src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/InputImageTests.java
! src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/OutputImageTests.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameBorder.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameDockIconUI.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java
! src/java.desktop/macosx/classes/sun/font/CFontManager.java
! src/java.desktop/share/classes/com/sun/imageio/plugins/gif/GIFMetadata.java
! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFImageMetadata.java
! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
! src/java.desktop/share/classes/java/awt/FileDialog.java
! src/java.desktop/share/classes/java/awt/TextComponent.java
! src/java.desktop/share/classes/java/beans/EventHandler.java
! src/java.desktop/share/classes/javax/swing/JEditorPane.java
! src/java.desktop/share/classes/javax/swing/SwingUtilities.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicButtonUI.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicToggleButtonUI.java
! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicToolTipUI.java
! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalButtonUI.java
! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalToggleButtonUI.java
! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalToolTipUI.java
! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthButtonUI.java
! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLabelUI.java
! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java
! src/java.desktop/share/classes/javax/swing/text/html/FormView.java
! src/java.desktop/share/classes/javax/swing/text/html/FrameView.java
! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java
! src/java.desktop/share/classes/sun/awt/DebugSettings.java
! src/java.desktop/share/classes/sun/awt/im/ExecutableInputMethodManager.java
! src/java.desktop/share/classes/sun/awt/im/InputContext.java
! src/java.desktop/share/classes/sun/font/SunFontManager.java
! src/java.desktop/share/classes/sun/print/PSPrinterJob.java
! src/java.desktop/share/classes/sun/print/PSStreamPrintJob.java
! src/java.desktop/share/classes/sun/print/PSStreamPrintService.java
! src/java.desktop/share/classes/sun/print/PrintJob2D.java
! src/java.desktop/share/classes/sun/print/ServiceDialog.java
! src/java.desktop/share/classes/sun/swing/MenuItemLayoutHelper.java
! src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
! src/java.desktop/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java
! src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java
! src/java.desktop/unix/classes/sun/awt/X11/XFileDialogPeer.java
! src/java.desktop/unix/classes/sun/awt/X11/XPopupMenuPeer.java
! src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java
! src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java
! src/java.desktop/unix/classes/sun/awt/X11InputMethodBase.java
! src/java.desktop/unix/classes/sun/font/FontConfigManager.java
! src/java.desktop/unix/classes/sun/print/IPPPrintService.java
! src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java
! src/java.desktop/unix/classes/sun/print/UnixPrintJob.java
! src/java.desktop/unix/classes/sun/print/UnixPrintService.java
! src/java.desktop/windows/classes/sun/java2d/windows/WindowsFlags.java
! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
! src/java.desktop/windows/classes/sun/print/Win32PrintJob.java
! src/java.desktop/windows/classes/sun/print/Win32PrintService.java

Changeset: fa917627b17b
Author:    jdv
Date:      2019-05-08 11:59 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fa917627b17b

Merge

- test/hotspot/gtest/oops/test_markOop.cpp

Changeset: 442e683e65fa
Author:    serb
Date:      2019-05-08 14:34 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/442e683e65fa

7141393: [macosx] CARemoteLayer code refactoring and unit test
Reviewed-by: dmarkov, jdv

! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m
! src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLGraphicsConfig.h
! src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLGraphicsConfig.m
! src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLLayer.h
! src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLLayer.m
! src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLSurfaceData.m

Changeset: 631c31a5bf40
Author:    serb
Date:      2019-05-08 16:19 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/631c31a5bf40

8144125: [macOS] java/awt/event/ComponentEvent/MovedResizedTwiceTest/MovedResizedTwiceTest.java failed automatically
Reviewed-by: dmarkov

! src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java
! test/jdk/java/awt/event/ComponentEvent/MovedResizedTwiceTest/MovedResizedTwiceTest.java

Changeset: bcfedddcf4ce
Author:    itakiguchi
Date:      2019-05-08 22:59 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bcfedddcf4ce

8211826: StringIndexOutOfBoundsException happens via GetStringUTFRegion()
Reviewed-by: serb

! src/java.desktop/unix/native/libawt_xawt/awt/awt_UNIXToolkit.c
! src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c
+ test/jdk/java/awt/Gtk/GtkJNITest/GtkIconTest.java

Changeset: da3834261f0c
Author:    prr
Date:      2019-05-09 16:09 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/da3834261f0c

8222362: Upgrade to Freetype 2.10.0
Reviewed-by: serb, erikj

! make/lib/Awt2dLibraries.gmk
! src/java.desktop/share/legal/freetype.md
! src/java.desktop/share/native/libfreetype/UPDATING.txt
! src/java.desktop/share/native/libfreetype/include/freetype/config/ftconfig.h
! src/java.desktop/share/native/libfreetype/include/freetype/config/ftheader.h
! src/java.desktop/share/native/libfreetype/include/freetype/config/ftmodule.h
! src/java.desktop/share/native/libfreetype/include/freetype/config/ftoption.h
! src/java.desktop/share/native/libfreetype/include/freetype/config/ftstdlib.h
! src/java.desktop/share/native/libfreetype/include/freetype/freetype.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftadvanc.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftbbox.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftbdf.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftbitmap.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftchapters.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftcid.h
+ src/java.desktop/share/native/libfreetype/include/freetype/ftcolor.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftdriver.h
! src/java.desktop/share/native/libfreetype/include/freetype/fterrdef.h
! src/java.desktop/share/native/libfreetype/include/freetype/fterrors.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftfntfmt.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftgasp.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftglyph.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftgzip.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftimage.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftincrem.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftlcdfil.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftlist.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftmac.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftmm.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftmodapi.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftmoderr.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftoutln.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftparams.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftrender.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftsizes.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftsnames.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftstroke.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftsynth.h
! src/java.desktop/share/native/libfreetype/include/freetype/ftsystem.h
! src/java.desktop/share/native/libfreetype/include/freetype/fttrigon.h
! src/java.desktop/share/native/libfreetype/include/freetype/fttypes.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/autohint.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/cffotypes.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/cfftypes.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftcalc.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftdebug.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftdrv.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftgloadr.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/fthash.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftmemory.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftobjs.h
- src/java.desktop/share/native/libfreetype/include/freetype/internal/ftpic.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftpsprop.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftrfork.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftserv.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftstream.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/fttrace.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/ftvalid.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/internal.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/psaux.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/pshints.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svbdf.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svcfftl.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svcid.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svfntfmt.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svgldict.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svgxval.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svkern.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svmetric.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svmm.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svotval.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svpfr.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svpostnm.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svprop.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svpscmap.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svpsinfo.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svsfnt.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svttcmap.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svtteng.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svttglyf.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/services/svwinfnt.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/sfnt.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/t1types.h
! src/java.desktop/share/native/libfreetype/include/freetype/internal/tttypes.h
! src/java.desktop/share/native/libfreetype/include/freetype/t1tables.h
! src/java.desktop/share/native/libfreetype/include/freetype/ttnameid.h
! src/java.desktop/share/native/libfreetype/include/freetype/tttables.h
! src/java.desktop/share/native/libfreetype/include/freetype/tttags.h
! src/java.desktop/share/native/libfreetype/include/ft2build.h
! src/java.desktop/share/native/libfreetype/src/autofit/afangles.c
! src/java.desktop/share/native/libfreetype/src/autofit/afangles.h
! src/java.desktop/share/native/libfreetype/src/autofit/afblue.c
! src/java.desktop/share/native/libfreetype/src/autofit/afblue.cin
! src/java.desktop/share/native/libfreetype/src/autofit/afblue.dat
! src/java.desktop/share/native/libfreetype/src/autofit/afblue.h
! src/java.desktop/share/native/libfreetype/src/autofit/afblue.hin
! src/java.desktop/share/native/libfreetype/src/autofit/afcjk.c
! src/java.desktop/share/native/libfreetype/src/autofit/afcjk.h
! src/java.desktop/share/native/libfreetype/src/autofit/afcover.h
! src/java.desktop/share/native/libfreetype/src/autofit/afdummy.c
! src/java.desktop/share/native/libfreetype/src/autofit/afdummy.h
! src/java.desktop/share/native/libfreetype/src/autofit/aferrors.h
! src/java.desktop/share/native/libfreetype/src/autofit/afglobal.c
! src/java.desktop/share/native/libfreetype/src/autofit/afglobal.h
! src/java.desktop/share/native/libfreetype/src/autofit/afhints.c
! src/java.desktop/share/native/libfreetype/src/autofit/afhints.h
! src/java.desktop/share/native/libfreetype/src/autofit/afindic.c
! src/java.desktop/share/native/libfreetype/src/autofit/afindic.h
! src/java.desktop/share/native/libfreetype/src/autofit/aflatin.c
! src/java.desktop/share/native/libfreetype/src/autofit/aflatin.h
! src/java.desktop/share/native/libfreetype/src/autofit/afloader.c
! src/java.desktop/share/native/libfreetype/src/autofit/afloader.h
! src/java.desktop/share/native/libfreetype/src/autofit/afmodule.c
! src/java.desktop/share/native/libfreetype/src/autofit/afmodule.h
- src/java.desktop/share/native/libfreetype/src/autofit/afpic.c
- src/java.desktop/share/native/libfreetype/src/autofit/afpic.h
! src/java.desktop/share/native/libfreetype/src/autofit/afranges.c
! src/java.desktop/share/native/libfreetype/src/autofit/afranges.h
! src/java.desktop/share/native/libfreetype/src/autofit/afscript.h
! src/java.desktop/share/native/libfreetype/src/autofit/afshaper.c
! src/java.desktop/share/native/libfreetype/src/autofit/afshaper.h
! src/java.desktop/share/native/libfreetype/src/autofit/afstyles.h
! src/java.desktop/share/native/libfreetype/src/autofit/aftypes.h
! src/java.desktop/share/native/libfreetype/src/autofit/afwarp.c
! src/java.desktop/share/native/libfreetype/src/autofit/afwarp.h
! src/java.desktop/share/native/libfreetype/src/autofit/afwrtsys.h
- src/java.desktop/share/native/libfreetype/src/base/basepic.c
- src/java.desktop/share/native/libfreetype/src/base/basepic.h
! src/java.desktop/share/native/libfreetype/src/base/ftadvanc.c
- src/java.desktop/share/native/libfreetype/src/base/ftapi.c
! src/java.desktop/share/native/libfreetype/src/base/ftbase.h
! src/java.desktop/share/native/libfreetype/src/base/ftbbox.c
! src/java.desktop/share/native/libfreetype/src/base/ftbitmap.c
! src/java.desktop/share/native/libfreetype/src/base/ftcalc.c
! src/java.desktop/share/native/libfreetype/src/base/ftcid.c
! src/java.desktop/share/native/libfreetype/src/base/ftdbgmem.c
! src/java.desktop/share/native/libfreetype/src/base/ftdebug.c
! src/java.desktop/share/native/libfreetype/src/base/ftfntfmt.c
! src/java.desktop/share/native/libfreetype/src/base/ftfstype.c
! src/java.desktop/share/native/libfreetype/src/base/ftgasp.c
! src/java.desktop/share/native/libfreetype/src/base/ftgloadr.c
! src/java.desktop/share/native/libfreetype/src/base/ftglyph.c
! src/java.desktop/share/native/libfreetype/src/base/fthash.c
! src/java.desktop/share/native/libfreetype/src/base/ftinit.c
! src/java.desktop/share/native/libfreetype/src/base/ftlcdfil.c
! src/java.desktop/share/native/libfreetype/src/base/ftmac.c
! src/java.desktop/share/native/libfreetype/src/base/ftmm.c
! src/java.desktop/share/native/libfreetype/src/base/ftobjs.c
! src/java.desktop/share/native/libfreetype/src/base/ftoutln.c
! src/java.desktop/share/native/libfreetype/src/base/ftpatent.c
- src/java.desktop/share/native/libfreetype/src/base/ftpic.c
! src/java.desktop/share/native/libfreetype/src/base/ftpsprop.c
! src/java.desktop/share/native/libfreetype/src/base/ftrfork.c
! src/java.desktop/share/native/libfreetype/src/base/ftsnames.c
! src/java.desktop/share/native/libfreetype/src/base/ftstream.c
! src/java.desktop/share/native/libfreetype/src/base/ftstroke.c
! src/java.desktop/share/native/libfreetype/src/base/ftsynth.c
! src/java.desktop/share/native/libfreetype/src/base/ftsystem.c
! src/java.desktop/share/native/libfreetype/src/base/fttrigon.c
! src/java.desktop/share/native/libfreetype/src/base/fttype1.c
! src/java.desktop/share/native/libfreetype/src/base/ftutil.c
- src/java.desktop/share/native/libfreetype/src/base/md5.c
- src/java.desktop/share/native/libfreetype/src/base/md5.h
! src/java.desktop/share/native/libfreetype/src/cff/cffcmap.c
! src/java.desktop/share/native/libfreetype/src/cff/cffcmap.h
! src/java.desktop/share/native/libfreetype/src/cff/cffdrivr.c
! src/java.desktop/share/native/libfreetype/src/cff/cffdrivr.h
! src/java.desktop/share/native/libfreetype/src/cff/cfferrs.h
! src/java.desktop/share/native/libfreetype/src/cff/cffgload.c
! src/java.desktop/share/native/libfreetype/src/cff/cffgload.h
! src/java.desktop/share/native/libfreetype/src/cff/cffload.c
! src/java.desktop/share/native/libfreetype/src/cff/cffload.h
! src/java.desktop/share/native/libfreetype/src/cff/cffobjs.c
! src/java.desktop/share/native/libfreetype/src/cff/cffobjs.h
! src/java.desktop/share/native/libfreetype/src/cff/cffparse.c
! src/java.desktop/share/native/libfreetype/src/cff/cffparse.h
- src/java.desktop/share/native/libfreetype/src/cff/cffpic.c
- src/java.desktop/share/native/libfreetype/src/cff/cffpic.h
! src/java.desktop/share/native/libfreetype/src/cff/cfftoken.h
! src/java.desktop/share/native/libfreetype/src/cid/ciderrs.h
! src/java.desktop/share/native/libfreetype/src/cid/cidgload.c
! src/java.desktop/share/native/libfreetype/src/cid/cidgload.h
! src/java.desktop/share/native/libfreetype/src/cid/cidload.c
! src/java.desktop/share/native/libfreetype/src/cid/cidload.h
! src/java.desktop/share/native/libfreetype/src/cid/cidobjs.c
! src/java.desktop/share/native/libfreetype/src/cid/cidobjs.h
! src/java.desktop/share/native/libfreetype/src/cid/cidparse.c
! src/java.desktop/share/native/libfreetype/src/cid/cidparse.h
! src/java.desktop/share/native/libfreetype/src/cid/cidriver.c
! src/java.desktop/share/native/libfreetype/src/cid/cidriver.h
! src/java.desktop/share/native/libfreetype/src/cid/cidtoken.h
! src/java.desktop/share/native/libfreetype/src/psaux/afmparse.c
! src/java.desktop/share/native/libfreetype/src/psaux/afmparse.h
! src/java.desktop/share/native/libfreetype/src/psaux/cffdecode.c
! src/java.desktop/share/native/libfreetype/src/psaux/cffdecode.h
! src/java.desktop/share/native/libfreetype/src/psaux/psarrst.c
! src/java.desktop/share/native/libfreetype/src/psaux/psarrst.h
! src/java.desktop/share/native/libfreetype/src/psaux/psauxerr.h
! src/java.desktop/share/native/libfreetype/src/psaux/psauxmod.c
! src/java.desktop/share/native/libfreetype/src/psaux/psauxmod.h
! src/java.desktop/share/native/libfreetype/src/psaux/psblues.c
! src/java.desktop/share/native/libfreetype/src/psaux/psblues.h
! src/java.desktop/share/native/libfreetype/src/psaux/psconv.c
! src/java.desktop/share/native/libfreetype/src/psaux/psconv.h
! src/java.desktop/share/native/libfreetype/src/psaux/pserror.c
! src/java.desktop/share/native/libfreetype/src/psaux/pserror.h
! src/java.desktop/share/native/libfreetype/src/psaux/psfixed.h
! src/java.desktop/share/native/libfreetype/src/psaux/psfont.c
! src/java.desktop/share/native/libfreetype/src/psaux/psfont.h
! src/java.desktop/share/native/libfreetype/src/psaux/psft.c
! src/java.desktop/share/native/libfreetype/src/psaux/psft.h
! src/java.desktop/share/native/libfreetype/src/psaux/psglue.h
! src/java.desktop/share/native/libfreetype/src/psaux/pshints.c
! src/java.desktop/share/native/libfreetype/src/psaux/pshints.h
! src/java.desktop/share/native/libfreetype/src/psaux/psintrp.c
! src/java.desktop/share/native/libfreetype/src/psaux/psintrp.h
! src/java.desktop/share/native/libfreetype/src/psaux/psobjs.c
! src/java.desktop/share/native/libfreetype/src/psaux/psobjs.h
! src/java.desktop/share/native/libfreetype/src/psaux/psread.c
! src/java.desktop/share/native/libfreetype/src/psaux/psread.h
! src/java.desktop/share/native/libfreetype/src/psaux/psstack.c
! src/java.desktop/share/native/libfreetype/src/psaux/psstack.h
! src/java.desktop/share/native/libfreetype/src/psaux/pstypes.h
! src/java.desktop/share/native/libfreetype/src/psaux/t1cmap.c
! src/java.desktop/share/native/libfreetype/src/psaux/t1cmap.h
! src/java.desktop/share/native/libfreetype/src/psaux/t1decode.c
! src/java.desktop/share/native/libfreetype/src/psaux/t1decode.h
! src/java.desktop/share/native/libfreetype/src/pshinter/pshalgo.c
! src/java.desktop/share/native/libfreetype/src/pshinter/pshalgo.h
! src/java.desktop/share/native/libfreetype/src/pshinter/pshglob.c
! src/java.desktop/share/native/libfreetype/src/pshinter/pshglob.h
! src/java.desktop/share/native/libfreetype/src/pshinter/pshmod.c
! src/java.desktop/share/native/libfreetype/src/pshinter/pshmod.h
! src/java.desktop/share/native/libfreetype/src/pshinter/pshnterr.h
- src/java.desktop/share/native/libfreetype/src/pshinter/pshpic.c
- src/java.desktop/share/native/libfreetype/src/pshinter/pshpic.h
! src/java.desktop/share/native/libfreetype/src/pshinter/pshrec.c
! src/java.desktop/share/native/libfreetype/src/pshinter/pshrec.h
! src/java.desktop/share/native/libfreetype/src/psnames/psmodule.c
! src/java.desktop/share/native/libfreetype/src/psnames/psmodule.h
! src/java.desktop/share/native/libfreetype/src/psnames/psnamerr.h
- src/java.desktop/share/native/libfreetype/src/psnames/pspic.c
- src/java.desktop/share/native/libfreetype/src/psnames/pspic.h
! src/java.desktop/share/native/libfreetype/src/psnames/pstables.h
! src/java.desktop/share/native/libfreetype/src/raster/ftmisc.h
! src/java.desktop/share/native/libfreetype/src/raster/ftraster.c
! src/java.desktop/share/native/libfreetype/src/raster/ftraster.h
! src/java.desktop/share/native/libfreetype/src/raster/ftrend1.c
! src/java.desktop/share/native/libfreetype/src/raster/ftrend1.h
! src/java.desktop/share/native/libfreetype/src/raster/rasterrs.h
- src/java.desktop/share/native/libfreetype/src/raster/rastpic.c
- src/java.desktop/share/native/libfreetype/src/raster/rastpic.h
! src/java.desktop/share/native/libfreetype/src/sfnt/pngshim.c
! src/java.desktop/share/native/libfreetype/src/sfnt/pngshim.h
! src/java.desktop/share/native/libfreetype/src/sfnt/sfdriver.c
! src/java.desktop/share/native/libfreetype/src/sfnt/sfdriver.h
! src/java.desktop/share/native/libfreetype/src/sfnt/sferrors.h
- src/java.desktop/share/native/libfreetype/src/sfnt/sfntpic.c
- src/java.desktop/share/native/libfreetype/src/sfnt/sfntpic.h
! src/java.desktop/share/native/libfreetype/src/sfnt/sfobjs.c
! src/java.desktop/share/native/libfreetype/src/sfnt/sfobjs.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttcmap.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttcmap.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttcmapc.h
+ src/java.desktop/share/native/libfreetype/src/sfnt/ttcolr.c
+ src/java.desktop/share/native/libfreetype/src/sfnt/ttcolr.h
+ src/java.desktop/share/native/libfreetype/src/sfnt/ttcpal.c
+ src/java.desktop/share/native/libfreetype/src/sfnt/ttcpal.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttkern.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttkern.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttload.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttload.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttmtx.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttmtx.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttpost.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttpost.h
! src/java.desktop/share/native/libfreetype/src/sfnt/ttsbit.c
! src/java.desktop/share/native/libfreetype/src/sfnt/ttsbit.h
! src/java.desktop/share/native/libfreetype/src/smooth/ftgrays.c
! src/java.desktop/share/native/libfreetype/src/smooth/ftgrays.h
! src/java.desktop/share/native/libfreetype/src/smooth/ftsmerrs.h
! src/java.desktop/share/native/libfreetype/src/smooth/ftsmooth.c
! src/java.desktop/share/native/libfreetype/src/smooth/ftsmooth.h
- src/java.desktop/share/native/libfreetype/src/smooth/ftspic.c
- src/java.desktop/share/native/libfreetype/src/smooth/ftspic.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttdriver.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttdriver.h
! src/java.desktop/share/native/libfreetype/src/truetype/tterrors.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttgload.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttgload.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttgxvar.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttgxvar.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttinterp.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttinterp.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttobjs.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttobjs.h
- src/java.desktop/share/native/libfreetype/src/truetype/ttpic.c
- src/java.desktop/share/native/libfreetype/src/truetype/ttpic.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttpload.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttpload.h
! src/java.desktop/share/native/libfreetype/src/truetype/ttsubpix.c
! src/java.desktop/share/native/libfreetype/src/truetype/ttsubpix.h
! src/java.desktop/share/native/libfreetype/src/type1/t1afm.c
! src/java.desktop/share/native/libfreetype/src/type1/t1afm.h
! src/java.desktop/share/native/libfreetype/src/type1/t1driver.c
! src/java.desktop/share/native/libfreetype/src/type1/t1driver.h
! src/java.desktop/share/native/libfreetype/src/type1/t1errors.h
! src/java.desktop/share/native/libfreetype/src/type1/t1gload.c
! src/java.desktop/share/native/libfreetype/src/type1/t1gload.h
! src/java.desktop/share/native/libfreetype/src/type1/t1load.c
! src/java.desktop/share/native/libfreetype/src/type1/t1load.h
! src/java.desktop/share/native/libfreetype/src/type1/t1objs.c
! src/java.desktop/share/native/libfreetype/src/type1/t1objs.h
! src/java.desktop/share/native/libfreetype/src/type1/t1parse.c
! src/java.desktop/share/native/libfreetype/src/type1/t1parse.h
! src/java.desktop/share/native/libfreetype/src/type1/t1tokens.h

Changeset: dde07ac16610
Author:    prr
Date:      2019-05-10 16:22 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dde07ac16610

8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit
Reviewed-by: serb, rriggs

! src/java.base/share/classes/jdk/internal/util/SystemProps.java
! src/java.base/share/native/libjava/System.c
! src/java.base/share/native/libjava/java_props.h
! src/java.base/unix/native/libjava/java_props_md.c
! src/java.base/windows/native/libjava/java_props_md.c
! src/java.desktop/macosx/classes/sun/awt/PlatformGraphicsInfo.java
! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java
! src/java.desktop/share/classes/java/awt/Toolkit.java
! src/java.desktop/unix/classes/sun/awt/PlatformGraphicsInfo.java
! src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java
! src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java
! src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java
+ test/jdk/java/awt/Toolkit/ToolkitPropertyTest/CheckToolkitSystemProperty.java

Changeset: b267b838272f
Author:    psadhukhan
Date:      2019-05-14 11:23 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b267b838272f

Merge

- make/data/cldr/common/main/ff_CM.xml
- make/data/cldr/common/main/ff_GN.xml
- make/data/cldr/common/main/ff_MR.xml
- make/data/cldr/common/main/ff_SN.xml
- make/data/cldr/common/main/yue_HK.xml
- make/data/cldr/common/supplemental/telephoneCodeData.xml
- src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
- src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.hpp
- src/hotspot/share/gc/shenandoah/shenandoahBrooksPointer.inline.hpp
! test/jdk/ProblemList.txt

Changeset: f5c0793f2dc1
Author:    psadhukhan
Date:      2019-05-15 13:54 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f5c0793f2dc1

Merge

- src/hotspot/share/gc/g1/g1InCSetState.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.cpp
- src/hotspot/share/gc/z/zPreMappedMemory.hpp
- src/hotspot/share/gc/z/zPreMappedMemory.inline.hpp
- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPhysicalMemoryManager.java

Changeset: b0b20413d853
Author:    shade
Date:      2019-05-15 11:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b0b20413d853

8223911: Disable bad node budget verification until the fix
Reviewed-by: kvn, thartmann

! src/hotspot/share/opto/loopnode.hpp

Changeset: 80991d58b947
Author:    thartmann
Date:      2019-05-15 14:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/80991d58b947

8223885: hs_err and replay file may contain garbage when overwriting existing file
Summary: Truncate file before overwriting.
Reviewed-by: stuefe, dholmes

! src/hotspot/share/utilities/vmError.cpp
! test/hotspot/jtreg/ProblemList.txt

Changeset: b99e97bc5040
Author:    zgu
Date:      2019-05-15 08:58 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b99e97bc5040

8223215: Shenandoah: Support verifying subset of roots
Reviewed-by: shade, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp
+ src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp

Changeset: 4ee117b890c5
Author:    aeubanks
Date:      2019-05-10 17:13 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4ee117b890c5

8223737: Fix HostsFileNameService for IPv6 literal addresses
Reviewed-by: chegar, msheppar
Contributed-by: aeubanks at google.com

! src/java.base/share/classes/java/net/InetAddress.java
! test/jdk/java/net/InetAddress/InternalNameServiceWithHostsFileTest.java

Changeset: 8a6093c186a6
Author:    amenkov
Date:      2019-05-15 11:06 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8a6093c186a6

8184770: JDWP support for IPv6
Reviewed-by: sspitsyn, chegar

! src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketListeningConnector.java
! src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java
! src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
! src/jdk.jdwp.agent/share/native/libdt_socket/sysSocket.h
! src/jdk.jdwp.agent/unix/native/libdt_socket/socket_md.c
! src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c
! test/hotspot/jtreg/vmTestbase/nsk/jdi/ListeningConnector/startListening/startlis001.java
- test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java
+ test/jdk/com/sun/jdi/JdwpAllowTest.java
+ test/jdk/com/sun/jdi/JdwpAttachTest.java
+ test/jdk/com/sun/jdi/JdwpListenTest.java
+ test/jdk/com/sun/jdi/JdwpNetProps.java

Changeset: e58e454c1409
Author:    dfuchs
Date:      2019-05-15 19:09 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e58e454c1409

8223716: sun/net/www/http/HttpClient/MultiThreadTest.java should be more resilient to unexpected traffic
Reviewed-by: chegar

! test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java

Changeset: 4dd7ea5f28cf
Author:    dfuchs
Date:      2019-05-15 19:34 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4dd7ea5f28cf

8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work with IPv6 addresses
Summary: This fix updates three tests: sun/net/ftp/FtpURL.java, sun/net/ftp/FtpURLConnectionLeak.java, and sun/net/ftp/FtpGetContent.java, to work with IPv6 addresses
Reviewed-by: chegar, aeubanks, vtewari

! test/jdk/sun/net/ftp/FtpGetContent.java
! test/jdk/sun/net/ftp/FtpURL.java
! test/jdk/sun/net/ftp/FtpURLConnectionLeak.java

Changeset: 442e22c051f0
Author:    aefimov
Date:      2019-05-15 19:47 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/442e22c051f0

8223798: Replace wildcard address with loopback or local host in tests - part 7
Reviewed-by: dfuchs, vtewari

! test/jdk/java/net/Socket/DeadlockTest.java
! test/jdk/java/net/Socket/SocketGrowth.java
! test/jdk/java/net/Socket/asyncClose/DatagramSocket_receive.java
! test/jdk/java/net/Socket/asyncClose/Socket_getInputStream_read.java
! test/jdk/java/net/Socket/asyncClose/Socket_getOutputStream_write.java
! test/jdk/java/net/URLConnection/HttpContinueStackOverflow.java
! test/jdk/java/net/URLConnection/ResendPostBody.java
! test/jdk/sun/net/ftp/MarkResetTest.java
! test/jdk/sun/net/www/http/ChunkedOutputStream/Test.java
! test/jdk/sun/net/www/protocol/http/B6518816.java
! test/jdk/sun/net/www/protocol/http/ProxyTunnelServer.java
! test/jdk/sun/net/www/protocol/http/TunnelThroughProxy.java

Changeset: 2c19c55a289a
Author:    rhalade
Date:      2019-05-15 13:22 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2c19c55a289a

8222136: Remove two Comodo root CA certificates that are expiring
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 53d51822f287
Author:    aeubanks
Date:      2019-05-07 16:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/53d51822f287

8223532: Don't try creating IPv4 sockets in NetworkInterface.c if IPv4 is not supported
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! src/java.base/unix/native/libnet/NetworkInterface.c

Changeset: f2f11d7f7f4e
Author:    shade
Date:      2019-05-15 22:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f2f11d7f7f4e

8223980: Shenandoah: Refactor and fix ObjArrayChunkedTask verification
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp

Changeset: 2b5b666f26a6
Author:    jwilhelm
Date:      2019-05-16 02:34 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2b5b666f26a6

Added tag jdk-13+21 for changeset f2f11d7f7f4e

! .hgtags

Changeset: eedc3db527ac
Author:    coleenp
Date:      2019-05-15 20:33 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/eedc3db527ac

8224010: Incorrect string interning
Summary: Revert jvmci change
Reviewed-by: dholmes, jiangli

! src/hotspot/share/jvmci/compilerRuntime.cpp

Changeset: 3e1ecfd3ea18
Author:    rschmelter
Date:      2019-05-13 07:41 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3e1ecfd3ea18

8223770: code_size2 still too small in some compressed oops configurations
Reviewed-by: mdoerr, stuefe

! src/hotspot/cpu/x86/stubRoutines_x86.hpp

Changeset: 382101e97784
Author:    jlahoda
Date:      2019-05-16 10:52 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/382101e97784

8222169: java.lang.AssertionError switch expression in ternary operator - ?
Summary: Ensure the stack size recoded at the begining of the let expression is the correct one.
Reviewed-by: vromero
Contributed-by: vicente.romero at oracle.com, jan.lahoda at oracle.com

! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java
+ test/langtools/tools/javac/T8222795/ConditionalAndPostfixOperator.java
! test/langtools/tools/javac/switchexpr/ExpressionSwitch-old.out
! test/langtools/tools/javac/switchexpr/ExpressionSwitch.java

Changeset: 4f1f939d8f5d
Author:    pmuthuswamy
Date:      2019-05-16 16:40 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4f1f939d8f5d

8222548: Upgrading JDK 13 with the latest available jQuery 3.4.1
Reviewed-by: hannesw

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/external/jquery/jquery.js
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.3.1.js
+ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.4.1.js
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-migrate-3.0.1.js
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java
- src/jdk.javadoc/share/legal/jquery-migrate.md
! src/jdk.javadoc/share/legal/jquery.md
! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java
! test/langtools/jdk/javadoc/tool/api/basic/APITest.java

Changeset: ea619918de95
Author:    coleenp
Date:      2019-05-16 07:09 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ea619918de95

8223956: Make SymbolTable and StringTable AllStatic
Summary: Removed superfluous and confusing _the_table pointer.
Reviewed-by: gziemski, rehn

! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/stringTable.hpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/symbolTable.hpp
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/hotspot/share/prims/resolvedMethodTable.cpp
! src/hotspot/share/prims/resolvedMethodTable.hpp

Changeset: 2e5e9d31a6c5
Author:    stuefe
Date:      2019-05-16 13:57 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2e5e9d31a6c5

8224023: Redo the fix for ErrorFile option does not handle pre-existing error files of the same name
Reviewed-by: clanger, dholmes

! src/hotspot/share/utilities/vmError.cpp

Changeset: 17926213de55
Author:    rrich
Date:      2019-05-15 12:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/17926213de55

8223572: ~ThreadInVMForHandshake() should call handle_special_runtime_exit_condition()
Reviewed-by: dcubed, rehn, dholmes

! src/hotspot/share/runtime/interfaceSupport.inline.hpp

Changeset: e4cff3cf0234
Author:    mbaesken
Date:      2019-05-16 09:21 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e4cff3cf0234

8223438: add VirtualizationInformation JFR event
Reviewed-by: clanger, egahlin

! src/hotspot/cpu/ppc/vm_version_ppc.cpp
! src/hotspot/cpu/ppc/vm_version_ppc.hpp
! src/hotspot/share/jfr/metadata/metadata.xml
! src/hotspot/share/jfr/periodic/jfrOSInterface.cpp
! src/hotspot/share/jfr/periodic/jfrOSInterface.hpp
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/hotspot/share/runtime/vm_version.hpp
! src/jdk.jfr/share/conf/jfr/default.jfc
! src/jdk.jfr/share/conf/jfr/profile.jfc
+ test/jdk/jdk/jfr/event/os/TestVirtualizationInfo.java
! test/lib/jdk/test/lib/jfr/EventNames.java

Changeset: e9f5e06a0dd7
Author:    jlahoda
Date:      2019-05-16 16:42 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e9f5e06a0dd7

8224031: Cannot parse switch expressions after type cast
Summary: Correctly categorize parentheses followed by the switch keyword as cast.
Reviewed-by: mcimadamore

! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
! test/langtools/tools/javac/switchexpr/ExpressionSwitch-old.out
! test/langtools/tools/javac/switchexpr/ExpressionSwitch.java

Changeset: 631d51796dbf
Author:    coleenp
Date:      2019-05-16 11:07 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/631d51796dbf

8223585: vmTestbase/runtime/pcl/* get SEGV in MetadataOnStackClosure::do_metadata(Metadata*)+0x0
Summary: adjust old method table by only one thread.
Reviewed-by: kvn, jcbeyler, sspitsyn

! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/nmethod.cpp

Changeset: d1717e05e51c
Author:    alanb
Date:      2019-05-16 17:06 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d1717e05e51c

8223442: java/nio/channels/SocketChannel/AdaptorStreams.java testConcurrentTimedReadWrite3(): failure
Reviewed-by: michaelm

! src/java.base/windows/classes/sun/nio/ch/DatagramDispatcher.java
! src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java
! src/java.base/windows/native/libnio/ch/Net.c
! src/java.base/windows/native/libnio/ch/SocketDispatcher.c
! test/jdk/java/nio/channels/SocketChannel/AdaptorStreams.java

Changeset: 5a211ee83bf1
Author:    aeubanks
Date:      2019-05-15 17:13 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5a211ee83bf1

8224018: test/jdk/java/net/ipv6tests/{Tcp,Udp}Test.java assume IPv4 is available
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! test/jdk/java/net/ipv6tests/TcpTest.java
! test/jdk/java/net/ipv6tests/UdpTest.java

Changeset: c1143a0d4e22
Author:    adinn
Date:      2019-05-16 15:45 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c1143a0d4e22

8224042: Add private alignDown method to MappedByteBuffer
Summary: Use alignDown method to round addresses down to page boundary
Reviewed-by: stuefe, mikael, alanb

! src/java.base/share/classes/java/nio/MappedByteBuffer.java

Changeset: d43cc2039ccf
Author:    rkennke
Date:      2019-05-16 19:07 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d43cc2039ccf

8224043: Shenandoah: Remove clear_claimed_marks() from start of concurrent_traversal()
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: b6ee58ec8814
Author:    vromero
Date:      2019-05-16 13:34 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b6ee58ec8814

8223726: j.l.c.MethodTypeDesc spec should contain precise assertions for one parameter's methods
Reviewed-by: darcy

! src/java.base/share/classes/java/lang/constant/MethodHandleDesc.java
! src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java
! test/jdk/java/lang/constant/MethodHandleDescTest.java
! test/jdk/java/lang/constant/MethodTypeDescTest.java

Changeset: 6bcda7ed24ef
Author:    dtitov
Date:      2019-05-16 11:37 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6bcda7ed24ef

8222422: vmTestbase/nsk/jdi/ClassLoaderReference/definedClasses tests failed with Unexpected Exception: null
Reviewed-by: dholmes, jcbeyler, cjplummer

! src/jdk.jdi/share/classes/com/sun/tools/jdi/ClassLoaderReferenceImpl.java
! src/jdk.jdi/share/classes/com/sun/tools/jdi/ClassTypeImpl.java
! src/jdk.jdi/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java
! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java
! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java

Changeset: 717c4a905f62
Author:    epavlova
Date:      2019-05-16 11:30 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/717c4a905f62

8223910: TestFloatJNIArgs and TestTrichotomyExpressions time out with Graal as JIT
Reviewed-by: thartmann

! test/hotspot/jtreg/ProblemList-graal.txt
! test/hotspot/jtreg/compiler/floatingpoint/TestFloatJNIArgs.java

Changeset: c107322c28b0
Author:    rhalade
Date:      2019-05-16 12:36 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c107322c28b0

8223499: Remove two DocuSign root certificates that are expiring
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 361bd0fb9390
Author:    shade
Date:      2019-05-16 21:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/361bd0fb9390

8224033: os::snprintf should be used in virtualizationSupport.cpp
Reviewed-by: mbaesken, stuefe

! src/hotspot/share/utilities/virtualizationSupport.cpp

Changeset: c5bb50505a65
Author:    jcbeyler
Date:      2019-05-16 12:48 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c5bb50505a65

8224020: AsyncGetCallTrace test should not run on PPC64 or IA64
Summary: Restrict the test to the right architectures
Reviewed-by: cjplummer, sspitsyn, simonis

! test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
! test/hotspot/jtreg/serviceability/AsyncGetCallTrace/libAsyncGetCallTraceTest.cpp

Changeset: c6f2500c1504
Author:    epavlova
Date:      2019-05-16 12:33 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c6f2500c1504

8224017: [Graal] gc/z/TestUncommit.java fails with Graal
Reviewed-by: kvn

! test/hotspot/jtreg/ProblemList-graal.txt
! test/hotspot/jtreg/gc/z/TestUncommit.java

Changeset: 9cfbe22bcdf8
Author:    iignatyev
Date:      2019-05-16 12:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9cfbe22bcdf8

8222154: upgrade gtest to 1.8.1
Reviewed-by: jwilhelm, rwestberg

! make/hotspot/lib/CompileGtest.gmk
+ test/fmw/gtest/CONTRIBUTORS
- test/fmw/gtest/README
+ test/fmw/gtest/README.md
! test/fmw/gtest/include/gtest/gtest-death-test.h
! test/fmw/gtest/include/gtest/gtest-message.h
! test/fmw/gtest/include/gtest/gtest-param-test.h
! test/fmw/gtest/include/gtest/gtest-param-test.h.pump
! test/fmw/gtest/include/gtest/gtest-printers.h
! test/fmw/gtest/include/gtest/gtest-spi.h
! test/fmw/gtest/include/gtest/gtest-test-part.h
! test/fmw/gtest/include/gtest/gtest-typed-test.h
! test/fmw/gtest/include/gtest/gtest.h
! test/fmw/gtest/include/gtest/gtest_pred_impl.h
! test/fmw/gtest/include/gtest/gtest_prod.h
+ test/fmw/gtest/include/gtest/internal/custom/README.md
+ test/fmw/gtest/include/gtest/internal/custom/gtest-port.h
+ test/fmw/gtest/include/gtest/internal/custom/gtest-printers.h
+ test/fmw/gtest/include/gtest/internal/custom/gtest.h
! test/fmw/gtest/include/gtest/internal/gtest-death-test-internal.h
! test/fmw/gtest/include/gtest/internal/gtest-filepath.h
! test/fmw/gtest/include/gtest/internal/gtest-internal.h
! test/fmw/gtest/include/gtest/internal/gtest-linked_ptr.h
! test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h
! test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h.pump
! test/fmw/gtest/include/gtest/internal/gtest-param-util.h
+ test/fmw/gtest/include/gtest/internal/gtest-port-arch.h
! test/fmw/gtest/include/gtest/internal/gtest-port.h
! test/fmw/gtest/include/gtest/internal/gtest-string.h
! test/fmw/gtest/include/gtest/internal/gtest-tuple.h
! test/fmw/gtest/include/gtest/internal/gtest-tuple.h.pump
! test/fmw/gtest/include/gtest/internal/gtest-type-util.h
! test/fmw/gtest/include/gtest/internal/gtest-type-util.h.pump
! test/fmw/gtest/src/gtest-all.cc
! test/fmw/gtest/src/gtest-death-test.cc
! test/fmw/gtest/src/gtest-filepath.cc
! test/fmw/gtest/src/gtest-internal-inl.h
! test/fmw/gtest/src/gtest-port.cc
! test/fmw/gtest/src/gtest-printers.cc
! test/fmw/gtest/src/gtest-test-part.cc
! test/fmw/gtest/src/gtest-typed-test.cc
! test/fmw/gtest/src/gtest.cc
! test/fmw/gtest/src/gtest_main.cc

Changeset: 9feb4852536f
Author:    jwilhelm
Date:      2019-05-17 00:21 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9feb4852536f

8223346: Update Graal
Reviewed-by: kvn

! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64Assembler.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/TwoSlotMarkerClearingTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/spi/Canonicalizable.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/MathDoubleFMATest.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/MathFMAConstantInputTest.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/MathFloatFMATest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1BarrierSet.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/BarrierSet.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/CardTableBarrierSet.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotObjdumpDisassemblerProvider.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierAdditionPhase.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierVerificationPhase.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/UnsafeLoadSnippets.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/FrameStateBuilder.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Ternary.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/ArithmeticLIRGeneratorTool.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/TernaryNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/HeapAccess.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/RootMethodSubstitutionTest.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java
+ src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/FusedMultiplyAddNode.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java
! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/WordOperationPlugin.java

Changeset: 278600885731
Author:    bulasevich
Date:      2019-05-16 18:45 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/278600885731

8222825: ARM32 SIGILL issue on single core CPU (not supported PLDW instruction)
Reviewed-by: dholmes, dlong

! src/hotspot/cpu/arm/arm.ad
! src/hotspot/cpu/arm/assembler_arm_32.hpp
! src/hotspot/cpu/arm/vm_version_arm.hpp
! src/hotspot/cpu/arm/vm_version_arm_32.cpp
! src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp

Changeset: 7136c9ac56a7
Author:    kbarrett
Date:      2019-05-16 20:14 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7136c9ac56a7

8160539: Stack frame scanning acquires DerivedPointerTableGC_lock mutex
Summary: Use lock-free stack for accumulating table entries.
Reviewed-by: tschatzl, kvn

! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/compiler/oopMap.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp

Changeset: 81852d53e585
Author:    ysuenaga
Date:      2019-05-17 14:14 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/81852d53e585

8223665: SA: debugd options should follow jhsdb style
Reviewed-by: dholmes, sspitsyn, ysuenaga, jcbeyler
Contributed-by: Osamu Sakamoto <sakamoto.osamu at nttcom.co.jp>

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java

Changeset: b88bcaa94c10
Author:    mbaesken
Date:      2019-05-16 13:21 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b88bcaa94c10

8223944: fix zlib related building docu and comments
Reviewed-by: alanb, erikj

! doc/building.html
! doc/building.md
! make/autoconf/lib-bundled.m4

Changeset: 21925121a917
Author:    bulasevich
Date:      2019-05-17 03:01 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/21925121a917

8220656: ARM32: -XX:MaxVectorSize=16 makes SIGILL
Reviewed-by: dholmes, dlong

! src/hotspot/cpu/arm/vm_version_arm_32.cpp

Changeset: 6a6935abebe8
Author:    clanger
Date:      2019-05-17 09:00 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6a6935abebe8

8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031
Reviewed-by: lancea

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileAttributeView.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileAttributes.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileStore.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipInfo.java
! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipPath.java

Changeset: be1cbfd81ea1
Author:    bulasevich
Date:      2019-05-17 11:44 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/be1cbfd81ea1

8223472: volatile long field corruption on x86_32
Reviewed-by: eosterlund, dholmes, shade, coleenp

! src/hotspot/cpu/x86/templateTable_x86.cpp

Changeset: 185ffc45593c
Author:    pliden
Date:      2019-05-17 12:06 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/185ffc45593c

8223961: ZGC: Unexpected behaviour due to ZMetronome::wait_for_tick() oversleeping
Reviewed-by: pliden, stefank
Contributed-by: fujie at loongson.cn, per.liden at oracle.com

! src/hotspot/share/gc/z/zMetronome.cpp
! src/hotspot/share/gc/z/zMetronome.hpp
! src/hotspot/share/gc/z/zStat.cpp

Changeset: 23837d614c17
Author:    tschatzl
Date:      2019-05-17 12:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/23837d614c17

8224038: Fix remaining InCSetState mentions
Reviewed-by: kbarrett

! src/hotspot/share/gc/g1/g1CollectedHeap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp
! src/hotspot/share/gc/g1/g1HeapVerifier.cpp
! src/hotspot/share/gc/g1/g1HeapVerifier.hpp

Changeset: ba1eccda5450
Author:    zgu
Date:      2019-05-17 09:52 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ba1eccda5450

8223774: Shenandoah: Refactor ShenandoahRootProcessor and family
Reviewed-by: shade, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 3205f4c40716
Author:    aoqi
Date:      2019-05-16 21:25 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3205f4c40716

8224028: loop initial declarations introduced by JDK-8184770
Reviewed-by: dfuchs, amenkov, sspitsyn

! src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c

Changeset: d4e7ccaf1445
Author:    rriggs
Date:      2019-05-17 10:48 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d4e7ccaf1445

8220166: Performance regression in deserialization (4-6% in SPECjbb)
Reviewed-by: shade, dholmes, alanb

! src/java.base/share/classes/java/io/ObjectInputFilter.java

Changeset: 1512d88b24c6
Author:    ccheung
Date:      2019-05-17 08:29 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1512d88b24c6

8207812: Implement Dynamic CDS Archive
Summary: Improve the usability of AppCDS
Reviewed-by: acorn, jiangli, mseledtsov
Contributed-by: ioi.lam at oracle.com, jianglizhou at google.com, calvin.cheung at oracle.com

! make/hotspot/lib/JvmFeatures.gmk
! src/hotspot/share/classfile/classListParser.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoader.hpp
! src/hotspot/share/classfile/classLoader.inline.hpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/compactHashtable.cpp
! src/hotspot/share/classfile/compactHashtable.hpp
! src/hotspot/share/classfile/dictionary.cpp
! src/hotspot/share/classfile/klassFactory.cpp
! src/hotspot/share/classfile/sharedPathsMiscInfo.cpp
! src/hotspot/share/classfile/sharedPathsMiscInfo.hpp
! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/symbolTable.hpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/classfile/systemDictionaryShared.hpp
! src/hotspot/share/classfile/verificationType.cpp
! src/hotspot/share/include/cds.h
! src/hotspot/share/jfr/recorder/jfrRecorder.cpp
! src/hotspot/share/logging/logTag.hpp
! src/hotspot/share/memory/allocation.hpp
+ src/hotspot/share/memory/dynamicArchive.cpp
+ src/hotspot/share/memory/dynamicArchive.hpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/filemap.hpp
! src/hotspot/share/memory/heapShared.cpp
! src/hotspot/share/memory/heapShared.hpp
! src/hotspot/share/memory/memRegion.cpp
! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/memory/metaspaceClosure.cpp
! src/hotspot/share/memory/metaspaceClosure.hpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/metaspaceShared.hpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/constMethod.hpp
! src/hotspot/share/oops/constantPool.cpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/method.hpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/oops/symbol.hpp
! src/hotspot/share/prims/cdsoffsets.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/arguments.hpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/java.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/thread.cpp
! test/hotspot/jtreg/TEST.groups
! test/hotspot/jtreg/runtime/appcds/AppendClasspath.java
! test/hotspot/jtreg/runtime/appcds/BootClassPathMismatch.java
! test/hotspot/jtreg/runtime/appcds/CDSandJFR.java
! test/hotspot/jtreg/runtime/appcds/CaseSensitiveClassPath.java
! test/hotspot/jtreg/runtime/appcds/CommandLineFlagCombo.java
! test/hotspot/jtreg/runtime/appcds/CommandLineFlagComboNegative.java
! test/hotspot/jtreg/runtime/appcds/DirClasspathTest.java
! test/hotspot/jtreg/runtime/appcds/JvmtiAddPath.java
! test/hotspot/jtreg/runtime/appcds/LotsOfClasses.java
! test/hotspot/jtreg/runtime/appcds/PackageSealing.java
! test/hotspot/jtreg/runtime/appcds/ProhibitedPackage.java
! test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
! test/hotspot/jtreg/runtime/appcds/TestCommon.java
! test/hotspot/jtreg/runtime/appcds/TraceLongClasspath.java
! test/hotspot/jtreg/runtime/appcds/WrongClasspath.java
+ test/hotspot/jtreg/runtime/appcds/cdsutils/DynamicDumpHelper.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatA.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatB.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatBase.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatC.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatD.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatE.java
! test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom.java
! test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom_JFR.java
! test/hotspot/jtreg/runtime/appcds/customLoader/ProhibitedPackageNamesTest.java
+ test/hotspot/jtreg/runtime/appcds/customLoader/test-classes/HelloUnload.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/AppendClasspath.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/ArchiveConsistency.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/ArrayKlasses.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/ClassResolutionFailure.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicArchiveTestBase.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicFlag.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicLotsOfClasses.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/ExcludedClasses.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamic.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamicCustom.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamicCustomUnload.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/JITInteraction.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/MainModuleOnly.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/MethodSorting.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/MissingArchive.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/NoClassToArchive.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/SharedArchiveFileOption.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/UnsupportedBaseArchive.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/UnusedCPDuringDump.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/WrongTopClasspath.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/ArrayKlassesApp.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/ExcludedClassesApp.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/LoadClasses.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/MethodSortingApp.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/MissingDependent.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/StrConcatApp.java
+ test/hotspot/jtreg/runtime/appcds/dynamicArchive/test-classes/TestJIT.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/MismatchedPatchModule.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchJavaBase.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchMain.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddModules.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/MainModuleOnly.java
! test/hotspot/jtreg/runtime/appcds/jigsaw/overridetests/OverrideTests.java
! test/hotspot/jtreg/runtime/appcds/jvmti/dumpingWithAgent/DumpingWithJavaAgent.java
! test/hotspot/jtreg/runtime/appcds/jvmti/transformRelatedClasses/TransformRelatedClassesAppCDS.java
! test/hotspot/jtreg/runtime/appcds/test-classes/DummyClassHelper.java
+ test/hotspot/jtreg/runtime/appcds/test-classes/GenericTestApp.java
! test/lib/jdk/test/lib/cds/CDSTestUtils.java
! test/lib/sun/hotspot/WhiteBox.java

Changeset: fe4c2de90b59
Author:    zgu
Date:      2019-05-17 11:47 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fe4c2de90b59

8223951: Shenandoah: Only need to update thread roots during final update refs
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: 657f6e484bc6
Author:    vromero
Date:      2019-05-17 13:16 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/657f6e484bc6

8223803: j.l.c.MethodTypeDesc::insertParameterTypes??? doesn't control type of parameters
Reviewed-by: rriggs

! src/java.base/share/classes/java/lang/constant/ConstantDesc.java
! src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java
! test/jdk/java/lang/constant/MethodTypeDescTest.java

Changeset: 43633b8e24c6
Author:    rfield
Date:      2019-05-17 12:52 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/43633b8e24c6

8223595: Consider updating jdk.jshell module description
Summary: Conform to module summary standards
Reviewed-by: jlahoda

! src/jdk.jshell/share/classes/module-info.java

Changeset: 13507abf416c
Author:    ysuenaga
Date:      2019-05-18 15:42 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/13507abf416c

8163805: hotspot/test/serviceability/sa/sadebugd/SADebugDTest.java failed with timed out
Reviewed-by: cjplummer, jcbeyler

! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java

Changeset: 0f934da77390
Author:    shade
Date:      2019-05-18 18:49 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0f934da77390

8224170: Build failures after JDK-8207812 (Implement Dynamic CDS Archive)
Reviewed-by: stuefe, kvn

! src/hotspot/share/memory/dynamicArchive.cpp

Changeset: 24c0eeb3ebe7
Author:    jiefu
Date:      2019-05-18 12:13 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/24c0eeb3ebe7

8222302: [TESTBUG]test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java fails on any other CPU
Reviewed-by: kvn, dlong

! test/hotspot/jtreg/compiler/intrinsics/sha/cli/SHAOptionsBase.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java

Changeset: 39814e0a8964
Author:    tschatzl
Date:      2019-05-18 22:11 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/39814e0a8964

8222492: G1 unnecessarily scans remembered set cards for regions that already have been evacuated
Summary: Filter out cards from the current collection set during evacuation increments.
Reviewed-by: kbarrett, sangheki

! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp
! src/hotspot/share/gc/g1/g1OopClosures.hpp
! src/hotspot/share/gc/g1/g1OopClosures.inline.hpp
! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp
! src/hotspot/share/gc/g1/g1RemSet.cpp
! src/hotspot/share/gc/g1/g1RemSet.hpp

Changeset: cb80f2adf35c
Author:    ljiang
Date:      2019-05-19 22:14 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cb80f2adf35c

8219781: Localized names for Japanese era Reiwa in COMPAT provider
Reviewed-by: naoto

! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ar.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ko.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_th.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_zh.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ar.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_hi_IN.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_hr.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_in.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ko.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_lt.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_nl.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_no.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ru.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sr.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sr_Latn.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sv.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_th.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_zh.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_zh_TW.java
+ test/jdk/java/util/Calendar/JapanEraNameCompatTest.java

Changeset: 8c63164bd540
Author:    pmuthuswamy
Date:      2019-05-20 14:42 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8c63164bd540

8219313: Support module specific stylesheets
Reviewed-by: jjg

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java
+ test/langtools/jdk/javadoc/doclet/testModuleSpecificStylesheet/TestModuleSpecificStylesheet.java
! test/langtools/jdk/javadoc/doclet/testPackageSpecificStylesheet/TestPackageSpecificStylesheet.java

Changeset: 7e5e0b326ed7
Author:    mbaesken
Date:      2019-05-14 10:21 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7e5e0b326ed7

8130017: use _FORTIFY_SOURCE in gcc fastdebug builds
Reviewed-by: erikj

! make/autoconf/flags-cflags.m4
! test/fmw/gtest/src/gtest.cc

Changeset: 8c977741c3c8
Author:    dfuchs
Date:      2019-05-20 12:37 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8c977741c3c8

8223856: Replace wildcard address with loopback or local host in tests - part 8
Summary: Fixes some intermittent test failures by replacing wildcard with loopback - or retrying once.
Reviewed-by: aefimov, chegar

! test/jdk/com/sun/net/httpserver/SimpleHttpServerTest.java
! test/jdk/java/net/BindException/Test.java
! test/jdk/java/net/PlainSocketImpl/SetOption.java
! test/jdk/java/net/Socket/RST.java
! test/jdk/java/net/URLConnection/URLConnectionHeaders.java
! test/jdk/java/net/ipv6tests/UdpTest.java
! test/jdk/sun/net/ftp/B6427768.java
! test/jdk/sun/net/www/ftptest/FtpCommandHandler.java
! test/jdk/sun/net/www/ftptest/FtpServer.java
! test/jdk/sun/net/www/http/HttpClient/RetryPost.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/ReadTimeout.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/Redirect.java

Changeset: bafd6c944db4
Author:    dkejriwal
Date:      2019-05-16 12:14 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bafd6c944db4

8206879: Currency decimal marker incorrect for Peru
Reviewed-by: naoto, rpatil

! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_es_PE.java
+ test/jdk/java/text/Format/NumberFormat/TestPeruCurrencyFormat.java
! test/jdk/sun/text/resources/LocaleData

Changeset: 2d90a0988c95
Author:    zgu
Date:      2019-05-20 09:42 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2d90a0988c95

8224210: Shenandoah: Refactor ShenandoahRootScanner to support scanning CSet codecache roots
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: af28daff6b98
Author:    zgu
Date:      2019-05-20 09:43 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/af28daff6b98

8224179: Shenandoah: CTW test failures with traversal GC
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

Changeset: 5108637ad8a8
Author:    shade
Date:      2019-05-21 09:26 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5108637ad8a8

Merge

! .hgtags
! make/hotspot/lib/JvmFeatures.gmk
! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/macroAssembler_x86.cpp
! src/hotspot/cpu/x86/macroAssembler_x86.hpp
! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp
! src/hotspot/cpu/x86/templateTable_x86.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp
! src/hotspot/share/classfile/classLoaderData.cpp
! src/hotspot/share/classfile/classLoaderData.hpp
! src/hotspot/share/classfile/javaClasses.cpp
! src/hotspot/share/classfile/javaClasses.hpp
! src/hotspot/share/classfile/modules.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/g1/g1CollectedHeap.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp
- src/hotspot/share/gc/g1/g1InCSetState.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
! src/hotspot/share/gc/shenandoah/shenandoahAllocRequest.hpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp
! src/hotspot/share/gc/shenandoah/shenandoahControlThread.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.hpp
! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp
! src/hotspot/share/memory/metaspace.hpp
! src/hotspot/share/oops/objArrayKlass.cpp
! src/hotspot/share/oops/oop.cpp
! src/hotspot/share/opto/loopnode.hpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/os.hpp
! src/hotspot/share/runtime/thread.cpp
- src/java.desktop/share/native/libfreetype/include/freetype/internal/ftpic.h
- src/java.desktop/share/native/libfreetype/src/autofit/afpic.c
- src/java.desktop/share/native/libfreetype/src/autofit/afpic.h
- src/java.desktop/share/native/libfreetype/src/base/basepic.c
- src/java.desktop/share/native/libfreetype/src/base/basepic.h
- src/java.desktop/share/native/libfreetype/src/base/ftapi.c
- src/java.desktop/share/native/libfreetype/src/base/ftpic.c
- src/java.desktop/share/native/libfreetype/src/base/md5.c
- src/java.desktop/share/native/libfreetype/src/base/md5.h
- src/java.desktop/share/native/libfreetype/src/cff/cffpic.c
- src/java.desktop/share/native/libfreetype/src/cff/cffpic.h
- src/java.desktop/share/native/libfreetype/src/pshinter/pshpic.c
- src/java.desktop/share/native/libfreetype/src/pshinter/pshpic.h
- src/java.desktop/share/native/libfreetype/src/psnames/pspic.c
- src/java.desktop/share/native/libfreetype/src/psnames/pspic.h
- src/java.desktop/share/native/libfreetype/src/raster/rastpic.c
- src/java.desktop/share/native/libfreetype/src/raster/rastpic.h
- src/java.desktop/share/native/libfreetype/src/sfnt/sfntpic.c
- src/java.desktop/share/native/libfreetype/src/sfnt/sfntpic.h
- src/java.desktop/share/native/libfreetype/src/smooth/ftspic.c
- src/java.desktop/share/native/libfreetype/src/smooth/ftspic.h
- src/java.desktop/share/native/libfreetype/src/truetype/ttpic.c
- src/java.desktop/share/native/libfreetype/src/truetype/ttpic.h
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-3.3.1.js
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script-dir/jquery-migrate-3.0.1.js
- src/jdk.javadoc/share/legal/jquery-migrate.md
- test/fmw/gtest/README
! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/TEST.groups
- test/jdk/com/sun/jdi/BasicJDWPConnectionTest.java


From shade at redhat.com  Tue May 21 08:15:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 10:15:49 +0200
Subject: RFR/RFC: Pick up jdk-13+21+ to sh/jdk
In-Reply-To: <b3afab91-d249-f117-fdb6-cc91c4e5f166@redhat.com>
References: <9a10782b-9fce-c65e-47af-c2bbd5e1298b@redhat.com>
 <b3afab91-d249-f117-fdb6-cc91c4e5f166@redhat.com>
Message-ID: <6a8040f7-0e42-e3bc-91ac-602d9741772e@redhat.com>

Pushed.


On 5/21/19 9:56 AM, Roman Kennke wrote:
> Finally! :-)
> 
> Changes look good. Go!
> 
> Thanks,
> Roman
> 
> 
>> We have caught the moment in jdk/jdk where it is not broken anywhere. Let's pick that up. There is a
>> trivial merge required after ShRootProcessor changes.
>>
>> Changesets:
>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/changesets.txt
>>
>> Webrev (only "shenandoah" parts, since there is a huge Graal update):
>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b21-plus/webrev.01/
>>
>> Testing: hotspot_gc_shenandoah {fastdebug|release}, eyeballing webrev
>>
> 


-- 
Thanks,
-Aleksey


From shade at redhat.com  Tue May 21 08:46:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 10:46:55 +0200
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <0d538ec3-5532-70fc-8ad4-85916b681e19@redhat.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
 <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
 <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>
 <CADPaBqnGZe2CWPgME_Q1uBD2uun6jTctPDm3s6WQ2BxNPR9xjQ@mail.gmail.com>
 <0d538ec3-5532-70fc-8ad4-85916b681e19@redhat.com>
Message-ID: <ef4af3ff-38d4-faac-a968-5a789f4bc160@redhat.com>

On 5/20/19 12:34 PM, Aleksey Shipilev wrote:
> On 5/17/19 10:29 PM, Ken Dobson wrote:
>> Apologies there was one tiny typo in a String that is now fixed here:
>> http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests1/webrev
> 
> I can sponsor this week, after we stabilize jdk/jdk enough to accept it.

And done:
  http://hg.openjdk.java.net/jdk/jdk/rev/43340a79840d

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May 21 10:01:02 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 21 May 2019 12:01:02 +0200
Subject: RFR (jdk8): Backport weakroots stuff to sh/jdk8
In-Reply-To: <6a59c752-6661-360e-9e9f-b54eaa7ba497@redhat.com>
References: <f7b672f7-06b2-2f3b-1f35-51c43fc87fb2@redhat.com>
 <6a59c752-6661-360e-9e9f-b54eaa7ba497@redhat.com>
Message-ID: <5953d291-938e-9880-987d-f2dab5db5c1c@redhat.com>

Hi Zhengyu,

> 1) Should StringTable also belong to WeakProcessor?

It should, but then it would go under a single claimed task together
with the other weak roots there, and we'd loose possible parallel
procesing. I don't know if we want to do this. The other option would be
to extend ShWeakProcessor to handle parallel processing like >=JDK12
WeakProcessor, but I don't think we want to go that way either.

> 2) Why SRP::processor_vm_roots() still contains JNIHandles' weak oops

That is because of the bug that is described in the comment. I don't
dare to touch that ;-)

> 3) SRP::process_all_roots(), should we call WeakProcessor::oops_do()
> instead? when we need to mark through all roots?

We could, but the way I did mirrored jdk11 and up changes. Plus, it is
changed right in the subsequent changeset again to accept a templated
BoolClosure, so doesn't seem worth to change anything.

Roman


> Thanks,
> 
> -Zhengyu
> 
> 
> On 5/17/19 8:29 AM, Roman Kennke wrote:
>> This backports the following two changes from sh/jdk11 -> sh/jdk8:
>>
>> 49: JDK-8221435: Shenandoah should not mark through weak roots
>> 49: JDK-8221629: Shenandoah: Cleanup class unloading logic
>>
>>
>> This is a bit risky and complicated. I added a compat class in
>> shenandoahWeakProcessor.hpp/cpp which is basically the same (with minor
>> removals) as jdk11's weakProcessor.hpp/cpp.
>>
>> Other than that, the weakroots-handling in systemDictionary is a bit
>> different and more messy than in jdk11, which is why I moved those bits
>> into process_strong_roots() (only scans strong sys-dict roots) and
>> process_weak_roots (scans both strong+weak sys-dict roots). This keeps
>> the interfaces the same as in jdk11 and 13 and does the right thing.
>> Unfortunately, we can't drive the strong and weak sys-dict roots
>> separately as it's done in jdk11 and upwards.
>>
>> The stringdedup stuff is also different. I believe I got it right, as
>> much as it is possible.
>>
>> Testing: hotspot_gc_shenandoah looks good. Some point testing in specjvm
>> did not show up any problems. We want to test this thouroughly in our CI
>> before shipping it anywhere.
>>
>> http://cr.openjdk.java.net/~rkennke/backport-jdk8-2019-05-17-1/webrev.00/
>>
>> Ok to go?
>>
>> Roman
>>


From rkennke at redhat.com  Tue May 21 10:43:22 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 21 May 2019 12:43:22 +0200
Subject: RFR (8): JDK-8221848: Shenandoah: ArrayCopy post-barrier improvements
Message-ID: <c18dc22a-c938-1657-e763-3006dea902d7@redhat.com>

This backports JDK-8221848: Shenandoah: ArrayCopy post-barrier
improvements. As before with "JDK-8221751: Shenandoah: Improve SATB
enqueueing" we need to break out the arraycopy-epilogue code in asm. It
also incorporates the fixes that I've done for jdk11 (correct usage of
missing count Register, correct placement of push/pop).

http://cr.openjdk.java.net/~rkennke/backport-jdk8-JDK-8221848/webrev.00/

Testing: hotspot_gc_shenandoah (x86/aarch64)

ok?

Roman


From kdobson at redhat.com  Tue May 21 14:33:34 2019
From: kdobson at redhat.com (Ken Dobson)
Date: Tue, 21 May 2019 10:33:34 -0400
Subject: RFR 8221507: Implement JFR Events for Shenandoah
In-Reply-To: <ef4af3ff-38d4-faac-a968-5a789f4bc160@redhat.com>
References: <CADPaBqnvz488yBHxuTBVseifyisd=z6UtnS8x-oiMVX77DvYhg@mail.gmail.com>
 <7ab5fe7b-bd77-39e6-9435-7c334507b1b1@redhat.com>
 <CADPaBq=9XVMAsp5UGXtYZxqtFggF7otWy5b_snthd1jGe7w=sw@mail.gmail.com>
 <472df260-d308-f285-de4e-f61aebfef048@redhat.com>
 <30063000-1648-2ac3-01f7-b0d60004f948@redhat.com>
 <CADPaBq=26b0iFJh+bK8BLYWWP_RQr4BafijvH2NcJbYKWFU5sQ@mail.gmail.com>
 <153377a0-362e-d245-593d-0fb05fe32260@redhat.com>
 <CADPaBqnYAJ3wi-KX4YG_rqOYzz12y8yVPNU5aTkZ0aGvR+LXPw@mail.gmail.com>
 <CADPaBqnGZe2CWPgME_Q1uBD2uun6jTctPDm3s6WQ2BxNPR9xjQ@mail.gmail.com>
 <0d538ec3-5532-70fc-8ad4-85916b681e19@redhat.com>
 <ef4af3ff-38d4-faac-a968-5a789f4bc160@redhat.com>
Message-ID: <CADPaBqkXa5ZJfuTAoofVZQRBJ7meGtvNJXnMSwW30WmPpJBy9A@mail.gmail.com>

Great, thanks for merging and thanks to everybody for your help!

Ken Dobson

On Tue, May 21, 2019 at 4:47 AM Aleksey Shipilev <shade at redhat.com> wrote:

> On 5/20/19 12:34 PM, Aleksey Shipilev wrote:
> > On 5/17/19 10:29 PM, Ken Dobson wrote:
> >> Apologies there was one tiny typo in a String that is now fixed here:
> >>
> http://cr.openjdk.java.net/~kdobson/finalshenandoaheventswithtests1/webrev
> >
> > I can sponsor this week, after we stabilize jdk/jdk enough to accept it.
>
> And done:
>   http://hg.openjdk.java.net/jdk/jdk/rev/43340a79840d
>
> --
> Thanks,
> -Aleksey
>
>

From zgu at redhat.com  Tue May 21 16:45:33 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 21 May 2019 12:45:33 -0400
Subject: RFR(XXS) 8224495: Shenandoah: Do not rescan code roots in final mark
 pause if it is not degenerated GC
Message-ID: <6d007baa-98c8-42c1-6cc2-109db197444d@redhat.com>

As comments in code stated, it only guards against degenerated GC, that 
bypasses concurrent cycle. So, let's only re-scan code roots if 
degenerated GC is in progress.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224495
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224495/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Tue May 21 16:51:42 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 18:51:42 +0200
Subject: RFR(XXS) 8224495: Shenandoah: Do not rescan code roots in final
 mark pause if it is not degenerated GC
In-Reply-To: <6d007baa-98c8-42c1-6cc2-109db197444d@redhat.com>
References: <6d007baa-98c8-42c1-6cc2-109db197444d@redhat.com>
Message-ID: <59744575-b42d-c939-06a4-76c6f94e1654@redhat.com>

On 5/21/19 6:45 PM, Zhengyu Gu wrote:
> As comments in code stated, it only guards against degenerated GC, that bypasses concurrent cycle.
> So, let's only re-scan code roots if degenerated GC is in progress.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224495
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224495/webrev.00/

Local var "heap" is already available there. Looks okay otherwise.

-Aleksey


From shade at redhat.com  Tue May 21 20:06:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 22:06:40 +0200
Subject: RFR (S) 8224522: Shenandoah should apply barriers on deoptimization
Message-ID: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8224522

Fix:
  http://cr.openjdk.java.net/~shade/8224522/webrev.01/

Shenandoah, like ZGC, needs to make sure that the oops that are in deoptimized frames are passed
through the barriers. Otherwise deoptimization might sneak bad oops into into Java heap. This is a
very rare, hard to replicate, but still fatal error. The fix copies what ZGC code already does.
Since Shenandoah also runs with compressed oops, we need to take care of "narrowoop" path as well. I
made the oop/narrowoop as close as possible style-wise.

Testing: hotspot_gc_shenandoah; build with -shenandoahgc; jdk-submit (running)

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Tue May 21 20:20:29 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Tue, 21 May 2019 22:20:29 +0200
Subject: RFR (S) 8224522: Shenandoah should apply barriers on
 deoptimization
In-Reply-To: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
References: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
Message-ID: <745a0845-9031-1502-2a3c-4b628ca8757b@redhat.com>

It looks good to me.

It probably warrants a proper GC interface. But let's fix the bug first.

I was thinking what kind of GC interface would be appropriate. It really
is a load from an off-heap address plus a load-barrier, so maybe
NativeAccess<>::load() with appropriate decorators would cover it? Let's
discuss this in a follow-up though.

Thanks,
Roman

> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8224522
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8224522/webrev.01/
> 
> Shenandoah, like ZGC, needs to make sure that the oops that are in deoptimized frames are passed
> through the barriers. Otherwise deoptimization might sneak bad oops into into Java heap. This is a
> very rare, hard to replicate, but still fatal error. The fix copies what ZGC code already does.
> Since Shenandoah also runs with compressed oops, we need to take care of "narrowoop" path as well. I
> made the oop/narrowoop as close as possible style-wise.
> 
> Testing: hotspot_gc_shenandoah; build with -shenandoahgc; jdk-submit (running)
> 


From zgu at redhat.com  Tue May 21 20:50:08 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 21 May 2019 16:50:08 -0400
Subject: RFR(XXS) 8224508: Shenandoah: Need to update thread roots in final
 mark for piggyback ref update cycle
Message-ID: <a98e110e-bbbb-50e5-3bf3-e0dadb801f44@redhat.com>

The thread roots may still contain forwarded oops.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224508
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224508/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release) with fixed verifier

Thanks,

-Zhengyu

From zgu at redhat.com  Tue May 21 20:57:58 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 21 May 2019 16:57:58 -0400
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
Message-ID: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>

Since switching to LRB, verifier has side-effects of evacuating oops, if 
it is ran during evacuation phase.

The patch resets gc_state before LRB can be triggered by verifier, and 
restore gc_state when it is done.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224525
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.00/

Test:
   hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)


Thanks,

-Zhengyu

From shade at redhat.com  Tue May 21 21:10:02 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 23:10:02 +0200
Subject: RFR(XXS) 8224508: Shenandoah: Need to update thread roots in
 final mark for piggyback ref update cycle
In-Reply-To: <a98e110e-bbbb-50e5-3bf3-e0dadb801f44@redhat.com>
References: <a98e110e-bbbb-50e5-3bf3-e0dadb801f44@redhat.com>
Message-ID: <26ae4960-1f09-6965-e77e-56d76cadecdf@redhat.com>

On 5/21/19 10:50 PM, Zhengyu Gu wrote:
> The thread roots may still contain forwarded oops.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224508
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224508/webrev.00/

Looks okay. Indent is not correct at L1509 here, please fix before pushing.

1508     if (has_forwarded_objects()) {
1509     // Degen may be caused by failed evacuation of roots
1510       if (is_degenerated_gc_in_progress()) {

-Aleksey


From alex at scalyr.com  Tue May 21 21:14:56 2019
From: alex at scalyr.com (Alex Elent)
Date: Tue, 21 May 2019 14:14:56 -0700
Subject: Measuring Stop-the-World(STW) Pauses
Message-ID: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>

Hello,

We are evaluating Shenandoah GC for our application. In order to evaluate
we'd like to measure the STW pauses. Would anyone be able to assist in
identifying which log lines we should be evaluating? We are using JDK8
(also in progress of upgrading to JDK11). Should we be looking at entries
that contain the "Pause" keyword? Does that indicate a STW pause? Is there
anything else we should be counting towards the STW pauses?

Thank you so much for your help!

A snippet of our logs:
2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
8645M->2324M(10G), 1.147 ms]
Free: 7358M (1853 regions), Max regular: 4096K, Max humongous: 962560K,
External frag: 88%, Internal frag: 0%
Evacuation Reserve: 509M (128 regions), Max regular: 4096K
2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
    Using 4 of 4 workers for concurrent evacuation
2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
2324M->2329M(10G), 5.720 ms]
2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, start]
    Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable: 735M,
Alloc Tax Rate: 1.1x
2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061 ms]
2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
start]
    Using 4 of 4 workers for concurrent reference update
2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
2329M->2330M(10G), 23.211 ms]
2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs, start]
    Using 4 of 4 workers for final reference update
2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs, 1.142 ms]
2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
2330M->390M(10G), 0.455 ms]
Free: 9321M (2345 regions), Max regular: 4096K, Max humongous: 4575232K,
External frag: 53%, Internal frag: 0%
Evacuation Reserve: 512M (128 regions), Max regular: 4096K
Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
Trigger: Free (1023M) is below minimum threshold (1023M)
Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
External frag: 7%, Internal frag: 5%
Evacuation Reserve: 512M (128 regions), Max regular: 4096K
2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
    Using 4 of 4 workers for concurrent reset
2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
8640M->8643M(10G), 4.835 ms]
2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
weakrefs), start]
    Using 4 of 4 workers for init marking
    Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable: 102M,
Alloc Tax Rate: 1.1x
2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
weakrefs), 2.050 ms]

From shade at redhat.com  Tue May 21 21:23:05 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 23:23:05 +0200
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
Message-ID: <1020a3c9-3e30-a7c8-a0e7-09807aaae5df@redhat.com>

On 5/21/19 10:57 PM, Zhengyu Gu wrote:
> Since switching to LRB, verifier has side-effects of evacuating oops, if it is ran during evacuation
> phase.
> 
> The patch resets gc_state before LRB can be triggered by verifier, and restore gc_state when it is
> done.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224525
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)

The idea looks good.

Let's put the comment like:

 672   // Deactivate barriers temporarily: Verifier wants plain heap accesses
 673   ShenandoahGCStateResetter resetter;

You can common the use of ShenandoahHeap::heap() here (in fact you can probably just pull it into
the ShenandoahGCStateResetter const field):

 618   ~ShenandoahGCStateResetter() {
 619     ShenandoahHeap::heap()->_gc_state.set(_gc_state);
 620     assert(ShenandoahHeap::heap()->gc_state() == _gc_state, "Should be restored");
 621   }

-Aleksey


From shade at redhat.com  Tue May 21 21:31:21 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 21 May 2019 23:31:21 +0200
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
Message-ID: <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>

On 5/21/19 11:14 PM, Alex Elent wrote:
> Should we be looking at entries that contain the "Pause" keyword?
Yes. Everything with "Pause" is global STW pause. This should correlate to MXBean "Shenandoah
Pauses" (if you are running external monitoring service), safepoint logging
(-XX:+PrintSafepointStatistics), etc. With -verbose:gc, you should also have the summary table at
the end of the run, which would dissect the pauses more thoroughly.

In your log below, there is 2.032ms Final Mark, 0.061ms Init Update Refs, 1.142ms Final Update Refs
pauses (there should also be Init Mark in the beginning). There are normally four pauses per GC
cycle, sometimes less if cycle shortcuts.

> 2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
> 2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
> 8645M->2324M(10G), 1.147 ms]
> Free: 7358M (1853 regions), Max regular: 4096K, Max humongous: 962560K,
> External frag: 88%, Internal frag: 0%
> Evacuation Reserve: 509M (128 regions), Max regular: 4096K
> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
>     Using 4 of 4 workers for concurrent evacuation
> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
> 2324M->2329M(10G), 5.720 ms]
> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, start]
>     Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable: 735M,
> Alloc Tax Rate: 1.1x
> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061 ms]
> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
> start]
>     Using 4 of 4 workers for concurrent reference update
> 2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
> 2329M->2330M(10G), 23.211 ms]
> 2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs, start]
>     Using 4 of 4 workers for final reference update
> 2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs, 1.142 ms]
> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
> 2330M->390M(10G), 0.455 ms]
> Free: 9321M (2345 regions), Max regular: 4096K, Max humongous: 4575232K,
> External frag: 53%, Internal frag: 0%
> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
> Trigger: Free (1023M) is below minimum threshold (1023M)
> Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
> External frag: 7%, Internal frag: 5%
> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> 2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
>     Using 4 of 4 workers for concurrent reset
> 2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
> 8640M->8643M(10G), 4.835 ms]
> 2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
> weakrefs), start]
>     Using 4 of 4 workers for init marking
>     Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable: 102M,
> Alloc Tax Rate: 1.1x
> 2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
> weakrefs), 2.050 ms]


-- 
Thanks,
-Aleksey


From alex at scalyr.com  Tue May 21 21:47:55 2019
From: alex at scalyr.com (Alex Elent)
Date: Tue, 21 May 2019 14:47:55 -0700
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
 <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
Message-ID: <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>

That's absolutely perfect, thanks!

On Tue, May 21, 2019 at 2:31 PM Aleksey Shipilev <shade at redhat.com> wrote:

> On 5/21/19 11:14 PM, Alex Elent wrote:
> > Should we be looking at entries that contain the "Pause" keyword?
> Yes. Everything with "Pause" is global STW pause. This should correlate to
> MXBean "Shenandoah
> Pauses" (if you are running external monitoring service), safepoint logging
> (-XX:+PrintSafepointStatistics), etc. With -verbose:gc, you should also
> have the summary table at
> the end of the run, which would dissect the pauses more thoroughly.
>
> In your log below, there is 2.032ms Final Mark, 0.061ms Init Update Refs,
> 1.142ms Final Update Refs
> pauses (there should also be Init Mark in the beginning). There are
> normally four pauses per GC
> cycle, sometimes less if cycle shortcuts.
>
> > 2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
> > 2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
> > 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
> > 8645M->2324M(10G), 1.147 ms]
> > Free: 7358M (1853 regions), Max regular: 4096K, Max humongous: 962560K,
> > External frag: 88%, Internal frag: 0%
> > Evacuation Reserve: 509M (128 regions), Max regular: 4096K
> > 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
> >     Using 4 of 4 workers for concurrent evacuation
> > 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
> > 2324M->2329M(10G), 5.720 ms]
> > 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, start]
> >     Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable: 735M,
> > Alloc Tax Rate: 1.1x
> > 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061
> ms]
> > 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
> > start]
> >     Using 4 of 4 workers for concurrent reference update
> > 2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
> > 2329M->2330M(10G), 23.211 ms]
> > 2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs, start]
> >     Using 4 of 4 workers for final reference update
> > 2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs, 1.142
> ms]
> > 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
> > 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
> > 2330M->390M(10G), 0.455 ms]
> > Free: 9321M (2345 regions), Max regular: 4096K, Max humongous: 4575232K,
> > External frag: 53%, Internal frag: 0%
> > Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> > Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
> > Trigger: Free (1023M) is below minimum threshold (1023M)
> > Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
> > External frag: 7%, Internal frag: 5%
> > Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> > 2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
> >     Using 4 of 4 workers for concurrent reset
> > 2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
> > 8640M->8643M(10G), 4.835 ms]
> > 2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
> > weakrefs), start]
> >     Using 4 of 4 workers for init marking
> >     Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable: 102M,
> > Alloc Tax Rate: 1.1x
> > 2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
> > weakrefs), 2.050 ms]
>
>
> --
> Thanks,
> -Aleksey
>
>

From shade at redhat.com  Wed May 22 06:56:23 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 08:56:23 +0200
Subject: RFR/RFC: Pick up aarch64-shenandoah-jdk8u222-b02 to sh/jdk8
In-Reply-To: <dc392693-a164-f51c-a7a8-00b6ffffa041@redhat.com>
References: <dc392693-a164-f51c-a7a8-00b6ffffa041@redhat.com>
Message-ID: <8f6d76cb-560f-9cf6-cea7-768271f418d7@redhat.com>

Ping Andrew Hughes.

On 5/20/19 12:26 PM, Aleksey Shipilev wrote:
> Hi,
> 
> This is our first ever merge from aarch64-port/jdk8u-shenandoah to sh/jdk8. This picks up
> aarch64-shenandoah-jdk8u222-b02 tag and merges it into sh/jdk8.
> 
> Changesets (only hotspot, others are trivial):
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/changesets.txt
> 
> Webrev (only hotspot, others are trivial):
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/webrev.01/
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 
> Andrew Hughes, we need to agree on process here. The way it is done right now, we are doing this:
>  a. Pull aarch64-port/jdk8u-shenandoah -> sh/jdk8, merge
>  b. Test it, pile on our backports
>  c. Repeat (a)-(b) until Shenandoah is stable
>  d. RFR the pull sh/jdk8 -> aarch64-port/jdk8u-shenandoah, tag it appropriately
> 
> Since aarch64-port/jdk8u-shenandoah and sh/jdk8 are related now, this allows us to push/pull between
> them without any Mercurial voodoo. The caveat there is that the pull at (d) would include a few
> local "merge" changesets from (a), are you fine with that? I also prefer not to introduce new
> sh/jdk8-specific tags to avoid contaminating aarch64-port/jdk8u-shenandoah with them, so those
> merges would be untagged.
> 
> You could ask why don't we just push the backports to aarch64-port/jdk8u-shenandoah, but the trouble
> is that 8u is a mess GC-interface-wise, and we would like to have sh/jdk8 as additional sandbox to
> test for ourselves before integrating. It would be better as we backport more simplifications like
> LRB and nofwdptr features into sh/jdk8u, which would get Shenandoah upstream exposure down
> significantly. But so far it is what it is.
> 

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 22 07:25:51 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 09:25:51 +0200
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
Message-ID: <804f9b18-8204-b1c0-5406-e96af34c2412@redhat.com>

Where exactly does verification interfere with evacuation-in-progress?
Because I don't see it. verify_before_evacuation() is done before
activating the flag, and verify_after_evacuation() is done after
clearing the flag.

Roman


> Since switching to LRB, verifier has side-effects of evacuating oops, if
> it is ran during evacuation phase.
> 
> The patch resets gc_state before LRB can be triggered by verifier, and
> restore gc_state when it is done.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224525
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah with -XX:+ShenandoahVerify (fastdebug and release)
> 
> 
> Thanks,
> 
> -Zhengyu


From shade at redhat.com  Wed May 22 07:29:50 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 09:29:50 +0200
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <804f9b18-8204-b1c0-5406-e96af34c2412@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
 <804f9b18-8204-b1c0-5406-e96af34c2412@redhat.com>
Message-ID: <aafbfa9a-7176-abcc-328b-b4812b522ff7@redhat.com>

On 5/22/19 9:25 AM, Roman Kennke wrote:
> Where exactly does verification interfere with evacuation-in-progress?
> Because I don't see it. verify_before_evacuation() is done before
> activating the flag, and verify_after_evacuation() is done after
> clearing the flag.

There is also ShenandoahVerifier::verify_during_evacuation(). But anyhow, we want to skip any
barriers when doing verification, as we'd like to see the unaided view of the heap.

-Aleksey


From rkennke at redhat.com  Wed May 22 07:37:37 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 09:37:37 +0200
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <aafbfa9a-7176-abcc-328b-b4812b522ff7@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
 <804f9b18-8204-b1c0-5406-e96af34c2412@redhat.com>
 <aafbfa9a-7176-abcc-328b-b4812b522ff7@redhat.com>
Message-ID: <c89a1d40-5406-f362-8bff-39a5c6092c5f@redhat.com>

>> Where exactly does verification interfere with evacuation-in-progress?
>> Because I don't see it. verify_before_evacuation() is done before
>> activating the flag, and verify_after_evacuation() is done after
>> clearing the flag.
> 
> There is also ShenandoahVerifier::verify_during_evacuation(). But anyhow, we want to skip any
> barriers when doing verification, as we'd like to see the unaided view of the heap.

Ok, that makes sense. Good with me.

Roman


From rkennke at redhat.com  Wed May 22 07:38:15 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 09:38:15 +0200
Subject: RFR(XXS) 8224508: Shenandoah: Need to update thread roots in
 final mark for piggyback ref update cycle
In-Reply-To: <a98e110e-bbbb-50e5-3bf3-e0dadb801f44@redhat.com>
References: <a98e110e-bbbb-50e5-3bf3-e0dadb801f44@redhat.com>
Message-ID: <45244187-136e-6ed2-9aab-a30561356599@redhat.com>

Ok.

Thanks,
Roman

> The thread roots may still contain forwarded oops.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224508
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224508/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release) with fixed verifier
> 
> Thanks,
> 
> -Zhengyu


From shade at redhat.com  Wed May 22 07:40:26 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 09:40:26 +0200
Subject: RFR (S) 8224522: Shenandoah should apply barriers on
 deoptimization
In-Reply-To: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
References: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
Message-ID: <2301c8d8-f7dc-1d7d-cf9a-3e20bdf1a079@redhat.com>

On 5/21/19 10:06 PM, Aleksey Shipilev wrote:
> Fix:
>   http://cr.openjdk.java.net/~shade/8224522/webrev.01/

jdk-submit came clean. I am going to push it today.

-- 
Thanks,
-Aleksey


From aoqi at loongson.cn  Wed May 22 08:40:21 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 22 May 2019 16:40:21 +0800
Subject: RFR(trivial): JDK-8224579: ResourceMark not declared in
 shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
Message-ID: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>

Hi,

Could I please get reviews for this?

JBS:
https://bugs.openjdk.java.net/browse/JDK-8224579

Fix:
diff -r 6b976a59ee87
src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
Wed May 22 08:42:00 2019 +0100
+++ b/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
Wed May 22 16:37:29 2019 +0800
@@ -27,6 +27,7 @@
 #include "gc/shenandoah/shenandoahHeuristics.hpp"
 #include "gc/shenandoah/shenandoahRootProcessor.hpp"
 #include "gc/shenandoah/shenandoahTimingTracker.hpp"
+#include "memory/resourceArea.hpp"

 template <typename IsAlive, typename KeepAlive>
 void ShenandoahWeakRoots::oops_do(IsAlive* is_alive, KeepAlive*
keep_alive, uint worker_id) {

Thanks,
Ao Qi

From shade at redhat.com  Wed May 22 08:43:27 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 10:43:27 +0200
Subject: RFR(trivial): JDK-8224579: ResourceMark not declared in
 shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
In-Reply-To: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>
References: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>
Message-ID: <71ab6b6f-e576-a7ba-2bab-2d0368401788@redhat.com>

On 5/22/19 10:40 AM, Ao Qi wrote:
> Could I please get reviews for this?

Looks good and trivial. You need a sponsor, right?

-- 
Thanks,
-Aleksey


From aoqi at loongson.cn  Wed May 22 08:53:01 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 22 May 2019 16:53:01 +0800
Subject: RFR(trivial): JDK-8224579: ResourceMark not declared in
 shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
In-Reply-To: <71ab6b6f-e576-a7ba-2bab-2d0368401788@redhat.com>
References: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>
 <71ab6b6f-e576-a7ba-2bab-2d0368401788@redhat.com>
Message-ID: <CALjzQn7aCY=YVxdO3=FGCCW85PA0f8tHx5FyVdbGBz5c=PNXgw@mail.gmail.com>

On Wed, May 22, 2019 at 4:43 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/22/19 10:40 AM, Ao Qi wrote:
> > Could I please get reviews for this?
>
> Looks good and trivial. You need a sponsor, right?

Thanks Aleksey. Yes:)

>
> --
> Thanks,
> -Aleksey
>

From shade at redhat.com  Wed May 22 09:03:15 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 11:03:15 +0200
Subject: RFR(trivial): JDK-8224579: ResourceMark not declared in
 shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
In-Reply-To: <CALjzQn7aCY=YVxdO3=FGCCW85PA0f8tHx5FyVdbGBz5c=PNXgw@mail.gmail.com>
References: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>
 <71ab6b6f-e576-a7ba-2bab-2d0368401788@redhat.com>
 <CALjzQn7aCY=YVxdO3=FGCCW85PA0f8tHx5FyVdbGBz5c=PNXgw@mail.gmail.com>
Message-ID: <33cb91a7-6ff3-2983-1542-3378d90f230c@redhat.com>

On 5/22/19 10:53 AM, Ao Qi wrote:
> On Wed, May 22, 2019 at 4:43 PM Aleksey Shipilev <shade at redhat.com> wrote:
>>
>> On 5/22/19 10:40 AM, Ao Qi wrote:
>>> Could I please get reviews for this?
>>
>> Looks good and trivial. You need a sponsor, right?
> 
> Thanks Aleksey. Yes:)

Done: http://hg.openjdk.java.net/jdk/jdk/rev/b1f070f4a4ae

-Aleksey


From aoqi at loongson.cn  Wed May 22 09:08:07 2019
From: aoqi at loongson.cn (Ao Qi)
Date: Wed, 22 May 2019 17:08:07 +0800
Subject: RFR(trivial): JDK-8224579: ResourceMark not declared in
 shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
In-Reply-To: <33cb91a7-6ff3-2983-1542-3378d90f230c@redhat.com>
References: <CALjzQn4_A=b6vRjOkzVp6=6pr26rypf3ye2z2e-4=c3k6QzeUQ@mail.gmail.com>
 <71ab6b6f-e576-a7ba-2bab-2d0368401788@redhat.com>
 <CALjzQn7aCY=YVxdO3=FGCCW85PA0f8tHx5FyVdbGBz5c=PNXgw@mail.gmail.com>
 <33cb91a7-6ff3-2983-1542-3378d90f230c@redhat.com>
Message-ID: <CALjzQn6wjYPLnyr-dO2Ob3VTObxT0VBZ=i15bMGAcup3+-G6Zw@mail.gmail.com>

On Wed, May 22, 2019 at 5:03 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 5/22/19 10:53 AM, Ao Qi wrote:
> > On Wed, May 22, 2019 at 4:43 PM Aleksey Shipilev <shade at redhat.com> wrote:
> >>
> >> On 5/22/19 10:40 AM, Ao Qi wrote:
> >>> Could I please get reviews for this?
> >>
> >> Looks good and trivial. You need a sponsor, right?
> >
> > Thanks Aleksey. Yes:)
>
> Done: http://hg.openjdk.java.net/jdk/jdk/rev/b1f070f4a4ae

Thanks Aleksey!

>
> -Aleksey
>

From rkennke at redhat.com  Wed May 22 11:09:52 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 13:09:52 +0200
Subject: RFR: Don't require barriers for LoadKlass in C2
Message-ID: <b9202e74-6174-f6d3-d93f-50eb022b49ac@redhat.com>

Aleksey spotted a diff in sh/jdk vs jdk/jdk yesterday, which appears to
be a left-over from earlier attempts to put the forwarding pointer in
Klass* slot. Back then I needed to force barriers before loading Klass*.
However that is not needed anymore, we should be good loading Klass*
from from-space copy because it is immutable.

http://cr.openjdk.java.net/~rkennke/loadklass-no-barriers/webrev.00/

Testing: hotspot_gc_shenandoah

Ok?

Roman


From zgu at redhat.com  Wed May 22 11:31:05 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 22 May 2019 07:31:05 -0400
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <1020a3c9-3e30-a7c8-a0e7-09807aaae5df@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
 <1020a3c9-3e30-a7c8-a0e7-09807aaae5df@redhat.com>
Message-ID: <13791027-0f87-2ee3-bc0c-93d2c71c2301@redhat.com>

> The idea looks good.
> 
> Let's put the comment like:
> 
>   672   // Deactivate barriers temporarily: Verifier wants plain heap accesses
>   673   ShenandoahGCStateResetter resetter;
> 
> You can common the use of ShenandoahHeap::heap() here (in fact you can probably just pull it into
> the ShenandoahGCStateResetter const field):
> 
>   618   ~ShenandoahGCStateResetter() {
>   619     ShenandoahHeap::heap()->_gc_state.set(_gc_state);
>   620     assert(ShenandoahHeap::heap()->gc_state() == _gc_state, "Should be restored");
>   621   }

Updated: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.01/

Okay now?

Thanks,

-Zhengyu

> 
> -Aleksey
> 

From rkennke at redhat.com  Wed May 22 11:35:54 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 13:35:54 +0200
Subject: RFR: JDK-8224584: Shenandoah: Eliminate forwarding pointer word
Message-ID: <2e90069e-94a5-a863-c80d-1441d3a55f8e@redhat.com>

Until now, Shenandoah had the 'limitation' that it required an extra
word per object to keep the forwarding pointer. It either points to
itself (most of the time) or to the forwarded object when evacuated. The
forwarding pointer is updated atomically using CAS. This is the heart of
Shenandoah's evacuation protocol.

With LRB, we have the opportunity to eliminate that extra word. The
insight is that we really don't need the old copy of an object anymore
and we can store the forwarding pointer in the mark word of it. We would
distinguish a valid mark word from a forwarding pointer by checking the
lowest 2 bits: if they are 0b11 then it's forwarded, otherwise it's not.
0b11 is not a valid combination of bits otherwise. This is the same
protocol that is used by other GCs.

The evacuation protocol changes slightly to CAS into the mark word
instead of the extra word. But the basic mechanics are the same.

The extra decoding does not (significantly) affect performance because
it's only done in the mid/slow-path of the LRB. (As opposed to earlier
attempts at it where it'd have to be in the read-barrier.)

The full-GC needs some significant reworking because we used to store
the forwarding ptr in the extra slot. Storing it in mark-word in full-gc
is destructive because there are no from/to-space copies. Therfore we
need to stash the mark-word when it's not trivial. This is pretty much
what other GCs (G1, parallel, CMS) do, and we re-use the shared
infrastructure for this.

I've run SPECjvm2008. Performance benefits vary between 0 and ~+10%.
SPECjbb2015 shows +~12% improvement in throughput and +~9% improvement
in latency.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8224584
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8224584/webrev.00/

Testing:
The change has undergone intensive testing, reviews and bug-fixes in
shenandoah/jdk repository. We have run several workloads on it, some of
them many times. I've run the usual hotspot_gc_shenandoah on it many
times, both on x86 and aarch64.

There is one outstanding C2/matcher issue currently under review that
causes (rare but fatal) failures with this change:
https://bugs.openjdk.java.net/browse/JDK-8224580
https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-May/033838.html

Roman


From shade at redhat.com  Wed May 22 13:07:17 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 15:07:17 +0200
Subject: RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's
 side-effects
In-Reply-To: <13791027-0f87-2ee3-bc0c-93d2c71c2301@redhat.com>
References: <9a96d219-252b-e581-ae15-c4bad21c3dbb@redhat.com>
 <1020a3c9-3e30-a7c8-a0e7-09807aaae5df@redhat.com>
 <13791027-0f87-2ee3-bc0c-93d2c71c2301@redhat.com>
Message-ID: <28b8b84d-1d2e-3daf-50fc-a07080124c9a@redhat.com>

On 5/22/19 1:31 PM, Zhengyu Gu wrote:
>> The idea looks good.
>>
>> Let's put the comment like:
>>
>> ? 672?? // Deactivate barriers temporarily: Verifier wants plain heap accesses
>> ? 673?? ShenandoahGCStateResetter resetter;
>>
>> You can common the use of ShenandoahHeap::heap() here (in fact you can probably just pull it into
>> the ShenandoahGCStateResetter const field):
>>
>> ? 618?? ~ShenandoahGCStateResetter() {
>> ? 619???? ShenandoahHeap::heap()->_gc_state.set(_gc_state);
>> ? 620???? assert(ShenandoahHeap::heap()->gc_state() == _gc_state, "Should be restored");
>> ? 621?? }
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.01/
> 
> Okay now?

Yup, thumbs up.

-Aleksey


From shade at redhat.com  Wed May 22 13:08:14 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 15:08:14 +0200
Subject: RFR: Don't require barriers for LoadKlass in C2
In-Reply-To: <b9202e74-6174-f6d3-d93f-50eb022b49ac@redhat.com>
References: <b9202e74-6174-f6d3-d93f-50eb022b49ac@redhat.com>
Message-ID: <bd84c7f5-e382-fb7a-dfeb-9f6b6d950dee@redhat.com>

On 5/22/19 1:09 PM, Roman Kennke wrote:
> Aleksey spotted a diff in sh/jdk vs jdk/jdk yesterday, which appears to
> be a left-over from earlier attempts to put the forwarding pointer in
> Klass* slot. Back then I needed to force barriers before loading Klass*.
> However that is not needed anymore, we should be good loading Klass*
> from from-space copy because it is immutable.
> 
> http://cr.openjdk.java.net/~rkennke/loadklass-no-barriers/webrev.00/

Looks good.

-Aleksey


From shade at redhat.com  Wed May 22 13:39:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 15:39:37 +0200
Subject: RFR: JDK-8224584: Shenandoah: Eliminate forwarding pointer word
In-Reply-To: <2e90069e-94a5-a863-c80d-1441d3a55f8e@redhat.com>
References: <2e90069e-94a5-a863-c80d-1441d3a55f8e@redhat.com>
Message-ID: <e1746952-530f-4e87-3865-21d94d6efa27@redhat.com>

On 5/22/19 1:35 PM, Roman Kennke wrote:
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8224584/webrev.00/
I looked at this patch multiple times over the last weeks, and it still looks good to me.

-Aleksey


From rwestrel at redhat.com  Wed May 22 14:09:52 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Wed, 22 May 2019 16:09:52 +0200
Subject: RFR: JDK-8224584: Shenandoah: Eliminate forwarding pointer word
In-Reply-To: <2e90069e-94a5-a863-c80d-1441d3a55f8e@redhat.com>
References: <2e90069e-94a5-a863-c80d-1441d3a55f8e@redhat.com>
Message-ID: <87v9y2k2bz.fsf@redhat.com>


> http://cr.openjdk.java.net/~rkennke/JDK-8224584/webrev.00/

C2 changes look good.

Roland.

From shade at redhat.com  Wed May 22 14:39:27 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 16:39:27 +0200
Subject: RFR (S) 8224522: Shenandoah should apply barriers on
 deoptimization
In-Reply-To: <2301c8d8-f7dc-1d7d-cf9a-3e20bdf1a079@redhat.com>
References: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
 <2301c8d8-f7dc-1d7d-cf9a-3e20bdf1a079@redhat.com>
Message-ID: <f91ee022-8bb4-d31a-f40d-f882fe907bcb@redhat.com>

On 5/22/19 9:40 AM, Aleksey Shipilev wrote:
> On 5/21/19 10:06 PM, Aleksey Shipilev wrote:
>> Fix:
>>   http://cr.openjdk.java.net/~shade/8224522/webrev.01/
> 
> jdk-submit came clean. I am going to push it today.

Ah no, I have only one reviewer yet (rkennke), and this is a shared code change. I'd like somebody
else to take a look as well.

-Aleksey


From rkennke at redhat.com  Wed May 22 14:49:13 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Wed, 22 May 2019 14:49:13 +0000
Subject: hg: shenandoah/jdk: Don't require barriers for LoadKlass in C2
Message-ID: <201905221449.x4MEnDcX029948@aojmv0008.oracle.com>

Changeset: 244f5d3d8a25
Author:    rkennke
Date:      2019-05-22 13:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/244f5d3d8a25

Don't require barriers for LoadKlass in C2

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp


From shade at redhat.com  Wed May 22 15:23:33 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 22 May 2019 15:23:33 +0000
Subject: hg: shenandoah/jdk: Shenandoah support for x86_32
Message-ID: <201905221523.x4MFNXfj022327@aojmv0008.oracle.com>

Changeset: 6edfd2a46118
Author:    shade
Date:      2019-05-22 16:51 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6edfd2a46118

Shenandoah support for x86_32

! make/autoconf/hotspot.m4
! src/hotspot/cpu/x86/gc/shenandoah/c1/shenandoahBarrierSetC1_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
+ src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_32.ad
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! test/hotspot/jtreg/gc/TestHumongousReferenceObject.java
! test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java
! test/hotspot/jtreg/gc/shenandoah/TestLargeObjectAlignment.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestNullCheck.java
! test/hotspot/jtreg/gc/shenandoah/compiler/TestReferenceCAS.java
! test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
! test/hotspot/jtreg/gc/shenandoah/options/TestObjectAlignment.java


From shade at redhat.com  Wed May 22 15:25:22 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 17:25:22 +0200
Subject: RFR/RFC: Shenandoah support for x86_32
In-Reply-To: <6c30c0ef-0934-bad1-1fce-893c9bb86ce2@redhat.com>
References: <9c157818-c9c9-9226-f0bd-aec12dae2c4f@redhat.com>
 <96073858-f2a3-0c9d-25d5-a23394ebf80d@redhat.com>
 <9bd7d193-53a5-84ae-d936-f4e3367a2781@redhat.com>
 <6c30c0ef-0934-bad1-1fce-893c9bb86ce2@redhat.com>
Message-ID: <bb6a3d75-afcd-bcf9-8e68-1b9af317bb9a@redhat.com>

On 5/15/19 4:17 PM, Aleksey Shipilev wrote:
> On 5/14/19 10:23 PM, Roman Kennke wrote:
>> I guess we will want to wait until the nofwdptr train has left the
>> station to jdk/jdk?
> 
> Yes. Because otherwise I would need to implement and test Shenandoah-specific allocation path for
> x86_32, which I don't want to do. It is fine to linger in my mq for a while.

Pushed to sh/jdk for pre-integration testing:
 http://hg.openjdk.java.net/shenandoah/jdk/rev/6edfd2a46118

-Aleksey



From zgu at redhat.com  Wed May 22 18:42:58 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 22 May 2019 14:42:58 -0400
Subject: RFR (S) 8224522: Shenandoah should apply barriers on
 deoptimization
In-Reply-To: <f91ee022-8bb4-d31a-f40d-f882fe907bcb@redhat.com>
References: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
 <2301c8d8-f7dc-1d7d-cf9a-3e20bdf1a079@redhat.com>
 <f91ee022-8bb4-d31a-f40d-f882fe907bcb@redhat.com>
Message-ID: <e9c6741a-df64-e6aa-3a58-fced2f4c6673@redhat.com>

Looks good.

-Zhengyu

On 5/22/19 10:39 AM, Aleksey Shipilev wrote:
> On 5/22/19 9:40 AM, Aleksey Shipilev wrote:
>> On 5/21/19 10:06 PM, Aleksey Shipilev wrote:
>>> Fix:
>>>    http://cr.openjdk.java.net/~shade/8224522/webrev.01/
>>
>> jdk-submit came clean. I am going to push it today.
> 
> Ah no, I have only one reviewer yet (rkennke), and this is a shared code change. I'd like somebody
> else to take a look as well.
> 
> -Aleksey
> 

From alex at scalyr.com  Wed May 22 19:50:02 2019
From: alex at scalyr.com (Alex Elent)
Date: Wed, 22 May 2019 12:50:02 -0700
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
 <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
 <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>
Message-ID: <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>

Hi Aleksey,

Just wanted to validate that this is also a STW pause:

2019-05-22T19:45:37.182+0000: 66424.311: [Pause Init Mark (process
weakrefs), 2.344 ms]

Thanks,

On Tue, May 21, 2019 at 2:47 PM Alex Elent <alex at scalyr.com> wrote:

> That's absolutely perfect, thanks!
>
> On Tue, May 21, 2019 at 2:31 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 5/21/19 11:14 PM, Alex Elent wrote:
>> > Should we be looking at entries that contain the "Pause" keyword?
>> Yes. Everything with "Pause" is global STW pause. This should correlate
>> to MXBean "Shenandoah
>> Pauses" (if you are running external monitoring service), safepoint
>> logging
>> (-XX:+PrintSafepointStatistics), etc. With -verbose:gc, you should also
>> have the summary table at
>> the end of the run, which would dissect the pauses more thoroughly.
>>
>> In your log below, there is 2.032ms Final Mark, 0.061ms Init Update Refs,
>> 1.142ms Final Update Refs
>> pauses (there should also be Init Mark in the beginning). There are
>> normally four pauses per GC
>> cycle, sometimes less if cycle shortcuts.
>>
>> > 2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
>> > 2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
>> > 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
>> > 8645M->2324M(10G), 1.147 ms]
>> > Free: 7358M (1853 regions), Max regular: 4096K, Max humongous: 962560K,
>> > External frag: 88%, Internal frag: 0%
>> > Evacuation Reserve: 509M (128 regions), Max regular: 4096K
>> > 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
>> >     Using 4 of 4 workers for concurrent evacuation
>> > 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
>> > 2324M->2329M(10G), 5.720 ms]
>> > 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, start]
>> >     Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable: 735M,
>> > Alloc Tax Rate: 1.1x
>> > 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061
>> ms]
>> > 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
>> > start]
>> >     Using 4 of 4 workers for concurrent reference update
>> > 2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
>> > 2329M->2330M(10G), 23.211 ms]
>> > 2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs, start]
>> >     Using 4 of 4 workers for final reference update
>> > 2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs, 1.142
>> ms]
>> > 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
>> > 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
>> > 2330M->390M(10G), 0.455 ms]
>> > Free: 9321M (2345 regions), Max regular: 4096K, Max humongous: 4575232K,
>> > External frag: 53%, Internal frag: 0%
>> > Evacuation Reserve: 512M (128 regions), Max regular: 4096K
>> > Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
>> > Trigger: Free (1023M) is below minimum threshold (1023M)
>> > Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
>> > External frag: 7%, Internal frag: 5%
>> > Evacuation Reserve: 512M (128 regions), Max regular: 4096K
>> > 2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
>> >     Using 4 of 4 workers for concurrent reset
>> > 2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
>> > 8640M->8643M(10G), 4.835 ms]
>> > 2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
>> > weakrefs), start]
>> >     Using 4 of 4 workers for init marking
>> >     Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable: 102M,
>> > Alloc Tax Rate: 1.1x
>> > 2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
>> > weakrefs), 2.050 ms]
>>
>>
>> --
>> Thanks,
>> -Aleksey
>>
>>

From shade at redhat.com  Wed May 22 19:52:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 21:52:40 +0200
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
 <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
 <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>
 <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>
Message-ID: <69488001-c78a-b189-9cc0-5ab199a37a0c@redhat.com>

On 5/22/19 9:50 PM, Alex Elent wrote:
> Just wanted to validate that this is also a STW pause:
> 
> 2019-05-22T19:45:37.182+0000: 66424.311: [Pause Init Mark (process weakrefs), 2.344 ms]

Yes, it is. If you are not sure, ask for safepoints logging (-XX:+PrintSafepointStatistics) and see
what operations are done when safepoint is taken -- most of them are GC ops.

-Aleksey


From rkennke at redhat.com  Wed May 22 19:53:36 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 21:53:36 +0200
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
 <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
 <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>
 <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>
Message-ID: <fa6fab8e-5890-b437-6015-8ca9db46a74c@redhat.com>

Hi Alex,

> Just wanted to validate that this is also a STW pause:
> 
> 2019-05-22T19:45:37.182+0000: 66424.311: [Pause Init Mark (process
> weakrefs), 2.344 ms]

Yes, it is. :-)

Roman



> Thanks,
> 
> On Tue, May 21, 2019 at 2:47 PM Alex Elent <alex at scalyr.com> wrote:
> 
>> That's absolutely perfect, thanks!
>>
>> On Tue, May 21, 2019 at 2:31 PM Aleksey Shipilev <shade at redhat.com> wrote:
>>
>>> On 5/21/19 11:14 PM, Alex Elent wrote:
>>>> Should we be looking at entries that contain the "Pause" keyword?
>>> Yes. Everything with "Pause" is global STW pause. This should correlate
>>> to MXBean "Shenandoah
>>> Pauses" (if you are running external monitoring service), safepoint
>>> logging
>>> (-XX:+PrintSafepointStatistics), etc. With -verbose:gc, you should also
>>> have the summary table at
>>> the end of the run, which would dissect the pauses more thoroughly.
>>>
>>> In your log below, there is 2.032ms Final Mark, 0.061ms Init Update Refs,
>>> 1.142ms Final Update Refs
>>> pauses (there should also be Init Mark in the beginning). There are
>>> normally four pauses per GC
>>> cycle, sometimes less if cycle shortcuts.
>>>
>>>> 2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
>>>> 2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
>>>> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
>>>> 8645M->2324M(10G), 1.147 ms]
>>>> Free: 7358M (1853 regions), Max regular: 4096K, Max humongous: 962560K,
>>>> External frag: 88%, Internal frag: 0%
>>>> Evacuation Reserve: 509M (128 regions), Max regular: 4096K
>>>> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
>>>>     Using 4 of 4 workers for concurrent evacuation
>>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
>>>> 2324M->2329M(10G), 5.720 ms]
>>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, start]
>>>>     Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable: 735M,
>>>> Alloc Tax Rate: 1.1x
>>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061
>>> ms]
>>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
>>>> start]
>>>>     Using 4 of 4 workers for concurrent reference update
>>>> 2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
>>>> 2329M->2330M(10G), 23.211 ms]
>>>> 2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs, start]
>>>>     Using 4 of 4 workers for final reference update
>>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs, 1.142
>>> ms]
>>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
>>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
>>>> 2330M->390M(10G), 0.455 ms]
>>>> Free: 9321M (2345 regions), Max regular: 4096K, Max humongous: 4575232K,
>>>> External frag: 53%, Internal frag: 0%
>>>> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
>>>> Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
>>>> Trigger: Free (1023M) is below minimum threshold (1023M)
>>>> Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
>>>> External frag: 7%, Internal frag: 5%
>>>> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
>>>> 2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
>>>>     Using 4 of 4 workers for concurrent reset
>>>> 2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
>>>> 8640M->8643M(10G), 4.835 ms]
>>>> 2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
>>>> weakrefs), start]
>>>>     Using 4 of 4 workers for init marking
>>>>     Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable: 102M,
>>>> Alloc Tax Rate: 1.1x
>>>> 2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
>>>> weakrefs), 2.050 ms]
>>>
>>>
>>> --
>>> Thanks,
>>> -Aleksey
>>>
>>>


From alex at scalyr.com  Wed May 22 19:56:40 2019
From: alex at scalyr.com (Alex Elent)
Date: Wed, 22 May 2019 12:56:40 -0700
Subject: Measuring Stop-the-World(STW) Pauses
In-Reply-To: <fa6fab8e-5890-b437-6015-8ca9db46a74c@redhat.com>
References: <CAOrmtvMhp_s-wDUkV+HMWwkkE20P_mQoZDFpZotivwvZVNsxwQ@mail.gmail.com>
 <f57a814e-5fac-9e02-f79d-dcf671861966@redhat.com>
 <CAOrmtvNW8w78K1iOyJ6xCdgO9rkXhYAqBf2W3D4fYY6JfPOtZg@mail.gmail.com>
 <CAOrmtvNvDCKy1egAtP=LZsNVmzdG7odxCWtnwaRQDNaDWe=hsg@mail.gmail.com>
 <fa6fab8e-5890-b437-6015-8ca9db46a74c@redhat.com>
Message-ID: <CAOrmtvP3Y_6nGZXRfQ0nsj9drCTwGD63YczH1S5WDi+pB+SDwg@mail.gmail.com>

Thanks again gentlemen.

On Wed, May 22, 2019 at 12:53 PM Roman Kennke <rkennke at redhat.com> wrote:

> Hi Alex,
>
> > Just wanted to validate that this is also a STW pause:
> >
> > 2019-05-22T19:45:37.182+0000: 66424.311: [Pause Init Mark (process
> > weakrefs), 2.344 ms]
>
> Yes, it is. :-)
>
> Roman
>
>
>
> > Thanks,
> >
> > On Tue, May 21, 2019 at 2:47 PM Alex Elent <alex at scalyr.com> wrote:
> >
> >> That's absolutely perfect, thanks!
> >>
> >> On Tue, May 21, 2019 at 2:31 PM Aleksey Shipilev <shade at redhat.com>
> wrote:
> >>
> >>> On 5/21/19 11:14 PM, Alex Elent wrote:
> >>>> Should we be looking at entries that contain the "Pause" keyword?
> >>> Yes. Everything with "Pause" is global STW pause. This should correlate
> >>> to MXBean "Shenandoah
> >>> Pauses" (if you are running external monitoring service), safepoint
> >>> logging
> >>> (-XX:+PrintSafepointStatistics), etc. With -verbose:gc, you should also
> >>> have the summary table at
> >>> the end of the run, which would dissect the pauses more thoroughly.
> >>>
> >>> In your log below, there is 2.032ms Final Mark, 0.061ms Init Update
> Refs,
> >>> 1.142ms Final Update Refs
> >>> pauses (there should also be Init Mark in the beginning). There are
> >>> normally four pauses per GC
> >>> cycle, sometimes less if cycle shortcuts.
> >>>
> >>>> 2019-05-21T21:11:34.249+0000: 2026.775: [Pause Final Mark, 2.032 ms]
> >>>> 2019-05-21T21:11:34.249+0000: 2026.775: [Concurrent cleanup, start]
> >>>> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent cleanup
> >>>> 8645M->2324M(10G), 1.147 ms]
> >>>> Free: 7358M (1853 regions), Max regular: 4096K, Max humongous:
> 962560K,
> >>>> External frag: 88%, Internal frag: 0%
> >>>> Evacuation Reserve: 509M (128 regions), Max regular: 4096K
> >>>> 2019-05-21T21:11:34.250+0000: 2026.776: [Concurrent evacuation, start]
> >>>>     Using 4 of 4 workers for concurrent evacuation
> >>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent evacuation
> >>>> 2324M->2329M(10G), 5.720 ms]
> >>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs,
> start]
> >>>>     Pacer for Update Refs. Used: 2329M, Free: 7358M, Non-Taxable:
> 735M,
> >>>> Alloc Tax Rate: 1.1x
> >>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Pause Init Update Refs, 0.061
> >>> ms]
> >>>> 2019-05-21T21:11:34.256+0000: 2026.782: [Concurrent update references,
> >>>> start]
> >>>>     Using 4 of 4 workers for concurrent reference update
> >>>> 2019-05-21T21:11:34.279+0000: 2026.805: [Concurrent update references
> >>>> 2329M->2330M(10G), 23.211 ms]
> >>>> 2019-05-21T21:11:34.280+0000: 2026.806: [Pause Final Update Refs,
> start]
> >>>>     Using 4 of 4 workers for final reference update
> >>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Pause Final Update Refs,
> 1.142
> >>> ms]
> >>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup, start]
> >>>> 2019-05-21T21:11:34.281+0000: 2026.807: [Concurrent cleanup
> >>>> 2330M->390M(10G), 0.455 ms]
> >>>> Free: 9321M (2345 regions), Max regular: 4096K, Max humongous:
> 4575232K,
> >>>> External frag: 53%, Internal frag: 0%
> >>>> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> >>>> Pacer for Idle. Initial: 204M, Alloc Tax Rate: 1.0x
> >>>> Trigger: Free (1023M) is below minimum threshold (1023M)
> >>>> Free: 1023M (270 regions), Max regular: 4096K, Max humongous: 978944K,
> >>>> External frag: 7%, Internal frag: 5%
> >>>> Evacuation Reserve: 512M (128 regions), Max regular: 4096K
> >>>> 2019-05-21T21:12:15.373+0000: 2067.899: [Concurrent reset, start]
> >>>>     Using 4 of 4 workers for concurrent reset
> >>>> 2019-05-21T21:12:15.377+0000: 2067.903: [Concurrent reset
> >>>> 8640M->8643M(10G), 4.835 ms]
> >>>> 2019-05-21T21:12:15.378+0000: 2067.904: [Pause Init Mark (process
> >>>> weakrefs), start]
> >>>>     Using 4 of 4 workers for init marking
> >>>>     Pacer for Mark. Expected Live: 295M, Free: 1020M, Non-Taxable:
> 102M,
> >>>> Alloc Tax Rate: 1.1x
> >>>> 2019-05-21T21:12:15.380+0000: 2067.906: [Pause Init Mark (process
> >>>> weakrefs), 2.050 ms]
> >>>
> >>>
> >>> --
> >>> Thanks,
> >>> -Aleksey
> >>>
> >>>
>
>

From shade at redhat.com  Wed May 22 20:19:38 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 22 May 2019 22:19:38 +0200
Subject: RFR (S) 8224522: Shenandoah should apply barriers on
 deoptimization
In-Reply-To: <e9c6741a-df64-e6aa-3a58-fced2f4c6673@redhat.com>
References: <f160ba0e-bd13-b70c-d75b-473ae9add8e5@redhat.com>
 <2301c8d8-f7dc-1d7d-cf9a-3e20bdf1a079@redhat.com>
 <f91ee022-8bb4-d31a-f40d-f882fe907bcb@redhat.com>
 <e9c6741a-df64-e6aa-3a58-fced2f4c6673@redhat.com>
Message-ID: <c1f324cf-3808-d868-f195-305d20b19de5@redhat.com>

Thanks, pushed.

-Aleksey

On 5/22/19 8:42 PM, Zhengyu Gu wrote:
> Looks good.
> 
> -Zhengyu
> 
> On 5/22/19 10:39 AM, Aleksey Shipilev wrote:
>> On 5/22/19 9:40 AM, Aleksey Shipilev wrote:
>>> On 5/21/19 10:06 PM, Aleksey Shipilev wrote:
>>>> Fix:
>>>> ?? http://cr.openjdk.java.net/~shade/8224522/webrev.01/
>>>
>>> jdk-submit came clean. I am going to push it today.
>>
>> Ah no, I have only one reviewer yet (rkennke), and this is a shared code change. I'd like somebody
>> else to take a look as well.


From rkennke at redhat.com  Wed May 22 21:50:22 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 22 May 2019 23:50:22 +0200
Subject: RFR: JDK-8224626: Shenandoah: Elide barriers on uncommon traps
Message-ID: <c4b7a353-1009-1564-fd65-57e373dd14f8@redhat.com>

 We currently preserve all load-reference-barriers that feed into calls.
With Aleksey's recent change JDK-8224522 that places barriers at deopt
unpacking, we don't need to place barriers in generated code when an oop
only feeds into uncommon traps.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8224626
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8224626/webrev.00/

Testing: hotspot_gc_shenandoah, specjbb, specjvm all good

Ok?

Roman


From rwestrel at redhat.com  Thu May 23 08:07:58 2019
From: rwestrel at redhat.com (Roland Westrelin)
Date: Thu, 23 May 2019 10:07:58 +0200
Subject: RFR: JDK-8224626: Shenandoah: Elide barriers on uncommon traps
In-Reply-To: <c4b7a353-1009-1564-fd65-57e373dd14f8@redhat.com>
References: <c4b7a353-1009-1564-fd65-57e373dd14f8@redhat.com>
Message-ID: <87pno9k2zl.fsf@redhat.com>


> http://cr.openjdk.java.net/~rkennke/JDK-8224626/webrev.00/

Looks ok to me.

Roland.

From shade at redhat.com  Thu May 23 08:11:40 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 10:11:40 +0200
Subject: RFR: JDK-8224626: Shenandoah: Elide barriers on uncommon traps
In-Reply-To: <c4b7a353-1009-1564-fd65-57e373dd14f8@redhat.com>
References: <c4b7a353-1009-1564-fd65-57e373dd14f8@redhat.com>
Message-ID: <b4df5fad-f41a-e6f7-6558-f6183d9bcfa6@redhat.com>

On 5/22/19 11:50 PM, Roman Kennke wrote:
>  We currently preserve all load-reference-barriers that feed into calls.
> With Aleksey's recent change JDK-8224522 that places barriers at deopt
> unpacking, we don't need to place barriers in generated code when an oop
> only feeds into uncommon traps.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8224626
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8224626/webrev.00/

Okay.

-Aleksey


From shade at redhat.com  Thu May 23 10:40:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 12:40:46 +0200
Subject: RFR(XS) 8224115: Shenandoah: Eliminate RWLock that protects
 recorded nmethod data array
In-Reply-To: <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>
References: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
 <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>
Message-ID: <b2c38cfc-baf1-d97c-de51-34cca0a4a379@redhat.com>

On 5/20/19 1:26 PM, Zhengyu Gu wrote:
> Split the original patch, moved root processing changes that deal with traversal GC problem into
> JDK-8224179.
> 
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.01/

Looks fine, except:

What is this removal? It does not seem related:

 248 ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
 249   return ShenandoahAllCodeRootsIterator();
 250 }
 251
 252 ShenandoahCsetCodeRootsIterator ShenandoahCodeRoots::cset_iterator() {
 253   return ShenandoahCsetCodeRootsIterator();
 254 }

-Aleksey


From rkennke at redhat.com  Thu May 23 12:07:47 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 14:07:47 +0200
Subject: RFR (11): Clean up unused shenandoah_wb_C leftovers
Message-ID: <48855e69-0bb6-1c71-2ffd-317e0e2d2bc5@redhat.com>

This is a little cleanup in sh/jdk11. We have leftover use of
shenandoah_wb_C stub. It is not used anymore. This change removes the
relevant code and brings the affected code to state pre-LRB of jdk/jdk.
This is preparatory work for LRB backport to jdk 11.

http://cr.openjdk.java.net/~rkennke/jdk11-cleanup-wb-C/webrev.00/

Testing: hotspot_gc_shenandoah (x86/aarch64)

Good?

Roman



From rkennke at redhat.com  Thu May 23 12:17:08 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 14:17:08 +0200
Subject: RFR: JDK-8224667: Shenandoah: Post-LRB cleanup
Message-ID: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>

 We've got some leftover mentions of write-barrier in our code. We
better clean that up and change to corresponding load-reference-barrier
mentions. Also, some arraycopy code that previously named things
'READ-*' and 'WRITE-' is now more apppropriately named 'RESOLVE*' and
'EVAC*'.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8224667
Webrev:
http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.00/

Testing: hotspot_gc_shenandoah

Ok?

Roman


From zgu at redhat.com  Thu May 23 13:24:28 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 23 May 2019 09:24:28 -0400
Subject: RFR(XS) 8224115: Shenandoah: Eliminate RWLock that protects
 recorded nmethod data array
In-Reply-To: <b2c38cfc-baf1-d97c-de51-34cca0a4a379@redhat.com>
References: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
 <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>
 <b2c38cfc-baf1-d97c-de51-34cca0a4a379@redhat.com>
Message-ID: <57e16c8c-a5d3-c6e8-d656-1a83016bfa91@redhat.com>



On 5/23/19 6:40 AM, Aleksey Shipilev wrote:
> On 5/20/19 1:26 PM, Zhengyu Gu wrote:
>> Split the original patch, moved root processing changes that deal with traversal GC problem into
>> JDK-8224179.
>>
>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.01/
> 
> Looks fine, except:
> 
> What is this removal? It does not seem related:
> 
>   248 ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
>   249   return ShenandoahAllCodeRootsIterator();
>   250 }
>   251
>   252 ShenandoahCsetCodeRootsIterator ShenandoahCodeRoots::cset_iterator() {
>   253   return ShenandoahCsetCodeRootsIterator();
>   254 }

Can make separate patch. Both methods seem to depend on inline behavior 
to avoid fatal error, where they may free 
ShenandoahParallelCodeHeapIterator inside 
ShenandoahParallelCodeCacheIterator twice due to copy constructors.

Thanks,

-Zhengyu

> 
> -Aleksey
> 

From zgu at redhat.com  Thu May 23 15:01:35 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 23 May 2019 11:01:35 -0400
Subject: RFR(XS) 8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator
 noncopyable
Message-ID: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>

Copies may cause its member '_iters' to be freed multiple times.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From rkennke at redhat.com  Thu May 23 15:03:30 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 17:03:30 +0200
Subject: RFR: JDK-8224667: Shenandoah: Post-LRB cleanup
In-Reply-To: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>
References: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>
Message-ID: <87e74561-ab6c-3438-6940-f0d21a3cf119@redhat.com>

Somehow I managed to upload a totally unrelated webrev. Here's the
correct one:

http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.01/

Roman


>  We've got some leftover mentions of write-barrier in our code. We
> better clean that up and change to corresponding load-reference-barrier
> mentions. Also, some arraycopy code that previously named things
> 'READ-*' and 'WRITE-' is now more apppropriately named 'RESOLVE*' and
> 'EVAC*'.
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8224667
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.00/
> 
> Testing: hotspot_gc_shenandoah
> 
> Ok?
> 
> Roman
> 


From rkennke at redhat.com  Thu May 23 15:10:24 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 17:10:24 +0200
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
Message-ID: <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>

Are there no users of iterator() and cset_iterator()? Or which part am I
missing?

Roman


> Copies may cause its member '_iters' to be freed multiple times.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu


From zgu at redhat.com  Thu May 23 15:18:31 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 23 May 2019 11:18:31 -0400
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
 <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>
Message-ID: <2c741499-e568-f476-5102-b9ec419b86bd@redhat.com>

On 5/23/19 11:10 AM, Roman Kennke wrote:
> Are there no users of iterator() and cset_iterator()? Or which part am I
> missing?

We no longer use them since SRP refactor.

-Zhengyu

> 
> Roman
> 
> 
>> Copies may cause its member '_iters' to be freed multiple times.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
>>
>> Test:
>>  ? hotspot_gc_shenandoah (fastdebug and release)
>>
>> Thanks,
>>
>> -Zhengyu
> 

From rkennke at redhat.com  Thu May 23 15:19:30 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 17:19:30 +0200
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <2c741499-e568-f476-5102-b9ec419b86bd@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
 <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>
 <2c741499-e568-f476-5102-b9ec419b86bd@redhat.com>
Message-ID: <e4c4a2ff-ec2f-928c-a535-e2c677bfd2af@redhat.com>

>> Are there no users of iterator() and cset_iterator()? Or which part am I
>> missing?
> 
> We no longer use them since SRP refactor.

If we don't use them, why bother? Why not remove it instead?

Roman

> 
> -Zhengyu
> 
>>
>> Roman
>>
>>
>>> Copies may cause its member '_iters' to be freed multiple times.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
>>>
>>> Test:
>>> ?? hotspot_gc_shenandoah (fastdebug and release)
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>


From zgu at redhat.com  Thu May 23 15:21:47 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 23 May 2019 11:21:47 -0400
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <e4c4a2ff-ec2f-928c-a535-e2c677bfd2af@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
 <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>
 <2c741499-e568-f476-5102-b9ec419b86bd@redhat.com>
 <e4c4a2ff-ec2f-928c-a535-e2c677bfd2af@redhat.com>
Message-ID: <3d298330-f860-2941-232c-5b662ce7fb22@redhat.com>



On 5/23/19 11:19 AM, Roman Kennke wrote:
>>> Are there no users of iterator() and cset_iterator()? Or which part am I
>>> missing?
>>
>> We no longer use them since SRP refactor.
> 
> If we don't use them, why bother? Why not remove it instead?

Yes, we are removing them


diff --git a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp 
b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
+++ b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
@@ -245,14 +245,6 @@
    }
  }

-ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
-  return ShenandoahAllCodeRootsIterator();
-}
-
-ShenandoahCsetCodeRootsIterator ShenandoahCodeRoots::cset_iterator() {
-  return ShenandoahCsetCodeRootsIterator();
-}
-

-Zhengyu
> 
> Roman
> 
>>
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>
>>>> Copies may cause its member '_iters' to be freed multiple times.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
>>>>
>>>> Test:
>>>>  ?? hotspot_gc_shenandoah (fastdebug and release)
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
> 

From zgu at redhat.com  Thu May 23 15:29:16 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 23 May 2019 11:29:16 -0400
Subject: RFR(XS) 8224115: Shenandoah: Eliminate RWLock that protects
 recorded nmethod data array
In-Reply-To: <57e16c8c-a5d3-c6e8-d656-1a83016bfa91@redhat.com>
References: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
 <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>
 <b2c38cfc-baf1-d97c-de51-34cca0a4a379@redhat.com>
 <57e16c8c-a5d3-c6e8-d656-1a83016bfa91@redhat.com>
Message-ID: <27523810-aaaf-1bd8-f1ba-9804463c503e@redhat.com>



On 5/23/19 9:24 AM, Zhengyu Gu wrote:
> 
> 
> On 5/23/19 6:40 AM, Aleksey Shipilev wrote:
>> On 5/20/19 1:26 PM, Zhengyu Gu wrote:
>>> Split the original patch, moved root processing changes that deal 
>>> with traversal GC problem into
>>> JDK-8224179.
>>>
>>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.01/
>>
>> Looks fine, except:
>>
>> What is this removal? It does not seem related:
>>
>> ? 248 ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
>> ? 249?? return ShenandoahAllCodeRootsIterator();
>> ? 250 }
>> ? 251
>> ? 252 ShenandoahCsetCodeRootsIterator 
>> ShenandoahCodeRoots::cset_iterator() {
>> ? 253?? return ShenandoahCsetCodeRootsIterator();
>> ? 254 }
> 
> Can make separate patch. Both methods seem to depend on inline behavior 
> to avoid fatal error, where they may free 
> ShenandoahParallelCodeHeapIterator inside 
> ShenandoahParallelCodeCacheIterator twice due to copy constructors.

Addressed by JDK-8224679: Shenandoah: Make 
ShenandoahParallelCodeCacheIterator noncopyable	


Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.02/

Reran hotspot_gc_shenandoah tests.

Thanks,

-Zhengyu

> 
> Thanks,
> 
> -Zhengyu
> 
>>
>> -Aleksey
>>

From rkennke at redhat.com  Thu May 23 15:33:57 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 17:33:57 +0200
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <3d298330-f860-2941-232c-5b662ce7fb22@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
 <4355ba79-ffb1-95c7-a4dd-9b1ca26638f4@redhat.com>
 <2c741499-e568-f476-5102-b9ec419b86bd@redhat.com>
 <e4c4a2ff-ec2f-928c-a535-e2c677bfd2af@redhat.com>
 <3d298330-f860-2941-232c-5b662ce7fb22@redhat.com>
Message-ID: <720a23c2-6108-539c-e841-45ba87c676f8@redhat.com>

Duh. Of course :-)

Looks good. Thanks!

Roman


> On 5/23/19 11:19 AM, Roman Kennke wrote:
>>>> Are there no users of iterator() and cset_iterator()? Or which part
>>>> am I
>>>> missing?
>>>
>>> We no longer use them since SRP refactor.
>>
>> If we don't use them, why bother? Why not remove it instead?
> 
> Yes, we are removing them
> 
> 
> diff --git a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
> b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
> @@ -245,14 +245,6 @@
> ?? }
> ?}
> 
> -ShenandoahAllCodeRootsIterator ShenandoahCodeRoots::iterator() {
> -? return ShenandoahAllCodeRootsIterator();
> -}
> -
> -ShenandoahCsetCodeRootsIterator ShenandoahCodeRoots::cset_iterator() {
> -? return ShenandoahCsetCodeRootsIterator();
> -}
> -
> 
> -Zhengyu
>>
>> Roman
>>
>>>
>>> -Zhengyu
>>>
>>>>
>>>> Roman
>>>>
>>>>
>>>>> Copies may cause its member '_iters' to be freed multiple times.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679
>>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/
>>>>>
>>>>> Test:
>>>>> ??? hotspot_gc_shenandoah (fastdebug and release)
>>>>>
>>>>> Thanks,
>>>>>
>>>>> -Zhengyu
>>>>
>>


From shade at redhat.com  Thu May 23 19:08:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:08:45 +0200
Subject: RFC: Pick up 11.0.4+4 to sh/jdk11
Message-ID: <38b1592d-c7ab-5769-6316-2ecbb86a2c5d@redhat.com>

The trivial merge from jdk-updates/jdk11u, at 11.0.4+4. Since there are no Hotspot changes to care
about, and no Shenandoah changes since last tag, I would tag it immediately as shenandoah-jdk-11.0.4+4.

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b4/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 23 19:13:05 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:13:05 +0200
Subject: RFR (11): Clean up unused shenandoah_wb_C leftovers
In-Reply-To: <48855e69-0bb6-1c71-2ffd-317e0e2d2bc5@redhat.com>
References: <48855e69-0bb6-1c71-2ffd-317e0e2d2bc5@redhat.com>
Message-ID: <41b7c242-6fa8-9427-3cdd-53f8a467edb6@redhat.com>

On 5/23/19 2:07 PM, Roman Kennke wrote:
> This is a little cleanup in sh/jdk11. We have leftover use of
> shenandoah_wb_C stub. It is not used anymore. This change removes the
> relevant code and brings the affected code to state pre-LRB of jdk/jdk.
> This is preparatory work for LRB backport to jdk 11.
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-cleanup-wb-C/webrev.00/

Looks good. Please push it after the 11.0.4+4 pickup is in, so we have some testing done.

-Aleksey


From shade at redhat.com  Thu May 23 19:17:00 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:17:00 +0200
Subject: RFR: JDK-8224667: Shenandoah: Post-LRB cleanup
In-Reply-To: <87e74561-ab6c-3438-6940-f0d21a3cf119@redhat.com>
References: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>
 <87e74561-ab6c-3438-6940-f0d21a3cf119@redhat.com>
Message-ID: <ff669329-8fba-b5b9-31c3-1e9e95058a10@redhat.com>

On 5/23/19 5:03 PM, Roman Kennke wrote:
> Somehow I managed to upload a totally unrelated webrev. Here's the
> correct one:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.01/

*) Missed the spot (read the comments), shenandoahBarrierSet.inline.hpp:

 271  case RESOLVE_BARRIER:
 272  case EVAC_BARRIER:
 273    // The write-barrier case cannot really happen. It's traversal-only and traversal
 274    // doesn't currently use SATB. And even if it did, it would not be fatal to just do the
normal RB here.

No other mentions of "RB", "WB", "read barrier", "read-barrier", "write barrier", "write-barrier" in
shenandoah/ folders?

Thanks,
-Aleksey


From shade at redhat.com  Thu May 23 19:28:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:28:16 +0200
Subject: RFR(XS) 8224679: Shenandoah: Make
 ShenandoahParallelCodeCacheIterator noncopyable
In-Reply-To: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
References: <911cd8f8-9a5f-4bbd-1e81-444568a3d587@redhat.com>
Message-ID: <10f5877f-79dd-471f-68e3-4af39e617b40@redhat.com>

On 5/23/19 5:01 PM, Zhengyu Gu wrote:
> Copies may cause its member '_iters' to be freed multiple times.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224679

Please link the issue that made these redundant.

> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224679/webrev.00/

Please match what ShenandoahRegionIterator does, notably, declare variables? I remember the absence
of those tripped some compilers.

  // No implicit copying: iterators should be passed by reference to capture the state
  ShenandoahRegionIterator(const ShenandoahRegionIterator& that);
  ShenandoahRegionIterator& operator=(const ShenandoahRegionIterator& o);

Otherwise good.

-Aleksey


From shade at redhat.com  Thu May 23 19:32:55 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:32:55 +0200
Subject: RFR(XS) 8224115: Shenandoah: Eliminate RWLock that protects
 recorded nmethod data array
In-Reply-To: <27523810-aaaf-1bd8-f1ba-9804463c503e@redhat.com>
References: <3f736be4-bf6f-1559-f8fe-66902ce97c9f@redhat.com>
 <25e4be93-8496-3c6b-127e-30d2ef9fc4e8@redhat.com>
 <b2c38cfc-baf1-d97c-de51-34cca0a4a379@redhat.com>
 <57e16c8c-a5d3-c6e8-d656-1a83016bfa91@redhat.com>
 <27523810-aaaf-1bd8-f1ba-9804463c503e@redhat.com>
Message-ID: <5c3f5a8f-683c-a629-8234-ffa48d9f3d6e@redhat.com>

On 5/23/19 5:29 PM, Zhengyu Gu wrote:
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224115/webrev.02/
> 
> Reran hotspot_gc_shenandoah tests.

Okay, looks good!

-Aleksey


From rkennke at redhat.com  Thu May 23 19:46:11 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 21:46:11 +0200
Subject: RFC: Pick up 11.0.4+4 to sh/jdk11
In-Reply-To: <38b1592d-c7ab-5769-6316-2ecbb86a2c5d@redhat.com>
References: <38b1592d-c7ab-5769-6316-2ecbb86a2c5d@redhat.com>
Message-ID: <4318d7e2-fcaf-1b64-e50f-d74057e25d4d@redhat.com>

Good with me!

Roman


> The trivial merge from jdk-updates/jdk11u, at 11.0.4+4. Since there are no Hotspot changes to care
> about, and no Shenandoah changes since last tag, I would tag it immediately as shenandoah-jdk-11.0.4+4.
> 
> Changesets:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b4/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}
> 


From shade at redhat.com  Thu May 23 19:47:10 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 23 May 2019 19:47:10 +0000
Subject: hg: shenandoah/jdk11: 29 new changesets
Message-ID: <201905231947.x4NJlC96020006@aojmv0008.oracle.com>

Changeset: 77b2c252913d
Author:    itakiguchi
Date:      2019-02-01 15:34 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/77b2c252913d

8212677: X11 default visual support for IM status window on VNC
Reviewed-by: serb, naoto

! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c
! src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c

Changeset: 2c17b4d4fbdb
Author:    rriggs
Date:      2019-05-17 10:48 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2c17b4d4fbdb

8220166: Performance regression in deserialization (4-6% in SPECjbb)
Reviewed-by: shade, dholmes, alanb

! src/java.base/share/classes/java/io/ObjectInputFilter.java

Changeset: 1c8cd5b5d362
Author:    gromero
Date:      2018-09-04 11:46 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1c8cd5b5d362

8210320: PPC64: Fix uninitialized variable in C1 LIR assembler code
Reviewed-by: mbaesken, shade, mdoerr

! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp

Changeset: 97944ed2319d
Author:    shade
Date:      2018-12-13 16:45 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/97944ed2319d

8181143: Introduce diagnostic flag to abort VM on too long VM operations
Reviewed-by: rkennke, zgu, dholmes, stuefe, rehn

! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/vmThread.cpp
! src/hotspot/share/runtime/vmThread.hpp
+ test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java

Changeset: 7d5f1ead0e07
Author:    shade
Date:      2018-12-14 12:56 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7d5f1ead0e07

8215374: 32-bit build failures after JDK-8181143 (Introduce diagnostic flag to abort VM on too long VM operations)
Reviewed-by: roland

! src/hotspot/share/runtime/vmThread.cpp

Changeset: 5531c3fda6dd
Author:    jgeorge
Date:      2018-12-10 19:08 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/5531c3fda6dd

8215026: Incorrect amount of memory unmapped with ImageFileReader::close()
Summary: Use map_size() instead of _index_size as the amount of memory to be unmapped while closing an image file
Reviewed-by: alanb, jlaskey

! src/java.base/share/native/libjimage/imageFile.cpp

Changeset: 81e8ea3599c9
Author:    jgeorge
Date:      2018-12-12 10:13 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/81e8ea3599c9

8200613: SA: jstack throws UnmappedAddressException with a CDS core file
Summary: Dump the closed archive heap space into the corefile on Linux by setting bit 2 of the coredump_filter file to dump the file backed private mappings.
Reviewed-by: iklam, cjplummer, kevinw, coleenp

! src/hotspot/os/linux/globals_linux.hpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoader.hpp
! test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java

Changeset: e72fc2367172
Author:    sgehwolf
Date:      2018-12-13 10:25 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e72fc2367172

8215342: [Zero] Build fails after JDK-8200613
Reviewed-by: shade, jgeorge
Contributed-by: Christophe Phillips <chphilli at redhat.com>

! src/hotspot/os/linux/os_linux.cpp

Changeset: 210d56ef6135
Author:    ysuenaga
Date:      2019-02-21 21:02 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/210d56ef6135

8219414: SA: jhsdb jsnap throws UnmappedAddressException with core generated by gcore
Reviewed-by: cjplummer, jgeorge

! src/hotspot/os/linux/globals_linux.hpp
! src/hotspot/os/linux/os_linux.cpp

Changeset: 3e9a39ec55da
Author:    shade
Date:      2019-02-22 17:54 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3e9a39ec55da

8219574: Minimal VM build failure after JDK-8219414
Reviewed-by: jgeorge, dholmes, cjplummer

! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/share/classfile/classLoader.cpp

Changeset: 9ee5d5bda9a3
Author:    clanger
Date:      2019-05-14 09:25 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/9ee5d5bda9a3

8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc <entries20> failed 6af4413c vs 0 ...)
Reviewed-by: redestad, lancea

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
! test/jdk/jdk/nio/zipfs/ZipFSTester.java

Changeset: 43e22009e009
Author:    prr
Date:      2018-11-01 13:56 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/43e22009e009

8213213: Remove src/java.desktop/unix/classes/sun/awt/X11/keysym2ucs.h
Reviewed-by: serb

! src/java.desktop/unix/classes/sun/awt/X11/XKeysym.java
- src/java.desktop/unix/classes/sun/awt/X11/genhash.awk
- src/java.desktop/unix/classes/sun/awt/X11/keysym2ucs.h
! src/java.desktop/unix/legal/xwindows.md

Changeset: 1d48e3245136
Author:    pmuthuswamy
Date:      2018-12-12 13:01 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1d48e3245136

8214468: jQuery UI upgrade from 1.11.4 to 1.12.1
Reviewed-by: hannesw

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_flat_0_aaaaaa_40x100.png
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_flat_75_ffffff_40x100.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_55_fbf9ee_1x400.png
+ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_65_dadada_1x400.png
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_65_ffffff_1x400.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_75_dadada_1x400.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_75_e6e6e6_1x400.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_95_fef1ec_1x400.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_highlight-soft_75_cccccc_1x100.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-icons_222222_256x240.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-icons_2e83ff_256x240.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-icons_454545_256x240.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-icons_888888_256x240.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-icons_cd0a0a_256x240.png
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.css
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.js
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.min.css
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.min.js
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.structure.css
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-ui.structure.min.css
! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js
! src/jdk.javadoc/share/legal/jqueryUI.md
! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java
! test/langtools/jdk/javadoc/tool/api/basic/APITest.java
! test/langtools/tools/javadoc/api/basic/APITest.java

Changeset: 559d95b50f8a
Author:    pbansal
Date:      2019-01-18 13:54 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/559d95b50f8a

8214765: All TrayIcon MessageType icons does not show up with gtk3 option set
Reviewed-by: serb, psadhukhan

! src/java.desktop/unix/classes/sun/awt/X11/InfoWindow.java

Changeset: ea7243346301
Author:    nishjain
Date:      2019-01-31 13:05 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ea7243346301

8214935: Upgrade IANA LSR data
Reviewed-by: rriggs, naoto

! make/data/lsrdata/language-subtag-registry.txt

Changeset: 665635fc1779
Author:    naoto
Date:      2019-02-21 10:26 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/665635fc1779

8218960: CONFIG level logging statements printed in CLDRCalendarDataProviderImpl.java even when default log Level is INFO
Reviewed-by: nishjain, rriggs

! src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
! src/java.base/share/classes/sun/util/locale/provider/CalendarDataUtility.java
! src/java.base/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java
+ test/jdk/sun/util/locale/provider/CheckLoggingFromLocaleProvider.java

Changeset: d13519767b9c
Author:    aivanov
Date:      2019-04-09 08:50 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/d13519767b9c

8221263: [TEST_BUG] RemotePrinterStatusRefresh test is hard to use
Reviewed-by: serb, prr

! test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java

Changeset: edbee2271b33
Author:    weijun
Date:      2019-03-26 21:33 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/edbee2271b33

8217690: Update public suffix version
Reviewed-by: mullan

! make/data/publicsuffixlist/VERSION
! make/data/publicsuffixlist/public_suffix_list.dat

Changeset: a9e99b290e8e
Author:    rhalade
Date:      2019-05-15 13:22 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/a9e99b290e8e

8222136: Remove two Comodo root CA certificates that are expiring
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 7121bf2ba203
Author:    itakiguchi
Date:      2019-04-22 18:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7121bf2ba203

8212676: AWT SystemColor setting on CDE
Reviewed-by: serb

! src/java.desktop/share/classes/sun/awt/OSInfo.java
! src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java

Changeset: 8eb76ea9dbbe
Author:    itakiguchi
Date:      2019-04-30 14:30 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/8eb76ea9dbbe

8213232: Unix/X11 setCompositionEnableNative issue
Reviewed-by: serb

! src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c
! src/java.desktop/share/classes/sun/awt/im/InputContext.java
! src/java.desktop/unix/classes/sun/awt/X11InputMethod.java
! src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c

Changeset: 1ebbf0415bad
Author:    itakiguchi
Date:      2019-05-08 22:59 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1ebbf0415bad

8211826: StringIndexOutOfBoundsException happens via GetStringUTFRegion()
Reviewed-by: serb

! src/java.desktop/unix/native/libawt_xawt/awt/awt_UNIXToolkit.c
! src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c
+ test/jdk/java/awt/Gtk/GtkJNITest/GtkIconTest.java

Changeset: 4c216e5efa3e
Author:    rhalade
Date:      2019-05-16 12:36 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4c216e5efa3e

8223499: Remove two DocuSign root certificates that are expiring
Reviewed-by: mullan

! src/java.base/share/lib/security/cacerts
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 2a0081be4c4c
Author:    mbaesken
Date:      2019-03-18 16:04 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2a0081be4c4c

8220781: linux-s390 : os::get_summary_cpu_info gives bad output
Reviewed-by: dholmes, lucy

! src/hotspot/os/linux/os_linux.cpp

Changeset: db3fd1c27386
Author:    mbaesken
Date:      2019-04-08 14:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/db3fd1c27386

8221535: add steal tick related information to hs_error file [linux]
Reviewed-by: dholmes, goetz

! src/hotspot/os/aix/os_perf_aix.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/linux/os_linux.hpp
! src/hotspot/os/linux/os_perf_linux.cpp

Changeset: e442b78d7687
Author:    sgehwolf
Date:      2019-05-21 11:17 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e442b78d7687

8224474: harfbuzz 2.3.1 code fails to compile with gcc 4.4.7
Summary: Move GCC pragmas outside functions
Reviewed-by: clanger, aph

! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh
! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-machinery.hh

Changeset: 435ba0b576c9
Author:    goetz
Date:      2019-05-22 15:02 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/435ba0b576c9

Added tag jdk-11.0.4+4 for changeset e442b78d7687

! .hgtags

Changeset: 3a3ca39c60b2
Author:    shade
Date:      2019-05-23 21:02 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3a3ca39c60b2

Merge

! .hgtags
! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp
! src/hotspot/os/linux/os_linux.cpp
- src/java.desktop/unix/classes/sun/awt/X11/genhash.awk
- src/java.desktop/unix/classes/sun/awt/X11/keysym2ucs.h
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_flat_0_aaaaaa_40x100.png
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_flat_75_ffffff_40x100.png
- src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/images/ui-bg_glass_65_ffffff_1x400.png

Changeset: 66d8898a72f3
Author:    shade
Date:      2019-05-23 21:03 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/66d8898a72f3

Added tag shenandoah-jdk-11.0.4+4 for changeset 3a3ca39c60b2

! .hgtags


From shade at redhat.com  Thu May 23 19:47:22 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:47:22 +0200
Subject: RFC: Pick up 11.0.4+4 to sh/jdk11
In-Reply-To: <4318d7e2-fcaf-1b64-e50f-d74057e25d4d@redhat.com>
References: <38b1592d-c7ab-5769-6316-2ecbb86a2c5d@redhat.com>
 <4318d7e2-fcaf-1b64-e50f-d74057e25d4d@redhat.com>
Message-ID: <daf96180-78d8-342b-7588-89d18c785fa0@redhat.com>

And pushed.

-Aleksey

On 5/23/19 9:46 PM, Roman Kennke wrote:
> Good with me!
> 
> Roman
> 
> 
>> The trivial merge from jdk-updates/jdk11u, at 11.0.4+4. Since there are no Hotspot changes to care
>> about, and no Shenandoah changes since last tag, I would tag it immediately as shenandoah-jdk-11.0.4+4.
>>
>> Changesets:
>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b4/changesets.txt
>>
>> Testing: hotspot_gc_shenandoah {fastdebug|release}
>>
> 



From rkennke at redhat.com  Thu May 23 19:50:45 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 23 May 2019 21:50:45 +0200
Subject: RFR: JDK-8224667: Shenandoah: Post-LRB cleanup
In-Reply-To: <ff669329-8fba-b5b9-31c3-1e9e95058a10@redhat.com>
References: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>
 <87e74561-ab6c-3438-6940-f0d21a3cf119@redhat.com>
 <ff669329-8fba-b5b9-31c3-1e9e95058a10@redhat.com>
Message-ID: <cb9da016-3a4c-9224-4572-3e145a235921@redhat.com>

Ooops.

http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.02/

I've grepped for various keywords again, including the ones you listed.
No match.

Ok?

Roman

> On 5/23/19 5:03 PM, Roman Kennke wrote:
>> Somehow I managed to upload a totally unrelated webrev. Here's the
>> correct one:
>>
>> http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.01/
> 
> *) Missed the spot (read the comments), shenandoahBarrierSet.inline.hpp:
> 
>  271  case RESOLVE_BARRIER:
>  272  case EVAC_BARRIER:
>  273    // The write-barrier case cannot really happen. It's traversal-only and traversal
>  274    // doesn't currently use SATB. And even if it did, it would not be fatal to just do the
> normal RB here.
> 
> No other mentions of "RB", "WB", "read barrier", "read-barrier", "write barrier", "write-barrier" in
> shenandoah/ folders?
> 
> Thanks,
> -Aleksey
> 


From shade at redhat.com  Thu May 23 19:53:05 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 23 May 2019 21:53:05 +0200
Subject: RFR: JDK-8224667: Shenandoah: Post-LRB cleanup
In-Reply-To: <cb9da016-3a4c-9224-4572-3e145a235921@redhat.com>
References: <7e1bb712-cefa-877d-a21b-fd7b10c0c3c5@redhat.com>
 <87e74561-ab6c-3438-6940-f0d21a3cf119@redhat.com>
 <ff669329-8fba-b5b9-31c3-1e9e95058a10@redhat.com>
 <cb9da016-3a4c-9224-4572-3e145a235921@redhat.com>
Message-ID: <e4c10cc9-aa0c-a20b-8b7b-19df1044f798@redhat.com>

On 5/23/19 9:50 PM, Roman Kennke wrote:
> Ooops.
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8224667/webrev.02/
> 
> I've grepped for various keywords again, including the ones you listed.
> No match.
> 
> Ok?
OK then!

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Thu May 23 21:38:35 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Thu, 23 May 2019 22:38:35 +0100
Subject: RFR/RFC: Pick up aarch64-shenandoah-jdk8u222-b02 to sh/jdk8
In-Reply-To: <8f6d76cb-560f-9cf6-cea7-768271f418d7@redhat.com>
References: <dc392693-a164-f51c-a7a8-00b6ffffa041@redhat.com>
 <8f6d76cb-560f-9cf6-cea7-768271f418d7@redhat.com>
Message-ID: <9f70ef03-e6e6-f9af-66ee-2c8f9b364e30@redhat.com>

On 22/05/2019 07:56, Aleksey Shipilev wrote:
> Ping Andrew Hughes.
> 
> On 5/20/19 12:26 PM, Aleksey Shipilev wrote:
>> Hi,
>>
>> This is our first ever merge from aarch64-port/jdk8u-shenandoah to sh/jdk8. This picks up
>> aarch64-shenandoah-jdk8u222-b02 tag and merges it into sh/jdk8.
>>
>> Changesets (only hotspot, others are trivial):
>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/changesets.txt
>>
>> Webrev (only hotspot, others are trivial):
>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/webrev.01/
>>
>> Testing: hotspot_gc_shenandoah {fastdebug,release}
>>
>> Andrew Hughes, we need to agree on process here. The way it is done right now, we are doing this:
>>  a. Pull aarch64-port/jdk8u-shenandoah -> sh/jdk8, merge
>>  b. Test it, pile on our backports
>>  c. Repeat (a)-(b) until Shenandoah is stable
>>  d. RFR the pull sh/jdk8 -> aarch64-port/jdk8u-shenandoah, tag it appropriately
>>
>> Since aarch64-port/jdk8u-shenandoah and sh/jdk8 are related now, this allows us to push/pull between
>> them without any Mercurial voodoo. The caveat there is that the pull at (d) would include a few
>> local "merge" changesets from (a), are you fine with that? I also prefer not to introduce new
>> sh/jdk8-specific tags to avoid contaminating aarch64-port/jdk8u-shenandoah with them, so those
>> merges would be untagged.

That doesn't sound problematic. I'd prefer they were "Merge <tag>"
rather than "Merge" if possible. I've never understood why jcheck only
allows the latter.

>>
>> You could ask why don't we just push the backports to aarch64-port/jdk8u-shenandoah, but the trouble
>> is that 8u is a mess GC-interface-wise, and we would like to have sh/jdk8 as additional sandbox to
>> test for ourselves before integrating. It would be better as we backport more simplifications like
>> LRB and nofwdptr features into sh/jdk8u, which would get Shenandoah upstream exposure down
>> significantly. But so far it is what it is.
>>
> 

I'm happy with whatever way you're most comfortable.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From rkennke at redhat.com  Fri May 24 09:43:36 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Fri, 24 May 2019 09:43:36 +0000
Subject: hg: shenandoah/jdk11: Clean up unused shenandoah_wb_C leftovers
Message-ID: <201905240943.x4O9hbHW007258@aojmv0008.oracle.com>

Changeset: 2c1b64179c11
Author:    rkennke
Date:      2019-05-23 14:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2c1b64179c11

Clean up unused shenandoah_wb_C leftovers

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
- src/hotspot/share/gc/shenandoah/shenandoahBarrierSetAssembler.cpp
! src/hotspot/share/opto/lcm.cpp


From gnu.andrew at redhat.com  Fri May 24 19:20:02 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Fri, 24 May 2019 20:20:02 +0100
Subject: RFR] [8u] 8u222-b03 Upstream Sync
Message-ID: <e920d489-9922-eb9c-6f95-9e0e8bdd1660@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/

Merge changesets:

http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u222-b03:
  - S7100957: SOCKS proxying does not work with IPv6 connections
  - S7102541: RFE: os::set_native_thread_name() cleanups
  - S8144332: HSDB could not terminate when close button is pushed.
  - S8151322: Implement os::set_native_thread_name() on Solaris
  - S8154387: Parallel unordered Stream.limit() tries to collect 128
elements even if limit is less
  - S8189131: Open-source the Oracle JDK Root Certificates
  - S8189949: Remove Baltimore Cybertrust Code Signing CA
  - S8191031: Remove several Symantec Root CAs
  - S8191844: Remove SECOM root (secomevrootca1)
  - S8195774: Add Entrust root certificates
  - S8195793: Remove GTE CyberTrust Global Root
  - S8196141: Add GoDaddy root certificates
  - S8199779: Add T-Systems, GlobalSign and Starfield services root
certificates
  - S8204923: Restore Symantec root verisignclass2g2ca
  - S8209506: Add Google Trust Services GlobalSign root certificates
  - S8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled
without optimization
  - S8210432: Add additional TeliaSonera root certificate
  - S8213213: Remove src/java.desktop/unix/classes/sun/awt/X11/keysym2ucs.h
  - S8214770: java/time/test/java/time/format/TestNonIsoFormatter.java
failed in non-english locales.
  - S8216577: Add GlobalSign's R6 Root certificate
  - S8218152: [javac] fails and exits with no error if a bad annotation
processor provided
  - S8222136: Remove two Comodo root CA certificates that are expiring
  - S8222137: Remove T-Systems root CA certificate
  - S8223555: Cleanups in cacerts tests
  - S8223664: Add jtreg tests for 8223528, backport to jdk8u of 8176100

Main issues of note:

No changes that really affect Shenandoah. We do need to bring in the
AArch64 chunk of 8210425, but I'll do that in the next batch (didn't
notice it until building RPMs)

diffstat for corba
 b/.hgtags            |    1 +
 b/THIRD_PARTY_README |   49
-------------------------------------------------
 2 files changed, 1 insertion(+), 49 deletions(-)
diffstat for jaxp
 b/.hgtags            |    1 +
 b/THIRD_PARTY_README |   49
-------------------------------------------------
 2 files changed, 1 insertion(+), 49 deletions(-)
diffstat for jaxws
 b/.hgtags            |    1 +
 b/THIRD_PARTY_README |   49
-------------------------------------------------
 2 files changed, 1 insertion(+), 49 deletions(-)
diffstat for langtools
 b/.hgtags
            |    1
 b/THIRD_PARTY_README
            |   49 ---
 b/src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java |   10
 b/src/share/classes/com/sun/tools/javac/resources/compiler.properties
            |    5
 b/test/tools/javac/annotations/8218152/MalformedAnnotationProcessorTests.java      |  158 ++++++++++
 b/test/tools/javac/diags/examples.not-yet.txt
            |    1
 6 files changed, 173 insertions(+), 51 deletions(-)
diffstat for nashorn
 b/.hgtags            |    1 +
 b/THIRD_PARTY_README |   49
-------------------------------------------------
 2 files changed, 1 insertion(+), 49 deletions(-)
diffstat for jdk
 a/src/solaris/classes/sun/awt/X11/genhash.awk
                              |   45
 a/src/solaris/classes/sun/awt/X11/keysym2ucs.h
                              | 2758 ----------
 b/.hgtags
                              |    1
 b/THIRD_PARTY_README
                              |   49
 b/src/share/classes/java/net/SocksSocketImpl.java
                              |   10
 b/src/share/classes/java/util/stream/StreamSpliterators.java
                              |   17
 b/src/solaris/classes/sun/awt/X11/XKeysym.java
                              |   26
 b/test/TEST.groups
                              |    3
 b/test/java/net/Socks/SocksIPv6Test.java
                              |  178
 b/test/java/net/Socks/SocksServer.java
                              |   34
 b/test/java/time/test/java/time/format/TestNonIsoFormatter.java
                              |    2
 b/test/security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java              |  253
 b/test/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java              |  291 +
 b/test/security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java               |  674 ++
 b/test/security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java               |  280 +
 b/test/security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java              |  169
 b/test/security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java         |  202
 b/test/security/infra/java/security/cert/CertPathValidator/certification/GoDaddyCA.java              |  346 +
 b/test/security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java          |  181
 b/test/security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java             |  471 +
 b/test/security/infra/java/security/cert/CertPathValidator/certification/TeliaSoneraCA.java          |  195
 b/test/security/infra/java/security/cert/CertPathValidator/certification/ValidatePathWithParams.java |  354 +
 b/test/sun/security/lib/cacerts/VerifyCACerts.java
                              |  362 +
 23 files changed, 4005 insertions(+), 2896 deletions(-)
diffstat for hotspot
 b/.hgtags                                               |    1
 b/THIRD_PARTY_README                                    |   49 -----
 b/agent/src/share/classes/sun/jvm/hotspot/HSDB.java     |   18 +-
 b/make/bsd/makefiles/amd64.make                         |   15 +
 b/make/bsd/makefiles/i486.make                          |   14 +
 b/make/bsd/makefiles/ppc.make                           |   12 +
 b/make/bsd/makefiles/zeroshark.make                     |   14 +
 b/make/linux/makefiles/amd64.make                       |   14 +
 b/make/linux/makefiles/i486.make                        |   14 +
 b/make/linux/makefiles/ppc64.make                       |   11 +
 b/make/linux/makefiles/zeroshark.make                   |   14 +
 b/src/os/linux/vm/os_linux.cpp                          |   16 +
 b/src/os/linux/vm/os_linux.hpp                          |    1
 b/src/os/solaris/vm/os_solaris.cpp                      |   19 +-
 b/src/os/solaris/vm/os_solaris.hpp                      |    5
 b/src/os/windows/vm/os_windows.cpp                      |   25 ++
 b/src/share/vm/runtime/thread.cpp                       |    1
 b/src/share/vm/runtime/vmThread.cpp                     |    1
 b/src/share/vm/utilities/globalDefinitions.hpp          |    2
 b/test/runtime/jni/CallWithJNIWeak/CallWithJNIWeak.c    |  142
++++++++++++++++
 b/test/runtime/jni/CallWithJNIWeak/CallWithJNIWeak.java |   63 +++++++
 b/test/runtime/jni/CallWithJNIWeak/test.sh              |   93 ++++++++++
 b/test/runtime/jni/ReturnJNIWeak/ReturnJNIWeak.c        |   52 +++++
 b/test/runtime/jni/ReturnJNIWeak/ReturnJNIWeak.java     |  122
+++++++++++++
 b/test/runtime/jni/ReturnJNIWeak/test.sh                |   93 ++++++++++
 25 files changed, 721 insertions(+), 90 deletions(-)
diffstat for root
 b/.hgtags            |    1 +
 b/THIRD_PARTY_README |   49
-------------------------------------------------
 2 files changed, 1 insertion(+), 49 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Sun May 26 21:34:27 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Sun, 26 May 2019 23:34:27 +0200
Subject: RFR] [8u] 8u222-b03 Upstream Sync
In-Reply-To: <e920d489-9922-eb9c-6f95-9e0e8bdd1660@redhat.com>
References: <e920d489-9922-eb9c-6f95-9e0e8bdd1660@redhat.com>
Message-ID: <10204a7b-c947-c12b-6bc8-a33fcb5d10c9@redhat.com>

On 5/24/19 9:20 PM, Andrew John Hughes wrote:
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/corba/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxws/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/nashorn/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/root/merge.changeset

Trivial.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jdk/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/hotspot/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/langtools/merge.changeset

Looks good.

-Aleksey


From shade at redhat.com  Mon May 27 08:35:33 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:33 +0000
Subject: hg: shenandoah/jdk8: 16 new changesets
Message-ID: <201905270835.x4R8ZXNm006671@aojmv0008.oracle.com>

Changeset: 84abdd92cb0c
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/84abdd92cb0c

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 1dd3e61c5c50

! .hgtags

Changeset: 6857b11f17b1
Author:    clanger
Date:      2019-03-18 08:41 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/6857b11f17b1

Added tag jdk8u222-b00 for changeset 5af73acc6b6c

! .hgtags

Changeset: a15c48796bec
Author:    clanger
Date:      2019-03-18 08:46 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/a15c48796bec

Merge

! .hgtags

Changeset: 9a4af54dd074
Author:    ihse
Date:      2019-03-22 17:51 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/9a4af54dd074

8192854: FONTCONFIG_CFLAGS missing from spec.gmk.in
Summary: Add FONTCONFIG_CFLAGS declaration.
Reviewed-by: erikj, prr

! common/autoconf/spec.gmk.in

Changeset: f6bc08715234
Author:    clanger
Date:      2019-04-01 14:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/f6bc08715234

Merge

! .hgtags
! common/autoconf/spec.gmk.in

Changeset: 0bbd2bf737bf
Author:    kevinw
Date:      2019-04-04 08:01 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/0bbd2bf737bf

8221789: make reconfigure broken (jdk8u only)
Reviewed-by: phh, martin

! make/Main.gmk

Changeset: c52bf8887eb0
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/c52bf8887eb0

Added tag jdk8u212-ga for changeset 5218ef8ea6c3

! .hgtags

Changeset: 892833503e6f
Author:    andrew
Date:      2019-04-25 05:11 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/892833503e6f

Merge

! .hgtags

Changeset: 84adf64edebb
Author:    stooke
Date:      2019-04-26 17:11 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/84adf64edebb

8222975: Fix 'release' file to reflect actual repo checkin used to compile JDK
Summary: Use 'hg id -i' instead of 'hg tip' for obtaining the source revision
Reviewed-by: andrew

! make/common/MakeBase.gmk

Changeset: 9d00e3f144e0
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/9d00e3f144e0

Added tag jdk8u222-b01 for changeset 84adf64edebb

! .hgtags

Changeset: 1655c4f62e9d
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/1655c4f62e9d

Merge jdk8u222-b01

! .hgtags

Changeset: 20ce6b352f9a
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/20ce6b352f9a

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset 1655c4f62e9d

! .hgtags

Changeset: 3a2c8d0a600d
Author:    sgehwolf
Date:      2019-04-29 14:23 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/3a2c8d0a600d

8210416: [linux] Poor StrictMath performance due to non-optimized compilation
Summary: Compile fdlibm with -O3 and relevant C flags on gcc arches.
Reviewed-by: mbaesken, andrew

! common/autoconf/flags.m4
! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in

Changeset: e4f636834af7
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/e4f636834af7

Added tag jdk8u222-b02 for changeset 3a2c8d0a600d

! .hgtags

Changeset: 771de19e5f51
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/771de19e5f51

Merge jdk8u222-b02

! .hgtags
! common/autoconf/flags.m4
! common/autoconf/generated-configure.sh

Changeset: c54186dc7440
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/rev/c54186dc7440

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset 771de19e5f51

! .hgtags


From shade at redhat.com  Mon May 27 08:35:35 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:35 +0000
Subject: hg: shenandoah/jdk8/corba: 12 new changesets
Message-ID: <201905270835.x4R8ZZ2W006793@aojmv0008.oracle.com>

Changeset: 21451af2aa86
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/21451af2aa86

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 59220ef37e45

! .hgtags

Changeset: a9a55b6b64e8
Author:    clanger
Date:      2019-03-18 08:48 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/a9a55b6b64e8

Added tag jdk8u222-b00 for changeset e41d4e43109e

! .hgtags

Changeset: 4423816f0aae
Author:    clanger
Date:      2019-03-18 08:50 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/4423816f0aae

Merge

! .hgtags

Changeset: b223e13e5926
Author:    clanger
Date:      2019-04-01 14:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/b223e13e5926

Merge

! .hgtags

Changeset: 5e0bcca758bf
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/5e0bcca758bf

Added tag jdk8u212-ga for changeset b6ed07cab3f8

! .hgtags

Changeset: 84cd6d251c41
Author:    andrew
Date:      2019-04-25 05:11 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/84cd6d251c41

Merge

! .hgtags

Changeset: 0c183329d0f6
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/0c183329d0f6

Added tag jdk8u222-b01 for changeset 84cd6d251c41

! .hgtags

Changeset: acd627b5205f
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/acd627b5205f

Merge jdk8u222-b01

! .hgtags

Changeset: 184544a1bc7d
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/184544a1bc7d

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset acd627b5205f

! .hgtags

Changeset: 0202fead2157
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/0202fead2157

Added tag jdk8u222-b02 for changeset 0c183329d0f6

! .hgtags

Changeset: 2293ecd29e54
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/2293ecd29e54

Merge jdk8u222-b02

! .hgtags

Changeset: 4bb3a1f9c6ec
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/corba/rev/4bb3a1f9c6ec

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset 2293ecd29e54

! .hgtags


From shade at redhat.com  Mon May 27 08:35:37 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:37 +0000
Subject: hg: shenandoah/jdk8/jaxws: 12 new changesets
Message-ID: <201905270835.x4R8ZbsB006929@aojmv0008.oracle.com>

Changeset: 51dc0b8c80a1
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/51dc0b8c80a1

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset da9f52f7a068

! .hgtags

Changeset: cb40ea4fc831
Author:    clanger
Date:      2019-03-18 09:01 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/cb40ea4fc831

Added tag jdk8u222-b00 for changeset 5f9530ebac26

! .hgtags

Changeset: f3b3b58ee7b8
Author:    clanger
Date:      2019-03-18 09:02 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/f3b3b58ee7b8

Merge

! .hgtags

Changeset: 0b1bf2c98b76
Author:    clanger
Date:      2019-04-01 14:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/0b1bf2c98b76

Merge

! .hgtags

Changeset: 0b35685505cd
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/0b35685505cd

Added tag jdk8u212-ga for changeset edd8659683b4

! .hgtags

Changeset: 70d757a2a4e1
Author:    andrew
Date:      2019-04-25 05:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/70d757a2a4e1

Merge

! .hgtags

Changeset: b57a4deb3aca
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/b57a4deb3aca

Added tag jdk8u222-b01 for changeset 70d757a2a4e1

! .hgtags

Changeset: 647f4d0a5ae2
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/647f4d0a5ae2

Merge jdk8u222-b01

! .hgtags

Changeset: d28eca3321b8
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/d28eca3321b8

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset 647f4d0a5ae2

! .hgtags

Changeset: 9b17ffc86441
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/9b17ffc86441

Added tag jdk8u222-b02 for changeset b57a4deb3aca

! .hgtags

Changeset: e5d3ef45ad4c
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/e5d3ef45ad4c

Merge jdk8u222-b02

! .hgtags

Changeset: e1b53c5baa73
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxws/rev/e1b53c5baa73

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset e5d3ef45ad4c

! .hgtags


From shade at redhat.com  Mon May 27 08:35:38 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:38 +0000
Subject: hg: shenandoah/jdk8/nashorn: 12 new changesets
Message-ID: <201905270835.x4R8Zc6Y006980@aojmv0008.oracle.com>

Changeset: 024ce4a4ce59
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/024ce4a4ce59

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 4dbb004474ef

! .hgtags

Changeset: 5e7373302102
Author:    clanger
Date:      2019-03-18 09:10 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/5e7373302102

Added tag jdk8u222-b00 for changeset 203712f71207

! .hgtags

Changeset: 5ac73294cf68
Author:    clanger
Date:      2019-03-18 09:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/5ac73294cf68

Merge

! .hgtags

Changeset: 17caa5cc3969
Author:    clanger
Date:      2019-04-01 14:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/17caa5cc3969

Merge

! .hgtags

Changeset: 8bbcc2375d0c
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/8bbcc2375d0c

Added tag jdk8u212-ga for changeset f470f90fa4f7

! .hgtags

Changeset: 60065d9e17b0
Author:    andrew
Date:      2019-04-25 05:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/60065d9e17b0

Merge

! .hgtags

Changeset: 4e370d5e4c56
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/4e370d5e4c56

Added tag jdk8u222-b01 for changeset 60065d9e17b0

! .hgtags

Changeset: 21e659c7044b
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/21e659c7044b

Merge jdk8u222-b01

! .hgtags

Changeset: 4ed6718ad67a
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/4ed6718ad67a

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset 21e659c7044b

! .hgtags

Changeset: c370478005ec
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/c370478005ec

Added tag jdk8u222-b02 for changeset 4e370d5e4c56

! .hgtags

Changeset: c63b176f3012
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/c63b176f3012

Merge jdk8u222-b02

! .hgtags

Changeset: 5e25a30f3d81
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/nashorn/rev/5e25a30f3d81

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset c63b176f3012

! .hgtags


From shade at redhat.com  Mon May 27 08:35:40 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:40 +0000
Subject: hg: shenandoah/jdk8/jaxp: 13 new changesets
Message-ID: <201905270835.x4R8ZeEo007013@aojmv0008.oracle.com>

Changeset: fd0ff2e18e4e
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/fd0ff2e18e4e

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset a47eb551627f

! .hgtags

Changeset: 0136637e03f1
Author:    clanger
Date:      2019-03-18 08:58 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/0136637e03f1

Added tag jdk8u222-b00 for changeset 22d26c0a8eb7

! .hgtags

Changeset: 35cdcb220a39
Author:    clanger
Date:      2019-03-18 09:00 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/35cdcb220a39

Merge

! .hgtags

Changeset: ff33172d2522
Author:    joehw
Date:      2019-03-28 15:18 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/ff33172d2522

8207760: SAXException: Invalid UTF-16 surrogate detected: d83c ?
Summary: Properly handle unicode16 characters split across buffer chunks.
Reviewed-by: lancea, dfuchs

! src/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
! src/com/sun/org/apache/xml/internal/serializer/ToStream.java
! src/com/sun/org/apache/xml/internal/serializer/ToTextStream.java

Changeset: 9842fc4ed823
Author:    clanger
Date:      2019-04-01 14:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/9842fc4ed823

Merge

! .hgtags

Changeset: 73b35563337b
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/73b35563337b

Added tag jdk8u212-ga for changeset 7dca173f654e

! .hgtags

Changeset: c3b532bf906c
Author:    andrew
Date:      2019-04-25 05:11 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/c3b532bf906c

Merge

! .hgtags

Changeset: e0ba0b931da8
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/e0ba0b931da8

Added tag jdk8u222-b01 for changeset c3b532bf906c

! .hgtags

Changeset: 1fc2cbcbdd34
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/1fc2cbcbdd34

Merge jdk8u222-b01

! .hgtags

Changeset: 9e499c294ef3
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/9e499c294ef3

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset 1fc2cbcbdd34

! .hgtags

Changeset: eb0c5e5c47ec
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/eb0c5e5c47ec

Added tag jdk8u222-b02 for changeset e0ba0b931da8

! .hgtags

Changeset: c1d4ff0d8020
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/c1d4ff0d8020

Merge jdk8u222-b02

! .hgtags

Changeset: 3678924c087d
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jaxp/rev/3678924c087d

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset c1d4ff0d8020

! .hgtags


From shade at redhat.com  Mon May 27 08:35:41 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:41 +0000
Subject: hg: shenandoah/jdk8/hotspot: 27 new changesets
Message-ID: <201905270835.x4R8Zf3o007020@aojmv0008.oracle.com>

Changeset: 97fb0d686f79
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/97fb0d686f79

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 94a8fbf1b6a3

! .hgtags

Changeset: ec3f2b2a054d
Author:    clanger
Date:      2019-03-18 08:55 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/ec3f2b2a054d

Added tag jdk8u222-b00 for changeset 5af8ec63c21c

! .hgtags

Changeset: f59f67eb8bc8
Author:    clanger
Date:      2019-03-18 08:57 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/f59f67eb8bc8

Merge

! .hgtags

Changeset: 6b67e2bcf2be
Author:    jcm
Date:      2019-01-23 23:24 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/6b67e2bcf2be

8213825: assert(false) failed: Non-balanced monitor enter/exit! Likely JNI locking
Summary: skip sfpt optimization for Load is removed for Java Object's Markword Load.
Reviewed-by: kvn, dlong

! src/share/vm/opto/memnode.cpp

Changeset: a49d6f06f0d5
Author:    kevinw
Date:      2019-01-31 04:49 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a49d6f06f0d5

8209951: Problematic sparc intrinsic: com.sun.crypto.provider.CipherBlockChaining
Reviewed-by: kvn, thartmann
Contributed-by: fairoz.matte at oracle.com

! src/cpu/sparc/vm/stubGenerator_sparc.cpp
+ test/compiler/8209951/TestCipherBlockChainingEncrypt.java

Changeset: 35d9d8c13d30
Author:    shade
Date:      2019-03-19 17:30 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/35d9d8c13d30

8220718: Missing ResourceMark in nmethod::metadata_do
Reviewed-by: mdoerr, zgu

! src/share/vm/code/nmethod.cpp

Changeset: 71aba4a921a0
Author:    aoqi
Date:      2019-01-31 23:56 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/71aba4a921a0

8217597: [TESTBUG] old version docker does not support --cpus
Summary: "--cpus" is only available in Docker 1.13 and higher, and is the equivalent of setting both --cpu-period and --cpu-quota.
Reviewed-by: bobv, dholmes
Contributed-by: aoqi at loongson.cn

! test/runtime/containers/docker/TestCPUAwareness.java

Changeset: fc5ffcba674b
Author:    clanger
Date:      2019-04-01 14:31 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/fc5ffcba674b

Merge

! .hgtags

Changeset: 0cbfe6c38b2e
Author:    sgehwolf
Date:      2019-04-10 11:38 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/0cbfe6c38b2e

8221355: Performance regression after JDK-8155635 backport into 8u
Reviewed-by: shade, roland

! src/share/vm/opto/library_call.cpp

Changeset: f54baa81b631
Author:    ctornqvi
Date:      2014-08-22 09:30 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/f54baa81b631

8055814: [TESTBUG] runtime/NMT/NMTWithCDS.java fails with product builds due to missing UnlockDiagnosticVMOptions
Summary: Passing -XX:+UnlockDiagnosticVMOptions to ProcessBuilder
Reviewed-by: zgu, gtriantafill

! test/runtime/NMT/NMTWithCDS.java

Changeset: 379a59bf685d
Author:    cvarming
Date:      2019-04-15 16:27 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/379a59bf685d

8150013: ParNew: Prune nmethods scavengable list.
Summary: Speed up ParNew collections by pruning the list of scavengable nmethods.
Reviewed-by: jmasa, tonyp, twisti

! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/memory/iterator.hpp

Changeset: 6eedcffa129d
Author:    gromero
Date:      2019-04-24 11:48 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/6eedcffa129d

8154156: PPC64: improve array copy stubs by using vector instructions
Reviewed-by: goetz, mdoerr
Contributed-by: Kazunori Ogata <ogatak at jp.ibm.com>

! src/cpu/ppc/vm/assembler_ppc.hpp
! src/cpu/ppc/vm/assembler_ppc.inline.hpp
! src/cpu/ppc/vm/globals_ppc.hpp
! src/cpu/ppc/vm/register_ppc.cpp
! src/cpu/ppc/vm/register_ppc.hpp
! src/cpu/ppc/vm/stubGenerator_ppc.cpp
! src/cpu/ppc/vm/vm_version_ppc.cpp
! src/cpu/ppc/vm/vm_version_ppc.hpp

Changeset: c16cc0cdcce5
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/c16cc0cdcce5

Added tag jdk8u212-ga for changeset 96fec237fcc0

! .hgtags

Changeset: 7fe2cda84af1
Author:    andrew
Date:      2019-04-25 05:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/7fe2cda84af1

Merge

! .hgtags

Changeset: af49c0f75bd1
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/af49c0f75bd1

Added tag jdk8u222-b01 for changeset 7fe2cda84af1

! .hgtags

Changeset: a33c11783e6b
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a33c11783e6b

Merge jdk8u222-b01

! .hgtags
! src/share/vm/code/codeCache.cpp
! src/share/vm/code/codeCache.hpp
! src/share/vm/code/nmethod.cpp
! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/opto/memnode.cpp

Changeset: da68cd870abc
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/da68cd870abc

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset a33c11783e6b

! .hgtags

Changeset: a8441ccaff15
Author:    stefank
Date:      2016-03-15 10:11 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/a8441ccaff15

8151539: Remove duplicate AlwaysTrueClosures
Reviewed-by: tschatzl, mgerdin, kbarrett, drwhite

! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/iterator.hpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/jniHandles.cpp
! src/share/vm/runtime/jniHandles.hpp

Changeset: 4fdf42cda0d5
Author:    andrew
Date:      2019-05-02 17:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/4fdf42cda0d5

Merge


Changeset: 1a1aec8c87b7
Author:    shade
Date:      2019-01-18 17:05 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/1a1aec8c87b7

8217315: Proper units should print more significant digits
Reviewed-by: stuefe, tschatzl

! src/share/vm/prims/jni.cpp
! src/share/vm/utilities/globalDefinitions.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: acb9351e3a29
Author:    aeriksso
Date:      2015-11-05 11:42 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/acb9351e3a29

8134030: test/serviceability/dcmd/gc/HeapDumpTest fails to verify the dump
Reviewed-by: dholmes

! src/share/vm/services/heapDumper.cpp

Changeset: 32bc598624bd
Author:    phh
Date:      2019-05-07 20:38 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/32bc598624bd

8176100: [REDO][REDO] G1 Needs pre barrier on dereference of weak JNI handles
Summary: Add tag bit to all JNI weak handles
Reviewed-by: kbarrett, coleenp, tschatzl

! src/cpu/ppc/vm/frame_ppc.cpp
! src/cpu/ppc/vm/interpreter_ppc.cpp
! src/cpu/ppc/vm/macroAssembler_ppc.cpp
! src/cpu/ppc/vm/macroAssembler_ppc.hpp
! src/cpu/ppc/vm/sharedRuntime_ppc.cpp
! src/cpu/sparc/vm/jniFastGetField_sparc.cpp
! src/cpu/sparc/vm/sharedRuntime_sparc.cpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/x86/vm/jniFastGetField_x86_32.cpp
! src/cpu/x86/vm/jniFastGetField_x86_64.cpp
! src/cpu/x86/vm/macroAssembler_x86.cpp
! src/cpu/x86/vm/macroAssembler_x86.hpp
! src/cpu/x86/vm/sharedRuntime_x86_32.cpp
! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/zero/vm/cppInterpreter_zero.cpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jvmtiEnv.cpp
! src/share/vm/runtime/javaCalls.cpp
! src/share/vm/runtime/javaCalls.hpp
! src/share/vm/runtime/jniHandles.cpp
! src/share/vm/runtime/jniHandles.hpp
! src/share/vm/shark/sharkNativeWrapper.cpp

Changeset: 884a9feb3bb8
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/884a9feb3bb8

Added tag jdk8u222-b02 for changeset 32bc598624bd

! .hgtags

Changeset: 6e5f9aaf6f23
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/6e5f9aaf6f23

Merge jdk8u222-b02

! .hgtags
! src/cpu/ppc/vm/sharedRuntime_ppc.cpp
! src/cpu/sparc/vm/sharedRuntime_sparc.cpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/x86/vm/jniFastGetField_x86_64.cpp
! src/cpu/x86/vm/macroAssembler_x86.cpp
! src/cpu/x86/vm/macroAssembler_x86.hpp
! src/cpu/x86/vm/sharedRuntime_x86_32.cpp
! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/zero/vm/cppInterpreter_zero.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp
! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/prims/jni.cpp
! src/share/vm/prims/jvmtiEnv.cpp
! src/share/vm/prims/whitebox.cpp
! src/share/vm/runtime/javaCalls.cpp
! src/share/vm/runtime/javaCalls.hpp
! src/share/vm/runtime/jniHandles.cpp
! src/share/vm/runtime/jniHandles.hpp
! src/share/vm/services/heapDumper.cpp
! src/share/vm/utilities/globalDefinitions.hpp

Changeset: 327f9583546e
Author:    andrew
Date:      2019-05-13 03:43 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/327f9583546e

8176100: [AArch64] [REDO][REDO] G1 Needs pre barrier on dereference of weak JNI handles
Reviewed-by: kbarrett, coleenp, tschatzl

! src/cpu/aarch64/vm/jniFastGetField_aarch64.cpp
! src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
! src/cpu/aarch64/vm/templateInterpreter_aarch64.cpp

Changeset: 68b747ae3866
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/68b747ae3866

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset 327f9583546e

! .hgtags

Changeset: 5182332fe753
Author:    shade
Date:      2019-05-20 12:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/5182332fe753

Merge



From shade at redhat.com  Mon May 27 08:35:39 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:39 +0000
Subject: hg: shenandoah/jdk8/jdk: 48 new changesets
Message-ID: <201905270835.x4R8ZfYI007021@aojmv0008.oracle.com>

Changeset: 55f522c448bb
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/55f522c448bb

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 0dda9055b439

! .hgtags

Changeset: 13ee07a85337
Author:    clanger
Date:      2019-03-18 09:03 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/13ee07a85337

Added tag jdk8u222-b00 for changeset fcf246aa327f

! .hgtags

Changeset: d2fe42f45c4a
Author:    clanger
Date:      2019-03-18 09:06 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/d2fe42f45c4a

Merge

! .hgtags

Changeset: e4b14943040f
Author:    ssadetsky
Date:      2019-02-15 10:01 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/e4b14943040f

8218479: JTextPane display issue with GTKLookAndFeel
Reviewed-by: prr, serb

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

Changeset: d9da27985291
Author:    psadhukhan
Date:      2019-03-20 15:37 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/d9da27985291

8048782: OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException
Summary: Redirect PiscesTileGenerator.getBbox() to PiscesCache.getBBox().
Reviewed-by: prr, flar

! src/share/classes/sun/java2d/pisces/PiscesCache.java
! src/share/classes/sun/java2d/pisces/PiscesTileGenerator.java
+ test/sun/java2d/pisces/OpenJDKFillBug.java

Changeset: dcae196c2af1
Author:    ssadetsky
Date:      2019-02-15 10:06 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/dcae196c2af1

8218473: JOptionPane display issue with GTKLookAndFeel
Reviewed-by: prr, serb

! src/solaris/native/sun/awt/gtk3_interface.c

Changeset: 6a54110f573c
Author:    pbansal
Date:      2019-02-15 10:58 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/6a54110f573c

8218469: JSlider display issue with slider for GTKLookAndFeel
8218470: JScrollBar display issue with GTKLookAndFeel
8218472: JProgressBar display issue with GTKLookAndFeel
8203627: Swing applications with JRadioButton and JCheckbox fail to render correctly when using GTK3 and the GTK L&F
Reviewed-by: serb, prr

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
! src/solaris/native/sun/awt/gtk3_interface.c
! src/solaris/native/sun/awt/gtk3_interface.h

Changeset: 0efb8d935281
Author:    pbansal
Date:      2019-03-05 13:09 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/0efb8d935281

8214253: Tooltip is transparent rather than having a black background
Reviewed-by: serb, psadhukhan

! src/solaris/native/sun/awt/gtk3_interface.c

Changeset: 0ff0f14d5346
Author:    pbansal
Date:      2019-01-10 16:38 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/0ff0f14d5346

8214252: Expanded & Collapsed nodes of a JTree look the same on GTK3
Reviewed-by: serb, psadhukhan

! src/solaris/native/sun/awt/gtk3_interface.c

Changeset: fbed78affeea
Author:    dmarkov
Date:      2019-02-26 18:12 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/fbed78affeea

8214109: XToolkit is not correctly displayed color on 16-bit high color setting
Reviewed-by: serb, prr

! src/solaris/classes/sun/awt/X11/XWindow.java

Changeset: 94230f2a671e
Author:    pbansal
Date:      2019-01-18 13:36 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/94230f2a671e

8214111: There is no icon in all JOptionPane target image
Reviewed-by: serb, psadhukhan

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

Changeset: 8c0ae4357017
Author:    pbansal
Date:      2019-03-05 14:03 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/8c0ae4357017

8214112: The whole text in target JPasswordField image are not selected
Reviewed-by: serb, psadhukhan

! src/solaris/native/sun/awt/gtk3_interface.c

Changeset: 708b820b474e
Author:    bpb
Date:      2015-07-31 07:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/708b820b474e

8073078: java/nio/file/FileStore/Basic.java sensitive to NFS configuration
Summary: Ignore NoSuchFileExceptions as the store might have been deleted subsequent to creation of the FileStore iterator which is not dynamic.
Reviewed-by: alanb

! test/java/nio/file/FileStore/Basic.java

Changeset: 613eee8ca9bf
Author:    bpb
Date:      2016-07-08 16:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/613eee8ca9bf

8157287: java/nio/file/FileStore/Basic.java failed with "java.nio.file.AccessDeniedException : /zones/zoneone/root "
Summary: Ignore AccessDeniedException when testing space attributes.
Reviewed-by: alanb

! test/java/nio/file/FileStore/Basic.java

Changeset: 64f676f55401
Author:    darcy
Date:      2016-03-04 10:09 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/64f676f55401

8151225: Mark SpecTest.java as intermittently failing
Reviewed-by: mullan

! test/sun/security/rsa/SpecTest.java

Changeset: 1c193f846f42
Author:    rhalade
Date:      2016-04-19 18:09 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/1c193f846f42

8137231: sun/security/rsa/SpecTest.java timeout with Agent error: java.lang.Exception
Reviewed-by: valeriep

! test/sun/security/rsa/SpecTest.java

Changeset: 9fd54dabc0a2
Author:    rhalade
Date:      2016-05-18 16:36 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/9fd54dabc0a2

8156035: Remove intermittent key from sun/security/rsa/SpecTest.java
Reviewed-by: mullan

! test/sun/security/rsa/SpecTest.java

Changeset: e993056564d3
Author:    aivanov
Date:      2019-02-07 13:57 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/e993056564d3

8217263: Automate DashOffset test
Reviewed-by: prr, serb

+ test/java/awt/BasicStroke/DashOffset.java

Changeset: 2e4283de3be9
Author:    tyan
Date:      2014-01-17 14:03 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/2e4283de3be9

8031666: TEST_BUG: java/net/ipv6tests/UdpTest.java failed because of SocketTimeoutException
Reviewed-by: alanb, chegar

! test/java/net/ipv6tests/UdpTest.java

Changeset: e4cc513c7a91
Author:    alanb
Date:      2013-12-20 09:58 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/e4cc513c7a91

8030690: TEST_BUG java/nio/Buffer/Chars.java fails intermittently
Reviewed-by: alanb
Contributed-by: yiming.wang at oracle.com

! test/java/nio/Buffer/Chars.java

Changeset: 2f6332c1e882
Author:    alanb
Date:      2013-12-19 18:13 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/2f6332c1e882

8022879: TEST_BUG: sun/nio/cs/MalformedSurrogates.java fails intermittently
Reviewed-by: martin
Contributed-by: yiming.wang at oracle.com

! test/sun/nio/cs/MalformedSurrogates.java

Changeset: 70555c8718d9
Author:    alanb
Date:      2014-03-25 10:14 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/70555c8718d9

8031563: TEST_BUG: java/nio/channels/Selector/ChangingInterests.java failed once
Reviewed-by: alanb
Contributed-by: michael.cui at oracle.com

! test/java/nio/channels/Selector/ChangingInterests.java

Changeset: c0a7a4829d6a
Author:    alanb
Date:      2014-01-03 15:59 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/c0a7a4829d6a

8031113: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Basic.java fails intermittently
Reviewed-by: chegar

! test/java/nio/channels/AsynchronousChannelGroup/Basic.java
! test/java/nio/channels/AsynchronousChannelGroup/GroupOfOne.java
! test/java/nio/channels/AsynchronousChannelGroup/Restart.java

Changeset: 308ec99c6172
Author:    chegar
Date:      2014-03-31 11:33 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/308ec99c6172

8025209: Intermittent test failure java/net/Socket/asyncClose/AsyncClose.java
Reviewed-by: chegar
Contributed-by: Eric Wang <yiming.wang at oracle.com>, Chris Hegarty <chris.hegarty at oracle.com>

! test/java/net/Socket/asyncClose/AsyncClose.java
! test/java/net/Socket/asyncClose/AsyncCloseTest.java
! test/java/net/Socket/asyncClose/DatagramSocket_receive.java
! test/java/net/Socket/asyncClose/ServerSocket_accept.java
! test/java/net/Socket/asyncClose/Socket_getInputStream_read.java
! test/java/net/Socket/asyncClose/Socket_getOutputStream_write.java

Changeset: 2d756138f8ff
Author:    joehw
Date:      2019-03-28 15:11 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/2d756138f8ff

8207760: SAXException: Invalid UTF-16 surrogate detected: d83c ?
Summary: Add JDK8207760.java jtreg test.
Reviewed-by: lancea, dfuchs

+ test/javax/xml/jaxp/transform/8207760/JDK8207760.java

Changeset: 7d5d3659c9e0
Author:    kaddepalli
Date:      2018-02-05 13:44 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/7d5d3659c9e0

8171000: Robot.createScreenCapture() crashes in wayland mode
Reviewed-by: serb, mhalder

! src/solaris/native/sun/awt/multiVis.c

Changeset: e4f2a8ab1709
Author:    clanger
Date:      2019-04-01 14:35 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/e4f2a8ab1709

Merge

! .hgtags

Changeset: cb56b5bc01c8
Author:    xiaofeya
Date:      2018-08-09 15:42 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/cb56b5bc01c8

8208656: Move java/util/Calendar/CalendarTestScripts tests into OpenJDK
Reviewed-by: naoto

+ test/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java
+ test/java/util/Calendar/CalendarTestScripts/CalendarTestEngine.java
+ test/java/util/Calendar/CalendarTestScripts/CalendarTestException.java
+ test/java/util/Calendar/CalendarTestScripts/Exceptions.java
+ test/java/util/Calendar/CalendarTestScripts/GregorianAdapter.java
+ test/java/util/Calendar/CalendarTestScripts/JapaneseRollDayOfWeekTestGenerator.java
+ test/java/util/Calendar/CalendarTestScripts/JapaneseRollTests.java
+ test/java/util/Calendar/CalendarTestScripts/JapaneseTests.java
+ test/java/util/Calendar/CalendarTestScripts/README
+ test/java/util/Calendar/CalendarTestScripts/Result.java
+ test/java/util/Calendar/CalendarTestScripts/Symbol.java
+ test/java/util/Calendar/CalendarTestScripts/Variable.java
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese_exceptions.cts
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese_normalization.cts
+ test/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts
+ test/java/util/Calendar/CalendarTestScripts/params/lenient.cts
+ test/java/util/Calendar/CalendarTestScripts/params/non-lenient.cts
+ test/java/util/Calendar/CalendarTestScripts/timezones/tz_japan.cts
+ test/java/util/Calendar/CalendarTestScripts/timezones/tz_novosibirsk.cts
+ test/java/util/Calendar/CalendarTestScripts/timezones/tz_pst.cts
+ test/java/util/Calendar/CalendarTestScripts/timezones/tz_sydney.cts

Changeset: d264b1318b82
Author:    naoto
Date:      2019-04-03 04:07 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/d264b1318b82

8042131: DateTimeFormatterBuilder Mapped-values do not work for JapaneseDate
8210633: Cannot parse JapaneseDate string with DateTimeFormatterBuilder Mapped-values
Reviewed-by: clanger

! src/share/classes/java/time/format/DateTimeFormatterBuilder.java
+ test/java/time/test/java/time/format/TestDateTimeFormatterBuilderWithLocale.java

Changeset: 8e126e1398ee
Author:    naoto
Date:      2019-04-03 04:22 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/8e126e1398ee

8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales
Reviewed-by: lancea

! src/share/classes/java/util/JapaneseImperialCalendar.java
! test/java/util/Calendar/JapaneseEraNameTest.java

Changeset: ee55428fe158
Author:    naoto
Date:      2019-04-09 18:24 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/ee55428fe158

8205432: Replace the placeholder Japanese era name
Summary: Also brings in some cleanups from JDK-8048123
Reviewed-by: rriggs, chegar, phh, clanger, aph

! make/data/unicodedata/UnicodeData.txt
! src/share/classes/java/time/chrono/JapaneseEra.java
! src/share/classes/java/util/JapaneseImperialCalendar.java
! src/share/classes/sun/text/resources/FormatData.java
! src/share/classes/sun/text/resources/JavaTimeSupplementary.java
! src/share/classes/sun/text/resources/ja/FormatData_ja.java
! src/share/classes/sun/text/resources/ja/JavaTimeSupplementary_ja.java
! src/share/classes/sun/util/calendar/Era.java
! src/share/classes/sun/util/cldr/resources/21_0_1/common/main/ja.xml
! src/share/classes/sun/util/cldr/resources/21_0_1/common/main/root.xml
! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
! src/share/lib/calendars.properties
! test/java/text/Format/DateFormat/WeekDateTest.java
! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java
! test/java/time/tck/java/time/chrono/TCKJapaneseEra.java
! test/java/time/test/java/time/chrono/TestJapaneseChronology.java
! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java
! test/java/time/test/java/time/format/TestNonIsoFormatter.java
! test/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java
! test/java/util/Calendar/CalendarTestScripts/Symbol.java
! test/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts
! test/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts
! test/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts
! test/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts
! test/java/util/Calendar/JapaneseEraNameTest.java
! test/java/util/Calendar/JapaneseLenientEraTest.java
! test/java/util/Calendar/NarrowNamesTest.java

Changeset: 533a8dfd2ec5
Author:    prr
Date:      2019-04-10 19:27 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/533a8dfd2ec5

8197546: Fix for 8171000 breaks Solaris + Linux builds
Summary: Move loop declarations to function scope in ReadRegionsInList() in multiVis.c
Reviewed-by: serb, jdv

! src/solaris/native/sun/awt/multiVis.c

Changeset: 42474254c74c
Author:    pbansal
Date:      2019-04-04 12:14 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/42474254c74c

8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour
Reviewed-by: serb, prr

! src/solaris/native/sun/awt/gtk3_interface.c

Changeset: ece1d281763e
Author:    psandoz
Date:      2019-04-16 17:37 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/ece1d281763e

8206955: MethodHandleProxies.asInterfaceInstance does not support default methods
Summary: Cache default method handles.
Reviewed-by: mchung, plevart

! src/share/classes/java/lang/invoke/MethodHandleProxies.java
+ test/java/lang/invoke/MethodHandlesProxiesTest.java

Changeset: 900e4921e59d
Author:    xuelei
Date:      2019-04-24 14:48 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/900e4921e59d

8129988: JSSE should create a single instance of the cacerts KeyStore
Summary: Add a TrustStoreManager to manage trusted certs.
Reviewed-by: mullan

! src/share/classes/sun/security/ssl/SSLContextImpl.java
! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java
! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java
! src/share/classes/sun/security/validator/Validator.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/BadTSProvider.java
! test/sun/security/validator/EndEntityExtensionCheck.java

Changeset: cecd70d27b27
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/cecd70d27b27

Added tag jdk8u212-ga for changeset ac2ef877d3e8

! .hgtags

Changeset: f2be071af129
Author:    andrew
Date:      2019-04-25 05:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/f2be071af129

Merge

! .hgtags
! src/share/classes/java/util/JapaneseImperialCalendar.java
! src/share/classes/sun/util/calendar/Era.java
! test/java/time/test/java/time/chrono/TestJapaneseChronology.java

Changeset: b014bff7ba96
Author:    andrew
Date:      2019-04-26 15:48 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/b014bff7ba96

8222965: Backport of JDK-8129988 broke the build
Summary: Files were missed in the commit of the 8129988 backport
Reviewed-by: shade

+ src/share/classes/sun/security/ssl/TrustStoreManager.java
- src/share/classes/sun/security/validator/KeyStores.java
+ src/share/classes/sun/security/validator/TrustStoreUtil.java

Changeset: 6e82c02bee9f
Author:    serb
Date:      2018-06-12 09:26 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/6e82c02bee9f

8202768: [macos] Appkit thread slows when any Window Manager active
Reviewed-by: ant

! src/macosx/native/sun/awt/JavaComponentAccessibility.m
+ test/javax/accessibility/SlowPanelIteration/SlowPanelIteration.java

Changeset: e880f2d161bf
Author:    simonis
Date:      2019-04-29 21:39 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/e880f2d161bf

8205916: [test] Fix jdk/tools/launcher/RunpathTest to handle both, RPATH and RUNPATH
Summary: Extend match pattern to handle RUNPATH as well as RPATH.
Reviewed-by: martin, erikj

! test/tools/launcher/RunpathTest.java

Changeset: 9db1950723f1
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/9db1950723f1

Added tag jdk8u222-b01 for changeset e880f2d161bf

! .hgtags

Changeset: fdd7eff12e7e
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/fdd7eff12e7e

Merge jdk8u222-b01

! .hgtags
! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java
! src/share/classes/java/lang/invoke/MethodHandleProxies.java
! src/share/classes/sun/security/ssl/SSLContextImpl.java
- src/share/classes/sun/security/validator/KeyStores.java
! src/share/classes/sun/security/validator/Validator.java
! src/solaris/classes/sun/awt/X11/XWindow.java
! src/solaris/native/sun/awt/multiVis.c
! test/tools/launcher/RunpathTest.java

Changeset: bc82a596bb90
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/bc82a596bb90

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset fdd7eff12e7e

! .hgtags

Changeset: 3f75ecf2feed
Author:    sgehwolf
Date:      2019-04-25 15:19 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/3f75ecf2feed

8210416: [linux] Poor StrictMath performance due to non-optimized compilation
Summary: Compile fdlibm with -O3 and relevant C flags on gcc arches.
Reviewed-by: mbaesken, andrew

! make/lib/CoreLibraries.gmk

Changeset: 78d1f9f2fec2
Author:    kaddepalli
Date:      2019-05-09 21:02 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/78d1f9f2fec2

8218674: HTML Tooltip with "img=src" on component doesn't show
Summary: Make sure image is scaled appropriately if synchronous loading flag is set.
Reviewed-by: serb, psadhukhan

! src/share/classes/javax/swing/text/html/ImageView.java
+ test/javax/swing/text/html/8218674/TooltipImageTest.java
+ test/javax/swing/text/html/8218674/circle.png

Changeset: 43f4f5b4becc
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/43f4f5b4becc

Added tag jdk8u222-b02 for changeset 78d1f9f2fec2

! .hgtags

Changeset: fa1b609b305f
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/fa1b609b305f

Merge jdk8u222-b02

! .hgtags
! make/lib/CoreLibraries.gmk

Changeset: 63e398a7858d
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/jdk/rev/63e398a7858d

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset fa1b609b305f

! .hgtags


From shade at redhat.com  Mon May 27 08:35:42 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 08:35:42 +0000
Subject: hg: shenandoah/jdk8/langtools: 12 new changesets
Message-ID: <201905270835.x4R8Zgoa007034@aojmv0008.oracle.com>

Changeset: 9c6dd2a48251
Author:    andrew
Date:      2019-05-01 21:21 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/9c6dd2a48251

Added tag aarch64-shenandoah-jdk8u212-b04-shenandoah-merge-2019-04-30 for changeset 2d2e7b70a09f

! .hgtags

Changeset: 3c696f673bb1
Author:    clanger
Date:      2019-03-18 09:08 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/3c696f673bb1

Added tag jdk8u222-b00 for changeset f301c2612d60

! .hgtags

Changeset: d5fe7504e90c
Author:    clanger
Date:      2019-03-18 09:09 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/d5fe7504e90c

Merge

! .hgtags

Changeset: b38dc179ccee
Author:    clanger
Date:      2019-04-01 14:37 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/b38dc179ccee

Merge

! .hgtags

Changeset: 8aab93346792
Author:    andrew
Date:      2019-04-16 21:59 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/8aab93346792

Added tag jdk8u212-ga for changeset 4c4c8a86bcb2

! .hgtags

Changeset: 1f6b4d944977
Author:    andrew
Date:      2019-04-25 05:12 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/1f6b4d944977

Merge

! .hgtags

Changeset: d91f70a5eb9d
Author:    andrew
Date:      2019-05-01 06:16 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/d91f70a5eb9d

Added tag jdk8u222-b01 for changeset 1f6b4d944977

! .hgtags

Changeset: f9dde1a1356e
Author:    andrew
Date:      2019-05-02 01:23 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/f9dde1a1356e

Merge jdk8u222-b01

! .hgtags

Changeset: 1765d5b4a94b
Author:    andrew
Date:      2019-05-02 02:14 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/1765d5b4a94b

Added tag aarch64-shenandoah-jdk8u222-b01 for changeset f9dde1a1356e

! .hgtags

Changeset: 40b40af700b4
Author:    andrew
Date:      2019-05-10 18:15 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/40b40af700b4

Added tag jdk8u222-b02 for changeset d91f70a5eb9d

! .hgtags

Changeset: 5d0d6319e668
Author:    andrew
Date:      2019-05-13 03:17 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/5d0d6319e668

Merge jdk8u222-b02

! .hgtags

Changeset: 2d020a6abed1
Author:    andrew
Date:      2019-05-13 03:44 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/langtools/rev/2d020a6abed1

Added tag aarch64-shenandoah-jdk8u222-b02 for changeset 5d0d6319e668

! .hgtags


From shade at redhat.com  Mon May 27 08:36:18 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 10:36:18 +0200
Subject: RFR/RFC: Pick up aarch64-shenandoah-jdk8u222-b02 to sh/jdk8
In-Reply-To: <9f70ef03-e6e6-f9af-66ee-2c8f9b364e30@redhat.com>
References: <dc392693-a164-f51c-a7a8-00b6ffffa041@redhat.com>
 <8f6d76cb-560f-9cf6-cea7-768271f418d7@redhat.com>
 <9f70ef03-e6e6-f9af-66ee-2c8f9b364e30@redhat.com>
Message-ID: <092158b3-5224-f796-8db7-eae3982716f4@redhat.com>

On 5/23/19 11:38 PM, Andrew John Hughes wrote:
> On 22/05/2019 07:56, Aleksey Shipilev wrote:
>> On 5/20/19 12:26 PM, Aleksey Shipilev wrote:
>>> Hi,
>>>
>>> This is our first ever merge from aarch64-port/jdk8u-shenandoah to sh/jdk8. This picks up
>>> aarch64-shenandoah-jdk8u222-b02 tag and merges it into sh/jdk8.
>>>
>>> Changesets (only hotspot, others are trivial):
>>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/changesets.txt
>>>
>>> Webrev (only hotspot, others are trivial):
>>>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk8-8u222-b02/webrev.01/
>>>
>>> Testing: hotspot_gc_shenandoah {fastdebug,release}

This is now pushed to sh/jdk8. Going to pick up 8u222-b03 after it lands.

-Aleksey


From shade at redhat.com  Mon May 27 11:47:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 13:47:49 +0200
Subject: RFR/RFC [8u]: Enable weak JNI handling with Shenandoah after
 JDK-8176100
Message-ID: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>

In Shenandoah/jdk8u code, we have a workaround for weak JNI handling:
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/119e9a5b24d5
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/d305c31da9f5

This workaround is not necessary anymore, after we got the backports of JDK-8176100:
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/32bc598624bd
  http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/327f9583546e

So, this changeset rolls back the workaround and injects Shenandoah calls where appropriate.

8u candidate fix:
  http://cr.openjdk.java.net/~shade/shenandoah/8u-enable-weak-jni/webrev.01/

Note aarch64 fails! This might mean the upstream patch is incomplete. And I cannot debug it properly
without having working aarch64 machine.

Testing: hotspot_gc_shenandoah (includes gc/shenandoah/jni/TestJNIGlobalRefs.sh
test that fails without the workaround, and passes again without the workaround _and_ the fixes in
platform-specific code); tested with x86_64

-- 
Thanks,
-Aleksey


From shade at redhat.com  Mon May 27 12:11:07 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 14:11:07 +0200
Subject: [8u] RFR: [backport] 8222403: Shenandoah: Remove
 ShenandoahAlwaysTrueClosure, use AlwaysTrueClosure instead
Message-ID: <272c0c3c-6e00-a93c-1ac3-c0bcaabd4ac3@redhat.com>

We have upstream change now that gives us AlwaysTrueClosure, so we can finally backport this change:

diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
--- a/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 20 12:04:27 2019
+++ b/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 27 14:09:23 2019
@@ -98,9 +98,4 @@
 #endif

-class ShenandoahAlwaysTrueClosure : public BoolObjectClosure {
-public:
-  bool do_object_b(oop p) { return true; }
-};
-
 // Shenandoah GC is low-pause concurrent GC that uses Brooks forwarding pointers
 // to encode forwarding data. See BrooksPointer for details on forwarding data encoding.
diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp
--- a/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 20 12:04:27
+++ b/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 27 14:09:23
@@ -65,5 +65,5 @@

 void ShenandoahRootProcessor::process_all_roots_slow(OopClosure* oops) {
-  ShenandoahAlwaysTrueClosure always_true;
+  AlwaysTrueClosure always_true;

   CLDToOopClosure clds(oops);
@@ -195,5 +195,5 @@
   if (jni_weak_roots != NULL) {
     if (!_process_strong_tasks->is_task_claimed(SHENANDOAH_RP_PS_JNIHandles_weak_oops_do)) {
-      ShenandoahAlwaysTrueClosure always_true;
+      AlwaysTrueClosure always_true;
       ShenandoahWorkerTimingsTracker timer(worker_times, ShenandoahPhaseTimings::JNIWeakRoots,
worker_id);
       JNIHandles::weak_oops_do(&always_true, jni_weak_roots);

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey


From zgu at redhat.com  Mon May 27 12:33:22 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 27 May 2019 08:33:22 -0400
Subject: [8u] RFR: [backport] 8222403: Shenandoah: Remove
 ShenandoahAlwaysTrueClosure, use AlwaysTrueClosure instead
In-Reply-To: <272c0c3c-6e00-a93c-1ac3-c0bcaabd4ac3@redhat.com>
References: <272c0c3c-6e00-a93c-1ac3-c0bcaabd4ac3@redhat.com>
Message-ID: <ea5e92b3-8950-d8b1-fb81-4a766cec384f@redhat.com>

Looks good.

-Zhengyu

On 5/27/19 8:11 AM, Aleksey Shipilev wrote:
> We have upstream change now that gives us AlwaysTrueClosure, so we can finally backport this change:
> 
> diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
> --- a/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 20 12:04:27 2019
> +++ b/src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp   Mon May 27 14:09:23 2019
> @@ -98,9 +98,4 @@
>   #endif
> 
> -class ShenandoahAlwaysTrueClosure : public BoolObjectClosure {
> -public:
> -  bool do_object_b(oop p) { return true; }
> -};
> -
>   // Shenandoah GC is low-pause concurrent GC that uses Brooks forwarding pointers
>   // to encode forwarding data. See BrooksPointer for details on forwarding data encoding.
> diff -r 5182332fe753 src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp
> --- a/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 20 12:04:27
> +++ b/src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp  Mon May 27 14:09:23
> @@ -65,5 +65,5 @@
> 
>   void ShenandoahRootProcessor::process_all_roots_slow(OopClosure* oops) {
> -  ShenandoahAlwaysTrueClosure always_true;
> +  AlwaysTrueClosure always_true;
> 
>     CLDToOopClosure clds(oops);
> @@ -195,5 +195,5 @@
>     if (jni_weak_roots != NULL) {
>       if (!_process_strong_tasks->is_task_claimed(SHENANDOAH_RP_PS_JNIHandles_weak_oops_do)) {
> -      ShenandoahAlwaysTrueClosure always_true;
> +      AlwaysTrueClosure always_true;
>         ShenandoahWorkerTimingsTracker timer(worker_times, ShenandoahPhaseTimings::JNIWeakRoots,
> worker_id);
>         JNIHandles::weak_oops_do(&always_true, jni_weak_roots);
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}
> 

From rkennke at redhat.com  Mon May 27 12:51:48 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 27 May 2019 14:51:48 +0200
Subject: RFR: JDK-8224836: Backout: JDK-8224626: Shenandoah: Elide barriers on
 uncommon traps
Message-ID: <e8d9abee-d668-dc62-ab34-80a0d502c241@redhat.com>

This is a clean backout of "JDK-8224626: Shenandoah: Elide barriers on
uncommon traps". This seems to cause failures in a ctw test. It seems a
bit odd that this would cause problems, but life's too short to debug
this ;-)

http://cr.openjdk.java.net/~rkennke/JDK-8224836/webrev.00/

Testing: the failing ctw test, hotspot_gc_shenandoah

Ok?

Roman


From shade at redhat.com  Mon May 27 12:53:44 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 14:53:44 +0200
Subject: RFR: JDK-8224836: Backout: JDK-8224626: Shenandoah: Elide
 barriers on uncommon traps
In-Reply-To: <e8d9abee-d668-dc62-ab34-80a0d502c241@redhat.com>
References: <e8d9abee-d668-dc62-ab34-80a0d502c241@redhat.com>
Message-ID: <80854181-a599-5ea5-cfaa-a43a19268b46@redhat.com>

On 5/27/19 2:51 PM, Roman Kennke wrote:
> This is a clean backout of "JDK-8224626: Shenandoah: Elide barriers on
> uncommon traps". This seems to cause failures in a ctw test. It seems a
> bit odd that this would cause problems, but life's too short to debug
> this ;-)

True.

> http://cr.openjdk.java.net/~rkennke/JDK-8224836/webrev.00/

Looks good.

-Aleksey


From shade at redhat.com  Mon May 27 12:58:02 2019
From: shade at redhat.com (shade at redhat.com)
Date: Mon, 27 May 2019 12:58:02 +0000
Subject: hg: shenandoah/jdk8/hotspot: [backport] 8222403: Shenandoah: Remove
 ShenandoahAlwaysTrueClosure, use AlwaysTrueClosure instead
Message-ID: <201905271258.x4RCw2jx015646@aojmv0008.oracle.com>

Changeset: ce3759cb9713
Author:    shade
Date:      2019-05-27 14:09 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/ce3759cb9713

[backport] 8222403: Shenandoah: Remove ShenandoahAlwaysTrueClosure, use AlwaysTrueClosure instead

! src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp
! src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp


From rkennke at redhat.com  Mon May 27 13:29:11 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 27 May 2019 15:29:11 +0200
Subject: RFR/RFC [8u]: Enable weak JNI handling with Shenandoah after
 JDK-8176100
In-Reply-To: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>
References: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>
Message-ID: <b666ad08-2048-c787-f78c-2910efc341ae@redhat.com>

Looks like we've got a clash between rscratch1 used in
g1_write_barrier_pre() and the rscratch that's passed as tmp from
sharedRuntime_aarch64.cpp. You need this fix:

diff -r 9f523f185755 src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
--- a/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 12:23:24
2019 +0200
+++ b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 09:27:22
2019 -0400
@@ -2066,7 +2066,7 @@
       __ g1_write_barrier_pre(noreg /* obj */,
                               r0 /* pre_val */,
                               rthread /* thread */,
-                              rscratch1 /* tmp */,
+                              rscratch2 /* tmp */,
                               true /* tosca_live */,
                               true /* expand_call */);
     }

This makes the failing test pass for me.

It probably warrants a more careful fix, extra asserts in
g1_write_barrier_pre() and checking if newer versions have similar problems.

Roman

> In Shenandoah/jdk8u code, we have a workaround for weak JNI handling:
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/119e9a5b24d5
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/d305c31da9f5
> 
> This workaround is not necessary anymore, after we got the backports of JDK-8176100:
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/32bc598624bd
>   http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/327f9583546e
> 
> So, this changeset rolls back the workaround and injects Shenandoah calls where appropriate.
> 
> 8u candidate fix:
>   http://cr.openjdk.java.net/~shade/shenandoah/8u-enable-weak-jni/webrev.01/
> 
> Note aarch64 fails! This might mean the upstream patch is incomplete. And I cannot debug it properly
> without having working aarch64 machine.
> 
> Testing: hotspot_gc_shenandoah (includes gc/shenandoah/jni/TestJNIGlobalRefs.sh
> test that fails without the workaround, and passes again without the workaround _and_ the fixes in
> platform-specific code); tested with x86_64
> 


From zgu at redhat.com  Mon May 27 13:58:50 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Mon, 27 May 2019 09:58:50 -0400
Subject: RFR (S) 8224751: Shenandoah: Shenandoah Verifier should select proper
 roots according to current GC cycle
Message-ID: <5d41da11-59b5-f469-d6d9-72e43ac9efcf@redhat.com>

Verifier should seed the marking with the same roots as current GC cycle.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224751
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224751/webrev.00/

Test:
   hotspot_gc_shenandoah with ShenandoahVerify (fastdebug and release)

Thanks,

-Zhengyu


From rkennke at redhat.com  Mon May 27 14:31:41 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Mon, 27 May 2019 16:31:41 +0200
Subject: RFR (S) 8224751: Shenandoah: Shenandoah Verifier should select
 proper roots according to current GC cycle
In-Reply-To: <5d41da11-59b5-f469-d6d9-72e43ac9efcf@redhat.com>
References: <5d41da11-59b5-f469-d6d9-72e43ac9efcf@redhat.com>
Message-ID: <76c5e0cf-0be9-09ab-a1e4-c66079803a3c@redhat.com>

Looks good. Thanks!

Roman


> Verifier should seed the marking with the same roots as current GC cycle.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224751
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224751/webrev.00/
> 
> Test:
> ? hotspot_gc_shenandoah with ShenandoahVerify (fastdebug and release)
> 
> Thanks,
> 
> -Zhengyu
> 


From shade at redhat.com  Mon May 27 15:39:09 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 17:39:09 +0200
Subject: RFR/RFC [8u]: Enable weak JNI handling with Shenandoah after
 JDK-8176100
In-Reply-To: <b666ad08-2048-c787-f78c-2910efc341ae@redhat.com>
References: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>
 <b666ad08-2048-c787-f78c-2910efc341ae@redhat.com>
Message-ID: <7c4acfbf-df61-a163-484d-0dc81d67eabf@redhat.com>

On 5/27/19 3:29 PM, Roman Kennke wrote:
> Looks like we've got a clash between rscratch1 used in
> g1_write_barrier_pre() and the rscratch that's passed as tmp from
> sharedRuntime_aarch64.cpp. You need this fix:
> 
> diff -r 9f523f185755 src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
> --- a/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 12:23:24
> 2019 +0200
> +++ b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 09:27:22
> 2019 -0400
> @@ -2066,7 +2066,7 @@
>        __ g1_write_barrier_pre(noreg /* obj */,
>                                r0 /* pre_val */,
>                                rthread /* thread */,
> -                              rscratch1 /* tmp */,
> +                              rscratch2 /* tmp */,
>                                true /* tosca_live */,
>                                true /* expand_call */);
>      }
> 
> This makes the failing test pass for me.

Yes, it does! Thank you.

> It probably warrants a more careful fix, extra asserts in
> g1_write_barrier_pre() and checking if newer versions have similar problems.

This is apparently fixed by:
  https://bugs.openjdk.java.net/browse/JDK-8186325

...and we "just" need to backport it.

-Aleksey


From shade at redhat.com  Mon May 27 16:58:15 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Mon, 27 May 2019 18:58:15 +0200
Subject: RFR/RFC [8u]: Enable weak JNI handling with Shenandoah after
 JDK-8176100
In-Reply-To: <7c4acfbf-df61-a163-484d-0dc81d67eabf@redhat.com>
References: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>
 <b666ad08-2048-c787-f78c-2910efc341ae@redhat.com>
 <7c4acfbf-df61-a163-484d-0dc81d67eabf@redhat.com>
Message-ID: <7327b190-0eca-a422-39ba-5a24e1572461@redhat.com>

On 5/27/19 5:39 PM, Aleksey Shipilev wrote:
> On 5/27/19 3:29 PM, Roman Kennke wrote:
>> Looks like we've got a clash between rscratch1 used in
>> g1_write_barrier_pre() and the rscratch that's passed as tmp from
>> sharedRuntime_aarch64.cpp. You need this fix:
>>
>> diff -r 9f523f185755 src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
>> --- a/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 12:23:24
>> 2019 +0200
>> +++ b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 09:27:22
>> 2019 -0400
>> @@ -2066,7 +2066,7 @@
>>        __ g1_write_barrier_pre(noreg /* obj */,
>>                                r0 /* pre_val */,
>>                                rthread /* thread */,
>> -                              rscratch1 /* tmp */,
>> +                              rscratch2 /* tmp */,
>>                                true /* tosca_live */,
>>                                true /* expand_call */);
>>      }
>>
>> This makes the failing test pass for me.
> 
> Yes, it does! Thank you.
> 
>> It probably warrants a more careful fix, extra asserts in
>> g1_write_barrier_pre() and checking if newer versions have similar problems.
> 
> This is apparently fixed by:
>   https://bugs.openjdk.java.net/browse/JDK-8186325
> 
> ...and we "just" need to backport it.

Here:
  https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-May/007397.html

Assuming it is approved soon, we would need to wait for another 8u pull to get it.

-Aleksey


From roman at kennke.org  Mon May 27 17:52:06 2019
From: roman at kennke.org (Roman Kennke)
Date: Mon, 27 May 2019 19:52:06 +0200
Subject: RFR/RFC [8u]: Enable weak JNI handling with Shenandoah after
 JDK-8176100
In-Reply-To: <7327b190-0eca-a422-39ba-5a24e1572461@redhat.com>
References: <c86bd84e-3c9c-1e1f-c1f2-da8fef52f972@redhat.com>
 <b666ad08-2048-c787-f78c-2910efc341ae@redhat.com>
 <7c4acfbf-df61-a163-484d-0dc81d67eabf@redhat.com>
 <7327b190-0eca-a422-39ba-5a24e1572461@redhat.com>
Message-ID: <17db35d7-f2d0-499c-6ae0-3a9161b5640e@kennke.org>

>>> Looks like we've got a clash between rscratch1 used in
>>> g1_write_barrier_pre() and the rscratch that's passed as tmp from
>>> sharedRuntime_aarch64.cpp. You need this fix:
>>>
>>> diff -r 9f523f185755 src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
>>> --- a/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 12:23:24
>>> 2019 +0200
>>> +++ b/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp	Mon May 27 09:27:22
>>> 2019 -0400
>>> @@ -2066,7 +2066,7 @@
>>>        __ g1_write_barrier_pre(noreg /* obj */,
>>>                                r0 /* pre_val */,
>>>                                rthread /* thread */,
>>> -                              rscratch1 /* tmp */,
>>> +                              rscratch2 /* tmp */,
>>>                                true /* tosca_live */,
>>>                                true /* expand_call */);
>>>      }
>>>
>>> This makes the failing test pass for me.
>>
>> Yes, it does! Thank you.
>>
>>> It probably warrants a more careful fix, extra asserts in
>>> g1_write_barrier_pre() and checking if newer versions have similar problems.
>>
>> This is apparently fixed by:
>>   https://bugs.openjdk.java.net/browse/JDK-8186325
>>
>> ...and we "just" need to backport it.
> 
> Here:
>   https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-May/007397.html
> 
> Assuming it is approved soon, we would need to wait for another 8u pull to get it.

Looks good to me.

Roman

From zgu at redhat.com  Tue May 28 16:17:55 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Tue, 28 May 2019 12:17:55 -0400
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should take
 lock to protect shared code roots array
Message-ID: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>

The patch changes ShenandoahHeapLock to general purpose spin lock and 
uses it to protect concurrent access to shared array during parallel 
cleaning at safepoints.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224875
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Tue May 28 16:28:31 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 28 May 2019 18:28:31 +0200
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
Message-ID: <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>

On 5/28/19 6:17 PM, Zhengyu Gu wrote:
> The patch changes ShenandoahHeapLock to general purpose spin lock and uses it to protect concurrent
> access to shared array during parallel cleaning at safepoints.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224875
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.00/

*) Name it ShenandoahLock, maybe? The fact it is a spin lock is the implementation detail. Maybe we
actually want to split out the rename into a separate changeset, so we can backport it ahead of time.

*) These two typedefs deserve to be in shenandoahHeap.hpp?

  96 typedef ShenandoahSpinLock   ShenandoahHeapLock;
  97 typedef ShenandoahSpinLocker ShenandoahHeapLocker;

*) You don't need a comment here, I think it is clear what that lock protects

 136   // Lock to protect recorded nms array
 137   static ShenandoahSpinLock                 _recorded_nms_lock;

*) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
ShenandoahCodeRoots::add_nmethod too?

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Tue May 28 16:57:21 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Tue, 28 May 2019 17:57:21 +0100
Subject: RFR] [8u] 8u222-b03 Upstream Sync
In-Reply-To: <10204a7b-c947-c12b-6bc8-a33fcb5d10c9@redhat.com>
References: <e920d489-9922-eb9c-6f95-9e0e8bdd1660@redhat.com>
 <10204a7b-c947-c12b-6bc8-a33fcb5d10c9@redhat.com>
Message-ID: <a1f062cd-5156-1503-6728-bbaa6738b9b3@redhat.com>



On 26/05/2019 22:34, Aleksey Shipilev wrote:
> On 5/24/19 9:20 PM, Andrew John Hughes wrote:
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/corba/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxp/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jaxws/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/nashorn/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/root/merge.changeset
> 
> Trivial.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/jdk/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/hotspot/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b03/langtools/merge.changeset
> 
> Looks good.
> 
> -Aleksey
> 

Thanks. Pushed.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From gnu.andrew at redhat.com  Tue May 28 17:13:30 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Tue, 28 May 2019 18:13:30 +0100
Subject: [RFR] [8u] 8u222-b04 Upstream Sync
Message-ID: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>

Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/

Merge changesets (not including 8210425):

http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/corba/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxp/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxws/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jdk/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/hotspot/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/langtools/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/nashorn/merge.changeset
http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/root/merge.changeset

Changes in aarch64-shenandoah-jdk8u222-b04:
  - S8158232: PPC64: improve byte, int and long array copy stubs by
using VSX instructions
  - S8190974: Parallel stream execution within a custom ForkJoinPool
should obey the parallelism
  - S8203190: SessionId.hashCode generates too many collisions
  - S8210425: [AArch64] sharedRuntimeTrig/sharedRuntimeTrans compiled
without optimization
  - S8223499: Remove two DocuSign root certificates that are expiring
  - S8223883: Fix jni.cpp copyright date after 8223528

Main issues of note:
No merge issues, just inclusion of AArch64 version of 8210425.

diffstat for root
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for corba
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for jaxp
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for jaxws
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for langtools
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for nashorn
 b/.hgtags |    1 +
 1 file changed, 1 insertion(+)
diffstat for jdk
 b/.hgtags
               |    1
 b/src/share/classes/java/util/stream/AbstractTask.java
               |   29 +
 b/src/share/classes/java/util/stream/ForEachOps.java
               |    5
 b/src/share/classes/java/util/stream/StreamSpliterators.java
               |    6
 b/src/share/classes/sun/security/ssl/SessionId.java
               |    7
 b/test/java/util/stream/test/org/openjdk/tests/java/util/stream/CustomFJPoolTest.java |  152 +++++++++
 b/test/sun/security/lib/cacerts/VerifyCACerts.java
               |   11
 b/test/sun/security/ssl/SessionIdCollisionTest.java
               |  158 ++++++++++
 8 files changed, 340 insertions(+), 29 deletions(-)
diffstat for hotspot
 b/.hgtags                              |    1
 b/src/cpu/ppc/vm/stubGenerator_ppc.cpp |  140
+++++++++++++++++++++++++++++++--
 b/src/share/vm/prims/jni.cpp           |    2
 3 files changed, 135 insertions(+), 8 deletions(-)

Successfully built on x86, x86_64, s390, s390x, ppc, ppc64, ppc64le &
aarch64.

Ok to push?
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Tue May 28 17:32:45 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 28 May 2019 19:32:45 +0200
Subject: [RFR] [8u] 8u222-b04 Upstream Sync
In-Reply-To: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>
References: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>
Message-ID: <75a2fecf-4aeb-034f-5fa2-b10e788eac70@redhat.com>

On 5/28/19 7:13 PM, Andrew John Hughes wrote:
> Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/
> 
> Merge changesets (not including 8210425):
> 
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/corba/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxp/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxws/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/langtools/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/nashorn/merge.changeset
> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/root/merge.changeset

Trivial and good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jdk/merge.changeset

Looks good.

> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/hotspot/merge.changeset

Looks good.

Is the copyright year adjustment in src/share/vm/prims/jni.cpp worthwhile? We can fix it along with
other minor things that differ from upstream later.

Thumbs up!

-Aleksey


From gnu.andrew at redhat.com  Tue May 28 17:42:04 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Tue, 28 May 2019 18:42:04 +0100
Subject: [RFR] [8u] 8u222-b04 Upstream Sync
In-Reply-To: <75a2fecf-4aeb-034f-5fa2-b10e788eac70@redhat.com>
References: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>
 <75a2fecf-4aeb-034f-5fa2-b10e788eac70@redhat.com>
Message-ID: <f8c81a8a-00e0-7480-a0ca-75f39f8039e1@redhat.com>



On 28/05/2019 18:32, Aleksey Shipilev wrote:
> On 5/28/19 7:13 PM, Andrew John Hughes wrote:
>> Webrevs: https://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/
>>
>> Merge changesets (not including 8210425):
>>
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/corba/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxp/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jaxws/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/langtools/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/nashorn/merge.changeset
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/root/merge.changeset
> 
> Trivial and good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/jdk/merge.changeset
> 
> Looks good.
> 
>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/hotspot/merge.changeset
> 
> Looks good.
> 
> Is the copyright year adjustment in src/share/vm/prims/jni.cpp worthwhile? We can fix it along with
> other minor things that differ from upstream later.
> 

I don't follow you. It's from upstream:

https://hg.openjdk.java.net//jdk8u/jdk8u/hotspot/rev/2afa5ff125ac24f372

> Thumbs up!
> 
> -Aleksey
> 

Pushed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Tue May 28 17:44:21 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 28 May 2019 19:44:21 +0200
Subject: [RFR] [8u] 8u222-b04 Upstream Sync
In-Reply-To: <f8c81a8a-00e0-7480-a0ca-75f39f8039e1@redhat.com>
References: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>
 <75a2fecf-4aeb-034f-5fa2-b10e788eac70@redhat.com>
 <f8c81a8a-00e0-7480-a0ca-75f39f8039e1@redhat.com>
Message-ID: <fea2f524-3e54-7b44-c1ac-ccade24a2754@redhat.com>

On 5/28/19 7:42 PM, Andrew John Hughes wrote:
>>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/hotspot/merge.changeset
>>
>> Looks good.
>>
>> Is the copyright year adjustment in src/share/vm/prims/jni.cpp worthwhile? We can fix it along with
>> other minor things that differ from upstream later.
> 
> I don't follow you. It's from upstream:
> 
> https://hg.openjdk.java.net//jdk8u/jdk8u/hotspot/rev/2afa5ff125ac24f372

Ah. I thought some "real change" was reverted, and only copyright line remained. But it is fine if
that was the intentional change.

-- 
Thanks,
-Aleksey


From gnu.andrew at redhat.com  Tue May 28 17:49:37 2019
From: gnu.andrew at redhat.com (Andrew John Hughes)
Date: Tue, 28 May 2019 18:49:37 +0100
Subject: [RFR] [8u] 8u222-b04 Upstream Sync
In-Reply-To: <fea2f524-3e54-7b44-c1ac-ccade24a2754@redhat.com>
References: <978f9199-bc5d-226f-d2c7-886698d9646a@redhat.com>
 <75a2fecf-4aeb-034f-5fa2-b10e788eac70@redhat.com>
 <f8c81a8a-00e0-7480-a0ca-75f39f8039e1@redhat.com>
 <fea2f524-3e54-7b44-c1ac-ccade24a2754@redhat.com>
Message-ID: <63d2a293-0a30-765f-4203-d3710fec9575@redhat.com>



On 28/05/2019 18:44, Aleksey Shipilev wrote:
> On 5/28/19 7:42 PM, Andrew John Hughes wrote:
>>>> http://cr.openjdk.java.net/~andrew/shenandoah-8/u222-b04/hotspot/merge.changeset
>>>
>>> Looks good.
>>>
>>> Is the copyright year adjustment in src/share/vm/prims/jni.cpp worthwhile? We can fix it along with
>>> other minor things that differ from upstream later.
>>
>> I don't follow you. It's from upstream:
>>
>> https://hg.openjdk.java.net//jdk8u/jdk8u/hotspot/rev/2afa5ff125ac24f372
> 
> Ah. I thought some "real change" was reverted, and only copyright line remained. But it is fine if
> that was the intentional change.
> 

It's part of one backport taking three changesets over multiple tags...

So b02 had:

changeset:   11216:32bc598624bd
tag:         jdk8u222-b02
user:        phh
date:        Tue May 07 20:38:26 2019 +0000
summary:     8176100: [REDO][REDO] G1 Needs pre barrier on dereference
of weak JNI handles

b03 then had:

changeset:   11221:e86bc9786d83
parent:      11216:32bc598624bd
user:        phh
date:        Fri May 10 18:50:40 2019 +0000
summary:     8223664: Add jtreg tests for 8223528, backport to jdk8u of
8176100

and b04 had:

changeset:   11232:2afa5ff125ac
parent:      11227:af43bab3c5d0
user:        phh
date:        Mon May 20 14:37:33 2019 +0000
summary:     8223883: Fix jni.cpp copyright date after 8223528

which reverts the following bad change in the 8176100 original:

diff --git a/src/share/vm/prims/jni.cpp b/src/share/vm/prims/jni.cpp
--- a/src/share/vm/prims/jni.cpp
+++ b/src/share/vm/prims/jni.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights
reserved.
+ * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights
reserved.
  * Copyright (c) 2012 Red Hat, Inc.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


From shade at redhat.com  Wed May 29 10:17:58 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 12:17:58 +0200
Subject: RFR [8] [backport] 8220714: C2 Compilation failure when accessing
 off-heap memory using Unsafe
Message-ID: <1c06ea50-5466-1a8e-6983-94cc8ac0ebb7@redhat.com>

I have not yet convinced myself the upstream fix is ideal, so let's do the next best thing: fix it
for Shenandoah only. This backport also brings in the test that fails without the fix, and passes
with it:
  http://cr.openjdk.java.net/~shade/shenandoah/8u-8220714/webrev.01/

Once upstream fix arrives, we would ditch that new block.

Testing: hotspot_gc_shenandoah {fastdebug|release}; {x86_32, x86_64} builds

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 10:20:41 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 12:20:41 +0200
Subject: RFR [8] [backport] 8220714: C2 Compilation failure when accessing
 off-heap memory using Unsafe
In-Reply-To: <1c06ea50-5466-1a8e-6983-94cc8ac0ebb7@redhat.com>
References: <1c06ea50-5466-1a8e-6983-94cc8ac0ebb7@redhat.com>
Message-ID: <f6fa074d-0af0-1318-104b-c1ae96d62999@redhat.com>

> I have not yet convinced myself the upstream fix is ideal, so let's do the next best thing: fix it
> for Shenandoah only. This backport also brings in the test that fails without the fix, and passes
> with it:
>   http://cr.openjdk.java.net/~shade/shenandoah/8u-8220714/webrev.01/
> 
> Once upstream fix arrives, we would ditch that new block.
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}; {x86_32, x86_64} builds

Upstream fix so far would be the same as this backport, except without
the guards?

I think this fix is the exact equivalent to what we've done in newer
versions. Looks good to me.

Roman



From shade at redhat.com  Wed May 29 10:24:20 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 12:24:20 +0200
Subject: RFR [8] [backport] 8220714: C2 Compilation failure when accessing
 off-heap memory using Unsafe
In-Reply-To: <f6fa074d-0af0-1318-104b-c1ae96d62999@redhat.com>
References: <1c06ea50-5466-1a8e-6983-94cc8ac0ebb7@redhat.com>
 <f6fa074d-0af0-1318-104b-c1ae96d62999@redhat.com>
Message-ID: <db72ad49-39c1-2bb9-9cfc-99770f8ad7f7@redhat.com>

On 5/29/19 12:20 PM, Roman Kennke wrote:
>> I have not yet convinced myself the upstream fix is ideal, so let's do the next best thing: fix it
>> for Shenandoah only. This backport also brings in the test that fails without the fix, and passes
>> with it:
>>   http://cr.openjdk.java.net/~shade/shenandoah/8u-8220714/webrev.01/
>>
>> Once upstream fix arrives, we would ditch that new block.
>>
>> Testing: hotspot_gc_shenandoah {fastdebug|release}; {x86_32, x86_64} builds
> 
> Upstream fix so far would be the same as this backport, except without
> the guards?

Yes, as long as I convince myself it has no ill effects. Having this in for Shenandoah would give us
some testing edge.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed May 29 10:55:27 2019
From: shade at redhat.com (shade at redhat.com)
Date: Wed, 29 May 2019 10:55:27 +0000
Subject: hg: shenandoah/jdk8/hotspot: [backport] 8220714: C2 Compilation
 failure when accessing off-heap memory using Unsafe
Message-ID: <201905291055.x4TAtRU1002059@aojmv0008.oracle.com>

Changeset: eb25f2203b39
Author:    rkennke
Date:      2019-03-15 09:57 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/eb25f2203b39

[backport] 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe

! src/share/vm/opto/library_call.cpp
+ test/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java


From zgu at redhat.com  Wed May 29 11:13:03 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 07:13:03 -0400
Subject: RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it
 general purpose lock
Message-ID: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>

Please review this refactor ShenandoahHeapLock to general purpose spin 
lock (I kept ShenandoahSpinLock, cause ShenandoahLock was taken in 
another changeset. Any other suggestions for the name?)

Bug: https://bugs.openjdk.java.net/browse/JDK-8224932
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224932/webrev.00/

Test:
   hotspot_gc_shenandoah (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Wed May 29 11:19:58 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 13:19:58 +0200
Subject: RFR (XS) 8224880: ShenandoahRootScanner::roots_do assert is too strong
Message-ID: <1a025fa8-c21c-d631-189b-8b0683125c14@redhat.com>

Bug:
  https://bugs.openjdk.java.net/browse/JDK-8224970

It reliably happens with x86_32 and gc/shenandoah/oom tests that enter the heap inspection on OOM.
That operation is done under its own VM op. So, the fix is to relax the assert to accept
non-Shenandoah safepoints.

diff -r 785a12e0f89b src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
--- a/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp        Wed May 29 12:01:21
2019 +0200
+++ b/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp        Wed May 29 12:57:03
2019 +0200
@@ -28,4 +28,5 @@
 #include "gc/shenandoah/shenandoahRootProcessor.hpp"
 #include "gc/shenandoah/shenandoahTimingTracker.hpp"
+#include "gc/shenandoah/shenandoahUtils.hpp"
 #include "memory/resourceArea.hpp"

@@ -91,7 +92,8 @@
 template <typename ITR>
 void ShenandoahRootScanner<ITR>::roots_do(uint worker_id, OopClosure* oops, CLDClosure* clds,
CodeBlobClosure* code, ThreadClosure *tc) {
-  assert(!ShenandoahHeap::heap()->unload_classes() ||
+  assert(!ShenandoahSafepoint::is_at_shenandoah_safepoint() ||
+         !ShenandoahHeap::heap()->unload_classes() ||
           ShenandoahHeap::heap()->heuristics()->can_do_traversal_gc(),
-          "No class unloading or traversal GC");
+          "Expect class unloading or traversal when Shenandoah cycle is running");
   ShenandoahParallelOopsDoThreadClosure tc_cl(oops, code, tc);
   ResourceMark rm;


Testing: hotspot_gc_shenandoah + failing test

-- 
Thanks,
-Aleksey


From shade at redhat.com  Wed May 29 11:26:01 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 13:26:01 +0200
Subject: RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it
 general purpose lock
In-Reply-To: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>
References: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>
Message-ID: <de7c2ce3-3e83-a594-1ed3-3cb04c85d1e3@redhat.com>

On 5/29/19 1:13 PM, Zhengyu Gu wrote:
> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
> the name?)

I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
are no conflicts in current jdk/jdk I can see.

> Bug: https://bugs.openjdk.java.net/browse/JDK-8224932
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224932/webrev.00/

Otherwise looks good.

-Aleksey


From zgu at redhat.com  Wed May 29 11:29:11 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 07:29:11 -0400
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
Message-ID: <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>

On 5/28/19 12:28 PM, Aleksey Shipilev wrote:
> On 5/28/19 6:17 PM, Zhengyu Gu wrote:
>> The patch changes ShenandoahHeapLock to general purpose spin lock and uses it to protect concurrent
>> access to shared array during parallel cleaning at safepoints.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224875
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.00/
> 
> *) Name it ShenandoahLock, maybe? The fact it is a spin lock is the implementation detail. Maybe we
> actually want to split out the rename into a separate changeset, so we can backport it ahead of time.

Okay, split into JDK-8224932


> 
> *) These two typedefs deserve to be in shenandoahHeap.hpp?
> 
>    96 typedef ShenandoahSpinLock   ShenandoahHeapLock;
>    97 typedef ShenandoahSpinLocker ShenandoahHeapLocker;

Done in JDK-8224932

> 
> *) You don't need a comment here, I think it is clear what that lock protects
> 
>   136   // Lock to protect recorded nms array
>   137   static ShenandoahSpinLock                 _recorded_nms_lock;

Okay.

> 
> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
> ShenandoahCodeRoots::add_nmethod too?
> 
Sure.

Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.01/

Reran hotspot_gc_shenandoah test.

Thanks,

-Zhengyu




From shade at redhat.com  Wed May 29 11:31:49 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 13:31:49 +0200
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
Message-ID: <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>

On 5/29/19 1:29 PM, Zhengyu Gu wrote:
>> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
>> ShenandoahCodeRoots::add_nmethod too?
>>
> Sure.

So... should we make (add|remove)_nmethod symmetrical? If remove_* can acquire the lock, then add_*
should do that too?

> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.01/

Otherwise good.

-Aleksey


From zgu at redhat.com  Wed May 29 11:40:58 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 07:40:58 -0400
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
Message-ID: <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>



On 5/29/19 7:31 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:29 PM, Zhengyu Gu wrote:
>>> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
>>> ShenandoahCodeRoots::add_nmethod too?
>>>
>> Sure.
> 
> So... should we make (add|remove)_nmethod symmetrical? If remove_* can acquire the lock, then add_*
> should do that too?
I don't think add_nmethod needs additional lock, cause it is always 
called with CodeCache_lock outside safepoints. The new lock only 
protects concurrent workers when unregister nmethods during safepoint 
cleanup.

> 
>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.01/
> 
> Otherwise good.

Thanks,

-Zhengyu

> 
> -Aleksey
> 

From zgu at redhat.com  Wed May 29 11:43:34 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 07:43:34 -0400
Subject: RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it
 general purpose lock
In-Reply-To: <de7c2ce3-3e83-a594-1ed3-3cb04c85d1e3@redhat.com>
References: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>
 <de7c2ce3-3e83-a594-1ed3-3cb04c85d1e3@redhat.com>
Message-ID: <4088fa15-c496-987f-c566-78f968d942ac@redhat.com>



On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>> the name?)
> 
> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
> are no conflicts in current jdk/jdk I can see.

Right, it is in concurrent class unloading changeset, and not yet here.

Thanks,

-Zhengyu

> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224932
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224932/webrev.00/
> 
> Otherwise looks good.
> 
> -Aleksey
> 

From rkennke at redhat.com  Wed May 29 12:01:25 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 14:01:25 +0200
Subject: RFR (11): Revert to emit locked cmpxchg only on MP
Message-ID: <be697b65-e238-54d8-0733-47c4bf8b9d7f@redhat.com>

Last backports introduced a minor diff vs. upstream that we can and
should revert:

http://cr.openjdk.java.net/~rkennke/jdk11-revert-lock-cas/webrev.00/

Testing: hotspot_gc_shenandoah

Ok?

Roman


From zgu at redhat.com  Wed May 29 12:22:26 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 08:22:26 -0400
Subject: RFR (XS) 8224880: ShenandoahRootScanner::roots_do assert is too
 strong
In-Reply-To: <1a025fa8-c21c-d631-189b-8b0683125c14@redhat.com>
References: <1a025fa8-c21c-d631-189b-8b0683125c14@redhat.com>
Message-ID: <957b36cf-f373-7ab5-4de6-c515a09b12a6@redhat.com>



On 5/29/19 7:19 AM, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8224970
> 
> It reliably happens with x86_32 and gc/shenandoah/oom tests that enter the heap inspection on OOM.
> That operation is done under its own VM op. So, the fix is to relax the assert to accept
> non-Shenandoah safepoints.
> 
> diff -r 785a12e0f89b src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp        Wed May 29 12:01:21
> 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp        Wed May 29 12:57:03
> 2019 +0200
> @@ -28,4 +28,5 @@
>   #include "gc/shenandoah/shenandoahRootProcessor.hpp"
>   #include "gc/shenandoah/shenandoahTimingTracker.hpp"
> +#include "gc/shenandoah/shenandoahUtils.hpp"
>   #include "memory/resourceArea.hpp"
> 
> @@ -91,7 +92,8 @@
>   template <typename ITR>
>   void ShenandoahRootScanner<ITR>::roots_do(uint worker_id, OopClosure* oops, CLDClosure* clds,
> CodeBlobClosure* code, ThreadClosure *tc) {
> -  assert(!ShenandoahHeap::heap()->unload_classes() ||
> +  assert(!ShenandoahSafepoint::is_at_shenandoah_safepoint() ||
> +         !ShenandoahHeap::heap()->unload_classes() ||
>             ShenandoahHeap::heap()->heuristics()->can_do_traversal_gc(),
> -          "No class unloading or traversal GC");
> +          "Expect class unloading or traversal when Shenandoah cycle is running");
>     ShenandoahParallelOopsDoThreadClosure tc_cl(oops, code, tc);
>     ResourceMark rm;
Okay.

-Zhengyu

> 
> 
> Testing: hotspot_gc_shenandoah + failing test
> 

From shade at redhat.com  Wed May 29 13:07:43 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:07:43 +0200
Subject: RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it
 general purpose lock
In-Reply-To: <4088fa15-c496-987f-c566-78f968d942ac@redhat.com>
References: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>
 <de7c2ce3-3e83-a594-1ed3-3cb04c85d1e3@redhat.com>
 <4088fa15-c496-987f-c566-78f968d942ac@redhat.com>
Message-ID: <99dbf2fa-eae9-5a21-2e77-49d26a23dbb9@redhat.com>

On 5/29/19 1:43 PM, Zhengyu Gu wrote:
> On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
>> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>>> the name?)
>>
>> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
>> are no conflicts in current jdk/jdk I can see.
> 
> Right, it is in concurrent class unloading changeset, and not yet here.

Well, that means *that* changeset should use another identifier. It has no business hoarding the
generic "ShenandoahLock", IMO.

-Aleksey


From shade at redhat.com  Wed May 29 13:18:19 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:18:19 +0200
Subject: RFR (11): Revert to emit locked cmpxchg only on MP
In-Reply-To: <be697b65-e238-54d8-0733-47c4bf8b9d7f@redhat.com>
References: <be697b65-e238-54d8-0733-47c4bf8b9d7f@redhat.com>
Message-ID: <7d3cc0e4-7cf2-bd07-b027-b7318ed519cf@redhat.com>

On 5/29/19 2:01 PM, Roman Kennke wrote:
> Last backports introduced a minor diff vs. upstream that we can and
> should revert:
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-revert-lock-cas/webrev.00/

Looks good.

I think there is a white-space difference here:
 1942    } else {

See:

https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp.sdiff.html

Can you "hg diff -r 435ba0b576c9 src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp" to see it?

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 13:21:49 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 15:21:49 +0200
Subject: RFR (11): Cleaner separation between Shenandoah and other GCs in C1's
 compare-and-swap generation
Message-ID: <e6318cc4-405a-f9ac-c6b2-765bf3faf9e0@redhat.com>

Looking at this here:

https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp.udiff.html

I see that we're unconditionally allocating 2 tmp registers for c1's
CAS, because we need them for Shenandoah. We better separate this to
compile only with INCLUDE_SHENANDOAHGC and when UseShenandoahGC, so that
other GCs don't get punished by Shenandoah-only requirement:

http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.00/

Ok?

Roman


From rkennke at redhat.com  Wed May 29 13:23:36 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 15:23:36 +0200
Subject: RFR (11): Revert to emit locked cmpxchg only on MP
In-Reply-To: <7d3cc0e4-7cf2-bd07-b027-b7318ed519cf@redhat.com>
References: <be697b65-e238-54d8-0733-47c4bf8b9d7f@redhat.com>
 <7d3cc0e4-7cf2-bd07-b027-b7318ed519cf@redhat.com>
Message-ID: <69db31a8-eb1c-ff6b-4c6f-271526044ddb@redhat.com>

>> Last backports introduced a minor diff vs. upstream that we can and
>> should revert:
>>
>> http://cr.openjdk.java.net/~rkennke/jdk11-revert-lock-cas/webrev.00/
> 
> Looks good.
> 
> I think there is a white-space difference here:
>  1942    } else {
> 
> See:
> 
> https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp.sdiff.html
> 
> Can you "hg diff -r 435ba0b576c9 src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp" to see it?

I'll revert that WS diff too, ok?

Roman



From shade at redhat.com  Wed May 29 13:24:36 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:24:36 +0200
Subject: RFR (11): Revert to emit locked cmpxchg only on MP
In-Reply-To: <69db31a8-eb1c-ff6b-4c6f-271526044ddb@redhat.com>
References: <be697b65-e238-54d8-0733-47c4bf8b9d7f@redhat.com>
 <7d3cc0e4-7cf2-bd07-b027-b7318ed519cf@redhat.com>
 <69db31a8-eb1c-ff6b-4c6f-271526044ddb@redhat.com>
Message-ID: <a15ccb57-7245-de1f-e0cd-b57778600996@redhat.com>

On 5/29/19 3:23 PM, Roman Kennke wrote:
>>> Last backports introduced a minor diff vs. upstream that we can and
>>> should revert:
>>>
>>> http://cr.openjdk.java.net/~rkennke/jdk11-revert-lock-cas/webrev.00/
>>
>> Looks good.
>>
>> I think there is a white-space difference here:
>>  1942    } else {
>>
>> See:
>>
>> https://builds.shipilev.net/patch-openjdk-shenandoah-jdk11/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp.sdiff.html
>>
>> Can you "hg diff -r 435ba0b576c9 src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp" to see it?
> 
> I'll revert that WS diff too, ok?

Yes, do that before push. Check the "hg diff" above before you push.

-Aleksey


From rkennke at redhat.com  Wed May 29 13:25:53 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Wed, 29 May 2019 13:25:53 +0000
Subject: hg: shenandoah/jdk11: Revert to emit locked cmpxchg only on MP
Message-ID: <201905291325.x4TDPsnW007526@aojmv0008.oracle.com>

Changeset: ee1b9d72a1ba
Author:    rkennke
Date:      2019-05-29 14:35 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/ee1b9d72a1ba

Revert to emit locked cmpxchg only on MP

! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp


From shade at redhat.com  Wed May 29 13:29:03 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:29:03 +0200
Subject: RFR (11): Cleaner separation between Shenandoah and other GCs in
 C1's compare-and-swap generation
In-Reply-To: <e6318cc4-405a-f9ac-c6b2-765bf3faf9e0@redhat.com>
References: <e6318cc4-405a-f9ac-c6b2-765bf3faf9e0@redhat.com>
Message-ID: <720bfb5a-d6f5-7597-f249-b9267827fc70@redhat.com>

On 5/29/19 3:21 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.00/

Right on.

I think we should #include "utilities/macros.hpp" to gain access to INCLUDE_SHENANDOAHGC without
precompiled headers.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 13:37:24 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 15:37:24 +0200
Subject: RFR (11): Cleaner separation between Shenandoah and other GCs in
 C1's compare-and-swap generation
In-Reply-To: <720bfb5a-d6f5-7597-f249-b9267827fc70@redhat.com>
References: <e6318cc4-405a-f9ac-c6b2-765bf3faf9e0@redhat.com>
 <720bfb5a-d6f5-7597-f249-b9267827fc70@redhat.com>
Message-ID: <f8676fc5-b790-36c1-cfa9-7aaabcc3d43b@redhat.com>

> On 5/29/19 3:21 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.00/
> 
> Right on.
> 
> I think we should #include "utilities/macros.hpp" to gain access to INCLUDE_SHENANDOAHGC without
> precompiled headers.

Right.

http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.01/

Good?

Roman


From shade at redhat.com  Wed May 29 13:37:56 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:37:56 +0200
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
 <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
Message-ID: <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>

On 5/29/19 1:40 PM, Zhengyu Gu wrote:
> On 5/29/19 7:31 AM, Aleksey Shipilev wrote:
>> On 5/29/19 1:29 PM, Zhengyu Gu wrote:
>>>> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
>>>> ShenandoahCodeRoots::add_nmethod too?
>>>>
>>> Sure.
>>
>> So... should we make (add|remove)_nmethod symmetrical? If remove_* can acquire the lock, then add_*
>> should do that too?
> I don't think add_nmethod needs additional lock, cause it is always called with CodeCache_lock
> outside safepoints. The new lock only protects concurrent workers when unregister nmethods during
> safepoint cleanup.

Okay, this asymmetry still irks me.

I see G1CollectedHeap::register_nmethod eventually calls into
HeapRegion::add_strong_code_root_locked, which does assert_locked_or_safepoint(CodeCache_lock), and
then does the complicated check like this downstream:

  assert((CodeCache_lock->owned_by_self() ||
         (SafepointSynchronize::is_at_safepoint() &&
          (_m.owned_by_self() || Thread::current()->is_VM_thread()))),

How much does it really hurt for us to be on a safe side and grab the lock on add_* path too? We
would normally enter there with CodeCache lock held, and this might just protect us from some rare
corner case.

Thanks,
-Aleksey


From shade at redhat.com  Wed May 29 13:39:48 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 15:39:48 +0200
Subject: RFR (11): Cleaner separation between Shenandoah and other GCs in
 C1's compare-and-swap generation
In-Reply-To: <f8676fc5-b790-36c1-cfa9-7aaabcc3d43b@redhat.com>
References: <e6318cc4-405a-f9ac-c6b2-765bf3faf9e0@redhat.com>
 <720bfb5a-d6f5-7597-f249-b9267827fc70@redhat.com>
 <f8676fc5-b790-36c1-cfa9-7aaabcc3d43b@redhat.com>
Message-ID: <cbc59f94-dad2-f4e2-fdee-ba28ab32c2c9@redhat.com>

On 5/29/19 3:37 PM, Roman Kennke wrote:
>> On 5/29/19 3:21 PM, Roman Kennke wrote:
>>> http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.00/
>>
>> Right on.
>>
>> I think we should #include "utilities/macros.hpp" to gain access to INCLUDE_SHENANDOAHGC without
>> precompiled headers.
> 
> Right.
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-better-c1-cas-regalloc/webrev.01/

Looks good.

-Aleksey


From rkennke at redhat.com  Wed May 29 13:41:42 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Wed, 29 May 2019 13:41:42 +0000
Subject: hg: shenandoah/jdk11: Cleaner separation between Shenandoah and other
 GCs in C1's compare-and-swap generation
Message-ID: <201905291341.x4TDfhEM017468@aojmv0008.oracle.com>

Changeset: 08744769b9f6
Author:    rkennke
Date:      2019-05-29 15:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/08744769b9f6

Cleaner separation between Shenandoah and other GCs in C1's compare-and-swap generation

! src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp


From zgu at redhat.com  Wed May 29 13:44:53 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 09:44:53 -0400
Subject: RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it
 general purpose lock
In-Reply-To: <99dbf2fa-eae9-5a21-2e77-49d26a23dbb9@redhat.com>
References: <44155f7e-4b04-71e1-8a4d-999c42190507@redhat.com>
 <de7c2ce3-3e83-a594-1ed3-3cb04c85d1e3@redhat.com>
 <4088fa15-c496-987f-c566-78f968d942ac@redhat.com>
 <99dbf2fa-eae9-5a21-2e77-49d26a23dbb9@redhat.com>
Message-ID: <7d164b80-b166-de63-4873-3833418e751b@redhat.com>

Okay, renamed and pushed.

Thanks,

-Zhengyu

On 5/29/19 9:07 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:43 PM, Zhengyu Gu wrote:
>> On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
>>> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>>>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>>>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>>>> the name?)
>>>
>>> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
>>> are no conflicts in current jdk/jdk I can see.
>>
>> Right, it is in concurrent class unloading changeset, and not yet here.
> 
> Well, that means *that* changeset should use another identifier. It has no business hoarding the
> generic "ShenandoahLock", IMO.
> 
> -Aleksey
> 

From zgu at redhat.com  Wed May 29 14:30:24 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 10:30:24 -0400
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
 <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
 <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>
Message-ID: <bf5762eb-0b99-d6a4-36aa-892fe8883aa0@redhat.com>



On 5/29/19 9:37 AM, Aleksey Shipilev wrote:
> On 5/29/19 1:40 PM, Zhengyu Gu wrote:
>> On 5/29/19 7:31 AM, Aleksey Shipilev wrote:
>>> On 5/29/19 1:29 PM, Zhengyu Gu wrote:
>>>>> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
>>>>> ShenandoahCodeRoots::add_nmethod too?
>>>>>
>>>> Sure.
>>>
>>> So... should we make (add|remove)_nmethod symmetrical? If remove_* can acquire the lock, then add_*
>>> should do that too?
>> I don't think add_nmethod needs additional lock, cause it is always called with CodeCache_lock
>> outside safepoints. The new lock only protects concurrent workers when unregister nmethods during
>> safepoint cleanup.
> 
> Okay, this asymmetry still irks me.
> 
> I see G1CollectedHeap::register_nmethod eventually calls into
> HeapRegion::add_strong_code_root_locked, which does assert_locked_or_safepoint(CodeCache_lock), and
> then does the complicated check like this downstream:
> 
>    assert((CodeCache_lock->owned_by_self() ||
>           (SafepointSynchronize::is_at_safepoint() &&
>            (_m.owned_by_self() || Thread::current()->is_VM_thread()))),
> 
> How much does it really hurt for us to be on a safe side and grab the lock on add_* path too? We
> would normally enter there with CodeCache lock held, and this might just protect us from some rare
> corner case.

We can make it symmetric, but it does nothing :-)

In add_nmethod(), We assert:

assert(CodeCache_lock->owned_by_self(), "Must own CodeCache_lock");

if we put lock there as we do for remove_nmethod()

ShenandoahLocker locker(CodeCache_lock->owned_by_self() ? NULL : 
&_recorded_nms_lock);

It should always pass NULL to locker.

How about enhancing assertions and comments, clearly states the purpose 
of the lock.

http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.02/

Thanks,

-Zhengyu












> 
> Thanks,
> -Aleksey
> 

From shade at redhat.com  Wed May 29 14:42:09 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 16:42:09 +0200
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <bf5762eb-0b99-d6a4-36aa-892fe8883aa0@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
 <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
 <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>
 <bf5762eb-0b99-d6a4-36aa-892fe8883aa0@redhat.com>
Message-ID: <449d30c2-bd06-1999-af46-ad0b5f7f4b77@redhat.com>

On 5/29/19 4:30 PM, Zhengyu Gu wrote:
>> How much does it really hurt for us to be on a safe side and grab the lock on add_* path too? We
>> would normally enter there with CodeCache lock held, and this might just protect us from some rare
>> corner case.
> 
> We can make it symmetric, but it does nothing :-)

Please do. We *think* it does nothing now, because we don't see how we can enter add_nmethod without
holding the CodeCache_lock. But do understand that is a flaky temporary understanding that can
change at any moment. The code should fail safe when that happens.

> ShenandoahLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);
> It should always pass NULL to locker.

...and that is a problem how? The same happens in remove_nmethod.

> How about enhancing assertions and comments, clearly states the purpose of the lock.
> http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.02/
No, that is somehow worse. What prevents us to put this to both methods, and be done?

  assert_locked_or_safepoint(CodeCache_lock);
  ShenandoahSpinLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);


Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 14:43:15 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 16:43:15 +0200
Subject: RFR (11): Revert MachMemBarNode related diffs vs. upstream
Message-ID: <2afba40c-98ad-f152-4796-950a24f7be15@redhat.com>

Back when we had membars in our barriers (acmp I think), we needed some
extra fluff to deal with those. We can revert this in 11 now:

http://cr.openjdk.java.net/~rkennke/jdk11-revert-machmembarnode/webrev.00/

This is mostly a reversal of the upstream change (>11):

http://hg.openjdk.java.net/jdk/jdk/rev/904cf5407ac7

with some added extra cleanups in the touched files.

This cleans up our upstream diff, and reduces risks.

Testing: hotspot_gc_shenandoah

Good?

Roman


From zgu at redhat.com  Wed May 29 14:50:53 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 10:50:53 -0400
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <449d30c2-bd06-1999-af46-ad0b5f7f4b77@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
 <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
 <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>
 <bf5762eb-0b99-d6a4-36aa-892fe8883aa0@redhat.com>
 <449d30c2-bd06-1999-af46-ad0b5f7f4b77@redhat.com>
Message-ID: <6e02977b-caf1-f0f8-296e-cc65320a5b2b@redhat.com>

> 
>    assert_locked_or_safepoint(CodeCache_lock);
>    ShenandoahSpinLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);

Okay. http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.03/

-Zhengyu

> 
> 
> Thanks,
> -Aleksey
> 

From shade at redhat.com  Wed May 29 14:55:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 16:55:16 +0200
Subject: RFR 8224875: Shenandoah: ParallelCleaning code unloading should
 take lock to protect shared code roots array
In-Reply-To: <6e02977b-caf1-f0f8-296e-cc65320a5b2b@redhat.com>
References: <7da54d3f-7818-3128-34ba-1adcbb2bb7c5@redhat.com>
 <8de74d12-43cc-bc0f-ef65-19a0821a5816@redhat.com>
 <8c43b056-601b-8ed9-a625-b2ce4f66f30c@redhat.com>
 <3aec2f45-4013-510c-2b63-883f580296f8@redhat.com>
 <ab905cb3-41b4-e18e-5c01-473f82b895c7@redhat.com>
 <b916fa5b-6844-15c6-2819-a32a59e02fba@redhat.com>
 <bf5762eb-0b99-d6a4-36aa-892fe8883aa0@redhat.com>
 <449d30c2-bd06-1999-af46-ad0b5f7f4b77@redhat.com>
 <6e02977b-caf1-f0f8-296e-cc65320a5b2b@redhat.com>
Message-ID: <69274d88-1325-1a6c-816b-c3cc6084fbb0@redhat.com>

On 5/29/19 4:50 PM, Zhengyu Gu wrote:
>>
>> ?? assert_locked_or_safepoint(CodeCache_lock);
>> ?? ShenandoahSpinLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);
> 
> Okay. http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.03/

Add a new line here:

 137       assert_locked_or_safepoint(CodeCache_lock);
 138       ShenandoahLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);
 <here>
 139       ShenandoahNMethodOopDetector detector;

...and the whole thing is good to go in.

-Aleksey


From shade at redhat.com  Wed May 29 14:57:34 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 16:57:34 +0200
Subject: RFR (11): Revert MachMemBarNode related diffs vs. upstream
In-Reply-To: <2afba40c-98ad-f152-4796-950a24f7be15@redhat.com>
References: <2afba40c-98ad-f152-4796-950a24f7be15@redhat.com>
Message-ID: <a95946e8-333a-f45f-b73a-04d667ae0fbb@redhat.com>

On 5/29/19 4:43 PM, Roman Kennke wrote:
> Back when we had membars in our barriers (acmp I think), we needed some
> extra fluff to deal with those. We can revert this in 11 now:
> http://cr.openjdk.java.net/~rkennke/jdk11-revert-machmembarnode/webrev.00/
> 
> This is mostly a reversal of the upstream change (>11):
> http://hg.openjdk.java.net/jdk/jdk/rev/904cf5407ac7
Yes, the reversal looks good.

Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 15:57:58 2019
From: rkennke at redhat.com (rkennke at redhat.com)
Date: Wed, 29 May 2019 15:57:58 +0000
Subject: hg: shenandoah/jdk11: Revert MachMemBarNode related diffs vs. upstream
Message-ID: <201905291557.x4TFvxvd013270@aojmv0008.oracle.com>

Changeset: c53c15bbecff
Author:    rkennke
Date:      2019-05-29 16:39 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/c53c15bbecff

Revert MachMemBarNode related diffs vs. upstream

! src/hotspot/share/adlc/formssel.cpp
! src/hotspot/share/adlc/formssel.hpp
! src/hotspot/share/adlc/output_c.cpp
! src/hotspot/share/adlc/output_h.cpp
! src/hotspot/share/opto/machnode.cpp
! src/hotspot/share/opto/machnode.hpp
! src/hotspot/share/opto/matcher.cpp
! src/hotspot/share/opto/node.hpp


From zgu at redhat.com  Wed May 29 16:01:13 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 12:01:13 -0400
Subject: RFR(S) 8224978: Shenandoah: Allows root verifier to verify some roots
 outside safepoints with proper locks
Message-ID: <fe870e62-dd47-17b7-28cf-94724587cefc@redhat.com>

Please review this patch that allows root verifier to verify CLDG and 
code roots outside safepoints, with proper locks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8224978
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.00/

Test:
   hotspot_gc_shenandoah + ShenandoahVerify (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Wed May 29 20:13:42 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Wed, 29 May 2019 22:13:42 +0200
Subject: RFR (XS) 8225017: [TESTBUG] gc/shenandoah/oom/TestThreadFailure.java
 takes too long
Message-ID: <1e80edef-f27e-c885-002a-5cfa6519402b@redhat.com>

RFE:
  https://bugs.openjdk.java.net/browse/JDK-8225017

Change is to drop one of the configs and trim down the other one:

diff -r b7ac60035a28 test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
--- a/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Thu May 16 15:58:15 2019 -0700
+++ b/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Wed May 29 22:12:38 2019 +0200
@@ -64,19 +64,5 @@
         {
             ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
-                    "-Xmx16m",
-                    "-XX:+UnlockExperimentalVMOptions",
-                    "-XX:+UseShenandoahGC",
-                    TestThreadFailure.class.getName(),
-                    "test");
-
-            OutputAnalyzer analyzer = new OutputAnalyzer(pb.start());
-            analyzer.shouldHaveExitValue(0);
-            analyzer.shouldContain("java.lang.OutOfMemoryError");
-            analyzer.shouldContain("All good");
-        }
-
-        {
-            ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
-                    "-Xmx128m",
+                    "-Xmx64m",
                     "-XX:+UnlockExperimentalVMOptions",
                     "-XX:+UseShenandoahGC",

Testing: hotspot_gc_shenandoah {x86_64, x86_32}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Wed May 29 20:33:22 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Wed, 29 May 2019 22:33:22 +0200
Subject: RFR (XS) 8225017: [TESTBUG]
 gc/shenandoah/oom/TestThreadFailure.java takes too long
In-Reply-To: <1e80edef-f27e-c885-002a-5cfa6519402b@redhat.com>
References: <1e80edef-f27e-c885-002a-5cfa6519402b@redhat.com>
Message-ID: <09f399ad-11d7-9a9d-7b7d-a849b4e0c3b9@redhat.com>

Seems ok.
Thanks,
Roman


> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8225017
> 
> Change is to drop one of the configs and trim down the other one:
> 
> diff -r b7ac60035a28 test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
> --- a/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Thu May 16 15:58:15 2019 -0700
> +++ b/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Wed May 29 22:12:38 2019 +0200
> @@ -64,19 +64,5 @@
>          {
>              ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
> -                    "-Xmx16m",
> -                    "-XX:+UnlockExperimentalVMOptions",
> -                    "-XX:+UseShenandoahGC",
> -                    TestThreadFailure.class.getName(),
> -                    "test");
> -
> -            OutputAnalyzer analyzer = new OutputAnalyzer(pb.start());
> -            analyzer.shouldHaveExitValue(0);
> -            analyzer.shouldContain("java.lang.OutOfMemoryError");
> -            analyzer.shouldContain("All good");
> -        }
> -
> -        {
> -            ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
> -                    "-Xmx128m",
> +                    "-Xmx64m",
>                      "-XX:+UnlockExperimentalVMOptions",
>                      "-XX:+UseShenandoahGC",
> 
> Testing: hotspot_gc_shenandoah {x86_64, x86_32}
> 


From zgu at redhat.com  Thu May 30 00:52:59 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Wed, 29 May 2019 20:52:59 -0400
Subject: RFR 8225014: Separate ShenandoahRootScanner method for object_iterate
Message-ID: <64e54f3d-d0b2-d15e-9a04-64ae89e37ae6@redhat.com>

Please review this patch that allows SH::object_iterate() invokes 
ShenandoahRootScanner method without assertion. A regression test is 
also added.


Bug: https://bugs.openjdk.java.net/browse/JDK-8225014
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225014/webrev.00/

Test:
   hotspot_gc_shenandoah with new regression test (fastdebug and release)

Thanks,

-Zhengyu

From shade at redhat.com  Thu May 30 09:16:17 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 11:16:17 +0200
Subject: RFR 8225014: Separate ShenandoahRootScanner method for
 object_iterate
In-Reply-To: <64e54f3d-d0b2-d15e-9a04-64ae89e37ae6@redhat.com>
References: <64e54f3d-d0b2-d15e-9a04-64ae89e37ae6@redhat.com>
Message-ID: <3b3cb71d-8d5d-b480-c654-06fcadc3bfef@redhat.com>

On 5/30/19 2:52 AM, Zhengyu Gu wrote:
> Please review this patch that allows SH::object_iterate() invokes ShenandoahRootScanner method
> without assertion. A regression test is also added.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225014
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225014/webrev.00/

*) Suggestion for the name "roots_do_no_assert" -> "roots_do_unchecked"

*) I was thinking that object_iterate should visit the code cache too. Current shared method would
do that optionally depending on ShenandoahConcurrentScanCodeRoots. Maybe it is cleaner to just do
the separate "roots_do_all" specifically for heap iteration?

Regression test looks nice.

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 30 09:17:16 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 11:17:16 +0200
Subject: RFR (XS) 8225017: [TESTBUG]
 gc/shenandoah/oom/TestThreadFailure.java takes too long
In-Reply-To: <09f399ad-11d7-9a9d-7b7d-a849b4e0c3b9@redhat.com>
References: <1e80edef-f27e-c885-002a-5cfa6519402b@redhat.com>
 <09f399ad-11d7-9a9d-7b7d-a849b4e0c3b9@redhat.com>
Message-ID: <8bc3a938-c900-5089-55db-575690c4923d@redhat.com>

Thanks, pushed.

-Aleksey

On 5/29/19 10:33 PM, Roman Kennke wrote:
> Seems ok.
> Thanks,
> Roman
> 
> 
>> RFE:
>>   https://bugs.openjdk.java.net/browse/JDK-8225017
>>
>> Change is to drop one of the configs and trim down the other one:
>>
>> diff -r b7ac60035a28 test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java
>> --- a/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Thu May 16 15:58:15 2019 -0700
>> +++ b/test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java       Wed May 29 22:12:38 2019 +0200
>> @@ -64,19 +64,5 @@
>>          {
>>              ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
>> -                    "-Xmx16m",
>> -                    "-XX:+UnlockExperimentalVMOptions",
>> -                    "-XX:+UseShenandoahGC",
>> -                    TestThreadFailure.class.getName(),
>> -                    "test");
>> -
>> -            OutputAnalyzer analyzer = new OutputAnalyzer(pb.start());
>> -            analyzer.shouldHaveExitValue(0);
>> -            analyzer.shouldContain("java.lang.OutOfMemoryError");
>> -            analyzer.shouldContain("All good");
>> -        }
>> -
>> -        {
>> -            ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
>> -                    "-Xmx128m",
>> +                    "-Xmx64m",
>>                      "-XX:+UnlockExperimentalVMOptions",
>>                      "-XX:+UseShenandoahGC",
>>
>> Testing: hotspot_gc_shenandoah {x86_64, x86_32}
>>
> 


-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 30 09:58:08 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 11:58:08 +0200
Subject: RFC: Pick up jdk-13+22 to sh/jdk
Message-ID: <9b6f953c-e2d5-e571-ee8f-766f0881f803@redhat.com>

jdk/jdk is somewhat stable at the moment, let's pick it up to sh/jdk. This is the penultimate
stepping stone for upstreaming x86_32 support. The merges were simple, but not trivial, but I
verified those are correct by diffing against jdk/jdk. We would check webrevs again once this merge
lands.

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b22/changesets.txt

Notable ones:
  8221507: Implement JFR Events for Shenandoah
  8224495: Shenandoah: Do not rescan code roots in final mark pause if it is not degenerated GC
  8224579: ResourceMark not declared in shenandoahRootProcessor.inline.hpp with
--disable-precompiled-headers
  8224508: Shenandoah: Need to update thread roots in final mark for piggyback ref update cycle
  8224525: Shenandoah: Eliminate shenandoah verifier's side-effects
  8224529: [TESTBUG] JFR TestShenandoahHeapRegion* tests fail on build w/o Shenandoah
  8224522: Shenandoah should apply barriers on deoptimization
  8224667: Shenandoah: Post-LRB cleanup
  8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator noncopyable
  8224115: Shenandoah: Eliminate RWLock that protects recorded nmethod data array
  8224751: Shenandoah: Shenandoah Verifier should select proper roots according to current GC cycle
  8224584: Shenandoah: Eliminate forwarding pointer word
  8224496: Shenandoah compilation fails with assert(is_CountedLoopEnd()) failed: invalid node class
  8224970: ShenandoahRootScanner::roots_do assert is too strong
  8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock
  8224875: Shenandoah: ParallelCleaning code unloading should take lock to protect shared code roots

Testing: hotspot_gc_shenandoah {x86_32, x86_64}, eyeballing the diff against jdk/jdk

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 30 10:05:04 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 12:05:04 +0200
Subject: RFC: Pick up 11.0.4+5 to sh/jdk11
Message-ID: <92b382b4-6b94-a7f8-a811-306c92d5d2d1@redhat.com>

Upstream had published 11.0.4+5, let's pick that up to sh/jdk11. The merges were trivial, but I
would like to give it a single pass via testing before tagging it shenandoah-jdk-11.0.4+5.

Changesets:
  http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b5/changesets.txt

Testing: hotspot_gc_shenandoah {fastdebug|release}

-- 
Thanks,
-Aleksey


From shade at redhat.com  Thu May 30 10:16:19 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 12:16:19 +0200
Subject: RFR(S) 8224978: Shenandoah: Allows root verifier to verify some
 roots outside safepoints with proper locks
In-Reply-To: <fe870e62-dd47-17b7-28cf-94724587cefc@redhat.com>
References: <fe870e62-dd47-17b7-28cf-94724587cefc@redhat.com>
Message-ID: <2e2de49d-782a-7966-e6d4-13ec8508b24f@redhat.com>

On 5/29/19 6:01 PM, Zhengyu Gu wrote:
> Please review this patch that allows root verifier to verify CLDG and code roots outside safepoints,
> with proper locks.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224978
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.00/

*) Don't we want to demote those checks to "asserts"? Is there a reason to have these checks in
release bits (and make it pay on tiny root sets)?

*) Maybe it should be moved to shenandoahAsserts. I think these new definitions:

 shenandoah_assert_safepoint()
 shenandoah_assert_locked_or_safepoint(lock)

-Aleksey


From rkennke at redhat.com  Thu May 30 10:28:49 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 30 May 2019 12:28:49 +0200
Subject: RFC: Pick up jdk-13+22 to sh/jdk
In-Reply-To: <9b6f953c-e2d5-e571-ee8f-766f0881f803@redhat.com>
References: <9b6f953c-e2d5-e571-ee8f-766f0881f803@redhat.com>
Message-ID: <7e25a459-ccc5-261d-933e-27cfe843425a@redhat.com>

Yes, let's do it.

Thanks,
Roman

> jdk/jdk is somewhat stable at the moment, let's pick it up to sh/jdk. This is the penultimate
> stepping stone for upstreaming x86_32 support. The merges were simple, but not trivial, but I
> verified those are correct by diffing against jdk/jdk. We would check webrevs again once this merge
> lands.
> 
> Changesets:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk-13%2b22/changesets.txt
> 
> Notable ones:
>   8221507: Implement JFR Events for Shenandoah
>   8224495: Shenandoah: Do not rescan code roots in final mark pause if it is not degenerated GC
>   8224579: ResourceMark not declared in shenandoahRootProcessor.inline.hpp with
> --disable-precompiled-headers
>   8224508: Shenandoah: Need to update thread roots in final mark for piggyback ref update cycle
>   8224525: Shenandoah: Eliminate shenandoah verifier's side-effects
>   8224529: [TESTBUG] JFR TestShenandoahHeapRegion* tests fail on build w/o Shenandoah
>   8224522: Shenandoah should apply barriers on deoptimization
>   8224667: Shenandoah: Post-LRB cleanup
>   8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator noncopyable
>   8224115: Shenandoah: Eliminate RWLock that protects recorded nmethod data array
>   8224751: Shenandoah: Shenandoah Verifier should select proper roots according to current GC cycle
>   8224584: Shenandoah: Eliminate forwarding pointer word
>   8224496: Shenandoah compilation fails with assert(is_CountedLoopEnd()) failed: invalid node class
>   8224970: ShenandoahRootScanner::roots_do assert is too strong
>   8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock
>   8224875: Shenandoah: ParallelCleaning code unloading should take lock to protect shared code roots
> 
> Testing: hotspot_gc_shenandoah {x86_32, x86_64}, eyeballing the diff against jdk/jdk
> 


From rkennke at redhat.com  Thu May 30 10:29:06 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 30 May 2019 12:29:06 +0200
Subject: RFC: Pick up 11.0.4+5 to sh/jdk11
In-Reply-To: <92b382b4-6b94-a7f8-a811-306c92d5d2d1@redhat.com>
References: <92b382b4-6b94-a7f8-a811-306c92d5d2d1@redhat.com>
Message-ID: <7cff40b1-85aa-144f-f043-70b88e1b7ec0@redhat.com>

Yes, let's do it.

Thanks,
Roman

> Upstream had published 11.0.4+5, let's pick that up to sh/jdk11. The merges were trivial, but I
> would like to give it a single pass via testing before tagging it shenandoah-jdk-11.0.4+5.
> 
> Changesets:
>   http://cr.openjdk.java.net/~shade/shenandoah/merges/jdk11-11.0.4%2b5/changesets.txt
> 
> Testing: hotspot_gc_shenandoah {fastdebug|release}
> 


From shade at redhat.com  Thu May 30 10:35:02 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 30 May 2019 10:35:02 +0000
Subject: hg: shenandoah/jdk: 152 new changesets
Message-ID: <201905301035.x4UAZE0Y026015@aojmv0008.oracle.com>

Changeset: 2523496f5107
Author:    coleenp
Date:      2019-05-20 10:06 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2523496f5107

8221967: InternTest.java timed out
Summary: Move redundant table lookup and make rehashing be a needed guaranteed safepoint cleanup action.
Reviewed-by: dholmes, rehn

! src/hotspot/share/classfile/stringTable.cpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/runtime/safepoint.cpp

Changeset: 6cbb5c2255e3
Author:    lucy
Date:      2019-05-20 17:44 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6cbb5c2255e3

8223444: Improve CodeHeap Free Space Management
Reviewed-by: kvn, thartmann

! src/hotspot/cpu/aarch64/c2_globals_aarch64.hpp
! src/hotspot/cpu/arm/c2_globals_arm.hpp
! src/hotspot/cpu/ppc/c2_globals_ppc.hpp
! src/hotspot/cpu/sparc/c2_globals_sparc.hpp
! src/hotspot/cpu/x86/c2_globals_x86.hpp
! src/hotspot/share/memory/heap.cpp
! src/hotspot/share/memory/heap.hpp

Changeset: 9f714ef845d5
Author:    lancea
Date:      2019-05-20 12:24 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9f714ef845d5

8222807: Address iteration with invalid ZIP header entries
Reviewed-by: redestad, clanger

! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java
+ test/jdk/jdk/nio/zipfs/InvalidZipHeaderTests.java

Changeset: cc92a45f4c73
Author:    aeubanks
Date:      2019-05-15 09:15 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cc92a45f4c73

8223214: Inet6AddressImpl.loopbackAddress() should choose loopback address that is available
Reviewed-by: chegar
Contributed-by: aeubanks at google.com

! src/java.base/share/classes/java/net/Inet6AddressImpl.java

Changeset: b7c408df5008
Author:    darcy
Date:      2019-05-20 10:16 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b7c408df5008

8224174: java.lang.Number has a default constructor
Reviewed-by: rriggs, bpb

! src/java.base/share/classes/java/lang/Number.java

Changeset: 69d1dff1bb70
Author:    aeubanks
Date:      2019-05-15 17:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/69d1dff1bb70

8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available
Reviewed-by: chegar, dfuchs, alanb
Contributed-by: aeubanks at google.com

! test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java

Changeset: 751a19168b11
Author:    aeubanks
Date:      2019-05-15 16:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/751a19168b11

8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment
Reviewed-by: chegar, dfuchs
Contributed-by: aeubanks at google.com

! test/jdk/java/net/NetworkInterface/IPv4Only.java

Changeset: 7bfb499b4f38
Author:    jiangli
Date:      2019-05-20 10:32 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7bfb499b4f38

Merge


Changeset: 46ae54c3026d
Author:    jjg
Date:      2019-05-20 10:57 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/46ae54c3026d

8223663: Update links for tool guides
Reviewed-by: alanb, erikj, darcy

! make/Docs.gmk
+ make/jdk/src/classes/build/tools/taglet/ToolGuide.java
! src/java.base/share/classes/module-info.java
! src/java.rmi/share/classes/module-info.java
! src/java.scripting/share/classes/module-info.java
! src/jdk.compiler/share/classes/module-info.java
! src/jdk.hotspot.agent/share/classes/module-info.java
! src/jdk.jartool/share/classes/module-info.java
! src/jdk.javadoc/share/classes/module-info.java
! src/jdk.jcmd/share/classes/module-info.java
! src/jdk.jconsole/share/classes/module-info.java
! src/jdk.jdeps/share/classes/module-info.java
! src/jdk.jdi/share/classes/module-info.java
! src/jdk.jfr/share/classes/module-info.java
! src/jdk.jlink/share/classes/module-info.java
! src/jdk.jshell/share/classes/module-info.java
! src/jdk.jstatd/share/classes/module-info.java
! src/jdk.pack/share/classes/module-info.java
! src/jdk.rmic/share/classes/module-info.java
! src/jdk.scripting.nashorn.shell/share/classes/module-info.java

Changeset: a73fe240da4a
Author:    mseledtsov
Date:      2019-05-20 15:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a73fe240da4a

8220672: [TESTBUG] TestCPUSets should check that cpuset does not exceed available cores
Summary: making sure cpuset size does not exceed available cores
Reviewed-by: dholmes, lmesnik

! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/containers/docker/TestCPUSets.java

Changeset: a978d86ac389
Author:    darcy
Date:      2019-05-20 17:29 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a978d86ac389

8224175: Fix inconsistencies in @jls and @jvms tags
Reviewed-by: jjg, rfield

! src/java.base/share/classes/java/lang/Byte.java
! src/java.base/share/classes/java/lang/Class.java
! src/java.base/share/classes/java/lang/ClassLoader.java
! src/java.base/share/classes/java/lang/Double.java
! src/java.base/share/classes/java/lang/Float.java
! src/java.base/share/classes/java/lang/FunctionalInterface.java
! src/java.base/share/classes/java/lang/Integer.java
! src/java.base/share/classes/java/lang/Long.java
! src/java.base/share/classes/java/lang/Number.java
! src/java.base/share/classes/java/lang/Package.java
! src/java.base/share/classes/java/lang/Short.java
! src/java.base/share/classes/java/lang/SuppressWarnings.java
! src/java.base/share/classes/java/lang/constant/Constable.java
! src/java.base/share/classes/java/lang/reflect/Method.java
! src/java.base/share/classes/java/lang/reflect/Modifier.java
! src/java.compiler/share/classes/javax/lang/model/AnnotatedConstruct.java
! src/java.compiler/share/classes/javax/lang/model/element/Element.java
! src/java.compiler/share/classes/javax/lang/model/element/NestingKind.java
! src/java.compiler/share/classes/javax/lang/model/util/Types.java
! src/jdk.compiler/share/classes/com/sun/source/tree/BinaryTree.java
! src/jdk.compiler/share/classes/com/sun/source/tree/ModifiersTree.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
! src/jdk.jshell/share/classes/jdk/jshell/ExpressionSnippet.java
! src/jdk.jshell/share/classes/jdk/jshell/ImportSnippet.java
! src/jdk.jshell/share/classes/jdk/jshell/MethodSnippet.java
! src/jdk.jshell/share/classes/jdk/jshell/Snippet.java
! src/jdk.jshell/share/classes/jdk/jshell/StatementSnippet.java
! src/jdk.jshell/share/classes/jdk/jshell/VarSnippet.java

Changeset: 566fbca8a890
Author:    jjg
Date:      2019-05-20 18:18 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/566fbca8a890

8224166: Create a taglet to better handle @jls and @jvms tags
Reviewed-by: erikj, darcy

! make/Docs.gmk
+ make/jdk/src/classes/build/tools/taglet/JSpec.java

Changeset: 6ec71a88b68e
Author:    sspitsyn
Date:      2019-05-21 00:52 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6ec71a88b68e

8183273: Clarify Instrumentation interface should not be implemented outside java.instrument module
Summary: Add a note with a clarification
Reviewed-by: alanb, dholmes, jcbeyler

! src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java

Changeset: 46409371a691
Author:    rehn
Date:      2019-05-21 10:34 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/46409371a691

8223306: Remove threads linked list (use ThreadsList's array in SA)
Reviewed-by: coleenp, dholmes, dcubed

! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/threadSMR.hpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/DeadlockDetector.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/PStack.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/StackTrace.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/JavaThreadsPanel.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PointerFinder.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/ReversePtrsAnalysis.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaVM.java
! test/hotspot/jtreg/serviceability/sa/ClhsdbField.java
! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java
! test/hotspot/jtreg/serviceability/sa/ClhsdbVmStructsDump.java

Changeset: 43340a79840d
Author:    kdobson
Date:      2019-05-21 10:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/43340a79840d

8221507: Implement JFR Events for Shenandoah
Reviewed-by: rkennke, shade, egahlin, mseledtsov
Contributed-by: Ken Dobson <kdobson at redhat.com>

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahJfrSupport.cpp
+ src/hotspot/share/gc/shenandoah/shenandoahJfrSupport.hpp
! src/hotspot/share/jfr/metadata/metadata.xml
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! src/jdk.jfr/share/conf/jfr/default.jfc
! src/jdk.jfr/share/conf/jfr/profile.jfc
+ test/jdk/jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionInformationEvent.java
+ test/jdk/jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionStateChangeEvent.java
! test/lib/jdk/test/lib/jfr/EventNames.java
! test/lib/jdk/test/lib/jfr/GCHelper.java

Changeset: b6b02a503d02
Author:    rehn
Date:      2019-05-21 10:46 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b6b02a503d02

8223313: Use handshakes for CountStackFrames.
Reviewed-by: dholmes, rrich, dcubed

! src/hotspot/share/prims/jvm.cpp

Changeset: 55bfc2eee3ab
Author:    pmuthuswamy
Date:      2019-05-21 15:02 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/55bfc2eee3ab

8223733: "Detail" in headings should be "Details"
Reviewed-by: hannesw

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties
! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java
! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java
! test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java
! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java
! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java
! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java

Changeset: 00425a850a2f
Author:    mdoerr
Date:      2019-05-21 11:45 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/00425a850a2f

8224230: [PPC64, s390] Support AsyncGetCallTrace
Reviewed-by: goetz, jcbeyler, sspitsyn

! src/hotspot/os_cpu/linux_ppc/thread_linux_ppc.cpp
! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp
! src/hotspot/share/prims/forte.cpp
! test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java

Changeset: e46fe26d7f77
Author:    lucy
Date:      2019-05-21 15:51 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e46fe26d7f77

8213084: Rework and enhance Print[Opto]Assembly output
Reviewed-by: kvn, thartmann

! src/hotspot/cpu/aarch64/assembler_aarch64.hpp
! src/hotspot/cpu/aarch64/disassembler_aarch64.hpp
! src/hotspot/cpu/arm/assembler_arm_32.hpp
! src/hotspot/cpu/arm/disassembler_arm.hpp
! src/hotspot/cpu/ppc/assembler_ppc.hpp
+ src/hotspot/cpu/ppc/disassembler_ppc.cpp
! src/hotspot/cpu/ppc/disassembler_ppc.hpp
! src/hotspot/cpu/ppc/vm_version_ppc.cpp
! src/hotspot/cpu/s390/assembler_s390.hpp
! src/hotspot/cpu/s390/assembler_s390.inline.hpp
+ src/hotspot/cpu/s390/disassembler_s390.cpp
! src/hotspot/cpu/s390/disassembler_s390.hpp
! src/hotspot/cpu/s390/s390.ad
! src/hotspot/cpu/s390/vm_version_s390.cpp
! src/hotspot/cpu/sparc/assembler_sparc.hpp
! src/hotspot/cpu/sparc/disassembler_sparc.hpp
! src/hotspot/cpu/sparc/sparc.ad
! src/hotspot/cpu/x86/assembler_x86.hpp
! src/hotspot/cpu/x86/disassembler_x86.hpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/cpu/zero/assembler_zero.hpp
! src/hotspot/cpu/zero/disassembler_zero.hpp
! src/hotspot/share/asm/codeBuffer.cpp
! src/hotspot/share/asm/codeBuffer.hpp
! src/hotspot/share/code/codeBlob.cpp
! src/hotspot/share/code/codeBlob.hpp
! src/hotspot/share/code/exceptionHandlerTable.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/nmethod.hpp
! src/hotspot/share/code/pcDesc.cpp
! src/hotspot/share/code/pcDesc.hpp
! src/hotspot/share/code/vmreg.cpp
! src/hotspot/share/code/vtableStubs.cpp
+ src/hotspot/share/compiler/abstractDisassembler.cpp
+ src/hotspot/share/compiler/abstractDisassembler.hpp
! src/hotspot/share/compiler/disassembler.cpp
! src/hotspot/share/compiler/disassembler.hpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/opto/block.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/compile.hpp
! src/hotspot/share/opto/output.cpp
! src/hotspot/share/runtime/stubCodeGenerator.cpp
! src/hotspot/share/utilities/globalDefinitions.hpp

Changeset: 30c8a21ce002
Author:    coleenp
Date:      2019-05-21 09:53 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/30c8a21ce002

8224119: Safepoint cleanup logging logs times for things it doesn't do
Summary: test condition before reporting times for cleanup actions.
Reviewed-by: rehn, hseigel

! src/hotspot/share/classfile/classLoaderDataGraph.cpp
! src/hotspot/share/classfile/classLoaderDataGraph.hpp
! src/hotspot/share/runtime/safepoint.cpp
! test/hotspot/jtreg/runtime/logging/SafepointCleanupTest.java

Changeset: 1b28206dcbcb
Author:    stuefe
Date:      2019-05-21 18:22 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/1b28206dcbcb

8224034: [TESTBUG] runtime/ErrorHandlerTest/ErrorHandler fails intermittently for case 13 on Windows
Reviewed-by: dholmes

! test/hotspot/jtreg/runtime/ErrorHandling/ErrorHandler.java

Changeset: a5f5e680ea32
Author:    zgu
Date:      2019-05-21 13:06 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a5f5e680ea32

8224495: Shenandoah: Do not rescan code roots in final mark pause if it is not degenerated GC
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

Changeset: ec7d6d8effc7
Author:    mgronlun
Date:      2019-05-21 20:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ec7d6d8effc7

8220293: Deadlock in JFR string pool
Reviewed-by: rehn, egahlin

! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp
! src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp
! src/hotspot/share/jfr/recorder/storage/jfrBuffer.hpp
! src/hotspot/share/jfr/recorder/storage/jfrMemorySpace.inline.hpp
! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp
! src/hotspot/share/jfr/recorder/storage/jfrStorageUtils.hpp
! src/hotspot/share/jfr/recorder/storage/jfrStorageUtils.inline.hpp
! src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp
! src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp

Changeset: e022b9cb35a5
Author:    vromero
Date:      2019-05-21 15:44 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e022b9cb35a5

8223723: j.l.c.MethodTypeDesc.dropParameterTypes??? throws the undocumented exception: IllegalArgumentException
Reviewed-by: rriggs

! src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java
! src/java.base/share/classes/java/lang/constant/MethodTypeDescImpl.java
! test/jdk/java/lang/constant/MethodTypeDescTest.java

Changeset: 508285c7c6f7
Author:    epavlova
Date:      2019-05-21 12:29 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/508285c7c6f7

8222482: [Graal] Update java-allocation-instrumenter.jar handling in graalunit README.md
Reviewed-by: kvn, shade

! test/hotspot/jtreg/compiler/graalunit/README.md
+ test/hotspot/jtreg/compiler/graalunit/downloadLibs.sh

Changeset: 3adf893a6861
Author:    vromero
Date:      2019-05-21 15:59 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3adf893a6861

8223725: j.l.c.MethodHandleDesc::of throws undocumented exception IllegalArgumentException
Reviewed-by: rriggs

! src/java.base/share/classes/java/lang/constant/MethodHandleDesc.java

Changeset: c13b1382aa30
Author:    naoto
Date:      2019-05-21 13:40 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c13b1382aa30

8224105: Cannot parse JapaneseDate string on some specified locales
Reviewed-by: bchristi

! src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
! test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java

Changeset: 6bd29804ace0
Author:    joehw
Date:      2019-05-21 14:55 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6bd29804ace0

8219692: DOM and SAX parsers ignore namespace
Reviewed-by: lancea

! src/java.xml/share/classes/javax/xml/parsers/DocumentBuilderFactory.java
! src/java.xml/share/classes/javax/xml/parsers/SAXParserFactory.java
! test/jaxp/javax/xml/jaxp/unittest/parsers/BaseParsingTest.java

Changeset: 76d3d96a8bc2
Author:    kbarrett
Date:      2019-05-21 19:19 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/76d3d96a8bc2

8224167: Refactor PtrQueue completed buffer processing
Summary: Add handle_completed_buffer and refactor.
Reviewed-by: tschatzl, shade

! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp
! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/ptrQueue.hpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp

Changeset: 4285b4d13471
Author:    igerasim
Date:      2019-05-21 18:40 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4285b4d13471

8223593: Refactor code for reallocating storage
Reviewed-by: prappo, plevart, rriggs, smarks

! src/java.base/share/classes/java/io/BufferedInputStream.java
! src/java.base/share/classes/java/io/ByteArrayOutputStream.java
! src/java.base/share/classes/java/lang/StringLatin1.java
! src/java.base/share/classes/java/lang/StringUTF16.java
! src/java.base/share/classes/java/nio/file/Files.java
! src/java.base/share/classes/java/util/AbstractCollection.java
! src/java.base/share/classes/java/util/ArrayList.java
! src/java.base/share/classes/java/util/PriorityQueue.java
! src/java.base/share/classes/java/util/Vector.java
! src/java.base/share/classes/java/util/regex/Pattern.java
! src/java.base/share/classes/jdk/internal/util/ArraysSupport.java

Changeset: f98a0ab24887
Author:    henryjen
Date:      2019-05-21 20:14 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f98a0ab24887

8218997: Xusage text, man help, etc doesn't mention -Xlog option.
Reviewed-by: dholmes

! src/java.base/share/classes/sun/launcher/resources/launcher.properties

Changeset: 0927d8c7296f
Author:    stuefe
Date:      2019-05-22 07:10 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0927d8c7296f

8224487: outputStream should not be copyable
Reviewed-by: kbarrett, coleenp

! src/hotspot/share/c1/c1_Runtime1.cpp
! src/hotspot/share/code/codeHeapState.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/interpreter/bytecodeInterpreter.cpp
! src/hotspot/share/interpreter/interpreterRuntime.cpp
! src/hotspot/share/jvmci/jvmciRuntime.cpp
! src/hotspot/share/utilities/events.cpp
! src/hotspot/share/utilities/events.hpp
! src/hotspot/share/utilities/exceptions.cpp
! src/hotspot/share/utilities/exceptions.hpp
! src/hotspot/share/utilities/ostream.hpp

Changeset: 22961d673487
Author:    stuefe
Date:      2019-05-22 09:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/22961d673487

8224193: stringStream should not use Resouce Area
Reviewed-by: goetz, coleenp, dholmes

! src/hotspot/share/utilities/ostream.cpp
! src/hotspot/share/utilities/ostream.hpp
+ test/hotspot/gtest/utilities/test_ostream.cpp

Changeset: 6b976a59ee87
Author:    clanger
Date:      2019-05-22 08:42 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6b976a59ee87

8224573: Fix windows build after JDK-8221507
Reviewed-by: shade, stuefe

! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahJfrSupport.cpp

Changeset: b1f070f4a4ae
Author:    shade
Date:      2019-05-22 10:48 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b1f070f4a4ae

8224579: ResourceMark not declared in shenandoahRootProcessor.inline.hpp with --disable-precompiled-headers
Reviewed-by: shade
Contributed-by: Ao Qi <aoqi at loongson.cn>

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp

Changeset: ab96027e99ed
Author:    tschatzl
Date:      2019-05-22 11:19 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ab96027e99ed

8224160: Move G1RemSetScanClosure into g1RemSet.cpp file
Reviewed-by: kbarrett, sangheki

! src/hotspot/share/gc/g1/g1RemSet.cpp
! src/hotspot/share/gc/g1/g1RemSet.hpp

Changeset: 5b4d1b87dd4b
Author:    dholmes
Date:      2019-05-22 06:13 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5b4d1b87dd4b

8224570: Update ProblemList-graal.txt
Reviewed-by: thartmann

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: f982c1a6582c
Author:    smonteith
Date:      2019-05-22 06:29 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f982c1a6582c

8224187: Refactor arraycopy_prologue to allow ZGC read barriers on arraycopy
Reviewed-by: eosterlund

! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

Changeset: e2c952c7ff20
Author:    redestad
Date:      2019-05-22 13:19 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e2c952c7ff20

8224589: Improve startup behavior of SecurityProperties
Reviewed-by: alanb

! src/java.base/share/classes/sun/security/util/SecurityProperties.java

Changeset: 0b56fc0448ec
Author:    zgu
Date:      2019-05-22 07:12 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0b56fc0448ec

8224508: Shenandoah: Need to update thread roots in final mark for piggyback ref update cycle
Reviewed-by: shade, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

Changeset: b18c8301b8c2
Author:    stefank
Date:      2019-05-22 13:05 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b18c8301b8c2

8224201: Simplify JVM flag macro expansions
Reviewed-by: rehn, kvn, stuefe, tschatzl, coleenp, gziemski

- src/hotspot/share/c1/c1_globals.cpp
! src/hotspot/share/c1/c1_globals.hpp
+ src/hotspot/share/compiler/compiler_globals.hpp
! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/epsilon/epsilon_globals.hpp
! src/hotspot/share/gc/g1/g1EvacFailure.cpp
! src/hotspot/share/gc/g1/g1EvacStats.cpp
! src/hotspot/share/gc/g1/g1HotCardCache.hpp
! src/hotspot/share/gc/g1/g1_globals.hpp
! src/hotspot/share/gc/shared/gc_globals.hpp
! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp
! src/hotspot/share/jvmci/jvmci.cpp
! src/hotspot/share/jvmci/jvmci_globals.cpp
! src/hotspot/share/jvmci/jvmci_globals.hpp
! src/hotspot/share/oops/methodData.hpp
- src/hotspot/share/opto/c2_globals.cpp
! src/hotspot/share/opto/c2_globals.hpp
! src/hotspot/share/runtime/flags/jvmFlag.cpp
! src/hotspot/share/runtime/flags/jvmFlagConstraintList.cpp
! src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp
! src/hotspot/share/runtime/flags/jvmFlagWriteableList.cpp
! src/hotspot/share/runtime/globals.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/globals_ext.hpp
! src/hotspot/share/runtime/globals_extension.hpp
+ src/hotspot/share/runtime/globals_shared.hpp
! src/hotspot/share/runtime/safepoint.cpp

Changeset: 81becad91321
Author:    stefank
Date:      2019-05-22 13:06 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/81becad91321

8224203: Remove need to specify type when using FLAG_SET macros
Reviewed-by: rehn, pliden, coleenp

! src/hotspot/cpu/ppc/c2_init_ppc.cpp
! src/hotspot/cpu/ppc/vm_version_ppc.cpp
! src/hotspot/cpu/sparc/vm_version_sparc.cpp
! src/hotspot/cpu/x86/rdtsc_x86.cpp
! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/windows/os_windows.cpp
! src/hotspot/share/aot/aotLoader.hpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/compiler/compilerDefinitions.cpp
! src/hotspot/share/gc/cms/cmsArguments.cpp
! src/hotspot/share/gc/g1/g1Arguments.cpp
! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp
! src/hotspot/share/gc/g1/heapRegion.cpp
! src/hotspot/share/gc/parallel/parallelArguments.cpp
! src/hotspot/share/gc/shared/gcArguments.cpp
! src/hotspot/share/gc/shared/gcConfig.cpp
! src/hotspot/share/gc/shared/genArguments.cpp
! src/hotspot/share/jfr/recorder/jfrRecorder.cpp
! src/hotspot/share/memory/metaspace.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/compilationPolicy.cpp
! src/hotspot/share/runtime/globals_extension.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! test/hotspot/gtest/gc/shared/test_collectorPolicy.cpp
! test/hotspot/gtest/runtime/test_os_windows.cpp

Changeset: 8f7d232b4225
Author:    dfuchs
Date:      2019-05-22 13:58 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8f7d232b4225

8224204: Replace wildcard address with loopback or local host in tests - part 10
Summary: Fixed intermittently failing tests
Reviewed-by: chegar

! test/jdk/sun/net/InetAddress/nameservice/simple/DefaultCaching.java
! test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
! test/jdk/sun/net/www/http/KeepAliveStream/InfiniteLoop.java
! test/jdk/sun/net/www/protocol/http/B6369510.java
! test/jdk/sun/net/www/protocol/http/BasicLongCredentials.java
! test/jdk/sun/net/www/protocol/http/NTLMTest.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/HttpsPost.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/ProxyTunnelServer.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/RetryHttps.java

Changeset: 37d8790efed7
Author:    zgu
Date:      2019-05-22 09:10 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/37d8790efed7

8224525: Shenandoah: Eliminate shenandoah verifier's side-effects
Reviewed-by: shade, rkennke

! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: 3b4ecc4180e0
Author:    vromero
Date:      2019-05-22 09:26 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3b4ecc4180e0

8223914: specification of j.l.c.MethodTypeDesc::of should document better the exceptions thrown
Reviewed-by: rriggs

! src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java
! test/jdk/java/lang/constant/MethodTypeDescTest.java

Changeset: 2ffbc00d87ae
Author:    dtitov
Date:      2019-05-22 09:06 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2ffbc00d87ae

8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows
Reviewed-by: dholmes, amenkov, bulasevich, dfuchs, erikj

! make/test/JtregNativeJdk.gmk
! test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
! test/jdk/sun/management/windows/README
+ test/jdk/sun/management/windows/exerevokeall.c
- test/jdk/sun/management/windows/revokeall.c
- test/jdk/sun/management/windows/revokeall.exe

Changeset: dd15cec077fc
Author:    jcbeyler
Date:      2019-05-22 09:32 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dd15cec077fc

8224500: Put HeapMonitorStatArrayCorrectnessTest in the problem list
Summary: Since the test is failing, let's quarantine it
Reviewed-by: stuefe

! test/hotspot/jtreg/ProblemList.txt

Changeset: d0c73c8f35ca
Author:    aeubanks
Date:      2019-05-20 14:19 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d0c73c8f35ca

8224248: test/jdk/java/net/InetAddress/CheckJNI.java assumes 127.0.0.1 is available
Reviewed-by: dfuchs, chegar
Contributed-by: aeubanks at google.com

! test/jdk/java/net/InetAddress/CheckJNI.java

Changeset: cbc557f166f2
Author:    dpochepk
Date:      2019-05-22 20:12 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cbc557f166f2

8215792: AArch64: String.indexOf generates incorrect result
Reviewed-by: dsamersoff

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
+ test/hotspot/jtreg/compiler/intrinsics/Test8215792.java

Changeset: 82fd8793ba5e
Author:    dpochepk
Date:      2019-05-22 20:39 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/82fd8793ba5e

8218966: AArch64: String.compareTo() can read memory after string
Reviewed-by: dsamersoff

! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
+ test/hotspot/jtreg/compiler/intrinsics/string/TestStringCompareToDifferentLength.java
+ test/hotspot/jtreg/compiler/intrinsics/string/TestStringCompareToSameLength.java

Changeset: 4cc9109caffd
Author:    mseledtsov
Date:      2019-05-22 10:51 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4cc9109caffd

8224529: [TESTBUG] JFR TestShenandoahHeapRegion* tests fail on build w/o Shenandoah
Summary: Fixed at-requires statement, updated TEST.ROOT
Reviewed-by: clanger, egahlin

! test/jdk/TEST.ROOT
! test/jdk/jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionInformationEvent.java
! test/jdk/jdk/jfr/event/gc/detailed/TestShenandoahHeapRegionStateChangeEvent.java

Changeset: 65b0b63d7f14
Author:    dchuyko
Date:      2019-05-22 21:33 +0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/65b0b63d7f14

8220072: GCC 8.3 reports errors in java.base
Reviewed-by: rriggs

! src/java.base/unix/native/libjava/canonicalize_md.c

Changeset: faf89c9568bd
Author:    aoqi
Date:      2019-05-23 00:21 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/faf89c9568bd

8224568: minimal and zero build fails after JDK-8213084
Reviewed-by: shade, lucy
Contributed-by: Ao Qi <aoqi at loongson.cn>

! src/hotspot/share/compiler/abstractDisassembler.cpp
! src/hotspot/share/compiler/disassembler.cpp

Changeset: 181986c54764
Author:    shade
Date:      2019-05-22 21:40 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/181986c54764

8224522: Shenandoah should apply barriers on deoptimization
Reviewed-by: rkennke, zgu

! src/hotspot/share/runtime/stackValue.cpp

Changeset: 3081932e7efd
Author:    valeriep
Date:      2019-05-22 21:38 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3081932e7efd

7107615: scalability bloker in javax.crypto.JceSecurity
Summary: Change to use ConcurrentHashMap instead of syncing on whole method
Reviewed-by: xuelei, alanb, dfuchs

! src/java.base/share/classes/javax/crypto/JceSecurity.java.template

Changeset: a573f58bc798
Author:    aeubanks
Date:      2019-05-20 16:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a573f58bc798

8224256: test/jdk/java/security/SecureClassLoader/DefineClass.java hardcodes 127.0.0.1
Reviewed-by: chegar, dfuchs, mullan
Contributed-by: aeubanks at google.com

! test/jdk/java/security/SecureClassLoader/DefineClass.java
! test/jdk/java/security/SecureClassLoader/DefineClass.policy

Changeset: dc343eb0fcf0
Author:    jwilhelm
Date:      2019-05-23 02:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dc343eb0fcf0

Added tag jdk-13+22 for changeset 181986c54764

! .hgtags

Changeset: 98ed47cd114a
Author:    dholmes
Date:      2019-05-22 21:50 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/98ed47cd114a

8224087: Compile C code for at least C99 Standard compliance
Reviewed-by: simonis, aph, erikj, serb, stuefe

! doc/building.html
! doc/building.md
! make/autoconf/flags-cflags.m4
! make/lib/Awt2dLibraries.gmk

Changeset: f11f2a4210b5
Author:    henryjen
Date:      2019-05-22 21:45 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f11f2a4210b5

8215156: Deprecate the -Xfuture option
Reviewed-by: dholmes

! src/hotspot/share/Xusage.txt
! src/java.base/share/classes/sun/launcher/resources/launcher.properties
! src/java.base/share/man/java.1
! src/java.base/share/native/libjli/emessages.h
! src/java.base/share/native/libjli/java.c

Changeset: 7dd0430a6997
Author:    darcy
Date:      2019-05-22 21:49 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7dd0430a6997

8224628: Note that type parameters are not visited by ElementScanners
Reviewed-by: jjg

! src/java.compiler/share/classes/javax/lang/model/util/ElementScanner6.java

Changeset: da9840e2f7da
Author:    pliden
Date:      2019-05-23 08:09 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/da9840e2f7da

8224185: ZGC: Introduce "High Usage" rule
Reviewed-by: eosterlund

! src/hotspot/share/gc/shared/gcCause.cpp
! src/hotspot/share/gc/shared/gcCause.hpp
! src/hotspot/share/gc/z/zDirector.cpp
! src/hotspot/share/gc/z/zDirector.hpp
! src/hotspot/share/gc/z/zDriver.cpp
+ test/hotspot/jtreg/gc/z/TestHighUsage.java

Changeset: bec1bb783c7e
Author:    thartmann
Date:      2019-05-23 08:57 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bec1bb783c7e

8224539: C2 compilation fails during ArrayCopyNode optimizations with assert(i < _max) failed: oob: i=1, _max=1
Summary: Bail out if src_offset or dst_offset is top.
Reviewed-by: roland, vlivanov, kvn

! src/hotspot/share/opto/arraycopynode.cpp
+ test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java

Changeset: 4645b6d57f54
Author:    thartmann
Date:      2019-05-23 09:46 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4645b6d57f54

8223581: C2 compilation failed with assert(!q->is_MergeMem())
Summary: Aggressively remove MergeMems feeding into other MergeMems during incremental inlining.
Reviewed-by: vlivanov

! src/hotspot/share/opto/graphKit.cpp

Changeset: 9b70ebd131b4
Author:    rehn
Date:      2019-05-23 10:13 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9b70ebd131b4

8221734: Deoptimize with handshakes
Reviewed-by: dcubed, dholmes, pchilanomate, dlong, coleenp

! src/hotspot/share/aot/aotCodeHeap.cpp
! src/hotspot/share/aot/aotCompiledMethod.cpp
! src/hotspot/share/aot/aotCompiledMethod.hpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/compiledMethod.hpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/code/nmethod.hpp
! src/hotspot/share/gc/z/zBarrierSetNMethod.cpp
! src/hotspot/share/gc/z/zNMethod.cpp
! src/hotspot/share/jvmci/jvmciEnv.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/method.hpp
! src/hotspot/share/prims/jvmtiEventController.cpp
! src/hotspot/share/prims/methodHandles.cpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/biasedLocking.cpp
! src/hotspot/share/runtime/biasedLocking.hpp
! src/hotspot/share/runtime/deoptimization.cpp
! src/hotspot/share/runtime/deoptimization.hpp
! src/hotspot/share/runtime/mutex.hpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/mutexLocker.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/vmOperations.cpp
! src/hotspot/share/runtime/vmOperations.hpp
! src/hotspot/share/services/dtraceAttacher.cpp
+ test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java

Changeset: 377bba651f4e
Author:    rkennke
Date:      2019-05-23 12:12 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/377bba651f4e

8224626: Shenandoah: Elide barriers on uncommon traps
Reviewed-by: roland, shade

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Changeset: 617e7f0e370d
Author:    dfuchs
Date:      2019-05-23 11:36 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/617e7f0e370d

8224656: Problem list java/security/SecureClassLoader/DefineClass.java until JDK-8224635 is fixed
Summary: the test failed consistently on windows and linux, and intermittently (but rarely) on solaris.  This patch problem-list it on all platform.
Reviewed-by: dholmes, chegar, alanb

! test/jdk/ProblemList.txt

Changeset: 6977eb6a4b61
Author:    erikj
Date:      2019-05-23 08:57 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6977eb6a4b61

8221543: Indify-dependent microbenchmarks are broken
Reviewed-by: redestad

! make/test/BuildMicrobenchmark.gmk

Changeset: cdb107ca16e6
Author:    redestad
Date:      2019-05-23 18:43 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cdb107ca16e6

8224202: Speed up Properties.load
Reviewed-by: rriggs, igerasim

! src/java.base/share/classes/java/util/Properties.java

Changeset: 8559810c60f8
Author:    aeubanks
Date:      2019-05-23 09:03 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8559810c60f8

8224635: Revert 8224256 and add back java/security/SecureClassLoader/DefineClass.java test
Reviewed-by: mullan
Contributed-by: aeubanks at google.com

! test/jdk/ProblemList.txt
! test/jdk/java/security/SecureClassLoader/DefineClass.java
! test/jdk/java/security/SecureClassLoader/DefineClass.policy

Changeset: 2218f9d57d2f
Author:    ccheung
Date:      2019-05-23 10:05 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2218f9d57d2f

8224264: [TESTBUG] HelloDynamicCustom.java test failed on the Windows platform in tiers 6 and 7 testing
Summary: Making use of the DynamicArchiveTestBase class so that mapping failure can be handled more robustly.
Reviewed-by: iklam

! test/hotspot/jtreg/runtime/appcds/dynamicArchive/HelloDynamicCustom.java

Changeset: fb0cfce19262
Author:    mseledtsov
Date:      2019-05-23 11:37 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fb0cfce19262

8224165: [TESTBUG] Docker tests produce excessive output
Summary: Trimmed child process output, saving child stdout to file
Reviewed-by: dholmes, lmesnik

! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java

Changeset: 8dae495a59e7
Author:    naoto
Date:      2019-05-23 12:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8dae495a59e7

8221431: Support for Unicode 12.1
Reviewed-by: erikj, rriggs

! make/CompileJavaModules.gmk
! make/ToolsJdk.gmk
! make/data/characterdata/CharacterData00.java.template
! make/data/characterdata/CharacterData01.java.template
+ make/data/unicodedata/Blocks.txt
+ make/data/unicodedata/NormalizationTest.txt
! make/data/unicodedata/PropList.txt
+ make/data/unicodedata/PropertyValueAliases.txt
! make/data/unicodedata/Scripts.txt
! make/data/unicodedata/SpecialCasing.txt
! make/data/unicodedata/UnicodeData.txt
! make/data/unicodedata/VERSION
+ make/data/unicodedata/auxiliary/GraphemeBreakProperty.txt
+ make/data/unicodedata/auxiliary/GraphemeBreakTest.txt
+ make/data/unicodedata/emoji-data.txt
! make/gensrc/Gensrc-java.base.gmk
+ make/gensrc/GensrcEmojiData.gmk
+ make/jdk/src/classes/build/tools/generateemojidata/GenerateEmojiData.java
! src/java.base/share/classes/java/lang/Character.java
+ src/java.base/share/classes/java/util/regex/EmojiData.java.template
! src/java.base/share/classes/java/util/regex/Grapheme.java
! src/java.base/share/classes/java/util/regex/Pattern.java
+ src/java.base/share/classes/sun/text/normalizer/CodePointMap.java
+ src/java.base/share/classes/sun/text/normalizer/CodePointTrie.java
! src/java.base/share/classes/sun/text/normalizer/ICUBinary.java
! src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java
! src/java.base/share/classes/sun/text/normalizer/NormalizerImpl.java
- src/java.base/share/classes/sun/text/resources/nfc.icu
+ src/java.base/share/classes/sun/text/resources/nfc.nrm
- src/java.base/share/classes/sun/text/resources/nfkc.icu
+ src/java.base/share/classes/sun/text/resources/nfkc.nrm
- src/java.base/share/classes/sun/text/resources/nfkc_cf.icu
! src/java.base/share/classes/sun/text/resources/ubidi.icu
! src/java.base/share/classes/sun/text/resources/uprops.icu
! src/java.base/share/legal/icu.md
! src/java.base/share/legal/unicode.md
! test/jdk/java/lang/Character/CharPropTest.java
! test/jdk/java/lang/Character/CheckProp.java
! test/jdk/java/lang/Character/CheckScript.java
! test/jdk/java/lang/Character/CheckUnicode.java
- test/jdk/java/lang/Character/PropList.txt
- test/jdk/java/lang/Character/PropertyValueAliases.txt
- test/jdk/java/lang/Character/Scripts.txt
- test/jdk/java/lang/Character/SpecialCasing.txt
- test/jdk/java/lang/Character/UnicodeBlock/Blocks.txt
! test/jdk/java/lang/Character/UnicodeBlock/CheckBlocks.java
! test/jdk/java/lang/Character/UnicodeBlock/OptimalMapSize.java
! test/jdk/java/lang/Character/UnicodeCasingTest.java
- test/jdk/java/lang/Character/UnicodeData.txt
- test/jdk/java/lang/Character/charprop00.bin
- test/jdk/java/lang/Character/charprop01.bin
- test/jdk/java/lang/Character/charprop02.bin
- test/jdk/java/lang/Character/charprop03.bin
- test/jdk/java/lang/Character/charprop0E.bin
- test/jdk/java/lang/Character/charprop0F.bin
- test/jdk/java/lang/Character/charprop10.bin
! test/jdk/java/lang/String/SpecialCasingTest.java
! test/jdk/java/lang/String/UnicodeCasingTest.java
+ test/jdk/java/text/Normalizer/ConformanceTest.java
+ test/jdk/java/text/Normalizer/DataValidationTest.java
+ test/jdk/java/text/Normalizer/ICUBasicTest.java
+ test/jdk/java/text/Normalizer/ICUNormalizationTest.txt
+ test/jdk/java/text/Normalizer/NormalizationTest-3.2.0.Corrigendum4.txt
+ test/jdk/java/text/Normalizer/NormalizationTest-3.2.0.txt
+ test/jdk/java/text/Normalizer/SquareEraCharacterTest.java
- test/jdk/java/util/regex/GraphemeBreakProperty.txt
- test/jdk/java/util/regex/GraphemeBreakTest.txt
! test/jdk/java/util/regex/GraphemeTest.java
! test/jdk/java/util/regex/RegExTest.java
+ test/jdk/lib/testlibrary/java/lang/UCDFiles.java

Changeset: 8b43726c1a47
Author:    iklam
Date:      2019-05-23 12:57 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/8b43726c1a47

8224689: ProblemList runtime/appcds/SharedArchiveConsistency.java
Reviewed-by: ccheung, dcubed

! test/hotspot/jtreg/ProblemList.txt

Changeset: 738285c4d1e1
Author:    rkennke
Date:      2019-05-23 17:01 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/738285c4d1e1

8224667: Shenandoah: Post-LRB cleanup
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

Changeset: 4f98fcd1bf16
Author:    igerasim
Date:      2019-05-23 13:48 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4f98fcd1bf16

7061590: Javadoc issues in Charset and StandardCharsets
Reviewed-by: alanb, jjg

! src/java.base/share/classes/java/nio/charset/Charset.java
! src/java.base/share/classes/java/nio/charset/StandardCharsets.java

Changeset: 5dc15cb1405c
Author:    erikj
Date:      2019-05-23 14:13 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/5dc15cb1405c

8224677: Dtrace .d files clash with make dependency .d files
Reviewed-by: tbell

! make/hotspot/lib/JvmDtraceObjects.gmk

Changeset: ecb7b9a98f0e
Author:    erikj
Date:      2019-05-23 14:14 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ecb7b9a98f0e

8224145: Build compare script fails intermittently on test image native libraries
Reviewed-by: tbell

! make/scripts/compare.sh
! make/scripts/compare_exceptions.sh.incl

Changeset: c55404ed4bd9
Author:    jwilhelm
Date:      2019-05-24 03:17 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c55404ed4bd9

8224715: ProblemList compiler/graalunit/HotspotJdk9Test.java
Reviewed-by: mikael

! test/hotspot/jtreg/ProblemList-graal.txt

Changeset: 2bcb825c8edf
Author:    mseledtsov
Date:      2019-05-23 18:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2bcb825c8edf

8224706: [TESTBUG] problem list failing JDK docker API tests
Summary: Put the failing tests on a problem list
Reviewed-by: lmesnik

! test/jdk/ProblemList.txt

Changeset: d84176dd57b0
Author:    darcy
Date:      2019-05-23 18:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d84176dd57b0

8224177: Harden annotation processing framework to irregular behavior from processors
Reviewed-by: jjg

! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/langtools/tools/javac/diags/examples/DuplicateSupportedInfoFromProc/DuplicateSupportedInfoFromProc.java
+ test/langtools/tools/javac/diags/examples/DuplicateSupportedInfoFromProc/processors/AnnoProc.java
! test/langtools/tools/javac/diags/examples/MalformedSupported/MalformedSupported.java
+ test/langtools/tools/javac/diags/examples/RedundantTypesWithWildcardProc/RedundantTypesWithWildcardProc.java
+ test/langtools/tools/javac/diags/examples/RedundantTypesWithWildcardProc/processors/AnnoProc.java
+ test/langtools/tools/javac/processing/warnings/TestRepeatedItemsRuntime.java
+ test/langtools/tools/javac/processing/warnings/auric_current.out

Changeset: 9785b9fb328e
Author:    clanger
Date:      2019-05-24 07:56 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/9785b9fb328e

8223553: Fix code constructs that do not compile with the Eclipse Java Compiler
Reviewed-by: smarks, dfuchs

! src/java.base/share/classes/java/lang/invoke/MethodHandles.java
! src/java.management/share/classes/java/lang/management/ManagementFactory.java
! src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java

Changeset: d56d8e40b6cd
Author:    stuefe
Date:      2019-05-24 09:02 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d56d8e40b6cd

8220394: bufferedStream does not honor size limit
Reviewed-by: dholmes, clanger

! src/hotspot/share/utilities/ostream.cpp
! src/hotspot/share/utilities/ostream.hpp
! test/hotspot/gtest/utilities/test_ostream.cpp

Changeset: 948385f851f2
Author:    lucy
Date:      2019-05-23 18:50 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/948385f851f2

8224652: 32-bit build failures after JDK-8213084
Reviewed-by: thartmann, shade
Contributed-by: shade at redhat.com

! src/hotspot/share/compiler/abstractDisassembler.cpp
! src/hotspot/share/utilities/globalDefinitions.hpp

Changeset: e93621d4db2c
Author:    thartmann
Date:      2019-05-24 09:51 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e93621d4db2c

8224723: [TESTBUG] compiler/arraycopy/TestArrayCopyWithBadOffset.java failed
Summary: Added missing -XX:+IgnoreUnrecognizedVMOptions
Reviewed-by: thartmann
Contributed-by: wangxue at loongson.cn

! test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyWithBadOffset.java

Changeset: a8673ccddffd
Author:    dkejriwal
Date:      2019-05-23 12:36 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a8673ccddffd

8214563: Use {@systemProperty} in specification of system properties in java.nio packages
8214565: Use {@systemProperty} for definitions of system properties
Reviewed-by: alanb, rriggs

! src/java.base/share/classes/java/io/FilePermission.java
! src/java.base/share/classes/java/io/ObjectInputFilter.java
! src/java.base/share/classes/java/nio/channels/AsynchronousChannelGroup.java
! src/java.base/share/classes/java/nio/channels/spi/AsynchronousChannelProvider.java
! src/java.base/share/classes/java/nio/channels/spi/SelectorProvider.java
! src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java

Changeset: adb2493b120e
Author:    jlahoda
Date:      2019-05-24 12:25 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/adb2493b120e

8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH
Summary: Allow --add-modules ALL-MODULE-PATH when compiling in the context of an automatic module.
Reviewed-by: jjg

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/langtools/tools/javac/modules/AutomaticModules.java

Changeset: da5435d9a801
Author:    zgu
Date:      2019-05-24 09:23 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/da5435d9a801

8224679: Shenandoah: Make ShenandoahParallelCodeCacheIterator noncopyable
Reviewed-by: rkennke, shade

! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp

Changeset: fc66237d5eae
Author:    zgu
Date:      2019-05-22 21:24 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fc66237d5eae

8224115: Shenandoah: Eliminate RWLock that protects recorded nmethod data array
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp

Changeset: 703b2c04fc2c
Author:    lucy
Date:      2019-05-24 15:36 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/703b2c04fc2c

8224742: JLONG_FORMAT_W incompatible with type jlong
Reviewed-by: thartmann, clanger

! src/hotspot/share/utilities/globalDefinitions_gcc.hpp

Changeset: 37a077319427
Author:    dfuchs
Date:      2019-05-24 15:34 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/37a077319427

8224603: Replace wildcard address with loopback or local host in tests - part 11
Summary: Fixes a batch of tests that were observed failing intermittently.
Reviewed-by: chegar, vtewari

! test/jdk/com/sun/net/httpserver/SelCacheTest.java
! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java
! test/jdk/java/net/Authenticator/B4722333.java
! test/jdk/java/net/DatagramSocket/Send12k.java
! test/jdk/java/net/Socket/CloseAvailable.java
! test/jdk/java/net/Socket/setReuseAddress/Restart.java
! test/jdk/java/net/Socks/BadProxySelector.java
! test/jdk/java/net/Socks/SocksProxyVersion.java
! test/jdk/java/net/URLPermission/URLTest.java
! test/jdk/sun/net/www/http/ChunkedOutputStream/CheckError.java
! test/jdk/sun/net/www/httptest/TestHttpServer.java
! test/jdk/sun/net/www/protocol/https/ChunkedOutputStream.java
! test/jdk/sun/net/www/protocol/https/TestHttpsServer.java

Changeset: 11d9cd8d99f3
Author:    dl
Date:      2019-05-24 08:39 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/11d9cd8d99f3

8224698: ConcurrentSkipListMap.java does not compile with the Eclipse Java Compiler
Reviewed-by: martin, clanger, smarks, dfuchs

! src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java

Changeset: c72451a9f67e
Author:    dl
Date:      2019-05-24 08:43 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c72451a9f67e

8224176: Fix inconsistencies in @jls tags in java.util.concurrent
Reviewed-by: martin, darcy, jjg

! src/java.base/share/classes/java/util/concurrent/atomic/AtomicInteger.java
! src/java.base/share/classes/java/util/concurrent/atomic/AtomicLong.java

Changeset: f46be958c4ac
Author:    dl
Date:      2019-05-24 08:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f46be958c4ac

8224024: java/util/concurrent/BlockingQueue/DrainToFails.java testBounded fails intermittently
Reviewed-by: martin

! test/jdk/java/util/concurrent/BlockingQueue/DrainToFails.java

Changeset: 3a30c73838f6
Author:    dl
Date:      2019-05-24 08:51 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a30c73838f6

8220478: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out intermittently
8223379: Clarify ForkJoinPool.getStealCount() javadoc
Reviewed-by: martin

! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java

Changeset: 265b110fc022
Author:    dl
Date:      2019-05-24 08:55 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/265b110fc022

8223245: Miscellaneous changes imported from jsr166 CVS 2019-06
Reviewed-by: martin

! src/java.base/share/classes/java/util/ArrayList.java
! src/java.base/share/classes/java/util/Vector.java

Changeset: 290679ec47bb
Author:    rhalade
Date:      2019-05-24 09:47 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/290679ec47bb

8202651: Test ComodoCA.java fails
Reviewed-by: mullan

! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java

Changeset: 4ccc8d8bc02b
Author:    joehw
Date:      2019-05-24 10:28 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4ccc8d8bc02b

8223658: Performance regression of XML.validation in 13-b19
Reviewed-by: lancea

! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java

Changeset: 4947a097db60
Author:    lancea
Date:      2019-05-24 15:06 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4947a097db60

8224682: Remove the com.sun.CORBA.ORBIorTypeCheckRegistryFilter security property
Reviewed-by: bchristi

! src/java.base/share/conf/security/java.security
! test/lib/jdk/test/lib/security/JDKSecurityProperties.java

Changeset: 0627b8ad33c1
Author:    weijun
Date:      2019-05-25 08:30 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0627b8ad33c1

6682540: Incorrect SASL DIGEST-MD5 behavior
Reviewed-by: jnimeh

! src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Server.java
+ test/jdk/com/sun/security/sasl/digest/HasInitialResponse.java

Changeset: 18f94e911c55
Author:    sspitsyn
Date:      2019-05-24 21:05 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/18f94e911c55

8046018: JVMTI Spec: can_redefine_any_class capability spec is inconsistent
Summary: Make the "can_redefine_any_class" capability spec clear and consistent
Reviewed-by: alanb, cjplummer, dholmes, dcubed, jcbeyler

! src/hotspot/share/prims/jvmti.xml

Changeset: 6264783438f6
Author:    clanger
Date:      2019-05-25 10:54 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6264783438f6

8224727: Problem list test security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java
Reviewed-by: rhalade

! test/jdk/ProblemList.txt

Changeset: d871ce8ab96b
Author:    ysuenaga
Date:      2019-05-25 20:55 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d871ce8ab96b

8224252: [TESTBUG] hotspot/test/serviceability/sa/sadebugd/SADebugDTest.java is timing out again after fix for JDK-8163805
Reviewed-by: cjplummer, sspitsyn

! test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java

Changeset: d3afe760b392
Author:    mbaesken
Date:      2019-05-23 15:15 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d3afe760b392

8224221: add memprotect calls to event log
Reviewed-by: dholmes, mdoerr

! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/solaris/os_solaris.cpp
! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/utilities/events.hpp

Changeset: 3a8433d967ea
Author:    aefimov
Date:      2019-05-27 13:29 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3a8433d967ea

8224035: Replace wildcard address with loopback or local host in tests - part 9
Reviewed-by: dfuchs

! test/jdk/java/net/ServerSocket/ThreadStop.java
! test/jdk/java/net/Socket/asyncClose/Race.java
! test/jdk/java/net/URLClassLoader/HttpTest.java
! test/jdk/java/net/URLConnection/TimeoutTest.java
! test/jdk/sun/net/www/http/HttpClient/CookieHttpClientTest.java
! test/jdk/sun/net/www/protocol/http/HttpInputStream.java
! test/jdk/sun/net/www/protocol/http/HttpStreams.java
! test/jdk/sun/net/www/protocol/http/RedirectOnPost.java
! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java
! test/jdk/sun/net/www/protocol/http/SetIfModifiedSince.java

Changeset: 7f03c3e42628
Author:    rkennke
Date:      2019-05-27 14:57 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/7f03c3e42628

8224836: Backout: JDK-8224626: Shenandoah: Elide barriers on uncommon traps
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Changeset: 3131927311ee
Author:    dfuchs
Date:      2019-05-27 19:24 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/3131927311ee

8224761: Replace wildcard address with loopback or local host in tests - part 12
Summary: fixes a batch of intermittent failures.
Reviewed-by: chegar, vtewari

! test/jdk/com/sun/net/httpserver/Test6a.java
! test/jdk/java/net/MulticastSocket/UnreferencedMulticastSockets.java
! test/jdk/java/net/ProxySelector/ProxyTest.java
! test/jdk/java/net/ResponseCache/Test.java
! test/jdk/java/net/URLConnection/ZeroContentLength.java
! test/jdk/sun/net/www/http/HttpClient/B6726695.java
! test/jdk/sun/net/www/http/KeepAliveStream/InfiniteLoop.java
! test/jdk/sun/net/www/protocol/http/HttpOnly.java
! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/HttpsCreateSockTest.java
! test/lib/jdk/test/lib/NetworkConfiguration.java

Changeset: 812212323fb1
Author:    zgu
Date:      2019-05-27 14:34 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/812212323fb1

8224751: Shenandoah: Shenandoah Verifier should select proper roots according to current GC cycle
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp
! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: 4853b1ceb3d6
Author:    iignatyev
Date:      2019-05-27 19:46 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4853b1ceb3d6

8222414: bring googlemock v1.8.1
Reviewed-by: erikj, rwestberg

! make/hotspot/lib/CompileGtest.gmk
- test/fmw/gtest/CHANGES
- test/fmw/gtest/CONTRIBUTORS
- test/fmw/gtest/LICENSE
- test/fmw/gtest/README.md
+ test/fmw/gtest/googlemock/CHANGES
+ test/fmw/gtest/googlemock/CONTRIBUTORS
+ test/fmw/gtest/googlemock/LICENSE
+ test/fmw/gtest/googlemock/README.md
+ test/fmw/gtest/googlemock/include/gmock/gmock-actions.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-cardinalities.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-actions.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-actions.h.pump
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-function-mockers.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-function-mockers.h.pump
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-matchers.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-matchers.h.pump
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-nice-strict.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-generated-nice-strict.h.pump
+ test/fmw/gtest/googlemock/include/gmock/gmock-matchers.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-more-actions.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-more-matchers.h
+ test/fmw/gtest/googlemock/include/gmock/gmock-spec-builders.h
+ test/fmw/gtest/googlemock/include/gmock/gmock.h
+ test/fmw/gtest/googlemock/include/gmock/internal/custom/README.md
+ test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-generated-actions.h
+ test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-generated-actions.h.pump
+ test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-matchers.h
+ test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-port.h
+ test/fmw/gtest/googlemock/include/gmock/internal/gmock-generated-internal-utils.h
+ test/fmw/gtest/googlemock/include/gmock/internal/gmock-generated-internal-utils.h.pump
+ test/fmw/gtest/googlemock/include/gmock/internal/gmock-internal-utils.h
+ test/fmw/gtest/googlemock/include/gmock/internal/gmock-port.h
+ test/fmw/gtest/googlemock/src/gmock-all.cc
+ test/fmw/gtest/googlemock/src/gmock-cardinalities.cc
+ test/fmw/gtest/googlemock/src/gmock-internal-utils.cc
+ test/fmw/gtest/googlemock/src/gmock-matchers.cc
+ test/fmw/gtest/googlemock/src/gmock-spec-builders.cc
+ test/fmw/gtest/googlemock/src/gmock.cc
+ test/fmw/gtest/googlemock/src/gmock_main.cc
+ test/fmw/gtest/googletest/CHANGES
+ test/fmw/gtest/googletest/CONTRIBUTORS
+ test/fmw/gtest/googletest/LICENSE
+ test/fmw/gtest/googletest/README.md
+ test/fmw/gtest/googletest/include/gtest/gtest-death-test.h
+ test/fmw/gtest/googletest/include/gtest/gtest-message.h
+ test/fmw/gtest/googletest/include/gtest/gtest-param-test.h
+ test/fmw/gtest/googletest/include/gtest/gtest-param-test.h.pump
+ test/fmw/gtest/googletest/include/gtest/gtest-printers.h
+ test/fmw/gtest/googletest/include/gtest/gtest-spi.h
+ test/fmw/gtest/googletest/include/gtest/gtest-test-part.h
+ test/fmw/gtest/googletest/include/gtest/gtest-typed-test.h
+ test/fmw/gtest/googletest/include/gtest/gtest.h
+ test/fmw/gtest/googletest/include/gtest/gtest_pred_impl.h
+ test/fmw/gtest/googletest/include/gtest/gtest_prod.h
+ test/fmw/gtest/googletest/include/gtest/internal/custom/README.md
+ test/fmw/gtest/googletest/include/gtest/internal/custom/gtest-port.h
+ test/fmw/gtest/googletest/include/gtest/internal/custom/gtest-printers.h
+ test/fmw/gtest/googletest/include/gtest/internal/custom/gtest.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-death-test-internal.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-filepath.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-internal.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-linked_ptr.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util-generated.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util-generated.h.pump
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-port-arch.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-port.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-string.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-tuple.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-tuple.h.pump
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-type-util.h
+ test/fmw/gtest/googletest/include/gtest/internal/gtest-type-util.h.pump
+ test/fmw/gtest/googletest/src/gtest-all.cc
+ test/fmw/gtest/googletest/src/gtest-death-test.cc
+ test/fmw/gtest/googletest/src/gtest-filepath.cc
+ test/fmw/gtest/googletest/src/gtest-internal-inl.h
+ test/fmw/gtest/googletest/src/gtest-port.cc
+ test/fmw/gtest/googletest/src/gtest-printers.cc
+ test/fmw/gtest/googletest/src/gtest-test-part.cc
+ test/fmw/gtest/googletest/src/gtest-typed-test.cc
+ test/fmw/gtest/googletest/src/gtest.cc
+ test/fmw/gtest/googletest/src/gtest_main.cc
- test/fmw/gtest/include/gtest/gtest-death-test.h
- test/fmw/gtest/include/gtest/gtest-message.h
- test/fmw/gtest/include/gtest/gtest-param-test.h
- test/fmw/gtest/include/gtest/gtest-param-test.h.pump
- test/fmw/gtest/include/gtest/gtest-printers.h
- test/fmw/gtest/include/gtest/gtest-spi.h
- test/fmw/gtest/include/gtest/gtest-test-part.h
- test/fmw/gtest/include/gtest/gtest-typed-test.h
- test/fmw/gtest/include/gtest/gtest.h
- test/fmw/gtest/include/gtest/gtest_pred_impl.h
- test/fmw/gtest/include/gtest/gtest_prod.h
- test/fmw/gtest/include/gtest/internal/custom/README.md
- test/fmw/gtest/include/gtest/internal/custom/gtest-port.h
- test/fmw/gtest/include/gtest/internal/custom/gtest-printers.h
- test/fmw/gtest/include/gtest/internal/custom/gtest.h
- test/fmw/gtest/include/gtest/internal/gtest-death-test-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-filepath.h
- test/fmw/gtest/include/gtest/internal/gtest-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-linked_ptr.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-param-util.h
- test/fmw/gtest/include/gtest/internal/gtest-port-arch.h
- test/fmw/gtest/include/gtest/internal/gtest-port.h
- test/fmw/gtest/include/gtest/internal/gtest-string.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h.pump
- test/fmw/gtest/src/gtest-all.cc
- test/fmw/gtest/src/gtest-death-test.cc
- test/fmw/gtest/src/gtest-filepath.cc
- test/fmw/gtest/src/gtest-internal-inl.h
- test/fmw/gtest/src/gtest-port.cc
- test/fmw/gtest/src/gtest-printers.cc
- test/fmw/gtest/src/gtest-test-part.cc
- test/fmw/gtest/src/gtest-typed-test.cc
- test/fmw/gtest/src/gtest.cc
- test/fmw/gtest/src/gtest_main.cc
! test/hotspot/gtest/gtestMain.cpp
! test/hotspot/gtest/unittest.hpp

Changeset: feba48c5dfb4
Author:    rraghavan
Date:      2019-05-28 12:01 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/feba48c5dfb4

8213416: Replace some enums with static const members in hotspot/compiler
Summary: Changes to fix enumeral and non-enumeral type in conditional expression warnings with -Wextra for gcc on hotspot
Reviewed-by: kvn, thartmann

! src/hotspot/share/ci/ciReplay.cpp
! src/hotspot/share/opto/machnode.hpp
! src/hotspot/share/opto/node.hpp

Changeset: fb9758536458
Author:    lucy
Date:      2019-05-28 09:41 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/fb9758536458

8224672: (lib)hsdis-<arch>.so search incorrect after JDK-8213084
Reviewed-by: kvn, shade

! src/hotspot/share/compiler/disassembler.cpp

Changeset: 05a408cbd945
Author:    coleenp
Date:      2019-05-28 06:42 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/05a408cbd945

8220688: [TESTBUG] runtime/NMT/MallocStressTest.java timed out
Summary: reduce number of threads and iterate rather than sleep.
Reviewed-by: zgu, dholmes

! test/hotspot/jtreg/runtime/NMT/MallocStressTest.java

Changeset: d58e1a447d2b
Author:    mgronlun
Date:      2019-05-28 13:28 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d58e1a447d2b

8221121: applications/microbenchmarks are encountering crashes in tier5
Reviewed-by: egahlin, dholmes

! src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp
! src/hotspot/share/jfr/recorder/storage/jfrBuffer.hpp
! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp

Changeset: 78e49883146f
Author:    aph
Date:      2019-05-23 07:57 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/78e49883146f

8224671: AArch64: mauve System.arraycopy test failure
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/assembler_aarch64.hpp
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp

Changeset: 755f1c66a891
Author:    aph
Date:      2019-05-28 08:25 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/755f1c66a891

Merge

- src/hotspot/share/c1/c1_globals.cpp
- src/hotspot/share/opto/c2_globals.cpp
- src/java.base/share/classes/sun/text/resources/nfc.icu
- src/java.base/share/classes/sun/text/resources/nfkc.icu
- src/java.base/share/classes/sun/text/resources/nfkc_cf.icu
- test/fmw/gtest/CHANGES
- test/fmw/gtest/CONTRIBUTORS
- test/fmw/gtest/LICENSE
- test/fmw/gtest/README.md
- test/fmw/gtest/include/gtest/gtest-death-test.h
- test/fmw/gtest/include/gtest/gtest-message.h
- test/fmw/gtest/include/gtest/gtest-param-test.h
- test/fmw/gtest/include/gtest/gtest-param-test.h.pump
- test/fmw/gtest/include/gtest/gtest-printers.h
- test/fmw/gtest/include/gtest/gtest-spi.h
- test/fmw/gtest/include/gtest/gtest-test-part.h
- test/fmw/gtest/include/gtest/gtest-typed-test.h
- test/fmw/gtest/include/gtest/gtest.h
- test/fmw/gtest/include/gtest/gtest_pred_impl.h
- test/fmw/gtest/include/gtest/gtest_prod.h
- test/fmw/gtest/include/gtest/internal/custom/README.md
- test/fmw/gtest/include/gtest/internal/custom/gtest-port.h
- test/fmw/gtest/include/gtest/internal/custom/gtest-printers.h
- test/fmw/gtest/include/gtest/internal/custom/gtest.h
- test/fmw/gtest/include/gtest/internal/gtest-death-test-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-filepath.h
- test/fmw/gtest/include/gtest/internal/gtest-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-linked_ptr.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-param-util.h
- test/fmw/gtest/include/gtest/internal/gtest-port-arch.h
- test/fmw/gtest/include/gtest/internal/gtest-port.h
- test/fmw/gtest/include/gtest/internal/gtest-string.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h.pump
- test/fmw/gtest/src/gtest-all.cc
- test/fmw/gtest/src/gtest-death-test.cc
- test/fmw/gtest/src/gtest-filepath.cc
- test/fmw/gtest/src/gtest-internal-inl.h
- test/fmw/gtest/src/gtest-port.cc
- test/fmw/gtest/src/gtest-printers.cc
- test/fmw/gtest/src/gtest-test-part.cc
- test/fmw/gtest/src/gtest-typed-test.cc
- test/fmw/gtest/src/gtest.cc
- test/fmw/gtest/src/gtest_main.cc
- test/jdk/java/lang/Character/PropList.txt
- test/jdk/java/lang/Character/PropertyValueAliases.txt
- test/jdk/java/lang/Character/Scripts.txt
- test/jdk/java/lang/Character/SpecialCasing.txt
- test/jdk/java/lang/Character/UnicodeBlock/Blocks.txt
- test/jdk/java/lang/Character/UnicodeData.txt
- test/jdk/java/lang/Character/charprop00.bin
- test/jdk/java/lang/Character/charprop01.bin
- test/jdk/java/lang/Character/charprop02.bin
- test/jdk/java/lang/Character/charprop03.bin
- test/jdk/java/lang/Character/charprop0E.bin
- test/jdk/java/lang/Character/charprop0F.bin
- test/jdk/java/lang/Character/charprop10.bin
- test/jdk/java/util/regex/GraphemeBreakProperty.txt
- test/jdk/java/util/regex/GraphemeBreakTest.txt
- test/jdk/sun/management/windows/revokeall.c
- test/jdk/sun/management/windows/revokeall.exe

Changeset: 146f257274c9
Author:    thartmann
Date:      2019-05-28 14:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/146f257274c9

8224870: Problemlist compiler/c2/Test8004741.java until JDK-8214904 is fixed
Summary: Added Test8004741 to problem list.
Reviewed-by: shade

! test/hotspot/jtreg/ProblemList.txt

Changeset: 63ab89cc3e69
Author:    sundar
Date:      2019-05-28 19:30 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/63ab89cc3e69

8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path
Reviewed-by: alanb, jlaskey

! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java
! test/jdk/jdk/internal/jrtfs/Basic.java
! test/langtools/tools/lib/toolbox/JarTask.java

Changeset: 30094911fffd
Author:    aph
Date:      2019-05-28 09:13 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/30094911fffd

8224880: AArch64: java/javac error with AllocatePrefetchDistance
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Changeset: 0422b4b5cb8e
Author:    aph
Date:      2019-05-28 10:20 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/0422b4b5cb8e

Merge


Changeset: b5ca5b98037b
Author:    ccheung
Date:      2019-05-28 09:40 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b5ca5b98037b

8224548: [TESTBUG] runtime/appcds/jvmti/ClassFileLoadHookTest.java failed: must be shared
Summary: improve the -Xshare:auto case
Reviewed-by: iklam, coleenp

! test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHook.java
! test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHookTest.java

Changeset: d1fa0f8d8c9a
Author:    vdeshpande
Date:      2019-05-28 09:56 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d1fa0f8d8c9a

8224558: Fix replicateB encoding
Reviewed-by: thartmann, vlivanov

! src/hotspot/cpu/x86/x86.ad

Changeset: 45128070fd15
Author:    darcy
Date:      2019-05-28 10:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/45128070fd15

8224783: Javadoc of String strip methods uses link where linkplain would be better
Reviewed-by: lancea, jlaskey

! src/java.base/share/classes/java/lang/String.java

Changeset: 51c699875f7c
Author:    coffeys
Date:      2019-05-28 19:19 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/51c699875f7c

8042904: apple.security.KeychainStore.getSalt() calling generateSeed()
Reviewed-by: jnimeh

! src/java.base/macosx/classes/apple/security/KeychainStore.java

Changeset: cb35ce1770a0
Author:    jjg
Date:      2019-05-28 11:21 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/cb35ce1770a0

8219147: Javadoc should expose covariant return type overrides
Reviewed-by: hannesw

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java
! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java
+ test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg6/Base.java
+ test/langtools/jdk/javadoc/doclet/testOverriddenMethods/pkg6/Sub.java

Changeset: 103f9068c39f
Author:    jjg
Date:      2019-05-28 11:22 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/103f9068c39f

Merge


Changeset: b9d1e2fbe51d
Author:    mullan
Date:      2019-05-28 14:28 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b9d1e2fbe51d

8224885: ProblemList sun/security/tools/keytool/KeyToolTest.java and WeakAlgTest.java on Solaris
Reviewed-by: xuelei

! test/jdk/ProblemList.txt

Changeset: 52a1bebd1355
Author:    mullan
Date:      2019-05-28 14:29 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/52a1bebd1355

Merge


Changeset: f6260463dbe4
Author:    rehn
Date:      2019-05-28 20:47 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f6260463dbe4

8224795: some runtime/SelectionResolution tests are timing out
Reviewed-by: dholmes, thartmann

! src/hotspot/share/code/nmethod.cpp

Changeset: 6e0786d8451b
Author:    shade
Date:      2019-05-28 21:31 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/6e0786d8451b

8224796: C code is not compiled correctly due to undefined "i386"
Reviewed-by: dholmes, mikael

! src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c
! src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c

Changeset: d850d0f41c72
Author:    jlaskey
Date:      2019-05-28 16:51 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d850d0f41c72

8224908: Revert: 8216553: JrtFileSystemProvider getPath(URI) omits /modules element from file path
Reviewed-by: darcy, kbarrett

! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java
! test/jdk/jdk/internal/jrtfs/Basic.java
! test/langtools/tools/lib/toolbox/JarTask.java

Changeset: 4e62485d2b18
Author:    rraghavan
Date:      2019-05-29 07:49 +0530
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/4e62485d2b18

8220449: serviceability/dcmd/compiler/CodelistTest.java failure
Summary: Added -XX:-BackgroundCompilation to test to eager initialize JVMCI
Reviewed-by: gadams, thartmann

! test/hotspot/jtreg/serviceability/dcmd/compiler/CodelistTest.java

Changeset: d0f73fccf5f3
Author:    mbalao
Date:      2019-05-28 19:01 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/d0f73fccf5f3

8223482: Unsupported ciphersuites may be offered by a TLS client
Reviewed-by: xuelei

! src/java.base/share/classes/sun/security/ssl/SSLCipher.java
! src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java
! test/jdk/sun/security/pkcs11/tls/tls12/FipsModeTLS12.java

Changeset: f4702c8c9b3f
Author:    ysuenaga
Date:      2019-05-29 13:50 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/f4702c8c9b3f

8223814: SA: jhsdb common help needs to be more detailed
Reviewed-by: dholmes, sspitsyn, ysuenaga
Contributed-by: Osamu Sakamoto <sakamoto.osamu at nttcom.co.jp>

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java

Changeset: ea1e4a818785
Author:    mbaesken
Date:      2019-05-24 14:32 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ea1e4a818785

8224750: Display thread once in Internal exceptions event log lines
Reviewed-by: mdoerr

! src/hotspot/share/utilities/events.cpp

Changeset: 044f2ca6ce22
Author:    stefank
Date:      2019-05-29 09:25 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/044f2ca6ce22

8223392: Add missing BitMap comments for JDK-8222986
Reviewed-by: tschatzl, pliden

! src/hotspot/share/utilities/bitMap.cpp
! src/hotspot/share/utilities/bitMap.hpp

Changeset: 785a12e0f89b
Author:    rkennke
Date:      2019-05-29 12:01 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/785a12e0f89b

8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland

! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

Changeset: 806b1c8e24b8
Author:    hannesw
Date:      2019-05-29 12:43 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/806b1c8e24b8

8222318: javadoc does not accept valid HTML5 entity names
Reviewed-by: jjg

! src/jdk.compiler/share/classes/com/sun/tools/doclint/Entity.java

Changeset: e63a624da347
Author:    mgronlun
Date:      2019-05-29 13:30 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/e63a624da347

8217089: JFR: Lazy install os interface components for improved startup
Reviewed-by: dholmes, egahlin

! src/hotspot/share/jfr/periodic/jfrOSInterface.cpp

Changeset: de371e2d1acc
Author:    roland
Date:      2019-05-22 10:11 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/de371e2d1acc

8224496: Shenandoah compilation fails with assert(is_CountedLoopEnd()) failed: invalid node class
Reviewed-by: rkennke

! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Changeset: ef713640430e
Author:    hseigel
Date:      2019-05-29 08:21 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/ef713640430e

8224763: Update man pages to show deprecation of -Xverify:none
Summary: Add the appropriate deprecation text
Reviewed-by: dholmes, lfoltan

! src/java.base/share/classes/sun/launcher/resources/launcher.properties
! src/java.base/share/man/java.1
! src/java.base/share/native/libjli/java.c

Changeset: dd321e3596c0
Author:    chegar
Date:      2019-05-29 13:58 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dd321e3596c0

8224477: java.net socket types new-style socket option methods - spec and impl mismatch
Reviewed-by: alanb

! src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java
! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java
! src/java.base/share/classes/java/net/DatagramSocket.java
! src/java.base/share/classes/java/net/DatagramSocketImpl.java
! src/java.base/share/classes/java/net/ServerSocket.java
! src/java.base/share/classes/java/net/Socket.java
! src/java.base/share/classes/java/net/SocketImpl.java
! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java
! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java
! src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java
! src/java.base/unix/classes/java/net/PlainSocketImpl.java
+ test/jdk/java/net/DatagramSocketImpl/TestDefaultBehavior.java
+ test/jdk/java/net/SocketImpl/TestDefaultBehavior.java
+ test/jdk/java/net/SocketOption/AfterClose.java
+ test/jdk/java/net/SocketOption/NullsAndBadValues.java
! test/jdk/java/net/SocketOption/OptionsTest.java
! test/jdk/java/net/SocketOption/UnsupportedOptionsTest.java

Changeset: 335f474becde
Author:    shade
Date:      2019-05-29 15:25 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/335f474becde

8224970: ShenandoahRootScanner::roots_do assert is too strong
Reviewed-by: zgu

! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp

Changeset: 2fc6027f0eed
Author:    zgu
Date:      2019-05-29 09:43 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/2fc6027f0eed

8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
- src/hotspot/share/gc/shenandoah/shenandoahHeapLock.hpp
+ src/hotspot/share/gc/shenandoah/shenandoahLock.hpp

Changeset: a8e2e273c943
Author:    hannesw
Date:      2019-05-29 15:52 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/a8e2e273c943

8224982: JDK-8222318 breaks tools/doclint/html/EntitiesTest.java
Reviewed-by: sundar

! src/jdk.compiler/share/classes/com/sun/tools/doclint/Entity.java

Changeset: bda9984d8ee4
Author:    xuelei
Date:      2019-05-29 06:56 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bda9984d8ee4

8224981: Problemlist test/jdk/sun/security/pkcs11/tls/tls12/FipsModeTLS12.java
Reviewed-by: mullan

! test/jdk/ProblemList.txt

Changeset: dcda4663a926
Author:    xuelei
Date:      2019-05-29 07:48 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/dcda4663a926

8224984: Problemlist javax/net/ssl/SSLSocket/Tls13PacketSize.java
Reviewed-by: mullan

! test/jdk/ProblemList.txt

Changeset: 82fe7292ca5c
Author:    gromero
Date:      2019-05-22 12:17 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/82fe7292ca5c

8223660: jtreg: Decouple Unsafe from RTM tests
Reviewed-by: mdoerr, shade

! test/hotspot/jtreg/compiler/rtm/locking/TestRTMAbortRatio.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMAbortThreshold.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMLockingCalculationDelay.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMLockingThreshold.java
! test/hotspot/jtreg/compiler/rtm/locking/TestRTMTotalCountIncrRate.java
! test/hotspot/jtreg/compiler/rtm/locking/TestUseRTMAfterLockInflation.java
! test/hotspot/jtreg/compiler/rtm/locking/TestUseRTMDeopt.java
! test/hotspot/jtreg/compiler/rtm/locking/TestUseRTMForInflatedLocks.java
! test/hotspot/jtreg/compiler/rtm/locking/TestUseRTMForStackLocks.java
! test/hotspot/jtreg/compiler/rtm/method_options/TestNoRTMLockElidingOption.java
! test/hotspot/jtreg/compiler/rtm/method_options/TestUseRTMLockElidingOption.java
! test/hotspot/jtreg/compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
! test/hotspot/jtreg/compiler/testlibrary/rtm/XAbortProvoker.java
+ test/hotspot/jtreg/compiler/testlibrary/rtm/libXAbortProvoker.c

Changeset: 69a35cd74f7d
Author:    weijun
Date:      2019-05-29 23:36 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/69a35cd74f7d

8223053: [xmldsig] Add KeyValue::EC_TYPE
Reviewed-by: mullan

! src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/keyinfo/KeyValue.java

Changeset: 934d68e9c45d
Author:    zgu
Date:      2019-05-29 10:57 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/934d68e9c45d

8224875: Shenandoah: ParallelCleaning code unloading should take lock to protect shared code roots array
Reviewed-by: shade

! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp

Changeset: c1ad2862d0dd
Author:    darcy
Date:      2019-05-29 09:53 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c1ad2862d0dd

8224012: AnnotatedType implementations of hashCode() lead to StackOverflowError
Reviewed-by: jfranck

! src/java.base/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java
! test/jdk/java/lang/annotation/typeAnnotations/TestObjectMethods.java

Changeset: c58772f2dbce
Author:    iignatyev
Date:      2019-05-29 11:54 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/c58772f2dbce

8224945: googlemock update breaks the build of arm32 and ppc
Reviewed-by: dholmes, simonis

! test/hotspot/gtest/unittest.hpp

Changeset: b034d2dee5fc
Author:    joehw
Date:      2019-05-29 11:58 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/b034d2dee5fc

8225005: Xerces 2.12.0: License file
Reviewed-by: lancea

! src/java.xml/share/legal/xerces.md

Changeset: bdc9eb30a3f2
Author:    shade
Date:      2019-05-30 11:49 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk/rev/bdc9eb30a3f2

Merge

! .hgtags
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp
! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp
! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/windows/os_windows.cpp
- src/hotspot/share/c1/c1_globals.cpp
! src/hotspot/share/code/codeCache.cpp
! src/hotspot/share/code/nmethod.cpp
! src/hotspot/share/compiler/compileBroker.cpp
! src/hotspot/share/compiler/oopMap.cpp
! src/hotspot/share/gc/shared/gcCause.cpp
! src/hotspot/share/gc/shared/gcCause.hpp
! src/hotspot/share/gc/shared/gcConfig.cpp
! src/hotspot/share/gc/shared/gc_globals.hpp
! src/hotspot/share/gc/shared/ptrQueue.cpp
! src/hotspot/share/gc/shared/ptrQueue.hpp
! src/hotspot/share/gc/shared/satbMarkQueue.cpp
! src/hotspot/share/gc/shared/satbMarkQueue.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp
! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp
! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp
! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.hpp
! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
- src/hotspot/share/gc/shenandoah/shenandoahHeapLock.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeuristics.cpp
+ src/hotspot/share/gc/shenandoah/shenandoahLock.hpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp
! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.hpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp
! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp
! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
! src/hotspot/share/opto/arraycopynode.cpp
- src/hotspot/share/opto/c2_globals.cpp
! src/hotspot/share/opto/compile.cpp
! src/hotspot/share/opto/compile.hpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/machnode.hpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/prims/whitebox.cpp
! src/hotspot/share/runtime/mutexLocker.cpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/runtime/tieredThresholdPolicy.cpp
! src/hotspot/share/runtime/vmOperations.hpp
! src/hotspot/share/runtime/vmStructs.cpp
! src/hotspot/share/utilities/bitMap.cpp
! src/hotspot/share/utilities/bitMap.hpp
! src/hotspot/share/utilities/globalDefinitions.hpp
- src/java.base/share/classes/sun/text/resources/nfc.icu
- src/java.base/share/classes/sun/text/resources/nfkc.icu
- src/java.base/share/classes/sun/text/resources/nfkc_cf.icu
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java
- test/fmw/gtest/CHANGES
- test/fmw/gtest/CONTRIBUTORS
- test/fmw/gtest/LICENSE
- test/fmw/gtest/README.md
- test/fmw/gtest/include/gtest/gtest-death-test.h
- test/fmw/gtest/include/gtest/gtest-message.h
- test/fmw/gtest/include/gtest/gtest-param-test.h
- test/fmw/gtest/include/gtest/gtest-param-test.h.pump
- test/fmw/gtest/include/gtest/gtest-printers.h
- test/fmw/gtest/include/gtest/gtest-spi.h
- test/fmw/gtest/include/gtest/gtest-test-part.h
- test/fmw/gtest/include/gtest/gtest-typed-test.h
- test/fmw/gtest/include/gtest/gtest.h
- test/fmw/gtest/include/gtest/gtest_pred_impl.h
- test/fmw/gtest/include/gtest/gtest_prod.h
- test/fmw/gtest/include/gtest/internal/custom/README.md
- test/fmw/gtest/include/gtest/internal/custom/gtest-port.h
- test/fmw/gtest/include/gtest/internal/custom/gtest-printers.h
- test/fmw/gtest/include/gtest/internal/custom/gtest.h
- test/fmw/gtest/include/gtest/internal/gtest-death-test-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-filepath.h
- test/fmw/gtest/include/gtest/internal/gtest-internal.h
- test/fmw/gtest/include/gtest/internal/gtest-linked_ptr.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h
- test/fmw/gtest/include/gtest/internal/gtest-param-util-generated.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-param-util.h
- test/fmw/gtest/include/gtest/internal/gtest-port-arch.h
- test/fmw/gtest/include/gtest/internal/gtest-port.h
- test/fmw/gtest/include/gtest/internal/gtest-string.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h
- test/fmw/gtest/include/gtest/internal/gtest-tuple.h.pump
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h
- test/fmw/gtest/include/gtest/internal/gtest-type-util.h.pump
- test/fmw/gtest/src/gtest-all.cc
- test/fmw/gtest/src/gtest-death-test.cc
- test/fmw/gtest/src/gtest-filepath.cc
- test/fmw/gtest/src/gtest-internal-inl.h
- test/fmw/gtest/src/gtest-port.cc
- test/fmw/gtest/src/gtest-printers.cc
- test/fmw/gtest/src/gtest-test-part.cc
- test/fmw/gtest/src/gtest-typed-test.cc
- test/fmw/gtest/src/gtest.cc
- test/fmw/gtest/src/gtest_main.cc
! test/hotspot/jtreg/ProblemList.txt
- test/jdk/java/lang/Character/PropList.txt
- test/jdk/java/lang/Character/PropertyValueAliases.txt
- test/jdk/java/lang/Character/Scripts.txt
- test/jdk/java/lang/Character/SpecialCasing.txt
- test/jdk/java/lang/Character/UnicodeBlock/Blocks.txt
- test/jdk/java/lang/Character/UnicodeData.txt
- test/jdk/java/lang/Character/charprop00.bin
- test/jdk/java/lang/Character/charprop01.bin
- test/jdk/java/lang/Character/charprop02.bin
- test/jdk/java/lang/Character/charprop03.bin
- test/jdk/java/lang/Character/charprop0E.bin
- test/jdk/java/lang/Character/charprop0F.bin
- test/jdk/java/lang/Character/charprop10.bin
- test/jdk/java/util/regex/GraphemeBreakProperty.txt
- test/jdk/java/util/regex/GraphemeBreakTest.txt
- test/jdk/sun/management/windows/revokeall.c
- test/jdk/sun/management/windows/revokeall.exe


From shade at redhat.com  Thu May 30 10:35:41 2019
From: shade at redhat.com (shade at redhat.com)
Date: Thu, 30 May 2019 10:35:41 +0000
Subject: hg: shenandoah/jdk11: 23 new changesets
Message-ID: <201905301035.x4UAZhKZ026232@aojmv0008.oracle.com>

Changeset: 2a402ebee58d
Author:    aph
Date:      2019-05-23 07:57 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/2a402ebee58d

8224671: AArch64: mauve System.arraycopy test failure
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/assembler_aarch64.hpp
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp

Changeset: 11e4d9499986
Author:    aph
Date:      2019-05-28 09:13 -0400
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/11e4d9499986

8224880: AArch64: java/javac error with AllocatePrefetchDistance
Reviewed-by: adinn

! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

Changeset: 6057accb1fd3
Author:    mgronlun
Date:      2018-12-13 14:36 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/6057accb1fd3

8215284: Reduce noise induced by periodic task getFileSize()
Reviewed-by: redestad, egahlin

! src/hotspot/share/jfr/jni/jfrJniMethod.cpp
! src/hotspot/share/jfr/jni/jfrJniMethod.hpp
! src/hotspot/share/jfr/jni/jfrJniMethodRegistration.cpp
+ src/hotspot/share/jfr/recorder/repository/jfrChunkRotation.cpp
+ src/hotspot/share/jfr/recorder/repository/jfrChunkRotation.hpp
- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.cpp
- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.hpp
! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp
! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java
! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecorder.java

Changeset: 1389f30c1e0b
Author:    egahlin
Date:      2018-12-08 17:41 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1389f30c1e0b

8213617: JFR should record the PID of the recorded process
Reviewed-by: mgronlun

! src/hotspot/share/jfr/metadata/metadata.xml
! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp
! test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.java

Changeset: 28325061ab64
Author:    ysuenaga
Date:      2018-11-23 16:36 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/28325061ab64

8213015: Inconsistent settings between JFR.configure and -XX:FlightRecorderOptions
Reviewed-by: mgronlun, egahlin

! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp
! src/hotspot/share/jfr/dcmd/jfrDcmds.hpp
! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp
! test/jdk/jdk/jfr/jcmd/TestJcmdConfigure.java

Changeset: 4eb4c556802a
Author:    goetz
Date:      2019-05-22 15:04 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/4eb4c556802a

Merge

- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.cpp
- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.hpp

Changeset: 657c2d544f50
Author:    mbalao
Date:      2018-11-29 13:36 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/657c2d544f50

6913047: Long term memory leak when using PKCS11 and JCE exceeds 32 bit process address space
Summary: Extract cryptographic keys within NSS PKCS11 software tokens for memory management purposes.
Reviewed-by: valeriep

! src/java.base/share/lib/security/default.policy
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DHKeyFactory.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Digest.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECDHKeyAgreement.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11ECKeyFactory.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyAgreement.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Mac.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSACipher.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsMasterSecretGenerator.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java
! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java
! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c
! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h
! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11wrapper.h

Changeset: 90e397c9cce4
Author:    mbalao
Date:      2019-01-15 19:24 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/90e397c9cce4

8217088: Disable JDK-6913047 fix (SunPKCS11 memory leak) after JDK-8216597 (SIGBUS error in getNativeKeyInfo)
Summary: Disable JDK-6913047 fix (SunPKCS11 memory leak) temporarily until JDK-8216597 (SIGBUS error in getNativeKeyInfo) is fixed.
Reviewed-by: mullan

! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java

Changeset: 93adf33b1ab4
Author:    valeriep
Date:      2019-02-20 19:16 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/93adf33b1ab4

8216597: SIGBUS in Java_sun_security_pkcs11_wrapper_PKCS11_getNativeKeyInfo after JDK-6913047
Summary: changed variable declaration type to byte* from long* to fix SIGBUS error
Reviewed-by: ascarpino

! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

Changeset: bc7041ab415e
Author:    mbalao
Date:      2019-04-15 15:52 -0300
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/bc7041ab415e

8220513: Wrapper Key may get deleted when closing sessions in SunPKCS11 crypto provider
Summary: Do not close the session holding the Wrapper Key while in use. Delete the Wrapper Key when no longer needed.
Reviewed-by: valeriep

! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java
! src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_keymgmt.c

Changeset: 1343aecdc170
Author:    mbaesken
Date:      2019-04-10 09:33 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/1343aecdc170

8221915: cleanup ticks related coding in os_perf_aix.cpp [aix]
Reviewed-by: mdoerr

! src/hotspot/os/aix/os_perf_aix.cpp

Changeset: 53f0757193a8
Author:    serb
Date:      2018-08-08 18:31 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/53f0757193a8

8208996: X11 icon window color handing bug
Reviewed-by: serb
Contributed-by: takiguc at linux.vnet.ibm.com

! src/java.desktop/unix/classes/sun/awt/X11/XIconWindow.java

Changeset: 7dd0a5eaeb67
Author:    itakiguchi
Date:      2018-10-30 15:51 -0700
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/7dd0a5eaeb67

8211810: X11 Time stamp data should be unsigned
Reviewed-by: serb

! src/java.desktop/unix/classes/sun/awt/X11/XDnDDropTargetProtocol.java
! src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java

Changeset: 936ef385c63e
Author:    itakiguchi
Date:      2018-11-14 18:04 -0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/936ef385c63e

8213614: DnD operation change feature does not work with 64bit big endian CPU
Reviewed-by: serb

! src/java.desktop/unix/classes/sun/awt/X11/XDragSourceContextPeer.java

Changeset: 601ec8cdb753
Author:    itakiguchi
Date:      2019-01-11 09:37 +0100
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/601ec8cdb753

8211841: [testbug] sun/nio/cs/OLD/TestIBMDB.java does not compile (aix)
Reviewed-by: alanb, goetz

! test/jdk/ProblemList.txt
! test/jdk/sun/nio/cs/OLD/IBM1383_OLD.java
! test/jdk/sun/nio/cs/OLD/IBM942_OLD.java
! test/jdk/sun/nio/cs/OLD/IBM943_OLD.java
! test/jdk/sun/nio/cs/OLD/IBM950_OLD.java
! test/jdk/sun/nio/cs/OLD/IBM970_OLD.java

Changeset: 71a1591b915c
Author:    goetz
Date:      2019-04-04 09:39 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/71a1591b915c

8221470: Print methods in exception messages in java-like Syntax.
Reviewed-by: dholmes, mdoerr, coleenp

! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/interpreter/linkResolver.cpp
! src/hotspot/share/interpreter/linkResolver.hpp
! src/hotspot/share/oops/constantPool.cpp
! src/hotspot/share/oops/klassVtable.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/oops/method.hpp
! src/hotspot/share/oops/symbol.cpp
! src/hotspot/share/oops/symbol.hpp
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/nativeLookup.cpp
! src/hotspot/share/prims/stackwalk.cpp
! src/hotspot/share/runtime/reflection.cpp
! test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java
! test/hotspot/jtreg/runtime/LoaderConstraints/vtableLdrConstraint/Test.java
! test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java
! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestConstructorHierarchy.java
! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java
! test/hotspot/jtreg/runtime/exceptionMsgs/IllegalAccessError/IllegalAccessErrorTest.java
+ test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TeMe3_C.jasm
+ test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TestPrintingMethods.java
! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualToM1PrivateMethodIAE.java

Changeset: f4176fe57b08
Author:    ljiang
Date:      2019-05-19 22:14 +0800
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/f4176fe57b08

8218781: Localized names for Japanese era Reiwa in COMPAT provider
Reviewed-by: naoto

! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ar.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ko.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_th.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_zh.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ar.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_hi_IN.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_hr.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_in.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ko.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_lt.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_nl.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_no.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ru.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sr.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sr_Latn.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_sv.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_th.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_zh.java
! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_zh_TW.java
+ test/jdk/java/util/Calendar/JapanEraNameCompatTest.java

Changeset: eb1e977b8126
Author:    aivanov
Date:      2019-03-28 18:51 +0000
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/eb1e977b8126

8217707: JNICALL declaration breaks Splash screen functions
Reviewed-by: prr, stuefe

! src/java.desktop/share/native/libsplashscreen/splashscreen_impl.c
! src/java.desktop/share/native/libsplashscreen/splashscreen_impl.h
! src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c
! src/java.desktop/windows/native/libsplashscreen/splashscreen_sys.c

Changeset: 365ae6cee007
Author:    ysuenaga
Date:      2019-05-17 14:14 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/365ae6cee007

8223665: SA: debugd options should follow jhsdb style
Reviewed-by: dholmes, sspitsyn, ysuenaga, jcbeyler
Contributed-by: Osamu Sakamoto <sakamoto.osamu at nttcom.co.jp>

! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java

Changeset: 371ce104ac19
Author:    ysuenaga
Date:      2019-05-28 22:49 +0900
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/371ce104ac19

8163805: hotspot/test/serviceability/sa/sadebugd/SADebugDTest.java failed with timed out
Reviewed-by: cjplummer, jcbeyler

! test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java

Changeset: 3594cd8691f2
Author:    goetz
Date:      2019-05-28 18:37 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/3594cd8691f2

Added tag jdk-11.0.4+5 for changeset 371ce104ac19

! .hgtags

Changeset: 029f5940cb2f
Author:    goetz
Date:      2019-05-30 10:11 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/029f5940cb2f

Merge


Changeset: 87e545ffbce6
Author:    shade
Date:      2019-05-30 12:01 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/87e545ffbce6

Merge

! .hgtags
! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp
! src/hotspot/share/interpreter/linkResolver.cpp
- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.cpp
- src/hotspot/share/jfr/recorder/repository/jfrChunkSizeNotifier.hpp


From rkennke at redhat.com  Thu May 30 11:00:46 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 30 May 2019 13:00:46 +0200
Subject: RFR (11): Streamline CAS barriers, C2 ideal graph generation and
 matching
Message-ID: <afcdbd08-911d-a61c-42b4-07def52e7260@redhat.com>

Recently, I've streamlined the C1 and backend parts of CAS. When doing
the LRB backport to 11, I noticed that should also harmonize C2 ideal
generation and matching for CASes:

http://cr.openjdk.java.net/~rkennke/jdk11-streamline-cas-c2/webrev.00/

As far as I can tell, this makes the relevant code 100% equivalent to
what we have in jdk/jdk. Some changes are required in escape.cpp and
matcher.cpp to do this, we have the exact equivalent in
ShenandoahBarrierSetC2 matcher_* and escape_* methods in jdk/jdk. This
GC interface doesn't exist in 11.

Testing: hotspot_gc_shenandoah aarch64/x86

Can I please get a review?

Roman


From shade at redhat.com  Thu May 30 11:10:14 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 13:10:14 +0200
Subject: RFR (11): Streamline CAS barriers, C2 ideal graph generation and
 matching
In-Reply-To: <afcdbd08-911d-a61c-42b4-07def52e7260@redhat.com>
References: <afcdbd08-911d-a61c-42b4-07def52e7260@redhat.com>
Message-ID: <5047f1bc-24a4-b599-f62c-776de460edaf@redhat.com>

On 5/30/19 1:00 PM, Roman Kennke wrote:
> Recently, I've streamlined the C1 and backend parts of CAS. When doing
> the LRB backport to 11, I noticed that should also harmonize C2 ideal
> generation and matching for CASes:
> 
> http://cr.openjdk.java.net/~rkennke/jdk11-streamline-cas-c2/webrev.00/

Looks fine to me. Roland might want to eyeball?

Hold it off until we clear and push shenandoah-jdk-11.0.4+5 tag in the evening?

-Aleksey


From rkennke at redhat.com  Thu May 30 11:18:12 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 30 May 2019 13:18:12 +0200
Subject: RFR (11): Streamline CAS barriers, C2 ideal graph generation and
 matching
In-Reply-To: <5047f1bc-24a4-b599-f62c-776de460edaf@redhat.com>
References: <afcdbd08-911d-a61c-42b4-07def52e7260@redhat.com>
 <5047f1bc-24a4-b599-f62c-776de460edaf@redhat.com>
Message-ID: <6d4e31fa-b53f-8edd-0652-0b6af1887364@redhat.com>

>> Recently, I've streamlined the C1 and backend parts of CAS. When doing
>> the LRB backport to 11, I noticed that should also harmonize C2 ideal
>> generation and matching for CASes:
>>
>> http://cr.openjdk.java.net/~rkennke/jdk11-streamline-cas-c2/webrev.00/
> 
> Looks fine to me. Roland might want to eyeball?
> 
> Hold it off until we clear and push shenandoah-jdk-11.0.4+5 tag in the evening?
> 

I will surely wait for Roland, which would be early next week I suppose.

Roman


From shade at redhat.com  Thu May 30 11:44:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 13:44:37 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
Message-ID: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>

http://cr.openjdk.java.net/~shade/8225048/webrev.01/

Some history: Shenandoah used to support x86_32 in "passive" mode long time ago. This mode relies
only on stop-the-world GC to avoid implementing barriers (basically, runs Degenerated GC all the
time). It was an interesting mode to see the footprint numbers you can get with uncommits and
slimmer native pointers with really small microservice-size VMs. This mode was dropped before
integration upstream, because many Shenandoah tests expect all heuristics/modes to work properly,
and having the rudimentary x86_32 support was breaking tier1 tests. So we disabled it.

Today, we have significantly simplified runtime interface thanks to LRB and elimination of separate
forwarding pointer slot, and we can build the fully concurrent x86_32 with ease. This allows us to
maintain 32-bit cleanness in Shenandoah code, plus serves as the proof of concept that Shenandoah
can be implemented on 32-bit platform.

I am planning to backport this all the way to 8u, once other improvements are backported, so keeping
the patch simple is paramount.

A brief tour of changes:

 *) One minor change in build config to accept both x86_32 and x86_64 (therefore, cc'ing build-dev);
this is the same check we had before reversal in jdk12;

 *) C1 changes need to disambiguate for single/double-cpu slots in CAS, this is the same other
BarrierSets do;

 *) C2 changes need shenandoah_x86_32.ad to carry adapters for CAS barriers, plus accept
StoreIConditional for raw ptr stores on some paths.

 *) SBSAssembler change reshuffles _LP64 checks to enable x86_32 paths. It needs to deal with
UseCompressedOops blocks, getting threads into a separate register, etc.;

 *) Test changes enable running them on x86_32, and generally 32-bit platforms -- I can split them
out, but they make little sense on their own, without having the product code that actually uses them;

Builds: {x86_32, x86_64} with/without PCH; other platform builds in CI
Testing: hotspot_gc_shenandoah, CTW tests, jcstress, ad-hoc footprint experiments

IIRC, Oracle does not build either x86_32 or Shenandoah, so I did not run it through jdk-submit.

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Thu May 30 12:14:14 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Thu, 30 May 2019 14:14:14 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
Message-ID: <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>

The changes look good to me. Thanks!!

Roman

> http://cr.openjdk.java.net/~shade/8225048/webrev.01/
> 
> Some history: Shenandoah used to support x86_32 in "passive" mode long time ago. This mode relies
> only on stop-the-world GC to avoid implementing barriers (basically, runs Degenerated GC all the
> time). It was an interesting mode to see the footprint numbers you can get with uncommits and
> slimmer native pointers with really small microservice-size VMs. This mode was dropped before
> integration upstream, because many Shenandoah tests expect all heuristics/modes to work properly,
> and having the rudimentary x86_32 support was breaking tier1 tests. So we disabled it.
> 
> Today, we have significantly simplified runtime interface thanks to LRB and elimination of separate
> forwarding pointer slot, and we can build the fully concurrent x86_32 with ease. This allows us to
> maintain 32-bit cleanness in Shenandoah code, plus serves as the proof of concept that Shenandoah
> can be implemented on 32-bit platform.
> 
> I am planning to backport this all the way to 8u, once other improvements are backported, so keeping
> the patch simple is paramount.
> 
> A brief tour of changes:
> 
>  *) One minor change in build config to accept both x86_32 and x86_64 (therefore, cc'ing build-dev);
> this is the same check we had before reversal in jdk12;
> 
>  *) C1 changes need to disambiguate for single/double-cpu slots in CAS, this is the same other
> BarrierSets do;
> 
>  *) C2 changes need shenandoah_x86_32.ad to carry adapters for CAS barriers, plus accept
> StoreIConditional for raw ptr stores on some paths.
> 
>  *) SBSAssembler change reshuffles _LP64 checks to enable x86_32 paths. It needs to deal with
> UseCompressedOops blocks, getting threads into a separate register, etc.;
> 
>  *) Test changes enable running them on x86_32, and generally 32-bit platforms -- I can split them
> out, but they make little sense on their own, without having the product code that actually uses them;
> 
> Builds: {x86_32, x86_64} with/without PCH; other platform builds in CI
> Testing: hotspot_gc_shenandoah, CTW tests, jcstress, ad-hoc footprint experiments
> 
> IIRC, Oracle does not build either x86_32 or Shenandoah, so I did not run it through jdk-submit.
> 


From zgu at redhat.com  Thu May 30 12:54:04 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 30 May 2019 08:54:04 -0400
Subject: RFR 8225014: Separate ShenandoahRootScanner method for
 object_iterate
In-Reply-To: <3b3cb71d-8d5d-b480-c654-06fcadc3bfef@redhat.com>
References: <64e54f3d-d0b2-d15e-9a04-64ae89e37ae6@redhat.com>
 <3b3cb71d-8d5d-b480-c654-06fcadc3bfef@redhat.com>
Message-ID: <9c6247ae-3580-877d-362f-f499c89c10e4@redhat.com>



On 5/30/19 5:16 AM, Aleksey Shipilev wrote:
> On 5/30/19 2:52 AM, Zhengyu Gu wrote:
>> Please review this patch that allows SH::object_iterate() invokes ShenandoahRootScanner method
>> without assertion. A regression test is also added.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225014
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225014/webrev.00/
> 
> *) Suggestion for the name "roots_do_no_assert" -> "roots_do_unchecked"
> 
> *) I was thinking that object_iterate should visit the code cache too. Current shared method would
> do that optionally depending on ShenandoahConcurrentScanCodeRoots. Maybe it is cleaner to just do
> the separate "roots_do_all" specifically for heap iteration?
Right.

Updated: http://cr.openjdk.java.net/~zgu/JDK-8225014/webrev.01/index.html

Thanks,

-Zhengyu

> 
> Regression test looks nice.
> 

From erik.joelsson at oracle.com  Thu May 30 13:29:19 2019
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Thu, 30 May 2019 06:29:19 -0700
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
Message-ID: <52336e65-ba7d-891e-921b-eab2cb54bab1@oracle.com>

Build change looks good.

/Erik

On 2019-05-30 04:44, Aleksey Shipilev wrote:
> http://cr.openjdk.java.net/~shade/8225048/webrev.01/
>
> Some history: Shenandoah used to support x86_32 in "passive" mode long time ago. This mode relies
> only on stop-the-world GC to avoid implementing barriers (basically, runs Degenerated GC all the
> time). It was an interesting mode to see the footprint numbers you can get with uncommits and
> slimmer native pointers with really small microservice-size VMs. This mode was dropped before
> integration upstream, because many Shenandoah tests expect all heuristics/modes to work properly,
> and having the rudimentary x86_32 support was breaking tier1 tests. So we disabled it.
>
> Today, we have significantly simplified runtime interface thanks to LRB and elimination of separate
> forwarding pointer slot, and we can build the fully concurrent x86_32 with ease. This allows us to
> maintain 32-bit cleanness in Shenandoah code, plus serves as the proof of concept that Shenandoah
> can be implemented on 32-bit platform.
>
> I am planning to backport this all the way to 8u, once other improvements are backported, so keeping
> the patch simple is paramount.
>
> A brief tour of changes:
>
>   *) One minor change in build config to accept both x86_32 and x86_64 (therefore, cc'ing build-dev);
> this is the same check we had before reversal in jdk12;
>
>   *) C1 changes need to disambiguate for single/double-cpu slots in CAS, this is the same other
> BarrierSets do;
>
>   *) C2 changes need shenandoah_x86_32.ad to carry adapters for CAS barriers, plus accept
> StoreIConditional for raw ptr stores on some paths.
>
>   *) SBSAssembler change reshuffles _LP64 checks to enable x86_32 paths. It needs to deal with
> UseCompressedOops blocks, getting threads into a separate register, etc.;
>
>   *) Test changes enable running them on x86_32, and generally 32-bit platforms -- I can split them
> out, but they make little sense on their own, without having the product code that actually uses them;
>
> Builds: {x86_32, x86_64} with/without PCH; other platform builds in CI
> Testing: hotspot_gc_shenandoah, CTW tests, jcstress, ad-hoc footprint experiments
>
> IIRC, Oracle does not build either x86_32 or Shenandoah, so I did not run it through jdk-submit.
>

From zgu at redhat.com  Thu May 30 15:10:23 2019
From: zgu at redhat.com (Zhengyu Gu)
Date: Thu, 30 May 2019 11:10:23 -0400
Subject: RFR(S) 8224978: Shenandoah: Allows root verifier to verify some
 roots outside safepoints with proper locks
In-Reply-To: <2e2de49d-782a-7966-e6d4-13ec8508b24f@redhat.com>
References: <fe870e62-dd47-17b7-28cf-94724587cefc@redhat.com>
 <2e2de49d-782a-7966-e6d4-13ec8508b24f@redhat.com>
Message-ID: <55d59de5-3b45-9abf-e6c3-21389dcbecce@redhat.com>



On 5/30/19 6:16 AM, Aleksey Shipilev wrote:
> On 5/29/19 6:01 PM, Zhengyu Gu wrote:
>> Please review this patch that allows root verifier to verify CLDG and code roots outside safepoints,
>> with proper locks.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224978
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.00/
> 
> *) Don't we want to demote those checks to "asserts"? Is there a reason to have these checks in
> release bits (and make it pay on tiny root sets)?
> 
> *) Maybe it should be moved to shenandoahAsserts. I think these new definitions:
> 
>   shenandoah_assert_safepoint()
>   shenandoah_assert_locked_or_safepoint(lock)

Updated and retested:
   http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.01/

Thanks,

-Zhengyu

> 
> -Aleksey
> 

From shade at redhat.com  Thu May 30 17:00:37 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 19:00:37 +0200
Subject: RFR 8225014: Separate ShenandoahRootScanner method for
 object_iterate
In-Reply-To: <9c6247ae-3580-877d-362f-f499c89c10e4@redhat.com>
References: <64e54f3d-d0b2-d15e-9a04-64ae89e37ae6@redhat.com>
 <3b3cb71d-8d5d-b480-c654-06fcadc3bfef@redhat.com>
 <9c6247ae-3580-877d-362f-f499c89c10e4@redhat.com>
Message-ID: <ed0e812e-c4f6-7705-1f78-31c80922bbf5@redhat.com>

On 5/30/19 2:54 PM, Zhengyu Gu wrote:
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8225014/webrev.01/index.html

Looks good. Maybe you can drop "worker_id" argument that is always 0. Your call.

-Aleksey


From shade at redhat.com  Thu May 30 17:06:36 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 30 May 2019 19:06:36 +0200
Subject: RFR(S) 8224978: Shenandoah: Allows root verifier to verify some
 roots outside safepoints with proper locks
In-Reply-To: <55d59de5-3b45-9abf-e6c3-21389dcbecce@redhat.com>
References: <fe870e62-dd47-17b7-28cf-94724587cefc@redhat.com>
 <2e2de49d-782a-7966-e6d4-13ec8508b24f@redhat.com>
 <55d59de5-3b45-9abf-e6c3-21389dcbecce@redhat.com>
Message-ID: <7315a095-b85d-f801-fd61-5c727eda3e81@redhat.com>

On 5/30/19 5:10 PM, Zhengyu Gu wrote:
> Updated and retested:
> ? http://cr.openjdk.java.net/~zgu/JDK-8224978/webrev.01/

*) Synopsis is missing "S": "8224978: henandoah: Allows root verifier to verify some roots outside
safepoints with proper locks"

*) This include in shenandoahRootVerifier.cpp is not needed anymore, right?

  36 #include "gc/shenandoah/shenandoahUtils.hpp"

*) Excess capitalization. Suggestion for rewording: "Should be at Shenandoah safepoint":

 132  assert(ShenandoahSafepoint::is_at_shenandoah_safepoint(), "Only at Shenandoah Safepoints");

*) Also here: "Must be at Shenandoah safepoint or hold %s lock":

 375   ShenandoahMessageBuffer msg("Must at a Shenandoah safepoint or held %s lock", lock->name());

Fix it, and the patch is good to go.

-Aleksey


From shade at redhat.com  Fri May 31 07:53:47 2019
From: shade at redhat.com (shade at redhat.com)
Date: Fri, 31 May 2019 07:53:47 +0000
Subject: hg: shenandoah/jdk11: Added tag shenandoah-jdk-11.0.4+5 for changeset
 87e545ffbce6
Message-ID: <201905310753.x4V7rmgA027073@aojmv0008.oracle.com>

Changeset: e312aa268170
Author:    shade
Date:      2019-05-31 09:53 +0200
URL:       http://hg.openjdk.java.net/shenandoah/jdk11/rev/e312aa268170

Added tag shenandoah-jdk-11.0.4+5 for changeset 87e545ffbce6

! .hgtags


From shade at redhat.com  Fri May 31 11:02:46 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 31 May 2019 13:02:46 +0200
Subject: RFR (S) 8225111: Make Shenandoah tests work with 32-bit VMs
Message-ID: <5f8d0549-bcad-8c3f-631f-7109b9e3f4e5@redhat.com>

RFE:
  https://bugs.openjdk.java.net/browse/JDK-8225111

On the second thought, I want to split these test changes from the x86_32 support patch. This allows
other 32-bit targets to work as well, and it would only require to backport this smaller test bunch,
without dragging x86_32 in.

This only touches Shenandoah tests:
  http://cr.openjdk.java.net/~shade/8225111/webrev.01/

Testing: hotspot_gc_shenandoah {fastdebug,release}

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Fri May 31 11:05:44 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 31 May 2019 13:05:44 +0200
Subject: RFR (S) 8225111: Make Shenandoah tests work with 32-bit VMs
In-Reply-To: <5f8d0549-bcad-8c3f-631f-7109b9e3f4e5@redhat.com>
References: <5f8d0549-bcad-8c3f-631f-7109b9e3f4e5@redhat.com>
Message-ID: <ea816731-29a7-b71f-fdbf-2f91018146f8@redhat.com>

Ok. Thanks!
Roman


> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8225111
> 
> On the second thought, I want to split these test changes from the x86_32 support patch. This allows
> other 32-bit targets to work as well, and it would only require to backport this smaller test bunch,
> without dragging x86_32 in.
> 
> This only touches Shenandoah tests:
>   http://cr.openjdk.java.net/~shade/8225111/webrev.01/
> 
> Testing: hotspot_gc_shenandoah {fastdebug,release}
> 


From shade at redhat.com  Fri May 31 11:06:03 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 31 May 2019 13:06:03 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <52336e65-ba7d-891e-921b-eab2cb54bab1@oracle.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
 <52336e65-ba7d-891e-921b-eab2cb54bab1@oracle.com>
Message-ID: <73c875ae-0198-1a23-be64-db8cfa081cc0@redhat.com>

On 5/30/19 3:29 PM, Erik Joelsson wrote:
> Build change looks good.

Thanks, Erik. Not expecting any more build changes, I am going to drop build-dev@ from the following
replies on this thread.

-Aleksey


From shade at redhat.com  Fri May 31 11:07:19 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 31 May 2019 13:07:19 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
 <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>
Message-ID: <5e2083ef-7ac0-d2d4-b578-074fbcfce3c3@redhat.com>

On 5/30/19 2:14 PM, Roman Kennke wrote:
> The changes look good to me. Thanks!!

Thanks! Split out test changes as JDK-8225111, so this patch does only x86_32 parts:
  http://cr.openjdk.java.net/~shade/8225048/webrev.01/

Still passes hotspot_gc_shenandoah.

-Aleksey


From rkennke at redhat.com  Fri May 31 11:09:03 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 31 May 2019 13:09:03 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <5e2083ef-7ac0-d2d4-b578-074fbcfce3c3@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
 <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>
 <5e2083ef-7ac0-d2d4-b578-074fbcfce3c3@redhat.com>
Message-ID: <4b260309-b483-4d47-8f71-9e1befa13988@redhat.com>

>> The changes look good to me. Thanks!!
> 
> Thanks! Split out test changes as JDK-8225111, so this patch does only x86_32 parts:
>   http://cr.openjdk.java.net/~shade/8225048/webrev.01/
> 
> Still passes hotspot_gc_shenandoah.

It's still got plenty of test changes in it.

Roman



From shade at redhat.com  Fri May 31 11:09:57 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 31 May 2019 13:09:57 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <4b260309-b483-4d47-8f71-9e1befa13988@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
 <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>
 <5e2083ef-7ac0-d2d4-b578-074fbcfce3c3@redhat.com>
 <4b260309-b483-4d47-8f71-9e1befa13988@redhat.com>
Message-ID: <5af505b0-cd85-bfd0-fc9e-007ab2680431@redhat.com>

On 5/31/19 1:09 PM, Roman Kennke wrote:
>>> The changes look good to me. Thanks!!
>>
>> Thanks! Split out test changes as JDK-8225111, so this patch does only x86_32 parts:
>>   http://cr.openjdk.java.net/~shade/8225048/webrev.01/
>>
>> Still passes hotspot_gc_shenandoah.
> 
> It's still got plenty of test changes in it.

Dang, wrong link! Here:
 http://cr.openjdk.java.net/~shade/8225048/webrev.02/

-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Fri May 31 11:18:17 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 31 May 2019 13:18:17 +0200
Subject: RFR (M) 8225048: Shenandoah x86_32 support
In-Reply-To: <5af505b0-cd85-bfd0-fc9e-007ab2680431@redhat.com>
References: <4fb7a59f-1ceb-af71-2038-a48ef6366087@redhat.com>
 <ead7cc87-ebb8-637f-d976-bf7f0855d612@redhat.com>
 <5e2083ef-7ac0-d2d4-b578-074fbcfce3c3@redhat.com>
 <4b260309-b483-4d47-8f71-9e1befa13988@redhat.com>
 <5af505b0-cd85-bfd0-fc9e-007ab2680431@redhat.com>
Message-ID: <1ee76bda-f346-397f-495e-e345edd60cd8@redhat.com>

>>>> The changes look good to me. Thanks!!
>>>
>>> Thanks! Split out test changes as JDK-8225111, so this patch does only x86_32 parts:
>>>   http://cr.openjdk.java.net/~shade/8225048/webrev.01/
>>>
>>> Still passes hotspot_gc_shenandoah.
>>
>> It's still got plenty of test changes in it.
> 
> Dang, wrong link! Here:
>  http://cr.openjdk.java.net/~shade/8225048/webrev.02/

This is much cuter indeed :-) Good!

Roman



From rkennke at redhat.com  Fri May 31 14:23:12 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 31 May 2019 16:23:12 +0200
Subject: RFR (11): [backport] 8221766: Load-reference barriers for Shenandoah
Message-ID: <714958c7-635c-f9a7-5804-fc58892d193e@redhat.com>

This is the backport of load-reference-barriers to sh/jdk11. It goes on
top of the recently proposed (and not-yet-pushed) CAS streamlining.

It is a tremendous harmonization in the C1 and C2 barriers sets: I
basically copied over the relevant files from jdk/jdk at the point of
the Load-ref-barriers-change, and retrofitted it to match jdk11.

I have *not* yet backported the LRB-related-bugfixes, yet. Let's start
review on this here, while I'll pile on the followup-bugfixes in the
meantime.

I also went over the sh/jdk11 vs. upstream jdk11u diff and reverted any
change that's not needed anymore (resolve() and equals() stuff for the
most part). It is *much* nicer now. :-) Notably, it makes
oopDesc::unsafe_equals() disappear, and we should do the equivalent in
jdk/jdk to match it.

http://cr.openjdk.java.net/~rkennke/backport-jdk11-JDK-8221766/webrev.00/

Testing: hotspot_gc_shenandoah x86/aarch64

What do you think?

Roman


From shade at redhat.com  Fri May 31 18:25:18 2019
From: shade at redhat.com (Aleksey Shipilev)
Date: Fri, 31 May 2019 20:25:18 +0200
Subject: RFR (11): [backport] 8221766: Load-reference barriers for
 Shenandoah
In-Reply-To: <714958c7-635c-f9a7-5804-fc58892d193e@redhat.com>
References: <714958c7-635c-f9a7-5804-fc58892d193e@redhat.com>
Message-ID: <5fb48ec6-6d6f-115d-5f8b-f83801ebbc8d@redhat.com>

On 5/31/19 4:23 PM, Roman Kennke wrote:
> This is the backport of load-reference-barriers to sh/jdk11. It goes on
> top of the recently proposed (and not-yet-pushed) CAS streamlining.
> 
> It is a tremendous harmonization in the C1 and C2 barriers sets: I
> basically copied over the relevant files from jdk/jdk at the point of
> the Load-ref-barriers-change, and retrofitted it to match jdk11.
> 
> I have *not* yet backported the LRB-related-bugfixes, yet. Let's start
> review on this here, while I'll pile on the followup-bugfixes in the
> meantime.
> 
> I also went over the sh/jdk11 vs. upstream jdk11u diff and reverted any
> change that's not needed anymore (resolve() and equals() stuff for the
> most part). It is *much* nicer now. :-) Notably, it makes
> oopDesc::unsafe_equals() disappear, and we should do the equivalent in
> jdk/jdk to match it.

Yeah, and I have a bit of reservation about that, seeing the stuff that is changed. It is probably
fine to include in LRB backport, as it would be the jdk11u-specific (and later jdk8u-specific)
change later anyway.

> http://cr.openjdk.java.net/~rkennke/backport-jdk11-JDK-8221766/webrev.00/

First look:

*) src/hotspot/share/ci/ciObjectFactory.cpp
  I don't see sh/jdk11 change that needs to be reverted...

*) src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
  This is needed why? I don't see it used in Shenandoah code anywhere. There is a definition in
src/hotspot/share/gc/shared/c1/barrierSetC1.cpp, though.

  34 #ifndef PATCHED_ADDR
  35 #define PATCHED_ADDR  (max_jint)
  36 #endif

*) src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
 This breaks Solaris. (also, see other enums?)

  47     ShenandoahNone,
  48   };

*) src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
 This thing looks like the accidental backport of pre-evac-ing all roots.

*) src/hotspot/share/opto/mulnode.cpp
 This does not seem related to LRB all that much. We'd need to see if matcher still matches
fastpaths right.


-- 
Thanks,
-Aleksey


From rkennke at redhat.com  Fri May 31 19:39:39 2019
From: rkennke at redhat.com (Roman Kennke)
Date: Fri, 31 May 2019 21:39:39 +0200
Subject: RFR (11): [backport] 8221766: Load-reference barriers for
 Shenandoah
In-Reply-To: <5fb48ec6-6d6f-115d-5f8b-f83801ebbc8d@redhat.com>
References: <714958c7-635c-f9a7-5804-fc58892d193e@redhat.com>
 <5fb48ec6-6d6f-115d-5f8b-f83801ebbc8d@redhat.com>
Message-ID: <6f85fc7f-34d0-49c3-eccf-4f24573ebd59@redhat.com>

>> This is the backport of load-reference-barriers to sh/jdk11. It goes on
>> top of the recently proposed (and not-yet-pushed) CAS streamlining.
>>
>> It is a tremendous harmonization in the C1 and C2 barriers sets: I
>> basically copied over the relevant files from jdk/jdk at the point of
>> the Load-ref-barriers-change, and retrofitted it to match jdk11.
>>
>> I have *not* yet backported the LRB-related-bugfixes, yet. Let's start
>> review on this here, while I'll pile on the followup-bugfixes in the
>> meantime.
>>
>> I also went over the sh/jdk11 vs. upstream jdk11u diff and reverted any
>> change that's not needed anymore (resolve() and equals() stuff for the
>> most part). It is *much* nicer now. :-) Notably, it makes
>> oopDesc::unsafe_equals() disappear, and we should do the equivalent in
>> jdk/jdk to match it.
> 
> Yeah, and I have a bit of reservation about that, seeing the stuff that is changed. It is probably
> fine to include in LRB backport, as it would be the jdk11u-specific (and later jdk8u-specific)
> change later anyway.

Yeah, I wasn't sure either.

>> http://cr.openjdk.java.net/~rkennke/backport-jdk11-JDK-8221766/webrev.00/
> 
> First look:
> 
> *) src/hotspot/share/ci/ciObjectFactory.cpp
>   I don't see sh/jdk11 change that needs to be reverted...

Oops, I accidentally changed that. Will remove it in next patch.

> *) src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp
>   This is needed why? I don't see it used in Shenandoah code anywhere. There is a definition in
> src/hotspot/share/gc/shared/c1/barrierSetC1.cpp, though.
> 
>   34 #ifndef PATCHED_ADDR
>   35 #define PATCHED_ADDR  (max_jint)
>   36 #endif


Uh, dunno. This came from jdk/jdk version. Should be removed from there
and then trickle down?

> *) src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp
>  This breaks Solaris. (also, see other enums?)
> 
>   47     ShenandoahNone,
>   48   };

Arg, this happened because I copied from pre-Solaris change. Will fix.

> *) src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp
>  This thing looks like the accidental backport of pre-evac-ing all roots.

Yes, but some of it was part of original LRB change, and the rest is
needed to make it work (e.g. the CLD evacing, because jdk11 doesn't have
the barrier hooks to deal with CLD otherwise).

> *) src/hotspot/share/opto/mulnode.cpp
>  This does not seem related to LRB all that much. We'd need to see if matcher still matches
> fastpaths right.

Hmm, right. Will revert.

Will compile the changes later this weekend and post new webrev then.

Thanks for looking!

Roman